Re: [dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit

2018-04-28 Thread Arnon Warshavsky
So will it fail checkpatch in patchwork? I agree with Aaron and Anatoly > that patches with rte_panic/exit should flag some warning message, but > the maintainer should have final say. I don't think failing checkpatch > is the solution for that. > Ok. will leave that to the maintainers and change t

Re: [dpdk-dev] [PATCH v2 1/3] net/mlx4: fix Rx resource leak in case of error

2018-04-28 Thread Shahaf Shuler
Thursday, April 26, 2018 7:26 PM, Adrien Mazarguil: > Subject: [PATCH v2 1/3] net/mlx4: fix Rx resource leak in case of error > > When creation of a flow rule fails during dev_start(), the usage count of the > common RSS context is not decremented, which triggers an assertion failure > in debug mo

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix flow director rule deletion crash

2018-04-28 Thread Shahaf Shuler
Friday, April 27, 2018 9:55 AM, Nélio Laranjeiro: > Subject: Re: [PATCH v1] net/mlx5: fix flow director rule deletion crash > > On Thu, Apr 26, 2018 at 06:17:46PM +0200, Adrien Mazarguil wrote: > > Flow director rules matching traffic properties above layer 2 do not > > target a fixed hash Rx queu

[dpdk-dev] [PATCH v5] net/i40e: fix disabling promiscuous mode

2018-04-28 Thread Rosen Xu
v5 updates: === - Modificate some comments for this patch v4 updates: === - Add some comments for this patch v3 updates: === - Move modification from device close to device disable - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous, so unicast/

[dpdk-dev] [PATCH v2] net/i40e: fix missing some offload capabilities

2018-04-28 Thread Yanglong Wu
MULTI_SEGS and JUMBO_FRAME offload capability should be exposed both VF and PF since i40e does support it. Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API") Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Yanglong Wu --- v2: rework fix line --- driv

Re: [dpdk-dev] [PATCH v3 2/2] mem: revert to using flock() and add per-segment lockfiles

2018-04-28 Thread Andrew Rybchenko
On 04/25/2018 01:36 PM, Anatoly Burakov wrote: The original implementation used flock() locks, but was later switched to using fcntl() locks for page locking, because fcntl() locks allow locking parts of a file, which is useful for single-file segments mode, where locking the entire file isn't as

Re: [dpdk-dev] [PATCH v6 07/16] ethdev: flatten RSS configuration in flow API

2018-04-28 Thread Peng, Yuan
Hi,Adrien Mazarguil There is a bug of queue region with 18.05-rc1 The test steps are as below: ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 ./x86_64-native-linuxapp-gcc/app/testpmd -c 1 -n 4 -- -i --rxq=16 --txq=16 testpmd> port config all rss all Configuration of RSS hash at ethernet port 0