[dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-22 Thread Anoob Joseph
Removing redundant strncmp in parsing long arguments. The getopt library provides means to identify long options using the "val" field of structure option. The existing code gets 0 as "val" for all long arguments and then uses strncmp to figure out which long option was being referred to. Fixing th

Re: [dpdk-dev] [PATCH] net/bnxt: Fix bug with duplicate filter pattern for flow director

2018-03-22 Thread Somnath Kotur
Hi Ferruh, On Fri, Mar 23, 2018 at 12:16 AM, Ferruh Yigit wrote: > On 2/22/2018 2:58 AM, Somnath Kotur wrote: > > Please start with lowercase after "net/bnxt: fix" > > > When user reissues same flow director cmd with a different queue > > update the existing filter to redirect flow to the new d

[dpdk-dev] [PATCH v2 2/2] vhost: add fdset-event thread name

2018-03-22 Thread xiangxia . m . yue
From: Tonghao Zhang This patch adds the name for vhost fdset thread. It can help us to know whether the thread is running. Signed-off-by: Tonghao Zhang Reviewed-by: Jianfeng Tan --- lib/librte_vhost/socket.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_vhost/socket.

[dpdk-dev] [PATCH v2 1/2] vhost: make sure vhost fdset-thread created successfully

2018-03-22 Thread xiangxia . m . yue
From: Tonghao Zhang When first call the 'rte_vhost_driver_start', the fdset_event_dispatch thread should be created successfully. Because the vhost uses it to poll socket events for vhost server or clients. Without it, for example, vhost will not get the connection event. This patch returns err

Re: [dpdk-dev] [PATCH 1/2] vhost: make sure vhost fdset-thread created successfully

2018-03-22 Thread Tonghao Zhang
On Fri, Mar 23, 2018 at 9:30 AM, Tan, Jianfeng wrote: > Hi Xiangxia, > >> -Original Message- >> From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] >> Sent: Thursday, March 22, 2018 8:40 PM >> To: Tan, Jianfeng >> Cc: dev@dpdk.org; Tonghao Zhang >> Subject: [PATCH 1/2] vhost:

Re: [dpdk-dev] [PATCH 2/2] vhost: add fdset-event thread name

2018-03-22 Thread Tan, Jianfeng
> -Original Message- > From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] > Sent: Thursday, March 22, 2018 8:40 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Tonghao Zhang > Subject: [PATCH 2/2] vhost: add fdset-event thread name > > From: Tonghao Zhang > > This patch adds t

Re: [dpdk-dev] [PATCH v2] net/i40e: fix flow RSS configuration error

2018-03-22 Thread Zhao1, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, March 22, 2018 8:39 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: RE: [PATCH v2] net/i40e: fix flow RSS configuration error > > > > > -Original Message- > > From: Zhao1, Wei > > Sent: Wednesday, March 21, 2018 3:25 PM >

Re: [dpdk-dev] [PATCH 1/2] vhost: make sure vhost fdset-thread created successfully

2018-03-22 Thread Tan, Jianfeng
Hi Xiangxia, > -Original Message- > From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] > Sent: Thursday, March 22, 2018 8:40 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Tonghao Zhang > Subject: [PATCH 1/2] vhost: make sure vhost fdset-thread created > successfully > > From: T

Re: [dpdk-dev] [PATCH v2 04/18] eal: add lightweight kvarg parsing utility

2018-03-22 Thread Neil Horman
On Thu, Mar 22, 2018 at 05:27:51PM +0100, Gaëtan Rivet wrote: > On Thu, Mar 22, 2018 at 10:10:37AM -0400, Neil Horman wrote: > > On Wed, Mar 21, 2018 at 05:32:24PM +, Wiles, Keith wrote: > > > > > > > > > > On Mar 21, 2018, at 12:15 PM, Gaetan Rivet > > > > wrote: > > > > > > > > This libr

Re: [dpdk-dev] [PATCH] eal: list acceptable init priorities

2018-03-22 Thread Neil Horman
On Thu, Mar 22, 2018 at 04:58:24PM +0100, Gaetan Rivet wrote: > Build a central list to quickly see each used priorities for > constructors, allowing to verify that they are both above 100 and in the > proper order. > > Cc: Neil Horman > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common

Re: [dpdk-dev] [PATCH v2 01/18] eal: introduce dtor macros

2018-03-22 Thread Neil Horman
On Thu, Mar 22, 2018 at 04:56:43PM +0100, Gaëtan Rivet wrote: > On Thu, Mar 22, 2018 at 09:51:14AM -0400, Neil Horman wrote: > > On Wed, Mar 21, 2018 at 06:15:22PM +0100, Gaetan Rivet wrote: > > > Signed-off-by: Gaetan Rivet > > > --- > > > lib/librte_eal/common/include/rte_common.h | 23

Re: [dpdk-dev] [PATCH v2] net/mlx5: setup RSS regardless of queue count

2018-03-22 Thread Yongseok Koh
> On Mar 21, 2018, at 5:47 AM, Nelio Laranjeiro > wrote: > > From: Dahir Osman > > In some environments it is desirable to have the NIC perform RSS > normally on the packet regardless of the number of queues configured. > The RSS hash result that is stored in the mbuf can then be used by > th

Re: [dpdk-dev] [PATCH] net/bnxt: Fix bug with duplicate filter pattern for flow director

2018-03-22 Thread Ferruh Yigit
On 2/22/2018 2:58 AM, Somnath Kotur wrote: Please start with lowercase after "net/bnxt: fix" > When user reissues same flow director cmd with a different queue > update the existing filter to redirect flow to the new desired > queue as destination just like the other filters like 5 tuple and > ge

Re: [dpdk-dev] [PATCH] event/octeontx: support device stop flush callback

2018-03-22 Thread Eads, Gage
Looks good. Acked-by: Gage Eads > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, March 20, 2018 7:00 AM > To: dev@dpdk.org > Cc: Eads, Gage ; Van Haaren, Harry > ; hemant.agra...@nxp.com; > pbhagavat...@caviumnetworks.com; nipun.gu...@nxp.

[dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-03-22 Thread Ferruh Yigit
It is not clear if tap PMD supports queue specific offloads, removing the related code. Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") Cc: mo...@mellanox.com Signed-off-by: Ferruh Yigit --- Cc: Shahaf Shuler --- drivers/net/tap

[dpdk-dev] [PATCH] net/mrvl: fix build error with gcc

2018-03-22 Thread Ferruh Yigit
gcc version: aarch64-linux-gnu-gcc (Linaro GCC 7.2-2017.11) 7.2.1 20171011 build error: CC mrvl_qos.o .../drivers/net/mrvl/mrvl_qos.c: In function ‘mrvl_configure_rxqs’: .../drivers/net/mrvl/mrvl_qos.c:679:17: error: ‘sprintf’ may write a terminating nul past the end of the destinatio

[dpdk-dev] [PATCH] doc: sort qede feature list

2018-03-22 Thread Ferruh Yigit
Sort list to be same order as default.ini. No value changed. Signed-off-by: Ferruh Yigit --- --- doc/guides/nics/features/qede.ini | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/features/qede.ini b/doc/guides/nics/features/qede.ini index 13e34ae33

Re: [dpdk-dev] [PATCH] net/bonding: switch to new offloading flags

2018-03-22 Thread Ferruh Yigit
On 3/14/2018 12:50 PM, Matan Azrad wrote: > Questions: > Have you an idea why bonding PMD doesn't adjust the slaves port > configurations to the bonding port configuration like he does for slave queue > configuration? > Is the responsibility to fill the slave port configuration structure for the

[dpdk-dev] [PATCH v2] net/bonding: switch to new offloading API

2018-03-22 Thread Ferruh Yigit
Switch to new ethdev offloading API. Signed-off-by: Ferruh Yigit --- Cc: Radu Nicolau Cc: Matan Azrad v2: * added [rt]x_queue_offload_capa to driver internal struct * increased [rt]x_offload_capa size to 64bit as same as ethdev --- drivers/net/bonding/rte_eth_bond_api.c | 9 - dr

Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.5

2018-03-22 Thread Ferruh Yigit
On 3/1/2018 11:20 PM, Lee Roberts wrote: > Fix kni compilation under RHEL 7.5. > > Signed-off-by: Lee Roberts Acked-by: Ferruh Yigit (Not tested on RHEL 7.5 but code looks good) Following patch title can be used for compatibility with old commits: "kni: fix build on RHEL 7.5"

Re: [dpdk-dev] [PATCH] eal: abstract away the auxiliary vector

2018-03-22 Thread Aaron Conole
"Wiles, Keith" writes: >> On Mar 22, 2018, at 10:35 AM, Aaron Conole wrote: >> >> Rather than attempting to load the contents of the auxv directly, >> prefer to use an exposed API - and if that doesn't exist then attempt >> to load the vector. This is because on some systems, when a user >> is

Re: [dpdk-dev] [PATCH v2 3/3] net/ifcvf: add ifcvf driver

2018-03-22 Thread Wang, Xiao W
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, March 22, 2018 4:51 PM > To: Wang, Xiao W ; maxime.coque...@redhat.com; > y...@fridaylinux.org > Cc: dev@dpdk.org; Wang, Zhihong ; Bie, Tiwei > ; Chen, Junjie J ; Xu, Rosen > ; Daly, Dan ; Liang, Cunming > ; Burakov, A

Re: [dpdk-dev] [PATCH v6] eal: provide API for querying valid socket id's

2018-03-22 Thread gowrishankar muthukrishnan
On Thursday 22 March 2018 06:06 PM, Anatoly Burakov wrote: During lcore scan, find all socket ID's and store them, and provide public API to query valid socket id's. This will break the ABI, so bump ABI version. Signed-off-by: Anatoly Burakov Acked-by: Gowrishankar Muthukrishnan Thanks, Gowr

Re: [dpdk-dev] [dpdk-stable] [PATCH] pci: remove duplicated symbol from map file

2018-03-22 Thread Thomas Monjalon
15/03/2018 18:21, Gaëtan Rivet: > Hi Ferruh, > > On Thu, Mar 15, 2018 at 04:48:54PM +, Ferruh Yigit wrote: > > Remove duplicated symbol rte_pci_device_name from .map file. > > > > Also sort the map file to be able to detect any possible duplication > > easier in the future. > > > > Fixes: 0e

Re: [dpdk-dev] [PATCH v7] kernel folder for Linux and BSD modules

2018-03-22 Thread Thomas Monjalon
22/02/2018 07:09, Hemant Agrawal: > This patch moves the kernel modules code from EAL to a common place. > - Separate the kernel module code from user space code. > > Signed-off-by: Hemant Agrawal > Tested-by: Bruce Richardson Applied, thanks

Re: [dpdk-dev] [PATCH v2 04/18] eal: add lightweight kvarg parsing utility

2018-03-22 Thread Gaëtan Rivet
On Thu, Mar 22, 2018 at 10:10:37AM -0400, Neil Horman wrote: > On Wed, Mar 21, 2018 at 05:32:24PM +, Wiles, Keith wrote: > > > > > > > On Mar 21, 2018, at 12:15 PM, Gaetan Rivet wrote: > > > > > > This library offers a quick way to parse parameters passed with a > > > key=value syntax. > >

Re: [dpdk-dev] [PATCH] eal: abstract away the auxiliary vector

2018-03-22 Thread Wiles, Keith
> On Mar 22, 2018, at 10:35 AM, Aaron Conole wrote: > > Rather than attempting to load the contents of the auxv directly, > prefer to use an exposed API - and if that doesn't exist then attempt > to load the vector. This is because on some systems, when a user > is downgraded, the /proc/self/a

[dpdk-dev] [PATCH] eal: list acceptable init priorities

2018-03-22 Thread Gaetan Rivet
Build a central list to quickly see each used priorities for constructors, allowing to verify that they are both above 100 and in the proper order. Cc: Neil Horman Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_log.c | 2 +- lib/librte_eal/common/include/rte_bus.h| 2 +

Re: [dpdk-dev] [PATCH v2 01/18] eal: introduce dtor macros

2018-03-22 Thread Gaëtan Rivet
On Thu, Mar 22, 2018 at 09:51:14AM -0400, Neil Horman wrote: > On Wed, Mar 21, 2018 at 06:15:22PM +0100, Gaetan Rivet wrote: > > Signed-off-by: Gaetan Rivet > > --- > > lib/librte_eal/common/include/rte_common.h | 23 +++ > > 1 file changed, 23 insertions(+) > > > > diff --gi

[dpdk-dev] [PATCH] eal: abstract away the auxiliary vector

2018-03-22 Thread Aaron Conole
Rather than attempting to load the contents of the auxv directly, prefer to use an exposed API - and if that doesn't exist then attempt to load the vector. This is because on some systems, when a user is downgraded, the /proc/self/auxv file retains the old ownership and permissions. The original

Re: [dpdk-dev] i40e mbuf->rss indication

2018-03-22 Thread Bruce Richardson
On Thu, Mar 22, 2018 at 12:52:30PM +, Hanoch Haim (hhaim) wrote: > Hi, > I think this is not the vector driver because I'm user scatter/gather > Vector driver has supported multi-buffer packets for a while now, so it should be used for packet RX in i40e in just about all cases. If possible

Re: [dpdk-dev] Add option to dpdk-devbind.py to restore kernel driver binding

2018-03-22 Thread Burakov, Anatoly
On 22-Mar-18 1:41 PM, Tosatti, Giovanni wrote: Hi all, I'm new to this list. I have a use case that required me to do a small enhancement to the dpdk-devbind.py script. In particular I found very useful to have a --restore option that will unbind all devices currently bound to DPDK PMDs back to

Re: [dpdk-dev] [PATCH v3 3/5] vhost: add apis for datapath configuration

2018-03-22 Thread Maxime Coquelin
Hi, On 03/22/2018 09:22 AM, Wang, Zhihong wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Thursday, March 22, 2018 5:08 AM To: Wang, Zhihong ; dev@dpdk.org Cc: Tan, Jianfeng ; Bie, Tiwei ; y...@fridaylinux.org; Liang, Cunming ; Wang, Xiao W ;

Re: [dpdk-dev] [PATCH v2 04/18] eal: add lightweight kvarg parsing utility

2018-03-22 Thread Neil Horman
On Wed, Mar 21, 2018 at 05:32:24PM +, Wiles, Keith wrote: > > > > On Mar 21, 2018, at 12:15 PM, Gaetan Rivet wrote: > > > > This library offers a quick way to parse parameters passed with a > > key=value syntax. > > > > A single function is needed and finds the relevant element within the

Re: [dpdk-dev] [PATCH v3 1/7] ethdev: introduce Tx generic tunnel L3/L4 offload

2018-03-22 Thread Xueming(Steven) Li
> -Original Message- > From: Yongseok Koh > Sent: Wednesday, March 21, 2018 9:41 AM > To: Xueming(Steven) Li > Cc: Wenzhuo Lu ; Jingjing Wu ; > Thomas Monjalon ; Olivier MATZ > ; Shahaf Shuler ; Ferruh > Yigit ; dev@dpdk.org > Subject: Re: [PATCH v3 1/7] ethdev: introduce Tx generic tunn

Re: [dpdk-dev] [PATCH v2 01/18] eal: introduce dtor macros

2018-03-22 Thread Neil Horman
On Wed, Mar 21, 2018 at 06:15:22PM +0100, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/include/rte_common.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/lib/librte_eal/common/include/rte_common.h > b/lib/librte_eal/common/i

[dpdk-dev] Add option to dpdk-devbind.py to restore kernel driver binding

2018-03-22 Thread Tosatti, Giovanni
Hi all, I'm new to this list. I have a use case that required me to do a small enhancement to the dpdk-devbind.py script. In particular I found very useful to have a --restore option that will unbind all devices currently bound to DPDK PMDs back to the kernel driver. The patch is in attachment...

[dpdk-dev] [PATCH v3 5/5] net/ixgbe: remove the unnecessary call rte_intr_enable.

2018-03-22 Thread xiangxia . m . yue
From: Tonghao Zhang When binding the ixgbe pf or vf to vfio and call the rte_eth_dev_rx_intr_enable frequently, the interrupt setting (msi_set_mask_bit) will take more CPU as show below. rte_intr_enable calls the ioctl to map the fd to interrupts frequently. perf top: 5.45% [kernel] [k] msi_s

[dpdk-dev] [PATCH v3 4/5] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance.

2018-03-22 Thread xiangxia . m . yue
From: Tonghao Zhang If dpdk APPs call the rte_eth_dev_rx_intr_enable or rte_eth_dev_rx_intr_disable frequently, and ixgbe vf will read the IXGBE_VTEIMS register everytime. The patch saves the IXGBE_VTEIMS to mask to avoid read frequently. Signed-off-by: Tonghao Zhang Acked-by: Beilei Xing Acke

[dpdk-dev] [PATCH v3 3/5] net/ixgbe: write disable to ITR counter.

2018-03-22 Thread xiangxia . m . yue
From: Tonghao Zhang ixgbe doesn't write the ITR counter, disable it now. Signed-off-by: Tonghao Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 14296ea..0e

[dpdk-dev] [PATCH v3 2/5] net/ixgbe: set the ITR via configuration.

2018-03-22 Thread xiangxia . m . yue
From: Tonghao Zhang With this patch, the ITR value of ixgbe PF, can be configured as wanted. Signed-off-by: Tonghao Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 + drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/i

[dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt interval for EITR.

2018-03-22 Thread xiangxia . m . yue
From: Tonghao Zhang Set EITR interval as default. This patch can improve the performance when we enable the rx-intrrupt to process the packets because we hope rx-intrrupt reduce CPU. For example, the 200us value of EITR makes the performance better with the low CPU. Users can configure the value

[dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve.

2018-03-22 Thread xiangxia . m . yue
From: Tonghao Zhang The patches in the patchset have no dependency. But all of them is about ixgbe or ixgbevf. The patch 1 and 2 add the itr configuration for ixgbe and ixgbevf, the user and developer can configure it for their platform. Other patches refine the ixgbe or ixgbevf. v2 --> v3: remo

Re: [dpdk-dev] Question for queue_start

2018-03-22 Thread Thomas Monjalon
22/03/2018 13:27, Ananyev, Konstantin: > Hi Qi, > > > >Hi: > > In rte_eth_dev_rx|tx_queue_start, dev_started is not checked > > > > Which mean we can call > > Rte_eth_rx_queue_setup > > Rte_eth_rx_qeueu_start > > > > And what we expected is

[dpdk-dev] [PATCH] ethdev: fix queue start

2018-03-22 Thread Qi Zhang
Device must be started before start any queue. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- lib/librte_ether/rte_ethdev.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rt

Re: [dpdk-dev] i40e mbuf->rss indication

2018-03-22 Thread Hanoch Haim (hhaim)
Hi, I think this is not the vector driver because I'm user scatter/gather Thanks, Hanoh -Original Message- From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Thursday, March 22, 2018 2:18 PM To: Hanoch Haim (hhaim); Bruce Richardson Cc: dev@dpdk.org Subject: Re: [dpdk-dev] i40e

[dpdk-dev] [PATCH 2/2] vhost: add fdset-event thread name

2018-03-22 Thread xiangxia . m . yue
From: Tonghao Zhang This patch adds the name for vhost fdset thread. It can help us to know whether the thread is running. Signed-off-by: Tonghao Zhang --- lib/librte_vhost/socket.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket

[dpdk-dev] [PATCH 1/2] vhost: make sure vhost fdset-thread created successfully

2018-03-22 Thread xiangxia . m . yue
From: Tonghao Zhang When first call the 'rte_vhost_driver_start', the fdset_event_dispatch thread should be created successfully. Because the vhost uses it to poll socket events for vhost server or clients. Without it, for example, vhost will not get the connection event. This patch returns err

Re: [dpdk-dev] [PATCH v2] net/i40e: fix flow RSS configuration error

2018-03-22 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, March 21, 2018 3:25 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH v2] net/i40e: fix flow RSS configuration error > > I40e need a protection for rss rule flow configuration after one rule is set > for a

[dpdk-dev] [PATCH v6] eal: provide API for querying valid socket id's

2018-03-22 Thread Anatoly Burakov
During lcore scan, find all socket ID's and store them, and provide public API to query valid socket id's. This will break the ABI, so bump ABI version. Signed-off-by: Anatoly Burakov --- Notes: v6: - Fixed meson ABI version header v5: - Move API to experimental - Store

Re: [dpdk-dev] mlx5 reta size is dynamic

2018-03-22 Thread Hanoch Haim (hhaim)
Regarding #2 For some reason the "rte_eth_dev_rss_reta_update" API didn't make a change for Intel NIC if it was called *before* start. (weird I agree) Moving it after start API solve the issue for all the drivers .. Thanks, Hanoh -Original Message- From: Nélio Laranjeiro [mailto:nelio.

Re: [dpdk-dev] mlx5 reta size is dynamic

2018-03-22 Thread Nélio Laranjeiro
Hi, On Thu, Mar 22, 2018 at 10:59:36AM +, Hanoch Haim (hhaim) wrote: > Hi, > > 1) Regarding this sentence, > "Your need is to have a fixed size returned by the > rte_eth_dev_info_get(), the PMD can have an internal dynamic size, it > won't modify your spreading." > > I'm fine with that as l

Re: [dpdk-dev] Question for queue_start

2018-03-22 Thread Ananyev, Konstantin
Hi Qi, >Hi: >   In rte_eth_dev_rx|tx_queue_start, dev_started is not checked > >  Which mean we can call   > Rte_eth_rx_queue_setup > Rte_eth_rx_qeueu_start > > And what we expected is the queue is started while device is still >stopped, does th

[dpdk-dev] Question for queue_start

2018-03-22 Thread Zhang, Qi Z
Hi: In rte_eth_dev_rx|tx_queue_start, dev_started is not checked Which mean we can call Rte_eth_rx_queue_setup Rte_eth_rx_qeueu_start And what we expected is the queue is started while device is still stopped, does this make sense? Should it

Re: [dpdk-dev] i40e mbuf->rss indication

2018-03-22 Thread Ferruh Yigit
On 3/22/2018 11:46 AM, Hanoch Haim (hhaim) wrote: > Driver: i40e > > DPDK : 17.11 > > Configuration : > > 1) RSS configuration >rxmode.mq_mode = ETH_MQ_RX_RSS; >rss->rss_hf = ETH_RSS_UDP | ETH_RSS_TCP; >rss->rss_key = Microsoft key >rss->rss_key_len = 52 >

Re: [dpdk-dev] [PATCH v5] eal: provide API for querying valid socket id's

2018-03-22 Thread Burakov, Anatoly
On 22-Mar-18 10:58 AM, Anatoly Burakov wrote: During lcore scan, find all socket ID's and store them, and provide public API to query valid socket id's. This will break the ABI, so bump ABI version. Signed-off-by: Anatoly Burakov --- Left out meson ABI version, will respin. -- Thanks, Anatol

Re: [dpdk-dev] i40e mbuf->rss indication

2018-03-22 Thread Hanoch Haim (hhaim)
Driver: i40e DPDK : 17.11 Configuration : 1) RSS configuration rxmode.mq_mode = ETH_MQ_RX_RSS; rss->rss_hf = ETH_RSS_UDP | ETH_RSS_TCP; rss->rss_key = Microsoft key rss->rss_key_len = 52 *configure RETA to some rx-queues 2)Change hash to TOEPLI

Re: [dpdk-dev] [PATCH v2 01/18] eal: introduce dtor macros

2018-03-22 Thread Neil Horman
On Wed, Mar 21, 2018 at 06:15:22PM +0100, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/include/rte_common.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/lib/librte_eal/common/include/rte_common.h > b/lib/librte_eal/common/i

Re: [dpdk-dev] i40e mbuf->rss indication

2018-03-22 Thread Bruce Richardson
On Wed, Mar 21, 2018 at 06:47:22PM +, Hanoch Haim (hhaim) wrote: > Hi All, > DPDK:17.11 > When i40e is configured with RSS enabled and hash.type=toeplitz > > m->hash.rss = some weird number > ((m->ol_flags&PKT_RX_RSS_HASH) == PKT_RX_RSS_HASH > > The hash value is correct and match the MS Toep

Re: [dpdk-dev] [PATCH v2 00/18] Device querying

2018-03-22 Thread Bruce Richardson
On Wed, Mar 21, 2018 at 06:15:21PM +0100, Gaetan Rivet wrote: > This patchset introduces a new EAL API for querying devices, > filtered by arbitrary properties. > > The following elements are introduced to this end: > > * A new object, "rte_class", is used to describe >the device class abstr

Re: [dpdk-dev] mlx5 reta size is dynamic

2018-03-22 Thread Hanoch Haim (hhaim)
Hi, 1) Regarding this sentence, "Your need is to have a fixed size returned by the rte_eth_dev_info_get(), the PMD can have an internal dynamic size, it won't modify your spreading." I'm fine with that as long: 1. rte_eth_dev_info_get will expose the same *size* 2. rte_eth_dev_rss_reta_updat

[dpdk-dev] [PATCH v5] eal: provide API for querying valid socket id's

2018-03-22 Thread Anatoly Burakov
During lcore scan, find all socket ID's and store them, and provide public API to query valid socket id's. This will break the ABI, so bump ABI version. Signed-off-by: Anatoly Burakov --- Notes: v5: - Move API to experimental - Store list of valid socket id's instead of simply

Re: [dpdk-dev] [PATCH v7] kernel folder for Linux and BSD modules

2018-03-22 Thread Thomas Monjalon
22/03/2018 11:27, Bruce Richardson: > On Wed, Mar 21, 2018 at 07:42:55PM +0100, Thomas Monjalon wrote: > > Hi, > > > > About the title, please start with a verb: > > move kernel modules directories > > > > 22/02/2018 07:09, Hemant Agrawal: > > > --- /dev/null > > > +++ b/kernel/freebsd/BSDmak

Re: [dpdk-dev] mlx5 reta size is dynamic

2018-03-22 Thread Nélio Laranjeiro
Hi Hanoch, On Thu, Mar 22, 2018 at 10:00:45AM +, Hanoch Haim (hhaim) wrote: > Hi Nelio, > > Let me provide more background. > The context is TRex running in Advance Stateful (ASTf) mode using multi-core. > > In this case the flows are distributed using RSS. New flows (c->s) > need to have

Re: [dpdk-dev] [PATCH] net/mlx5: add supported hash function check

2018-03-22 Thread Xueming(Steven) Li
Just remind, denying unsupported hash function in rte_eth_dev_configure() might impact some user app using PMD that simply ignoring them silently. Testpmd command "port config rss all" should be updated as well to 'all' supported values from rte_eth_dev_info, I'll include this change in next ve

Re: [dpdk-dev] [PATCH v2] metrics: fix potential missing NULL termination

2018-03-22 Thread Ferruh Yigit
On 2/20/2018 4:05 PM, Remy Horton wrote: > Fixes a potential memory overrun detected by Coverity. > This overrun cannot currently happen in practice because > rte_metrics_reg_names() explicitly forces the last name > character to be a NULL terminator. This patch adds the > same enforcement to rte_m

[dpdk-dev] [PATCH v1] bus/fslmc: fix find device start condition

2018-03-22 Thread Gaetan Rivet
If start is set and a device before it matches the data, this device is returned. Fixes: c7fe1eea8a74 ("bus: simplify finding starting point") Cc: sta...@dpdk.org Cc: Hemant Agrawal Cc: Shreyansh Jain Signed-off-by: Gaetan Rivet --- Hi Shreyansh, Hemant, Sorry, I did not test this. I found t

Re: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses

2018-03-22 Thread Nélio Laranjeiro
On Thu, Mar 22, 2018 at 09:45:16AM +, Shahaf Shuler wrote: > Thursday, March 22, 2018 11:05 AM, Nélio Laranjeiro: > > > What if the DPDK process is terminated ungracefully? I think the MAC > > > table will remain with all the MACs which were added. > > > The next run of the process may have un-

Re: [dpdk-dev] [PATCH v7] kernel folder for Linux and BSD modules

2018-03-22 Thread Bruce Richardson
On Wed, Mar 21, 2018 at 07:42:55PM +0100, Thomas Monjalon wrote: > Hi, > > About the title, please start with a verb: > move kernel modules directories > > 22/02/2018 07:09, Hemant Agrawal: > > --- /dev/null > > +++ b/kernel/freebsd/BSDmakefile.meson > > @@ -0,0 +1,43 @@ > > +# BSD LICENS

Re: [dpdk-dev] [PATCH v3 0/6] net/sfc: implement dynamic logging

2018-03-22 Thread Ferruh Yigit
On 3/21/2018 11:28 AM, Andrew Rybchenko wrote: > The series adds EXPERIMENTAL EAL feature which removes dependency > on EAL arguments processing and log types registration. It stores > EAL loglevel arguments in the list and adds API function to register > a new log type and pick up its value from E

Re: [dpdk-dev] [PATCH v3 1/6] eal: register log type and pick level from EAL args

2018-03-22 Thread Ferruh Yigit
On 3/21/2018 11:28 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Dynamic log types are registered on RTE_INIT() step. > This allows one to set log levels by EAL options on > application launch. However, this does not allow to > manage log types if they are created during runtime. > > EAL do

Re: [dpdk-dev] mlx5 reta size is dynamic

2018-03-22 Thread Hanoch Haim (hhaim)
Hi Nelio, Let me provide more background. The context is TRex running in Advance Stateful (ASTf) mode using multi-core. In this case the flows are distributed using RSS. New flows (c->s) need to have a tuple that will match the generated core. For this calculation there is a need of to know t

Re: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses

2018-03-22 Thread Shahaf Shuler
Thursday, March 22, 2018 11:05 AM, Nélio Laranjeiro: > > What if the DPDK process is terminated ungracefully? I think the MAC > > table will remain with all the MACs which were added. > > The next run of the process may have un-expected results. > > > > Should we flush the neighbor mac table also o

Re: [dpdk-dev] mlx5 reta size is dynamic

2018-03-22 Thread Nélio Laranjeiro
Hi Hanoch, On Thu, Mar 22, 2018 at 09:02:19AM +, Hanoch Haim (hhaim) wrote: > Hi Nelio, > I think you didn't understand me. I suggest to keep the RETA table > size constant (maximum 512 in your case) and don't change its base on > the number of configured Rx-queue. It is even simpler, we can

Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK

2018-03-22 Thread Burakov, Anatoly
On 22-Mar-18 5:09 AM, Shreyansh Jain wrote: Hello Anatoly, -Original Message- From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] Sent: Wednesday, March 21, 2018 8:18 PM To: Shreyansh Jain Cc: dev@dpdk.org; Hemant Agrawal Subject: Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug f

Re: [dpdk-dev] [PATCH v2 0/9] align SPDX Mellanox copyrights

2018-03-22 Thread Adrien Mazarguil
On Tue, Mar 20, 2018 at 09:20:34PM +0200, Shahaf Shuler wrote: > This series is to align the format of the copyright in Mellanox related files. > > On v2: > - remove completely the BSD licence from mlx PMD docs > - add more patches to align files not under drivers/net/mlx* > > > Shahaf Shuler

Re: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses

2018-03-22 Thread Nélio Laranjeiro
On Thu, Mar 22, 2018 at 07:34:50AM +, Shahaf Shuler wrote: > Hi Nelio, > > Wednesday, March 21, 2018 3:40 PM, Nelio Laranjeiro: > > VF devices are not able to receive traffic unless it fully requests it > > though > > Netlink. This will cause the request to be processed by the PF which will

Re: [dpdk-dev] [PATCH 18.05 v4] eal: add function to return number of detected sockets

2018-03-22 Thread Burakov, Anatoly
On 22-Mar-18 5:16 AM, gowrishankar muthukrishnan wrote: On Wednesday 21 March 2018 03:54 PM, Burakov, Anatoly wrote: +    config->numa_node_count = max_socket_id + 1; In some IBM servers, socket ID number does not seem to be in sequence. For an instance, 0 and 8 for a 2 node server. In th

Re: [dpdk-dev] mlx5 reta size is dynamic

2018-03-22 Thread Hanoch Haim (hhaim)
Hi Nelio, I think you didn't understand me. I suggest to keep the RETA table size constant (maximum 512 in your case) and don't change its base on the number of configured Rx-queue. This will make the DPDK API consistent. As a user I need to do tricks (allocate an odd/prime number of rx-queues

Re: [dpdk-dev] [PATCH v2 3/3] net/ifcvf: add ifcvf driver

2018-03-22 Thread Ferruh Yigit
On 3/21/2018 1:21 PM, Xiao Wang wrote: > ifcvf driver uses vdev as a control domain to manage ifc VFs that belong > to it. It registers vDPA device ops to vhost lib to enable these VFs to be > used as vhost data path accelerator. > > Live migration feature is supported by ifc VF and this driver en

Re: [dpdk-dev] mlx5 reta size is dynamic

2018-03-22 Thread Nélio Laranjeiro
On Thu, Mar 22, 2018 at 06:52:53AM +, Hanoch Haim (hhaim) wrote: > Hi Yongseok, > > > RSS has a DPDK API,application can ask for the reta table size and > configure it. In your case you are assuming specific use case and > change the size dynamically which solve 90% of the use-cases but brea

Re: [dpdk-dev] [PATCH v2 01/10] lib/librte_vhost: add vhost user private info structure

2018-03-22 Thread Wodkowski, PawelX
> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, March 21, 2018 5:12 PM > To: Maxime Coquelin ; dev@dpdk.org; > Kulasek, TomaszX ; Wodkowski, PawelX > > Cc: jianjay.z...@huawei.com; y...@fridaylinux.org; Tan, Jianfeng > ; Bie, Tiwei > Subject: RE: [dpdk-dev] [PATCH v2 01/10]

Re: [dpdk-dev] [PATCH v3 2/5] vhost: support selective datapath

2018-03-22 Thread Maxime Coquelin
On 03/22/2018 08:55 AM, Wang, Zhihong wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Thursday, March 22, 2018 5:06 AM To: Wang, Zhihong ; dev@dpdk.org Cc: Tan, Jianfeng ; Bie, Tiwei ; y...@fridaylinux.org; Liang, Cunming ; Wang, Xiao W ; Dal

Re: [dpdk-dev] [PATCH v3 3/5] vhost: add apis for datapath configuration

2018-03-22 Thread Wang, Zhihong
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, March 22, 2018 5:08 AM > To: Wang, Zhihong ; dev@dpdk.org > Cc: Tan, Jianfeng ; Bie, Tiwei > ; y...@fridaylinux.org; Liang, Cunming > ; Wang, Xiao W ; Daly, > Dan > Subject: Re: [PATCH v3 3

Re: [dpdk-dev] [PATCH V15 2/5] eal: add uevent pass and process function

2018-03-22 Thread Guo, Jia
jianfeng, thanks for your review. almost make sense and comment as bellow. On 3/21/2018 10:20 PM, Tan, Jianfeng wrote: On 3/21/2018 1:27 PM, Jeff Guo wrote: In order to handle the uevent which have been detected from the kernel side, add uevent process function, let hot plug event to be exam

[dpdk-dev] [PATCH v6 0/2] app/testpmd: add new commands to test new Tx/Rx offloads

2018-03-22 Thread Wei Dai
Existed testpmd commands can't support per queue offload configuration. And there are different commands to enable or disable different offloading. This patch set add following commands to support new Tx/Rx offloading API test. To get Rx offload capability of a port, please run: testpmd > rx_offlo

[dpdk-dev] [PATCH v6 1/2] app/testpmd: add commands to test new Rx offload API

2018-03-22 Thread Wei Dai
Add following testpmd run-time commands to support test of new Rx offload API: rx_offload get capability rx_offload get configuration rx_offload enable|disable per_port rx_offload enable|disable per_queue Above last 2 commands should be run when the port is stopped. And can be one of "vlan

[dpdk-dev] [PATCH v6 2/2] app/testpmd: add commands to test new Tx offload API

2018-03-22 Thread Wei Dai
Add following testpmd run-time commands to support test of new Tx offload API: tx_offload get capability tx_offload get configuration tx_offload enable|disable per_port tx_offload enable|disable per_queue Above last 2 commands should be run when the port is stopped. And can be one of "vlan

Re: [dpdk-dev] [PATCH v3 2/5] vhost: support selective datapath

2018-03-22 Thread Wang, Zhihong
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, March 22, 2018 5:06 AM > To: Wang, Zhihong ; dev@dpdk.org > Cc: Tan, Jianfeng ; Bie, Tiwei > ; y...@fridaylinux.org; Liang, Cunming > ; Wang, Xiao W ; Daly, > Dan > Subject: Re: [PATCH v3 2

Re: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses

2018-03-22 Thread Shahaf Shuler
Thursday, March 22, 2018 9:35 AM, Shahaf Shuler: > Hi Nelio, > > Wednesday, March 21, 2018 3:40 PM, Nelio Laranjeiro: > > VF devices are not able to receive traffic unless it fully requests it > > though Netlink. This will cause the request to be processed by the PF > > which will add/remove the

Re: [dpdk-dev] [PATCH v3 3/3] net/mlx5: add a parameter for Netlink support in VF

2018-03-22 Thread Shahaf Shuler
Wednesday, March 21, 2018 3:40 PM, Nelio Laranjeiro: > All Netlink request the PMD will do can also be done by a iproute2 command > line interface, letting the operator configure the VF behavior without having > to modify the application nor reaching PMD limits (e.g. MAC address number > limit). >

Re: [dpdk-dev] [PATCH v3 2/3] net/mlx5: use Netlink to enable promisc / all multicast mode

2018-03-22 Thread Shahaf Shuler
Wednesday, March 21, 2018 3:40 PM, Nelio Laranjeiro: > VF devices are not able to receive promisc or allmulti traffic unless it fully > requests it though Netlink. This will cause the request to be processed by > the PF which will handle the request and enable it. > > This requires the VF to b

Re: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses

2018-03-22 Thread Shahaf Shuler
Hi Nelio, Wednesday, March 21, 2018 3:40 PM, Nelio Laranjeiro: > VF devices are not able to receive traffic unless it fully requests it though > Netlink. This will cause the request to be processed by the PF which will > add/remove the MAC address to the VF table if the VF is trusted. > > Signed