Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-16 Thread Patil, Harish
-Original Message- From: Ferruh Yigit Date: Friday, March 16, 2018 at 8:51 AM To: John McNamara , Marko Kovacevic Cc: "dev@dpdk.org" , Ferruh Yigit , Thomas Monjalon , "shah...@mellanox.com" , , Harish Patil Subject: [PATCH] doc: update new ethdev offload API description >Don't mandate

Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup

2018-03-16 Thread Ananyev, Konstantin
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, March 16, 2018 2:15 PM > To: Ananyev, Konstantin ; tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup > > > > > > >

[dpdk-dev] [PATCH v3 44/44] ip_pipeline: add flow classification example

2018-03-16 Thread Jasvinder Singh
Add example to build pipeline with hash table to classify the ingress traffic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/examples/flow.cli | 60 ++ 1 file changed, 60 insertions(+) create

[dpdk-dev] [PATCH v3 43/44] ip_pipeline: add firewall example

2018-03-16 Thread Jasvinder Singh
Add example to built pipeline with ACL table to demonstrate the firewall operation. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/examples/firewall.cli | 59 ++ 1 file changed, 59 insertions(+) create mode 100644 examples

[dpdk-dev] [PATCH v3 42/44] ip_pipeline: add route example

2018-03-16 Thread Jasvinder Singh
Add example to built pipeline with LPM table to demonstrate layer 3 routing. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- examples/ip_pipeline/examples/route.cli | 60 + 1 file changed, 60 insertions(+) crea

[dpdk-dev] [PATCH v3 40/44] ip_pipeline: add KNI port example

2018-03-16 Thread Jasvinder Singh
Add example to illustrate the pipeline functioning with KNI interface. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/examples/kni.cli | 69 +++ 1 file changed, 69 insertions(+) create mode

[dpdk-dev] [PATCH v3 41/44] ip_pipeline: add TAP port example

2018-03-16 Thread Jasvinder Singh
Add example to illustrate the pipeline functioning with TAP interface. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/examples/tap.cli | 66 +++ 1 file changed, 66 insertions(+) create mode

[dpdk-dev] [PATCH v3 38/44] ip_pipeline: add cli to read ttl stats

2018-03-16 Thread Jasvinder Singh
Add command to read the ttl stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 22 +++ examples/ip_pipeline/pipeline.h | 7 examples/ip_pipeline/thread.c | 84 + 3 files changed,

[dpdk-dev] [PATCH v3 39/44] ip_pipeline: add l2fwd example

2018-03-16 Thread Jasvinder Singh
This patch add the configuration file for l2fwd example. It includes commands to build the packet processing stage (pipeline), defining action, add rules to its table, etc. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/exa

[dpdk-dev] [PATCH v3 37/44] ip_pipeline: add cli to update dscp table

2018-03-16 Thread Jasvinder Singh
Add command to update the dscp table for traffic meter and traffic manager. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 154 examples/ip_pipeline/pipeline.h | 6 ++ examples/ip_pipeline/thread

[dpdk-dev] [PATCH v3 36/44] ip_pipeline: add cli to read meter stats

2018-03-16 Thread Jasvinder Singh
Add command to read traffic meter stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 22 +++ examples/ip_pipeline/pipeline.h | 8 examples/ip_pipeline/thread.c | 88 + 3 files cha

[dpdk-dev] [PATCH v3 35/44] ip_pipeline: add cli to configure meter profile

2018-03-16 Thread Jasvinder Singh
Add commands to configure the traffic meter profile. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 232 examples/ip_pipeline/pipeline.h | 11 ++ examples/ip_pipeline/thread.c | 145

[dpdk-dev] [PATCH v3 34/44] ip_pipeline: add cli to read pipeline table entry stats

2018-03-16 Thread Jasvinder Singh
Add command to read the pipeline table entry stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 22 +++ examples/ip_pipeline/pipeline.h | 7 examples/ip_pipeline/thread.c | 84 +

[dpdk-dev] [PATCH v3 33/44] ip_pipeline: add cli to delete pipeline table entry

2018-03-16 Thread Jasvinder Singh
Add command to delete the pipeline table entry. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 145 examples/ip_pipeline/pipeline.h | 9 +++ examples/ip_pipeline/thread.c | 140

[dpdk-dev] [PATCH v3 32/44] ip_pipeline: add cli for pipeline table entries

2018-03-16 Thread Jasvinder Singh
Add commands to add pipeline table entries which contains match and action part. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 1273 +++ examples/ip_pipeline/pipeline.h | 13 + examples/ip_pipeline/t

[dpdk-dev] [PATCH v3 31/44] ip_pipeline: add cli to read pipeline port and table stats

2018-03-16 Thread Jasvinder Singh
Add commands to read the pipeline port in, port out and table stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 256 examples/ip_pipeline/pipeline.h | 18 +++ exampl

[dpdk-dev] [PATCH v3 30/44] ip_pipeline: add cli to enable and disable pipeline port

2018-03-16 Thread Jasvinder Singh
Add commands to enable and disable the pipeline ports. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 112 +++ examples/ip_pipeline/pipeline.h | 8 ++ examples/ip_pipeline/thread.c | 1

[dpdk-dev] [PATCH v3 29/44] ip_pipeline: add cli to enable and disable pipeline

2018-03-16 Thread Jasvinder Singh
Add commands to enable and disable the pipeline on the thread. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c| 102 + examples/ip_pipeline/thread.c | 260 +- e

[dpdk-dev] [PATCH v3 26/44] ip_pipeline: add pipeline object

2018-03-16 Thread Jasvinder Singh
Add pipeline object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 786 + examples/ip_pipeline/cli.h | 2 - examples/ip_

[dpdk-dev] [PATCH v3 24/44] ip_pipeline: add kni object

2018-03-16 Thread Jasvinder Singh
Add kni object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 65 +++ examples/ip_pipeline/kni.c | 167 ++

[dpdk-dev] [PATCH v3 27/44] ip_pipeline: add threads

2018-03-16 Thread Jasvinder Singh
Add threads data structure and initialisation functions to run the pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 2 +- examples/ip_pipeline/main.c | 8 ++ examples/ip_pipeline/meson.build | 1 + examples/ip_pipeline

[dpdk-dev] [PATCH v3 28/44] ip_pipeline: add thread runtime

2018-03-16 Thread Jasvinder Singh
Add runtime thread functions for the pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/main.c | 6 ++ examples/ip_pipeline/thread.c | 193 ++ examples/ip_pipeline/thread.h | 3 + 3 files changed, 20

[dpdk-dev] [PATCH v3 25/44] ip_pipeline: add action profile object

2018-03-16 Thread Jasvinder Singh
Add action profile object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/Makefile| 4 +- examples/ip_pipeline/action.c| 165 + examples/ip_pipeline/action.h

[dpdk-dev] [PATCH v3 23/44] ip_pipeline: add tap object

2018-03-16 Thread Jasvinder Singh
Add tap object implementation to the application Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 32 + examples/ip_pipeline/main.c | 8 examples/i

[dpdk-dev] [PATCH v3 22/44] ip_pipeline: add traffic manager object

2018-03-16 Thread Jasvinder Singh
Add traffic manager object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 360 +++ examples/ip_pipeline/main.c | 8 +

[dpdk-dev] [PATCH v3 21/44] ip_pipeline: add software queue object

2018-03-16 Thread Jasvinder Singh
Add swq object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 55 + examples/ip_pipeline/main.c | 8

[dpdk-dev] [PATCH v3 20/44] ip_pipeline: add link object

2018-03-16 Thread Jasvinder Singh
Add link object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 122 ++ examples/ip_pipeline/link.c | 268

[dpdk-dev] [PATCH v3 19/44] ip_pipeline: add mempool object for pipeline

2018-03-16 Thread Jasvinder Singh
Add mempool object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 109 ++- examples/ip_pipeline/co

[dpdk-dev] [PATCH v3 18/44] ip_pipeline: add cli interface

2018-03-16 Thread Jasvinder Singh
CLI interface allowing connectivity with external agent(e.g. telnet, netcat, Python script, etc) is added to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 4 +- examples/ip_pipeline/cli.c | 85 ++ examp

[dpdk-dev] [PATCH v3 16/44] ip_pipeline: remove config

2018-03-16 Thread Jasvinder Singh
Remove application configuration and script files. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/config/action.cfg | 68 -- examples/ip_pipeline/config/action.sh | 119 --- examples/ip_pipeline/config/action.txt

[dpdk-dev] [PATCH v3 15/44] ip_pipeline: remove master pipeline

2018-03-16 Thread Jasvinder Singh
remove master pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile |6 - examples/ip_pipeline/app.h | 12 - examples/ip_pipeline/{pipeline => }/hash_func.h|3 +- .../ip_pipeline/{

[dpdk-dev] [PATCH v3 14/44] ip_pipeline: remove firewall pipeline

2018-03-16 Thread Jasvinder Singh
Remove firewall pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile |2 - examples/ip_pipeline/init.c|2 - examples/ip_pipeline/meson.build |2 - examples/ip_pipe

[dpdk-dev] [PATCH v3 12/44] ip_pipeline: remove flow classification pipeline

2018-03-16 Thread Jasvinder Singh
Remove flow classification pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile |2 - examples/ip_pipeline/init.c|2 - examples/ip_pipeline/meson.build |2 - .../p

[dpdk-dev] [PATCH v3 13/44] ip_pipeline: remove flow actions pipeline

2018-03-16 Thread Jasvinder Singh
Remove flow actions pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile |2 - examples/ip_pipeline/init.c|2 - examples/ip_pipeline/meson.build |2 - .../ip_pipel

[dpdk-dev] [PATCH v3 11/44] ip_pipeline: remove routing pipeline

2018-03-16 Thread Jasvinder Singh
Remove routing pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile |2 - examples/ip_pipeline/init.c|2 - examples/ip_pipeline/meson.build |2 - examples/ip_pipel

[dpdk-dev] [PATCH v3 10/44] ip_pipeline: remove passthrough pipeline

2018-03-16 Thread Jasvinder Singh
remove passthrough pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile | 2 - examples/ip_pipeline/init.c| 2 - examples/ip_pipeline/meson.build | 2 - .../ip_pipeline/

[dpdk-dev] [PATCH v3 08/44] pipeline: add statistics read action

2018-03-16 Thread Jasvinder Singh
Add implementation of stats read action Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 111 +++ lib/librte_pipeline/rte_table_action.h | 78 +++ 3 files cha

[dpdk-dev] [PATCH v3 09/44] pipeline: add timestamp action

2018-03-16 Thread Jasvinder Singh
Add implementation of timestamp action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 79 +++- lib/librte_pipeline/rte_table_action.h | 31 +++ 3 files changed, 110

[dpdk-dev] [PATCH v3 07/44] pipeline: add ttl update action

2018-03-16 Thread Jasvinder Singh
Add implementation of ttl update action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 162 +++ lib/librte_pipeline/rte_table_action.h | 66 +++ 3 files changed, 2

[dpdk-dev] [PATCH v3 06/44] pipeline: add nat action

2018-03-16 Thread Jasvinder Singh
Add implementation of Network Address Translation(NAT) action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_table_action.c | 351 + lib/librte_pipeline/rte_table_action.h | 39 2 files changed, 390 insertions(+) diff --git a/lib/librte_pip

[dpdk-dev] [PATCH v3 04/44] pipeline: add traffic manager action

2018-03-16 Thread Jasvinder Singh
Add implementation of traffic manager action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/Makefile | 2 +- lib/librte_pipeline/meson.build| 2 +- lib/librte_pipeline/rte_table_action.c | 130 - lib/librte_pipeline/rte_table_act

[dpdk-dev] [PATCH v3 05/44] pipeline: add packet encapsulation action

2018-03-16 Thread Jasvinder Singh
Add implementation of different type of packet encap such as vlan, qinq, mpls, pppoe, etc. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_table_action.c | 440 - lib/librte_pipeline/rte_table_action.h | 129 ++ 2 files changed, 568 insertio

[dpdk-dev] [PATCH v3 01/44] pipeline: add pipeline table action APIs

2018-03-16 Thread Jasvinder Singh
This API provides a common set of actions for pipeline tables to speed up application development. Each match-action rule added to a pipeline table has associated data that stores the action context. This data is input to the table action handler called for every input packet that hits the rule as

[dpdk-dev] [PATCH v3 03/44] pipeline: add traffic metering action

2018-03-16 Thread Jasvinder Singh
Add traffic metering action implementation. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/Makefile | 3 +- lib/librte_pipeline/meson.build | 2 +- lib/librte_pipeline/rte_pipeline_version.map | 4 + lib/librte_pipeline/rte_table_action.c | 64

[dpdk-dev] [PATCH v3 02/44] pipeline: get pipeline table action params

2018-03-16 Thread Jasvinder Singh
Add API to specify action related parameters such as action handler, table entry data size, etc. for the pipeline table. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 130 +++ li

[dpdk-dev] [PATCH v3 00/44] ip_pipeline: refactoring

2018-03-16 Thread Jasvinder Singh
Refactored the IP pipeline application. As result, the code base size (lines of code) reduces by ~60%. 1. Moved table actions into the librte_pipeline library. As result, the pre-fabricated pipelines from the application pipeline folder were removed. The flexibility is greatly improved, as n

[dpdk-dev] [PATCH v3 01/44] pipeline: add pipeline table action APIs

2018-03-16 Thread Jasvinder Singh
This API provides a common set of actions for pipeline tables to speed up application development. Each match-action rule added to a pipeline table has associated data that stores the action context. This data is input to the table action handler called for every input packet that hits the rule as

[dpdk-dev] [PATCH v3 00/44] ip_pipeline: refactoring

2018-03-16 Thread Jasvinder Singh
Refactored the IP pipeline application. As result, the code base size (lines of code) reduces by ~60%. 1. Moved table actions into the librte_pipeline library. As result, the pre-fabricated pipelines from the application pipeline folder were removed. The flexibility is greatly improved, as n

Re: [dpdk-dev] [PATCH v3 15/18] net/axgbe: add generic transmit and receive stats support

2018-03-16 Thread Ferruh Yigit
On 3/9/2018 8:42 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > +static int > +axgbe_dev_stats_get(struct rte_eth_dev *dev, > + struct rte_eth_stats *stats) > +{ > + struct axgbe_rx_queue *rxq; > + struct axgbe_tx_queue *txq; > + unsigned int i; > + > +

Re: [dpdk-dev] [PATCH v3 12/18] net/axgbe: add link status update

2018-03-16 Thread Ferruh Yigit
On 3/9/2018 8:42 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > +/* return 0 means link status changed, -1 means not changed */ > +static int > +axgbe_dev_link_update(struct rte_eth_dev *dev, > + int wait_to_complete __rte_unused) > +{ > + PMD_INIT_FUNC_TRACE();

Re: [dpdk-dev] [PATCH v3 11/18] doc: add documents for AMD axgbe Ethernet PMD

2018-03-16 Thread Ferruh Yigit
On 3/9/2018 8:42 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar > --- > doc/guides/nics/axgbe.rst | 211 > + cc'ed document maintainers. <...> > +Supported Chipsets and NICs > +--- > +- AMD 10 Gigabit Ethernet Controller

Re: [dpdk-dev] [PATCH v3 10/18] net/axgbe: add transmit and receive data path apis

2018-03-16 Thread Ferruh Yigit
On 3/9/2018 8:42 AM, Ravi Kumar wrote: May be good to mention in commit log that for scalar path both Rx/Tx implemented but for vector path only Tx implemented. > Signed-off-by: Ravi Kumar

Re: [dpdk-dev] [PATCH v3 08/18] net/axgbe: add transmit and receive queue setup apis

2018-03-16 Thread Ferruh Yigit
On 3/9/2018 8:42 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > + > + rxq->crc_len = (uint8_t)((dev->data->dev_conf.rxmode.hw_strip_crc) ? 0 : > + ETHER_CRC_LEN); This is also changed recently, new ethdev offloading API introduced which PMDs target to

Re: [dpdk-dev] [PATCH v3 04/18] net/axgbe: add structures for MAC initialization and reset

2018-03-16 Thread Ferruh Yigit
On 3/9/2018 8:42 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > @@ -167,6 +358,106 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) > pci_dev = RTE_DEV_TO_PCI(eth_dev->device); > pdata->pci_dev = pci_dev; > > + pdata->xgmac_regs = > + (uint64_t)pci_dev-

Re: [dpdk-dev] [PATCH v3 01/18] net/axgbe: add minimal dev init and uninit support

2018-03-16 Thread Ferruh Yigit
On 3/9/2018 8:42 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > @@ -412,6 +412,12 @@ CONFIG_RTE_PMD_RING_MAX_TX_RINGS=16 > CONFIG_RTE_LIBRTE_PMD_SOFTNIC=y > > # > +# Compile AMD PMD > +# > +CONFIG_RTE_LIBRTE_AXGBE_PMD=y > +CONFIG_RTE_LIBRTE_AXGBE_DEBUG_INIT=n Config file recently

[dpdk-dev] [PATCH] net/bonding: set dev_started later

2018-03-16 Thread Chas Williams
From: "Charles (Chas) Williams" There are several error paths where the bonding device may not start. Don't set dev_started until we know that we are sure start is going to succeed. Fixes: 2efb58cbab ("bond: new link bonding library") Cc: sta...@dpdk.org Signed-off-by: Chas Williams --- drive

[dpdk-dev] pmdinfo fails with GCC link-time-optimization

2018-03-16 Thread Stephen Hemminger
GCC link-time-optimization generates much better code (at expense of build time) so it is logical to use it for DPDK. But the current PMDINFO steps fail since .o file is not a binary with lto. Any ideas or planned fixes? == Build drivers/mempool/octeontx CC octeontx_ssovf.o PMDINFO octeontx_

[dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-16 Thread Ferruh Yigit
Don't mandate API to pass port offload configuration during queue setup, this is unnecessary for devices that support only port level offloads. Fixes: 81ac560dc1b4 ("doc: add details on ethdev offloads API") Cc: shah...@mellanox.com Signed-off-by: Ferruh Yigit --- Cc: Patil, Harish Btw, this e

Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-03-16 Thread Andrew Rybchenko
Hi Olivier, On 02/27/2018 06:11 PM, Olivier Matz wrote: Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a return code is added to notify the caller (librte_ether) if an error occurred in the PMD. The new default MAC address is now copied in dev->data->mac_addrs[0] only if

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix existing file removal

2018-03-16 Thread Nélio Laranjeiro
On Fri, Mar 16, 2018 at 11:22:27PM +0800, Xueming Li wrote: > There is no guarantee that the file won't be removed by external > user/application between the stat() and remove() syscalls, remove() will > fail if the file no longer exists. > > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exc

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-16 Thread Remy Horton
On 16/03/2018 13:54, Shreyansh Jain wrote: On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit wrote: On 3/15/2018 2:39 PM, Bruce Richardson wrote: On Thu, Mar 15, 2018 at 01:57:13PM +, Ferruh Yigit wrote: [..] Hi Remy, Shreyansh, What do you think about using a variable name consistent with

[dpdk-dev] [PATCH] doc: reduce initial offload API scope to drivers

2018-03-16 Thread Ferruh Yigit
18.05 tagets ethdev-PMD offload API, which means switching all PMDs to new offloading API Next step targets ethdev-application offload API which means forcing applications to switch to new API Fixes: 3004d3454192 ("doc: update deprecation of ethdev offload API") Cc: shah...@mellanox.com Signed-o

[dpdk-dev] [PATCH v1] net/mlx5: fix existing file removal

2018-03-16 Thread Xueming Li
There is no guarantee that the file won't be removed by external user/application between the stat() and remove() syscalls, remove() will fail if the file no longer exists. Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor") Signed-off-by: Xueming Li --- drivers/net

[dpdk-dev] [PATCH 17/17] vhost: support mergeable rx buffers with packed queues

2018-03-16 Thread Jens Freimann
This implements support for mergeable receive buffers in vhost when using packed virtqueues. The difference to split virtqueues is not big, it differs mostly where descriptor flags are touched and virtio features are checked. Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.c | 2 +

[dpdk-dev] [PATCH 12/17] vhost: dequeue for packed queues

2018-03-16 Thread Jens Freimann
Implement code to dequeue and process descriptors from the vring if VIRTIO_F_PACKED is enabled. Check if descriptor was made available by driver by looking at VIRTIO_F_DESC_AVAIL flag in descriptor. If so dequeue and set the used flag VIRTIO_F_DESC_USED to the current value of the used wrap counte

[dpdk-dev] [PATCH 14/17] vhost: enable packed virtqueues

2018-03-16 Thread Jens Freimann
From: Yuanhan Liu This patch enables the code do enqueue and dequeue packed to/from a packed virtqueue. Add feature bit for packed virtqueues as defined in Virtio 1.1 draft. Signed-off-by: Jens Freimann Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/virt

[dpdk-dev] [PATCH 15/17] net/virtio: disable ctrl virtqueue for packed rings

2018-03-16 Thread Jens Freimann
Signed-off-by: Jens Freiman --- drivers/net/virtio/virtio_ethdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 888cc49..9f372a4 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/vi

[dpdk-dev] [PATCH 16/17] net/virtio: add support for mergeable buffers with packed virtqueues

2018-03-16 Thread Jens Freimann
Implement support for receiving merged buffers in virtio when packed virtqueues are enabled. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 5 +- drivers/net/virtio/virtio_rxtx.c | 107 + drivers/net/virtio/virtqueue.h | 1 +

[dpdk-dev] [PATCH 13/17] vhost: packed queue enqueue path

2018-03-16 Thread Jens Freimann
Implement enqueue of packets to the receive virtqueue. Set descriptor flag VIRTQ_DESC_F_USED and toggle used wrap counter if last descriptor in ring is used. Perform a write memory barrier before flags are written to descriptor. Chained descriptors are not supported with this patch. Signed-off-b

[dpdk-dev] [PATCH 11/17] vhost: add helpers for packed virtqueues

2018-03-16 Thread Jens Freimann
Add some helper functions to set/check descriptor flags and toggle the used wrap counter. Signed-off-by: Jens Freimann --- lib/librte_vhost/virtio-1.1.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/lib/librte_vhost/virtio-1.1.h b/lib/librte_vho

[dpdk-dev] [PATCH 10/17] vhost: vring address setup for packed queues

2018-03-16 Thread Jens Freimann
From: Yuanhan Liu Add code to set up packed queues when enabled. Signed-off-by: Yuanhan Liu Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.c | 1 + lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 17 - 3 files changed, 18 insertions(+), 1 d

[dpdk-dev] [PATCH 09/17] vhost: add virtio 1.1 defines

2018-03-16 Thread Jens Freimann
This should actually be in the kernel header file, but it isn't yet. For now let's use our own headers. Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.h | 4 +++- lib/librte_vhost/virtio-1.1.h | 20 2 files changed, 23 insertions(+), 1 deletion(-) create mode

[dpdk-dev] [PATCH 08/17] net/virtio: implement receive path for packed queues

2018-03-16 Thread Jens Freimann
From: Yuanhan Liu Implement the receive part here. No support for mergeable buffers yet. Signed-off-by: Jens Freimann Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 5 +- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 134 ++

[dpdk-dev] [PATCH 07/17] net/virtio: implement transmit path for packed queues

2018-03-16 Thread Jens Freimann
This implements the transmit path for devices with support for Virtio 1.1. Add the feature bit for Virtio 1.1 and enable code to add buffers to vring and mark descriptors as available. This is based on a patch by Yuanhan Liu. Signed-off-by: Jens Freiman --- drivers/net/virtio/Makefile

[dpdk-dev] [PATCH 06/17] net/virtio-user: add option to use packed queues

2018-03-16 Thread Jens Freimann
From: Yuanhan Liu Add option to enable packed queue support for virtio-user devices. Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 12 ++-- drivers/net/virtio/virtio_user/virtio_user_dev.h | 3 ++- drivers/net/virtio/virtio_user_ethdev.c |

[dpdk-dev] [PATCH 05/17] net/virtio: don't dump split virtqueue data

2018-03-16 Thread Jens Freimann
VIRTQUEUE_DUMP access split virtqueue data which is not correct when packed virtqueues are used. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h

[dpdk-dev] [PATCH 04/17] net/virtio: add packed virtqueue helpers

2018-03-16 Thread Jens Freimann
Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 33 + drivers/net/virtio/virtqueue.c | 3 +++ 2 files changed, 36 insertions(+) diff --git a/drivers/net/virtio/virtio_ring.h b/dr

[dpdk-dev] [PATCH 03/17] net/virtio: add virtio 1.1 defines

2018-03-16 Thread Jens Freimann
Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h index fc45e34..6eb0077 100644 --- a/drivers/net/virtio/virtio_ring.h +++ b/drivers/net/virtio/virtio_ring

[dpdk-dev] [PATCH 02/17] net/virtio: don't call virtio_disable_intr() for packed queues

2018-03-16 Thread Jens Freimann
When VIRTIO_F_PACKED_RING is set, don't call virtio_disable_intr(). This function accesses data structures which are not available when packed virtqueues are enabled. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletio

[dpdk-dev] [PATCH 00/17] implement packed virtqueues

2018-03-16 Thread Jens Freimann
This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf It does not

[dpdk-dev] [PATCH 01/17] net/virtio: vring init for packed queues

2018-03-16 Thread Jens Freimann
Add and initialize descriptor data structures. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 22 -- drivers/net/virtio/virtio_pci.h| 8 drivers/net/virtio/virtio_ring.h | 25 +++-- drivers/net/virtio/virtqueue.h

[dpdk-dev] [dpdk-announce] Memory Hotplug patchset for DPDK

2018-03-16 Thread Burakov, Anatoly
Hi all, I would like to draw your attention to Memory Hotplug patchset that is targeted for 18.05. Because of the amount of code and potential implications of such a major EAL memory plumbing rework involved, I would like to ask everyone interested in this work (particularly representatives

Re: [dpdk-dev] [PATCH] ethdev: remove unused struct forward declaration

2018-03-16 Thread Ferruh Yigit
On 3/16/2018 2:09 PM, Shreyansh Jain wrote: > On Fri, Mar 16, 2018 at 4:44 PM, Ferruh Yigit wrote: >> Signed-off-by: Ferruh Yigit >> --- >> lib/librte_ether/rte_ethdev.h | 2 -- >> 1 file changed, 2 deletions(-) >> > > With movement to rte_ethdev_core.h, this looks correct. Good idea to add:

Re: [dpdk-dev] [PATCH v3] net/tap: allow user MAC to be passed as args

2018-03-16 Thread Ferruh Yigit
On 3/12/2018 5:45 PM, Ferruh Yigit wrote: > On 3/12/2018 9:53 PM, Vipin Varghese wrote: >> Allow TAP PMD to pass user desired MAC address as argument. >> The argument value is processed as string delimited by ':', >> is parsed and converted to HEX MAC address after validation. >> >> Signed-off-by:

Re: [dpdk-dev] [RFC v4 1/1] lib/compressdev: Adding hash support

2018-03-16 Thread Trahe, Fiona
Hi Shally, //snip//; > >> + /**< window size range in bytes */ > >> + int support_dict; > >> + /** Indicate algo support for dictionary load */ > >[Fiona] I need more info on this - What else is needed on the API to support > >it? > [Shally] We will need to add an API, say, rte_comp_set_dictio

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-16 Thread Bruce Richardson
On Fri, Mar 16, 2018 at 07:24:14PM +0530, Shreyansh Jain wrote: > On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit wrote: > > On 3/15/2018 2:39 PM, Bruce Richardson wrote: > >> On Thu, Mar 15, 2018 at 01:57:13PM +, Ferruh Yigit wrote: > >>> On 3/14/2018 9:36 PM, Bruce Richardson wrote: > On

Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup

2018-03-16 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, March 16, 2018 9:18 PM > To: Ananyev, Konstantin ; > tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue > setup > > > > >

Re: [dpdk-dev] [PATCH] ethdev: remove unused struct forward declaration

2018-03-16 Thread Shreyansh Jain
On Fri, Mar 16, 2018 at 4:44 PM, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit > --- > lib/librte_ether/rte_ethdev.h | 2 -- > 1 file changed, 2 deletions(-) > With movement to rte_ethdev_core.h, this looks correct. Acked-by: Shreyansh Jain

Re: [dpdk-dev] [PATCH v2] net/null: support bulk allocation

2018-03-16 Thread Ferruh Yigit
On 3/9/2018 11:09 AM, Ferruh Yigit wrote: > On 3/8/2018 11:40 PM, Mallesh Koujalagi wrote: >> Bulk allocation of multiple mbufs increased more than ~2% and less >> than 8% throughput on single core (1.8 GHz), based on usage for example >> 1: Testpmd case: Two null devices with copy 8% improvement.

Re: [dpdk-dev] [PATCH v3] net/null:Different mac address support

2018-03-16 Thread Ferruh Yigit
On 3/7/2018 10:45 AM, Ferruh Yigit wrote: > On 3/7/2018 3:31 AM, Mallesh Koujalagi wrote: >> After attaching two Null device to ovs, seeing "00.00.00.00.00.00" mac >> address for both null devices. Fix this issue, by setting different mac >> address. >> >> Signed-off-by: Mallesh Koujalagi > > Rev

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-16 Thread Shreyansh Jain
On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit wrote: > On 3/15/2018 2:39 PM, Bruce Richardson wrote: >> On Thu, Mar 15, 2018 at 01:57:13PM +, Ferruh Yigit wrote: >>> On 3/14/2018 9:36 PM, Bruce Richardson wrote: On Wed, Mar 14, 2018 at 09:02:47PM +, Ferruh Yigit wrote: > On 3/14/2

Re: [dpdk-dev] [PATCH] net/bonding: set MTU on slave configure

2018-03-16 Thread Ferruh Yigit
On 3/14/2018 12:11 PM, Radu Nicolau wrote: > > On 2/23/2018 4:01 AM, Chas Williams wrote: >> From: Chas Williams >> >> When a slave is configured make sure that the slave's MTU >> matches the bonding's idea of the MTU. >> >> Signed-off-by: Chas Williams >> --- >> > Acked-by: Radu Nicolau Appli

Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup

2018-03-16 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, March 16, 2018 5:54 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue > setup > > > > > --

[dpdk-dev] [PATCH] ethdev: remove unused struct forward declaration

2018-03-16 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- lib/librte_ether/rte_ethdev.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index d58b0cb02..71c3d29a4 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1117,8 +11

Re: [dpdk-dev] [PATCH 1/2] net/virtio: fix link autoneg value

2018-03-16 Thread Ferruh Yigit
On 3/16/2018 10:51 AM, Ferruh Yigit wrote: > link_autoneg shold use ETH_LINK_FIXED, not ETH_LINK_SPEED_FIXED > > Fixes: 138f367aec66 ("net/virtio: use linkstatus helper functions") > Cc: step...@networkplumber.org > > Signed-off-by: Ferruh Yigit Series Squashed into relevant commit in next-net,

Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup

2018-03-16 Thread Bruce Richardson
On Fri, Mar 16, 2018 at 09:54:03AM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Friday, March 16, 2018 12:52 AM > > To: Ananyev, Konstantin ; tho...@monjalon.net > > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > > ; Lu, Wenzhuo > > Subje

Re: [dpdk-dev] [PATCH] net/mlx5: fix existing file remove

2018-03-16 Thread Nélio Laranjeiro
On Fri, Mar 16, 2018 at 06:27:48PM +0800, Xueming Li wrote: > Remove file detection before removing existing file. > The explanation can induce some misunderstandings, the fact is there is no guarantee that the file won't be removed by an external user/application in between the stat() and remove

[dpdk-dev] [PATCH 1/2] net/virtio: fix link autoneg value

2018-03-16 Thread Ferruh Yigit
link_autoneg shold use ETH_LINK_FIXED, not ETH_LINK_SPEED_FIXED Fixes: 138f367aec66 ("net/virtio: use linkstatus helper functions") Cc: step...@networkplumber.org Signed-off-by: Ferruh Yigit --- drivers/net/virtio/virtio_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 2/2] net/vmxnet3: fix link autoneg value

2018-03-16 Thread Ferruh Yigit
link_autoneg shold use ETH_LINK_FIXED, not ETH_LINK_SPEED_FIXED Fixes: cd3c44c48caa ("net/vmxnet3: keep consistent link status") Cc: ch...@att.com Signed-off-by: Ferruh Yigit --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [dpdk-dev] [PATCH v8 00/15] common linkstatus functions

2018-03-16 Thread Ferruh Yigit
On 3/15/2018 5:38 PM, Ferruh Yigit wrote: > On 1/26/2018 2:01 AM, Stephen Hemminger wrote: >> While writing hyper-v driver, noticed a lot of unnecessary >> duplication of code in drivers for handling the eth_dev link status >> information. While consolidating this, it also became obvious that >> so

  1   2   >