Re: [dpdk-dev] net/i40e: fix intr callback unregister by adding retry

2018-03-12 Thread wangyunjian
> -Original Message- > From: wangyunjian > Sent: Saturday, March 10, 2018 2:51 PM > To: dev@dpdk.org > Cc: caihe ; wangyunjian > Subject: [dpdk-dev] net/i40e: fix intr callback unregister by adding retry > > From: Yunjian Wang > > The nic's interrupt source has some active callbacks,

[dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister by adding retry

2018-03-12 Thread wangyunjian
From: Yunjian Wang The nic's interrupt source has some active callbacks, when the port hotplug. Add a retry to give more port's a chance to uninit before returning an error. Fixes: d42aaf30008b ("i40e: support port hotplug") Signed-off-by: Yunjian Wang --- v2: * Fix return value check --- dri

[dpdk-dev] [RESEND v2 7/7] crypto/dpaa2_sec: change to dynamic logging

2018-03-12 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- config/common_base | 3 - config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 - doc/guides/cryptodevs/dpaa2_sec.rst | 21 +- drivers/crypto/dpaa2_sec/Makefile | 5 - drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 366

[dpdk-dev] [RESEND v2 6/7] crypto/dpaa2_sec: fix incorrect debugging prints

2018-03-12 Thread Shreyansh Jain
Digest and IV length variable declarations have changed. These were escaping builds as the debugging macro was disabled. During dynamic logging change, they were discoverd. Fixes: 0fbd75a99fc9 ("cryptodev: move IV parameters to session") Fixes: 7f0034275a24 ("cryptodev: remove digest length from c

[dpdk-dev] [RESEND v2 4/7] event/dpaa2: change to dynamic logging

2018-03-12 Thread Shreyansh Jain
Some changes had already been pushed via SHA:72654f090a11 patch. This patch updates them. Cc: nipun.gu...@nxp.com Signed-off-by: Shreyansh Jain --- doc/guides/eventdevs/dpaa2.rst| 14 - drivers/event/dpaa2/dpaa2_eventdev.c | 49 +++ drivers/ev

[dpdk-dev] [RESEND v2 5/7] bus/fslmc: remove unused debug macros

2018-03-12 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_logs.h | 40 1 file changed, 40 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_logs.h b/drivers/bus/fslmc/fslmc_logs.h index 1f3fe8e66..9750b8c8d 100644 --- a/drivers/bus/fslmc/fslmc_logs.h +++

[dpdk-dev] [RESEND v2 2/7] mempool/dpaa2: change to dynamic logging

2018-03-12 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/mempool/dpaa2/Makefile| 6 --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 60 +-- drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 38 + 3 files changed, 75 insertions(+), 29 deletions(-) creat

[dpdk-dev] [RESEND v2 0/7] Change DPAA2 to dynamic logging

2018-03-12 Thread Shreyansh Jain
(I forgot to add dev@ ml in previous send. Resending) ::History:: v2: - Fixed dynamic log identifier names (Ferruh) - Added dependency information in cover letter (Hemant) - Fixed some checkpatch issues - Updated some log messages ::Dependency:: This patchset is dependent on: master (c06ddf9

[dpdk-dev] [RESEND v2 3/7] net/dpaa2: change into dynamic logging

2018-03-12 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- config/common_base| 5 - config/defconfig_arm64-dpaa2-linuxapp-gcc | 9 - doc/guides/nics/dpaa2.rst | 44 ++--- drivers/net/dpaa2/Makefile| 6 - drivers/net/dpaa2/base/dpaa2_hw_dpni.c| 30 ++-- d

[dpdk-dev] [RESEND v2 1/7] bus/fslmc: change to dynamic logging

2018-03-12 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/Makefile | 5 - drivers/bus/fslmc/fslmc_bus.c| 64 + drivers/bus/fslmc/fslmc_logs.h | 31 +++ drivers/bus/fslmc/fslmc_vfio.c | 151 +++ drivers/bus/fsl

Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK

2018-03-12 Thread Shreyansh Jain
Hello Anatoly, On Fri, Mar 9, 2018 at 4:12 PM, Burakov, Anatoly wrote: > On 09-Mar-18 9:15 AM, Pavan Nikhilesh wrote: [...] >> >> >> I have taken a look at the github tree the issues with VFIO are gone, >> Although >> compilation issues with dpaa/dpaa2 are still present due to their >> dependen

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add commands to test new Rx offload API

2018-03-12 Thread Dai, Wei
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Monday, March 12, 2018 4:43 PM > To: Dai, Wei ; Lu, Wenzhuo ; > Wu, Jingjing > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add commands to test > new Rx offload API > > On 03/1

Re: [dpdk-dev] [PATCH v7 6/7] doc: add event timer adapter section to programmer's guide

2018-03-12 Thread Carrillo, Erik G
Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 12, 2018 6:21 AM > To: Carrillo, Erik G > Cc: pbhagavat...@caviumnetworks.com; dev@dpdk.org; > nipun.gu...@nxp.com; hemant.agra...@nxp.com > Subject: Re: [PATCH v7 6/7] doc: ad

Re: [dpdk-dev] [PATCH v7 3/7] eventtimer: add default software driver

2018-03-12 Thread Carrillo, Erik G
Hi Jerin, Response in-line: > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 12, 2018 3:46 AM > To: Carrillo, Erik G > Cc: pbhagavat...@caviumnetworks.com; dev@dpdk.org; > nipun.gu...@nxp.com; hemant.agra...@nxp.com > Subject: Re: [PA

[dpdk-dev] [PATCH] net/tap: fix icc build

2018-03-12 Thread Ferruh Yigit
build error: .../dpdk/drivers/net/tap/rte_eth_tap.c(598): error #279: controlling expression is constant RTE_ASSERT(!"unsupported request type: must not happen"); Although RTE_ASSERT helps debugging this issue when assert enabled, constant expression in assert means this path can be taken

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-12 Thread Ferruh Yigit
On 3/12/2018 5:58 PM, Shahaf Shuler wrote: > Monday, March 12, 2018 7:00 PM, Ferruh Yigit: >> There are some devices supports queue level offloads and there are some >> devices supports port level offloads. >> >> Values queue offload = 0x0 and port offload = 0x1000, for the device that >> support q

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-12 Thread Shahaf Shuler
Monday, March 12, 2018 7:00 PM, Ferruh Yigit: > There are some devices supports queue level offloads and there are some > devices supports port level offloads. > > Values queue offload = 0x0 and port offload = 0x1000, for the device that > support queue level offloads may mean disabling all offloa

Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD

2018-03-12 Thread Varghese, Vipin
Hi Reshma, I tried your suggestion, but the build fails even using warning or not using warning. The reason is DPDK build expects pdump to be build. I am looking at other alternatives, how to get this done. In last effort, we may need to disable PDUMP to be build default from '.config' file. T

[dpdk-dev] [PATCH v3] app/testpmd: print Rx/Tx offload values

2018-03-12 Thread Ferruh Yigit
Which per port offloads are enabled is not clear. Printing offloads values at forwarding start. CRC strip offload value was printed in more verbose manner, it is removed since Rx/Tx offload values covers it and printing only CRC one can cause confusion. Hexadecimal offloads values are not very us

[dpdk-dev] [PATCH v2 44/44] ip_pipeline: add flow classification example

2018-03-12 Thread Jasvinder Singh
Add example to build pipeline with hash table to classify the ingress traffic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/examples/flow.cli | 60 ++ 1 file changed, 60 insertions(+) create

[dpdk-dev] [PATCH v2 42/44] ip_pipeline: add route example

2018-03-12 Thread Jasvinder Singh
Add example to built pipeline with LPM table to demonstrate layer 3 routing. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- examples/ip_pipeline/examples/route.cli | 60 + 1 file changed, 60 insertions(+) crea

[dpdk-dev] [PATCH v2 43/44] ip_pipeline: add firewall example

2018-03-12 Thread Jasvinder Singh
Add example to built pipeline with ACL table to demonstrate the firewall operation. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/examples/firewall.cli | 59 ++ 1 file changed, 59 insertions(+) create mode 100644 examples

[dpdk-dev] [PATCH v2 41/44] ip_pipeline: add TAP port example

2018-03-12 Thread Jasvinder Singh
Add example to illustrate the pipeline functioning with TAP interface. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/examples/tap.cli | 66 +++ 1 file changed, 66 insertions(+) create mode

[dpdk-dev] [PATCH v2 39/44] ip_pipeline: add l2fwd example

2018-03-12 Thread Jasvinder Singh
This patch add the configuration file for l2fwd example. It includes commands to build the packet processing stage (pipeline), defining action, add rules to its table, etc. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/exa

[dpdk-dev] [PATCH v2 40/44] ip_pipeline: add KNI port example

2018-03-12 Thread Jasvinder Singh
Add example to illustrate the pipeline functioning with KNI interface. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/examples/kni.cli | 69 +++ 1 file changed, 69 insertions(+) create mode

[dpdk-dev] [PATCH v2 35/44] ip_pipeline: add cli to configure meter profile

2018-03-12 Thread Jasvinder Singh
Add commands to configure the traffic meter profile. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 232 examples/ip_pipeline/pipeline.h | 11 ++ examples/ip_pipeline/thread.c | 145

[dpdk-dev] [PATCH v2 37/44] ip_pipeline: add cli to update dscp table

2018-03-12 Thread Jasvinder Singh
Add command to update the dscp table for traffic meter and traffic manager. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 154 examples/ip_pipeline/pipeline.h | 6 ++ examples/ip_pipeline/thread

[dpdk-dev] [PATCH v2 38/44] ip_pipeline: add cli to read ttl stats

2018-03-12 Thread Jasvinder Singh
Add command to read the ttl stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 22 +++ examples/ip_pipeline/pipeline.h | 7 examples/ip_pipeline/thread.c | 84 + 3 files changed,

[dpdk-dev] [PATCH v2 33/44] ip_pipeline: add cli to delete pipeline table entry

2018-03-12 Thread Jasvinder Singh
Add command to delete the pipeline table entry. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 145 examples/ip_pipeline/pipeline.h | 9 +++ examples/ip_pipeline/thread.c | 140

[dpdk-dev] [PATCH v2 36/44] ip_pipeline: add cli to read meter stats

2018-03-12 Thread Jasvinder Singh
Add command to read traffic meter stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 22 +++ examples/ip_pipeline/pipeline.h | 8 examples/ip_pipeline/thread.c | 88 + 3 files cha

[dpdk-dev] [PATCH v2 32/44] ip_pipeline: add cli for pipeline table entries

2018-03-12 Thread Jasvinder Singh
Add commands to add pipeline table entries which contains match and action part. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/cli.c | 1273 +++ examples/ip_pipeline/pipeline.h | 13 + examples/ip_pipeline/t

[dpdk-dev] [PATCH v2 34/44] ip_pipeline: add cli to read pipeline table entry stats

2018-03-12 Thread Jasvinder Singh
Add command to read the pipeline table entry stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 22 +++ examples/ip_pipeline/pipeline.h | 7 examples/ip_pipeline/thread.c | 84 +

[dpdk-dev] [PATCH v2 31/44] ip_pipeline: add cli to read pipeline port and table stats

2018-03-12 Thread Jasvinder Singh
Add commands to read the pipeline port in, port out and table stats. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 256 examples/ip_pipeline/pipeline.h | 18 +++ exampl

[dpdk-dev] [PATCH v2 30/44] ip_pipeline: add cli to enable and disable pipeline port

2018-03-12 Thread Jasvinder Singh
Add commands to enable and disable the pipeline ports. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 112 +++ examples/ip_pipeline/pipeline.h | 8 ++ examples/ip_pipeline/thread.c | 1

[dpdk-dev] [PATCH v2 29/44] ip_pipeline: add cli to enable and disable pipeline

2018-03-12 Thread Jasvinder Singh
Add commands to enable and disable the pipeline on the thread. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c| 102 + examples/ip_pipeline/thread.c | 260 +- e

[dpdk-dev] [PATCH v2 28/44] ip_pipeline: add thread runtime

2018-03-12 Thread Jasvinder Singh
Add runtime thread functions for the pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/main.c | 6 ++ examples/ip_pipeline/thread.c | 193 ++ examples/ip_pipeline/thread.h | 3 + 3 files changed, 20

[dpdk-dev] [PATCH v2 25/44] ip_pipeline: add action profile object

2018-03-12 Thread Jasvinder Singh
Add action profile object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/Makefile| 4 +- examples/ip_pipeline/action.c| 165 + examples/ip_pipeline/action.h

[dpdk-dev] [PATCH v2 26/44] ip_pipeline: add pipeline object

2018-03-12 Thread Jasvinder Singh
Add pipeline object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 786 + examples/ip_pipeline/cli.h | 2 - examples/ip_

[dpdk-dev] [PATCH v2 23/44] ip_pipeline: add tap object

2018-03-12 Thread Jasvinder Singh
Add tap object implementation to the application Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 32 + examples/ip_pipeline/main.c | 8 examples/i

[dpdk-dev] [PATCH v2 27/44] ip_pipeline: add threads

2018-03-12 Thread Jasvinder Singh
Add threads data structure and initialisation functions to run the pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 2 +- examples/ip_pipeline/main.c | 8 ++ examples/ip_pipeline/meson.build | 1 + examples/ip_pipeline

[dpdk-dev] [PATCH v2 24/44] ip_pipeline: add kni object

2018-03-12 Thread Jasvinder Singh
Add kni object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 65 +++ examples/ip_pipeline/kni.c | 167 ++

[dpdk-dev] [PATCH v2 22/44] ip_pipeline: add traffic manager object

2018-03-12 Thread Jasvinder Singh
Add traffic manager object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 360 +++ examples/ip_pipeline/main.c | 8 +

[dpdk-dev] [PATCH v2 21/44] ip_pipeline: add software queue object

2018-03-12 Thread Jasvinder Singh
Add swq object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Kevin Laatz --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 55 + examples/ip_pipeline/main.c | 8

[dpdk-dev] [PATCH v2 20/44] ip_pipeline: add link object

2018-03-12 Thread Jasvinder Singh
Add link object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 122 ++ examples/ip_pipeline/link.c | 268

[dpdk-dev] [PATCH v2 19/44] ip_pipeline: add mempool object for pipeline

2018-03-12 Thread Jasvinder Singh
Add mempool object implementation to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Signed-off-by: Fan Zhang --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cli.c | 109 ++- examples/ip_pipeline/co

[dpdk-dev] [PATCH v2 16/44] ip_pipeline: remove config

2018-03-12 Thread Jasvinder Singh
Remove application configuration and script files. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/config/action.cfg | 68 -- examples/ip_pipeline/config/action.sh | 119 --- examples/ip_pipeline/config/action.txt

[dpdk-dev] [PATCH v2 18/44] ip_pipeline: add cli interface

2018-03-12 Thread Jasvinder Singh
CLI interface allowing connectivity with external agent(e.g. telnet, netcat, Python script, etc) is added to the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile| 4 +- examples/ip_pipeline/cli.c | 85 ++ examp

[dpdk-dev] [PATCH v2 14/44] ip_pipeline: remove firewall pipeline

2018-03-12 Thread Jasvinder Singh
Remove firewall pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile |2 - examples/ip_pipeline/init.c|2 - examples/ip_pipeline/meson.build |2 - examples/ip_pipe

[dpdk-dev] [PATCH v2 15/44] ip_pipeline: remove master pipeline

2018-03-12 Thread Jasvinder Singh
remove master pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile |6 - examples/ip_pipeline/app.h | 12 - examples/ip_pipeline/{pipeline => }/hash_func.h|3 +- .../ip_pipeline/{

[dpdk-dev] [PATCH v2 13/44] ip_pipeline: remove flow actions pipeline

2018-03-12 Thread Jasvinder Singh
Remove flow actions pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile |2 - examples/ip_pipeline/init.c|2 - examples/ip_pipeline/meson.build |2 - .../ip_pipel

[dpdk-dev] [PATCH v2 12/44] ip_pipeline: remove flow classification pipeline

2018-03-12 Thread Jasvinder Singh
Remove flow classification pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile |2 - examples/ip_pipeline/init.c|2 - examples/ip_pipeline/meson.build |2 - .../p

[dpdk-dev] [PATCH v2 11/44] ip_pipeline: remove routing pipeline

2018-03-12 Thread Jasvinder Singh
Remove routing pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile |2 - examples/ip_pipeline/init.c|2 - examples/ip_pipeline/meson.build |2 - examples/ip_pipel

[dpdk-dev] [PATCH v2 10/44] ip_pipeline: remove passthrough pipeline

2018-03-12 Thread Jasvinder Singh
remove passthrough pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/Makefile | 2 - examples/ip_pipeline/init.c| 2 - examples/ip_pipeline/meson.build | 2 - .../ip_pipeline/

[dpdk-dev] [PATCH v2 08/44] pipeline: add statistics read action

2018-03-12 Thread Jasvinder Singh
Add implementation of stats read action Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 112 ++- lib/librte_pipeline/rte_table_action.h | 78 +++ 3 files cha

[dpdk-dev] [PATCH v2 09/44] pipeline: add timestamp action

2018-03-12 Thread Jasvinder Singh
Add implementation of timestamp action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 79 +++- lib/librte_pipeline/rte_table_action.h | 31 +++ 3 files changed, 110

[dpdk-dev] [PATCH v2 05/44] pipeline: add packet encapsulation action

2018-03-12 Thread Jasvinder Singh
Add implementation of different type of packet encap such as vlan, qinq, mpls, pppoe, etc. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_table_action.c | 440 - lib/librte_pipeline/rte_table_action.h | 129 ++ 2 files changed, 568 insertio

[dpdk-dev] [PATCH v2 04/44] pipeline: add traffic manager action

2018-03-12 Thread Jasvinder Singh
Add implementation of traffic manager action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/Makefile | 2 +- lib/librte_pipeline/meson.build| 2 +- lib/librte_pipeline/rte_table_action.c | 130 - lib/librte_pipeline/rte_table_act

[dpdk-dev] [PATCH v2 06/44] pipeline: add nat action

2018-03-12 Thread Jasvinder Singh
Add implementation of Network Address Translation(NAT) action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_table_action.c | 162 + lib/librte_pipeline/rte_table_action.h | 39 2 files changed, 201 insertions(+) diff --git a/lib/librte

[dpdk-dev] [PATCH v2 07/44] pipeline: add ttl update action

2018-03-12 Thread Jasvinder Singh
Add implementation of ttl update action. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 155 +++ lib/librte_pipeline/rte_table_action.h | 66 3 files changed,

[dpdk-dev] [PATCH v2 03/44] pipeline: add traffic metering action

2018-03-12 Thread Jasvinder Singh
Add traffic metering action implementation. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/Makefile | 3 +- lib/librte_pipeline/meson.build | 2 +- lib/librte_pipeline/rte_pipeline_version.map | 4 + lib/librte_pipeline/rte_table_action.c | 64

[dpdk-dev] [PATCH v2 02/44] pipeline: get pipeline table action params

2018-03-12 Thread Jasvinder Singh
Add API to specify action related parameters such as action handler, table entry data size, etc. for the pipeline table. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_table_action.c | 132 ++- li

[dpdk-dev] [PATCH v2 01/44] pipeline: add pipeline table action APIs

2018-03-12 Thread Jasvinder Singh
This API provides a common set of actions for pipeline tables to speed up application development. Each match-action rule added to a pipeline table has associated data that stores the action context. This data is input to the table action handler called for every input packet that hits the rule as

[dpdk-dev] [PATCH v2 00/44] ip_pipeline: refactoring

2018-03-12 Thread Jasvinder Singh
Refactored the IP pipeline application. As result, the code base size (lines of code) reduces by ~60%. 1. Moved table actions into the librte_pipeline library. As result, the pre-fabricated pipelines from the application pipeline folder were removed. The flexibility is greatly improved, as n

Re: [dpdk-dev] [PATCH v2] app/testpmd: print Rx/Tx offload values

2018-03-12 Thread Ferruh Yigit
On 3/12/2018 5:26 PM, Yongseok Koh wrote: > >> On Mar 12, 2018, at 8:05 AM, Ferruh Yigit wrote: >> >> Which per port offloads are enabled is not clear. Printing offloads >> values at forwarding start. >> >> CRC strip offload value was printed in more verbose manner, it is >> removed since Rx/Tx o

Re: [dpdk-dev] [PATCH 1/2] net/vmxnet3: set the queue shared buffer at start

2018-03-12 Thread Shrikrishna Khare
On Wed, 17 Jan 2018, Chas Williams wrote: > From: "Charles (Chas) Williams" > > If a reconfiguration happens, queuedesc is reallocated. Any queues that > are preserved point to the previous queuedesc since the queues are only > configured during queue setup. Delay configuration of the shared

Re: [dpdk-dev] [PATCH v3] net/tap: allow user MAC to be passed as args

2018-03-12 Thread Ferruh Yigit
On 3/12/2018 9:53 PM, Vipin Varghese wrote: > Allow TAP PMD to pass user desired MAC address as argument. > The argument value is processed as string delimited by ':', > is parsed and converted to HEX MAC address after validation. > > Signed-off-by: Vipin Varghese > Acked-by: Pascal Mazon Revi

Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-03-12 Thread Stephen Hemminger
On Tue, 13 Mar 2018 01:51:34 +0530 Vipin Varghese wrote: > +static int parse_user_mac(struct ether_addr *user_mac, > + const char *value) > +{ > + unsigned int index = 0; > + char mac_temp[strlen(ETH_TAP_USR_MAC_FMT) + 1], *mac_byte = NULL; > + > + if (user_mac == NULL ||

Re: [dpdk-dev] [PATCH v2] app/testpmd: print Rx/Tx offload values

2018-03-12 Thread Yongseok Koh
> On Mar 12, 2018, at 8:05 AM, Ferruh Yigit wrote: > > Which per port offloads are enabled is not clear. Printing offloads > values at forwarding start. > > CRC strip offload value was printed in more verbose manner, it is > removed since Rx/Tx offload values covers it and printing only CRC one

[dpdk-dev] [PATCH] net/mlx5: remove excessive data prefetch

2018-03-12 Thread Yongseok Koh
In Enhanced Multi-Packet Send (eMPW), entire packet data is prefetched to LLC if it isn't inlined. Even though this helps reducing jitter when HW fetches data by DMA, this can thresh the LLC with evicting precious data. And if the size of queue is large and there are many queues, this might not be

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-12 Thread Ferruh Yigit
On 3/12/2018 2:20 PM, Shahaf Shuler wrote: > > > --Shahaf > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Friday, March 2, 2018 11:44 PM >> To: Mordechay Haimovsky ; >> pascal.ma...@6wind.com >> Cc: dev@dpdk.org; Shahaf Shuler >>

[dpdk-dev] [PATCH v2] vdev: fix name comparison in find_vdev

2018-03-12 Thread Nachiketa Prachanda
Use strcmp to compare device names as the strncmp in original code causes find_vdev to return -EEXIST for names that are prefix of another. The creation of interfaces fails unpredictably based on the order of their creation. An easy way hit this bug is to create eth_vhost1 after eth_vhost11. Fixe

Re: [dpdk-dev] [PATCH v7 1/7] eventtimer: add event timer adapter API

2018-03-12 Thread Carrillo, Erik G
Hi Jerin, Thanks for reviewing. I've responded in-line: > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 12, 2018 2:54 AM > To: Carrillo, Erik G > Cc: pbhagavat...@caviumnetworks.com; dev@dpdk.org; > nipun.gu...@nxp.com; hemant.agra.

[dpdk-dev] [PATCH v3] net/tap: allow user MAC to be passed as args

2018-03-12 Thread Vipin Varghese
Allow TAP PMD to pass user desired MAC address as argument. The argument value is processed as string delimited by ':', is parsed and converted to HEX MAC address after validation. Signed-off-by: Vipin Varghese Acked-by: Pascal Mazon --- Changed in V3: - change the default init for user_mac -

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-12 Thread Trahe, Fiona
Hi Shally, Ahmed, and anyone else interested in compressdev, I mentioned last week that we've been exploring using something other than mbufs to pass src/dst buffers to compressdev PMDs. Reasons: - mbuf data is limited to 64k-1 in each segment of a chained mbuf. Data for compression can be

Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK

2018-03-12 Thread NĂ©lio Laranjeiro
On Fri, Mar 09, 2018 at 10:42:03AM +, Burakov, Anatoly wrote: > On 09-Mar-18 9:15 AM, Pavan Nikhilesh wrote: > > On Thu, Mar 08, 2018 at 08:33:21PM +, Burakov, Anatoly wrote: > > > On 08-Mar-18 8:11 PM, Burakov, Anatoly wrote: > > > > On 08-Mar-18 2:36 PM, Burakov, Anatoly wrote: > > > > >

[dpdk-dev] [RFC] Switch device offload with DPDK

2018-03-12 Thread Adrien Mazarguil
Hi All, (I tried to CC key people part of related discussions but likely missed many, feel free to add them back) The following RFC formalizes what has been discussed so far regarding switch offload control using rte_flow through port/VF representors. It doesn't bring new ideas besides the "trans

Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-03-12 Thread Varghese, Vipin
Sure Ferruh, I will spin a new one. > -Original Message- > From: Yigit, Ferruh > Sent: Monday, March 12, 2018 8:39 PM > To: Varghese, Vipin ; dev@dpdk.org; > pascal.ma...@6wind.com > Subject: Re: [PATCH v2] net/tap: allow user MAC to be passed as args > > On 3/12/2018 8:21 PM, Vipin Vargh

Re: [dpdk-dev] [PATCH] examples: fix building examples with meson

2018-03-12 Thread Bruce Richardson
On Mon, Mar 12, 2018 at 03:28:20PM +, Bruce Richardson wrote: > The ip_pipeline and qos_meter example apps now use experimental APIs so > this fact needs to be flagged in their meson.build files. > > Fixes: c06ddf9698e0 ("meter: add configuration profile") > > Signed-off-by: Bruce Richardson

[dpdk-dev] [PATCH] examples: fix building examples with meson

2018-03-12 Thread Bruce Richardson
The ip_pipeline and qos_meter example apps now use experimental APIs so this fact needs to be flagged in their meson.build files. Fixes: c06ddf9698e0 ("meter: add configuration profile") Signed-off-by: Bruce Richardson --- examples/ip_pipeline/meson.build | 1 + examples/qos_meter/meson.build

Re: [dpdk-dev] [PATCH] net/pcap: simplify dependency checking using meson

2018-03-12 Thread Bruce Richardson
On Thu, Feb 22, 2018 at 11:30:44PM +0530, Hemant Agrawal wrote: > On 2/22/2018 10:50 PM, Bruce Richardson wrote: > > Rather than trying to use meson's build-in detection for libpcap, and > > having to special-case cross-building, just check for the presence of > > pcap.h and the pcap library. > >

Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-03-12 Thread Ferruh Yigit
On 3/12/2018 8:21 PM, Vipin Varghese wrote: > @@ -1591,7 +1632,7 @@ enum ioctl_mode { > int speed; > char tap_name[RTE_ETH_NAME_MAX_LEN]; > char remote_iface[RTE_ETH_NAME_MAX_LEN]; > - int fixed_mac_type = 0; > + struct ether_addr user_mac = { .addr_bytes = {0, 0, 0, 0, 0,

Re: [dpdk-dev] [PATCH] net/virtio: add driver to meson build

2018-03-12 Thread Bruce Richardson
On Wed, Feb 21, 2018 at 01:56:10PM +0100, Maxime Coquelin wrote: > > > On 02/16/2018 06:21 PM, Bruce Richardson wrote: > > Signed-off-by: Bruce Richardson > > --- > > drivers/net/meson.build| 2 +- > > drivers/net/virtio/meson.build | 27 +++ > > 2 files chan

Re: [dpdk-dev] [PATCH 0/3] generalize builds apps using meson

2018-03-12 Thread Bruce Richardson
On Fri, Feb 16, 2018 at 04:53:33PM +, Bruce Richardson wrote: > Put the building of the apps into a foreach loop as is done with the libs > and drivers in the DPDK meson build. This will reduce the path needed to > call the compiled binaries in the build directory by one level, while the > main

[dpdk-dev] [PATCH v2] app/testpmd: print Rx/Tx offload values

2018-03-12 Thread Ferruh Yigit
Which per port offloads are enabled is not clear. Printing offloads values at forwarding start. CRC strip offload value was printed in more verbose manner, it is removed since Rx/Tx offload values covers it and printing only CRC one can cause confusion. Hexadecimal offloads values are not very us

[dpdk-dev] [PATCH] app/testpmd: print Rx/Tx offload values

2018-03-12 Thread Ferruh Yigit
Which per port offloads are enabled is not clear. Printing offloads values at forwarding start. CRC strip offload value was printed in more verbose manner, it is removed since Rx/Tx offload values covers it and printing only CRC one can cause confusion. Hexadecimal offloads values are not very us

[dpdk-dev] [PATCH v2] event/sw: perform partial burst enqueues

2018-03-12 Thread Gage Eads
Previously, the sw PMD would enqueue either all or no events, depending on if enough inflight credits were available for the new events in the burst. If a port is enqueueing a large burst (i.e. a multiple of the credit update quanta), this can result in suboptimal performance, and requires an under

[dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args

2018-03-12 Thread Vipin Varghese
Allow TAP PMD to pass user desired MAC address as argument. The argument value is processed as string delimited by ':', is parsed and converted to HEX MAC address after validation. Signed-off-by: Vipin Varghese Acked-by: Pascal Mazon --- Changes in V2: - updated the auto variable for user_mac

Re: [dpdk-dev] [PATCH v2 1/2] eventdev: add device stop flush callback

2018-03-12 Thread Jerin Jacob
-Original Message- > Date: Mon, 12 Mar 2018 14:30:49 + > From: "Eads, Gage" > To: Jerin Jacob > CC: "dev@dpdk.org" , "Van Haaren, Harry" > , "hemant.agra...@nxp.com" > , "Richardson, Bruce" > , "santosh.shu...@caviumnetworks.com" > , "nipun.gu...@nxp.com" > > Subject: RE: [PATCH

Re: [dpdk-dev] [PATCH v2 1/2] eventdev: add device stop flush callback

2018-03-12 Thread Eads, Gage
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 12, 2018 1:25 AM > To: Eads, Gage > Cc: dev@dpdk.org; Van Haaren, Harry ; > hemant.agra...@nxp.com; Richardson, Bruce ; > santosh.shu...@caviumnetworks.com; nipun.gu...@nxp.com > Subjec

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-12 Thread Shahaf Shuler
--Shahaf > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, March 2, 2018 11:44 PM > To: Mordechay Haimovsky ; > pascal.ma...@6wind.com > Cc: dev@dpdk.org; Shahaf Shuler > Subject: Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx o

[dpdk-dev] [PATCH v2 3/3] net/mlx5: fix link status to use wait to complete

2018-03-12 Thread Nelio Laranjeiro
Wait to complete is present to let the application get a correct status when it requires it, it should not be ignored. Fixes: e313ef4c2fe8 ("net/mlx5: fix link state on device start") Fixes: cb8faed7dde8 ("mlx5: support link status update") Cc: shah...@mellanox.com Cc: adrien.mazarg...@6wind.com C

[dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-12 Thread Nelio Laranjeiro
This behavior is mixed between what should be handled by the application and what is under PMD responsibility. According to DPDK API: - link_update() should only query the link status [1] - link_set_{up,down}() should only set the link to the according status [1] - dev_{start,stop}() should enable

[dpdk-dev] [PATCH v2 1/3] net/mlx5: remove kernel version check

2018-03-12 Thread Nelio Laranjeiro
Kernel version check was introduced in commit 3a49ffe38a95 ("net/mlx5: fix link status query") due to a bug fixed by commit ef09a7fc7620 ("net/mlx5: fix inconsistent link status query") This patch restore the previous behavior as described in Linux API. Signed-off-by: Nelio Laranjeiro Acked-by:

[dpdk-dev] [PATCH v2 0/3] net/mlx5: cleanup link status

2018-03-12 Thread Nelio Laranjeiro
This series applies on top of [1] and cleans up the DPDK API implementation for the link status. [1] https://dpdk.org/dev/patchwork/patch/35653/ Changes in v2: - Removes kernel version verification, the bug it tried to detected was fixed several commit after in the PMD. Implementation in mlx5

[dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag

2018-03-12 Thread Ferruh Yigit
ICC warning #188 already disabled globally via commit [1], no need individual arguments in PMDs. [1] Fixes: 1b80b9c854c3 ("mk: disable icc warning 188") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- drivers/net/bnx2x/Makefile | 4 drivers/net/cxgbe/Makefile | 8 drivers/net/

[dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter

2018-03-12 Thread Ferruh Yigit
With icc (ICC) 18.0.1 20171018, -wd usage generates following warning: icc: command line remark #10010: option '-wd3656' is deprecated and will be removed in a future release. See '-help deprecated' "icc -help deprecated" output is: -wd use -diag-disable Based on above infor

Re: [dpdk-dev] [PATCH 0/7] Change DPAA2 to dynamic logging

2018-03-12 Thread Shreyansh Jain
On 3/12/2018 2:55 PM, Shreyansh Jain wrote: DPAA2 devices are enabled by: - bus/fslmc - net/dpaa2 - mempool/dpaa2 - event/dpaa2 and - crypto/dpaa2_sec This patch series converts the existing static debugging macros - for control and datapath, both - into dynamic logging macros. Identified for l

Re: [dpdk-dev] [PATCH 2/3] app/proc_info: rename folder to remove underscore

2018-03-12 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, February 16, 2018 4:54 PM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH 2/3] app/proc_info: rename folder to remove > underscore > > All other apps in the app folder use "-" rather th

Re: [dpdk-dev] [PATCH 3/3] app: add all remaining apps to meson build

2018-03-12 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, February 16, 2018 4:54 PM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH 3/3] app: add all remaining apps to meson build > > Add remaining subdirectories in the app folder to the meson

Re: [dpdk-dev] [PATCH 1/3] app: generalize building of apps using meson

2018-03-12 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, February 16, 2018 4:54 PM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH 1/3] app: generalize building of apps using meson > > Since most apps are built in largely the same way, genera

  1   2   >