Re: [dpdk-dev] [PATCH 07/10] event/octeontx: optimize timer adapter resolution parameters

-Original Message- > Date: Sat, 17 Feb 2018 03:06:57 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com, > erik.g.carri...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 07/10] event/octeontx: optimize timer a

Re: [dpdk-dev] [PATCH 10/10] maintainers: claim responsibility for octeontx timvf

-Original Message- > Date: Sat, 17 Feb 2018 03:07:00 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com, > erik.g.carri...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 10/10] maintainers: claim responsibilit

Re: [dpdk-dev] [PATCH 09/10] event/octeontx: add timer adapter SW traversal routine

-Original Message- > Date: Sat, 17 Feb 2018 03:06:59 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com, > erik.g.carri...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 09/10] event/octeontx: add timer adapte

Re: [dpdk-dev] [PATCH 02/10] mempool/octeontx: probe timvf PCIe devices

-Original Message- > Date: Sat, 17 Feb 2018 03:06:52 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com, > erik.g.carri...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 02/10] mempool/octeontx: probe timvf PC

Re: [dpdk-dev] [PATCH 01/10] eal: add API to align variable to previous power of 2

-Original Message- > Date: Sat, 17 Feb 2018 03:06:51 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com, > erik.g.carri...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 01/10] eal: add API to align variable t

Re: [dpdk-dev] [PATCH v1] doc: add template release notes for 18.05

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of John McNamara > Sent: Thursday, February 15, 2018 7:04 AM > To: dev@dpdk.org > Cc: Mcnamara, John > Subject: [dpdk-dev] [PATCH v1] doc: add template release notes for 18.05 > > Add template release notes for DPDK

[dpdk-dev] [PATCH 10/10] maintainers: claim responsibility for octeontx timvf

Signed-off-by: Pavan Nikhilesh --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a646ca3e1..35c3caeb7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -762,6 +762,10 @@ M: Peter Mccarthy F: drivers/event/opdl/ F: doc/guides/eventdevs/opdl.rst

[dpdk-dev] [PATCH 09/10] event/octeontx: add timer adapter SW traversal routine

Signed-off-by: Pavan Nikhilesh --- config/common_base| 1 + drivers/event/octeontx/timvf_worker.h | 105 ++ 2 files changed, 106 insertions(+) diff --git a/config/common_base b/config/common_base index 00010de92..2f8c21871 100644 --- a/config

[dpdk-dev] [PATCH 07/10] event/octeontx: optimize timer adapter resolution parameters

When application sets `RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES` flag while creating adapter underlying driver is free to optimize the resolution for best possible configuration. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 51 +++- driver

[dpdk-dev] [PATCH 08/10] event/octeontx: add option to use fpavf as chunk pool

Add compile-time configurable option to force TIMvf to use Octeontx FPAvf pool manager as its chunk pool. When FPAvf is used as pool manager the TIMvf automatically frees the chunks to FPAvf through gpool-id. Signed-off-by: Pavan Nikhilesh --- config/common_base| 1 + driver

[dpdk-dev] [PATCH 06/10] event/octeontx: add single producer timer arm variant

When application creates the timer adapter by passing `RTE_EVENT_TIMER_ADAPTER_F_SP_PUT` flag, we can optimize the arm sequence by removing the locking overhead. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 22 +++- drivers/event/octeontx/timvf_evdev.h | 5 + dr

[dpdk-dev] [PATCH 05/10] event/octeontx: add support for arm and cancel

Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/Makefile | 5 + drivers/event/octeontx/meson.build| 1 + drivers/event/octeontx/timvf_evdev.c | 11 +- drivers/event/octeontx/timvf_evdev.h | 31 drivers/event/octeontx/timvf_worker.c | 53 +++ drivers/event/oct

[dpdk-dev] [PATCH 04/10] event/octeontx: add support to start and stop timer device

When application requests to start the timer adapter through `rte_event_timer_adapter_start`, Octeontx TIMvf ring does the following: - Uses mbox to communicate TIMpf driver about, * SCLK frequency used to convert ns<->cycles. * program the ring control parameters and start the ring. * get th

[dpdk-dev] [PATCH 01/10] eal: add API to align variable to previous power of 2

Add 32b and 64b API's to align the given variable to the previous power of 2. Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/common/include/rte_common.h | 36 ++ 1 file changed, 36 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte

[dpdk-dev] [PATCH 0/9] event/octeontx: add event timer adapter driver

The event timer adapter[1] provides APIs to configure an event timer device that allows an application to arm timers which on expiry push events to an event device such as OcteonTx SSO. The OcteonTx TIM is a co-processor that can be configured as an event timer adapter which can be used by an appli

[dpdk-dev] [PATCH 03/10] event/octeontx: add support to create and free timer adapter

When the application requests to create a timer device, Octeontx TIM create does the following: - Get the requested TIMvf ring based on adapter_id. - Verify the config parameters supplied. - Allocate memory required for * Buckets based on min and max timeout supplied. * Allocate the chunk pool

[dpdk-dev] [PATCH 02/10] mempool/octeontx: probe timvf PCIe devices

On Octeontx HW, each event timer device is enumerated as separate SRIOV VF PCIe device. In order to expose as a event timer device: On PCIe probe, the driver stores the information associated with the PCIe device and later when appliacation requests for a event timer device through `rte_event_time

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

>> -Original Message- >> From: Verma, Shally [mailto:shally.ve...@cavium.com] >> Sent: Friday, February 16, 2018 7:17 AM >> To: Ahmed Mansour ; Trahe, Fiona >> ; >> dev@dpdk.org >> Cc: Athreya, Narayana Prasad ; Gupta, >> Ashish >> ; Sahu, Sunila ; De Lara >> Guarch, Pablo >> ; Challa, M

Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

On Wed, 29 Nov 2017 16:42:00 +0100 Tomasz Kulasek wrote: > + /* Some devices needs more time to initialize and bring interface up. > + * While link status up is preferable we wait some time to be sure that > + * link status of slave is valid. > + */ > + if (slave_eth_dev->d

Re: [dpdk-dev] [RFC v2] sched: parameterize QoS traffic-classes and queues

On Fri, 16 Feb 2018 15:44:13 + alangordonde...@gmail.com wrote: > - qindex = tc_index * 4; > - > - pipe->wrr_tokens[qindex] = (grinder->wrr_tokens[0] & > grinder->wrr_mask[0]) > - >> RTE_SCHED_WRR_SHIFT; > - pipe->wrr_tokens[qindex + 1] = (grinder->wrr_tokens[1] & >

Re: [dpdk-dev] [RFC v2] sched: parameterize QoS traffic-classes and queues

On Fri, 16 Feb 2018 15:44:13 + alangordonde...@gmail.com wrote: > > +static inline uint32_t > +rte_min_pos_n_u16(uint16_t *x, uint32_t n) The table (x) is const > +{ > + uint32_t index; > + uint32_t min_index = 0; > + uint16_t min_value = UINT16_MAX; > + > + for (index = 0;

[dpdk-dev] [PATCH] config: remove RTE_LOG_LEVEL

The old RTE_LOG_LEVEL has been replaced by RTE_DP_LOG_LEVEL and is not used anywhere in the currrent source tree. Signed-off-by: Stephen Hemminger --- config/rte_config.h | 1 - 1 file changed, 1 deletion(-) diff --git a/config/rte_config.h b/config/rte_config.h index 699878adb62a..08bcb1c3d043

Re: [dpdk-dev] [RFC v2, 2/2] eventdev: add crypto adapter API header

-Original Message- > Date: Mon, 15 Jan 2018 16:23:50 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, narender.vang...@intel.com, Abhinandan Gujjar > , Nikhil Rao , Gage > Eads > Subject: [RFC v2, 2/2] eventdev: add crypto adapter API header > X-M

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: add kernel version function

On Thu, 15 Feb 2018 09:47:27 +0100 Nelio Laranjeiro wrote: > Use a function to retrieve the version of the kernel. > > Signed-off-by: Nelio Laranjeiro This type of logic will run into problems with Enterprise and vendor kernels. What about users using older kernels with OFED? What about case w

Re: [dpdk-dev] release/acquire memory barriers and ring

On Tue, 13 Feb 2018 22:37:37 +0300 Alex Kiselev wrote: > Hi. > > I've been wondering should I use a release/acquire memory barrier pair > in order to be sure that the other thread will see the fully/corrected > initialized object > passed to it via a dpdk ring or ring itself is a kind of barrier

[dpdk-dev] [PATCH] net/virtio: add driver to meson build

Signed-off-by: Bruce Richardson --- drivers/net/meson.build| 2 +- drivers/net/virtio/meson.build | 27 +++ 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 drivers/net/virtio/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meso

[dpdk-dev] [PATCH 3/3] app: add all remaining apps to meson build

Add remaining subdirectories in the app folder to the meson build. Signed-off-by: Bruce Richardson --- app/meson.build | 6 +- app/pdump/meson.build| 6 ++ app/proc-info/meson.build| 6 ++ app/test-bbdev/meson.build | 9 + app/te

[dpdk-dev] [PATCH 1/3] app: generalize building of apps using meson

Since most apps are built in largely the same way, generalize the logic into a foreach loop in app/meson.build file. Signed-off-by: Bruce Richardson --- app/meson.build | 52 +-- app/test-eventdev/meson.build | 18 ++- app/test-pm

[dpdk-dev] [PATCH 2/3] app/proc_info: rename folder to remove underscore

All other apps in the app folder use "-" rather than "_" to separate words in the app name, so rename proc_info to be consistent. Signed-off-by: Bruce Richardson --- app/Makefile | 2 +- app/{proc_info => proc-info}/Makefile | 0 app/{proc_info => proc-info}/main.c | 0

[dpdk-dev] [PATCH 0/3] generalize builds apps using meson

Put the building of the apps into a foreach loop as is done with the libs and drivers in the DPDK meson build. This will reduce the path needed to call the compiled binaries in the build directory by one level, while the main benefit is reduced code duplication between the different apps. Bruce Ri

[dpdk-dev] [RFC v2] sched: parameterize QoS traffic-classes and queues

From: Alan Dewar The DPDK QoS framework has hierarchy of QoS scheduling elements: port, subport, pipe, traffic-class and queue. The first two levels of the hierarchy are flexible (port and subport) in the number child nodes that each parent can have, but from the pipe layer down the number of ch

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: fix traffic restart function to return errors

On Thu, Feb 15, 2018 at 10:29:27AM +0100, Nelio Laranjeiro wrote: > priv_dev_traffic_restart() was considering nothing could fail whereas it > can. How about simply describing it as: priv_dev_traffic_restart() must not ignore errors. > Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast

Re: [dpdk-dev] [PATCH 2/3] net/mlx5: convert return errno to negative ones

How about reusing the title/commit log of its mlx4 counterpart: net/mlx5: standardize on negative errno values (see 9d14b27308a0 "net/mlx4: standardize on negative errno values") More below. On Thu, Feb 15, 2018 at 10:29:26AM +0100, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro >

Re: [dpdk-dev] [PATCH 1/3] net/mlx5: add missing function documentation

I hate to sound pedantic but... On Thu, Feb 15, 2018 at 10:29:25AM +0100, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > Acked-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_trigger.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/

Re: [dpdk-dev] [PATCH] net/mlx4: use PCI address as port name

On Sun, Feb 11, 2018 at 04:29:32PM +0800, Yuanhan Liu wrote: > It is suggested to use PCI BDF to identify a port for port addition > in OVS-DPDK. While mlx5 has its own naming style: name it by ib dev ^ I believe you mean mlx4 here? > name. This breaks the typical OVS DP

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: add command to resume a TM node

> -Original Message- > From: Tomasz Duszynski [mailto:t...@semihalf.com] > Sent: Thursday, February 1, 2018 9:37 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Singh, Jasvinder ; > Tomasz Duszynski > Subject: [PATCH 2/2] app/testpmd: add command to resume a TM node > > Traff

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Friday, February 16, 2018 7:17 AM > To: Ahmed Mansour ; Trahe, Fiona > ; > dev@dpdk.org > Cc: Athreya, Narayana Prasad ; Gupta, > Ashish > ; Sahu, Sunila ; De Lara > Guarch, Pablo > ; Challa, Mahipal >

Re: [dpdk-dev] [PATCH v2] net/tap: add CRC stripping capability

15/02/2018 22:55, Stephen Hemminger: > On Tue, 13 Feb 2018 17:35:20 +0100 > Thomas Monjalon wrote: > > > 13/02/2018 09:14, Ophir Munk: > > > CRC stripping is executed in the kernel outside of TAP PMD scope. > > > There is no prevention that the TAP PMD will report on Rx CRC > > > stripping capabi

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix link status to use wait to complete

On Fri, Feb 16, 2018 at 11:49:00AM +0100, Adrien Mazarguil wrote: > On Thu, Feb 15, 2018 at 09:47:28AM +0100, Nelio Laranjeiro wrote: > > Wait to complete is present to let the application get a correct status > > when it requires it, it should not be ignored. > > > > Fixes: cb8faed7dde8 ("mlx5: s

Re: [dpdk-dev] [PATCH] net/mlx5: change tunnel flow priority

A few commit log rewording suggestions for clarity and a couple of additional comments below, otherwise patch looks fine. On Thu, Feb 15, 2018 at 10:23:29AM +0100, Nelio Laranjeiro wrote: > Packet matching inner and outer flow rules are catch by the first one catch => caught > added in the devic

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

> -Original Message- > From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] > Sent: Thursday, February 15, 2018 7:51 PM > To: Trahe, Fiona ; Verma, Shally > ; dev@dpdk.org > Cc: Athreya, Narayana Prasad ; Gupta, > Ashish > ; Sahu, Sunila ; De Lara > Guarch, Pablo > ; Challa, Mahipal > ;

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix link status to use wait to complete

On Thu, Feb 15, 2018 at 09:47:28AM +0100, Nelio Laranjeiro wrote: > Wait to complete is present to let the application get a correct status > when it requires it, it should not be ignored. > > Fixes: cb8faed7dde8 ("mlx5: support link status update") > Cc: adrien.mazarg...@6wind.com > > Signed-off

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: add kernel version function

On Thu, Feb 15, 2018 at 09:47:27AM +0100, Nelio Laranjeiro wrote: > Use a function to retrieve the version of the kernel. > > Signed-off-by: Nelio Laranjeiro A couple of nits, please see below. > --- > drivers/net/mlx5/mlx5_ethdev.c | 13 + > drivers/net/mlx5/mlx5_utils.h | 26 +++

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

On 15-Feb-18 8:53 PM, Ravi Kerur wrote: On Thu, Feb 15, 2018 at 10:27 AM, Ravi Kerur > wrote: On Thu, Feb 15, 2018 at 2:28 AM, Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 14-Feb-18 8:00 PM, Ravi Kerur wrote: Earlier I

Re: [dpdk-dev] [PATCH] app/testpmd: allow setting shaper profile id to none

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Friday, February 16, 2018 8:14 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Tomasz Duszynski > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: allow setting shaper profile id >

Re: [dpdk-dev] [PATCH] app/testpmd: allow setting shaper profile id to none

On Tue, Jan 30, 2018 at 08:37:08AM +0100, Tomasz Duszynski wrote: > Private shaper profiles are attached to nodes defined > in traffic manager hierarchy. > > Since not every node must have a configured shaper > testpmd should allow setting shaper profile id to > invalid (RTE_TM_SHAPER_PROFILE_ID_NO

Re: [dpdk-dev] [PATCH 0/2] add suspend/resume TM node commands to testpmd

On Thu, Feb 01, 2018 at 10:36:37AM +0100, Tomasz Duszynski wrote: > Add new testpmd commands for invoking traffic manager suspend/resume API. > > Tomasz Duszynski (2): > app/testpmd: add command to suspend a TM node > app/testpmd: add command to resume a TM node > > app/test-pmd/cmdline.c