Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-15 Thread Verma, Shally
Hi Fiona, Ahmed >-Original Message- >From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] >Sent: 16 February 2018 02:40 >To: Trahe, Fiona ; Verma, Shally >; dev@dpdk.org >Cc: Athreya, Narayana Prasad ; Gupta, >Ashish ; Sahu, Sunila >; De Lara Guarch, Pablo >; Challa, Mahipal >; Jain, Deep

Re: [dpdk-dev] [PATCH V2, 1/2] eventdev: add caps API and PMD callback for crypto adapter

2018-02-15 Thread Gujjar, Abhinandan S
Hi Jerin, Thanks for the review. Few comments inline. > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Thursday, February 15, 2018 6:40 PM > To: Gujjar, Abhinandan S > Cc: dev@dpdk.org; Rao, Nikhil > Subject: Re: [PATCH V2, 1/2] eventdev: add caps

[dpdk-dev] [PATCH 2/2] eal: use %zu to format size_t

2018-02-15 Thread Stephen Hemminger
The recommended way to format size_t in printf is to use the z modifier which handles the case where size_t maybe 32 or 64 bits. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/eal/eal_memory.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_ea

[dpdk-dev] [PATCH 0/2] use %z for formatting

2018-02-15 Thread Stephen Hemminger
Better to use %z and avoid any 32 bit platform woes; and not cast unnecessarily Stephen Hemminger (2): pci: use %z to format size_t eal: use %zu to format size_t lib/librte_eal/linuxapp/eal/eal_memory.c | 8 lib/librte_pci/rte_pci.c | 11 ++- 2 files changed

[dpdk-dev] [PATCH 1/2] pci: use %z to format size_t

2018-02-15 Thread Stephen Hemminger
This addresses potential issues where size_t and off_t can vary on some platforms. For size_t the best way to format the value is to use the z modifier to printf. For off_t need to cast to long long to handle 64 bit offset on 32 bit platforms. Signed-off-by: Stephen Hemminger --- lib/librte_pci

Re: [dpdk-dev] [PATCH v2] net/tap: add CRC stripping capability

2018-02-15 Thread Stephen Hemminger
On Tue, 13 Feb 2018 17:35:20 +0100 Thomas Monjalon wrote: > 13/02/2018 09:14, Ophir Munk: > > CRC stripping is executed in the kernel outside of TAP PMD scope. > > There is no prevention that the TAP PMD will report on Rx CRC > > stripping capability. > > In the corrupted code, TAP PMD did not re

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-15 Thread Ahmed Mansour
On 2/15/2018 1:47 PM, Trahe, Fiona wrote: > Hi Shally, Ahmed, > Sorry for the delay in replying, > Comments below > >> -Original Message- >> From: Verma, Shally [mailto:shally.ve...@cavium.com] >> Sent: Wednesday, February 14, 2018 7:41 AM >> To: Ahmed Mansour ; Trahe, Fiona >> ; >> dev@d

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-15 Thread Ravi Kerur
On Thu, Feb 15, 2018 at 10:27 AM, Ravi Kerur wrote: > > > On Thu, Feb 15, 2018 at 2:28 AM, Burakov, Anatoly < > anatoly.bura...@intel.com> wrote: > >> On 14-Feb-18 8:00 PM, Ravi Kerur wrote: >> >>> >>> Earlier I was focusing only on DMAR errors and I might have said 'it >>> worked' when I didn't

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-15 Thread Ahmed Mansour
/// snip /// > [Fiona] I propose if BFINAL bit is detected before end of input the decompression should stop. In this case consumed will be < src.length. produced will be < dst buffer size. Do we need an extra STATUS response? STATUS_BFINA

Re: [dpdk-dev] [PATCH] ethdev: adjust error log level

2018-02-15 Thread Stephen Hemminger
On Tue, 13 Feb 2018 15:03:47 + Martin Klozik wrote: > DPDK API does not propagate the reason of device allocation failure > from rte_eth_dev_allocate() up to the DPDK application (e.g. Open > vSwitch). > Log level of associated log entries was changed to warning. So user > can find additional

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-15 Thread Trahe, Fiona
Hi Shally, Ahmed, Sorry for the delay in replying, Comments below > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Wednesday, February 14, 2018 7:41 AM > To: Ahmed Mansour ; Trahe, Fiona > ; > dev@dpdk.org > Cc: Athreya, Narayana Prasad ; Gupta, > Ashi

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-15 Thread Ravi Kerur
On Thu, Feb 15, 2018 at 2:28 AM, Burakov, Anatoly wrote: > On 14-Feb-18 8:00 PM, Ravi Kerur wrote: > >> >> Earlier I was focusing only on DMAR errors and I might have said 'it >> worked' when I didn't notice them on host when dpdk was started on guest. >> When trying to send packets out of that i

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-15 Thread Trahe, Fiona
Hi Ahmed, Shally, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Thursday, February 15, 2018 5:53 AM > To: Ahmed Mansour ; Trahe, Fiona > ; > dev@dpdk.org > Cc: Athreya, Narayana Prasad ; Gupta, > Ashish > ; Sahu, Sunila ; De Lara > Guarch, Pablo > ;

Re: [dpdk-dev] [PATCH] doc: add kernel version deprecation notice

2018-02-15 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Feb 14, 2018 at 10:08:34AM -0800, Stephen Hemminger wrote: >> On Wed, 14 Feb 2018 11:44:15 + >> Bruce Richardson wrote: >> >> > On Wed, Feb 14, 2018 at 10:54:44AM +, Luca Boccassi wrote: >> > > On Wed, 2018-02-14 at 11:38 +0100, Maxime Coquelin wrote:

[dpdk-dev] Invitation to take part in collaborative development of compressdev API

2018-02-15 Thread Trahe, Fiona
Hi, We've set up a github repo for a joint collaboration effort on the compressdev API and test code. Developers from Cavium, NXP and Intel are already planning to use this collaboration space, if anyone else would like to collaborate with us please join in. The repo is here: https://gith

Re: [dpdk-dev] [PATCH V2, 1/2] eventdev: add caps API and PMD callback for crypto adapter

2018-02-15 Thread Jerin Jacob
-Original Message- > Date: Mon, 15 Jan 2018 16:22:50 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Abhinandan Gujjar , Nikhil > Rao > Subject: [PATCH V2, 1/2] eventdev: add caps API and PMD callback for crypto > adapter > X-Mailer: git-send-ema

[dpdk-dev] [PATCH v1] doc: add template release notes for 18.05

2018-02-15 Thread John McNamara
Add template release notes for DPDK 18.05 with inline comments and explanations of the various sections. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_18_05.rst | 187 + 1 file changed, 187 insertions(+) create mode 100644 doc/guides/rel_notes/rel

[dpdk-dev] doc for multi-process communication

2018-02-15 Thread Thomas Monjalon
Hi Jianfeng, The new experimental API for IPC is not documented a lot. We need some words in the prog guide, and some doxygen comments for the structures rte_mp_msg and rte_mp_reply. Please could you add this for the 18.05-rc1 release? Thank you

Re: [dpdk-dev] [RFC v1 1/1] lib/cryptodev: add support of asymmetric crypto

2018-02-15 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Thursday, February 15, 2018 5:33 AM > To: Trahe, Fiona ; dev@dpdk.org; Athreya, Narayana > Prasad > ; Murthy, Nidadavolu > ; > Sahu, Sunila ; Gupta, Ashish > ; Doherty, Declan > ; Keating, Bri

[dpdk-dev] [PATCH v2] eal: register log type and pick level from EAL args

2018-02-15 Thread Andrew Rybchenko
From: Ivan Malov Dynamic log types are registered on RTE_INIT() step. This allows one to set log levels by EAL options on application launch. However, this does not allow to manage log types if they are created during runtime. EAL does not store log levels and types passed from the command line.

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-15 Thread Burakov, Anatoly
On 14-Feb-18 8:00 PM, Ravi Kerur wrote: Earlier I was focusing only on DMAR errors and I might have said 'it worked' when I didn't notice them on host when dpdk was started on guest. When trying to send packets out of that interface from guest I did see DMAR errors. I am attaching information

[dpdk-dev] [PATCH 1/3] net/mlx5: add missing function documentation

2018-02-15 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_trigger.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index f5711a998..a70b13d52 100644 --- a/drivers/net/mlx

[dpdk-dev] [PATCH 2/3] net/mlx5: convert return errno to negative ones

2018-02-15 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 19 - drivers/net/mlx5/mlx5_ethdev.c | 30 -- drivers/net/mlx5/mlx5_flow.c| 92 + drivers/net/mlx5/mlx5_mac.c | 7 ++-- drivers/net/m

[dpdk-dev] [PATCH 3/3] net/mlx5: fix traffic restart function to return errors

2018-02-15 Thread Nelio Laranjeiro
priv_dev_traffic_restart() was considering nothing could fail whereas it can. Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_trigger.c | 10 +++--- 1 file changed, 7 i

Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: add support for wind river avp device

2018-02-15 Thread Burakov, Anatoly
On 14-Feb-18 11:17 PM, Zhang, Xiaohua wrote: That's no problem for me to move it to the "network" catalog. Should I generate a new patch? Yes, please. -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH] doc: add kernel version deprecation notice

2018-02-15 Thread Bruce Richardson
On Wed, Feb 14, 2018 at 10:08:34AM -0800, Stephen Hemminger wrote: > On Wed, 14 Feb 2018 11:44:15 + > Bruce Richardson wrote: > > > On Wed, Feb 14, 2018 at 10:54:44AM +, Luca Boccassi wrote: > > > On Wed, 2018-02-14 at 11:38 +0100, Maxime Coquelin wrote: > > > > > > > > On 02/14/2018 1

[dpdk-dev] [PATCH] net/mlx5: change tunnel flow priority

2018-02-15 Thread Nelio Laranjeiro
Packet matching inner and outer flow rules are catch by the first one added in the device as both flows are configured with the same priority. To avoid such situation, the inner flow can have an higher priority than the outer ones as their pattern matching will not collide. Signed-off-by: Nelio La

[dpdk-dev] [PATCH 2/2] net/mlx5: fix link status to use wait to complete

2018-02-15 Thread Nelio Laranjeiro
Wait to complete is present to let the application get a correct status when it requires it, it should not be ignored. Fixes: cb8faed7dde8 ("mlx5: support link status update") Cc: adrien.mazarg...@6wind.com Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 35

[dpdk-dev] [PATCH 1/2] net/mlx5: add kernel version function

2018-02-15 Thread Nelio Laranjeiro
Use a function to retrieve the version of the kernel. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 13 + drivers/net/mlx5/mlx5_utils.h | 26 ++ 2 files changed, 31 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethde