Re: [dpdk-dev] [PATCH 13/18] net/liquidio: align dynamic log names with standard

2018-01-26 Thread Shijith Thotton
On Thu, Jan 25, 2018 at 09:01:05AM +, Harry van Haaren wrote: > This commit aligns the names for dynamic logging with > the newly defined logging format. > > Note that the "lio" term has been replaced with "liquidio", > as the naming scheme defines that a PMD name should be the > same as the d

Re: [dpdk-dev] [PATCH V13 1/3] eal: add uevent monitor api and callback func

2018-01-26 Thread Guo, Jia
On 1/27/2018 12:53 AM, Bruce Richardson wrote: On Fri, Jan 26, 2018 at 11:49:35AM +0800, Jeff Guo wrote: This patch aim to add a general uevent mechanism in eal device layer, to enable all linux kernel object uevent monitoring, user could use these APIs to monitor and read out the device statu

Re: [dpdk-dev] [PATCH v8 01/15] eal: introduce atomic exchange operation

2018-01-26 Thread Stephen Hemminger
On Fri, 26 Jan 2018 17:24:40 + Bruce Richardson wrote: > On Fri, Jan 26, 2018 at 06:14:01PM +0100, Thomas Monjalon wrote: > > 26/01/2018 03:01, Stephen Hemminger: > > > To handle atomic update of link status (64 bit), every driver was > > > doing its own version using cmpset. Atomic exchan

Re: [dpdk-dev] [PATCH v8 0/3] net/failsafe: add Rx interrupts support

2018-01-26 Thread Ferruh Yigit
On 1/25/2018 4:53 PM, Gaëtan Rivet wrote: > Hi Moti, > > There are still a few nits here and there, but nothing important. > > Acked-by: Gaetan Rivet Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/mrvl: update MUSDK library build instructions

2018-01-26 Thread Ferruh Yigit
On 1/26/2018 8:02 AM, Tomasz Duszynski wrote: doc: update MUSDK library build instructions > By default both static and shared libraries should be created while > building MUSDK library. It turns out that this will not happen if > host parameter is not explicitly passed to the configure script

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mrvl: fix mbuf to bpool lookup

2018-01-26 Thread Ferruh Yigit
On 1/26/2018 7:55 AM, Tomasz Duszynski wrote: > From: Natalie Samsonov > > Since in DPDK 17.11 port type was changed from uint8_t to uint16_t > the MBUF_INVALID_PORT value became 0x but in mrvl_tx_pkt_burst() > when trying to lookup bpool using mbuf port, we check if the port > is invalid acc

Re: [dpdk-dev] [PATCH v3 0/7] bnxt patchset

2018-01-26 Thread Ferruh Yigit
On 1/26/2018 5:31 PM, Ajit Khaparde wrote: > Please apply this patchset. > > Ajit Khaparde (6): > net/bnxt: fix size of tx ring in HW > net/bnxt: use driver specific dynamic log type > net/bnxt: register for more async events > net/bnxt: check if MAC address is all zeros > net/bnxt: add

Re: [dpdk-dev] [PATCH v8 01/15] eal: introduce atomic exchange operation

2018-01-26 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Friday, January 26, 2018 2:02 AM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v8 01/15] eal: introduce atomic exchange operation > > To handle atomic update o

[dpdk-dev] [PATCH 2/2] test/memzone: handle previously allocated memzones

2018-01-26 Thread Anatoly Burakov
Currently, memzone autotest expects there to be no memzones present by the time the test is run. Some hardware drivers will allocate memzones for internal use during initialization, resulting in tests failing due to unexpected memzones being allocated before the test was run. Fix this by making ca

[dpdk-dev] [PATCH 1/2] test/memzone: add test for memzone count in eal mem config

2018-01-26 Thread Anatoly Burakov
Ensure that memzone count in eal mem config is incremented and decremented whenever memzones are allocated and freed. Signed-off-by: Anatoly Burakov --- test/test/test_memzone.c | 20 1 file changed, 20 insertions(+) diff --git a/test/test/test_memzone.c b/test/test/test_me

Re: [dpdk-dev] Compilation errors in drivers/event/opdl/

2018-01-26 Thread Adrien Mazarguil
(Replying since you added me to this thread) On Sun, Jan 21, 2018 at 06:49:13PM +0100, Thomas Monjalon wrote: > 21/01/2018 18:34, Stephen Hemminger: > > On Sat, 20 Jan 2018 09:44:46 +0100 > > Thomas Monjalon wrote: > > > > > 20/01/2018 06:18, Patil, Harish: > > > > Hi, > > > > > > > > I am seei

Re: [dpdk-dev] [PATCH v2 0/7] bnxt patchset

2018-01-26 Thread Ferruh Yigit
On 1/26/2018 5:35 PM, Ferruh Yigit wrote: > On 1/25/2018 10:47 PM, Ajit Khaparde wrote: >> Please apply this patchset. >> I have incorporated most of the comments that we got in v1. >> The switch to SPDX tags is in the works and will be submitted separately. >> >> Ajit Khaparde (6): >> net/bnxt:

Re: [dpdk-dev] [PATCH v2 0/7] bnxt patchset

2018-01-26 Thread Ferruh Yigit
On 1/25/2018 10:47 PM, Ajit Khaparde wrote: > Please apply this patchset. > I have incorporated most of the comments that we got in v1. > The switch to SPDX tags is in the works and will be submitted separately. > > Ajit Khaparde (6): > net/bnxt: fix size of tx ring in HW > net/bnxt: use drive

Re: [dpdk-dev] [PATCH v2 6/7] net/bnxt: add 100G speed detection

2018-01-26 Thread Ajit Khaparde
On Fri, Jan 26, 2018 at 9:08 AM, Ferruh Yigit wrote: > On 1/25/2018 10:47 PM, Ajit Khaparde wrote: > > When the driver is loaded on a 100G NIC, the port speed is not > > displayed correctly. Parse the 100G speed before displaying it. > > > > Signed-off-by: Ajit Khaparde > > --- > > drivers/net/

[dpdk-dev] [PATCH v3 7/7] net/bnxt: fix number of pools for RSS

2018-01-26 Thread Ajit Khaparde
While using RSS, the pool count should be 1. Fixes: 8103a57ab432a ("net/bnxt: handle Rx multi queue creation properly") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c

[dpdk-dev] [PATCH v3 6/7] net/bnxt: add 100G speed detection

2018-01-26 Thread Ajit Khaparde
When the driver is loaded on a 100G NIC, the port speed is not displayed correctly. Parse the 100G speed before displaying it. Signed-off-by: Ajit Khaparde -- v1->v2: add a missing break statement --- drivers/net/bnxt/bnxt_hwrm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net

[dpdk-dev] [PATCH v3 4/7] net/bnxt: check if MAC address is all zeros

2018-01-26 Thread Ajit Khaparde
In certain cases the MAC address of a port could be all zeros. Catch it early, log a message and fail the initiaization. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 10 ++ drivers/net/bnxt/bnxt_filter.c | 2 +- drivers/net/bnxt/bnxt_filter.h | 1 + 3 files changed

[dpdk-dev] [PATCH v3 5/7] net/bnxt: support for rx/tx_queue_start/stop ops

2018-01-26 Thread Ajit Khaparde
Currently this is implemented entirely in the PMD as there is no explicit support in the HW. Re-program the RSS Table without this queue on stop and add it back to the table on start. Signed-off-by: Somnath Kotur Signed-off-by: Ajit Khaparde -- v1->v2: address review comments --- drivers/net/bn

[dpdk-dev] [PATCH v3 3/7] net/bnxt: register for more async events

2018-01-26 Thread Ajit Khaparde
Register for async events from the FW. New events we are registering for include Link speed config changes, PF driver unload and VF config change. Also log a message when the async event arrives on the completion ring. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c | 11 ++

[dpdk-dev] [PATCH v3 2/7] net/bnxt: use driver specific dynamic log type

2018-01-26 Thread Ajit Khaparde
This patch implements driver specific log type doing away with usage of RTE_LOG() for logging. Signed-off-by: Ajit Khaparde -- v1 -> v2: address review comments --- drivers/net/bnxt/bnxt.h | 8 ++ drivers/net/bnxt/bnxt_cpr.c | 10 +- drivers/net/bnxt/bnxt_ethdev.c | 241 ++

[dpdk-dev] [PATCH v3 1/7] net/bnxt: fix size of tx ring in HW

2018-01-26 Thread Ajit Khaparde
During Tx ring allocation, the actual ring size configured in the HW ends up being twice the number of txd parameter specified to the driver. The power of 2 ring size wrongly adds a +1 while sending the ring create command to the FW. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Cc: sta...

[dpdk-dev] [PATCH v3 0/7] bnxt patchset

2018-01-26 Thread Ajit Khaparde
Please apply this patchset. Ajit Khaparde (6): net/bnxt: fix size of tx ring in HW net/bnxt: use driver specific dynamic log type net/bnxt: register for more async events net/bnxt: check if MAC address is all zeros net/bnxt: add 100G speed detection net/bnxt: fix number of pools for RS

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/procinfo: Fix memory leak by rte_service_init

2018-01-26 Thread Thomas Monjalon
26/01/2018 18:15, Van Haaren, Harry: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 11/01/2018 20:47, Vipin Varghese: > > > When procinfo is run multiple times against primary application, it > > > consumes huge page memory by rte_service_init. Which is not released > > > at exit of appli

Re: [dpdk-dev] [PATCH v8 01/15] eal: introduce atomic exchange operation

2018-01-26 Thread Bruce Richardson
On Fri, Jan 26, 2018 at 06:14:01PM +0100, Thomas Monjalon wrote: > 26/01/2018 03:01, Stephen Hemminger: > > To handle atomic update of link status (64 bit), every driver was > > doing its own version using cmpset. Atomic exchange is a useful > > primitive in its own right; therefore make it a EAL

Re: [dpdk-dev] [PATCH] net/tap: remove speed parameter from TAP args

2018-01-26 Thread Ferruh Yigit
On 1/26/2018 10:27 PM, Vipin Varghese wrote: > TAP is a virtual device created on Kernel. The speed of interface is > set by Kernel to a fixed static value. But this does not prevent using > RX or TX to rate limit. Hence removing the option from user arguments. > > Signed-off-by: Vipin Varghese

Re: [dpdk-dev] [PATCH] net/mrvl: update MUSDK library build instructions

2018-01-26 Thread Ferruh Yigit
On 1/26/2018 4:46 PM, Tomasz Duszynski wrote: > On Fri, Jan 26, 2018 at 04:37:27PM +, Ferruh Yigit wrote: >> On 1/26/2018 8:02 AM, Tomasz Duszynski wrote: >>> By default both static and shared libraries should be created while >>> building MUSDK library. It turns out that this will not happen i

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/procinfo: Fix memory leak by rte_service_init

2018-01-26 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, January 26, 2018 5:00 PM > To: Varghese, Vipin ; Van Haaren, Harry > > Cc: sta...@dpdk.org; dev@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v2] app/procinfo: Fix memory leak by > rte_service_init > > 11/01/2018 20:47, Vipin Var

Re: [dpdk-dev] [PATCH v8 01/15] eal: introduce atomic exchange operation

2018-01-26 Thread Thomas Monjalon
26/01/2018 03:01, Stephen Hemminger: > To handle atomic update of link status (64 bit), every driver > was doing its own version using cmpset. > Atomic exchange is a useful primitive in its own right; > therefore make it a EAL routine. > > Signed-off-by: Stephen Hemminger > --- > .../common/incl

Re: [dpdk-dev] [PATCH v2 6/7] net/bnxt: add 100G speed detection

2018-01-26 Thread Ferruh Yigit
On 1/25/2018 10:47 PM, Ajit Khaparde wrote: > When the driver is loaded on a 100G NIC, the port speed is not > displayed correctly. Parse the 100G speed before displaying it. > > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_hwrm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [dpdk-dev] [PATCH] net/mlx4: fix no broadcasts reception in promisc

2018-01-26 Thread Adrien Mazarguil
Hi Moti, On Sun, Jan 07, 2018 at 01:04:46PM +0200, Moti Haimovsky wrote: > This patch fixes the issue of mlx4 not receiving broadcast packets > when configured to work promiscuous mode. Also in allmulticast mode, right? Both IBV_FLOW_ATTR_MC_DEFAULT and IBV_FLOW_ATTR_ALL_DEFAULT priorities are to

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/procinfo: Fix memory leak by rte_service_init

2018-01-26 Thread Thomas Monjalon
11/01/2018 20:47, Vipin Varghese: > When procinfo is run multiple times against primary application, it > consumes huge page memory by rte_service_init. Which is not released > at exit of application. > > Invoking rte_service_finalize to real memory and prevent memory leak. I don't think it is co

Re: [dpdk-dev] [PATCH v3] service: fix memory leak by rte_service_init

2018-01-26 Thread Thomas Monjalon
26/01/2018 16:20, Van Haaren, Harry: > > From: Varghese, Vipin > > Sent: Friday, January 26, 2018 8:56 PM > > To: Van Haaren, Harry ; dev@dpdk.org > > Cc: sta...@dpdk.org; Varghese, Vipin > > Subject: [PATCH v3] service: fix memory leak by rte_service_init > > > > The rte_service_finalize routine

Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set ops

2018-01-26 Thread Ferruh Yigit
On 1/26/2018 2:19 AM, Lu, Wenzhuo wrote: > Hi Olivier, > > >> -Original Message- >> From: Olivier Matz [mailto:olivier.m...@6wind.com] >> Sent: Thursday, January 25, 2018 6:40 PM >> To: Lu, Wenzhuo >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value

Re: [dpdk-dev] [PATCH V13 1/3] eal: add uevent monitor api and callback func

2018-01-26 Thread Bruce Richardson
On Fri, Jan 26, 2018 at 11:49:35AM +0800, Jeff Guo wrote: > This patch aim to add a general uevent mechanism in eal device layer, > to enable all linux kernel object uevent monitoring, user could use these > APIs to monitor and read out the device status info that sent from the > kernel side, then

Re: [dpdk-dev] [PATCH] net/mrvl: update MUSDK library build instructions

2018-01-26 Thread Tomasz Duszynski
On Fri, Jan 26, 2018 at 04:37:27PM +, Ferruh Yigit wrote: > On 1/26/2018 8:02 AM, Tomasz Duszynski wrote: > > By default both static and shared libraries should be created while > > building MUSDK library. It turns out that this will not happen if > > host parameter is not explicitly passed to

[dpdk-dev] [PATCH] net/tap: remove speed parameter from TAP args

2018-01-26 Thread Vipin Varghese
TAP is a virtual device created on Kernel. The speed of interface is set by Kernel to a fixed static value. But this does not prevent using RX or TX to rate limit. Hence removing the option from user arguments. Signed-off-by: Vipin Varghese --- doc/guides/nics/tap.rst | 5 - drivers/n

Re: [dpdk-dev] [PATCH v1] net/mlx4: fix single port configuration

2018-01-26 Thread Adrien Mazarguil
Hi Ophir, On Tue, Jan 23, 2018 at 11:32:47PM +, Ophir Munk wrote: > The number of mlx4 present ports is calculated as follows: > conf.ports.present |= (UINT64_C(1) << device_attr.phys_port_cnt) - 1; > > That is - all ones sequence (due to -1 subtraction) > When retrieving the number of ports,

Re: [dpdk-dev] [PATCH] net/mrvl: update MUSDK library build instructions

2018-01-26 Thread Ferruh Yigit
On 1/26/2018 8:02 AM, Tomasz Duszynski wrote: > By default both static and shared libraries should be created while > building MUSDK library. It turns out that this will not happen if > host parameter is not explicitly passed to the configure script. > > Specifying host makes sure configure will d

Re: [dpdk-dev] [PATCH v1] doc: add note in proc info for stats retrieval

2018-01-26 Thread Jain, Deepak K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marko Kovacevic > Sent: Wednesday, January 24, 2018 4:47 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Varghese, Vipin > ; Kovacevic, Marko > > Subject: [dpdk-dev] [PATCH v1] doc: add note in proc info for stats r

Re: [dpdk-dev] [PATCH v2 0/4] net/mlx: make rdma-core optional at run-time

2018-01-26 Thread Nélio Laranjeiro
On Fri, Jan 26, 2018 at 03:18:55PM +0100, Adrien Mazarguil wrote: > A problem encountered with Mellanox PMDs and frequently reported by DPDK > application developers and Linux distribution package maintainers is their > dependency on rdma-core components, namely libibverbs, libmlx4, and libmlx5. >

Re: [dpdk-dev] [PATCH] net/ena: TX L4 offloads should not be set in RX path

2018-01-26 Thread Ferruh Yigit
On 1/25/2018 4:13 PM, Michał Krawczyk wrote: > 2018-01-25 16:27 GMT+01:00 Rafal Kozik : >> >> Information about received packet type detected by NIC should be >> stored in packet_type field of rte_mbuf. TX L4 offload flags should >> not be set in RX path. Only fields that could be set in of_flags >

Re: [dpdk-dev] [PATCH] app/pdump: fix the memory leak by rte_service_init

2018-01-26 Thread Van Haaren, Harry
> From: Varghese, Vipin > Sent: Wednesday, January 24, 2018 7:55 AM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: Jain, Deepak K ; Mcnamara, John > ; sta...@dpdk.org; Patel, Amol > ; Varghese, Vipin > Subject: [PATCH] app/pdump: fix the memory leak by rte_service_init > > When pdump is run multipl

Re: [dpdk-dev] [PATCH v2] app/procinfo: Fix memory leak by rte_service_init

2018-01-26 Thread Van Haaren, Harry
> From: Varghese, Vipin > Sent: Thursday, January 11, 2018 7:48 PM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: sta...@dpdk.org; Varghese, Vipin > Subject: [PATCH v2] app/procinfo: Fix memory leak by rte_service_init > > When procinfo is run multiple times against primary application, it > consum

Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue interrupt enabling

2018-01-26 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Helin > Sent: Friday, January 26, 2018 11:33 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue interrupt > enabling >

Re: [dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt enabling

2018-01-26 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Helin > Sent: Friday, January 26, 2018 11:33 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt > enabling >

Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt enabling

2018-01-26 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Helin > Sent: Friday, January 26, 2018 11:32 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt > enabling >

Re: [dpdk-dev] [PATCH v3 0/4] net/virtio: fix memory leak when reinitializing device

2018-01-26 Thread Yuanhan Liu
On Tue, Jan 23, 2018 at 04:54:39PM +0100, Olivier Matz wrote: > When devops->configure() is called, the queues may be reallocated > if the features flag changed, but the previous are not freed. This > patchset fixes this issue. Seires applied to dpdk-next-virtio. Thanks. --yliu > > To r

Re: [dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt enabling

2018-01-26 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Wednesday, January 24, 2018 4:17 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt > enabling > > When using UIO

Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue interrupt enabling

2018-01-26 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Wednesday, January 24, 2018 4:17 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue interrupt > enabling > > When using UIO

Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt enabling

2018-01-26 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Wednesday, January 24, 2018 4:17 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt > enabling > > When using UIO,

Re: [dpdk-dev] [PATCH] net/virtio: fix Rx and Tx handler selection for arm32

2018-01-26 Thread Yuanhan Liu
On Thu, Dec 14, 2017 at 03:45:04PM +0100, Maxime Coquelin wrote: > Hi Olivier, > > On 12/14/2017 03:32 PM, Olivier Matz wrote: > >From: Samuel Gauthier > > > >On arm32, we were always selecting the simple handler, but it is only > >available if neon is present. > > > >This is due to a typo in the

Re: [dpdk-dev] [PATCH] vhost: fix iotlb pool out-of-memory handling

2018-01-26 Thread Maxime Coquelin
Hi Tiwei, On 01/26/2018 09:03 AM, Tiwei Bie wrote: On Thu, Jan 25, 2018 at 04:06:53PM +0100, Maxime Coquelin wrote: In the unlikely case the IOTLB memory pool runs out of memory, an issue may happen if all entries are used by the IOTLB cache, and an IOTLB miss happen. If the iotlb pending list

Re: [dpdk-dev] [PATCH v3] service: fix memory leak by rte_service_init

2018-01-26 Thread Van Haaren, Harry
> From: Varghese, Vipin > Sent: Friday, January 26, 2018 8:56 PM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: sta...@dpdk.org; Varghese, Vipin > Subject: [PATCH v3] service: fix memory leak by rte_service_init > > The rte_service_finalize routine checks if service is initialized > or not. If yes;

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix segfault as features change

2018-01-26 Thread Yuanhan Liu
On Tue, Jan 23, 2018 at 09:52:43AM +, Jianfeng Tan wrote: > Since commit 59fe5e17d930 ("vhost: propagate set features handling error"), > vhost does not allow to set different features without reset. > > The virito-user driver fails to reset the device in below commit. > > To fix, we send the

[dpdk-dev] [PATCH v3] service: fix memory leak by rte_service_init

2018-01-26 Thread Vipin Varghese
The rte_service_finalize routine checks if service is initialized or not. If yes; releases internal memory for services and lcore states are freed. This routine is to be invoked at end of application termination. Fixes: 21698354c832 ("service: introduce service cores concept") Cc: harry.van.haa...

Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

2018-01-26 Thread Nicolau, Radu
> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Friday, January 26, 2018 2:38 PM > To: Nicolau, Radu ; Akhil Goyal > > Cc: anoob.jos...@caviumnetworks.com; Doherty, Declan > ; Gonzalez Monroy, Sergio > ; Jerin Jacob > ; Narayana Prasad > ; Nelio

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix strncpy length

2018-01-26 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, January 26, 2018 2:44 PM > To: Zhang, Roy Fan > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] crypto/scheduler: fix strncpy length > > Th

[dpdk-dev] [PATCH] crypto/scheduler: fix strncpy length

2018-01-26 Thread Pablo de Lara
The coverity issue was not completely fixed, since strncpy should be called with max length - 1. Coverity issue: 143431 Fixes: d040aca67170 ("crypto/scheduler: fix strings not null terminated") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/crypto/scheduler/rte_cryptodev_scheduler

Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

2018-01-26 Thread Anoob Joseph
Hi Radu, On 01/26/2018 04:52 PM, Nicolau, Radu wrote: -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, January 25, 2018 5:13 PM To: Akhil Goyal ; Nicolau, Radu Cc: Doherty, Declan ; Gonzalez Monroy, Sergio ; anoob.jos...@caviumnetworks.com

[dpdk-dev] [PATCH v2 4/4] net/mlx5: spawn rdma-core dependency plug-in

2018-01-26 Thread Adrien Mazarguil
When mlx5 is not compiled directly as an independent shared object (e.g. CONFIG_RTE_BUILD_SHARED_LIB not enabled for performance reasons), DPDK applications inherit its dependencies on libibverbs and libmlx5 through rte.app.mk. This is an issue both when DPDK is delivered as a binary package (Linu

[dpdk-dev] [PATCH v2 1/4] net/mlx4: move rdma-core calls to separate file

2018-01-26 Thread Adrien Mazarguil
This lays the groundwork for externalizing rdma-core as an optional run-time dependency instead of a mandatory one. No functional change. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 1 + drivers/net/mlx4/mlx4.c| 35 ++--- drivers/net/mlx4/mlx4_ethdev.c | 3

[dpdk-dev] [PATCH v2 2/4] net/mlx4: spawn rdma-core dependency plug-in

2018-01-26 Thread Adrien Mazarguil
When mlx4 is not compiled directly as an independent shared object (e.g. CONFIG_RTE_BUILD_SHARED_LIB not enabled for performance reasons), DPDK applications inherit its dependencies on libibverbs and libmlx4 through rte.app.mk. This is an issue both when DPDK is delivered as a binary package (Linu

[dpdk-dev] [PATCH v2 3/4] net/mlx5: move rdma-core calls to separate file

2018-01-26 Thread Adrien Mazarguil
From: Nelio Laranjeiro This lays the groundwork for externalizing rdma-core as an optional run-time dependency instead of a mandatory one. No functional change. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/Makefile | 1 + drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v2 0/4] net/mlx: make rdma-core optional at run-time

2018-01-26 Thread Adrien Mazarguil
A problem encountered with Mellanox PMDs and frequently reported by DPDK application developers and Linux distribution package maintainers is their dependency on rdma-core components, namely libibverbs, libmlx4, and libmlx5. For best performance in applications, DPDK is normally built as a collect

Re: [dpdk-dev] [PATCH v2] service: fix memory leak by rte_service_init

2018-01-26 Thread Thomas Monjalon
26/01/2018 11:10, Van Haaren, Harry: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Your patches have been set to "Not Applicable" in patchwork. > > What happened? > > There was some confusion in my review-comments, and Vipin and I discussed > the best was to rework - I suggested marki

Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT declaration

2018-01-26 Thread Yuanhan Liu
On Sat, Jan 20, 2018 at 01:54:52AM +0800, Tan, Jianfeng wrote: > > > On 1/19/2018 10:42 PM, Yuanhan Liu wrote: > >On Fri, Jan 19, 2018 at 02:02:50PM -0500, Zhihong Wang wrote: > >>The VIRTIO_F_ANY_LAYOUT feature indicates the device accepts arbitrary > >>descriptor layouts. The vhost-user lib alr

Re: [dpdk-dev] [PATCH] vhost: fix iotlb pool out-of-memory handling

2018-01-26 Thread Jens Freimann
On Thu, Jan 25, 2018 at 04:06:53PM +0100, Maxime Coquelin wrote: In the unlikely case the IOTLB memory pool runs out of memory, an issue may happen if all entries are used by the IOTLB cache, and an IOTLB miss happen. If the iotlb pending list is empty, then no memory is freed and allocation fail

[dpdk-dev] [PATCH] doc: announce API deprecation in cryptodev

2018-01-26 Thread Pablo de Lara
Functions rte_cryptodev_queue_pair_start/stop are not really used in any of the crypto drivers (they all just return 0 or -ENOTSUP). Therefore, this API can be deprecated from 18.02 and removed in 18.05. Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/deprecation.rst | 5 + lib/librte_

Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

2018-01-26 Thread Nicolau, Radu
> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Thursday, January 25, 2018 5:13 PM > To: Akhil Goyal ; Nicolau, Radu > > Cc: Doherty, Declan ; Gonzalez Monroy, Sergio > ; > anoob.jos...@caviumnetworks.com; Jerin Jacob > ; Narayana Prasad > ; Nel

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

2018-01-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Friday, January 26, 2018 10:45 AM > To: De Lara Guarch, Pablo ; > akhil.go...@nxp.com; hemant.agra...@nxp.com; Doherty, Declan > ; jerin.ja...@intel.com; Griffin, John > ; Jain, Deepak K ; > j...@semihalf.com; t...@semihalf.com; d...@marve

Re: [dpdk-dev] [PATCH v2 0/4] fix VF RX queue interrupt enabling

2018-01-26 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Wednesday, January 24, 2018 4:17 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v2 0/4] fix VF RX queue interrupt enabling > > If multiple interrupt not supported, the dri

Re: [dpdk-dev] [PATCH 14/18] net/nfp: align dynamic log names with standard

2018-01-26 Thread Alejandro Lucero
Acked-by: Alejandro Lucero On Thu, Jan 25, 2018 at 9:01 AM, Harry van Haaren < harry.van.haa...@intel.com> wrote: > This commit aligns the names for dynamic logging with > the newly defined logging format. > > Signed-off-by: Harry van Haaren > > --- > > Maintainer: > Cc: alejandro.luc...@netron

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

2018-01-26 Thread Trahe, Fiona
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, January 26, 2018 9:04 AM > To: akhil.go...@nxp.com; hemant.agra...@nxp.com; Doherty, Declan > ; > jerin.ja...@intel.com; Trahe, Fiona ; Griffin, John > ; Jain, > Deepak K ; j...@semihalf.com; t...@semihalf.com;

Re: [dpdk-dev] [PATCH v6 2/2] eal: add synchronous multi-process communication

2018-01-26 Thread Burakov, Anatoly
On 26-Jan-18 3:41 AM, Jianfeng Tan wrote: We need the synchronous way for multi-process communication, i.e., blockingly waiting for reply message when we send a request to the peer process. We add two APIs rte_eal_mp_request() and rte_eal_mp_reply() for such use case. By invoking rte_eal_mp_requ

Re: [dpdk-dev] [PATCH v6 1/2] eal: add channel for multi-process communication

2018-01-26 Thread Burakov, Anatoly
On 26-Jan-18 3:41 AM, Jianfeng Tan wrote: Previouly, there are three channels for multi-process (i.e., primary/secondary) communication. 1. Config-file based channel, in which, the primary process writes info into a pre-defined config file, and the secondary process reads the info

Re: [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme

2018-01-26 Thread Bruce Richardson
On Thu, Jan 25, 2018 at 09:00:52AM +, Harry van Haaren wrote: > This patchset adds and documents a defined naming scheme > for logging. As the user selects logging topics of > interest, it is important for usability that the topics > are consistently named. > > The first patch of this patchset

Re: [dpdk-dev] [PATCH v2] service: fix memory leak by rte_service_init

2018-01-26 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, January 25, 2018 10:11 PM > To: Varghese, Vipin > Cc: dev@dpdk.org; Van Haaren, Harry ; > Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v2] service: fix memory leak by > rte_service_init > > 11/01/2018 19:20, Vipin Vargh

Re: [dpdk-dev] [PATCH v1 2/4] net/mlx4: spawn rdma-core dependency plug-in

2018-01-26 Thread Thomas Monjalon
25/01/2018 00:25, Adrien Mazarguil: > --- a/drivers/net/mlx4/Makefile > +++ b/drivers/net/mlx4/Makefile > @@ -38,7 +38,11 @@ LIB = librte_pmd_mlx4.a > SRCS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4.c > SRCS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4_ethdev.c > SRCS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4_f

Re: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser

2018-01-26 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Thursday, January 25, 2018 1:16 PM > To: Zhang, Qi Z; Xing, Beilei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser > > > > -Original Messag

Re: [dpdk-dev] [PATCH v4] net/i40e: add null point check and fix mem leak

2018-01-26 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei > Sent: Friday, January 26, 2018 12:58 PM > To: Yong Wang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: add null point check and fix mem > leak > > > -Original Message- >

[dpdk-dev] [PATCH] net/ixgbe: allow for setting 2.5G and 5G speeds on X550

2018-01-26 Thread Martin Weiser
This patch adds support for explicitly selecting 2.5G and 5G speeds on X550. Signed-off-by: Martin Weiser --- drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_eth

Re: [dpdk-dev] [PATCH v4] net/e1000: add null point check for rte_zmalloc

2018-01-26 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Friday, January 26, 2018 4:41 PM > To: Yong Wang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] net/e1000: add null point check for > rte_zmalloc > > Hi, > > > > -Original Messa

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: update copyright and license

2018-01-26 Thread Olivier Matz
Hi, On Wed, Jan 24, 2018 at 01:20:16PM +, Lee Daly wrote: > This updates the Intel and Oliver Matz licenses on files in examples > to be the standard BSD-3-Clause license used for the rest of DPDK, > bringing the files in compliance with the DPDK licensing policy. > > Signed-off-by: Lee Daly

Re: [dpdk-dev] [PATCH] pmdinfogen: allow using stdin and stdout

2018-01-26 Thread Bruce Richardson
On Thu, Jan 25, 2018 at 04:30:40PM -0500, Neil Horman wrote: > On Thu, Jan 25, 2018 at 11:12:25AM +, Bruce Richardson wrote: > > Rather than having to work off files all the time, allow stdin and > > stdout to be used as the source and destination for pmdinfogen. This > > will allow other possi

[dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

2018-01-26 Thread Pablo de Lara
Since the API changes made in 17.08, the session mempool is not created anymore in each crypto device. Therefore, there is no need to have, in the cryptodev info structure, the maximum number of sessions supported per device and per queue pair. Signed-off-by: Pablo de Lara --- doc/guides/rel_not

Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API

2018-01-26 Thread Zhao1, Wei
Hi, helin A new v3 has been commit, https://dpdk.org/dev/patchwork/patch/34546/ Thanks. > -Original Message- > From: Zhang, Helin > Sent: Friday, January 26, 2018 4:32 PM > To: Zhao1, Wei ; Zhang, Qi Z ; > dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix issues for RSS flow API > >

[dpdk-dev] [PATCH v3] net/i40e: fix issue for RSS flow API

2018-01-26 Thread Wei Zhao
This patch fix issue check from DPDK coverity issues. Coverity issue: 257020, 257024, 257037 Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Signed-off-by: Wei Zhao Acked-by: Qi Zhang --- v2: -fix an error introduced in v1 patch. v3: -change coverity writing style for DPDK rule. ---

[dpdk-dev] [PATCH v3] net/i40e: fix issue for RSS flow API

2018-01-26 Thread Wei Zhao
This patch fix issue check from DPDK coverity issues. Coverity issue: 257020, 257024, 257037 Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Signed-off-by: Wei Zhao --- v2: -fix an error introduced in v1 patch. v3: -change coverity writing style for DPDK rule. --- drivers/net/i40e/i4

Re: [dpdk-dev] [PATCH v4] net/e1000: add null point check for rte_zmalloc

2018-01-26 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Yong Wang [mailto:wang.yon...@zte.com.cn] > Sent: Thursday, January 25, 2018 3:43 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Yong Wang > Subject: [PATCH v4] net/e1000: add null point check for rte_zmalloc > > There are several func calls to rte_zmalloc()

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-26 Thread Thomas Monjalon
26/01/2018 09:06, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 26/01/2018 08:30, Lu, Wenzhuo: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 25/01/2018 02:11, Lu, Wenzhuo: > > > > > > --- a/app/test-pmd/testpmd.c > > > > > > +++ b/app/test-pmd/testpmd.c >

Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API

2018-01-26 Thread Zhang, Helin
Hi Wei I need your helps to rework the patch to follow the commit log styles other commits use. Please find some good examples via git log. Thanks! /Helin > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Friday, January 26, 2018 11:18 AM > To

Re: [dpdk-dev] [PATCH] net/i40e: remove unnecessary void pointer cast

2018-01-26 Thread Zhang, Helin
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, January 26, 2018 3:45 PM > To: Yang, Zhiyong; dev@dpdk.org > Cc: Xing, Beilei; Zhang, Helin > Subject: RE: [PATCH] net/i40e: remove unnecessary void pointer cast > > > > > -Original Message- > > From: Yang, Zhiyong > > Se

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/bond: fix vdev name in bond sample app

2018-01-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Thursday, January 25, 2018 4:26 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; Nicolau, Radu > ; sta...@dpdk.org > Subject: [dpdk-stable] [PATCH] examples/bond: fix vdev name in bond > sa

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-26 Thread Lu, Wenzhuo
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, January 26, 2018 3:48 PM > To: Lu, Wenzhuo > Cc: Moti Haimovsky ; dev@dpdk.org; > shah...@mellanox.com; Yigit, Ferruh > Subject: Re: [PATCH] app/testpmd: do not enable Rx offloads by default > > 26/

Re: [dpdk-dev] [PATCH] vhost: fix iotlb pool out-of-memory handling

2018-01-26 Thread Tiwei Bie
On Thu, Jan 25, 2018 at 04:06:53PM +0100, Maxime Coquelin wrote: > In the unlikely case the IOTLB memory pool runs out of memory, > an issue may happen if all entries are used by the IOTLB cache, > and an IOTLB miss happen. If the iotlb pending list is empty, > then no memory is freed and allocatio

[dpdk-dev] [PATCH] net/mrvl: update MUSDK library build instructions

2018-01-26 Thread Tomasz Duszynski
By default both static and shared libraries should be created while building MUSDK library. It turns out that this will not happen if host parameter is not explicitly passed to the configure script. Specifying host makes sure configure will detect support for shared libraries. Signed-off-by: Toma