[dpdk-dev] [PATCH] net/i40e: remove unnecessary void pointer cast

2018-01-24 Thread Zhiyong Yang
void pointer can be assigned to any type pointer without type cast. The patch can make code more simple. Cc: beilei.x...@intel.com Cc: qi.z.zh...@intel.com Cc: helin.zh...@intel.com Signed-off-by: Zhiyong Yang --- drivers/net/i40e/i40e_flow.c | 118 +-- 1

Re: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser

2018-01-24 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Zhiyong > Sent: Thursday, January 25, 2018 2:03 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Zhao1, Wei ; Zhang, Qi Z > > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser > > Hi Qi, > > > -Original Message---

[dpdk-dev] [PATCH v4] crypto/qat: add null point check and fix mem leak

2018-01-24 Thread Yong Wang
There are several func calls to rte_zmalloc() which don't do null point check on the return value. And before return, the memory is not freed. Fix it by adding null point check and rte_free(). Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Fixes: e09231eaa2af ("crypto/qat: add SGL

[dpdk-dev] [PATCH] event/opdl: fix ICC fails at compile time

2018-01-24 Thread Zhiyong Yang
ICC reports the issue at compile time as follows. error #592: variable "i" is used before its value is set RTE_SET_USED(i); The patch is to fix it. GCC and CLANG has been tested as well. Fixes: d548ef513cd7 ("event/opdl: add unit tests") Cc: liang.j...@intel.com Cc: peter.mccar...@intel.c

Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-24 Thread Shahaf Shuler
Hi Jiayu Hu, Good fix, thanks. Thursday, January 25, 2018 4:14 AM, Jiayu Hu: > In current design, we can't enable SW checksum calculation for the devices > which don't have checksum offloading abilities via the command "csum set > ip|tcp|udp|sctp|outer-ip sw ". > But SW checksum calculation shoul

Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API

2018-01-24 Thread Zhao1, Wei
Ok, v2 will commit later. > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 25, 2018 2:12 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix issues for RSS flow API > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Thursday, Janua

Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API

2018-01-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 25, 2018 12:00 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix issues for RSS flow API > > > -Original Message- > > From: Zhao1, Wei > > Sent: Tuesday, January 23, 2018 2:43 PM > > To: dev@

Re: [dpdk-dev] [PATCH] net/i40e: fix incorrect return

2018-01-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 25, 2018 2:04 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhao1, Wei ; Zhang, Qi Z > > Subject: [PATCH] net/i40e: fix incorrect return > > Fix incorrect function return. > > Fixes: ecad87d22383e ("net/i40e: move RSS to f

[dpdk-dev] [PATCH] net/i40e: fix incorrect return

2018-01-24 Thread Qi Zhang
Fix incorrect function return. Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index c4df65df0..

Re: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser

2018-01-24 Thread Yang, Zhiyong
Hi Qi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Thursday, January 25, 2018 1:11 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhao1, Wei ; Zhang, Qi Z > > Subject: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser > > Paramete

Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API

2018-01-24 Thread Zhang, Qi Z
Hi Wei: > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, January 23, 2018 2:43 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH] net/i40e: fix issues for RSS flow API > > This patch fix issues check from DPDK coverity issues. > > Fixes: ecad87d2238

Re: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser

2018-01-24 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Thursday, January 25, 2018 1:11 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhao1, Wei ; Zhang, Qi Z > > Subject: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser > > Parameter acti

Re: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser

2018-01-24 Thread Zhao1, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 25, 2018 1:11 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhao1, Wei ; Zhang, Qi Z > > Subject: [PATCH] net/i40e: fix bug in RSS flow action parser > > Parameter action_flag is not used correctly in i40e_flow_parse_rss_act

[dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser

2018-01-24 Thread Qi Zhang
Parameter action_flag is not used correctly in i40e_flow_parse_rss_action. Also change it from point type to value type since it is not an output parameter. Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_flow.c | 4 ++-- 1 file changed,

[dpdk-dev] [PATCH v3 3/3] vfio: use the generic multi-process channel

2018-01-24 Thread Jianfeng Tan
Previously, vfio uses its own private channel for the secondary process to get container fd and group fd from the primary process. This patch changes to use the generic mp channel. Test: 1. Bind two NICs to vfio-pci. 2. Start the primary and secondary process. $ (symmetric_mp) -c 2 -- -p

[dpdk-dev] [PATCH v3 0/3] generic channel for multi-process communication

2018-01-24 Thread Jianfeng Tan
v2->v3: - Add pre-check for each APIs. - Remove the limitation of 8 secondary processes by: discard original register/unregister mechanism of secondary process, instead, primary discoveries secondary processes by looking up the folder for regex match. - Previous implementation use two

[dpdk-dev] [PATCH v3 1/3] eal: add channel for multi-process communication

2018-01-24 Thread Jianfeng Tan
Previouly, there are three channels for multi-process (i.e., primary/secondary) communication. 1. Config-file based channel, in which, the primary process writes info into a pre-defined config file, and the secondary process reads the info out. 2. vfio submodule has its own channel ba

[dpdk-dev] [PATCH v3 2/3] eal: add synchronous multi-process communication

2018-01-24 Thread Jianfeng Tan
We need the synchronous way for multi-process communication, i.e., blockingly waiting for reply message when we send a request to the peer process. We add two APIs rte_eal_mp_request() and rte_eal_mp_reply() for such use case. By invoking rte_eal_mp_request(), a request message is sent out, and th

Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API

2018-01-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Tuesday, January 23, 2018 2:43 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH] net/i40e: fix issues for RSS flow API > > This patch fix issues check from DPDK coverity issues. > > Fixes: ecad87d22383e ("net/i40e: mov

Re: [dpdk-dev] [PATCH v5] app/testpmd: add option ring-bind-lcpu to bind Q with CPU

2018-01-24 Thread Simon Guo
Hi Konstantin, On Thu, Jan 18, 2018 at 12:14:05PM +, Ananyev, Konstantin wrote: > Hi Simon, > > > > > Hi, Konstantin, > > On Tue, Jan 16, 2018 at 12:38:35PM +, Ananyev, Konstantin wrote: > > > > > > > > > > -Original Message- > > > > From: dev [mailto:dev-boun...@dpdk.org] On Beh

Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-24 Thread Hu, Jiayu
> -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, January 25, 2018 10:58 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: shah...@mellanox.com; Yao, Lei A > Subject: RE: [PATCH] app/testpmd: fix failing to enable SW checksum > calculation > > Hi Jiayu, > > > > -Original Message---

Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-24 Thread Hu, Jiayu
Hi Wenzhuo, > -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, January 25, 2018 10:58 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: shah...@mellanox.com; Yao, Lei A > Subject: RE: [PATCH] app/testpmd: fix failing to enable SW checksum > calculation > > Hi Jiayu, > > > > -Original

Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-24 Thread Lu, Wenzhuo
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Thursday, January 25, 2018 10:14 AM > To: dev@dpdk.org > Cc: shah...@mellanox.com; Lu, Wenzhuo ; Yao, Lei > A ; Hu, Jiayu > Subject: [PATCH] app/testpmd: fix failing to enable SW checksum calculation > > In current design, we can'

[dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set ops

2018-01-24 Thread Wenzhuo Lu
Setting the default MAC address may fail on many NICs. But the ops return void. So, even it failed, RTE changes the MAC address and APP doesn't know the failure. It's not real patch, just show the idea to add a return value for the ops. BTW, Seems we should do the same thing for rte_eth_dev_mac_a

[dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-24 Thread Jiayu Hu
In current design, we can't enable SW checksum calculation for the devices which don't have checksum offloading abilities via the command "csum set ip|tcp|udp|sctp|outer-ip sw ". But SW checksum calculation shouldn't depend on HW offloading abilities. This patch is to fix this issue. Fixes: 3926dd

Re: [dpdk-dev] [PATCH v5 7/7] app/testpmd: adjust ethdev port ownership

2018-01-24 Thread Lu, Wenzhuo
Hi Matan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad > Sent: Tuesday, January 23, 2018 12:38 AM > To: Thomas Monjalon ; Gaetan Rivet > ; Wu, Jingjing > Cc: dev@dpdk.org; Neil Horman ; Richardson, > Bruce ; Ananyev, Konstantin > > Subject: [dp

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-24 Thread Lu, Wenzhuo
Hi Moti, > -Original Message- > From: Moti Haimovsky [mailto:mo...@mellanox.com] > Sent: Tuesday, January 23, 2018 4:11 PM > To: Lu, Wenzhuo ; tho...@monjalon.net > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [PATCH] app/testpmd: do not enable Rx offloads by default > > Removed the hard

Re: [dpdk-dev] [PATCH v1 1/4] net/mlx4: move rdma-core calls to separate file

2018-01-24 Thread Stephen Hemminger
On Thu, 25 Jan 2018 00:25:00 +0100 Adrien Mazarguil wrote: > +const struct mlx4_glue *mlx4_glue = &(const struct mlx4_glue){ > + .fork_init = mlx4_glue_fork_init, > + .get_async_event = mlx4_glue_get_async_event, The cast should not be necessary here.

[dpdk-dev] [PATCH v1 4/4] net/mlx5: spawn rdma-core dependency plug-in

2018-01-24 Thread Adrien Mazarguil
When mlx5 is not compiled directly as an independent shared object (e.g. CONFIG_RTE_BUILD_SHARED_LIB not enabled for performance reasons), DPDK applications inherit its dependencies on libibverbs and libmlx5 through rte.app.mk. This is an issue both when DPDK is delivered as a binary package (Linu

[dpdk-dev] [PATCH v1 3/4] net/mlx5: move rdma-core calls to separate file

2018-01-24 Thread Adrien Mazarguil
From: Nelio Laranjeiro This lays the groundwork for externalizing rdma-core as an optional run-time dependency instead of a mandatory one. No functional change. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/Makefile| 1 + drivers/net/mlx5/mlx5.c | 48 ++--- drivers/

[dpdk-dev] [PATCH v1 2/4] net/mlx4: spawn rdma-core dependency plug-in

2018-01-24 Thread Adrien Mazarguil
When mlx4 is not compiled directly as an independent shared object (e.g. CONFIG_RTE_BUILD_SHARED_LIB not enabled for performance reasons), DPDK applications inherit its dependencies on libibverbs and libmlx4 through rte.app.mk. This is an issue both when DPDK is delivered as a binary package (Linu

[dpdk-dev] [PATCH v1 0/4] net/mlx: make rdma-core optional at run-time

2018-01-24 Thread Adrien Mazarguil
A problem encountered with Mellanox PMDs and frequently reported by DPDK application developers and Linux distribution package maintainers is their dependency on rdma-core components, namely libibverbs, libmlx4, and libmlx5. For best performance in applications, DPDK is normally built as a collect

[dpdk-dev] [PATCH v1 1/4] net/mlx4: move rdma-core calls to separate file

2018-01-24 Thread Adrien Mazarguil
This lays the groundwork for externalizing rdma-core as an optional run-time dependency instead of a mandatory one. No functional change. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 1 + drivers/net/mlx4/mlx4.c| 35 ++--- drivers/net/mlx4/mlx4_ethdev.c | 3

Re: [dpdk-dev] [PATCH] maintainers: update for cryptodev

2018-01-24 Thread Doherty, Declan
On 24/01/2018 5:24 PM, Pablo de Lara wrote: Signed-off-by: Pablo de Lara --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5788ea004..924426343 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -276,6 +276,7 @@ F: examples/bbdev_app/ F: doc/guid

Re: [dpdk-dev] [RFC v2, 1/2] cryptodev: add support to set session private data

2018-01-24 Thread De Lara Guarch, Pablo
> -Original Message- > From: Gujjar, Abhinandan S > Sent: Tuesday, January 23, 2018 8:54 AM > To: Doherty, Declan ; akhil.go...@nxp.com; De > Lara Guarch, Pablo ; > jerin.jacobkollanukka...@cavium.com > Cc: dev@dpdk.org; Vangati, Narender ; > Gujjar, Abhinandan S ; Rao, Nikhil > > Subjec

Re: [dpdk-dev] [RFC v3 1/1] lib: add compressdev API

2018-01-24 Thread Ahmed Mansour
Hi All, Please see responses in line. Thanks, Ahmed On 1/23/2018 6:58 AM, Verma, Shally wrote: > Hi Fiona > >> -Original Message- >> From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >> Sent: 19 January 2018 17:30 >> To: Verma, Shally ; dev@dpdk.org; >> akhil.go...@nxp.com >> Cc: Challa

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-01-24 Thread Ravi Kerur
Hi Burakov, Thank you. I will try with vfio-pci driver. I am assuming it will work for both PF and VF interfaces since I am using both in my setup? Thanks. On Wed, Jan 24, 2018 at 2:31 AM, Burakov, Anatoly wrote: > On 23-Jan-18 5:25 PM, Ravi Kerur wrote: > >> Hi, >> >> I am running into an issu

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-24 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, January 24, 2018 8:10 AM > To: Ananyev, Konstantin > Cc: Matan Azrad ; Gaëtan Rivet ; > Wu, Jingjing ; > dev@dpdk.org; Neil Horman ; Richardson, Bruce > > Subject: Re: [dpdk-dev] [PATCH v3 7/7

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Stephen Hemminger
On Wed, 24 Jan 2018 19:08:02 +0100 Thomas Monjalon wrote: > 24/01/2018 16:39, Stephen Hemminger: > > On Wed, 24 Jan 2018 14:12:13 + > > Ophir Munk wrote: > > > --- a/drivers/net/vdev_netvsc/Makefile > > > +++ b/drivers/net/vdev_netvsc/Makefile > > > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Thomas Monjalon
24/01/2018 16:39, Stephen Hemminger: > On Wed, 24 Jan 2018 14:12:13 + > Ophir Munk wrote: > > --- a/drivers/net/vdev_netvsc/Makefile > > +++ b/drivers/net/vdev_netvsc/Makefile > > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map > > # Additional compilation flags. > > CFLAGS +

Re: [dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Thomas Monjalon
24/01/2018 15:45, Matan Azrad: > Hi Ophir > > From: Ophir Munk, Wednesday, January 24, 2018 4:12 PM > > Remove CFLAGS -std=c11 and -pedantic in order to guarantee a successful > > vdev_netvsc compilation on old Linux distributions. > > Otherwise old GCC compilers may complain as follows: > > cc1:

Re: [dpdk-dev] [PATCH v1] net/tap: use local eBPF definitions

2018-01-24 Thread Thomas Monjalon
24/01/2018 12:05, Van Haaren, Harry: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ophir Munk > > Sent: Tuesday, January 23, 2018 9:54 PM > > To: dev@dpdk.org; Pascal Mazon > > Cc: Thomas Monjalon ; Olga Shern ; > > Ophir Munk > > Subject: [dpdk-dev] [PATCH v1] net/tap: use local eBPF

Re: [dpdk-dev] [PATCH] drivers/event: fix resource leak in selftest

2018-01-24 Thread Thomas Monjalon
23/01/2018 15:17, Van Haaren, Harry: > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Monday, January 22, 2018 5:46 PM > > To: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH] drivers/event: fix

Re: [dpdk-dev] [PATCH] event/opdl: rework loops to comply with dpdk style

2018-01-24 Thread Thomas Monjalon
22/01/2018 11:30, Liang, Ma: > On 22 Jan 10:04, Harry van Haaren wrote: > > This commit reworks the loop counter variable declarations > > to be in line with the DPDK source code. > > > > Fixes: 3c7f3dcfb099 ("event/opdl: add PMD main body and helper function") > > Fixes: 8ca8e3b48eff ("event/opdl

Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-24 Thread Ferruh Yigit
On 1/23/2018 1:05 AM, John Daley wrote: > From: Hyong Youb Kim > > enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only > for IPv4. The hardware actually validates the TCP/UDP checksum of > IPv6 packets too. Set PKT_RX_L4_CKSUM_{GOOD,BAD} accordingly. > > Signed-off-by: Hyong Y

Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-24 Thread Hyong Youb Kim
On Wed, Jan 24, 2018 at 05:45:48PM +, Ferruh Yigit wrote: > On 1/24/2018 5:30 PM, Hyong Youb Kim wrote: > > On Wed, Jan 24, 2018 at 05:18:37PM +, Ferruh Yigit wrote: > >> On 1/23/2018 1:05 AM, John Daley wrote: > >>> From: Hyong Youb Kim > >>> > >>> enic_cq_rx_to_pkt_flags() currently sets

Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-24 Thread Ferruh Yigit
On 1/24/2018 5:30 PM, Hyong Youb Kim wrote: > On Wed, Jan 24, 2018 at 05:18:37PM +, Ferruh Yigit wrote: >> On 1/23/2018 1:05 AM, John Daley wrote: >>> From: Hyong Youb Kim >>> >>> enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only >>> for IPv4. The hardware actually validat

Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-24 Thread Hyong Youb Kim
On Wed, Jan 24, 2018 at 05:18:37PM +, Ferruh Yigit wrote: > On 1/23/2018 1:05 AM, John Daley wrote: > > From: Hyong Youb Kim > > > > enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only > > for IPv4. The hardware actually validates the TCP/UDP checksum of > > IPv6 packets to

Re: [dpdk-dev] [PATCH] net/failsafe: fix Rx burst infinite loop

2018-01-24 Thread Ferruh Yigit
On 1/24/2018 10:31 AM, Gaëtan Rivet wrote: > On Wed, Jan 24, 2018 at 10:19:17AM +, Matan Azrad wrote: >> In case of plugged out device, the fail-safe PMD uses failsafe_rx_burst >> function for packet receiving. >> >> This function iterates over the present sub-devices until it >> receives a tra

[dpdk-dev] [PATCH] maintainers: update for cryptodev

2018-01-24 Thread Pablo de Lara
Signed-off-by: Pablo de Lara --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5788ea004..924426343 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -276,6 +276,7 @@ F: examples/bbdev_app/ F: doc/guides/sample_app_ug/bbdev_app.rst Crypto API +M:

Re: [dpdk-dev] [PATCH] net/enic: add a Tx prepare handler

2018-01-24 Thread Ferruh Yigit
On 1/23/2018 1:05 AM, John Daley wrote: > From: Hyong Youb Kim > > Like most NICs, this hardware (Cisco VIC) also requires partial > checksum in the packet for checksum offload and TSO. So, add > the tx_pkt_prepare handler like other PMDs do. > > Technically, VIC has an offload mode that does no

Re: [dpdk-dev] [PATCH] net/enic: fix segfault due to static max number of queues

2018-01-24 Thread Ferruh Yigit
On 1/23/2018 1:05 AM, John Daley wrote: > From: Hyong Youb Kim > > ENIC_CQ_MAX, ENIC_WQ_MAX and others are arbitrary values that > prevent the app from using more queues when they are available on > hardware. Remove them and dynamically allocate vnic_cq and such > arrays to accommodate all availa

Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-24 Thread Ferruh Yigit
On 1/23/2018 1:05 AM, John Daley wrote: > From: Hyong Youb Kim > > enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only > for IPv4. The hardware actually validates the TCP/UDP checksum of > IPv6 packets too. Set PKT_RX_L4_CKSUM_{GOOD,BAD} accordingly. > > Signed-off-by: Hyong Y

[dpdk-dev] [PATCH] service: fix possible mem leak on initialize

2018-01-24 Thread Harry van Haaren
This commit ensures that if that if we run out of memory during the initialization of the service library, that the first allocated memory is correctly freed instead of leaked. Fixes: 21698354c832 ("service: introduce service cores concept") Cc: sta...@dpdk.org Reported-by: Vipin Varghese Signed

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Thomas Monjalon
24/01/2018 16:04, Yuanhan Liu: > On Wed, Jan 24, 2018 at 11:37:31AM +0100, Thomas Monjalon wrote: > > 24/01/2018 11:36, Yuanhan Liu: > > > On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > > > > 24/01/2018 10:28, Yuanhan Liu: > > > > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thom

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Thomas Monjalon
24/01/2018 16:24, Yuanhan Liu: > On Tue, Jan 23, 2018 at 05:08:16PM +0100, Gaëtan Rivet wrote: > > Drivers answers to a specific API (ethdev, cryptodev, ...), to create > > standardized objects in response to parameters that are given to them > > for init. I think matching properties should be rest

[dpdk-dev] [PATCH v1] doc: add note in proc info for stats retrieval

2018-01-24 Thread Marko Kovacevic
Note added to outline that using proc_info for virtual devices is not supported Signed-off-by: Marko Kovacevic --- doc/guides/tools/proc_info.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/tools/proc_info.rst b/doc/guides/tools/proc_info.rst index fd17e27..191ab20 100644 -

[dpdk-dev] [PATCH v6 3/3] net/failsafe: add Rx interrupts

2018-01-24 Thread Moti Haimovsky
This patch is the last patch in the series of patches aimed to add support for registering and waiting for Rx interrupts in failsafe PMD. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. The failsafe PMD presents to the application a facade of a single

[dpdk-dev] [PATCH v6 2/3] net/failsafe: slaves Rx interrupts registration

2018-01-24 Thread Moti Haimovsky
This commit adds the following functionality to failsafe PMD: * Register and unregister slaves Rx interrupts. * Enable and Disable slaves Rx interrupts. The interrupts events generated by the slaves are not handled in this commit. Signed-off-by: Moti Haimovsky --- V6: Added a wrapper around epoll

[dpdk-dev] [PATCH v6 0/3] net/failsafe: add Rx interrupts support

2018-01-24 Thread Moti Haimovsky
These three patches add support for registering and waiting for Rx interrupts in failsafe PMD. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. The failsafe PMD presents to the application a facade of a single device to be handled by the application wh

[dpdk-dev] [PATCH v6 1/3] net/failsafe: register as an Rx interrupt mode PMD

2018-01-24 Thread Moti Haimovsky
This patch adds registering the Rx queues of the failsafe PMD with EAL Rx interrupts subsystem. Each failsafe RX queue is assigned with a unique eventfd and an enable interrupts flag. The PMD creates an interrupt vector containing the above eventfds and Registers it with EAL. The PMD also implemen

Re: [dpdk-dev] [PATCH v2 0/2] net/mrvl: switch to the new Rx/Tx offloads API

2018-01-24 Thread Ferruh Yigit
On 1/23/2018 8:46 AM, Tomasz Duszynski wrote: > This patch series replaces the old Rx/Tx offload API with the > new API. > > v2: > * Follow the same logic for calculating both unsupported and missing flags. > > Tomasz Duszynski (2): > net/mrvl: switch to the new Rx offload API > net/mrvl: sw

Re: [dpdk-dev] [PATCH] ethdev: move internal callback list definition

2018-01-24 Thread Ferruh Yigit
On 1/22/2018 12:25 PM, David Marchand wrote: > This structure is not exposed through public apis, we should just move it > to the core header. > > Signed-off-by: David Marchand > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Stephen Hemminger
On Wed, 24 Jan 2018 14:12:13 + Ophir Munk wrote: > Remove CFLAGS -std=c11 and -pedantic in order to guarantee > a successful vdev_netvsc compilation on old Linux distributions. > Otherwise old GCC compilers may complain as follows: > cc1: error: unrecognized command line option -std=c11 > >

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Tue, Jan 23, 2018 at 05:08:16PM +0100, Gaëtan Rivet wrote: > Drivers answers to a specific API (ethdev, cryptodev, ...), to create > standardized objects in response to parameters that are given to them > for init. I think matching properties should be restricted to higher > classes (bus, eth/cr

Re: [dpdk-dev] [PATCH V12 3/3] app/testpmd: use uevent to monitor hotplug

2018-01-24 Thread Wu, Jingjing
> + > +static void > +add_uevent_callback(void *arg) > +{ > + char *dev_name = (char *)arg; > + > + rte_eal_alarm_cancel(add_uevent_callback, arg); > + > + if (!in_hotplug_list(dev_name)) > + return; > + > + RTE_LOG(ERR, EAL, "add device: %s\n", dev_name); It's not an e

[dpdk-dev] [PATCH v2] doc: fix bbdev test guide build

2018-01-24 Thread Marko Kovacevic
Fix build issue with pdf guides. Some indentations in the bbdev test application doc were causing build failures. Latex Log message:       doc.log:! LaTeX Error: Too deeply nested.     Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: amr.mokh...@intel.com   Signed-off-by:

[dpdk-dev] [PATCH 1/2] event/opdl: fix the resource leak issue

2018-01-24 Thread Liang Ma
Fixes: d548ef513cd7 ("event/opdl: add unit tests") Coverity issue: 257004 Signed-off-by: Liang Ma --- drivers/event/opdl/opdl_test.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/event/opdl/opdl_test.c b/drivers/event/opdl/opdl_test.c index 44a5cc5..4894c08 1

[dpdk-dev] [PATCH 2/2] event/opdl: fix dereference before null check

2018-01-24 Thread Liang Ma
Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library") Coverity issue: 257022 Signed-off-by: Liang Ma --- drivers/event/opdl/opdl_ring.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/event/opdl/opdl_ring.c b/drivers/event/opdl/opdl_ring.c i

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 11:37:31AM +0100, Thomas Monjalon wrote: > 24/01/2018 11:36, Yuanhan Liu: > > On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > > > 24/01/2018 10:28, Yuanhan Liu: > > > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > > > > 24/01/2018 0

Re: [dpdk-dev] [PATCH V12 2/3] eal: add uevent pass and process function

2018-01-24 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Thursday, January 18, 2018 12:12 PM > To: step...@networkplumber.org; Richardson, Bruce > ; > Yigit, Ferruh ; gaetan.ri...@6wind.com > Cc: Ananyev, Konstantin ; jblu...@infradead.org; > shreyansh.j...@nxp.com; Wu, Jingjing ; dev@dpdk.org; >

Re: [dpdk-dev] [PATCH V12 1/3] eal: add uevent monitor api and callback func

2018-01-24 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Thursday, January 18, 2018 12:12 PM > To: step...@networkplumber.org; Richardson, Bruce > ; > Yigit, Ferruh ; gaetan.ri...@6wind.com > Cc: Ananyev, Konstantin ; jblu...@infradead.org; > shreyansh.j...@nxp.com; Wu, Jingjing ; dev@dpdk.org; >

Re: [dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Matan Azrad
Hi Ophir From: Ophir Munk, Wednesday, January 24, 2018 4:12 PM > Remove CFLAGS -std=c11 and -pedantic in order to guarantee a successful > vdev_netvsc compilation on old Linux distributions. > Otherwise old GCC compilers may complain as follows: > cc1: error: unrecognized command line option -std=

[dpdk-dev] [PATCH v2] eal/service: add routine to release memory

2018-01-24 Thread Vipin Varghese
The routine rte_service_finalize checks if service is initialized, if yes; releases internal memory for services and lcore states. This routine is to be invoked at end of application termination. Signed-off-by: Vipin Varghese --- V2 Changes: - redo the logic for rte_service_finalize - added in

[dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Ophir Munk
Remove CFLAGS -std=c11 and -pedantic in order to guarantee a successful vdev_netvsc compilation on old Linux distributions. Otherwise old GCC compilers may complain as follows: cc1: error: unrecognized command line option -std=c11 Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform d

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: fix secondary process mempool registration

2018-01-24 Thread Shahaf Shuler
Wednesday, January 24, 2018 10:14 AM, Nélio Laranjeiro: > Hi Shahaf, > > On Tue, Jan 23, 2018 at 07:08:20PM +0200, Shahaf Shuler wrote: > > Secondary process is not allowed to register mempools on the flight. > > > > The code will return invalid memory key for such case. > > > > Fixes: 87ec44ce165

[dpdk-dev] [PATCH] examples: update copyrights and license

2018-01-24 Thread Lee Daly
This updates the Intel and Cavium license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- .../performance-thread/common/arch/x86/stack.h | 30 +

[dpdk-dev] [PATCH] app/pdump: fix the memory leak by rte_service_init

2018-01-24 Thread Vipin Varghese
When pdump is run multiple times against any primary application, it consumes huge page memory by rte_service_init. This is not freed at exit of application. Invoking rte_service_finalize to free memory and prevent memory leak. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 3 +++ 1 file

[dpdk-dev] [PATCH v2] examples/bond: add mbuf alloc check

2018-01-24 Thread Radu Nicolau
Fixes: cc7e8ae84faa ("examples/bond: add example application for link bonding mode 6") Coverity issue: 257008 Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- v2: updated commit message examples/bond/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/examples/bond/main.c b/exam

[dpdk-dev] [PATCH] examples/ip_pipeline: update copyright and license

2018-01-24 Thread Lee Daly
This updates the Intel and Oliver Matz licenses on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- examples/ip_pipeline/parser.c | 56 +++-

[dpdk-dev] [PATCH] app/procinfo: fix memory leak by rte_service_init

2018-01-24 Thread Vipin Varghese
When procinfo is run multiple times against primary application, it consumes huge page memory by rte_service_init. Which is not released at exit of application. Invoking rte_service_finalize to free memory and prevent memory leak. Signed-off-by: Vipin Varghese --- app/proc_info/main.c | 3 +++

Re: [dpdk-dev] [PATCH] eal/service: add routine to release memory.

2018-01-24 Thread Van Haaren, Harry
> From: Varghese, Vipin > Sent: Wednesday, January 24, 2018 7:03 AM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: Jain, Deepak K ; Mcnamara, John > ; sta...@dpdk.org; Patel, Amol > ; Varghese, Vipin > Subject: [PATCH] eal/service: add routine to release memory. > > The routine rte_service_finalize

[dpdk-dev] [PATCH v2] net/bonding: check dequeue result before proceeding

2018-01-24 Thread Radu Nicolau
Fixes: 09150784a776 ("net/bonding: burst mode hash calculation") Coverity issue: 257015 Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- v2: updated commit message drivers/net/bonding/rte_eth_bond_pmd.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[dpdk-dev] [PATCH] usertools/devbind: remove unused code

2018-01-24 Thread Anatoly Burakov
Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 33 - 1 file changed, 33 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 894b519..955e984 100755 --- a/usertools/dpdk-devbind.py +++ b/usertoo

Re: [dpdk-dev] [PATCH v1] net/vdev_netvsc: remove CFLAGS -std=c11 and -pedantic

2018-01-24 Thread Matan Azrad
Hi Ophir From: Ophir Munk, Wednesday, January 24, 2018 1:20 PM > In order to guarantee a successful vdev_netvsc compilation on old Linux > distributions remove CFLAGS -std=c11 and -pedantic Otherwise old GCC > compilers may complain as follows: > cc1: error: unrecognized command line option -std=c

[dpdk-dev] [PATCH] eal/service: add routine to release memory.

2018-01-24 Thread Vipin Varghese
The routine rte_service_finalize cehcks if service is initialized, if yes releases the internal meory for services and lcore states. This routine is to be invoked at end of application termiantion. Signed-off-by: Vipin Varghese --- lib/librte_eal/common/include/rte_service.h | 12

[dpdk-dev] [PATCH v1] doc: fix bbdev test guide build

2018-01-24 Thread Marko Kovacevic
Some indentations in the bbdev test application were causing build failures. Which are solved by this commit. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: amr.mokh...@intel.com Signed-off-by: Marko Kovacevic --- doc/guides/tools/testbbdev.rst | 18 ++

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-24 Thread george . dit
Hi again, I decided to simplify things for now, hence sent a new minimal patch only for testpmd (not librte_cmdline), which allows external applications to compile against it without errors. Thanks again for you time, Georgios On Tue, Jan 16, 2018 at 6:54 PM, Adrien Mazarguil wrote: > On Tue, J

Re: [dpdk-dev] [PATCH v2] keepalive: fix keepalive state alignment

2018-01-24 Thread Remy Horton
Done quick smoke test and it all seems fine :) On 23/01/2018 15:43, Andriy Berestovskyy wrote: [..] Fixes: e70a61ad50ab ("keepalive: export states") Cc: remy.hor...@intel.com Signed-off-by: Andriy Berestovskyy Acked-by: Remy Horton

[dpdk-dev] [PATCH] app/testpmd: move variables definition in source

2018-01-24 Thread Georgios P. Katsikas
From: Georgios Katsikas This patch moves the definition of 3 variables in testpmd.h into the respective .c file. The idea behind this move is to allow external applications to compile against testpmd without throwing compilation errors related to multiple definition of variables. Also, an extern

Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: add delay during updating link status

2018-01-24 Thread Ori Kam
> -Original Message- > From: Beilei Xing [mailto:beilei.x...@intel.com] > Sent: Wednesday, January 24, 2018 12:16 PM > To: Ori Kam > Cc: dev@dpdk.org > Subject: [PATCH v3] examples/flow_filtering: add delay during updating link > status > > Add up to 9s delay for getting link status to

[dpdk-dev] [pull-request] dpdk-next-build 18.02-rc2

2018-01-24 Thread Bruce Richardson
Hi Thomas, the new build system for DPDK using meson and ninja is now ready for merge as EXPERIMENTAL into the 18.02 release. Regards, /Bruce The following changes since commit bf375b4d51170cd58ca50c646781cb6de17766ea: version: 18.02-rc1 (2018-01-22 01:59:14 +0100) are available in the Git r

[dpdk-dev] [PATCH v1] net/vdev_netvsc: remove CFLAGS -std=c11 and -pedantic

2018-01-24 Thread Ophir Munk
In order to guarantee a successful vdev_netvsc compilation on old Linux distributions remove CFLAGS -std=c11 and -pedantic Otherwise old GCC compilers may complain as follows: cc1: error: unrecognized command line option -std=c11 Signed-off-by: Ophir Munk --- drivers/net/vdev_netvsc/Makefile | 2

Re: [dpdk-dev] [PATCH v1] net/tap: use local eBPF definitions

2018-01-24 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ophir Munk > Sent: Tuesday, January 23, 2018 9:54 PM > To: dev@dpdk.org; Pascal Mazon > Cc: Thomas Monjalon ; Olga Shern ; > Ophir Munk > Subject: [dpdk-dev] [PATCH v1] net/tap: use local eBPF definitions > > eBPF has a graceful approach: it

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Thomas Monjalon
24/01/2018 11:36, Yuanhan Liu: > On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > > 24/01/2018 10:28, Yuanhan Liu: > > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > > > 24/01/2018 07:43, Yuanhan Liu: > > > > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thom

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > 24/01/2018 10:28, Yuanhan Liu: > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > > 24/01/2018 07:43, Yuanhan Liu: > > > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > > > > 23/01/2018 1

Re: [dpdk-dev] [PATCH] net/failsafe: fix Rx burst infinite loop

2018-01-24 Thread Gaëtan Rivet
On Wed, Jan 24, 2018 at 10:19:17AM +, Matan Azrad wrote: > In case of plugged out device, the fail-safe PMD uses failsafe_rx_burst > function for packet receiving. > > This function iterates over the present sub-devices until it > receives a traffic from one of them or they are all cannot rece

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-01-24 Thread Burakov, Anatoly
On 23-Jan-18 5:25 PM, Ravi Kerur wrote: Hi, I am running into an issue when DPDK is started with iommu on via GRUB command. Problem is not seen with regular kernel driver, error messages show when DPDK is started and happens for both PF and VF interfaces. I am using DPDK 17.05 so the patch prop

[dpdk-dev] [PATCH] usertools/devbind: fix kernel module reporting

2018-01-24 Thread Anatoly Burakov
lspci reports kernel modules in "Module" string, but devbind expects it to be "Module_str". Fix it up similar to how we fix up "Driver" to be "Driver_str". Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: devbind status before changes: Other Network devices ===

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Thomas Monjalon
24/01/2018 10:28, Yuanhan Liu: > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > 24/01/2018 07:43, Yuanhan Liu: > > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > > > 23/01/2018 13:46, Yuanhan Liu: > > > > > If port not found, then the whole string will

  1   2   >