[dpdk-dev] [PATCH 5/7] net/dpaa: use phy to virt optimizations

2018-01-22 Thread Nipun Gupta
From: Hemant Agrawal Use the optimized routine for phy to virt conversion, when the mempool is allocated from physical contiguous memory. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_rxtx.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH 7/7] net/dpaa: further push mode optimizations

2018-01-22 Thread Nipun Gupta
This patch supports batch processing of multiple packets in the Rx side Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman.c | 89 ++--- drivers/bus/dpaa/include/fsl_qman.h | 10 + drivers/net/dpaa/dpaa_ethdev.c

[dpdk-dev] [PATCH 1/7] bus/dpaa: check flag in qman multi enqueue

2018-01-22 Thread Nipun Gupta
A caller may/may not pass the flags in qman enqueue multi API. This patch adds a check on that flag and only accesses it if passed by the caller. Fixes: 43797e7b4774 ("bus/dpaa: support event dequeue and consumption") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbma

[dpdk-dev] [PATCH 0/7] dpaa: fixes and performance improvement changes

2018-01-22 Thread Nipun Gupta
Patch 1-4 - Fixes some of the issues in the DPAA bus Patch 5-7 - Performance enhancement changes on DPAA platform Hemant Agrawal (2): mempool/dpaa: fix the phy to virt optimization net/dpaa: use phy to virt optimizations Nipun Gupta (4): bus/dpaa: check flag in qman multi enqueue bus/dpaa

[dpdk-dev] [PATCH 2/7] bus/dpaa: allocate qman portals in thread safe manner

2018-01-22 Thread Nipun Gupta
Fixes: 9d32ef0f5d61 ("bus/dpaa: support creating dynamic HW portal") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman

[dpdk-dev] [PATCH 6/7] bus/dpaa: check portal presence in the caller API

2018-01-22 Thread Nipun Gupta
In the I/O path we were calling rte_dpaa_portal_init which internally checks if a portal is affined to the core. But this lead to calling of that non-static API in every call. Instead check the portal affinity in the caller itself for performance reasons Signed-off-by: Nipun Gupta --- drivers/b

[dpdk-dev] [PATCH 3/7] mempool/dpaa: fix the phy to virt optimization

2018-01-22 Thread Nipun Gupta
From: Hemant Agrawal Fixes: 83a4f267f2e3 ("mempool/dpaa: optimize phy to virt conversion") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa/dpaa_mempool.c | 9 - drivers/mempool/dpaa/dpaa_mempool.h | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) di

[dpdk-dev] [PATCH 4/7] bus/dpaa: fix port order shuffling

2018-01-22 Thread Nipun Gupta
From: Shreyansh Jain While scanning for devices, the order in which devices appear is different as compared to MAC sequence. This can cause confusion for users and automated scripts. This patch create a sorted list of devices. Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleto

[dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API

2018-01-22 Thread Wei Zhao
This patch fix issues check from DPDK coverity issues. Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity issues: 257020 257024 257037 Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_ethdev.c | 2 +- drivers/net/i40e/i40e_flow.c | 4 ++-- 2 files changed, 3 insertions(+), 3 de

Re: [dpdk-dev] [PATCH v3 1/8] eal: introduce DMA memory barriers

2018-01-22 Thread Jerin Jacob
-Original Message- > Date: Mon, 22 Jan 2018 18:29:31 + > From: Yongseok Koh > To: Andrew Rybchenko , Thomas Monjalon > , "jianbo@arm.com" , Jerin > Jacob > CC: Adrien Mazarguil , Nélio Laranjeiro > , "bruce.richard...@intel.com" > , "Ananyev, Konstantin" > , Chao Zhu , > "de

[dpdk-dev] [PATCH v3 3/3] crypto/qat: add null point check and fix mem leak

2018-01-22 Thread Yong Wang
There are several func calls to rte_zmalloc() which don't do null point check on the return value. And before return, the memory is not freed. Fix it by adding null point check and rte_free(). Signed-off-by: Yong Wang --- v3: * Rebase on master and modify again. v2: * Fix code style warning. ---

[dpdk-dev] [PATCH v3 2/3] net/e1000: add null point check for rte_zmalloc

2018-01-22 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/e1000/igb_flow.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c index d98bdc8..a142759 100644 --- a/drivers/net/e1000/igb_flow.c +++ b/drivers/net/e1000/igb_flow.c @@ -1

[dpdk-dev] [PATCH v3 1/3] net/i40e: add null point check and fix mem leak

2018-01-22 Thread Yong Wang
Signed-off-by: Yong Wang --- v2: * Fix code style warning. --- drivers/net/i40e/i40e_ethdev.c | 32 drivers/net/i40e/i40e_fdir.c | 7 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index c

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-22 Thread Yang, Qiming
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Wednesday, January 17, 2018 10:34 PM > To: Andrew Rybchenko ; Adrien Mazarguil > ; Yang, Qiming > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC] New packet type query API > > Wednesday, January 17, 2018 10:

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-22 Thread Yang, Qiming
Answered in adrien’s email. From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Wednesday, January 17, 2018 4:09 PM To: Adrien Mazarguil ; Yang, Qiming Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC] New packet type query API On 01/16/2018 06:55 PM, Adrien Mazarguil wrote: I understa

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-22 Thread Yang, Qiming
Sorry for reply so late. Answered in line. > > This flag will be configured in dev_configure(), and can be queried by user > through dev->data->dev_conf.rxmode.enable_ptype_direct. In receive function, > driver will store HW's packet type value in mbuf->packet_type if direct mode > is > enabled,

Re: [dpdk-dev] [PATCH v2 1/4] net/virtio: fix queue flushing with vector Rx enabled

2018-01-22 Thread Tiwei Bie
On Mon, Jan 22, 2018 at 11:38:58AM +0100, Olivier Matz wrote: > On Mon, Jan 22, 2018 at 10:56:41AM +0800, Tiwei Bie wrote: > > On Fri, Jan 19, 2018 at 04:55:53PM +0100, Olivier Matz wrote: > > > When using vector Rx mode (use_simple_rx = 1), vq->vq_descx[] is not > > > kept up to date. To properly

Re: [dpdk-dev] [PATCH v3] net/ixgbe: check security enable bits

2018-01-22 Thread Zhang, Helin
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, January 22, 2018 6:24 PM > To: Nicolau, Radu; dev@dpdk.org > Cc: Yigit, Ferruh; Lu, Wenzhuo; Zhao, XinfengX; De Lara Guarch, Pablo; Zhang, > Helin > Subject: RE: [PATCH v3] net/ixgbe: check security enable bits > > > > >

Re: [dpdk-dev] [PATCH] mbuf: remove void pointer cast

2018-01-22 Thread Yang, Zhiyong
Olivier, Thanks for your review and Acked-by, I will do that as you said next time. Zhiyong > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, January 22, 2018 9:07 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; Yigit, Ferruh ; > tho...@monjalon.net >

[dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-22 Thread John Daley
From: Hyong Youb Kim enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only for IPv4. The hardware actually validates the TCP/UDP checksum of IPv6 packets too. Set PKT_RX_L4_CKSUM_{GOOD,BAD} accordingly. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/eni

[dpdk-dev] [PATCH] net/enic: add a Tx prepare handler

2018-01-22 Thread John Daley
From: Hyong Youb Kim Like most NICs, this hardware (Cisco VIC) also requires partial checksum in the packet for checksum offload and TSO. So, add the tx_pkt_prepare handler like other PMDs do. Technically, VIC has an offload mode that does not require partial checksum for non-TSO packets. But, i

[dpdk-dev] [PATCH] net/enic: fix segfault due to static max number of queues

2018-01-22 Thread John Daley
From: Hyong Youb Kim ENIC_CQ_MAX, ENIC_WQ_MAX and others are arbitrary values that prevent the app from using more queues when they are available on hardware. Remove them and dynamically allocate vnic_cq and such arrays to accommodate all available hardware queues. As a side effect of removing E

[dpdk-dev] [PACH v7 02a] typo in i686 version of rte_atomic64_exchange

2018-01-22 Thread Stephen Hemminger
Fix typo in 32 bit version of rte_atomic64_exchange. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/include/arch/x86/rte_atomic_32.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h b/lib/librte_eal/common/in

[dpdk-dev] [PATCH v7 14/15] net/octeontx: use rte_eth_linkstatus_set

2018-01-22 Thread Stephen Hemminger
Common function matches this drivers usage. Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index ad

[dpdk-dev] [PATCH v7 15/15] net/enic: use rte_eth_linkstatus_set

2018-01-22 Thread Stephen Hemminger
This driver was not doing atomic update of link status information. And the return value was different than others. The hardware also does not do autonegotiation (at least on Linux). Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- drivers/net/enic/enic_ethdev.c | 5 ++--- drive

[dpdk-dev] [PATCH v7 13/15] net/szedata: use _rte_eth_linkstatus_set

2018-01-22 Thread Stephen Hemminger
Yet another driver which was not returing correct value on link change. Since this driver can't be built on x86 could not even do a compile test. Signed-off-by: Stephen Hemminger --- drivers/net/szedata2/rte_eth_szedata2.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(

[dpdk-dev] [PATCH v7 11/15] net/liquidio: use rte_eth_linkstatus_set

2018-01-22 Thread Stephen Hemminger
Use the new link update API, and cleanup the logic in the the link update routine. Signed-off-by: Stephen Hemminger Tested-by: Shijith Thotton Reviewed-by: Ferruh Yigit --- drivers/net/liquidio/lio_ethdev.c | 53 ++- 1 file changed, 8 insertions(+), 45 delet

[dpdk-dev] [PATCH v7 12/15] net/thunderx: use rte_eth_linkstatus_set

2018-01-22 Thread Stephen Hemminger
Use new helper function. Signed-off-by: Stephen Hemminger --- drivers/net/thunderx/nicvf_ethdev.c | 48 - 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c index d34938c64

[dpdk-dev] [PATCH v7 10/15] net/i40e: use rte_eth_linkstatus functions

2018-01-22 Thread Stephen Hemminger
Use new rte_linkstatus update API Signed-off-by: Stephen Hemminger Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.c| 43 +-- drivers/net/i40e/i40e_ethdev_vf.c | 18 ++-- 2 files changed, 7 insertions(+), 54 deletions(-) diff --

[dpdk-dev] [PATCH v7 06/15] net/nfp: use rte_eth_linkstatus functions

2018-01-22 Thread Stephen Hemminger
Use new rte_eth_linkstatus_get/set helper function. Signed-off-by: Stephen Hemminger Signed-off-by: Ferruh Yigit --- drivers/net/nfp/nfp_net.c | 77 +-- 1 file changed, 7 insertions(+), 70 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/driver

[dpdk-dev] [PATCH v7 09/15] net/sfc: use new rte_eth_linkstatus functions

2018-01-22 Thread Stephen Hemminger
Use the new API (_rte_eth_linkstatus_set) to handle link status update. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc_ethdev.c | 21 +++-- drivers/net/sfc/sfc_ev.c | 20 ++-- 2 files changed, 5 insertions(+), 36 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v7 08/15] net/ixgbe: use rte_eth_linkstatus functions

2018-01-22 Thread Stephen Hemminger
Use the new helper functions from eth_dev for handling atomic link_info update. Signed-off-by: Stephen Hemminger Signed-off-by: Ferruh Yigit --- drivers/net/ixgbe/ixgbe_ethdev.c | 96 +++- 1 file changed, 17 insertions(+), 79 deletions(-) diff --git a/drive

[dpdk-dev] [PATCH v7 03/15] net/virtio: use eth_linkstatus_set

2018-01-22 Thread Stephen Hemminger
Use the new comon code in ethdev to handle link status update. Signed-off-by: Stephen Hemminger Signed-off-by: Ferruh Yigit --- drivers/net/virtio/virtio_ethdev.c | 65 +++--- 1 file changed, 12 insertions(+), 53 deletions(-) diff --git a/drivers/net/virtio/vir

[dpdk-dev] [PATCH v7 07/15] net/e1000: use rte_eth_linkstatus helpers

2018-01-22 Thread Stephen Hemminger
Use new rte_eth_linkstatus_get/set API. Signed-off-by: Stephen Hemminger Signed-off-by: Ferruh Yigit --- drivers/net/e1000/em_ethdev.c | 69 +++-- drivers/net/e1000/igb_ethdev.c | 70 +++--- 2 files changed, 10 insertions(

[dpdk-dev] [PATCH v7 02/15] ethdev: add linkstatus get/set helper functions

2018-01-22 Thread Stephen Hemminger
Many drivers are all doing copy/paste of the same code to atomically update the link status. Reduce duplication, and allow for future changes by having common function for this. Signed-off-by: Stephen Hemminger Acked-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c| 22 +++-

[dpdk-dev] [PATCH v7 04/15] net/vmxnet3: use rte_eth_linkstatus_set

2018-01-22 Thread Stephen Hemminger
Use new rte_eth_link_update helper. Also remove no longer necessary include of rte_atomic.h Signed-off-by: Stephen Hemminger Signed-off-by: Ferruh Yigit --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 86 +++- 1 file changed, 16 insertions(+), 70 deletions(-) diff --

[dpdk-dev] [PATCH v7 05/15] net/dpaa2: use rte_eth_linkstatus_set

2018-01-22 Thread Stephen Hemminger
Use new helper function to update the link status. Signed-off-by: Stephen Hemminger Acked-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 75 1 file changed, 7 insertions(+), 68 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/driv

[dpdk-dev] [PATCH v7 00/15] common linkstatus functions

2018-01-22 Thread Stephen Hemminger
While reviewing drivers, noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that some drivers behave differently for no good reason. It also was a good chance to introduce atomic exchange pr

[dpdk-dev] [PATCH v7 01/15] eal: introduce atomic exchange operation

2018-01-22 Thread Stephen Hemminger
To handle atomic update of link status (64 bit), every driver was doing its own version using cmpset. Atomic exchange is a useful primitive in its own right; therefore make it a EAL routine. Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- .../common/include/arch/ppc_64/rte_atomic

Re: [dpdk-dev] [PATCH] net/mlx5: fix missing capability for RSS

2018-01-22 Thread Yongseok Koh
> On Jan 22, 2018, at 12:52 PM, Shahaf Shuler wrote: > > The PMD was not reporting the supported RSS capabilities. > > Fixes: 2f97422e7759 ("mlx5: support RSS hash update and get") > Cc: sta...@dpdk.org > > Signed-off-by: Shahaf Shuler > --- Acked-by: Yongseok Koh Thanks

[dpdk-dev] [PATCH v2] app/testpmd: change log level at run time

2018-01-22 Thread Elza Mathew
Introduced a run time command to change the log level for a given log type. Added the necessary documentation. V2: Changed the position of the command in the documentation since generic commands are placed at the beginning. Signed-off-by: Elza Mathew --- app/test-pmd/cmdline.c

Re: [dpdk-dev] [PATCH v6 01/14] eal: introduce atomic exchange operation

2018-01-22 Thread Thomas Monjalon
22/01/2018 22:48, Stephen Hemminger: > On Mon, 22 Jan 2018 22:03:02 +0100 > Thomas Monjalon wrote: > > > 22/01/2018 17:56, Stephen Hemminger: > > > On Mon, 22 Jan 2018 00:50:55 +0100 > > > Thomas Monjalon wrote: > > > > > > > 21/01/2018 20:25, Ferruh Yigit: > > > > > On 1/21/2018 6:59 PM, F

Re: [dpdk-dev] [PATCH v6 01/14] eal: introduce atomic exchange operation

2018-01-22 Thread Stephen Hemminger
On Mon, 22 Jan 2018 22:03:02 +0100 Thomas Monjalon wrote: > 22/01/2018 17:56, Stephen Hemminger: > > On Mon, 22 Jan 2018 00:50:55 +0100 > > Thomas Monjalon wrote: > > > > > 21/01/2018 20:25, Ferruh Yigit: > > > > On 1/21/2018 6:59 PM, Ferruh Yigit wrote: > > > > > From: Stephen Hemminge

Re: [dpdk-dev] [PATCH v6 01/14] eal: introduce atomic exchange operation

2018-01-22 Thread Thomas Monjalon
22/01/2018 17:56, Stephen Hemminger: > On Mon, 22 Jan 2018 00:50:55 +0100 > Thomas Monjalon wrote: > > > 21/01/2018 20:25, Ferruh Yigit: > > > On 1/21/2018 6:59 PM, Ferruh Yigit wrote: > > > > From: Stephen Hemminger > > > > > > > > To handle atomic update of link status (64 bit), every drive

Re: [dpdk-dev] [PATCH] virtio: add new driver for crypto devices

2018-01-22 Thread Thomas Monjalon
22/01/2018 18:25, Zhang, Roy Fan: > Hi Thomas, > > Yes we are working together on this. Jay and Lei kindly agreed to upstream > their work. > > Jay is also working on Qemu patches to enable vhost-user as crypto backend > (https://patchwork.ozlabs.org/patch/864058/). > Jay's Qemu patches' mergi

Re: [dpdk-dev] [PATCH v3 1/8] eal: introduce DMA memory barriers

2018-01-22 Thread Thomas Monjalon
22/01/2018 19:29, Yongseok Koh: > > On Jan 18, 2018, at 11:16 PM, Andrew Rybchenko > > wrote: > > Maybe it would be useful to: > > - avoid duplication of so long explanations (put in in one place and add > > reference?) > > May have to ask Thomas how to do this. Thomas? You can group barriers

[dpdk-dev] [PATCH] net/mlx5: fix missing capability for RSS

2018-01-22 Thread Shahaf Shuler
The PMD was not reporting the supported RSS capabilities. Fixes: 2f97422e7759 ("mlx5: support RSS hash update and get") Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/driver

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-22 Thread Ananyev, Konstantin
Hi Matan, > -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Monday, January 22, 2018 1:23 PM > To: Ananyev, Konstantin ; Gaëtan Rivet > > Cc: Thomas Monjalon ; Wu, Jingjing > ; dev@dpdk.org; Neil Horman > ; Richardson, Bruce > Subject: RE: [PATCH v3 7/7] app/

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] net/mlx5: fix return value of start operation

2018-01-22 Thread Shahaf Shuler
Monday, January 22, 2018 2:34 PM, Olivier Matz: > On error, mlx5_dev_start() does not return a negative value as it is supposed > to do. The consequence is that the application > (ex: testpmd) does not notice that the port is not started and begins the rxtx > on an uninitialized port, which crashes

Re: [dpdk-dev] [PATCH 4/6] ethdev: introduce TX common tunnel offloads

2018-01-22 Thread Shahaf Shuler
Monday, January 22, 2018 2:47 PM, Olivier Matz: > Hi, > > On Tue, Jan 16, 2018 at 07:06:15PM +, Shahaf Shuler wrote: > > Hi Oliver, Xueming, > > > > Tuesday, January 16, 2018 7:29 PM, Xueming(Steven) Li: > > > > Hi Xueming, > > > > > > > > On Tue, Jan 09, 2018 at 10:11:08PM +0800, Xueming Li w

Re: [dpdk-dev] Compilation errors in drivers/event/opdl/

2018-01-22 Thread Patil, Harish
-Original Message- From: "Jacob, Jerin" Date: Saturday, January 20, 2018 at 12:56 AM To: Harish Patil Cc: "liang.j...@intel.com" , "peter.mccar...@intel.com" , "dev@dpdk.org" Subject: Re: [dpdk-dev] Compilation errors in drivers/event/opdl/ >-Original Message- >> Date: Sat, 2

Re: [dpdk-dev] [PATCH v3 1/8] eal: introduce DMA memory barriers

2018-01-22 Thread Yongseok Koh
> On Jan 18, 2018, at 11:16 PM, Andrew Rybchenko > wrote: > > On 01/19/2018 03:44 AM, Yongseok Koh wrote: >> This commit introduces rte_dma_wmb() and rte_dma_rmb(), in order to >> guarantee the ordering of coherent shared memory between the CPU and a DMA >> capable device. >> >> Signed-off-by:

Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

2018-01-22 Thread Andriy Berestovskyy
Hey Harry, Thanks for the review. On Fri, Jan 19, 2018 at 6:31 PM, Van Haaren, Harry wrote: > These changes do reduce false-sharing however is there actually a performance > benefit? A lot of cache space will be taken up if each core requires its own > cache line, which will reduce performance

Re: [dpdk-dev] [PATCH 1/2] net/mrvl: switch to the new Rx offload API

2018-01-22 Thread Ferruh Yigit
On 1/22/2018 12:04 PM, Tomasz Duszynski wrote: > Since the old Rx offload API is now depracated > update the driver to use the latest one. > > Signed-off-by: Tomasz Duszynski <...> > @@ -1308,6 +1313,42 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num) > } > > /** > + * Check whether reques

[dpdk-dev] [PATCH] drivers/event: fix resource leak in selftest

2018-01-22 Thread Pavan Nikhilesh
Free resources leak in eventdev selftests. Coverity issue: 257044 Coverity issue: 257047 Coverity issue: 257009 Fixes: 9ef576176db0 ("test/eventdev: add octeontx multi queue and multi port") Fixes: 3a17ff401f1e ("test/eventdev: add basic SW tests") Fixes: 5e6eb5ccd788 ("event/sw: make test standal

Re: [dpdk-dev] [PATCH] build: make compat a universal dependency

2018-01-22 Thread Luca Boccassi
On Mon, 2018-01-22 at 15:42 +, Bruce Richardson wrote: > By making "compat" lib (which consists of a header only) a dependency > of > the EAL, we make the header file available to all other libs, drivers > and > apps, and thereby make it less work to do ABI versioning. > > Signed-off-by: Bruce

Re: [dpdk-dev] [PATCH 3/3] net: run-time function selection

2018-01-22 Thread Bruce Richardson
On Mon, Dec 11, 2017 at 03:31:16PM +, Bruce Richardson wrote: > On Mon, Nov 06, 2017 at 10:05:43AM -0800, Elza Mathew wrote: > > Compile-time function selection can potentially lead to > > lower performance on generic builds done by distros. > > Replaced compile time flag checks with run-time >

Re: [dpdk-dev] [PATCH] virtio: add new driver for crypto devices

2018-01-22 Thread Zhang, Roy Fan
Hi Thomas, Yes we are working together on this. Jay and Lei kindly agreed to upstream their work. Jay is also working on Qemu patches to enable vhost-user as crypto backend (https://patchwork.ozlabs.org/patch/864058/). Jay's Qemu patches' merging is on the way but may not happen before DPDK 18

Re: [dpdk-dev] [PATCH v6 01/14] eal: introduce atomic exchange operation

2018-01-22 Thread Stephen Hemminger
On Mon, 22 Jan 2018 00:50:55 +0100 Thomas Monjalon wrote: > 21/01/2018 20:25, Ferruh Yigit: > > On 1/21/2018 6:59 PM, Ferruh Yigit wrote: > > > From: Stephen Hemminger > > > > > > To handle atomic update of link status (64 bit), every driver > > > was doing its own version using cmpset. > > >

Re: [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions

2018-01-22 Thread Stephen Hemminger
On Fri, 19 Jan 2018 16:47:36 + Hemant Agrawal wrote: > Hi Olivier, > > > On Fri, Jan 19, 2018 at 07:45:30PM +0530, Hemant Agrawal wrote: > > > Hi Jia, > > > > > > On 1/17/2018 9:33 AM, Jia He wrote: > > > > Move the common part of rte_ring.h into rte_ring_generic.h. > > > > Move the memo

[dpdk-dev] [PATCH] net/bonding: check dequeue result before proceeding

2018-01-22 Thread Radu Nicolau
Fixes Coverity issue 257015 Signed-off-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_pmd.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 158f3aa..cc06ff4 10

[dpdk-dev] [PATCH] examples/bond: add mbuf alloc check

2018-01-22 Thread Radu Nicolau
Fixes Coverity issue 257008 Signed-off-by: Radu Nicolau --- examples/bond/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/examples/bond/main.c b/examples/bond/main.c index 01e5eda..6c8a44a 100644 --- a/examples/bond/main.c +++ b/examples/bond/main.c @@ -441,6 +441,11 @@ static vo

[dpdk-dev] [PATCH v5 7/7] app/testpmd: adjust ethdev port ownership

2018-01-22 Thread Matan Azrad
Testpmd should not use ethdev ports which are managed by other DPDK entities. Set Testpmd ownership to each port which is not used by other entity and prevent any usage of ethdev ports which are not owned by Testpmd. Signed-off-by: Matan Azrad --- app/test-pmd/cmdline.c | 89 ++

[dpdk-dev] [PATCH v5 6/7] net/failsafe: use ownership mechanism to own ports

2018-01-22 Thread Matan Azrad
Fail-safe PMD sub devices management is based on ethdev port mechanism. So, the sub-devices management structures are exposed to other DPDK entities which may use them in parallel to fail-safe PMD. Use the new port ownership mechanism to avoid multiple managments of fail-safe PMD sub-devices. Sig

[dpdk-dev] [PATCH v5 5/7] net/failsafe: free an eth port by a dedicated API

2018-01-22 Thread Matan Azrad
Call dedicated ethdev API to free port in remove time as was done in other fail-safe places. Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_ether.c b/d

[dpdk-dev] [PATCH v5 4/7] ethdev: synchronize port allocation

2018-01-22 Thread Matan Azrad
Ethernet port allocation was not thread safe, means 2 threads which tried to allocate a new port at the same time might get an identical port identifier and caused to memory overwrite. Actually, all the port configurations were not thread safe from ethdev point of view. The port ownership mechanis

[dpdk-dev] [PATCH v5 3/7] ethdev: add port ownership

2018-01-22 Thread Matan Azrad
The ownership of a port is implicit in DPDK. Making it explicit is better from the next reasons: 1. It will define well who is in charge of the port usage synchronization. 2. A library could work on top of a port. 3. A port can work on top of another port. Also in the fail-safe case, an issue has

[dpdk-dev] [PATCH v5 2/7] ethdev: fix used portid allocation

2018-01-22 Thread Matan Azrad
rte_eth_dev_find_free_port() found a free port by state checking. The state field are in local process memory, so other DPDK processes may get the same port ID because their local states may be different. Replace the state checking by the ethdev port name checking, so, if the name is an empty stri

[dpdk-dev] [PATCH v5 1/7] ethdev: fix port data reset timing

2018-01-22 Thread Matan Azrad
rte_eth_dev_data structure is allocated per ethdev port and can be used to get a data of the port internally. rte_eth_dev_attach_secondary tries to find the port identifier using rte_eth_dev_data name field comparison and may get an identifier of invalid port in case of this port was released by t

[dpdk-dev] [PATCH v5 0/7] Port ownership and synchronization

2018-01-22 Thread Matan Azrad
Add ownership mechanism to DPDK Ethernet devices to avoid multiple management of a device by different DPDK entities. The port ownership mechanism is a good point to redefine the synchronization rules in ethdev: 1. The port allocation and port release synchronization will be managed by

[dpdk-dev] [PATCH v2 3/3] crypto/qat: fix parameter type

2018-01-22 Thread Tomasz Jozwiak
This commit fixes right cast from qat_cipher_get_block_size function. This function can return -EFAULT in case of any error, and that value must be cast to int instead of uint8_t Fixes: d18ab45f7654 ("crypto/qat: support DOCSIS BPI mode") Cc: sta...@dpdk.org Signed-off-by: Tomasz Jozwiak Acked-b

[dpdk-dev] [PATCH v2 2/3] crypto/qat: fix typo in error message

2018-01-22 Thread Tomasz Jozwiak
This commit fixes typo in bpi_cipher_decrypt error message Fixes: d18ab45f7654 ("crypto/qat: support DOCSIS BPI mode") Cc: sta...@dpdk.org Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe --- drivers/crypto/qat/qat_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[dpdk-dev] [PATCH v2 1/3] crypto/qat: fix out-of-bounds compiler error

2018-01-22 Thread Tomasz Jozwiak
This commit fixes - bpi_cipher_encrypt to prevent before 'array subscript is above array bounds' error - bpi_cipher_decrypt to prevent before 'array subscript is above array bounds' error Fixes: d18ab45f7654 ("crypto/qat: support DOCSIS BPI mode") Cc: sta...@dpdk.org Signed-off-by: To

[dpdk-dev] [PATCH v2 0/3] Fixes for QAT PMD

2018-01-22 Thread Tomasz Jozwiak
v2: - Previous patch has been split into 3 as below: Tomasz Jozwiak (3): crypto/qat: fix out-of-bounds compiler error crypto/qat: fix typo in error message crypto/qat: fix parameter type drivers/crypto/qat/qat_crypto.c | 26 +++--- 1 file changed, 15 insertions(+), 11 d

Re: [dpdk-dev] [PATCH v6 1/4] build: add support for ARM builds

2018-01-22 Thread Bruce Richardson
On Mon, Jan 22, 2018 at 09:50:04PM +0530, Jerin Jacob wrote: > -Original Message- > > Date: Mon, 22 Jan 2018 20:56:29 +0530 > > From: Pavan Nikhilesh > > To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com, > > harry.van.haa...@intel.com, herbert.g...@arm.com, hemant.agra...@nx

Re: [dpdk-dev] [PATCH v6 1/4] build: add support for ARM builds

2018-01-22 Thread Jerin Jacob
-Original Message- > Date: Mon, 22 Jan 2018 20:56:29 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com, > harry.van.haa...@intel.com, herbert.g...@arm.com, hemant.agra...@nxp.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v6 1/4] build: add support for ARM builds

2018-01-22 Thread Bruce Richardson
On Mon, Jan 22, 2018 at 08:56:29PM +0530, Pavan Nikhilesh wrote: > From: Bruce Richardson > > Add files to enable compiling for ARM native/cross builds. > This can be tested by doing a cross-compile for armv8-a type using > the linaro gcc toolchain. > > meson arm-build --cross-file aarch

Re: [dpdk-dev] [PATCH v3 1/3] kni: support for MAC addr change

2018-01-22 Thread Ferruh Yigit
On 1/22/2018 5:20 AM, Hemant Agrawal wrote: > Hi Ferruh, > > On 1/22/2018 3:37 AM, Ferruh Yigit wrote: >> On 1/18/2018 6:12 AM, Hemant Agrawal wrote: >>> This patch adds following: >>> 1. Option to configure the mac address during create. Generate random >>>address only if the user has not pro

[dpdk-dev] [PATCH] net/octeontx: register fpa as platform HW mempool

2018-01-22 Thread Pavan Nikhilesh
Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is used. Signed-off-by: Pavan Nikhilesh --- This patch depends on http://dpdk.org/dev/patchwork/patch/34239 patchset. drivers/net/octeontx/octeontx_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/o

[dpdk-dev] [PATCH] build: make compat a universal dependency

2018-01-22 Thread Bruce Richardson
By making "compat" lib (which consists of a header only) a dependency of the EAL, we make the header file available to all other libs, drivers and apps, and thereby make it less work to do ABI versioning. Signed-off-by: Bruce Richardson --- drivers/net/bonding/meson.build| 2 +- lib/librte_d

[dpdk-dev] [PATCH] app/testpmd: fix dereference null return valiue

2018-01-22 Thread Jasvinder Singh
Calloc() function might returns NULL due to insufficient space. Therefore, check for handling memory allocation failure is added. Coverity issue: 257030 Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode") Signed-off-by: Jasvinder Singh --- app/test-pmd/tm.c | 4 1 f

[dpdk-dev] [PATCH] doc: add release note entry for meson build

2018-01-22 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- doc/guides/rel_notes/release_18_02.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index 00b3224f3..cba8275a4 100644 --- a/doc/guides/rel_notes/release_18_0

[dpdk-dev] [PATCH v6 4/4] doc: add instructions to cross compile using meson

2018-01-22 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- doc/build-sdk-meson.txt | 27 +++ 1 file changed, 27 insertions(+) diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt index b5573f7a7..9618e759e 100644 --- a/doc/build-sdk-meson.txt +++ b/doc/build-sdk-meson.txt @@ -150,6 +15

[dpdk-dev] [PATCH v6 2/4] build: add support for detecting march on ARM

2018-01-22 Thread Pavan Nikhilesh
Added support for detecting march and mcpu by reading midr_el1 register. The implementer, primary part number values read can be used to figure out the underlying arm cpu. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/meson.build | 2 +- app/test-pmd/meson.build | 2 +- config/arm/

[dpdk-dev] [PATCH v6 3/4] build: add support for vendor specific ARM cross builds

2018-01-22 Thread Pavan Nikhilesh
Add various vendor specific cross build targets. This can be verified by using linaro toolchain and running meson build --cross-file config/arm/arm64___ In future more cross build targets can be added. Signed-off-by: Pavan Nikhilesh --- config/arm/arm64_armv8_linuxapp_gcc| 10 ++

[dpdk-dev] [PATCH v6 1/4] build: add support for ARM builds

2018-01-22 Thread Pavan Nikhilesh
From: Bruce Richardson Add files to enable compiling for ARM native/cross builds. This can be tested by doing a cross-compile for armv8-a type using the linaro gcc toolchain. meson arm-build --cross-file aarch64_cross.txt ninja -C arm-build where aarch64_cross.txt contained the

[dpdk-dev] [PATCH v6 0/7] Dynamic HW Mempool Detection Support

2018-01-22 Thread Hemant Agrawal
W.r.t the multiple discussions in the past about the ability to dynamically detect the HW mempool support. [1],[2] & [3] This patchset helps in removing the current static mempool selection model and provides a flexible model to select the pktmbuf mempool in more dynamic way. 1) This patchset upd

[dpdk-dev] [PATCH v6 5/7] app/testpmd: set preferred mempool as default pktpool

2018-01-22 Thread Hemant Agrawal
From: Pavan Nikhilesh Set the mempool preferred by the ethernet devices as default mbuf mempool before creating the pktpool. Signed-off-by: Pavan Nikhilesh Signed-off-by: Hemant Agrawal Reviewed-by: Olivier Matz --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[dpdk-dev] [PATCH v6 6/7] dpaa: register dpaa as platform HW mempool on runtime

2018-01-22 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa-linuxapp-gcc | 1 - drivers/bus/dpaa/dpaa_bus.c | 2 ++ drivers/bus/dpaa/rte_dpaa_bus.h | 2 ++ drivers/mempool/dpaa/dpaa_mempool.c | 2 +- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/confi

[dpdk-dev] [PATCH v6 4/7] mbuf: pktmbuf pool create helper for specific mempool ops

2018-01-22 Thread Hemant Agrawal
Introduce a new helper for pktmbuf pool, which will allow the application to optionally specify the mempool ops name as well. Signed-off-by: Hemant Agrawal Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.c | 23 +-- lib/librte_mbuf/rte_mbuf.h | 42 +++

[dpdk-dev] [PATCH v6 2/7] mbuf: maintain user and compile time mempool ops name

2018-01-22 Thread Hemant Agrawal
This patch change the logic to maintain the value of user defined and compile time i.e. RTE_MBUF_DEFAULT_MEMPOOL_OPS. The pktmbuf_create_pool is updated to reflect the same. Signed-off-by: Hemant Agrawal Acked-by: Olivier Matz --- lib/librte_eal/common/eal_common_options.c | 2 +- lib/librte_m

[dpdk-dev] [PATCH v6 1/7] eal: prefix mbuf pool ops name with user defined

2018-01-22 Thread Hemant Agrawal
This patch prefix the mbuf pool ops name with "user" to indicate that it is user defined. Signed-off-by: Hemant Agrawal Acked-by: Olivier Matz --- lib/librte_eal/bsdapp/eal/eal.c| 4 ++-- lib/librte_eal/common/eal_common_options.c | 2 +- lib/librte_eal/common/eal_internal_cfg.h |

[dpdk-dev] [PATCH v6 7/7] dpaa2: register dpaa2 as platform HW mempool on runtime

2018-01-22 Thread Hemant Agrawal
Detect if the DPAA2 mempool objects are present and register it as platform default hw mempool Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 1 - drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 3 +++ drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 ++ drivers/mempool/d

[dpdk-dev] [PATCH v6 3/7] mbuf: add pool ops name selection API helpers

2018-01-22 Thread Hemant Agrawal
This patch add support for various mempool ops config helper APIs. 1.User defined mempool ops 2.Platform detected HW mempool ops (active). 3.Best selection of mempool ops by looking into user defined, platform registered and compile time configured. Signed-off-by: Hemant Agrawal Acked-by: Oliv

[dpdk-dev] [PATCH] app/testpmd: fix dereference null return valiue

2018-01-22 Thread Jasvinder Singh
Malloc() function might return NULL due to insufficient space. Therefore, check for handling memory allocation failure is added. Coverity issue: 257039 Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands") Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline_mtr.c | 6 +++

Re: [dpdk-dev] [PATCH v2] meson: add tests to build

2018-01-22 Thread Bruce Richardson
On Wed, Dec 20, 2017 at 12:06:21PM +, Kevin Laatz wrote: > This commit adds most of the remaining tests to the meson build. > They can be run using test binary as normal. > > Signed-off-by: Kevin Laatz > > --- > v2: > Added the test names for the added tests. > --- > test/test/meson.bui

Re: [dpdk-dev] [PATCH] net/mlx5: remmap UAR address for multiple process

2018-01-22 Thread Nélio Laranjeiro
Hi Xueming, On Fri, Jan 19, 2018 at 11:08:54PM +0800, Xueming Li wrote: > UAR(doorbell) is hw resources that have to be same address between > primary and secondary process, failed to mmap UAR will make TX packets > invisible to HW. > Today, UAR address returned from verbs api is mixed in heap and

Re: [dpdk-dev] [PATCH v6 5/7] app/testpmd: set preferred mempool as default pktpool

2018-01-22 Thread santosh
On Monday 22 January 2018 07:21 PM, Hemant Agrawal wrote: > From: Pavan Nikhilesh > > Set the mempool preferred by the ethernet devices as default mbuf > mempool before creating the pktpool. > > Signed-off-by: Pavan Nikhilesh > Signed-off-by: Hemant Agrawal > Reviewed-by: Olivier Matz > --- A

Re: [dpdk-dev] [PATCH v6 4/7] mbuf: pktmbuf pool create helper for specific mempool ops

2018-01-22 Thread santosh
On Monday 22 January 2018 07:21 PM, Hemant Agrawal wrote: > Introduce a new helper for pktmbuf pool, which will allow > the application to optionally specify the mempool ops name > as well. > > Signed-off-by: Hemant Agrawal > Acked-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 3/7] mbuf: add pool ops name selection API helpers

2018-01-22 Thread santosh
On Monday 22 January 2018 07:21 PM, Hemant Agrawal wrote: > This patch add support for various mempool ops config helper APIs. > > 1.User defined mempool ops > 2.Platform detected HW mempool ops (active). > 3.Best selection of mempool ops by looking into user defined, > platform registered and c

  1   2   >