Re: [dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable.

2018-01-13 Thread Tonghao Zhang
On Fri, Jan 12, 2018 at 8:10 PM, Dai, Wei wrote: > Hi, Tonghao > Thanks for your patch. > It looks that same change can be applied to ixgbe_dev_interrupt_action( ) > and ixgbe_dev_interrupt_delayed_handler( ). Yes, but the irq (e.g mailbox irq) is not same as rx interrupt handled frequently. and

Re: [dpdk-dev] [PATCH v2] net/i40e: fix packet type parser issue

2018-01-13 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Friday, January 12, 2018 4:42 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix packet type parser issue > > Ptype mapping table will fail to update when loading PPP profile, fix the > issue >

Re: [dpdk-dev] [PATCH v2 1/4] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-13 Thread Tonghao Zhang
On Fri, Jan 12, 2018 at 4:39 PM, Dai, Wei wrote: > Hi, Tonghao & Beilei > > The issue reported by Tonghao is caused by shortage of igb_uio. > If you want to use Rx queue interrupt in your DPDK application, > I suggest use VFIO-PCI to bind NIC port instead of igb_uio. The performance of igb_uio is

Re: [dpdk-dev] [RFC v2 3/5] ether: Add flow timeout support

2018-01-13 Thread Zhang, Qi Z
Hi Alex & Keith Base on my further understanding about OVS requirement and the new device's capability. I realize there is no strong point to have the timeout APIs from this patch, I'd like to withdraw it. Thanks for all your comments that help me to think it over

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-13 Thread Thomas Monjalon
13/01/2018 13:15, Burakov, Anatoly: > On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: > > 07/11/2017 10:50, Jonas Pfefferle1: > >>> Is there something urgent for 17.11? > >>> Or can it be refined in 18.02? > >> > >> Nothing urgent. We can refine this for 18.02. > >> > >>> Anatoly, any thought? > > >

Re: [dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

2018-01-13 Thread Aleksey Baulin
Please see my comments inline. On Sun, Jan 14, 2018 at 1:24 AM, Thomas Monjalon wrote: > Hi, > > I moved your top-post below and did some comments inline. > More opinions are welcome. > > 13/01/2018 23:05, Aleksey Baulin: > > On Fri, Jan 12, 2018 at 6:35 PM, Thomas Monjalon > > wrote: > > > 21/

Re: [dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

2018-01-13 Thread Thomas Monjalon
Hi, I moved your top-post below and did some comments inline. More opinions are welcome. 13/01/2018 23:05, Aleksey Baulin: > On Fri, Jan 12, 2018 at 6:35 PM, Thomas Monjalon > wrote: > > 21/11/2017 08:05, Aleksey Baulin: > > > On Mon, Nov 20, 2017 at 4:36 PM, Wiles, Keith > > wrote: > > > > > O

Re: [dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

2018-01-13 Thread Aleksey Baulin
This is an interesting question. Perhaps, even a philosophical one. :-) 'likely(pointer)' is a perfectly legal statement in C language, as well as a concise one as compared to a more explicit (and redundant/superfluous) 'likely(pointer != NULL)'. If you _require_ this kind of explicitness in cases

Re: [dpdk-dev] DPDK-pktgen not giving expected throughput

2018-01-13 Thread Wiles, Keith
> On Jan 13, 2018, at 12:51 PM, Shailja Pandey wrote: > > Hi, > > Output of command ‘lspci | grep Ether’ is- > > 04:00.0 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit > X540-AT2 (rev 01) > 04:00.1 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit

[dpdk-dev] compilation error on Suse 11 - LPM init of anon union

2018-01-13 Thread Thomas Monjalon
Hi, There is a new compilation error since this commit in LPM: http://dpdk.org/commit/b2e1c99 The brace has been removed because unnecessary with anonymous union. This union is declared with RTE_STD_C11 for compatibility with old compilers: /** C extension macro for environments l

Re: [dpdk-dev] DPDK-pktgen not giving expected throughput

2018-01-13 Thread Shailja Pandey
Hi, Output of command ‘lspci | grep Ether’ is- 04:00.0 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit X540-AT2 (rev 01) 04:00.1 Ethernet controller: Intel Corporation Ethernet Controller 10-Gigabit X540-AT2 (rev 01) 05:00.0 Ethernet controller: Intel Corporation Ethernet

Re: [dpdk-dev] [PATCH 2/2] net/e1000: fix mailbox interrupt handler

2018-01-13 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Thursday, December 28, 2017 4:23 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai, Wei; Wang, Liang-min; Zhang, Qi Z; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] net/e1000: fix mailbox interrupt

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler

2018-01-13 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Thursday, December 28, 2017 4:22 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai, Wei; Wang, Liang-min; Zhang, Qi Z; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt

Re: [dpdk-dev] [PATCHv4 5/5] doc: Add ABI __experimental tag documentation

2018-01-13 Thread Thomas Monjalon
13/01/2018 01:28, Neil Horman: > On Fri, Jan 12, 2018 at 03:55:10PM +, Ferruh Yigit wrote: > > After this point agree to using EXPERIMENTAL tag in the version map as > > standard, > > but it will be hard to maintain "API is experimental for first release" > > without > > help of any automated

Re: [dpdk-dev] net/e1000: add pci ids for 82579LM

2018-01-13 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Thursday, January 11, 2018 3:12 PM > To: markus.th...@tu-ilmenau.de; dev@dpdk.org > Subject: Re: [dpdk-dev] net/e1000: add pci ids for 82579LM > > > Date: Fri, 13 Oct 2017 18:32:18 +0200 > > >

Re: [dpdk-dev] [PATCH v4] net/i40e: fix port segmentation fault when restart

2018-01-13 Thread Zhang, Helin
> -Original Message- > From: Zhao1, Wei > Sent: Friday, January 12, 2018 2:59 PM > To: dev@dpdk.org > Cc: Zhang, Helin; Zhao1, Wei > Subject: [PATCH v4] net/i40e: fix port segmentation fault when restart > > This patch will go into the process of clear all queue region related > configur

Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK

2018-01-13 Thread Burakov, Anatoly
On 19-Dec-17 11:14 AM, Anatoly Burakov wrote: This patchset introduces a prototype implementation of dynamic memory allocation for DPDK. It is intended to start a conversation and build consensus on the best way to implement this functionality. The patchset works well enough to pass all unit test

Re: [dpdk-dev] [PATCH v2 4/4] vfio: use the generic multi-process channel

2018-01-13 Thread Burakov, Anatoly
On 11-Jan-18 4:07 AM, Jianfeng Tan wrote: - } - /* fall-through on error */ - default: - RTE_LOG(ERR, EAL, " cannot get container fd!\n"); - close(socket_fd); - return -

Re: [dpdk-dev] [PATCH v2 1/2] test/test: introduce new test-case for rte_smp_mb()

2018-01-13 Thread Wiles, Keith
> On Dec 18, 2017, at 9:34 AM, Konstantin Ananyev > wrote: > > Simple functional test for rte_smp_mb() implementations. > Also when executed on a single lcore could be used as rough > estimation how many cycles particular implementation of rte_smp_mb() > might take. > > Signed-off-by: Konstan

Re: [dpdk-dev] [PATCH v2 1/2] test/test: introduce new test-case for rte_smp_mb()

2018-01-13 Thread Wiles, Keith
> On Dec 18, 2017, at 9:34 AM, Konstantin Ananyev > wrote: > > Simple functional test for rte_smp_mb() implementations. > Also when executed on a single lcore could be used as rough > estimation how many cycles particular implementation of rte_smp_mb() > might take. > > Signed-off-by: Konstan

Re: [dpdk-dev] [PATCH v2 3/4] eal: add synchronous multi-process communication

2018-01-13 Thread Burakov, Anatoly
On 11-Jan-18 4:07 AM, Jianfeng Tan wrote: --- lib/librte_eal/common/eal_common_proc.c | 144 +--- lib/librte_eal/common/include/rte_eal.h | 73 +++- lib/librte_eal/rte_eal_version.map | 2 + 3 files changed, 206 insertions(+), 13 deletions(-)

Re: [dpdk-dev] [PATCH v2 2/4] eal: add and del secondary processes in the primary

2018-01-13 Thread Burakov, Anatoly
On 11-Jan-18 4:07 AM, Jianfeng Tan wrote: By the multi-process channel, we add an mp action named "proc". As a secondary process starts, it sends a "proc add" message to the primary. As the primary finds a failure in sending message to a specific secondary process, that secondary process is tre

Re: [dpdk-dev] [PATCH v2 1/4] eal: add channel for multi-process communication

2018-01-13 Thread Burakov, Anatoly
On 11-Jan-18 4:07 AM, Jianfeng Tan wrote: diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c index 40fa982..d700e9e 100644 + int rte_eal_primary_proc_alive(const char *config_file_path) { @@ -31,3 +75,347 @@ rte_eal_primary_proc_alive(const

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-13 Thread Burakov, Anatoly
On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: 07/11/2017 10:50, Jonas Pfefferle1: Is there something urgent for 17.11? Or can it be refined in 18.02? Nothing urgent. We can refine this for 18.02. Anatoly, any thought? Anatoly, Jonas, how do you want to proceed with this patch? I don't s

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-13 Thread Burakov, Anatoly
On 31-Oct-17 3:59 PM, Jonas Pfefferle wrote: Check and report errors on open/read in noiommu check. Signed-off-by: Jonas Pfefferle --- LGTM Acked-by: Anatoly Burakov -- Thanks, Anatoly