On 1/8/2018 10:55 AM, Jerin Jacob wrote:
Signed-off-by: Jerin Jacob
---
test/test/test_bitmap.c| 32 ++--
test/test/test_eventdev.c | 32 ++--
test/test/test_eventdev_octeontx.c | 32 ++--
t
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wu, Jingjing
> Sent: Wednesday, December 27, 2017 2:19 PM
> To: Xing, Beilei
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: change VF default ITR interval
>
>
>
> > -Original Message-
>
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 26, 2017 5:44 PM
> To: Wu, Jingjing ; Yigit, Ferruh
>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 09/10] app/testpmd: enforce offloads caps
>
> In the current de
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing
> Sent: Monday, January 8, 2018 11:09 AM
> To: Wu, Jingjing; Lu, Wenzhuo; Zhang, Qi Z
> Cc: dev@dpdk.org; Chilikin, Andrey
> Subject: [dpdk-dev] [PATCH v8 0/2] support input set configuration
>
> The
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Friday, December 22, 2017 9:27 AM
> To: Xing, Beilei; Wu, Jingjing
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue
>
> > -O
> -Original Message-
> From: Chen, Junjie J
> Sent: Tuesday, January 9, 2018 7:04 PM
> To: y...@fridaylinux.org; maxime.coque...@redhat.com; Wang, Xiao W
> ; Bie, Tiwei ; Yao, Lei A
>
> Cc: dev@dpdk.org; Chen, Junjie J
> Subject: [PATCH v7] vhost: support virtqueue interrupt/notificatio
Hi Shahaf,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 26, 2017 5:44 PM
> To: Wu, Jingjing ; Yigit, Ferruh
>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags
>
> Since testpmd is
Hi Shahaf,
> -Original Message-
> From: Shahaf Shuler [mailto:shah...@mellanox.com]
> Sent: Tuesday, January 9, 2018 2:48 PM
> To: Lu, Wenzhuo ; Wu, Jingjing
> ; Yigit, Ferruh
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new
> Ethdev Tx offloads AP
Hi Gage,
On Mon, Jan 08, 2018 at 06:36:36PM +, Eads, Gage wrote:
> Hi Pavan,
>
> Thanks for the report and the GDB output. We've reproduced this and traced it
> down to how the PMD (mis)handles the re-configuration case. When the SW PMD
> is reconfigured, it reallocates the IQ chunks and rei
> -Original Message-
> From: Zhao1, Wei
> Sent: Tuesday, January 9, 2018 2:44 PM
> To: dev@dpdk.org
> Cc: Zhang, Helin
> Subject: [PATCH v6 0/2] move RSS to flow API
>
> The patches mainly finish following functions:
> 1) igb move RSS to flow API
> 2) ixgbe move RSS to flow API
>
> v2:
Hi Pablo,
On 1/8/2018 9:57 PM, De Lara Guarch, Pablo wrote:
-Original Message-
From: Shahaf Shuler [mailto:shah...@mellanox.com]
Sent: Thursday, December 21, 2017 1:45 PM
To: De Lara Guarch, Pablo ;
dev@dpdk.org; Ananyev, Konstantin ;
Nicolau, Radu ; arybche...@solarflare.com
Subject:
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Thursday, January 4, 2018 4:41 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: Zhang, Qi Z; Zhao1, Wei
> Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue
>
> Hi,
>
>
> > --
Rte_flow actually defined to include RSS,
but till now, RSS is out of rte_flow.
This patch is to move igb existing RSS to rte_flow.
The old RSS configuration is still reserved.
Signed-off-by: Wei Zhao
Acked-by: Wei Dai
---
doc/guides/rel_notes/release_18_02.rst | 6 ++
drivers/net/e1000/e1000
Rte_flow actually defined to include RSS,
but till now, RSS is out of rte_flow.
This patch is to move ixgbe existing RSS to rte_flow.
The old RSS configuration is still reserved.
Signed-off-by: Wei Zhao
Acked-by: Wei Dai
---
doc/guides/rel_notes/release_18_02.rst | 6 +-
drivers/net/ixgbe/ixg
The patches mainly finish following functions:
1) igb move RSS to flow API
2) ixgbe move RSS to flow API
v2:
-fix bug for RSS flush code.
-fix patch check warning.
v3:
-fix bug for ixgbe rss restore.
v4:
-fix build warning and add release notes comment.
v5:
-rebase patch set.
v6:
-rebase patch
Hi,
Tuesday, January 9, 2018 7:28 AM, Lu, Wenzhuo:
> Hi Shahaf,
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler
> > Sent: Tuesday, December 26, 2017 5:44 PM
> > To: Wu, Jingjing ; Yigit, Ferruh
> >
> > Cc: dev@dpdk.org
> > Subject: [dpdk-de
VF can't run in multi queue mode, if nb_q_per_pool was set as 1.
Nb_q_per_pool is passed through to max_rx_q and max_tx_q in VF.
So if nb_q_per_pool is equal to 1, max_rx_q and max_tx_q can't be more
than 1 and VF multi queue mode will fail.
Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode c
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, January 8, 2018 11:43 AM
> To: Xing, Beilei
> Cc: dev@dpdk.org; Wu, Jingjing ; Zhang, Qi Z
>
> Subject: [PATCH 04/25] net/i40e/base: release spinlock before function
> returns
>
> Fix a bug that adminq spin lock is not be release
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 26, 2017 5:44 PM
> To: Wu, Jingjing ; Yigit, Ferruh
>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 06/10] app/testpmd: cleanup internal Tx
> offloads flags field
>
The patches mainly finish following functions:
1) igb move RSS to flow API
2) ixgbe move RSS to flow API
v2:
-fix bug for RSS flush code.
-fix patch check warning.
v3:
-fix bug for ixgbe rss restore.
v4:
-fix build warning and add release notes comment.
v5:
-rebase patch set.
Wei Zhao (2):
n
> -Original Message-
> From: Zhang, Helin
> Sent: Tuesday, January 9, 2018 2:26 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: Mcnamara, John
> Subject: RE: [PATCH v3] doc: add queue region feature info to release notes
>
>
>
> > -Original Message-
> > From: Zhao1, Wei
> > Sent: Monda
Rte_flow actually defined to include RSS,
but till now, RSS is out of rte_flow.
This patch is to move igb existing RSS to rte_flow.
The old RSS configuration is still reserved.
Signed-off-by: Wei Zhao
Acked-by: Wei Dai
---
doc/guides/rel_notes/release_18_02.rst | 6 ++
drivers/net/e1000/e1000
Rte_flow actually defined to include RSS,
but till now, RSS is out of rte_flow.
This patch is to move ixgbe existing RSS to rte_flow.
The old RSS configuration is still reserved.
Signed-off-by: Wei Zhao
Acked-by: Wei Dai
---
doc/guides/rel_notes/release_18_02.rst | 6 +-
drivers/net/ixgbe/ixg
> -Original Message-
> From: Zhao1, Wei
> Sent: Monday, January 8, 2018 11:40 AM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> Subject: [PATCH v3] doc: add queue region feature info to release notes
>
> This patch add inforation about i40e queue region realted to re
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, January 8, 2018 11:44 AM
> To: Xing, Beilei
> Cc: dev@dpdk.org; Wu, Jingjing ; Zhang, Qi Z
>
> Subject: [PATCH 21/25] net/i40e/base: code clean
>
> 1. Add more debug information in PF reset 2. Remove some redandant code.
> 3. clea
> -Original Message-
> From: Zhang, Helin
> Sent: Tuesday, January 9, 2018 2:17 PM
> To: Zhao1, Wei ; dev@dpdk.org
> Cc: Mcnamara, John
> Subject: RE: [PATCH v3] doc: add queue region feature info to release notes
>
>
>
> > -Original Message-
> > From: Zhang, Helin
> > Sent: T
> -Original Message-
> From: Zhang, Helin
> Sent: Tuesday, January 9, 2018 2:15 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: Mcnamara, John
> Subject: RE: [PATCH v3] doc: add queue region feature info to release notes
>
>
>
> > -Original Message-
> > From: Zhao1, Wei
> > Sent: Monda
> -Original Message-
> From: Zhao1, Wei
> Sent: Monday, January 8, 2018 11:40 AM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> Subject: [PATCH v3] doc: add queue region feature info to release notes
>
> This patch add inforation about i40e queue region realted to re
The virtio_send_command function may be called from app's configuration
routine, but also from an interrupt handler called when live migration is
done on the backup side. So this patch makes control queue thread-safe
first.
Signed-off-by: Xiao Wang
---
drivers/net/virtio/virtio_ethdev.c | 7
This patch adds dev_pause, dev_resume and inject_pkts api to allow
driver to pause the worker threads and inject special packets into
Tx queue. The next patch will be based on this.
Signed-off-by: Xiao Wang
---
drivers/net/virtio/virtio_ethdev.c | 56 +
drive
When live migration is done, for the backup VM, either the virtio
frontend or the vhost backend needs to send out gratuitous RARP packet
to announce its new network location.
This patch enables VIRTIO_NET_F_GUEST_ANNOUNCE feature to support live
migration scenario where the vhost backend doesn't h
v7:
- Improve comment for state_lock.
- Rename spinlock variable 'sl' to 'lock'.
v6:
- Use rte_pktmbuf_alloc() instead of rte_mbuf_raw_alloc().
- Remove the 'len' parameter in calling virtio_send_command().
- Remove extra space between typo and var.
- Improve comment and alignment.
- Remove the un
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 26, 2017 5:44 PM
> To: Wu, Jingjing ; Yigit, Ferruh
>
> Cc: dev@dpdk.org; cchempara...@tilera.com; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 05/10] app/testpmd: fi
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 12, 2017 8:53 PM
> To: Yigit, Ferruh ; Wu, Jingjing
>
> Cc: dev@dpdk.org; cchempara...@tilera.com; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 05/10] app/testpmd: fi
Hi Shahaf,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 26, 2017 5:44 PM
> To: Wu, Jingjing ; Yigit, Ferruh
>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev
> Tx offloads A
-Original Message-
> Date: Mon, 8 Jan 2018 09:34:23 -0600
> From: Keith Wiles
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mbuf:using sanity checks do not panic on null
> mbuf
> X-Mailer: git-send-email 2.10.1
>
> The rte_pktmbuf_free() allows for NULL mbuf pointer, but
> when sanity
The driver can suppress interrupt when VIRTIO_F_EVENT_IDX feature bit is
negotiated. The driver set vring flags to 0, and MAY use used_event in
available ring to advise device interrupt util reach an index specified
by used_event. The device ignore the lower bit of vring flags, and send
an interrup
I’ll detail it. Thanks.
From: Andrew Rybchenko [mailto:arybche...@solarflare.com]
Sent: Saturday, January 6, 2018 6:22 PM
To: Yang, Qiming ; dev@dpdk.org; tho...@monjalon.net
Subject: Re: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags
On 01/04/2018 09:15 PM, Qiming Yang wrote:
Detail
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 26, 2017 5:44 PM
> To: Wu, Jingjing ; Yigit, Ferruh
>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 03/10] app/testpmd: support check of single
> port stop
>
> Thi
> -Original Message-
> From: Shahaf Shuler [mailto:shah...@mellanox.com]
> Sent: Sunday, January 7, 2018 2:33 PM
> To: Andrew Rybchenko ; Yang, Qiming
> ; dev@dpdk.org; Thomas Monjalon
>
> Subject: RE: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags
>
> Saturday, January 6, 201
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Tuesday, December 26, 2017 5:44 PM
> To: Wu, Jingjing ; Yigit, Ferruh
>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 02/10] app/testpmd: convert to new Ethdev
> Rx offloads API
>
> -Original Message-
> From: Wang, Xiao W
> Sent: Monday, January 8, 2018 11:12 PM
> To: Yuanhan Liu
> Cc: Bie, Tiwei ; dev@dpdk.org;
> step...@networkplumber.org
> Subject: RE: [PATCH v6 2/3] net/virtio: add packet injection method
>
>
>
> > -Original Message-
> > From: Yuanh
Checked with author offline.
Require more comments to explain the acceptable pattern for
i40e_flow_parse_rss_pattern
and also need to correct the logic since current implementation will accept any
combination of ETH and VLAN pattern which does not make sense.
Regards
Qi
> -Original Messag
Hi, Konstantin
Thanks for your comments!
Do you means that tx_q is must less than rx_q when the SRIOV is active and if
not, the application case will not be supported?
Do you think my patch will cause to 2 (or more cores) could try to TX packets
through the same TX queue? And as far as I kn
On Tue, Jan 09, 2018 at 02:12:02AM +, Chen, Junjie J wrote:
> > > + if (vring_need_event(vhost_used_event(vq), new, old)
> >
> > It's a bit weird that you use one from the standard linux header file
> > (vring_need_event), while you define you own one (vhost_used_event).
> > Note that
Hi
> -Original Message-
> From: Yuanhan Liu [mailto:y...@fridaylinux.org]
> Sent: Monday, January 8, 2018 10:07 PM
> To: Chen, Junjie J
> Cc: Wang, Xiao W ; maxime.coque...@redhat.com;
> Bie, Tiwei ; dev@dpdk.org; Yao, Lei A
>
> Subject: Re: [PATCH v6] vhost: support virtqueue interrupt/
Hi Stephen,
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, January 8, 2018 11:28 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH v4 01/15] net/avf/base: add base code for avf
> PMD
>
> On Mon, 8 J
On Fri, Jan 05, 2018 at 11:00:52AM -0500, Neil Horman wrote:
> On Fri, Jan 05, 2018 at 03:08:52PM +0100, Thomas Monjalon wrote:
> > 04/01/2018 13:56, Neil Horman:
> > > On Sat, Dec 30, 2017 at 12:15:17PM -0500, Neil Horman wrote:
> > > > Thomas-
> > > > I just noticed that the ci tests are fai
04/01/2018 21:01, Shahaf Shuler:
> Mellanox PMD patches should target the next-net-mlx sub tree.
>
> Signed-off-by: Shahaf Shuler
Acked-by: Thomas Monjalon
Applied, thanks
05/01/2018 23:33, Stephen Hemminger:
> On Fri, 5 Jan 2018 12:43:02 +0100
> Thomas Monjalon wrote:
>
> > The script checkpatch.pl from Linux is enforcing a tab
> > in the MAINTAINERS file (Linux commit 628f91a28649).
> > It can be ignored in our wrapper checkpatches.sh.
> >
> > Suggested-by: Rem
Hi Jeff,
I am surprised that there is not a lot of review of these very
important patches. Maybe it is not easy to review.
Let's try to progress in the following days.
This patch is really too big with a lot of concepts spread
in separate files, so it is difficult to properly review.
Please, try
In general, DPDK functions must not print to stdout (or stderr) directly because
typically DPDK applications are run as daemons and console is redirected to
/dev/null.
Doing a small audit of this noticed that ACL library needs to be fixed.
Instead of looking at log_level and using printf, it shou
The scan callback allows to spawn a vdev automatically
given some custom scan rules.
It is especially useful to create a TAP device automatically
connected to a netdevice as remote.
Signed-off-by: Thomas Monjalon
Acked-by: Jianfeng Tan
---
v3:
- add deadlock comment
- return -1 o
Bit-fields in mlx5_rxq_data can be chagned on the fly by a control plane -
e.g. rxq->mark. However, vectorized Rx uses a bit-field to mark pending
errors. Even if one bit is written, consuquence is to write the whole
integer and this can cause a synchronization issue - two entities write to
a same
My comment was intended as an FYI for future usage.
-Original Message-
From: Thomas Monjalon [mailto:tho...@monjalon.net]
Sent: Monday, January 8, 2018 10:46 AM
To: Stephen Hemminger
Cc: dev@dpdk.org; Stephen Hemminger ; Jerin Jacob
; Adrien Mazarguil
Subject: Re: [dpdk-dev] [PATCH v3
On Mon, 8 Jan 2018 12:24:25 -0800
Ajit Khaparde wrote:
> + rc = bnxt_hwrm_queue_qportcfg(bp);
> + if (rc) {
> + RTE_LOG(ERR, PMD, "hwrm queue qportcfg failed\n");
> + goto error_free;
> + }
I noticed that this driver is still using RTE_LOG directly.
The curre
Check for availability of on-chip resources - like Queue count,
number stat context, number of ring groups before inheriting and
initializing as per application requirements.
Also check before creating a Tx or Rx queue make sure there are
enough resources to complete the request.
Signed-off-by: Aj
From: Somnath Kotur
bnxt_free_all_hwrm_rings() was freeing all the Rx Rings including
zero-ing out the memory for the Aggregration rings, but was not issuing
the FW cmd to destroy the AGG ring(s) from HW. This would manifest in
problems when port stop/port start would be issued as there would be
From: Somnath Kotur
If the attribute/pattern for a flow is the same, with only the 'action'
i.e the destination queue index changing, allow it by cleaning up
the older ntuple filter and updating the existing flow with
the new filter rule having the new destination queue ID.
Also, clear the L2 fil
From: Somnath Kotur
When user re-issues same 5 tuple filter pattern cmd with different
destination queue, it would flag it as an existing match.
However, when deletion on this filter was attempted, it would crash
as the 'vnic' from which the filter was being removed from would be
different. Fix
Certain SKUs of NIC can support features like NPAR, Multi Host PFs per
port. We need to check for such features in order to restrict certain
HWRM commands from being sent to the FW.
For the single PF per port model, allow commands like hwrm_port_phy_cfg
from the PF driver. In NPAR and MH environm
Maintain state of PMD initialization and check it before checking stats.
In certain cases, we might end up accessing stats before the required
HWRM commands are processed by FW.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt.h| 1 +
drivers/net/bnxt/bnxt_ethdev.c | 2 ++
drivers/
If the FW fails bnxt_hwrm_func_reset() with an error status,
instead of returning -1, return a more standard value of -EIO.
Similarly sometimes the status returned by certain FW commands
may not be generic. Return a more standard value of -EIO in
that case as well.
Signed-off-by: Ajit Khaparde
--
filter1 which is used to just get the l2 filter FW id and not used
later was unecessarily being inserted into a list and was not being
freed after it's use was done.
Fix it by not doing the list insertion and releasing it back to the free
filter pool.
Signed-off-by: Somnath Kotur
Signed-off-by: A
As per documentation, While supporting ethertype_filters matching
ether_types 0x0800 (IPv4) and 0x86DD (IPv6) is invalid.
But we were wrongly doing that. This patch fixes it.
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.
Ring groups is a Rx only attribute. Make sure there are sufficient
ring groups available. Return an error if they are not available.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_cpr.c| 1 -
drivers/net/bnxt/bnxt_ethdev.c | 15 +--
drivers/net/bnxt/bnxt_hwrm.c | 14 ++
We are incrementing idx twice while allocating Tx rings.
Since this is passed to the firmware, it may cause unexpected behavior.
Fixes: daef48efe5e5 ("net/bnxt: support set MTU")
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ring.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/d
Parse the Tx checksum offload flags and set the proper bits
in the Tx descriptor.
Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_txr.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/b
Please apply these patches.
Ajit Khaparde (10):
net/bnxt: check return values in bnxt_dev_init
net/bnxt: fix double increment of idx during Tx ring alloc
net/bnxt: parse checksum offload flags
net/bnxt: fix grp_info usage
net/bnxt: return proper error code
net/bnxt: add check for multi
We are not checking for return values of functions like
bnxt_hwrm_queue_qportcfg and bnxt_hwrm_func_qcfg in bnxt_dev_init
thereby preventing a cleanup in case of a HWRM command failure.
This patch fixes that.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 12 ++--
1 fi
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Dai
> Sent: Monday, January 8, 2018 1:03 PM
> To: Lu, Wenzhuo ; Wu, Jingjing ;
> Peng, Yuan
> Cc: dev@dpdk.org; sta...@dpdk.org; Dai, Wei
> Subject: [dpdk-dev] [PATCH 1/2] app/testpmd: fix invalid rxq numbe
08/01/2018 17:54, Stephen Hemminger:
> On Sun, 7 Jan 2018 23:20:42 +0100
> Thomas Monjalon wrote:
>
> > diff --git a/lib/librte_eal/common/arch/arm/rte_hypervisor.c
> > b/lib/librte_eal/common/arch/arm/rte_hypervisor.c
> > new file mode 100644
> > index 0..3792fe2ce
> > --- /dev/null
>
Hi Pavan,
Thanks for the report and the GDB output. We've reproduced this and traced it
down to how the PMD (mis)handles the re-configuration case. When the SW PMD is
reconfigured, it reallocates the IQ chunks and reinitializes the chunk
freelist, but it doesn't delete the stale pointers in sw-
This driver was not doing atomic update of link status information.
And the return value was different than others.
The hardware also does not do autonegotiation (at least on Linux).
Signed-off-by: Stephen Hemminger
---
drivers/net/enic/enic_ethdev.c | 5 ++---
drivers/net/enic/enic_main.c |
Use new helper function.
Signed-off-by: Stephen Hemminger
---
drivers/net/thunderx/nicvf_ethdev.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/net/thunderx/nicvf_ethdev.c
b/drivers/net/thunderx/nicvf_ethdev.c
index d65d3cee727e..e41b379f3c9c 100
Common function matches this drivers usage.
Signed-off-by: Stephen Hemminger
---
drivers/net/octeontx/octeontx_ethdev.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev.c
b/drivers/net/octeontx/octeontx_ethdev.c
index bd24
Yet another driver which was not returing correct value on
link change.
Since this driver can't be built on x86 could not even
do a compile test.
Signed-off-by: Stephen Hemminger
---
drivers/net/szedata2/rte_eth_szedata2.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions
Use the new link update API, and cleanup the logic in the the
link update routine.
Tested-by: Shijith Thotton
Signed-off-by: Stephen Hemminger
---
drivers/net/liquidio/lio_ethdev.c | 54 ++-
1 file changed, 8 insertions(+), 46 deletions(-)
diff --git a/drive
Use new rte_linkstatus update API
Signed-off-by: Stephen Hemminger
---
drivers/net/i40e/i40e_ethdev.c| 44 ++-
drivers/net/i40e/i40e_ethdev_vf.c | 19 ++---
2 files changed, 8 insertions(+), 55 deletions(-)
diff --git a/drivers/net/i40e/i40e_e
Use the new helper functions from eth_dev for
handling atomic link_info update.
Signed-off-by: Stephen Hemminger
---
drivers/net/ixgbe/ixgbe_ethdev.c | 99 +++-
1 file changed, 17 insertions(+), 82 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/
Use the new API (_rte_eth_linkstatus_set) to handle link status update.
Signed-off-by: Stephen Hemminger
---
drivers/net/sfc/sfc_ethdev.c | 27 +++
drivers/net/sfc/sfc_ev.c | 23 ---
2 files changed, 11 insertions(+), 39 deletions(-)
diff --git a/
Use new rte_eth_linkstatus_get/set API.
Signed-off-by: Stephen Hemminger
---
drivers/net/e1000/em_ethdev.c | 70 +++--
drivers/net/e1000/igb_ethdev.c | 71 +++---
2 files changed, 10 insertions(+), 131 deletions(-)
diff --
Use new _rte_eth_linkstatus_get/set helper function.
Signed-off-by: Stephen Hemminger
---
drivers/net/nfp/nfp_net.c | 75 +--
1 file changed, 8 insertions(+), 67 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 050
Use the new comon code in ethdev to handle link status update.
Signed-off-by: Stephen Hemminger
---
drivers/net/virtio/virtio_ethdev.c | 64 +++---
1 file changed, 11 insertions(+), 53 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/vi
Use new _rte_eth_link_update helper.
Also remove no longer necessary include of rte_atomic.h
Signed-off-by: Stephen Hemminger
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 85 +++-
1 file changed, 15 insertions(+), 70 deletions(-)
diff --git a/drivers/net/vmxnet3/vm
Use new helper function to update the link status.
As a good side effect this fixes a but because this driver was not
returning correct status (should be -1 in link_status changed).
Signed-off-by: Stephen Hemminger
---
drivers/net/dpaa2/dpaa2_ethdev.c | 65 +--
Many drivers are all doing copy/paste of the same code to atomically
update the link status. Reduce duplication, and allow for future
changes by having common function for this.
Signed-off-by: Stephen Hemminger
---
lib/librte_ether/rte_ethdev.c | 36
lib/libr
While reviewing drivers, noticed a lot of unnecessary
duplication of code in drivers for handling the eth_dev link status
information. While consolidating this, it also became obvious that
some drivers behave differently for no good reason.
It also was a good chance to introduce atomic exchange pr
To handle atomic update of link status (64 bit), every driver
was doing its own version using cmpset.
Atomic exchange is a useful primitive in its own right;
therefore make it a EAL routine.
Signed-off-by: Stephen Hemminger
---
.../common/include/arch/x86/rte_atomic.h | 24 +++
...
Hi Ravi,
> -Original Message-
> From: Ravi Kumar [mailto:ravi1.ku...@amd.com]
> Sent: Friday, January 5, 2018 9:40 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH v2 17/20] crypto/ccp: add cpu based md5 and sha2 family
> auth algo support
>
> Auth operations can be pe
Hi Ravi,
> -Original Message-
> From: Ravi Kumar [mailto:ravi1.ku...@amd.com]
> Sent: Friday, January 5, 2018 9:40 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH v2 20/20] doc: add ccp crypto poll mode driver to release
> notes
>
I think you can add this patch direc
Hi Ravi,
> -Original Message-
> From: Ravi Kumar [mailto:ravi1.ku...@amd.com]
> Sent: Friday, January 5, 2018 9:40 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH v2 12/20] crypto/ccp: add aes-cmac auth algo aupport
>
> Signed-off-by: Ravi Kumar
...
> --- a/drivers
> -Original Message-
> From: Ravi Kumar [mailto:ravi1.ku...@amd.com]
> Sent: Friday, January 5, 2018 9:40 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH v2 03/20] crypto/ccp: add basic pmd ops support for start,
> stop, config etc
>
> Signed-off-by: Ravi Kumar
Cha
Hi Ravi,
> -Original Message-
> From: Ravi Kumar [mailto:ravi1.ku...@amd.com]
> Sent: Friday, January 5, 2018 9:40 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH v2 01/20] crypto/ccp: add AMD ccp crypto pmd support
>
Change to "crypto/ccp: support AMD CCP PMD" or ma
On Sat, Dec 30, 2017 at 10:07:54PM +0530, Pavan Nikhilesh wrote:
> Added support for detecting march and mcpu by reading midr_el1 register.
> The implementer, primary part number values read can be used to figure
> out the underlying arm cpu.
>
> Signed-off-by: Pavan Nikhilesh
> ---
>
> The cur
On Sat, 6 Jan 2018 11:10:08 +0800
Tiwei Bie wrote:
> Hi Stephen,
>
> On Fri, Jan 05, 2018 at 05:06:44PM -0800, Stephen Hemminger wrote:
> > Use the new comon code in ethdev to handle link status update.
>
> Typo: comon -> common
>
> >
> > Signed-off-by: Stephen Hemminger
> [...]
> > sta
On Sun, 7 Jan 2018 23:20:42 +0100
Thomas Monjalon wrote:
> diff --git a/lib/librte_eal/common/arch/arm/rte_hypervisor.c
> b/lib/librte_eal/common/arch/arm/rte_hypervisor.c
> new file mode 100644
> index 0..3792fe2ce
> --- /dev/null
> +++ b/lib/librte_eal/common/arch/arm/rte_hypervisor.c
On 01/08/2018 04:54 PM, Maxime Coquelin wrote:
On 01/08/2018 04:38 PM, Stephen Hemminger wrote:
On Mon, 8 Jan 2018 14:51:27 +0100
Maxime Coquelin wrote:
+static inline bool
+pci_one_device_iommu_support_va(struct rte_pci_device *dev)
+{
+#if defined(RTE_ARCH_PPC_64)
+ return false;
+#
> -Original Message-
> From: Shahaf Shuler [mailto:shah...@mellanox.com]
> Sent: Thursday, December 21, 2017 1:45 PM
> To: De Lara Guarch, Pablo ;
> dev@dpdk.org; Ananyev, Konstantin ;
> Nicolau, Radu ; arybche...@solarflare.com
> Subject: RE: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-se
On 12/29/2017 12:08 PM, Rami Rosen wrote:
> This trivial patch fixes a typo in sample apps guide, in
> the kernel nic interface (kni) section.
> Using "-config", as it is now today in this doc, will not
> work and will emit an error; it shuold be "--config" instead,
> and this patch fixes it acco
1 - 100 of 252 matches
Mail list logo
