[dpdk-dev] [PATCH v2] bus/pci: fix wrong intr_handle.type with uio_pci_generic

2017-12-28 Thread Zhiyong Yang
For virtio legacy device, testpmd startup fails when using uio_pci_generic. The issue is caused by invoking the function pci_ioport_map. The right intr_handle.type is already set before calling it, we should avoid overwriting the default value "RTE_ INTR_HANDLE_UNKNOWN" in it. Besides, the removal

Re: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self

2017-12-28 Thread Chen, Junjie J
Thanks Zhiyong Updated in v2. > -Original Message- > From: Yang, Zhiyong > Sent: Friday, December 29, 2017 2:27 PM > To: Chen, Junjie J ; y...@fridaylinux.org; > maxime.coque...@redhat.com > Cc: dev@dpdk.org; Chen, Junjie J > Subject: RE: [dpdk-dev] [PATCH] examples/vhost: fix sending ar

[dpdk-dev] [PATCH v2] examples/vhost: fix sending arp packet to self

2017-12-28 Thread Junjie Chen
ARP packets are not dropped when dest vdev is itself, which breaks RX ring inconspicuously. Fixes: 9c5ef51207c6 ("examples/vhost: handle broadcast packet") Signed-off-by: Junjie Chen --- v2: - Add fixline in commit message. examples/vhost/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

[dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog guide

2017-12-28 Thread Zhiyong Yang
fix one typo and a grammatical mistake. Fixes: b0152b1b40fe("doc: update bonding") Signed-off-by: Zhiyong Yang --- doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/prog_guide/link_bonding_poll_mode_drv_lib

Re: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self

2017-12-28 Thread Yang, Zhiyong
Hi Junjie, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Junjie Chen > Sent: Friday, December 29, 2017 6:14 PM > To: y...@fridaylinux.org; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Chen, Junjie J > Subject: [dpdk-dev] [PATCH] examples/vhost: fix sending

Re: [dpdk-dev] [PATCH v3 1/2] gro: code cleanup

2017-12-28 Thread Chen, Junjie J
> -Original Message- > From: Hu, Jiayu > Sent: Friday, December 22, 2017 3:26 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Chen, Junjie J > ; Ananyev, Konstantin > ; step...@networkplumber.org; Yigit, > Ferruh ; Yao, Lei A ; Hu, Jiayu > > Subject: [PATCH v3 1/2] gro: code cleanup > > - Re

Re: [dpdk-dev] [PATCH v3 2/2] gro: support VxLAN GRO

2017-12-28 Thread Chen, Junjie J
> -Original Message- > From: Hu, Jiayu > Sent: Friday, December 22, 2017 3:26 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Chen, Junjie J > ; Ananyev, Konstantin > ; step...@networkplumber.org; Yigit, > Ferruh ; Yao, Lei A ; Hu, Jiayu > > Subject: [PATCH v3 2/2] gro: support VxLAN GRO > >

Re: [dpdk-dev] [PATCH v3 0/2] Support VxLAN GRO

2017-12-28 Thread Chen, Junjie J
> -Original Message- > From: Hu, Jiayu > Sent: Friday, December 22, 2017 3:26 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Chen, Junjie J > ; Ananyev, Konstantin > ; step...@networkplumber.org; Yigit, > Ferruh ; Yao, Lei A ; Hu, Jiayu > > Subject: [PATCH v3 0/2] Support VxLAN GRO > > VxLAN

[dpdk-dev] [PATCH] net/virtio-user: specify the MAC of the tap

2017-12-28 Thread Ning Li
When using virtio-user with vhost-kernel to exchange packet with kernel networking stack, application can set the MAC of the tap interface via parameter. Signed-off-by: Ning Li --- drivers/net/virtio/virtio_user/vhost_kernel.c | 3 ++- drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 14

Re: [dpdk-dev] [PATCH] net/virtio-user: specify MAC address for tap port

2017-12-28 Thread Ning Li
HI Tiwei, Thanks for the reply! > Hi Ning, > > On Tue, Dec 19, 2017 at 06:08:10PM +0800, Ning Li wrote: > > Hi Tiwei, > > > > > Hi Ning, > > > > > > On Thu, Dec 14, 2017 at 07:38:14PM +0800, Ning Li wrote: > > > > When use virtio_user as exception path, we need to specify a MAC > > > > address f

[dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self

2017-12-28 Thread Junjie Chen
ARP packets are not dropped when dest vdev is itself, which breaks RX ring inconspicuously. Signed-off-by: Junjie Chen --- examples/vhost/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 89a61f0..10a7f5d 100644 --- a

Re: [dpdk-dev] [PATCH] bus/pci: fix wrong intr_handle.type with uio_pci_generic

2017-12-28 Thread Yang, Zhiyong
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, December 28, 2017 6:49 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org > Subject: Re: [PATCH] bus/pci: fix wrong intr_handle.type with uio_pci_generic > > 28/12/2017 10

[dpdk-dev] [PATCH v2] ethdev: remove useless parameter in callback process

2017-12-28 Thread Thomas Monjalon
The pointer to the user parameter of the callback registration is automatically pass to the callback function. There is no point to allow changing this user parameter by a caller. That's why this parameter is always set to NULL by PMDs and set only in ethdev layer before calling the callback functi

Re: [dpdk-dev] [PATCH] ethdev: remove useless parameter in callback process

2017-12-28 Thread Thomas Monjalon
28/12/2017 22:54, Thomas Monjalon: > 22/12/2017 04:08, Ferruh Yigit: > > On 11/28/2017 2:09 PM, Thomas Monjalon wrote: > > > The pointer to the user parameter of the callback registration is > > > automatically pass to the callback function. > > > There is no point to allow changing this user param

Re: [dpdk-dev] [PATCH] ethdev: remove useless parameter in callback process

2017-12-28 Thread Thomas Monjalon
22/12/2017 04:08, Ferruh Yigit: > On 11/28/2017 2:09 PM, Thomas Monjalon wrote: > > The pointer to the user parameter of the callback registration is > > automatically pass to the callback function. > > There is no point to allow changing this user parameter by a caller. > > That's why this paramet

Re: [dpdk-dev] [PATCH] examples/l2fwd: increase pktmbuf pool size

2017-12-28 Thread Pavan Nikhilesh
On Thu, Dec 28, 2017 at 12:36:42PM -0800, Stephen Hemminger wrote: > On Fri, 29 Dec 2017 01:49:06 +0530 > Pavan Nikhilesh wrote: > > > +/* > > + * This expression is used to calculate the number of mbufs needed > > + * depending on user input, taking into account memory for rx and > > + * tx hard

Re: [dpdk-dev] [PATCH] examples/l2fwd: increase pktmbuf pool size

2017-12-28 Thread Stephen Hemminger
On Fri, 29 Dec 2017 01:49:06 +0530 Pavan Nikhilesh wrote: > +/* > + * This expression is used to calculate the number of mbufs needed > + * depending on user input, taking into account memory for rx and > + * tx hardware rings, cache per lcore and mbuf pkt burst per port > + * per lcore. RTE_MAX

[dpdk-dev] [PATCH] examples/l2fwd: increase pktmbuf pool size

2017-12-28 Thread Pavan Nikhilesh
Make pktmbuf pool size a function of ports and lcores detected instead of using constant 8192. Signed-off-by: Pavan Nikhilesh --- Check patch generates warning `Unnecessary typecast of c90 int constant` but it is needed to make compiler happy (generates error comparison between signed and uns

Re: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool

2017-12-28 Thread Hemant Agrawal
Hi Olivier, On 12/22/2017 8:29 PM, Olivier MATZ wrote: On Mon, Dec 18, 2017 at 03:06:21PM +0530, Hemant Agrawal wrote: On 12/18/2017 2:25 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 15 Dec 2017 15:54:42 +0530 From: Hemant Agrawal To: olivier.m...@6wind.com, santosh.shu...@ca

Re: [dpdk-dev] [PATCH v2] net: update licence for network headers

2017-12-28 Thread Hemant Agrawal
On 12/22/2017 9:29 PM, Olivier Matz wrote: To be compliant with the DPDK licensing guidelines, switch to BSD-3-Clause. It can be done safely since the BSD headers from which these files derive also exist as a BSD-3-Clause license in FreeBSD. Link: https://raw.githubusercontent.com/freebsd/freeb

[dpdk-dev] [PATCH] app/eventdev: fix event device queue count

2017-12-28 Thread Pavan Nikhilesh
Fix the event device queue count reported when producer type is Rx adapter for perfomance queue and atq test. Fixes: 20eb154e0435 ("app/testeventdev: add perf queue test") Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c | 6 +++--- app/test-eventdev/test_perf_queue.c | 1

Re: [dpdk-dev] [PATCH] bus/pci: fix wrong intr_handle.type with uio_pci_generic

2017-12-28 Thread Thomas Monjalon
28/12/2017 10:37, Yang, Zhiyong: > Hi Thomas, > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Thursday, December 28, 2017 5:05 PM > > To: Yang, Zhiyong > > Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org > > Subject: Re: [PATCH] bus/pci: fix wro

[dpdk-dev] [PATCH v2 2/2] net/tap: implement RSS with eBPF classifier and action

2017-12-28 Thread Ophir Munk
Add BPF classifier for each TAP queue. According to this classifier packets marked with an RSS queue will be directed to this queue using a traffic control with "skbedit" action. The BPF classifier program is downloaded to the kernel once per TAP Rx queue. Add RSS BPF map entry for each new RSS ru

[dpdk-dev] [PATCH v2 1/2] net/tap: add eBPF instructions to TAP device

2017-12-28 Thread Ophir Munk
TAP PMD is required to support RSS queue mapping based on rte_flow API. An example usage for this requirement is failsafe transparent switching from a PCI device to TAP device while keep redirecting packets to the same RSS queues on both devices. TAP RSS implementation is based on eBPF programs se

[dpdk-dev] [PATCH v2 0/2] TAP RSS eBPF cover letter

2017-12-28 Thread Ophir Munk
The patches of TAP RSS eBPF follow the RFC on this issue https://dpdk.org/dev/patchwork/patch/31781/ v2 changes with respect to v1 = * v2 has new commits organization (3 --> 2) * BPF program was revised. It is successfully tested on IPv4 L3 L4 layers (compatible to ml

Re: [dpdk-dev] [PATCH] bus/pci: fix wrong intr_handle.type with uio_pci_generic

2017-12-28 Thread Yang, Zhiyong
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, December 28, 2017 5:05 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org > Subject: Re: [PATCH] bus/pci: fix wrong intr_handle.type with uio_pci_generic > > 28/

Re: [dpdk-dev] [PATCH] bus/pci: fix wrong intr_handle.type with uio_pci_generic

2017-12-28 Thread Thomas Monjalon
28/12/2017 07:12, Zhiyong Yang: > In the function rte_pci_ioport_map, if uio_pci_generic is used on X86 > platform, pci_ioport_map() is invoked, the operation > ev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; is execused directly, > it causes the wrong assignment for uio_pci_generic, the patch fixe

Re: [dpdk-dev] [PATCH] net/virtio-user: specify MAC address for tap port

2017-12-28 Thread Tiwei Bie
Hi Ning, On Tue, Dec 19, 2017 at 06:08:10PM +0800, Ning Li wrote: > Hi Tiwei, > > > Hi Ning, > > > > On Thu, Dec 14, 2017 at 07:38:14PM +0800, Ning Li wrote: > > > When use virtio_user as exception path, we need to specify a MAC > > > address for the tap port. > > > > Is this a fix? Did you mee