Re: [dpdk-dev] [PATCH] net/virtio: fix wrong use_msix value for legacy device

2017-12-27 Thread Yang, Zhiyong
Self Nack. Another patch has been sent out to fix testpmd startup failure issue using uio_pci_generic on virtio legacy device. http://www.dpdk.org/dev/patchwork/patch/32779/ > -Original Message- > From: Yang, Zhiyong > Sent: Wednesday, December 27, 2017 6:09 PM > To: dev@dpdk.org > Cc:

[dpdk-dev] [PATCH] bus/pci: fix wrong intr_handle.type with uio_pci_generic

2017-12-27 Thread Zhiyong Yang
In the function rte_pci_ioport_map, if uio_pci_generic is used on X86 platform, pci_ioport_map() is invoked, the operation ev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; is execused directly, it causes the wrong assignment for uio_pci_generic, the patch fixes it. Fixes: 756ce64b1ecd ("eal: introd

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler

2017-12-27 Thread Dai, Wei
According to step 7 & 8 in Table 7-74 PF-to-VF Messaging Flow in 82599 datasheet, The calling of ixgbe_read_mbx( ) can be replaced by following lines to avoid touching ->mbx.v2p_mailbox, IXGBE_WRITE_REG(hw, IXGBE_VFMAILBOX, IXGBE_VFMAILBOX_ACK); > -Original Message- > From: Zhang, Qi Z >

[dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler

2017-12-27 Thread Qi Zhang
Mailbox interrupt handler only take care of PF reset notification, for other message ixgbe_read_mbx should not be called since it get chance to break the foreground VF to PF communication. This can be simply repeated by testpmd>rx_vlan rm all 0 Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox i

[dpdk-dev] [PATCH 2/2] net/e1000: fix mailbox interrupt handler

2017-12-27 Thread Qi Zhang
Mailbox interrupt handler only take care of the PF reset notification, for other message mbx->ops.read should not be called since it get chance to break the foreground VF to PF communication. Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link up/down") Cc: sta...@dpdk.org Signed

[dpdk-dev] [PATCH] net/ixgbe: fix mailbox interrupt handler

2017-12-27 Thread Qi Zhang
Maibox interrupt handler only take about a PF reset notification, for other message ixgbe_read_mbx should not be called since it get chance to break the foreground VF to PF communication. This can be simply repeated by testpmd>rx_vlan rm all 0 Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox in

[dpdk-dev] [PATCH] net/bonding: set slave MAC addresses correctly

2017-12-27 Thread Chas Williams
From: Chas Williams Use rte_eth_dev_default_mac_addr_set() to change a slave MAC address. mac_address_set() only updates the software copy and does nothing to update the hardware. Signed-off-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_api.c | 2 +- drivers/net/bonding/rte_eth_bond_

Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: add Tx queues setup process

2017-12-27 Thread Zhao1, Wei
Thabk you. > -Original Message- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Wednesday, December 27, 2017 7:53 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: RE: [PATCH v2] examples/flow_filtering: add Tx queues setup > process > > > > > -Original Message- > > From: Wei Zh

[dpdk-dev] [PATCH v2] lib/librte_vhost: move fdset_del out of conn_mutex

2017-12-27 Thread zhike wang
From: wang zhike v2: * Move fdset_del before conn destroy. * Fix coding style. This patch fixes below race condition: 1. one thread calls: rte_vhost_driver_unregister->lock conn_mutex ->fdset_del->loop to check fd.busy. 2. another thread calls fdset_event_dispatch, and the busy flag is cha

[dpdk-dev] [PATCH v2] tap: remove unused KERNEL_VERSION definitions

2017-12-27 Thread Stephen Hemminger
The TAP device does not use these definitions in current version. And kernel version is not the correct way to detect features. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/ta

[dpdk-dev] [PATCH] pci: don't use kernel version to determine MSIX defines

2017-12-27 Thread Stephen Hemminger
In real life, kernel version is only weakly corolated with presence or absence of defines in header files. Instead, check directly if the needed value is defined. Signed-off-by: Stephen Hemminger --- drivers/bus/pci/linux/pci_init.h | 20 +--- 1 file changed, 13 insertions(+), 7

[dpdk-dev] [PATCH] tap: remove unused KERNEL_VERSION definitions

2017-12-27 Thread Stephen Hemminger
The TAP device does not use these definitions in current version. And kernel version is not the correct way to detect features. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap

Re: [dpdk-dev] [RFC 0/5] Port Representor for control and monitoring of VF devices

2017-12-27 Thread Alex Rosenbaum
On Wed, Dec 27, 2017 at 11:40 AM, Mohammad Abdul Awal wrote: > On 22/12/2017 22:33, Alex Rosenbaum wrote: >> On Fri, Dec 22, 2017 at 4:31 PM, Mohammad Abdul Awal >>> On 21/12/2017 14:51, Alex Rosenbaum wrote: > By hotplug I did not mean HW hotplug, rather I meant the software hotplug of > port rep

Re: [dpdk-dev] [PATCH v2 0/4] various fixes and cleanups for virtio PMD

2017-12-27 Thread Yuanhan Liu
On Mon, Dec 11, 2017 at 01:13:28PM +0800, Tiwei Bie wrote: > v2: > - refine indent for patch 2 > - fix a typo in commit log for patch 4 > - drop the blank lines squeezing patch Series applied to dpdk-next-virtio. Thanks. --yliu > > Tiwei Bie (4): > net/virtio: fix vector Rx break caus

Re: [dpdk-dev] [PATCH] vhost: support Generic Segmentation Offload

2017-12-27 Thread Yuanhan Liu
On Mon, Dec 25, 2017 at 01:53:29AM +, Yao, Lei A wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiayu Hu > > Sent: Tuesday, November 28, 2017 1:29 PM > > To: dev@dpdk.org > > Cc: y...@fridaylinux.org; Tan, Jianfeng ; Hu, Jiayu > > > > Subje

Re: [dpdk-dev] [PATCH] net/virtio: fix incorrect cast of void *

2017-12-27 Thread Yuanhan Liu
On Thu, Dec 14, 2017 at 03:49:32PM +0100, Maxime Coquelin wrote: > > > On 12/14/2017 03:33 PM, Olivier Matz wrote: > >From: Didier Pallard > > > >The rx_queues and tx_queues fields of the data structure points to a struct > >virtnet_rx or virtnet_tx. Casting it to a virtqueue is an error. > > >

Re: [dpdk-dev] [PATCH] vhost: support UDP Fragmentation Offload

2017-12-27 Thread Yuanhan Liu
On Tue, Nov 21, 2017 at 02:56:52PM +0800, Jiayu Hu wrote: > In virtio, UDP Fragmentation Offload (UFO) includes two parts: host UFO > and guest UFO. Guest UFO means the frontend can receive large UDP packets, > and host UFO means the backend can receive large UDP packets. This patch > supports host

Re: [dpdk-dev] [PATCH] lib/librte_vhost: remove redundant logic judgement

2017-12-27 Thread Yuanhan Liu
On Mon, Dec 25, 2017 at 05:16:17PM +0800, Zhiyong Yang wrote: > At the beginning of vring_translate, the code > if(!(dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))) already judges > if IOMMU_PLATFORM is supported. The function vhost_iova_to_vva always > repeats the logic, __vhost_iova_to_vva ca

Re: [dpdk-dev] [PATCH] net/virtio: remove unnecessary macro definitions

2017-12-27 Thread Yuanhan Liu
On Tue, Dec 26, 2017 at 05:25:00PM +0800, Zhiyong Yang wrote: > DPDK has already the definition of Ethernet numeric link speeds in Mbps in > the file Rte_ethdev.h, it is unnecessary to rededine virtio specific link > speeds macros again. > > Signed-off-by: Zhiyong Yang Applied to dpdk-next-virti

[dpdk-dev] [PATCH] lib/librte_vhost: move fdset_del out of conn_mutex

2017-12-27 Thread zhike wang
From: wang zhike This patch fixes below race condition: 1. one thread calls: rte_vhost_driver_unregister->lock conn_mutex ->fdset_del->loop to check fd.busy. 2. another thread calls fdset_event_dispatch, and the busy flag is changed AFTER handling on the fd, i.e, rcb(). However, the rcb,

Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: add Tx queues setup process

2017-12-27 Thread Ori Kam
> -Original Message- > From: Wei Zhao [mailto:wei.zh...@intel.com] > Sent: Wednesday, December 27, 2017 10:32 AM > To: dev@dpdk.org > Cc: Ori Kam ; Wei Zhao > Subject: [PATCH v2] examples/flow_filtering: add Tx queues setup process > > This example do not has the process of set up tx qu

[dpdk-dev] [PATCH] net/virtio: fix wrong use_msix value for legacy device

2017-12-27 Thread Zhiyong Yang
If virtio fails to detect modern device, use_misx should be reset to VIRTIO_MSIX_NONE, otherwise this wrong value will be used after legacy device detection succeeds to be done. Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO") Cc: sta...@dpdk.org Signed-off-by: Zhiyong Yang --- dri

Re: [dpdk-dev] [RFC 0/5] Port Representor for control and monitoring of VF devices

2017-12-27 Thread Mohammad Abdul Awal
On 22/12/2017 22:33, Alex Rosenbaum wrote: On Fri, Dec 22, 2017 at 4:31 PM, Mohammad Abdul Awal wrote: On 21/12/2017 14:51, Alex Rosenbaum wrote: As described in the links Alejandro referenced earlier, each of the switch ports should be a real PMD, and switch operations should be applied on

Re: [dpdk-dev] [PATCH] examples/flow_filtering: add Tx queues setup process

2017-12-27 Thread Zhao1, Wei
Hi, Ori Kam Thank you for your suggestion. I have commit a v2 to DPDK.org. https://dpdk.org/dev/patchwork/patch/32768/ > -Original Message- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Tuesday, December 26, 2017 10:09 PM > To: Zhao1, Wei > Cc: Lu, Wenzhuo ; dev@dpdk.org > Subje

[dpdk-dev] [PATCH v2] examples/flow_filtering: add Tx queues setup process

2017-12-27 Thread Wei Zhao
This example do not has the process of set up tx queues, but some NIC start up process will be blocked if this is no tx queue and only rx queues. So add tx queues setup process in main code. Signed-off-by: Wei Zhao --- v2: -add support the new tx offloads. --- examples/flow_filtering/main.c |

[dpdk-dev] [PATCH v2] examples/flow_filtering: add Tx queues setup process

2017-12-27 Thread Wei Zhao
From: zhao wei This example do not has the process of set up tx queues, but some NIC start up process will be blocked if this is no tx queue and only rx queues. So add tx queues setup process in main code. Signed-off-by: Wei Zhao --- v2: -add support the new tx offloads. --- examples/flow_fi

Re: [dpdk-dev] [PATCH v2] net/i40e: enable VF Tx offload

2017-12-27 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, December 27, 2017 4:27 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH v2] net/i40e: enable VF Tx offload > > Enable VF Tx offload including outer ip checksum, TSO and tunnel TSO. > > Signed-off-by: Beilei Xing > -

[dpdk-dev] [PATCH v2] net/i40e: enable VF Tx offload

2017-12-27 Thread Beilei Xing
Enable VF Tx offload including outer ip checksum, TSO and tunnel TSO. Signed-off-by: Beilei Xing --- v2 changes: - Reword commit log. drivers/net/i40e/i40e_ethdev_vf.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i4