Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk

2017-12-13 Thread Thomas Monjalon
14/12/2017 00:44, chunmei Liu: > From: chunmei > > ceph async messenger has some run time error with this dpdk library, > 1) need set rxm->next= null at end of packet since not init it to null > when allocate a buffer other wise rte_mbuf_sanity_check will report error. > 2) when check the size, c

[dpdk-dev] [PATCH] examples/ipsec-secgw: improve ipsec dequeue logic

2017-12-13 Thread Akhil Goyal
Since the processing of crypto operations may take time due to hardware offload, all the packets may not be available in the single dequeue command. So it may happen that there is leakage of cops, and there is nobody to dequeue the packets because dequeue of crypto ops is done only once for a parti

[dpdk-dev] [PATCH] examples/ipsec-secgw: update mbuf packet type

2017-12-13 Thread Akhil Goyal
Packet_type should be updated to remove/add L4 type for encrypted/decrypted packet Signed-off-by: Akhil Goyal --- examples/ipsec-secgw/ipip.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipip.h b/examples/ipsec-secgw/ipip.h index 93393d5..9267618

[dpdk-dev] [PATCH] examples/ipsec-secgw: add cryptodev mask option

2017-12-13 Thread Akhil Goyal
Previously, ipsec-secgw application did not give user the flexibility to decide which crypto device(s) will be used. In this patch, a new cryptodev_mask option is added to the application. Same as portmask, the cryptodev_mask avails the user to mask out the unwanted crypto devices in the system.

[dpdk-dev] [PATCH v2 3/3] net/qede: add support for GENEVE tunneling offload

2017-12-13 Thread Rasesh Mody
From: Shahed Shaikh This patch refactors existing VXLAN tunneling offload code and enables following features for GENEVE: - destination UDP port configuration - checksum offloads - filter configuration Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 518 ++

[dpdk-dev] [PATCH v2 2/3] net/qede: fix to reject config with no Rx queue

2017-12-13 Thread Rasesh Mody
From: Harish Patil The qede firmware expects minimum one RX queue to be created, otherwise it results in firmware exception. So a check is added to prevent that. Fixes: ec94dbc57362 ("qede: add base driver") Cc: sta...@dpdk.org Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c |

[dpdk-dev] [PATCH v2 1/3] net/qede: fix to enable LRO over tunnels

2017-12-13 Thread Rasesh Mody
From: Harish Patil Enable LRO feature to work with tunnel encapsulation protocols. Fixes: 29540be7efce ("net/qede: support LRO/TSO offloads") Cc: sta...@dpdk.org Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v2 0/3] net/qede: add enhancements and fixes

2017-12-13 Thread Rasesh Mody
Hi Ferruh, This patch set adds enhancements and fixes for qede PMD. v1..v2 - separate out QEDE PMD changes from rest. Thanks! Rasesh Harish Patil (2): net/qede: fix to enable LRO over tunnels net/qede: fix to reject config with no Rx queue Shahed Shaikh (1): net/qede: add support for GEN

Re: [dpdk-dev] [RFC PATCH 0/3] ethdev: few changes in rte_ethdev layer

2017-12-13 Thread Jerin Jacob
-Original Message- > Date: Fri, 1 Dec 2017 14:55:12 + > From: Konstantin Ananyev > To: dev@dpdk.org, dev@dpdk.org > CC: Konstantin Ananyev > Subject: [dpdk-dev] [RFC PATCH 0/3] ethdev: few changes in rte_ethdev layer > X-Mailer: git-send-email 1.7.0.7 > Hi Konstantin, > The series

Re: [dpdk-dev] [PATCH v2 2/2] gro: support VxLAN GRO

2017-12-13 Thread Hu, Jiayu
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, December 14, 2017 11:03 AM > To: Hu, Jiayu > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Tan, Jianfeng ; Chen, Junjie J > ; Mcnamara, John ; > matvejchi...@gmail.com > Subject: R

Re: [dpdk-dev] [PATCH v3 3/4] net/bond: dedicated hw queues for LACP control traffic

2017-12-13 Thread Linhaifeng
Hi, Tomasz Thanks for the reply! I thought that the patch was used to resolve the "lacp loss" problem. We know when the traffic is large enough bond may loss the lacp packets and slave would out of sync. My question is, are there any solutions to solve the "lacp loss" problem? -Original

Re: [dpdk-dev] [PATCH v2 2/2] gro: support VxLAN GRO

2017-12-13 Thread Stephen Hemminger
On Thu, 14 Dec 2017 10:49:39 +0800 Jiayu Hu wrote: > + /* Don't merge packets whose outer DF bits are different. */ > + if (item->outer_is_atomic ^ outer_is_atomic) unlikely() here? > + return 0; > + > + l2_offset = pkt->outer_l2_len + pkt->outer_l3_len; > + cmp = ch

Re: [dpdk-dev] [PATCH v2 2/2] gro: support VxLAN GRO

2017-12-13 Thread Stephen Hemminger
On Thu, 14 Dec 2017 10:49:39 +0800 Jiayu Hu wrote: > + > +static inline int > +is_same_vxlan_tcp4_flow(struct vxlan_tcp4_flow_key k1, > + struct vxlan_tcp4_flow_key k2) > +{ > + return (is_same_ether_addr(&k1.outer_eth_saddr, &k2.outer_eth_saddr) && > + is_same

Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header

2017-12-13 Thread Jerin Jacob
-Original Message- > Date: Wed, 13 Dec 2017 23:35:48 + > From: "Eads, Gage" > To: Jerin Jacob , "Gujjar, Abhinandan S" > > CC: "dev@dpdk.org" , "Vangati, Narender" > , "Rao, Nikhil" , > "hemant.agra...@nxp.com" , "Doherty, Declan" > , "nidadavolu.mur...@cavium.com" > , "nithin.da

[dpdk-dev] [PATCH v2 2/2] gro: support VxLAN GRO

2017-12-13 Thread Jiayu Hu
This patch adds a framework that allows GRO on tunneled packets. Furthermore, it leverages that framework to provide GRO support for VxLAN-encapsulated packets. Supported VxLAN packets must have an outer IPv4 header, and contain an inner TCP/IPv4 packet. VxLAN GRO doesn't check if input packets ha

[dpdk-dev] [PATCH v2 1/2] gro: code cleanup

2017-12-13 Thread Jiayu Hu
This patch updates gro codes as follows: - extract common internal functions for supporting tunneled gro - rename internal functions and variants for better understanding - update the programmer guide and function comments - comply RFC 6864 to process IP ID fields Signed-off-by: Jiayu Hu --- ...

[dpdk-dev] [PATCH v2 0/2] Support VxLAN GRO

2017-12-13 Thread Jiayu Hu
VxLAN is one of the most widely used tunneled protocols. Providing GRO support for VxLAN-encapsulated packets can benefit many per-packet based applications, like Open vSwitch. This patchset is to support VxLAN GRO. The first patch cleans up current gro codes for the sake of supporting tunneled GR

[dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk

2017-12-13 Thread chunmei Liu
From: chunmei ceph async messenger has some run time error with this dpdk library, 1) need set rxm->next= null at end of packet since not init it to null when allocate a buffer other wise rte_mbuf_sanity_check will report error. 2) when check the size, can't calculate mbuf_data_room_size because

[dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk

2017-12-13 Thread chunmei Liu
From: chunmei ceph async messenger has some run time error with this dpdk library, 1) need set rxm->next= null at end of packet since not init it to null when allocate a buffer other wise rte_mbuf_sanity_check will report error. 2) when check the size, can't calculate mbuf_data_room_size because

Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header

2017-12-13 Thread Eads, Gage
Hey Jerin, > > + > > + /** > > + * @warning > > + * @b EXPERIMENTAL: this enum may change without prior notice > > + * > > + * Crypto event adapter type > > + */ > > +enum rte_event_crypto_adapter_type { > > + RTE_EVENT_CRYPTO_ADAPTER_RX_ONLY = 1, > > + /**< Start only Rx part of crypto adap

Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk

2017-12-13 Thread Stephen Hemminger
On Wed, 13 Dec 2017 22:46:30 + "Liu, Chunmei" wrote: > Hold on, Let me try another place to fix this issue. > > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, December 13, 2017 1:31 PM > To: Liu, Chunmei > Cc: dev@dpdk.org > Sub

Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk

2017-12-13 Thread Liu, Chunmei
Hold on, Let me try another place to fix this issue. -Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Wednesday, December 13, 2017 1:31 PM To: Liu, Chunmei Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on

Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk

2017-12-13 Thread Liu, Chunmei
But if not initialize allocated mbuf->next = NULL, when do ip package assemble, the last mbuf->next maybe not be null, all the logical has error, the application use null pointer determine a packaged end. DPDK NIC doesn't work now. -Original Message- From: Stephen Hemminger [mailto:step

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Gaëtan Rivet
Hi again Matan, On Wed, Dec 13, 2017 at 05:09:16PM +0100, Gaëtan Rivet wrote: > On Wed, Dec 13, 2017 at 03:48:46PM +, Matan Azrad wrote: > > Hi Gaetan > > Thanks for the review. > > Some comments.. > > > > > -Original Message- > > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] >

Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk

2017-12-13 Thread Stephen Hemminger
On Wed, 13 Dec 2017 11:32:32 -0800 chunmei Liu wrote: > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c > index 1e07895..30fdbc1 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -1589,6 +1589,7 @@ ixgbe_rx_alloc_bufs(struct ixg

Re: [dpdk-dev] [PATCH 0/3] ethdev: add API to get preferred mbuf pool ops

2017-12-13 Thread Thomas Monjalon
13/12/2017 20:55, Pavan Nikhilesh: > This patch set provides new API to get and set the preferred mbuf mempool > ops across all the probed ethernet devices. > The API depends relies on ethernet devices to provide their preferred > mempool through `rte_eth_dev_pool_ops_supported`. Note that this ne

Re: [dpdk-dev] [dpdk-users] attach/detach on secondary process

2017-12-13 Thread Thomas Monjalon
13/12/2017 22:10, Stephen Hemminger: > On Wed, 13 Dec 2017 22:00:48 +0100 > Thomas Monjalon wrote: > > > 13/12/2017 18:09, Stephen Hemminger: > > > Many DPDK drivers require that setup and initialization be done by > > > the primary process. This is mostly to avoid dealing with concurrency > > >

Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk

2017-12-13 Thread Thomas Monjalon
13/12/2017 20:32, chunmei Liu: > drivers/net/ixgbe/ixgbe_rxtx.c | 1 + > lib/librte_mbuf/rte_mbuf.c | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) +Cc Olivier Please note that such a change in lib/librte_mbuf/ cannot be applied without the approval of Olivier Matz.

Re: [dpdk-dev] [dpdk-users] attach/detach on secondary process

2017-12-13 Thread Stephen Hemminger
On Wed, 13 Dec 2017 22:00:48 +0100 Thomas Monjalon wrote: > 13/12/2017 18:09, Stephen Hemminger: > > Many DPDK drivers require that setup and initialization be done by > > the primary process. This is mostly to avoid dealing with concurrency since > > there can be multiple secondary processes.

Re: [dpdk-dev] [dpdk-users] attach/detach on secondary process

2017-12-13 Thread Thomas Monjalon
13/12/2017 18:09, Stephen Hemminger: > Many DPDK drivers require that setup and initialization be done by > the primary process. This is mostly to avoid dealing with concurrency since > there can be multiple secondary processes. I think we should consider this limitation as a bug. We must allow a

[dpdk-dev] [PATCH 3/3] app/testpmd: set preferred mempool as default pktpool

2017-12-13 Thread Pavan Nikhilesh
Set the mempool preferred by the ethernet devices as default mbuf mempool before creating the pktpool. Signed-off-by: Pavan Nikhilesh --- app/test-pmd/testpmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index c3ab44849..bfea35613 100644

[dpdk-dev] [PATCH 1/3] eal: add API to set default mbuf mempool ops

2017-12-13 Thread Pavan Nikhilesh
Add new API to set the default mbuf mempool ops name i.e. set the provided ops name to `internal_config.mbuf_pool_ops_name`. Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/bsdapp/eal/eal.c | 6 ++ lib/librte_eal/common/include/rte_eal.h | 9 + lib/librte_eal/linuxapp/eal/e

[dpdk-dev] [PATCH 2/3] ethdev: add API to get preferred mempool ops name

2017-12-13 Thread Pavan Nikhilesh
Add API to scan through the ethernet devices and return the best mbuf mempool ops name. If no such mempool is found it returns the default mempool configured. Signed-off-by: Pavan Nikhilesh --- lib/librte_ether/rte_ethdev.c | 41 + lib/librte_ether/rte_e

[dpdk-dev] [PATCH 0/3] ethdev: add API to get preferred mbuf pool ops

2017-12-13 Thread Pavan Nikhilesh
This patch set provides new API to get and set the preferred mbuf mempool ops across all the probed ethernet devices. The API depends relies on ethernet devices to provide their preferred mempool through `rte_eth_dev_pool_ops_supported`. Currently, this patchset modifies only testpmd to used the A

[dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk

2017-12-13 Thread chunmei Liu
From: chunmei ceph async messenger has some run time error with this dpdk library, 1) need init mb->next= null when allocate a buffer other wise rte_mbuf_sanity_check will report error. 2) when check the size, can't calculate mbuf_data_room_size because async messenger dpdk will allocate this par

[dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk

2017-12-13 Thread chunmei Liu
From: chunmei ceph async messenger has some run time error with this dpdk library, 1) need init mb->next= null when allocate a buffer other wise rte_mbuf_sanity_check will report error. 2) when check the size, can't calculate mbuf_data_room_size because async messenger dpdk will allocate this par

Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header

2017-12-13 Thread Jerin Jacob
-Original Message- > Date: Wed, 13 Dec 2017 19:52:24 +0530 > From: Akhil Goyal > To: Jerin Jacob , "Doherty, Declan" > > CC: Abhinandan Gujjar , dev@dpdk.org, > narender.vang...@intel.com, Nikhil Rao , Gage Eads > , hemant.agra...@nxp.com, > nidadavolu.mur...@cavium.com, nithin.dabilp

Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API

2017-12-13 Thread Jerin Jacob
-Original Message- > Date: Wed, 13 Dec 2017 12:10:26 + > From: "Ananyev, Konstantin" > To: Jerin Jacob , Shahaf Shuler > > CC: "dev@dpdk.org" , "Nicolau, Radu" > , "arybche...@solarflare.com" > > Subject: RE: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev > offloads A

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Thomas Monjalon
13/12/2017 17:09, Gaëtan Rivet: > On Wed, Dec 13, 2017 at 03:48:46PM +, Matan Azrad wrote: > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > > > Fixes: a46f8d5 ("net/failsafe: add fail-safe PMD") > > > > Fixes: b737a1e ("net/failsafe: support flow API") > > > > Cc: sta...@dpdk.org > >

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Gaëtan Rivet
On Wed, Dec 13, 2017 at 03:48:46PM +, Matan Azrad wrote: > Hi Gaetan > Thanks for the review. > Some comments.. > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Wednesday, December 13, 2017 5:17 PM > > To: Matan Azrad > > Cc: Adrien Mazarguil ;

Re: [dpdk-dev] [ovs-dev] [PATCH] netdev-dpdk: defer MTU set after interface start

2017-12-13 Thread Aaron Conole
"Stokes, Ian" writes: >> > The issue only arises with the qede PMD and 67fe6d635193 >> > ("netdev-dpdk: use rte_eth_dev_set_mtu.") >> >> I had some more time to look at this today but this patch will break >> OVS DPDK for existing supported DPDK ports during testing. >> >> I tested with an XL710

[dpdk-dev] [PATCH] cryptodev: fix function prototype

2017-12-13 Thread Pablo de Lara
qp_detach_session function was using the attach_session_t function prototype, instead of detach_session_t. Since both of them have the same parameters, there were no compilation issues, but it is not consistent. Fixes: d816fdea557c ("cryptodev: add API to associate session with queue pair") Cc: st

[dpdk-dev] [PATCH] cryptodev: remove duplicated device name length

2017-12-13 Thread Pablo de Lara
Two macros were defined in cryptodev, to serve the same purpose: RTE_CRYPTODEV_NAME_LEN (in the config file) and RTE_CRYPTODEV_NAME_MAX_LEN (in the rte_cryptodev.h file). Since the second one is part of the external API, the first one has been removed, avoiding duplications. Signed-off-by: Pablo d

[dpdk-dev] [PATCH] cryptodev: add missing CPU flag string

2017-12-13 Thread Pablo de Lara
CPU flag AVX512 was added in a previous release, but it was not added in the list of strings. Fixes: 84d796586604 ("crypto/aesni_mb: support AVX512") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- lib/librte_cryptodev/rte_cryptodev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/l

Re: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test to driver

2017-12-13 Thread Pavan Nikhilesh Bhagavatula
On Wed, Dec 13, 2017 at 11:41:55AM +, Bruce Richardson wrote: > On Wed, Dec 13, 2017 at 04:49:47PM +0530, Pavan Nikhilesh Bhagavatula wrote: > > On Wed, Dec 13, 2017 at 10:19:51AM +, Van Haaren, Harry wrote: > > > > -Original Message- > > > > From: Pavan Nikhilesh [mailto:pbhagavat.

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Matan Azrad
Hi Gaetan Thanks for the review. Some comments.. > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, December 13, 2017 5:17 PM > To: Matan Azrad > Cc: Adrien Mazarguil ; Thomas Monjalon > ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2 4/4

Re: [dpdk-dev] [PATCH v3 1/4] Introducing SPDX License Identifiers

2017-12-13 Thread Wiles, Keith
> On Dec 13, 2017, at 5:38 AM, Bruce Richardson > wrote: > > On Wed, Dec 13, 2017 at 11:46:23AM +0100, Thomas Monjalon wrote: >> Hi Hemant, >> >> Some comments below >> >> 08/12/2017 08:41, Hemant Agrawal: >>> --- /dev/null >>> +++ b/Licenses/Exceptions.txt >> >> Please use lowercase for fi

Re: [dpdk-dev] [PATCHv4 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-13 Thread Bruce Richardson
On Wed, Dec 13, 2017 at 10:17:23AM -0500, Neil Horman wrote: > Hey all- > A few days ago, I was lamenting the fact that, when reviewing patches > I > would frequently complain about ABI changes that were actually considered safe > because they were part of the EXPERIMENTAL api set. John M

Re: [dpdk-dev] [PATCHv4 5/5] doc: Add ABI __experimental tag documentation

2017-12-13 Thread Bruce Richardson
On Wed, Dec 13, 2017 at 10:17:28AM -0500, Neil Horman wrote: > Document the need to add the __experimental tag to appropriate functions > > Signed-off-by: Neil Horman > CC: Thomas Monjalon > CC: "Mcnamara, John" > CC: Bruce Richardson > --- > doc/guides/contributing/versioning.rst | 9 +++

[dpdk-dev] [PATCHv4 3/5] Makefiles: Add experimental tag check and warnings to trigger on use

2017-12-13 Thread Neil Horman
Add checks during build to ensure that all symbols in the EXPERIMENTAL version map section have __experimental tags on their definitions, and enable the warnings needed to announce their use. Also add an ALLOW_EXPERIMENTAL_APIS define to allow individual libraries and files to declare the acceptab

[dpdk-dev] [PATCHv4 4/5] dpdk: add __experimental tag to appropriate api calls

2017-12-13 Thread Neil Horman
Append the __experimental tag to api calls appearing in the EXPERIMENTAL section of their libraries version map Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Mcnamara, John" CC: Bruce Richardson --- lib/librte_eal/common/eal_common_dev.c | 6 ++- lib/librte_eal/common/eal_c

[dpdk-dev] [PATCHv4 5/5] doc: Add ABI __experimental tag documentation

2017-12-13 Thread Neil Horman
Document the need to add the __experimental tag to appropriate functions Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Mcnamara, John" CC: Bruce Richardson --- doc/guides/contributing/versioning.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/contributing/ver

[dpdk-dev] [PATCHv4 1/5] buildtools: Add tool to check EXPERIMENTAL api exports

2017-12-13 Thread Neil Horman
This tools reads the given version map for a directory, and checks to ensure that, for each symbol listed in the export list, the corresponding definition is tagged as __experimental, erroring out if its not. In this way, we can ensure that the EXPERIMENTAL api is kept in sync with the tags Signe

[dpdk-dev] [PATCHv4 2/5] compat: Add __experimental macro

2017-12-13 Thread Neil Horman
The __experimental macro tags a given exported function as being part of the EXPERIMENTAL api. Use of this tag will cause any caller of the function (that isn't removed by dead code elimination) to emit a warning that the user is making use of an API whos stabilty isn't guaranteed. It also places

[dpdk-dev] [PATCHv4 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-13 Thread Neil Horman
Hey all- A few days ago, I was lamenting the fact that, when reviewing patches I would frequently complain about ABI changes that were actually considered safe because they were part of the EXPERIMENTAL api set. John M. asked me then what I might do to improve the situation, and the follow

Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Gaëtan Rivet
Hi Matan, On Wed, Dec 13, 2017 at 02:29:30PM +, Matan Azrad wrote: > There is time between the physical removal of the device until > sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and > applications still don't know about the removal and may call sub-device > control operation wh

Re: [dpdk-dev] [PATCH v2 12/18] eal: add generic device declaration parameter

2017-12-13 Thread Shreyansh Jain
On Wednesday 13 December 2017 08:17 PM, Gaëtan Rivet wrote: On Wed, Dec 13, 2017 at 07:56:42PM +0530, Shreyansh Jain wrote: On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: Add a new generic device declaration parameter: --dev= [...] diff --git a/lib/librte_eal/common/eal_c

Re: [dpdk-dev] [PATCH 1/3] ethdev: add max burst size to device info

2017-12-13 Thread Shreyansh Jain
On Wednesday 13 December 2017 06:22 PM, Ananyev, Konstantin wrote: -Original Message- From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] Sent: Tuesday, December 12, 2017 1:44 PM To: Ananyev, Konstantin ; Matan Azrad ; Nikhil Agarwal Cc: dev@dpdk.org; Hunt, David ; nikhil.agar...@nx

Re: [dpdk-dev] [PATCH v2 12/18] eal: add generic device declaration parameter

2017-12-13 Thread Gaëtan Rivet
On Wed, Dec 13, 2017 at 07:56:42PM +0530, Shreyansh Jain wrote: > On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: > > Add a new generic device declaration parameter: > > > > --dev= > > > > [...] > > > > > diff --git a/lib/librte_eal/common/eal_common_options.c > > b/lib/librte_e

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-13 Thread Nelio Laranjeiro
Hi, On Wed, Dec 13, 2017 at 07:23:19PM +0530, Anoob Joseph wrote: > Hi Nelio, > > > On 12/13/2017 06:23 PM, Nelio Laranjeiro wrote: > > Hi Anoob, > > > > On Wed, Dec 13, 2017 at 05:08:19PM +0530, Anoob Joseph wrote: > > > Hi Nelio, > > > > > > > > > On 12/13/2017 03:32 PM, Nelio Laranjeiro wr

Re: [dpdk-dev] [PATCH v3 1/2] lib/security: add support for get metadata

2017-12-13 Thread Akhil Goyal
On 12/12/2017 7:20 PM, Anoob Joseph wrote: Hi Akhil, Radu On 12/12/2017 02:25 PM, Akhil Goyal wrote: Hi Anoob, On 12/11/2017 12:51 PM, Anoob wrote: Hi Akhil, Can you confirm if you are fine with the approach explained inline. Thanks, Anoob On 12/06/2017 03:13 PM, Radu Nicolau wrote: Hi,

Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header

2017-12-13 Thread Akhil Goyal
Hi Nithin, On 12/13/2017 5:58 PM, Nithin Dabilpuram wrote: Hi Jerin, Declan, On Wednesday 13 December 2017 04:56 PM, Jerin Jacob wrote: -Original Message- Date: Wed, 13 Dec 2017 11:03:06 + From: "Doherty, Declan" To: Jerin Jacob , Abhinandan Gujjar   CC: dev@dpdk.org, narender.v

[dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling

2017-12-13 Thread Matan Azrad
There is time between the physical removal of the device until sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and applications still don't know about the removal and may call sub-device control operation which should return an error. In previous code this error is reported to the appl

[dpdk-dev] [PATCH v2 3/4] net/mlx5: support a device removal check operation

2017-12-13 Thread Matan Azrad
Add support to get removal status of mlx5 device. It is not supported in secondary process. Signed-off-by: Matan Azrad --- drivers/net/mlx5/mlx5.c| 2 ++ drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_ethdev.c | 20 3 files changed, 23 insertions(+) d

[dpdk-dev] [PATCH v2 2/4] net/mlx4: support a device removal check operation

2017-12-13 Thread Matan Azrad
Add support to get removal status of mlx4 device. Signed-off-by: Matan Azrad --- drivers/net/mlx4/mlx4.c| 1 + drivers/net/mlx4/mlx4.h| 1 + drivers/net/mlx4/mlx4_ethdev.c | 20 3 files changed, 22 insertions(+) diff --git a/drivers/net/mlx4/mlx4.c b/drive

[dpdk-dev] [PATCH v2 1/4] ethdev: add devop to check removal status

2017-12-13 Thread Matan Azrad
There is time between the physical removal of the device until PMDs get a RMV interrupt. At this time DPDK PMDs and applications still don't know about the removal. Current removal detection is achieved only by registration to device RMV event and the notification comes asynchronously. So, there i

[dpdk-dev] [PATCH v2 0/4] Fail-safe fix removal handling lack

2017-12-13 Thread Matan Azrad
There is time between the physical removal of the device until sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and applications still don't know about the removal and may call sub-device control operation which should return an error. This series adds new ethdev operation to check

Re: [dpdk-dev] [PATCH 4/4] examples/l3fwd-power: disable Lsc interrupts

2017-12-13 Thread Hunt, David
On 12/12/2017 10:08 AM, Nikhil Agarwal wrote: This application does not need Link Status Interrupt. It will cause failure for the platforms not supporting LSC. Signed-off-by: Nikhil Agarwal --- ---snip--- Acked-by: David Hunt

Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header

2017-12-13 Thread Akhil Goyal
Hi Jerin, On 12/13/2017 4:56 PM, Jerin Jacob wrote: -Original Message- Date: Wed, 13 Dec 2017 11:03:06 + From: "Doherty, Declan" To: Jerin Jacob , Abhinandan Gujjar CC: dev@dpdk.org, narender.vang...@intel.com, Nikhil Rao , Gage Eads , hemant.agra...@nxp.com, nidadavolu.mur..

Re: [dpdk-dev] [PATCH 3/4] examples/l3fwd-power: replace desc done with Rx queue count

2017-12-13 Thread Hunt, David
On 12/12/2017 10:08 AM, Nikhil Agarwal wrote: HW queue based platforms may not support descriptor done API. This patch changes the usages to rx_queue_count API, which is more generic. Signed-off-by: Nikhil Agarwal --- ---snip--- Acked-by: David Hunt

Re: [dpdk-dev] [PATCH 2/4] examples/l3fwd-power: fix the timer for any platform freq

2017-12-13 Thread Hunt, David
On 12/12/2017 10:08 AM, Nikhil Agarwal wrote: The code assumes that the platform frequency is 2GHz. This patch add support for dynamically detecting platform frequence. Fixes: d7937e2e3d12 ("power: initial import") Cc: sta...@dpdk.org Signed-off-by: Nikhil Agarwal --- ---snip--- Acked-by:

Re: [dpdk-dev] [PATCH 1/4] examples/l3fwd-power: fix non Rx intr supported platform

2017-12-13 Thread Hunt, David
On 12/12/2017 10:08 AM, Nikhil Agarwal wrote: This existing code cause the platform to start receiving packet immediately irrespective of interrupts available or not. If the platform does not support Rx interrupt, it shall not start receiving packets immediately. It shall let the timer management

Re: [dpdk-dev] [PATCH v2 12/18] eal: add generic device declaration parameter

2017-12-13 Thread Shreyansh Jain
On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: Add a new generic device declaration parameter: --dev= [...] diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 603df27..b7591fd 100644 --- a/lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH] net/mlx5: fix VLAN configuration after port stop

2017-12-13 Thread Shahaf Shuler
Ethdev layer has an API to configure vlan setting on the flight, i.e. when the port state is start. calling such API when the port is stopped may cause segmentation fault as the related Verbs contexts has not been created yet. Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue obje

[dpdk-dev] [PATCH 5/5] crypto/dpaa_sec: rewrite Rx/Tx path

2017-12-13 Thread Akhil Goyal
Rx and Tx patch are rewritten with improved internal APIs to improve performance. Signed-off-by: Akhil Goyal Signed-off-by: Nipun Gupta --- drivers/crypto/dpaa_sec/dpaa_sec.c | 260 ++--- drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +- 2 files changed, 153 insertion

[dpdk-dev] [PATCH 3/5] crypto/dpaa_sec: support ipsec protocol offload

2017-12-13 Thread Akhil Goyal
Signed-off-by: Akhil Goyal --- doc/guides/cryptodevs/features/dpaa_sec.ini | 1 + drivers/crypto/dpaa_sec/dpaa_sec.c | 409 ++-- drivers/crypto/dpaa_sec/dpaa_sec.h | 62 - 3 files changed, 449 insertions(+), 23 deletions(-) diff --git a/doc/guides

[dpdk-dev] [PATCH 4/5] bus/dpaa: support for enqueue frames of multiple queues

2017-12-13 Thread Akhil Goyal
Signed-off-by: Akhil Goyal Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c| 66 +++ drivers/bus/dpaa/include/fsl_qman.h | 14 +++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + 3 files changed, 81 insertions(+) diff --git a/driv

[dpdk-dev] [PATCH 2/5] crypto/dpaa_sec: support multiple sessions per qp

2017-12-13 Thread Akhil Goyal
From: Hemant Agrawal Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 154 + drivers/crypto/dpaa_sec/dpaa_sec.h | 74 +- 2 files changed, 145 insertions(+), 83 deletions(-) diff --git a/drivers/cr

[dpdk-dev] [PATCH 1/5] crypto/dpaa_sec: optimize virt to phy conversion

2017-12-13 Thread Akhil Goyal
From: Hemant Agrawal Context memory is allocated from mempool. Ideally it will get all memory from single segment, so simple offset calculation is used for address conversion for such addresses from context memory. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/dpaa_se

[dpdk-dev] [PATCH 0/5] crypto/dpaa_sec: performance optimizations

2017-12-13 Thread Akhil Goyal
Following changes are added to improve performance. 1. optimize virtual to physical address conversion 2. support for multiple sessions in a single queue pair 3. support for ipsec protocol offload 4. enqueue/dequeue code is rewritten to optimize the data path. Akhil Goyal (3): crypto/dpaa_sec: s

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-13 Thread Anoob Joseph
Hi Nelio, On 12/13/2017 06:23 PM, Nelio Laranjeiro wrote: Hi Anoob, On Wed, Dec 13, 2017 at 05:08:19PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/13/2017 03:32 PM, Nelio Laranjeiro wrote: Hi Anoob, On Wed, Dec 13, 2017 at 12:11:18PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/12/2017 08

Re: [dpdk-dev] [PATCH 7/7] doc: update eventdev documentation

2017-12-13 Thread Kovacevic, Marko
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Tuesday, December 12, 2017 7:27 PM > To: jerin.ja...@caviumnetworks.com; Richardson, Bruce > ; Van Haaren, Harry > ; Eads, Gage ; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; Ma, Liang J

Re: [dpdk-dev] [PATCH 0/6] next-build: create both static and shared libs

2017-12-13 Thread Bruce Richardson
On Wed, Dec 13, 2017 at 12:10:52PM +, Luca Boccassi wrote: > On Tue, 2017-12-12 at 17:14 +, Bruce Richardson wrote: > > On Tue, Dec 12, 2017 at 04:59:34PM +, Bruce Richardson wrote: > > > This patchset changes the meson+ninja build system to always create > > > both > > > static and sha

Re: [dpdk-dev] [PATCH v2 2/5] lpm: fix compilation on ARM BE

2017-12-13 Thread Bruce Richardson
On Wed, Dec 13, 2017 at 06:22:55PM +0530, Hemant Agrawal wrote: > Compiling on ARM BE using Linaro toolchain caused following > error/warnings. > > rte_lpm.c: In function ‘add_depth_big_v20’: > rte_lpm.c:911:4: error: braces around scalar initializer [-Werror] > { .group_idx = (uint8_t)tbl8_gr

[dpdk-dev] [PATCH] app/crypto-perf: support IMIX

2017-12-13 Thread Pablo de Lara
Add support for IMIX performance tests, where a distribution of various packet sizes can be submitted to a crypto device, testing a closer to a real world scenario. A sequence of packet sizes, selected randomly from a list of packet sizes (with "buffer-sz" parameter) with a list of the weights per

Re: [dpdk-dev] [PATCH] net/failsafe: add Rx interrupts

2017-12-13 Thread Mordechay Haimovsky
Thank you Stephen, Will gather more review inputs and send a fix. Moti > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, December 12, 2017 3:34 AM > To: Mordechay Haimovsky > Cc: gaetan.ri...@6wind.com; dev@dpdk.org > Subject: Re: [dpdk

[dpdk-dev] [PATCH v2 3/5] bus/dpaa: fix compilation on ARM BE

2017-12-13 Thread Hemant Agrawal
Fix the following compilation error when compiling with ARM BE compiler. drivers/bus/dpaa/include/fsl_qman.h:1997:25: error: statement with no effect [-Werror=unused-value] #define hw_sg_to_cpu(x) (x) Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines") Cc: sta...@dpdk.org Signed-off

[dpdk-dev] [PATCH v2 2/5] lpm: fix compilation on ARM BE

2017-12-13 Thread Hemant Agrawal
Compiling on ARM BE using Linaro toolchain caused following error/warnings. rte_lpm.c: In function ‘add_depth_big_v20’: rte_lpm.c:911:4: error: braces around scalar initializer [-Werror] { .group_idx = (uint8_t)tbl8_group_index, }, ^ rte_lpm.c:911:4: note: (near initialization for

[dpdk-dev] [PATCH v2 5/5] net/ixgbe: fix compilation on ARM BE

2017-12-13 Thread Hemant Agrawal
fixes the following compilation error on compiling with ARM BE compiler ixgbe_common.c: In function ‘ixgbe_host_interface_command’: ixgbe_common.c:4610:22: error: passing argument 1 of ‘__builtin_bswap32’ makes integer from pointer without a cast [-Werror=int-conversion] IXGBE_LE32_TO_CPUS(&buf

[dpdk-dev] [PATCH v2 4/5] net/i40e: fix compilation on ARM BE

2017-12-13 Thread Hemant Agrawal
This patch fixes the following error observed when compiling with ARM BE compiler. i40e_ethdev.c: In function ‘i40e_dev_tunnel_filter_set’: i40e_ethdev.c:6988:5: error: lvalue required as unary ‘&’ operand &rte_cpu_to_le_32(ipv4_addr), Fixes: edc845bd53ec ("app/testpmd: fix build on FreeBSD"

[dpdk-dev] [PATCH v2 1/5] pmdinfogen: fix cross compilation for ARM BE

2017-12-13 Thread Hemant Agrawal
Cross compiling DPDK for BE mode on ARM results into errors "PMDINFO portal/dpaa2_hw_dpio.o.pmd.c No drivers registered" The original code assumes the sh_size to be 32 bit, while it can be Elf32_Word or Elf64_Xword based on 32bit or 64 bit systems. This patches replaces the sh_size conversion rou

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-13 Thread Nelio Laranjeiro
Hi Anoob, On Wed, Dec 13, 2017 at 05:08:19PM +0530, Anoob Joseph wrote: > Hi Nelio, > > > On 12/13/2017 03:32 PM, Nelio Laranjeiro wrote: > > Hi Anoob, > > > > On Wed, Dec 13, 2017 at 12:11:18PM +0530, Anoob Joseph wrote: > > > Hi Nelio, > > > > > > > > > On 12/12/2017 08:08 PM, Nelio Laranje

Re: [dpdk-dev] [PATCH 1/3] ethdev: add max burst size to device info

2017-12-13 Thread Ananyev, Konstantin
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Tuesday, December 12, 2017 1:44 PM > To: Ananyev, Konstantin ; Matan Azrad > ; Nikhil Agarwal > > Cc: dev@dpdk.org; Hunt, David ; nikhil.agar...@nxp.com; > hemant.agra...@nxp.com; Yigit, Ferruh > > Sub

Re: [dpdk-dev] [PATCH v3 3/4] net/bond: dedicated hw queues for LACP control traffic

2017-12-13 Thread Kulasek, TomaszX
Hi, > -Original Message- > From: linhaifeng [mailto:haifeng@huawei.com] > Sent: Wednesday, December 13, 2017 09:16 > To: Doherty, Declan ; dev@dpdk.org > Cc: Kulasek, TomaszX > Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/bond: dedicated hw queues for LACP > control traffic > > Hi, >

Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header

2017-12-13 Thread Nithin Dabilpuram
Hi Jerin, Declan, On Wednesday 13 December 2017 04:56 PM, Jerin Jacob wrote: -Original Message- Date: Wed, 13 Dec 2017 11:03:06 + From: "Doherty, Declan" To: Jerin Jacob , Abhinandan Gujjar CC: dev@dpdk.org, narender.vang...@intel.com, Nikhil Rao , Gage Eads , hemant.agra...

Re: [dpdk-dev] check_port_config error

2017-12-13 Thread Bruce Richardson
On Tue, Dec 12, 2017 at 01:22:16AM -0500, Pragash Vijayaragavan wrote: > Hi, > > I am trying to run dpdk app l3fwd but gives some errors. > > I bind my nics using dpdk-dev-bind script. > > I also set env variables correctly. > > The nb_ports is 0 when i tried printing that inside "check_port_co

Re: [dpdk-dev] [PATCH 2/5] lpm: fix compilation on ARM BE

2017-12-13 Thread Hemant Agrawal
On 12/11/2017 6:11 PM, Bruce Richardson wrote: On Thu, Nov 02, 2017 at 03:38:52PM +0530, Hemant Agrawal wrote: Compiling on ARM BE using Linaro toolchain caused following error/warnings. rte_lpm.c: In function ‘add_depth_big_v20’: rte_lpm.c:911:4: error: braces around scalar initializer [-Werro

Re: [dpdk-dev] [PATCH 1/5] pmdinfogen: fix cross compilation for ARM BE

2017-12-13 Thread Neil Horman
On Wed, Dec 13, 2017 at 05:22:57PM +0530, Hemant Agrawal wrote: > Hi Neil/Bruce, > > On 12/12/2017 12:28 AM, Neil Horman wrote: > > On Mon, Dec 11, 2017 at 12:40:32PM +, Bruce Richardson wrote: > > > On Thu, Nov 02, 2017 at 03:38:51PM +0530, Hemant Agrawal wrote: > > > > cross compiling DPDK f

Re: [dpdk-dev] [PATCH 0/6] next-build: create both static and shared libs

2017-12-13 Thread Luca Boccassi
On Tue, 2017-12-12 at 17:14 +, Bruce Richardson wrote: > On Tue, Dec 12, 2017 at 04:59:34PM +, Bruce Richardson wrote: > > This patchset changes the meson+ninja build system to always create > > both > > static and shared libraries when doing a build. The applications > > compiled > > as pa

Re: [dpdk-dev] [PATCH 0/6] next-build: create both static and shared libs

2017-12-13 Thread Luca Boccassi
On Tue, 2017-12-12 at 16:59 +, Bruce Richardson wrote: > This patchset changes the meson+ninja build system to always create > both > static and shared libraries when doing a build. The applications > compiled > as part of a build use either the shared or static libraries > depending on > what

  1   2   >