Re: [dpdk-dev] [PATCH] net/mlx5: cleanup the allocation of the buffer used for the ethtool stats

2017-11-16 Thread Nelio Laranjeiro
+ sta...@dpdk.org On Thu, Nov 16, 2017 at 05:34:47PM +0100, Thierry Herbelot wrote: > Simplify the computation for the needed size: > - exact size for the structure header, > - exact size for a number of 64-bit counters. > > Fixes: a4193ae3bc4f ('net/mlx5: support extended statistics') > > Signe

[dpdk-dev] [PATCH] net/mlx5: remove parser/flow drop queue

2017-11-16 Thread Nelio Laranjeiro
This drop queue can be handled efficiently by using the drop flag in the context. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 128 ++- 1 file changed, 30 insertions(+), 98 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH] net/ixgbe: fix tunnel filter fail problem

2017-11-16 Thread Wei Zhao
Add a mode type check for tunnel mode, if fdir is in this mode, it do not need to do Sanity check for x550. Fixes: dc0c16105d2d2 ("ixgbe: fix X550 flow director check") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_fdir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-16 Thread Ferruh Yigit
On 11/16/2017 2:31 AM, Pavan Nikhilesh wrote: > Dynamic logs fail to print if the global log level is less than dynamic > loglevel. Example if the global log level is set to INFO and dynamic log > level for a specific module is set to DEBUG then the log fails to print. What is the purpose of the g

Re: [dpdk-dev] [PATCH 2/2] mbuf: reset nb_segs of chained packet

2017-11-16 Thread Ilya Matveychikov
> On Nov 16, 2017, at 9:01 PM, Stephen Hemminger > wrote: > > On Thu, 16 Nov 2017 18:05:35 +0400 > Ilya Matveychikov wrote: > >> Fixes: 139debc42dc0 ("mbuf: move chaining from ip_frag library") >> Cc: simon.kagst...@netinsight.net >> >> Signed-off-by: Ilya V. Matveychikov >> --- >> lib/libr

Re: [dpdk-dev] [PATCH] test: new sched WRR unit-test

2017-11-16 Thread Luca Boccassi
On Thu, 2017-11-16 at 17:18 +, alangordonde...@gmail.com wrote: > From: Alan Dewar > > New unit-test for the librte_sched WRR weighting code. > > With the standard 17.11 code, the first three sub-tests pass, but > the last two fail due to bugs in the WRR weighting code. > > With the "sched:

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Thomas Monjalon
16/11/2017 17:48, Wiles, Keith: > For now we can accept your patch for cmdline as it does add the support > without much effort. I agree.

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Thomas Monjalon
16/11/2017 18:27, Wiles, Keith: > > > On Nov 16, 2017, at 9:06 AM, Yigit, Ferruh wrote: > > > > On 11/16/2017 1:23 AM, Adrien Mazarguil wrote: > > <...> > > > >>> I do not agree it has severed DPDK well, just look at test-pmd and the > >>> hoops people have to jump thru to get a new command or

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Wiles, Keith
> On Nov 16, 2017, at 9:06 AM, Yigit, Ferruh wrote: > > On 11/16/2017 1:23 AM, Adrien Mazarguil wrote: > <...> > >>> I do not agree it has severed DPDK well, just look at test-pmd and the >>> hoops people have to jump thru to get a new command or variation of an >>> existing command integrat

[dpdk-dev] [PATCH] test: new sched WRR unit-test

2017-11-16 Thread alangordondewar
From: Alan Dewar New unit-test for the librte_sched WRR weighting code. With the standard 17.11 code, the first three sub-tests pass, but the last two fail due to bugs in the WRR weighting code. With the "sched: fix overflow errors in WRR weighting code" patch all five sub-tests pass. Signed-o

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Ferruh Yigit
On 11/16/2017 1:23 AM, Adrien Mazarguil wrote: <...> >> I do not agree it has severed DPDK well, just look at test-pmd and the hoops >> people have to jump thru to get a new command or variation of an existing >> command integrated into test-pmd it is very difficult. Also if you look at >> the

Re: [dpdk-dev] [PATCH 2/2] mbuf: reset nb_segs of chained packet

2017-11-16 Thread Stephen Hemminger
On Thu, 16 Nov 2017 18:05:35 +0400 Ilya Matveychikov wrote: > Fixes: 139debc42dc0 ("mbuf: move chaining from ip_frag library") > Cc: simon.kagst...@netinsight.net > > Signed-off-by: Ilya V. Matveychikov > --- > lib/librte_mbuf/rte_mbuf.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Wiles, Keith
> On Nov 16, 2017, at 1:23 AM, Adrien Mazarguil > wrote: > > Hi Keith, > > On Wed, Nov 15, 2017 at 04:12:07AM +, Wiles, Keith wrote: >> >> >>> On Nov 9, 2017, at 5:43 AM, Adrien Mazarguil >>> wrote: >>> >>> This patch removes all code associated with symbols not internally relied >>>

[dpdk-dev] [PATCH 2/2] mbuf: reset nb_segs of chained packet

2017-11-16 Thread Ilya Matveychikov
Fixes: 139debc42dc0 ("mbuf: move chaining from ip_frag library") Cc: simon.kagst...@netinsight.net Signed-off-by: Ilya V. Matveychikov --- lib/librte_mbuf/rte_mbuf.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h in

[dpdk-dev] [PATCH 1/2] mbuf: check sanity of data_len and pkt_len as well

2017-11-16 Thread Ilya Matveychikov
Signed-off-by: Ilya V. Matveychikov --- lib/librte_mbuf/rte_mbuf.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c index 7543662f7..491685c36 100644 --- a/lib/librte_mbuf/rte_mbuf.c +++ b/lib/libr

[dpdk-dev] [PATCH 0/2] Two more patches to mbuf

2017-11-16 Thread Ilya Matveychikov
Please, review two more patches to mbuf. Ilya V. Matveychikov (2): mbuf: check sanity of data_len and pkt_len as well mbuf: reset nb_segs of chained packet lib/librte_mbuf/rte_mbuf.c | 23 +++ lib/librte_mbuf/rte_mbuf.h | 5 - 2 files changed, 19 insertions(+), 9 del

Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-16 Thread Ananyev, Konstantin
Hi Olivier, > I agree with Konstantin's comment done in another thread [1]: > > ''' > That would cause extra read; cmp (and possible slowdown) for atomic refcnt. > If that really need to be fixed - probably we need to introduce a new > function > that would do update without trying to re

[dpdk-dev] [PATCH 1/2] eal: fix legacy dynamic logs defaulting to debug

2017-11-16 Thread Pavan Nikhilesh
Use RTE_LOG_LEVEL instead of RTE_LOG_DEBUG when registering dynamic logs for legacy modules. Fixes: c1b5fa94a46f ("eal: support dynamic log types") Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/common/eal_common_log.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-16 Thread Pavan Nikhilesh
Dynamic logs fail to print if the global log level is less than dynamic loglevel. Example if the global log level is set to INFO and dynamic log level for a specific module is set to DEBUG then the log fails to print. Check modules log level before checking the global log level. Fixes: c1b5fa94a4

Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-16 Thread Ilya Matveychikov
> On Nov 16, 2017, at 1:37 PM, Olivier MATZ wrote: > > On Thu, Nov 16, 2017 at 01:32:13PM +0400, Ilya Matveychikov wrote: >> >>> On Nov 16, 2017, at 1:06 PM, Hanoch Haim (hhaim) wrote: >>> >>> Understood >>> >>> rte_mbuf_refcnt_update_blind() >>> >>> should be good., it will take care the

Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-16 Thread Olivier MATZ
On Thu, Nov 16, 2017 at 01:32:13PM +0400, Ilya Matveychikov wrote: > > > On Nov 16, 2017, at 1:06 PM, Hanoch Haim (hhaim) wrote: > > > > Understood > > > > rte_mbuf_refcnt_update_blind() > > > > should be good., it will take care the RTE_MBUF_REFCNT_ATOMIC > > > > > Why guys not to add j

Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-16 Thread Ilya Matveychikov
> On Nov 16, 2017, at 1:06 PM, Hanoch Haim (hhaim) wrote: > > Understood > > rte_mbuf_refcnt_update_blind() > > should be good., it will take care the RTE_MBUF_REFCNT_ATOMIC > Why guys not to add just __rte_mbuf_refcnt_update() as a wrapper over rte_atomic16_add_return() and use it in in

Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

2017-11-16 Thread Adrien Mazarguil
Hi Keith, On Wed, Nov 15, 2017 at 04:12:07AM +, Wiles, Keith wrote: > > > > On Nov 9, 2017, at 5:43 AM, Adrien Mazarguil > > wrote: > > > > This patch removes all code associated with symbols not internally relied > > on by other DPDK components, makes struct cmdline opaque and then proce

Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-16 Thread Hanoch Haim (hhaim)
Understood rte_mbuf_refcnt_update_blind() should be good., it will take care the RTE_MBUF_REFCNT_ATOMIC Hanoh -Original Message- From: Olivier MATZ [mailto:olivier.m...@6wind.com] Sent: Thursday, November 16, 2017 10:42 AM To: Hanoch Haim (hhaim) Cc: Konstantin Ananyev; Ilya Matvey

Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-16 Thread Olivier MATZ
Hi Hanoh, On Thu, Nov 16, 2017 at 07:16:31AM +, Hanoch Haim (hhaim) wrote: > Hi Oliver, > > It's hard for me to follow this thread. Yes, here are some few tips to make it easier to follow: - avoid top-posting - prefix quoted lines with "> " - describe the problem and how you solve it in th

Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage

2017-11-16 Thread Ilya Matveychikov
> On Nov 16, 2017, at 11:16 AM, Hanoch Haim (hhaim) wrote: > > Hi Oliver, > > It's hard for me to follow this thread. > > 1) It is not about clear/not-clear, it is error prone to *replicate* code > that has the same logic. > > "I'm not convinced that: > >__rte_pktmbuf_reset_nb_segs(m

[dpdk-dev] [PATCH 53/53] net/sfc/base: move BIU test code into Siena-specific file

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_impl.h | 4 --- drivers/net/sfc/base/efx_nic.c | 72 --- drivers/net/sfc/base/siena_nic.c | 73 +++- 3 files c

[dpdk-dev] [PATCH 52/53] net/sfc/base: fix PreFAST static analysis warning (C6001)

2017-11-16 Thread Andrew Rybchenko
From: Andrew Lee Fix warning "C6001: Using uninitialized memory '*sensor_maskp'" which could occur when the npages argument to efx_mcdi_sensor_info() is less than or equal to zero. Fixes: dfb3b1ce15f6 ("net/sfc/base: import monitors access via MCDI") Cc: sta...@dpdk.org Signed-off-by: Andrew Le

[dpdk-dev] [PATCH 51/53] net/sfc/base: expand on comment on number of queues field

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender Expand on comment on RSS_CONTEXT_ALLOC_IN_NUM_QUEUES field. Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/sfc/base/ef10_rx.c b/drivers/net

[dpdk-dev] [PATCH 50/53] net/sfc/base: remove obsolete check for pre-Siena hardware

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender The fail4 label was used twice, so it doesn't need removing. Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_rx.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/sfc/base/efx_rx.c b/drivers/net/sfc/base/efx_rx.c in

[dpdk-dev] [PATCH 48/53] net/sfc/base: fix warnings from VS2015 C compiler (C4057)

2017-11-16 Thread Andrew Rybchenko
From: Andrew Lee Fix two level 4 warnings "C4057: 'function': 'const uint8_t *' differs in indirection to slightly different base types from 'caddr_t'"; no functional changes. Fixes: 354df7eadf66 ("net/sfc/base: import bootrom configuration") Cc: sta...@dpdk.org Signed-off-by: Andrew Lee Signe

[dpdk-dev] [PATCH 43/53] net/sfc/base: fix warnings from VS2015 C compiler (C4310)

2017-11-16 Thread Andrew Rybchenko
From: Andrew Lee Fix level 4 warning "C4310: cast truncates constant value"; no functional changes. Fixes: 354df7eadf66 ("net/sfc/base: import bootrom configuration") Cc: sta...@dpdk.org Signed-off-by: Andrew Lee Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_bootcfg.c | 2 +-

[dpdk-dev] [PATCH 44/53] net/sfc/base: fix warnings from VS2015 C compiler (C4244)

2017-11-16 Thread Andrew Rybchenko
From: Andrew Lee Fix level 4 warning "C4244: '+=': conversion from 'unsigned int' to 'uint16_t', possible loss of data"; no functional changes. Fixes: 946ba3b6941a ("net/sfc/base: import VPD support") Cc: sta...@dpdk.org Signed-off-by: Andrew Lee Signed-off-by: Andrew Rybchenko --- drivers/n

[dpdk-dev] [PATCH 49/53] net/sfc/base: fix warnings from VS2015 C compiler (C4214)

2017-11-16 Thread Andrew Rybchenko
From: Andrew Lee Fix multiple level 4 warnings "C4214: nonstandard extension used: bit field types other than int"; no functional changes. Fixes: f9565517ff4f ("net/sfc/base: import filters support") Fixes: 457beb2c4d3e ("net/sfc/base: support filters for encapsulated packets") Cc: sta...@dpdk.o

[dpdk-dev] [PATCH 39/53] net/sfc/base: cstyle fixes

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_filter.c | 8 +- drivers/net/sfc/base/ef10_impl.h | 36 +++ drivers/net/sfc/base/efx.h | 49 +- drivers/net/sfc/base/efx_impl.h| 3 +- drivers/net/sfc/ba

[dpdk-dev] [PATCH 46/53] net/sfc/base: fix warnings from VS2015 C compiler (C4100)

2017-11-16 Thread Andrew Rybchenko
From: Andrew Lee Fix multiple level 4 warnings "C4100: 'xxx': unreferenced formal parameter" no functional changes. The _NOTE(ARGUNUSED(xxx)) annotations are being exposed to the Visual Studio 2015 C compiler with the following: #define _NOTE_ARGUNUSED(...) UNREFERENCED_PARAMETER((__VA_ARGS

[dpdk-dev] [PATCH 47/53] net/sfc/base: fix warnings from VS2015 C compiler (C4189)

2017-11-16 Thread Andrew Rybchenko
From: Andrew Lee Fix multiple level 4 warnings "C4189: 'xxx': local variable is initialized but not referenced"; no functional changes. Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base") Fixes: dfb3b1ce15f6 ("net/sfc/base: import monitors access via MCDI") Fixes: e7cd430c864f ("net/sfc/bas

[dpdk-dev] [PATCH 29/53] net/sfc/base: request info about outer frame in Rx events

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender For encapsulated packets, the firmware gives info about the inner frame fields by default. When not using encapsulation offload, ask for info about the outer frame instead. Unless bug69842 is fixed, a driver reload will be needed, at least on some platforms, when switching fro

[dpdk-dev] [PATCH 45/53] net/sfc/base: fix warnings from VS2015 C compiler (C4245)

2017-11-16 Thread Andrew Rybchenko
From: Andrew Lee Fix level 4 warning "C4245: 'initializing': conversion from 'int' to 'uint32_t', signed/unsigned mismatch" warning; no functional changes. Fixes: f9565517ff4f ("net/sfc/base: import filters support") Fixes: daa007afd04b ("net/sfc/base: split local MAC I/G back into separate fla

[dpdk-dev] [PATCH 42/53] net/sfc/base: fix probes in licensing support

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender Fixes: 05fce2ce8451 ("net/sfc/base: import libefx licensing") Cc: sta...@dpdk.org Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_lic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/sfc/base/ef

[dpdk-dev] [PATCH 38/53] net/sfc/base: remove unused defined for WPTR alignment

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton MEDFORD_RX_WPTR_ALIGN is not used. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/medford_impl.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/net/sfc/base/medford_impl.h b/drivers/net/sfc/base/medford_impl.h index

[dpdk-dev] [PATCH 37/53] net/sfc/base: add support for new sensors

2017-11-16 Thread Andrew Rybchenko
From: Andrew Jackson Signed-off-by: Andrew Jackson Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/mcdi_mon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/sfc/base/mcdi_mon.c b/drivers/net/sfc/base/mcdi_mon.c index c5360c3..a083eac 100644 --- a/drivers/net/sfc/bas

[dpdk-dev] [PATCH 40/53] net/sfc/base: allow to use PHY stats on Huntington/Medford

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender EFSYS_OPT_PHY_STATS can be used with Huntington or Medford, not just Siena. Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_check.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/base/efx_chec

[dpdk-dev] [PATCH 33/53] net/sfc/base: improve names for TXQ descriptor counts

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h | 14 +++--- drivers/net/sfc/base/ef10_tx.c | 46 +- drivers/net/sfc/base/efx.h | 12 ++--- drivers/net/sfc/base/efx_tx.c| 102 +++-

[dpdk-dev] [PATCH 19/53] net/sfc/base: add description of the PS packets layout

2017-11-16 Thread Andrew Rybchenko
From: Andrew Rybchenko Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/sfc/base/ef10_rx.c b/drivers/net/sfc/base/ef10_rx.c index 53ea054..69ebc2d 100644 --- a/drivers/net/sfc/base/ef10_rx.c +++ b/driv

[dpdk-dev] [PATCH 16/53] net/sfc/base: add support for MUM/SUC firmware partitions

2017-11-16 Thread Andrew Rybchenko
From: Andrew Lee Signed-off-by: Andrew Lee Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_nvram.c | 1 + drivers/net/sfc/base/efx.h| 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/sfc/base/ef10_nvram.c b/drivers/net/sfc/base/ef10_nvram.c index 5d7a66f..

[dpdk-dev] [PATCH 41/53] net/sfc/base: fix diagnostics support build without Siena

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender The compilation failed because __efx_sram_pattern_fns was used in efx_nic.c, but defined in efx_sram.c which is only needed when supporting Siena. To fix it move all the code using __efx_sram_pattern_fns into Siena-specific files (except for the definition in efx_sram.c itself

[dpdk-dev] [PATCH 22/53] net/sfc/base: provide simple access to RxQ state in EvQ

2017-11-16 Thread Andrew Rybchenko
From: Andrew Rybchenko Packed stream Rx datapath requires access to packed stream state stored in event queue. Number of credits is upstead in event handler on a new buffer, packets parsing on 64k boundary crossing and Rx doorbell push to give credits back. Signed-off-by: Andrew Rybchenko ---

[dpdk-dev] [PATCH 23/53] net/sfc/base: enforce packed stream fake buffer size

2017-11-16 Thread Andrew Rybchenko
From: Andrew Rybchenko In the case of packed stream real size of the buffer does not fit in Rx descriptor byte count. Real size is specified on Rx queue setup. Non-zero fake should be used to bypass hardware checks. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 17 ++

[dpdk-dev] [PATCH 27/53] net/sfc/base: use MCDIv2 for requests with too long response

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender Use MCDIv2 for requests with a response size too long for MCDIv1. Required for MC_CMD_MAC_STATS to reports the stats without using DMA. Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_mcdi.c | 3 ++- 1 file changed, 2 insertions(+),

[dpdk-dev] [PATCH 30/53] net/sfc/base: remove assertion on no longer used define

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender MC_CMD_INIT_RXQ_OUT_LEN is not used any more. Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/sfc/base/ef10_rx.c b/drivers/net/sfc/base/ef10_rx.c index 5ede728..2

[dpdk-dev] [PATCH 35/53] net/sfc/base: move Siena-specific defs to right header

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx.h| 1 - drivers/net/sfc/base/efx_impl.h | 7 +-- drivers/net/sfc/base/siena_impl.h | 9 + 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH 34/53] net/sfc/base: fix build issue with PHY LED control enabled

2017-11-16 Thread Andrew Rybchenko
From: Vijay Srivastava Fixed build issue with the EFSYS_OPT_PHY_LED_CONTROL for Huntigton and Medford. Fixes: b1d06c75e32c ("net/sfc/base: import PHY LEDs control") Fixes: 0a7864349106 ("net/sfc/base: import PHY statistics") Cc: sta...@dpdk.org Signed-off-by: Vijay Srivastava Signed-off-by: An

[dpdk-dev] [PATCH 36/53] net/sfc/base: run mkconfig.py to add a new sensors

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx.h | 4 +++- drivers/net/sfc/base/efx_mon.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h index df15

[dpdk-dev] [PATCH 32/53] net/sfc/base: improve names for RXQ descriptor counts

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h | 16 +- drivers/net/sfc/base/ef10_rx.c | 33 +++-- drivers/net/sfc/base/efx.h | 16 +- drivers/net/sfc/base/efx_rx.c| 63

[dpdk-dev] [PATCH 31/53] net/sfc/base: improve names for EVQ descriptor counts

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_ev.c | 10 ++ drivers/net/sfc/base/ef10_impl.h | 2 +- drivers/net/sfc/base/efx.h | 2 +- drivers/net/sfc/base/efx_ev.c| 15 --- 4 files changed, 16 in

[dpdk-dev] [PATCH 28/53] net/sfc/base: ignore error in completion event on MCDIv2 HW

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender With MCDIv2, the reponse length can be to big to fit into the CMDDONE_DATALEN field in the MCDI completion event. But rather that the length being truncated, it can overflow into the CMDDONE_ERRNO field (this is a longstanding firmware bug). Hence the CMDDONE_ERRNO field may no

[dpdk-dev] [PATCH 24/53] net/sfc/base: more accurately calculate number of PS credits

2017-11-16 Thread Andrew Rybchenko
From: Andrew Rybchenko Maximum number of packets per 64k buffer should be rounded up when calculating number of credits by event queue size. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_ev.c | 2 +- drivers/net/sfc/base/efx.h | 3 +++ 2 files changed, 4 insertions(+), 1 de

[dpdk-dev] [PATCH 26/53] net/sfc/base: support inner checksum offload on transmit

2017-11-16 Thread Andrew Rybchenko
Inner checksum offloads may be used only if firmware supports these tunnels. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_tx.c | 27 +++ drivers/net/sfc/base/efx.h | 8 +--- drivers/net/sfc/base/efx_tx.c | 9 + 3 files changed, 37 inser

[dpdk-dev] [PATCH 25/53] net/sfc/base: make MAC naming consistent with other modules

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_mac.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/sfc/base/efx_mac.c b/drivers/net/sfc/base/efx_mac.c index 752e720..e33d54a 100644 --- a/d

[dpdk-dev] [PATCH 21/53] net/sfc/base: optimize credits overflow check

2017-11-16 Thread Andrew Rybchenko
From: Andrew Rybchenko Apply check against firmware maximum just before pushing. However, it does not save from overflow inside firmware, if firmware still have some credits. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_ev.c | 4 +--- drivers/net/sfc/base/ef10_rx.c | 18 +

[dpdk-dev] [PATCH 13/53] net/sfc/base: remove duplicate NVRAM asserts

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton The checking performed in the ->envo_type_to_partn internal method make these assertions unnecessary. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_nvram.c | 1 + drivers/net/sfc/base/efx_nvram.c | 27 -

[dpdk-dev] [PATCH 20/53] net/sfc/base: clarify meaning of Rx desc lbits in PS mode

2017-11-16 Thread Andrew Rybchenko
From: Andrew Rybchenko There is no point to add mask plus one before mask applying since it still does not help to avoid overflow on subtract. Modulo mask arithmetic works perfectly for unsigned integers of the same type. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_ev.c | 15

[dpdk-dev] [PATCH 14/53] net/sfc/base: quieten get version methods

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_nvram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/base/efx_nvram.c b/drivers/net/sfc/base/efx_nvram.c index 6bd7fc2..edf1d7d 100644 --- a/driver

[dpdk-dev] [PATCH 07/53] net/sfc/base: rename firmware update verify result cap field

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton The existing name confuses support for secure boot with support for reporting a verify result after an NVRAM update. As the capability only reports support for returning a verify result, change the name to be less confusing. Signed-off-by: Andy Moreton Signed-off-by: Andrew

[dpdk-dev] [PATCH 11/53] net/sfc/base: fix check in NVRAM validate

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Fixes: d96a34d165b1 ("net/sfc/base: import NVRAM support") Cc: sta...@dpdk.org Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_nvram.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/sfc/base/

[dpdk-dev] [PATCH 18/53] net/sfc/base: improve RxQ label init prototype

2017-11-16 Thread Andrew Rybchenko
From: Andrew Rybchenko RxQ type provides more information which may be useful to setup event queue appropriately. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_ev.c | 4 +++- drivers/net/sfc/base/ef10_impl.h | 2 +- drivers/net/sfc/base/ef10_rx.c | 2 +- 3 files changed, 5

[dpdk-dev] [PATCH 12/53] net/sfc/base: precheck and verify flash writes

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Read existing flash content before writing, so the flash write can be avoided if the existing partition content matches the new image. This avoids unnecessary write cycles for the flash device, and may also be faster. If the flash does need to be updated, verify the content aft

[dpdk-dev] [PATCH 06/53] net/sfc/base: extend NVRAM RW finish to return verify result

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Extend efx_nvram_rw_finish() to return firmware verify result code. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx.h | 3 ++- drivers/net/sfc/base/efx_bootcfg.c | 8 drivers/net/sfc/base/efx_nvram.c | 12 +++

[dpdk-dev] [PATCH 05/53] net/sfc/base: report verify result from RW finish callback

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton This makes the verify result visible to efx_nvram_rw_finish(), which can be extended to report it in a later patch. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h | 3 ++- drivers/net/sfc/base/ef10_nvram.c | 13 +++--

[dpdk-dev] [PATCH 15/53] net/sfc/base: fix PreFAST issues

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base") Cc: sta...@dpdk.org Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx.h | 12 ++-- drivers/net/sfc/base/efx_phy.c | 2 +- 2 files changed, 7 insertions(+), 7 deletio

[dpdk-dev] [PATCH 08/53] net/sfc/base: simplify NVRAM type to partition mappings

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_nvram.c | 110 +- 1 file changed, 37 insertions(+), 73 deletions(-) diff --git a/drivers/net/sfc/base/ef10_nvram.c b/drivers/net/sfc/base/ef10_nvra

[dpdk-dev] [PATCH 01/53] net/sfc/base: copy new header from firmwaresrc

2017-11-16 Thread Andrew Rybchenko
From: Andrew Jackson Signed-off-by: Andrew Jackson Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/siena_flash.h | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/sfc/base/siena_flash.h b/drivers/net/sfc/base/siena_flash.h index e2700554..5f

[dpdk-dev] [PATCH 10/53] net/sfc/base: report correct partition write chunk size

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton If the firmware reports a non-zero write chunk size then nvram writes may fail if a different granularity is used (e.g. for MUM firmware on Sorrento). Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_nvram.c | 17 ++--- 1

[dpdk-dev] [PATCH 17/53] net/sfc/base: improve PS credits push function name

2017-11-16 Thread Andrew Rybchenko
From: Andrew Rybchenko Make it clear from the name that it pushes doorbell. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h | 4 ++-- drivers/net/sfc/base/ef10_rx.c | 4 ++-- drivers/net/sfc/base/efx.h | 2 +- drivers/net/sfc/base/efx_impl.h | 2 +- drivers/ne

[dpdk-dev] [PATCH 09/53] net/sfc/base: check NVRAM locking by partition ID

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Tracking which partition is locked avoids being overly conservative when EFX_NVRAM_xxx maps to more than one partition (depnding on the current port number). Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_impl.h | 6 +- driver

[dpdk-dev] [PATCH 03/53] net/sfc/base: fix result code in MCDI NVRAM update finish

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Fixes: d96a34d165b1 ("net/sfc/base: import NVRAM support") Cc: sta...@dpdk.org Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_nvram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/base/efx_nvram

[dpdk-dev] [PATCH 02/53] net/sfc/base: do not use Tx desc push with TSO descriptors

2017-11-16 Thread Andrew Rybchenko
From: Mark Spender Pushing TSO option descriptors is unsafe if pacer bypass is enabled, so to make sure that doesn't happen never push TSO option descriptors. Signed-off-by: Mark Spender Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_tx.c | 56 --

[dpdk-dev] [PATCH 00/53] net/sfc: base driver update

2017-11-16 Thread Andrew Rybchenko
The series updates sfc base driver. There are a number of check patch warnings and errors because of coding style differencies. Andrew Jackson (2): net/sfc/base: copy new header from firmwaresrc net/sfc/base: add support for new sensors Andrew Lee (9): net/sfc/base: add support for MUM/SUC

[dpdk-dev] [PATCH 04/53] net/sfc/base: simplify verify result handling

2017-11-16 Thread Andrew Rybchenko
From: Andy Moreton Simplify verify result handling in NVRAM update finish Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_nvram.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/net/sfc/base/efx_nvr