Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director deletion

2017-11-13 Thread Thomas Monjalon
13/11/2017 17:56, Yongseok Koh: > > > On Nov 13, 2017, at 4:25 AM, Nelio Laranjeiro > > wrote: > > > > The speciation are wrongly computed causing the rule to not be match > > correctly for deletion. > > > > Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") > > > > Signed-off-by: Nelio

Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs types change

2017-11-13 Thread Thomas Monjalon
> > >> Update types of variables to correspond to nb_segs type change from > > >> uint8_t to uint16_t. > > >> > > >> Fixes: 97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments") > > >> Cc: olivier.m...@6wind.com > > >> > > >> Signed-off-by: Ilya V. Matveychikov > Acked-by: Olivier Matz I

Re: [dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet

2017-11-13 Thread Kumar, Ravi1
>15/09/2017 14:26, Kumar, Ravi1: > >> >1. As a non-written convention, we are adding following statement in >> >the top of such dual licensed files : " This file is provided under a >> >dual >> >BSD/GPLv2 license. When using or redistributing this file, you may do so >> >under either license.".

Re: [dpdk-dev] A question about (poor) rte_ethdev internal rx/tx callbacks design

2017-11-13 Thread Andrew Rybchenko
On 11/13/2017 10:33 PM, Ilya Matveychikov wrote: On Nov 13, 2017, at 9:15 PM, Adrien Mazarguil wrote: On Mon, Nov 13, 2017 at 02:56:23PM +0400, Ilya Matveychikov wrote: On Nov 13, 2017, at 2:39 PM, Adrien Mazarguil wrote: On Sat, Nov 11, 2017 at 09:18:45PM +0400, Ilya Matveychikov wrote:

Re: [dpdk-dev] [PATCH v2 01/25] ethdev: introduce generic flow API

2017-11-13 Thread Zhao1, Wei
Hi,Adrien > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Wednesday, November 1, 2017 1:46 AM > To: Zhao1, Wei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 01/25] ethdev: introduce generic flow API > > Hi Wei, > > Sorry for the late an

Re: [dpdk-dev] DPDK memory error check and offline bad pages

2017-11-13 Thread Tan, Jianfeng
On 11/14/2017 5:40 AM, Wiles, Keith wrote: On Nov 12, 2017, at 11:08 PM, Tan, Jianfeng wrote: Hi Jianjian, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jianjian Huo Sent: Wednesday, November 8, 2017 5:13 AM To: dev@dpdk.org Subject: [dpdk-dev] DPDK memor

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices

2017-11-13 Thread Stephen Hemminger
On Wed, 8 Nov 2017 07:00:23 -0500 Chas Williams <3ch...@gmail.com> wrote: > On Tue, Nov 7, 2017 at 5:26 PM, Ferruh Yigit wrote: > On 11/7/2017 12:47 PM, Chas Williams wrote: > > I will confess I haven't looked into the issue too hard since I have a > > workaround.  My first guess is that there is

Re: [dpdk-dev] [PATCH] testpmd: add nanosleep in main loop

2017-11-13 Thread Marcelo Tosatti
On Sun, Nov 12, 2017 at 11:14:35PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Marcelo Tosatti [mailto:mtosa...@redhat.com] > > Sent: Saturday, November 11, 2017 3:50 AM > > To: Ananyev, Konstantin > > Cc: Adrien Mazarguil ; dev@dpdk.org; Luiz > > Capitulino ;

Re: [dpdk-dev] DPDK memory error check and offline bad pages

2017-11-13 Thread Wiles, Keith
> On Nov 12, 2017, at 11:08 PM, Tan, Jianfeng wrote: > > Hi Jianjian, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jianjian Huo >> Sent: Wednesday, November 8, 2017 5:13 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] DPDK memory error check and offline

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage of incorrect port

2017-11-13 Thread Anoob Joseph
When security offload is enabled, the packet should be forwarded on the port configured in the SA. Security session will be configured on that port only, and sending the packet on other ports could result in unencrypted packets being sent out. This would have performance improvements too, as the p

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage of incorrect port

2017-11-13 Thread Anoob Joseph
Hi, Comments below On 13-11-2017 22:53, Radu Nicolau wrote: Hi, Comments below On 11/13/2017 4:13 PM, Anoob Joseph wrote: When security offload is enabled, the packet should be forwarded on the port configured in the SA. Security session will be configured on that port only, and sending the

Re: [dpdk-dev] A question about (poor) rte_ethdev internal rx/tx callbacks design

2017-11-13 Thread Ilya Matveychikov
> On Nov 13, 2017, at 9:15 PM, Adrien Mazarguil > wrote: > > On Mon, Nov 13, 2017 at 02:56:23PM +0400, Ilya Matveychikov wrote: >> >>> On Nov 13, 2017, at 2:39 PM, Adrien Mazarguil >>> wrote: >>> >>> On Sat, Nov 11, 2017 at 09:18:45PM +0400, Ilya Matveychikov wrote: Folks, A

Re: [dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet

2017-11-13 Thread Thomas Monjalon
15/09/2017 14:26, Kumar, Ravi1: > >1. As a non-written convention, we are adding following statement in the top > >of such dual licensed files : " This file is provided under a dual > >BSD/GPLv2 license. When using or redistributing this file, you may do so > >under either license.". And license

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage of incorrect port

2017-11-13 Thread Radu Nicolau
Hi, Comments below On 11/13/2017 4:13 PM, Anoob Joseph wrote: When security offload is enabled, the packet should be forwarded on the port configured in the SA. Security session will be configured on that port only, and sending the packet on other ports could result in unencrypted packets being

Re: [dpdk-dev] A question about (poor) rte_ethdev internal rx/tx callbacks design

2017-11-13 Thread Adrien Mazarguil
On Mon, Nov 13, 2017 at 02:56:23PM +0400, Ilya Matveychikov wrote: > > > On Nov 13, 2017, at 2:39 PM, Adrien Mazarguil > > wrote: > > > > On Sat, Nov 11, 2017 at 09:18:45PM +0400, Ilya Matveychikov wrote: > >> Folks, > >> > >> Are you serious with it: > >> > >> typedef uint16_t (*eth_rx_burst

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director deletion

2017-11-13 Thread Yongseok Koh
> On Nov 13, 2017, at 4:25 AM, Nelio Laranjeiro > wrote: > > The speciation are wrongly computed causing the rule to not be match > correctly for deletion. > > Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") > > Signed-off-by: Nelio Laranjeiro > --- There's a typo in the commit mess

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-11-13 Thread Tan, Jianfeng
Hi Sebastian, The title can be refined as: net/virtio-user: fix unchecked return value Other than the above comment, it seems good to me. On 11/13/2017 9:38 PM, SebastianX Basierski wrote: Report error message if clearing O_NONBLOCK flag will fail, then return from function. Coverity iss

[dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-11-13 Thread SebastianX Basierski
Report error message if clearing O_NONBLOCK flag will fail, then return from function. Coverity issue: 143439 Fixes: ef53b6030039 ("net/virtio-user: support LSC") Cc: jianfeng@intel.com Cc: y...@fridaylinux.org cc: dev@dpdk.org Signed-off-by: SebastianX Basierski --- drivers/net/virtio/vir

Re: [dpdk-dev] A question about (poor) rte_ethdev internal rx/tx callbacks design

2017-11-13 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil > Sent: Monday, November 13, 2017 10:39 AM > To: Ilya Matveychikov > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] A question about (poor) rte_ethdev internal rx/tx > callbacks design > > On Sat,

Re: [dpdk-dev] A question about (poor) rte_ethdev internal rx/tx callbacks design

2017-11-13 Thread Ilya Matveychikov
> On Nov 13, 2017, at 2:39 PM, Adrien Mazarguil > wrote: > > On Sat, Nov 11, 2017 at 09:18:45PM +0400, Ilya Matveychikov wrote: >> Folks, >> >> Are you serious with it: >> >> typedef uint16_t (*eth_rx_burst_t)(void *rxq, >> struct rte_mbuf **rx_pkts, >>

Re: [dpdk-dev] A question about (poor) rte_ethdev internal rx/tx callbacks design

2017-11-13 Thread Adrien Mazarguil
On Sat, Nov 11, 2017 at 09:18:45PM +0400, Ilya Matveychikov wrote: > Folks, > > Are you serious with it: > > typedef uint16_t (*eth_rx_burst_t)(void *rxq, > struct rte_mbuf **rx_pkts, > uint16_t nb_pkts); > typedef uint16_t (*eth_t

Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs types change

2017-11-13 Thread Olivier MATZ
On Mon, Nov 13, 2017 at 02:18:55PM +0400, Ilya Matveychikov wrote: > > > On Nov 13, 2017, at 2:10 PM, Olivier MATZ wrote: > > > > Hi Ilya, > > > > On Fri, Nov 10, 2017 at 04:56:43PM +0300, Ilya V. Matveychikov wrote: > >> Update types of variables to correspond to nb_segs type change from > >>

[dpdk-dev] [PATCH] net/mlx5: fix flow director deletion

2017-11-13 Thread Nelio Laranjeiro
The speciation are wrongly computed causing the rule to not be match correctly for deletion. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/n

Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs types change

2017-11-13 Thread Ilya Matveychikov
> But I didn’t try to fix it everywhere in drivers as it may depends of the > particular hardware - does it support more that uint8_t queues or not. So, I > agree with you that maintainers should have a look on that change. does it support more that uint8_t *segments*, not queues :-)

Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs types change

2017-11-13 Thread Ilya Matveychikov
> On Nov 13, 2017, at 2:10 PM, Olivier MATZ wrote: > > Hi Ilya, > > On Fri, Nov 10, 2017 at 04:56:43PM +0300, Ilya V. Matveychikov wrote: >> Update types of variables to correspond to nb_segs type change from >> uint8_t to uint16_t. >> >> Fixes: 97cb466d65c9 ("mbuf: use 2 bytes for port and nb

Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs types change

2017-11-13 Thread Olivier MATZ
Hi Ilya, On Fri, Nov 10, 2017 at 04:56:43PM +0300, Ilya V. Matveychikov wrote: > Update types of variables to correspond to nb_segs type change from > uint8_t to uint16_t. > > Fixes: 97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments") > Cc: olivier.m...@6wind.com > > Signed-off-by: Ilya

Re: [dpdk-dev] [RFC PATCH 0/4] testpmd: simulating noisy host environment

2017-11-13 Thread Victor Kaplansky
Hi, o testpmd is already the primary tool used by both DPDK developers, testers and for performance evaluations. Performances reports are available on dpdk.org for each DPDK releases, on various NICs, so it is a common baseline. o testpmd is being used not only for NIC testing, b

Re: [dpdk-dev] [PATCH v1] net/mlx4: store RSS hash result in mbufs

2017-11-13 Thread Adrien Mazarguil
On Sun, Nov 12, 2017 at 04:36:22PM +0200, Raslan Darawsheh wrote: > Add RSS hash result from CQE to mbuf, > Also, set PKT_RX_RSS_HASH in the ol_flags. > > Signed-off-by: Raslan Darawsheh Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND