[dpdk-dev] [PATCH] lib/librte_cryptodev: Fix a typo: rte_cyptodev_names -> rte_cryptodev_names

Signed-off-by: Pavel Shirshov --- lib/librte_cryptodev/rte_cryptodev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index dade554..5b6a254 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/li

[dpdk-dev] [PATCH] lib/librte_ether: Fix a typo

Signed-off-by: Pavel Shirshov --- lib/librte_ether/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 18e474d..341c2d6 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @

[dpdk-dev] [PATCH] lib/librte_distributor: Fix typos in comments

Signed-off-by: Pavel Shirshov --- lib/librte_distributor/rte_distributor.c | 4 ++-- lib/librte_distributor/rte_distributor.h | 2 +- lib/librte_distributor/rte_distributor_v20.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_distributor/rte_distributor.

[dpdk-dev] [PATCH] lib/librte_gro: Fix a typo in a documentation

Signed-off-by: Pavel Shirshov --- lib/librte_gro/gro_tcp4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_gro/gro_tcp4.h b/lib/librte_gro/gro_tcp4.h index f41dcee..0a81716 100644 --- a/lib/librte_gro/gro_tcp4.h +++ b/lib/librte_gro/gro_tcp4.h @@ -116,7 +116,7 @@ s

[dpdk-dev] [PATCH] lib/librte_ether: Fix a typo in a typedef

Signed-off-by: Pavel Shirshov --- lib/librte_ether/rte_tm_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_tm_driver.h b/lib/librte_ether/rte_tm_driver.h index b2e8ccf..2376943 100644 --- a/lib/librte_ether/rte_tm_driver.h +++ b/lib/librte_ether/rt

[dpdk-dev] [PATCH] lib/librte_gso: Fix a typo

Signed-off-by: Pavel Shirshov --- lib/librte_gso/rte_gso.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_gso/rte_gso.h b/lib/librte_gso/rte_gso.h index 4b77176..dbaedec 100644 --- a/lib/librte_gso/rte_gso.h +++ b/lib/librte_gso/rte_gso.h @@ -103,7 +103,7 @@ struct

[dpdk-dev] [PATCH] lib/librte_efd: Fix a typo

Signed-off-by: Pavel Shirshov --- lib/librte_efd/rte_efd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c index 8771d04..7d0b5cc 100644 --- a/lib/librte_efd/rte_efd.c +++ b/lib/librte_efd/rte_efd.c @@ -952,7 +952,7 @@ revert

Re: [dpdk-dev] ugb_uio: r3.8xlarge bind failure

It looks like igb_uio bind failed on servers running CentOS-6.x Servers with CentOS-7.3 Ubuntu-14, Ubuntu-16 and AWS-1703 (Amazon Linux) had no bind issues Regards, Gregory On Fri, Nov 10, 2017 at 3:42 AM, Ferruh Yigit wrote: > On 11/9/2017 9:20 AM, Gregory Etelson wrote: > > Hello, > > > > The

[dpdk-dev] [PATCH] testpmd: add nanosleep in main loop

This patch allows a configurable pair of values to be set, which controls the frequency and length of a nanosleep call performed at test-pmd's iofwd main loop. The problem is the following: it is necessary to execute code on isolated CPUs which is not part of the packet forwarding load. For exam

[dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

Add tested Intel platforms with Intel NICs to the release note. Signed-off-by: Yulong Pei --- doc/guides/rel_notes/release_17_11.rst | 71 ++ 1 file changed, 71 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_1

Re: [dpdk-dev] The virtio device mac is empty in vhostuser type.

Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of ? ? > Sent: Thursday, November 9, 2017 11:24 AM > To: dev > Cc: yuanhan.liu; Xie, Huawei > Subject: [dpdk-dev] The virtio device mac is empty in vhostuser type. > > Hi, > > When I attached a virtio device to

[dpdk-dev] [PATCH v6 3/3] ring: introduce new header file to support C11 memory model

To support C11 memory model barrier, 2 options are suggested by Jerin: 1. use rte_smp_rmb 2. use load_acquire/store_release(refer to [1]). CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "y" only on arm64 so far. The reason why providing 2 options is due to the performance benc

[dpdk-dev] [PATCH v5 2/3] ring: introduce new header file to include common functions

From: Jia He move the common part of rte_ring.h into rte_ring_generic.h move the memory barrier part into update_tail() no functional changes here Signed-off-by: Jia He Suggested-by: Jerin Jacob Suggested-by: Ananyev, Konstantin --- lib/librte_eventdev/rte_event_ring.h | 6 +- lib/librte_r

[dpdk-dev] [PATCH v5 1/3] eal/arm64: remove the braces {} for dmb() and dsb()

for the code as follows: if (condition) rte_smp_rmb(); else rte_smp_wmb(); Without this patch, compiler will report this error: error: 'else' without a previous 'if' Fixes: 84733fd0d75e ("eal/arm64: fix memory barrier definition") Signed-off-by: Jia He --- lib/librte_eal/common/i

[dpdk-dev] [PATCH v5 0/3] support c11 memory model barrier in librte_ring

From: Jia He To support C11 memory model barrier, 2 options are suggested by Jerin: 1. use rte_smp_rmb 2. use load_acquire/store_release CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "y" only on arm64 so far. The reason why providing 2 options is due to the performance benc

Re: [dpdk-dev] [PATCH] net/nfp: initialize stats struct

On Thu, 9 Nov 2017 17:10:16 -0800 Ferruh Yigit wrote: > On 11/8/2017 3:59 AM, Alejandro Lucero wrote: > > Not all struct fields will be written and random data could > > confuse readers. > > > > Fixes: 92aa491b881e ("nfp: add statistics") > > Coverity: 140755 > > Hi Alejandro, > > Thank you

[dpdk-dev] [PATCH v6] ring: guarantee load/load order in enqueue and dequeue

We watched a rte panic of mbuf_autotest in our qualcomm arm64 server (Amberwing). Root cause: In __rte_ring_move_cons_head() ... do { /* Restore n as it may change every loop */ n = max; *old_head = r->cons.head;//1st load

[dpdk-dev] [PATCH v6] guarantee load/load order in enqueue and dequeue

From: Jia He We watched a rte panic of mbuf_autotest in our qualcomm arm64 server (Amberwing) due to a possible race condition. To fix this race condition, rmb() is needed to add between the 2 loads. Already fuctionally tested on the machines as follows: - on X86 - on arm64 --- Changelog V6: i

Re: [dpdk-dev] [PATCH v5 1/1] ring: guarantee load/load order in enqueue and dequeue

The 11/10/2017 08:16, Jerin Jacob wrote: > -Original Message- > > Date: Fri, 10 Nov 2017 01:51:09 + > > From: Jia He > > To: jerin.ja...@caviumnetworks.com, dev@dpdk.org, olivier.m...@6wind.com > > Cc: konstantin.anan...@intel.com, bruce.richard...@intel.com, > > jianbo@arm.com, h

Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb()

The 11/10/2017 10:06, Jia He wrote: > > > On 11/9/2017 5:38 PM, Ananyev, Konstantin Wrote: > > > >>-Original Message- > >>From: Jianbo Liu [mailto:jianbo@arm.com] > >>Sent: Thursday, November 9, 2017 4:56 AM > >>To: Jia He > >>Cc: Richardson, Bruce ; > >>jerin.ja...@caviumnetworks.com

Re: [dpdk-dev] [PATCH v5 1/1] ring: guarantee load/load order in enqueue and dequeue

-Original Message- > Date: Fri, 10 Nov 2017 01:51:09 + > From: Jia He > To: jerin.ja...@caviumnetworks.com, dev@dpdk.org, olivier.m...@6wind.com > Cc: konstantin.anan...@intel.com, bruce.richard...@intel.com, > jianbo@arm.com, hemant.agra...@nxp.com, Jia He , > Jia He , jie2@

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix Rx packet type offloads

On 11/9/2017 1:18 AM, Adrien Mazarguil wrote: > On Thu, Nov 09, 2017 at 10:59:33AM +0200, Moti Haimovsky wrote: >> This patch improves Rx packet type offload report in case the device is >> a virtual function device. >> In these devices we observed that the L2 tunnel flag is set also for >> non-tun

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix VF cannot forward packets issue

On 11/9/2017 12:33 AM, Xing, Beilei wrote: >> -Original Message- >> From: Li, Xiaoyun >> Sent: Thursday, November 9, 2017 2:30 PM >> To: Wu, Jingjing ; Xing, Beilei >> >> Cc: dev@dpdk.org; Li, Xiaoyun ; sta...@dpdk.org >> Subject: [PATCH] net/i40e: fix VF cannot forward packets issue >> >

Re: [dpdk-dev] [PATCH] security: fix anonymous unions in structure definitions

On 11/9/2017 5:52 PM, Thomas Monjalon wrote: >>> Fixes: c261d1431bd8 ("security: introduce security API and framework") >>> >>> Signed-off-by: Akhil Goyal >> >> Acked-by: Pablo de Lara > > I'm surprised we have not hit this issue before. I think this only can be observed with gcc pedantic optio

Re: [dpdk-dev] [dpdk-stable] ugb_uio: r3.8xlarge bind failure

On 11/9/2017 5:42 PM, Ferruh Yigit wrote: > On 11/9/2017 9:20 AM, Gregory Etelson wrote: >> Hello, >> >> There are some AWS R3.8XLARGE instances >> that fail to bind Intel 10G VFs with igb_uio [c05cb4f939082]. > > Hi Gregory, > > Will you dig this issue more? Please keep us updated. > >> Syste

Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb()

On 11/9/2017 5:38 PM, Ananyev, Konstantin Wrote: -Original Message- From: Jianbo Liu [mailto:jianbo@arm.com] Sent: Thursday, November 9, 2017 4:56 AM To: Jia He Cc: Richardson, Bruce ; jerin.ja...@caviumnetworks.com; dev@dpdk.org; olivier.m...@6wind.com; Ananyev, Konstantin ; he

Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option

On 11/9/2017 5:53 PM, Mody, Rasesh wrote: > Hi Ferruh, > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Thursday, November 09, 2017 5:07 PM >> >> On 11/9/2017 3:16 PM, Patil, Harish wrote: >>> -Original Message- >>> From: Ferruh Yigit >>> Date: Thursday, November 9, 2017 a

Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option

Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, November 09, 2017 5:07 PM > > On 11/9/2017 3:16 PM, Patil, Harish wrote: > > -Original Message- > > From: Ferruh Yigit > > Date: Thursday, November 9, 2017 at 4:07 PM > > To: Harish Patil , "Mody, Rasesh" >

[dpdk-dev] [PATCH v5 0/1] fix race condition in enqueue/dequeue because of cpu reorder

We watched a rte panic of mbuf_autotest in our qualcomm arm64 server due to a possible race condition. To fix this race condition, rmb() is needed to add between the 2 loads. Already fuctionally tested on the machines as follows: - on X86 - on arm64 --- Changelog V5: split it into 2 patchset due

Re: [dpdk-dev] [PATCH] security: fix anonymous unions in structure definitions

> > Fixes: c261d1431bd8 ("security: introduce security API and framework") > > > > Signed-off-by: Akhil Goyal > > Acked-by: Pablo de Lara I'm surprised we have not hit this issue before. Applied, thanks

[dpdk-dev] [PATCH v5 1/1] ring: guarantee load/load order in enqueue and dequeue

We watched a rte panic of mbuf_autotest in our qualcomm arm64 server. In __rte_ring_move_cons_head() ... do { /* Restore n as it may change every loop */ n = max; *old_head = r->cons.head;//1st load const uint3

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1

> > On SUSE11 with gcc 4.5.1 the following build error occurred, most likely > > because of improper handling of annonymous unions: > > > > examples/ipsec-secgw/ipsec.c:87:4 error: > > unknown field ‘ipsec’ specified in initializer > > > > Fixes: ec17993a145a ("examples/ipsec-secgw: support s

Re: [dpdk-dev] ugb_uio: r3.8xlarge bind failure

On 11/9/2017 9:20 AM, Gregory Etelson wrote: > Hello, > > There are some AWS R3.8XLARGE instances > that fail to bind Intel 10G VFs with igb_uio [c05cb4f939082]. Hi Gregory, Will you dig this issue more? Please keep us updated. > System dmeg log show this backtrace: > > igb_uio: probe of 000

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices

On 11/8/2017 4:00 AM, Chas Williams wrote: > > > On Tue, Nov 7, 2017 at 5:26 PM, Ferruh Yigit > wrote: > > On 11/7/2017 12:47 PM, Chas Williams wrote: > > I will confess I haven't looked into the issue too hard since I have a > > workaround.  My first

Re: [dpdk-dev] vlan intertion offload does not take effect in 17.08

On 11/9/2017 2:27 AM, Chillance Zen wrote: > hi,all > I write this code when processing a packet try to utilize VLAN offload(the > nic does support that offlaod because I verify it in its dev_info) > > m->vlan_tci=222; > m->ol_flags=PKT_TX_VLAN_PKT; > > the packets out of that interface does not

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix link handling and configuration

On 11/9/2017 9:46 AM, Ajit Khaparde wrote: > Remove a case where we were sending a depricated field to the FW. > There is no need to send auto_link_speed to the FW. > Also set the auto_mode correctly depending on the setting requested. > > Fixes: 7bc8e9a227cc ("net/bnxt: support async link notific

Re: [dpdk-dev] [PATCH] net/nfp: initialize stats struct

On 11/8/2017 3:59 AM, Alejandro Lucero wrote: > Not all struct fields will be written and random data could > confuse readers. > > Fixes: 92aa491b881e ("nfp: add statistics") > Coverity: 140755 Hi Alejandro, Thank you for coverity fixes, but they will be considered for next release, since trying

Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option

On 11/9/2017 3:16 PM, Patil, Harish wrote: > -Original Message- > From: Ferruh Yigit > Date: Thursday, November 9, 2017 at 4:07 PM > To: Harish Patil , "Mody, Rasesh" > , "dev@dpdk.org" , > "thomas.monja...@6wind.com" > Cc: Dept-Eng DPDK Dev > Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede

Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs/port types change

On Thu, 9 Nov 2017 17:51:41 +0400 Ilya Matveychikov wrote: > Update types of variables to correspond to nb_segs type change from > uint8_t to uint16_t. Also, use 0x instead of 0xff to specify > invalid port value. > > Fixes: 97cb466d ("mbuf: use 2 bytes for port and nb segments") > Signed-of

Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option

-Original Message- From: Ferruh Yigit Date: Thursday, November 9, 2017 at 4:07 PM To: Harish Patil , "Mody, Rasesh" , "dev@dpdk.org" , "thomas.monja...@6wind.com" Cc: Dept-Eng DPDK Dev Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option >On 11/9/2017 3:00 PM, Patil,

Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option

On 11/9/2017 3:00 PM, Patil, Harish wrote: > -Original Message- > From: Harish Patil > Date: Thursday, November 9, 2017 at 3:57 PM > To: Ferruh Yigit , "Mody, Rasesh" > , "dev@dpdk.org" , > "thomas.monja...@6wind.com" > Cc: Dept-Eng DPDK Dev > Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede

Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option

-Original Message- From: Harish Patil Date: Thursday, November 9, 2017 at 3:57 PM To: Ferruh Yigit , "Mody, Rasesh" , "dev@dpdk.org" , "thomas.monja...@6wind.com" Cc: Dept-Eng DPDK Dev Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option >-Original Message- >F

Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option

-Original Message- From: Ferruh Yigit Date: Thursday, November 9, 2017 at 3:48 PM To: "Mody, Rasesh" , "dev@dpdk.org" , "thomas.monja...@6wind.com" Cc: Harish Patil , Dept-Eng DPDK Dev Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option >On 11/8/2017 10:52 PM, Rasesh

Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option

On 11/8/2017 10:52 PM, Rasesh Mody wrote: > From: Harish Patil > > Restore the default configuration as in previous releases and > add a debug msg. Is this reverting "f07aa795c92a ("net/qede: disable per-VF Tx switching feature")" This will be same as code before f07aa795c92a , right? If so why

Re: [dpdk-dev] [PATCH] net/mlx5: fix number of segment calculation

On Thu, Nov 09, 2017 at 06:04:32PM +0200, Ori Kam wrote: > The CRC size should be taken into consideration when computing > the number of mbuf segments for packet on the receive path. > Large packets can be dropped due to extra CRC length. > > Fixes: a1366b1a2be3 ("net/mlx5: add reference counter

Re: [dpdk-dev] [RFC PATCH 0/4] testpmd: simulating noisy host environment

31/10/2017 11:13, Bruce Richardson: > On Mon, Oct 30, 2017 at 02:41:05AM -0400, Victor Kaplansky wrote: > > > > This RFC patch propose enhancements to testpmd to simulate > > more realistic behavior of a guest machine engaged in receiving > > and sending packets performing Virtual Network Function

Re: [dpdk-dev] [PATCH] examples: fix for incomplete nb_segs type change

On 11/9/2017 5:55 AM, Ilya Matveychikov wrote: > Fixes: 97cb466d ("mbuf: use 2 bytes for port and nb segments") Fixline format we are using is slightly different, there is an alias to use: http://dpdk.org/doc/guides/contributing/patches.html git config alias.fixline "log -1 --abbrev=12 --format='

Re: [dpdk-dev] [PATCH] drivers/net: fix for incomplete nb_segs type change

On 11/9/2017 5:54 AM, Ilya Matveychikov wrote: > Fixes: 97cb466d ("mbuf: use 2 bytes for port and nb segments") > Signed-off-by: Ilya V. Matveychikov Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] pdump: fix possible mbuf leak

On 11/9/2017 5:49 AM, Ilya Matveychikov wrote: > If pdump_pktmbuf_copy_data() fails it's possible to have segment leak > as rte_pktmbuf_free() only handles m_dup chain but not the seg just > allocated and yet not chained. > > Fixes: 278f9454 ("pdump: add new library for packet capture") > Signed-o

[dpdk-dev] [PATCH] test/memory: fixing line parsing in memory autotest

This patch fixes three problems in memory autotest: - the regex for IOVA - missing validation of second and following output lines - propagation of error to consecutive tests - conversion base for mem size (hex indtead of dec) First fix is for changes introduced with IOVA, the regex was not upd

[dpdk-dev] [PATCH 2/2] net/bnxt: fix link handling and configuration

Remove a case where we were sending a depricated field to the FW. There is no need to send auto_link_speed to the FW. Also set the auto_mode correctly depending on the setting requested. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Signed-off-by: Ajit Khaparde --- drivers/n

[dpdk-dev] [PATCH 1/2] net/bnxt: fix duplicate creation of ntuple filter

Prevent the creation of duplicate 5tuple filters. Fixes: b7435d660a8c ("net/bnxt: add ntuple filtering support") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/net/

Re: [dpdk-dev] [PATCH 0/3] doc: documentation update for mlx4 PMD

On Thu, Nov 09, 2017 at 07:30:53PM +0200, Moti Haimovsky wrote: > The following three commits update the mlx4 documentation to reflect > the modifications done to the PMD and the new features added to it. > > Moti Haimovsky (3): > doc: fix remove mlx4 Tx inline compilation option > doc: fix ml

[dpdk-dev] [PATCH 3/3] doc: update mlx4 documentation

This updates mlx4 documentation and DPDK release notes to reflect the PMD support for rdma-core from linux-rdma. - PMD is now freed from Mellanox OFED and now only depends on the public rdma-core package (v15 and above) instead. (see https://github.com/linux-rdma/rdma-core/releases) This PMD

[dpdk-dev] [PATCH 2/3] doc: fix mlx4 drop inline receive support

This commit removes the stale MLX4_INLINE_RECV_SIZE environment variable from the documentation. Fixes: 056eaf2e6d55 ("net/mlx4: drop inline receive support") Signed-off-by: Moti Haimovsky --- doc/guides/nics/mlx4.rst | 20 1 file changed, 4 insertions(+), 16 deletions(-)

[dpdk-dev] [PATCH 1/3] doc: fix remove mlx4 Tx inline compilation option

This patch removes the stale CONFIG_RTE_LIBRTE_MLX4_MAX_INLINE compilation option from the documentation. Fixes: 586db080585b ("net/mlx4: remove Tx inline compilation option") Signed-off-by: Moti Haimovsky --- doc/guides/nics/mlx4.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/doc/

[dpdk-dev] [PATCH 0/3] doc: documentation update for mlx4 PMD

The following three commits update the mlx4 documentation to reflect the modifications done to the PMD and the new features added to it. Moti Haimovsky (3): doc: fix remove mlx4 Tx inline compilation option doc: fix mlx4 drop inline receive support doc: update mlx4 documentation doc/guides

[dpdk-dev] ugb_uio: r3.8xlarge bind failure

Hello, There are some AWS R3.8XLARGE instances that fail to bind Intel 10G VFs with igb_uio [c05cb4f939082]. System dmeg log show this backtrace: igb_uio: probe of :00:05.0 failed with error -16 IRQ handler type mismatch for IRQ 0 current handler: timer Pid: 3619, comm: bash Not tainted 2.6

[dpdk-dev] [PATCH] net/mlx5: fix number of segment calculation

The CRC size should be taken into consideration when computing the number of mbuf segments for packet on the receive path. Large packets can be dropped due to extra CRC length. Fixes: a1366b1a2be3 ("net/mlx5: add reference counter on DPDK Rx queues") Cc: sta...@dpdk.org Cc: nelio.laranje...@6wind.

Re: [dpdk-dev] [PATCH] security: fix anonymous unions in structure definitions

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, November 9, 2017 12:24 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; > hemant.agra...@nxp.com; Nicolau, Radu ; > tho...@monjalon.net; Akhil Goyal > Subject: [dpdk-dev] [PATCH] securi

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1

> -Original Message- > From: Nicolau, Radu > Sent: Thursday, November 9, 2017 9:57 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; Nicolau, Radu > > Subject: [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1 > > On SUSE11 with

Re: [dpdk-dev] [PATCH] net/mlx4: fix rxq interrupt memory corruption

On Thu, Nov 09, 2017 at 03:50:49PM +0200, Shahaf Shuler wrote: > intr_vec allocation size was wrong causing a memory corruption. > > Fixes: 0a2ae703192c ("net/mlx4: fix Rx interrupts management") > Cc: adrien.mazarg...@6wind.com > Cc: sta...@dpdk.org > > Signed-off-by: Shahaf Shuler Acked-by: A

[dpdk-dev] [PATCH] examples: fix for incomplete nb_segs type change

Fixes: 97cb466d ("mbuf: use 2 bytes for port and nb segments") Signed-off-by: Ilya V. Matveychikov --- doc/guides/sample_app_ug/ipv4_multicast.rst | 2 +- examples/ipv4_multicast/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/ip

[dpdk-dev] [PATCH] drivers/net: fix for incomplete nb_segs type change

Fixes: 97cb466d ("mbuf: use 2 bytes for port and nb segments") Signed-off-by: Ilya V. Matveychikov --- drivers/net/ark/ark_ethdev_rx.c | 2 +- drivers/net/i40e/i40e_rxtx.c| 9 +++-- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- drivers/net/qede/qede_rxtx.c| 4

[dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs/port types change

Update types of variables to correspond to nb_segs type change from uint8_t to uint16_t. Also, use 0x instead of 0xff to specify invalid port value. Fixes: 97cb466d ("mbuf: use 2 bytes for port and nb segments") Signed-off-by: Ilya V. Matveychikov --- lib/librte_mbuf/rte_mbuf.c | 6 +++---

[dpdk-dev] [PATCH] net/mlx4: fix rxq interrupt memory corruption

intr_vec allocation size was wrong causing a memory corruption. Fixes: 0a2ae703192c ("net/mlx4: fix Rx interrupts management") Cc: adrien.mazarg...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx4/mlx4_intr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH] pdump: fix possible mbuf leak

If pdump_pktmbuf_copy_data() fails it's possible to have segment leak as rte_pktmbuf_free() only handles m_dup chain but not the seg just allocated and yet not chained. Fixes: 278f9454 ("pdump: add new library for packet capture") Signed-off-by: Ilya V. Matveychikov --- lib/librte_pdump/rte_pdum

[dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit

This patch removes all code associated with symbols not internally relied on by other DPDK components, makes struct cmdline opaque and then proceeds to re-implement the remaining functionality as a wrapper to the editline library (also known as libedit) [1]. Besides adding a new external dependenc

Re: [dpdk-dev] [PATCH] net/mlx5: fix rxq interrupt memory corruption

On Thu, Nov 09, 2017 at 03:10:14PM +0200, Shahaf Shuler wrote: > intr_vec allocation size was wrong causing a memory corruption. > > Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") > Cc: adrien.mazarg...@6wind.com > Cc: sta...@dpdk.org > > Signed-off-by: Shahaf Shuler Indeed, nic

[dpdk-dev] [PATCH] net/mlx5: fix rxq interrupt memory corruption

intr_vec allocation size was wrong causing a memory corruption. Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") Cc: adrien.mazarg...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[dpdk-dev] [PATCH] net/mlx5: fix flow director rules comparison

When deleting/replacing a flow director rule the first rule of the list was always the one replaced instead of the corresponding one. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 5 - 1 file changed, 4 insertions(

[dpdk-dev] [PATCH v3] doc: added inline crypto feature

Signed-off-by: Radu Nicolau --- v2: removed useless anchor and updated ixgbe doc v3: removed trailing whitespaces and added line break doc/guides/nics/features.rst | 15 +++ doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/ixgbe.ini| 2

[dpdk-dev] [PATCH v2] doc: added inline crypto feature

Signed-off-by: Radu Nicolau --- v2: removed useless anchor and updated ixgbe doc doc/guides/nics/features.rst | 15 +++ doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/ixgbe.ini| 2 ++ doc/guides/nics/features/ixgbe_vec.ini| 2 ++

[dpdk-dev] [PATCH] security: fix anonymous unions in structure definitions

Fixes: c261d1431bd8 ("security: introduce security API and framework") Signed-off-by: Akhil Goyal --- lib/librte_security/rte_security.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h index 7e687d2..653929b 100644 -

[dpdk-dev] vlan intertion offload does not take effect in 17.08

hi,all I write this code when processing a packet try to utilize VLAN offload(the nic does support that offlaod because I verify it in its dev_info) m->vlan_tci=222; m->ol_flags=PKT_TX_VLAN_PKT; the packets out of that interface does not contain any vlan tag. does anybody know what's happening o

[dpdk-dev] Why I can't get max line speed using ovs-dpdk and vhost-user port?

Hi all, I'm using ovs-dpdk with vhost-user port and 10 VM started by qemu, topology is: VM1 ~ VM10 | | -OVS | dpdk-bond the start command of ovs-dpdk is: root 8969 200 0.1 107748696 231284 ?S ovs-vswitchd --dpdk -c 0x40004 -n 4 --socket-mem 10240 --proc

Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb()

> -Original Message- > From: Jianbo Liu [mailto:jianbo@arm.com] > Sent: Thursday, November 9, 2017 9:58 AM > To: Ananyev, Konstantin > Cc: Jia He ; Richardson, Bruce > ; jerin.ja...@caviumnetworks.com; dev@dpdk.org; > olivier.m...@6wind.com; hemant.agra...@nxp.com; jia...@hxt-semite

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1

On SUSE11 with gcc 4.5.1 the following build error occurred, most likely because of improper handling of annonymous unions: examples/ipsec-secgw/ipsec.c:87:4 error: unknown field ‘ipsec’ specified in initializer Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Signe

Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb()

The 11/09/2017 09:38, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Jianbo Liu [mailto:jianbo@arm.com] > > Sent: Thursday, November 9, 2017 4:56 AM > > To: Jia He > > Cc: Richardson, Bruce ; > > jerin.ja...@caviumnetworks.com; dev@dpdk.org; olivier.m...@6wind.com; >

Re: [dpdk-dev] Huge mapping secondary process linux

"Chao Zhu" wrote on 11/09/2017 04:08:36 AM: > From: "Chao Zhu" > To: "'Jonas Pfefferle1'" > Cc: "'Burakov, Anatoly'" , > , > Date: 11/09/2017 04:08 AM > Subject: RE: [dpdk-dev] Huge mapping secondary process linux > > > > From: Jonas Pfefferle1 [mailto:j...@zurich.ibm.com] > Sent: 2017年11月7日 1

Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb()

> -Original Message- > From: Jianbo Liu [mailto:jianbo@arm.com] > Sent: Thursday, November 9, 2017 4:56 AM > To: Jia He > Cc: Richardson, Bruce ; > jerin.ja...@caviumnetworks.com; dev@dpdk.org; olivier.m...@6wind.com; > Ananyev, Konstantin ; hemant.agra...@nxp.com; > jia...@hxt-sem

[dpdk-dev] [PATCH v6] net/virtio: fix rxq intr config fails using vfio-pci

When running l3fwd-power to test virtio rxq interrupt using vfio pci noiommu mode, startup fails. In the function virtio_read_caps, the code if (flags & PCI_MSIX_ENABLE) intends to double check if vfio msix is enabled or not. However, it is not enable at that time. So use_msix is assigned to "0", n

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix Rx packet type offloads

On Thu, Nov 09, 2017 at 10:59:33AM +0200, Moti Haimovsky wrote: > This patch improves Rx packet type offload report in case the device is > a virtual function device. > In these devices we observed that the L2 tunnel flag is set also for > non-tunneled packets, this leads to a complete misinterpret

Re: [dpdk-dev] [PATCH v5] net/virtio: fix rxq intr config fails using vfio-pci

> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, November 9, 2017 5:09 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: sta...@dpdk.org; Tan, Jianfeng ; > y...@fridaylinux.org > Subject: Re: [PATCH v5] net/virtio: fix rxq intr config fails usin

Re: [dpdk-dev] [PATCH v5] net/virtio: fix rxq intr config fails using vfio-pci

On 11/09/2017 09:55 AM, Zhiyong Yang wrote: diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h index 36d452c06..28e9af6c7 100644 --- a/drivers/net/virtio/virtio_pci.h +++ b/drivers/net/virtio/virtio_pci.h @@ -314,6 +314,12 @@ struct virtio_net_config { /* The align

[dpdk-dev] [PATCH v5] net/virtio: fix rxq intr config fails using vfio-pci

When running l3fwd-power to test virtio rxq interrupt using vfio pci noiommu mode, startup fails. In the function virtio_read_caps, the code if (flags & PCI_MSIX_ENABLE) intends to double check if vfio msix is enabled or not. However, it is not enable at that time. So use_msix is assigned to "0", n

[dpdk-dev] [PATCH v3] net/mlx4: fix Rx packet type offloads

This patch improves Rx packet type offload report in case the device is a virtual function device. In these devices we observed that the L2 tunnel flag is set also for non-tunneled packets, this leads to a complete misinterpretation of the packet type being received. This issue occurs since the tun

Re: [dpdk-dev] [PATCH] net/i40e: fix VF cannot forward packets issue

> -Original Message- > From: Li, Xiaoyun > Sent: Thursday, November 9, 2017 2:30 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Li, Xiaoyun ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix VF cannot forward packets issue > > When Rx interrupt is not enabled, there is no need t

Re: [dpdk-dev] [PATCH v4] net/virtio: fix rxq intr config fails using vfio-pci

On 11/09/2017 05:46 AM, Zhiyong Yang wrote: When running l3fwd-power to test virtio rxq interrupt using vfio pci noiommu mode, startup fails. In the function virtio_read_caps, the code if (flags & PCI_MSIX_ENABLE) intends to double check if vfio msix is enabled or not. However, it is not enable