Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix parsing flags of multi-packet send

2017-10-20 Thread Ferruh Yigit
On 10/16/2017 10:41 AM, Yongseok Koh wrote: > Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") > Cc: sta...@dpdk.org > > Signed-off-by: Yongseok Koh > Acked-by: Nelio Laranjeiro Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2] doc: update release notes for mlx5 driver

2017-10-20 Thread Ferruh Yigit
On 10/16/2017 12:09 PM, Mcnamara, John wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler >> Sent: Monday, October 16, 2017 2:32 PM >> To: tho...@monjalon.net; Yigit, Ferruh >> Cc: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v2] doc: upd

Re: [dpdk-dev] [PATCH] net/mlx5: fix ICC compiler warning

2017-10-20 Thread Ferruh Yigit
On 10/16/2017 7:46 PM, Xueming Li wrote: > Initialize variable to avoid ICC compiler warning: > http://www.dpdk.org/ml/archives/dev/2017-October/077971.html Hi Xueming, Nelio, I disabled that warning for ICC in Makefile [1], as mentioned in above mail. If you prefer to fix it instead of disable,

Re: [dpdk-dev] [PATCH] app/testpmd: remove useless funciton declarations

2017-10-20 Thread Ferruh Yigit
On 10/15/2017 7:30 PM, Zhiyong Yang wrote: > The four function declarations have no funciton implementation, > remove them. Fixes: 0db70a803028 ("app/testpmd: add commands for filters") Cc: sta...@dpdk.org > Signed-off-by: Zhiyong Yang Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 2/2] examples/kni: stop lcores while doing kni ops

2017-10-20 Thread Ferruh Yigit
On 10/16/2017 4:45 AM, Tomasz Duszynski wrote: > Since the transmit and receive functions should not be invoked when > the device is stopped, stop lcores during kni ops and restart them > after device is started once again. Hi Tomasz, Are you observing any error or unexpected behavior because of

Re: [dpdk-dev] [PATCH 1/2] examples/kni: check if pci_dev isn't NULL before using it

2017-10-20 Thread Ferruh Yigit
On 10/16/2017 4:45 AM, Tomasz Duszynski wrote: > Since virtual devices, i.e mrvl net pmd, do not touch pci_dev > dereferencing it will cause segmentation fault as by default > it's set to NULL in rte_eth_dev_info_get(). > > Signed-off-by: Tomasz Duszynski Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH] app/testpmd: refine xstats show

2017-10-20 Thread Elza Mathew
When using "show port xstats all" command to show xstats, the output is usually too long to obtain what you really want, especially when multi-queue is enabled. Added an option to set whether zero values should be displayed or not for xstats. The "set xstats-hide-zero on|off" command enables the u

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-10-20 Thread Patil, Harish
-Original Message- From: Ferruh Yigit Date: Friday, October 20, 2017 at 9:57 AM To: Jingjing Wu , "Thotton, Shijith" , Gregory Etelson , Harish Patil Cc: Thomas Monjalon , "dev@dpdk.org" , "sta...@dpdk.org" , Jianfeng Tan , George Prekas , Sergio Gonzalez Monroy Subject: Re: [PATCH] igb_

[dpdk-dev] [PATCH 3/3] cryptodev: break dependency on rte_pci.h

2017-10-20 Thread Declan Doherty
Removes any dependency of librte_cryptodev on the PCI device infrastructure code and removes the functions which were virtual device specific. Updates QAT crypto PMD to remove dependencies on rte_cryptodev_pci.h and replaces those calls with the new bus independent functions. Signed-off-by: Decla

[dpdk-dev] [PATCH 0/3] Break dependency on bus infrastructure*

2017-10-20 Thread Declan Doherty
This patch set breaks the dependency of the cryptodev library on both the virtual and PCI device infrastructure. It introduces new bus independent crypto PMD driver assist functions for parsing initialisation parameters, and creation/destruction of device instances. It deprecates all function c

[dpdk-dev] [PATCH 1/3] cryptodev: add new APIs to assist PMD initialisation

2017-10-20 Thread Declan Doherty
Adds new PMD assist functions which are bus independent for driver to create and destroy new device instances. Also includes function to parse parameters which can be passed to driver on device initialisation. Signed-off-by: Declan Doherty --- lib/librte_cryptodev/rte_cryptodev.h |

[dpdk-dev] [PATCH 2/3] cryptodev: break dependency on virtual device bus

2017-10-20 Thread Declan Doherty
Removes any dependency of librte_cryptodev on the virtual device infrastructure code and removes the functions which were virtual device specific. Updates all virtual PMDs to remove dependencies on rte_cryptodev_vdev.h and replaces those calls with the new bus independent functions. Signed-off-by

Re: [dpdk-dev] [PATCH v4 0/3] Octeontx doc misc

2017-10-20 Thread Thomas Monjalon
20/10/2017 18:07, Mcnamara, John: > From: Santosh Shukla [mailto:santosh.shu...@caviumnetworks.com] > > Patch 1: Introduce platform/ entry in guide. That has information about > > platform drivers. ( As per discussion[1]) Patch 2: Introduce mempool/ > > entry in guide. (Refer discussion[1]) Patch 3

Re: [dpdk-dev] [PATCH] pci: fix check uio bind

2017-10-20 Thread Gaëtan Rivet
On Sat, Oct 21, 2017 at 12:47:14AM +0800, Tan, Jianfeng wrote: > Hi Gaëtan, > > > On 10/19/2017 7:42 PM, Gaëtan Rivet wrote: > >Hi Jianfeng, > > > >On Thu, Oct 19, 2017 at 11:18:29AM +, Jianfeng Tan wrote: > >>When checking if any devices bound to uio, we did not exclud > >>those which are bl

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix RSS structure initialisation

2017-10-20 Thread Ferruh Yigit
On 10/13/2017 5:09 AM, Nelio Laranjeiro wrote: > Struct rss_conf.rss_key_len is not initialised forcing the user to verify > the rss_conf.rss_key pointer to know if the key is present or not. > rss_conf.rss_key_len should have a valid length according to the size of > the rss_key pointed. > > Fixe

Re: [dpdk-dev] [PATCH 3/3] net/bnxt: update HWRM API to 1.8.2

2017-10-20 Thread Ferruh Yigit
On 10/12/2017 10:35 AM, Ajit Khaparde wrote: > This patch updates the HWRM APi to version 1.8.2 > This patch is based on an autogenerated file. > Almost all the changes in the PMD are macro name changes. > > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt.h| 2 - >

Re: [dpdk-dev] [PATCH 3/3] net/bnxt: update HWRM API to 1.8.2

2017-10-20 Thread Ferruh Yigit
Hi Ajit, On 10/12/2017 10:35 AM, Ajit Khaparde wrote: > @@ -1,174 +1,51 @@ > -/*- > - * BSD LICENSE > +/ > + * Copyright(c) 2001-2017 Broadcom Corporation, all rights reserved > + * Proprietary and Confidential Informati

Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event queue config

2017-10-20 Thread Pavan Nikhilesh Bhagavatula
On Fri, Oct 20, 2017 at 04:38:57PM +, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Friday, October 20, 2017 11:31 AM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsis

Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB packets

2017-10-20 Thread Ferruh Yigit
On 10/12/2017 10:24 AM, Roger B Melton wrote: > When copying VLAN tags from the RX descriptor to the vlan_tci field > in the mbuf header, igb_rxtx.c:eth_igb_recv_pkts() and > eth_igb_recv_scattered_pkts() both assume that the VLAN tag is always > little endian. While i350, i354 and /i350vf VLAN n

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-10-20 Thread Gregory Etelson
On Friday, 20 October 2017 19:57:38 IDT Ferruh Yigit wrote: > On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > > Remove device reset during application start, the reset for application > > exit still there. > > > > Reset in open removed because of following comments: > > 1- Device reset not completed

Re: [dpdk-dev] Requirement of minimum Rx burst size for PMDs

2017-10-20 Thread Yongseok Koh
On Fri, Oct 20, 2017 at 03:23:10PM +0300, Andrew Rybchenko wrote: > On 10/20/2017 02:58 PM, Bruce Richardson wrote: > > On Fri, Oct 20, 2017 at 01:07:17PM +0300, Andrew Rybchenko wrote: > > > On 10/20/2017 04:18 AM, Yongseok Koh wrote: > > > > Therefore, how about adding min_rx/tx_burst_sz in struc

Re: [dpdk-dev] [PATCH v8 1/4] librte_flow_classify: add flow classify library

2017-10-20 Thread Iremonger, Bernard
Hi Jasvinder, Thanks for the review. > -Original Message- > From: Singh, Jasvinder > Sent: Thursday, October 19, 2017 3:22 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Yigit, Ferruh ; Ananyev, Konstantin > ; Dumitrescu, Cristian > ; adrien.mazarg...@6wind.com > Subject: RE: [PATCH v8 1/4

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-10-20 Thread Ferruh Yigit
On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > Remove device reset during application start, the reset for application > exit still there. > > Reset in open removed because of following comments: > 1- Device reset not completed when VF driver loaded, which cause VF PMD >initialization error. >

[dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-10-20 Thread Ferruh Yigit
Remove device reset during application start, the reset for application exit still there. Reset in open removed because of following comments: 1- Device reset not completed when VF driver loaded, which cause VF PMD initialization error. Adding delay can solve the issue but will increase driv

Re: [dpdk-dev] [PATCH] pci: fix check uio bind

2017-10-20 Thread Tan, Jianfeng
Hi Gaëtan, On 10/19/2017 7:42 PM, Gaëtan Rivet wrote: Hi Jianfeng, On Thu, Oct 19, 2017 at 11:18:29AM +, Jianfeng Tan wrote: When checking if any devices bound to uio, we did not exclud those which are blacklisted (or in the case that a whitelist is specified). This patch fixes it by onl

Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event queue config

2017-10-20 Thread Van Haaren, Harry
> From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@caviumnetworks.com] > Sent: Friday, October 20, 2017 11:31 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event > queue config > > On Fri, Oct 20, 2017 at 09:54:36AM +,

Re: [dpdk-dev] [PATCH v2 6/6] examples/ipsec-secgw: config ethernet MACs dynamically

2017-10-20 Thread Nicolau, Radu
Hi, I think this should be a separate patch, not bundled with a series of fixes. The guide has to be updated as well. And probably it's best to make the MAC configuration optional, keep a default hardcoded table. Regards, Radu > -Original Message- > From: avia...@dev.mellanox.co.il [mai

Re: [dpdk-dev] [PATCH 2/2] doc: add flow_filtering example documentation

2017-10-20 Thread Mcnamara, John
> -Original Message- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Thursday, October 19, 2017 11:16 AM > To: adrien.mazarg...@6wind.com; Mcnamara, John ; > tho...@monjalon.net > Cc: dev@dpdk.org; or...@mellanox.com > Subject: [PATCH 2/2] doc: add flow_filtering example documentation

Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-20 Thread Ferruh Yigit
On 10/20/2017 8:26 AM, Tan, Jianfeng wrote: > Hi Ferruh & Harish, > > > On 10/20/2017 9:15 AM, Ferruh Yigit wrote: >> On 10/19/2017 3:43 PM, Patil, Harish wrote: >>> -Original Message- >>> From: Harish Patil >>> Date: Tuesday, October 17, 2017 at 9:50 PM >>> To: Thomas Monjalon , Ferruh

Re: [dpdk-dev] [PATCH] doc: group classification libraries in doxygen index

2017-10-20 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, October 20, 2017 11:48 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: group classification libraries in doxygen > index > > The libraries reorder, distributor, EFD, ACL a

Re: [dpdk-dev] [PATCH v4 0/3] Octeontx doc misc

2017-10-20 Thread Mcnamara, John
> -Original Message- > From: Santosh Shukla [mailto:santosh.shu...@caviumnetworks.com] > Sent: Friday, October 20, 2017 4:21 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; jerin.ja...@caviumnetworks.com; Mcnamara, John > ; Santosh Shukla > > Subject: [PATCH v4 0/3] Octeontx doc misc >

Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec_secgw: switched to new offload API

2017-10-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Friday, October 20, 2017 10:30 AM > To: dev@dpdk.org > Cc: Gonzalez Monroy, Sergio ; De Lara > Guarch, Pablo ; > avia...@dev.mellanox.co.il; Nicolau, Radu > Subject: [PATCH v4 1/2] examples/ipsec_secgw: switched to new offload > API > >

[dpdk-dev] [PATCH] net/bonding: fix check slaves link properties

2017-10-20 Thread Tomasz Kulasek
Result of slaves link properties validation is not used when new slave is added. This patch uses the value of link_properties_valid() to determinate if slave can be used in the bonding. If function fails, error is returned preventing to add slave with invalid link properties. Coverity issue: 1586

[dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from gpool2handle

2017-10-20 Thread Santosh Shukla
Coverity Issue: 195000 Fixes: 02fd6c744350 ("mempool/octeontx: support allocation") Signed-off-by: Santosh Shukla --- drivers/mempool/octeontx/octeontx_fpavf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpa

Re: [dpdk-dev] [PATCH v2 5/6] examples/ipsec-secgw: iv should be be64

2017-10-20 Thread Radu Nicolau
On 10/19/2017 7:53 PM, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel According to rfc4106 the IV should be unique and can be implemented as counter. The changed was created because putting an analyzer on wire and comparing packets generated by this application and Linux kernel. Linux

Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-20 Thread Tan, Jianfeng
Hi Ferruh & Harish, On 10/20/2017 9:15 AM, Ferruh Yigit wrote: On 10/19/2017 3:43 PM, Patil, Harish wrote: -Original Message- From: Harish Patil Date: Tuesday, October 17, 2017 at 9:50 PM To: Thomas Monjalon , Ferruh Yigit Cc: "dev@dpdk.org" , Jianfeng Tan , Jingjing Wu , "Thotton, S

[dpdk-dev] [PATCH v4 3/3] doc: use correct mempool ops handle name

2017-10-20 Thread Santosh Shukla
Fixes: f820b5896631 ("doc: add octeontx ethdev driver documentation") Signed-off-by: Santosh Shukla --- doc/guides/nics/octeontx.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/octeontx.rst b/doc/guides/nics/octeontx.rst index 2527aa3e3..d40d1f94b 100644 -

[dpdk-dev] [PATCH v4 0/3] Octeontx doc misc

2017-10-20 Thread Santosh Shukla
Patch 1: Introduce platform/ entry in guide. That has information about platform drivers. ( As per discussion[1]) Patch 2: Introduce mempool/ entry in guide. (Refer discussion[1]) Patch 3: Misc Fix for nic/octeontx.rst Thanks. [1] http://dpdk.org/dev/patchwork/patch/29893/ Santosh Shukla (3):

[dpdk-dev] [PATCH v4 2/3] doc: add mempool and octeontx mempool device

2017-10-20 Thread Santosh Shukla
This commit adds a section to the docs listing the mempool device PMDs available. It then adds the octeontx fpavf mempool PMD to the listed mempool devices. Cc: John McNamara Signed-off-by: Santosh Shukla --- v3 --> v4: - Moved Prerequisite section from mempool/octeontx.rst to platform/octeo

[dpdk-dev] [PATCH v4 1/3] doc: add platform device

2017-10-20 Thread Santosh Shukla
This commit adds a section to the docs listing the platform device PMDs available. It then adds the octeontx platform driver to the listed platform devices. Patch also removes platform specific duplicate setup information from eventdev/octeontx.rst, nics/octeontx.rst and update to plaform/octeont

[dpdk-dev] [pull-request] next-tm 17.11 pre-rc2

2017-10-20 Thread Cristian Dumitrescu
The following changes since commit 6b9ed026a8704b9e5ee5da7997617ef7cc82e114: igb_uio: fix build with kernel <= 3.17 (2017-10-16 13:07:11 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-tm for you to fetch changes up to d5b0bd08a6064565515fd9e52ed2060693d22

[dpdk-dev] [PATCH] net/bonding: fix setting default aggregator mode to stable

2017-10-20 Thread Daniel Mrzyglod
This patch change default aggregator mode to stable when using rte_eth_bond_create() Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Signed-off-by: Daniel Mrzyglod --- drivers/net/bonding/rte_eth_bond_pmd.c | 21 - 1 file changed, 20 insertions(+), 1 deletio

Re: [dpdk-dev] [PATCH v2 0/7] fix TM (Traffic Management) issues on i40e and ixgbe

2017-10-20 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Tuesday, October 17, 2017 6:51 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v2 0/7] fix TM (Traffic Management) issues on > i40e and ixgbe > > By design, all the queues

Re: [dpdk-dev] [PATCH 0/6] fix TM (Traffic Management) issues on i40e and ixgbe

2017-10-20 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Friday, October 13, 2017 3:58 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH 0/6] fix TM (Traffic Management) issues on i40e > and ixgbe > > By design, all the queues are

Re: [dpdk-dev] [PATCH v10 1/3] app/test-pmd: add CLI for TM capability and stats

2017-10-20 Thread Dumitrescu, Cristian
> > > -Original Message- > > From: Singh, Jasvinder > > Sent: Tuesday, October 17, 2017 2:55 AM > > To: dev@dpdk.org > > Cc: Dumitrescu, Cristian ; Wu, Jingjing > > ; Pei, Yulong > > Subject: [PATCH v10 1/3] app/test-pmd: add CLI for TM capability and stats > > > > Add following CLIs to t

[dpdk-dev] [PATCH] vfio: fix secondary process initialization

2017-10-20 Thread Anatoly Burakov
When getting group fd from primary process, secondary wasn't storing the fd anywhere, leading to a (harmless) error message in EAL logs, and (not so harmless) potential problems when hot-unplugging devices managed by VFIO in a secondary process. Fix it by actually storing the group fd whenever we

Re: [dpdk-dev] [PATCH] net/mlx4: fix restriction on TCP/UDP flow rules

2017-10-20 Thread Nélio Laranjeiro
On Fri, Oct 20, 2017 at 02:39:58PM +0200, Adrien Mazarguil wrote: > The code as currently written requires TCP/UDP source and destination ports > to be always specified. > > No such restriction is enforced by hardware; all TCP and UDP traffic can be > matched by providing an empty mask for these f

[dpdk-dev] [PATCH] net/mlx4: fix restriction on TCP/UDP flow rules

2017-10-20 Thread Adrien Mazarguil
The code as currently written requires TCP/UDP source and destination ports to be always specified. No such restriction is enforced by hardware; all TCP and UDP traffic can be matched by providing an empty mask for these fields. Fixes: 680d5280c20b ("net/mlx4: refactor flow item validation code")

[dpdk-dev] [PATCH v3 6/6] eal/common/rte_malloc: use pointer diff in virt2iova

2017-10-20 Thread Santosh Shukla
Use RTE_PTR_DIFF macro in rte_mem_virt2iova api. Suggested-by: Anatoly Burakov Signed-off-by: Santosh Shukla --- lib/librte_eal/common/rte_malloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c index

[dpdk-dev] [PATCH v3 5/6] doc: remove dpdk iova aware notice

2017-10-20 Thread Santosh Shukla
Removed dpdk iova aware ABI deprecation notice, and updated ABI change details in release_17.11.rst. Signed-off-by: Santosh Shukla Acked-by: John McNamara --- doc/guides/rel_notes/deprecation.rst | 7 --- doc/guides/rel_notes/release_17_11.rst | 28 2 files c

Re: [dpdk-dev] [PATCH 2/3] ethdev: fix xstats get by id APIS

2017-10-20 Thread Ivan Malov
On Fri, Oct 20, 2017 at 01:03:50AM +0100, Ferruh Yigit wrote: > ethdev xstat get by id APIs: > rte_eth_xstats_get_names_by_id() > rte_eth_xstats_get_by_id() > > Works on ids calculated as "basic stats + device specific stats" > > When an application asking for id less than "basic stats count", it

[dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API to iova types

2017-10-20 Thread Santosh Shukla
Renamed memory translational api to _iova types. The following api renamed from: rte_mempool_populate_phys() rte_mempool_populate_phys_tab() rte_eal_using_phys_addrs() rte_mem_virt2phy() rte_dump_physmem_layout() rte_eal_get_physmem_layout() rte_eal_get_physmem_size() rte_malloc_virt2phy() rte_mem

[dpdk-dev] [PATCH v3 3/6] eal/memory: rename memseg member phys to iova addr

2017-10-20 Thread Santosh Shukla
Renaming rte_memseg {.phys_addr} to {.iova_addr} Signed-off-by: Santosh Shukla Reviewed-by: Anatoly Burakov --- lib/librte_eal/bsdapp/eal/eal_memory.c | 4 ++-- lib/librte_eal/common/eal_common_memory.c | 2 +- lib/librte_eal/common/include/rte_memory.h | 4 ++-- lib/librte_eal/common/rte_

[dpdk-dev] [PATCH v3 2/6] eal/memory: rename buf physaddr to buf iovaaddr

2017-10-20 Thread Santosh Shukla
Rename buf_physaddr to buf_iovaaddr Signed-off-by: Santosh Shukla Reviewed-by: Anatoly Burakov --- app/test-crypto-perf/cperf_test_common.c | 4 ++-- doc/guides/prog_guide/img/mbuf1.svg| 2 +- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h

[dpdk-dev] [PATCH v3 1/6] eal: rename phys addr to iova addr

2017-10-20 Thread Santosh Shukla
Renamed data type from phys_addr_t to iova_addr_t. Signed-off-by: Santosh Shukla Reviewed-by: Anatoly Burakov --- v2 --> v3: - Replaced __KERNEL__ with __clang__ in kni header (By Anatoly) Refer v2: http://dpdk.org/dev/patchwork/patch/28358/ app/test-crypto-perf/cperf_test_common.c |

[dpdk-dev] [PATCH v3 0/6] make dpdk iova aware

2017-10-20 Thread Santosh Shukla
v3: Include v2 review comment and rebased on top of upstream tip commit:6b9ed026a8704 v2: Include build fixes reported in patchworks. Changeset based on deprecation notice[1], planned for v17.11 release. Patches are based commit: (c42021fe56 : ethdev: rename map file to match library name) Sum

Re: [dpdk-dev] Requirement of minimum Rx burst size for PMDs

2017-10-20 Thread Andrew Rybchenko
On 10/20/2017 02:58 PM, Bruce Richardson wrote: On Fri, Oct 20, 2017 at 01:07:17PM +0300, Andrew Rybchenko wrote: On 10/20/2017 04:18 AM, Yongseok Koh wrote: Therefore, how about adding min_rx/tx_burst_sz in struct rte_eth_dev_info and have PMDs fill it in on dev_ops->dev_infos_get() so as to m

Re: [dpdk-dev] [PATCH V4 0/5] rte_mtr: generic ethdev api for metering and policing

2017-10-20 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > Sent: Friday, October 13, 2017 1:22 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; adrien.mazarg...@6wind.com; Wu, Jingjing > ; Mcnamara, John ; > hemant.agra...@nxp.com; jerin.ja...@cavium

Re: [dpdk-dev] Requirement of minimum Rx burst size for PMDs

2017-10-20 Thread Bruce Richardson
On Fri, Oct 20, 2017 at 01:07:17PM +0300, Andrew Rybchenko wrote: > On 10/20/2017 04:18 AM, Yongseok Koh wrote: > > Therefore, how about adding min_rx/tx_burst_sz in struct rte_eth_dev_info > > and > > have PMDs fill it in on dev_ops->dev_infos_get() so as to make apps comply > > with > > it. >

Re: [dpdk-dev] [PATCH v3] doc: add virtio lsc note

2017-10-20 Thread Yuanhan Liu
On Mon, Oct 16, 2017 at 07:10:24PM +, Mcnamara, John wrote: > > > > -Original Message- > > From: Yang, Zhiyong > > Sent: Monday, October 16, 2017 6:41 AM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; y...@fridaylinux.org; > > Mcnamara, John ; Yang, Zhiyong > > > > Subject: [PATCH v3]

Re: [dpdk-dev] [PATCH v2 1/7] eventdev: add API to get service id

2017-10-20 Thread Pavan Nikhilesh Bhagavatula
On Fri, Oct 20, 2017 at 10:21:57AM +, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Friday, October 13, 2017 5:37 PM > > To: jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; Van Haaren, > > Harry > > Cc: dev@dpdk.org; Pavan Bhagava

Re: [dpdk-dev] [PATCH v4 09/12] mk: add rte security into build system

2017-10-20 Thread Thomas Monjalon
Why not merging this patch with the first one? > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Security API - EXPERIMENTAL > +M: Akhil Goyal > +M: Declan Doherty > +T: git://dpdk.org/draft/dpdk-draft-ipsec > +F: lib/librte_security/ > +F: doc/guides/prog_guide/rte_security.rst Do you really want to

Re: [dpdk-dev] [PATCH v4 08/12] doc: add details of rte_flow security actions

2017-10-20 Thread Thomas Monjalon
This patch could be merged with the previous one, adding the action in the rte_flow code.

Re: [dpdk-dev] [PATCH v4 06/12] ethdev: support security APIs

2017-10-20 Thread Thomas Monjalon
15/10/2017 00:17, Akhil Goyal: > --- a/lib/librte_ether/rte_ethdev_version.map > +++ b/lib/librte_ether/rte_ethdev_version.map > @@ -194,5 +194,6 @@ DPDK_17.11 { > rte_eth_dev_pool_ops_supported; > rte_eth_dev_reset; > rte_flow_error_set; > + rte_eth_dev_get_sec_ctx; >

Re: [dpdk-dev] [PATCH v2 3/6] examples/ipsec-secgw: fix aad_len for for aes-gcm

2017-10-20 Thread Thomas Monjalon
20/10/2017 11:52, De Lara Guarch, Pablo: > Same comments as in patch 1, and also fix the commit title > ("for" duplicated) and avoid "_". The underscore is forbidden in titles to avoid naming variable or function names instead of giving a clear scope understandable without digging in the code. Her

[dpdk-dev] [PATCH] doc: group classification libraries in doxygen index

2017-10-20 Thread Thomas Monjalon
The libraries reorder, distributor, EFD, ACL and member seem to belong to the same category. The previous categories "layers" and "containers" do not fit well. It is proposed to group them under "classification" category. Signed-off-by: Thomas Monjalon --- doc/api/doxy-api-index.md | 14

Re: [dpdk-dev] [PATCH v3] net/failsafe: fix calling device during RMV events

2017-10-20 Thread Gaëtan Rivet
Hi Ophir, Sorry about the delay, I have a few remarks, I think this patch could be simpler. First, about the commit logline: "calling device" is not descriptive enough. I'd suggest net/failsafe: fix device configuration during RMV events But I'm not a native speaker either, so use it if you

Re: [dpdk-dev] [PATCH v9 2/2] doc: add new introduction to sample app guides

2017-10-20 Thread Mcnamara, John
> -Original Message- > From: Kovacevic, Marko > Sent: Thursday, October 19, 2017 1:11 PM > To: Mcnamara, John > Cc: dev@dpdk.org; Kovacevic, Marko > Subject: [PATCH v9 2/2] doc: add new introduction to sample app guides > > Add new Introduction Section into the sample app guides. > >

Re: [dpdk-dev] [PATCH v9 1/2] doc: add generic compilation doc for all sample apps

2017-10-20 Thread Mcnamara, John
> -Original Message- > From: Kovacevic, Marko > Sent: Thursday, October 19, 2017 1:11 PM > To: Mcnamara, John > Cc: dev@dpdk.org; Kovacevic, Marko ; Herakliusz > Lipiec > Subject: [PATCH v9 1/2] doc: add generic compilation doc for all sample > apps > > From: Herakliusz Lipiec > > Mo

Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event queue config

2017-10-20 Thread Pavan Nikhilesh Bhagavatula
On Fri, Oct 20, 2017 at 09:54:36AM +, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Thursday, October 12, 2017 2:16 PM > > To: jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; Van Haaren, > > Harry > > Cc: dev@dpdk.org; Pavan Nikhi

Re: [dpdk-dev] [PATCH v2 2/7] event/sw: extend service capability

2017-10-20 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Friday, October 13, 2017 5:37 PM > To: jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; Van Haaren, > Harry > Cc: dev@dpdk.org; Pavan Bhagavatula > Subject: [dpdk-dev] [PATCH v2 2/7] event/sw: extend service capabilit

Re: [dpdk-dev] [PATCH v4 2/2] examples/ipsec_secgw: added jumbo frames support

2017-10-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Friday, October 20, 2017 10:30 AM > To: dev@dpdk.org > Cc: Gonzalez Monroy, Sergio ; De Lara > Guarch, Pablo ; > avia...@dev.mellanox.co.il; Nicolau, Radu > Subject: [dpdk-dev] [PATCH v4 2/2]

Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec_secgw: switched to new offload API

2017-10-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Friday, October 20, 2017 10:30 AM > To: dev@dpdk.org > Cc: Gonzalez Monroy, Sergio ; De Lara > Guarch, Pablo ; > avia...@dev.mellanox.co.il; Nicolau, Radu > Subject: [PATCH v4 1/2] examples/ipsec_secgw: switched to new offload > API > >

Re: [dpdk-dev] [PATCH v2 1/7] eventdev: add API to get service id

2017-10-20 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Friday, October 13, 2017 5:37 PM > To: jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; Van Haaren, > Harry > Cc: dev@dpdk.org; Pavan Bhagavatula > Subject: [dpdk-dev] [PATCH v2 1/7] eventdev: add API to get service i

Re: [dpdk-dev] [PATCH v4 04/12] net: add ESP header to generic flow steering

2017-10-20 Thread Thomas Monjalon
15/10/2017 00:17, Akhil Goyal: > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -111,7 +111,8 @@ The public API headers are grouped by topics: >[LPM IPv6 route] (@ref rte_lpm6.h), >[ACL](@ref rte_acl.h), >[EFD](@ref rte_efd.h),

Re: [dpdk-dev] Requirement of minimum Rx burst size for PMDs

2017-10-20 Thread Andrew Rybchenko
On 10/20/2017 04:18 AM, Yongseok Koh wrote: Therefore, how about adding min_rx/tx_burst_sz in struct rte_eth_dev_info and have PMDs fill it in on dev_ops->dev_infos_get() so as to make apps comply with it. Just for my understand, what should happen if application wants to send only one packet?

Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event queue config

2017-10-20 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Thursday, October 12, 2017 2:16 PM > To: jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; Van Haaren, > Harry > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event q

Re: [dpdk-dev] [PATCH v2 1/6] examples/ipsec-secgw: fix initialization of aead crypto devices

2017-10-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: avia...@dev.mellanox.co.il [mailto:avia...@dev.mellanox.co.il] > Sent: Thursday, October 19, 2017 7:53 PM > To: dev@dpdk.org; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.ag

Re: [dpdk-dev] [PATCH v2 3/6] examples/ipsec-secgw: fix aad_len for for aes-gcm

2017-10-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: avia...@dev.mellanox.co.il [mailto:avia...@dev.mellanox.co.il] > Sent: Thursday, October 19, 2017 7:53 PM > To: dev@dpdk.org; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.ag

Re: [dpdk-dev] [PATCH v4 02/12] doc: add details of rte security

2017-10-20 Thread Thomas Monjalon
15/10/2017 00:17, Akhil Goyal: > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -58,7 +58,8 @@ The public API headers are grouped by topics: >[ixgbe] (@ref rte_pmd_ixgbe.h), >[i40e] (@ref rte_pmd_i40e.h), >[bnxt] (@ref rte

Re: [dpdk-dev] [PATCH v4 01/12] lib/rte_security: add security library

2017-10-20 Thread Thomas Monjalon
20/10/2017 11:37, Thomas Monjalon: > 15/10/2017 00:17, Akhil Goyal: > > lib/librte_security/Makefile | 53 +++ > > lib/librte_security/rte_security.c | 149 > > lib/librte_security/rte_security.h | 535 > > +++ > > lib/librte_s

Re: [dpdk-dev] [PATCH v4 01/12] lib/rte_security: add security library

2017-10-20 Thread Thomas Monjalon
15/10/2017 00:17, Akhil Goyal: > lib/librte_security/Makefile | 53 +++ > lib/librte_security/rte_security.c | 149 > lib/librte_security/rte_security.h | 535 > +++ > lib/librte_security/rte_security_driver.h| 155

[dpdk-dev] [PATCH v4 1/2] examples/ipsec_secgw: switched to new offload API

2017-10-20 Thread Radu Nicolau
Signed-off-by: Radu Nicolau --- v2: updated commit message v3: addressed feedback v4: split in 2 patches examples/ipsec-secgw/ipsec-secgw.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index d

[dpdk-dev] [PATCH v4 2/2] examples/ipsec_secgw: added jumbo frames support

2017-10-20 Thread Radu Nicolau
Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 31 +-- 2 files changed, 34 insertions(+), 3 deletions(-) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides/sample_app_ug

[dpdk-dev] [PATCH v4] examples/ipsec_secgw: added jumbo frames support

2017-10-20 Thread Radu Nicolau
Signed-off-by: Radu Nicolau --- v2: updated commit message v3: addressed feedback v4: split in 2 patches doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 31 +-- 2 files changed, 34 insertions(+), 3 deletions(-) diff --

Re: [dpdk-dev] [PATCH v4 00/12] introduce security offload library

2017-10-20 Thread Thomas Monjalon
16/10/2017 12:44, Thomas Monjalon: > 15/10/2017 00:17, Akhil Goyal: > > This patchset introduce the rte_security library in DPDK. > > This also includes the sample implementation of drivers and > > changes in ipsec gateway application to demonstrate its usage. > [...] > > This patchset is also avai

Re: [dpdk-dev] [PATCH 2/5] eal/bsdapp: fix missing interrupt stub functions

2017-10-20 Thread Bruce Richardson
On Thu, Oct 19, 2017 at 05:36:26PM +0100, Bruce Richardson wrote: > A number of interrupt functions only existed on Linux. Adding in stubs > for these functions corrects this omission, and allows the map files for > both Linux and FreeBSD to be identical. > > CC: sta...@dpdk.org > Fixes: 9efe9c6cd

[dpdk-dev] [RFC 7/9] net/avf: enable ops for rss setting

2017-10-20 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/avf/avf_ethdev.c | 173 +++ 1 file changed, 173 insertions(+) diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index a9cea86..d3946d6 100644 --- a/drivers/net/avf/avf_ethdev.c +++ b/drivers

[dpdk-dev] [RFC 8/9] net/avf: enable ops to check queue info and status

2017-10-20 Thread Jingjing Wu
- rxq_info_get - txq_info_get - rx_queue_count - rx_descriptor_done - rx_descriptor_status - tx_descriptor_status Signed-off-by: Jingjing Wu --- doc/guides/nics/intel_vf.rst | 16 - drivers/net/avf/avf_ethdev.c | 8 +++ drivers/net/avf/avf_rxtx.c | 145

[dpdk-dev] [RFC 9/9] net/i40e: support AVF basic interface

2017-10-20 Thread Jingjing Wu
Enable Virtchnl offload Caps negotiation and RSS_PF offload to support AVF basic interface. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 64 +++ drivers/net/i40e/i40e_ethdev.h | 4 ++ drivers/net/i40e/i40e_pf.c | 136 +

[dpdk-dev] [RFC 6/9] net/avf: enable ops for MAC VLAN offload

2017-10-20 Thread Jingjing Wu
- promiscuous_enable - promiscuous_disable - allmulticast_enable - allmulticast_disable - mac_addr_add - mac_addr_remove - mac_addr_set Signed-off-by: Jingjing Wu --- drivers/net/avf/avf.h| 5 + drivers/net/avf/avf_ethdev.c | 211 +++ driv

[dpdk-dev] [RFC 4/9] net/avf: enable basic Rx Tx func

2017-10-20 Thread Jingjing Wu
Signed-off-by: Wenzhuo Lu --- config/common_base | 3 + drivers/net/avf/avf_ethdev.c | 17 +- drivers/net/avf/avf_log.h| 14 + drivers/net/avf/avf_rxtx.c | 740 +++ drivers/net/avf/avf_rxtx.h | 46 +++ 5 files changed, 819 insertions(

[dpdk-dev] [RFC 5/9] net/avf: enable link status update

2017-10-20 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/avf/avf_ethdev.c | 50 drivers/net/avf/avf_vchnl.c | 35 ++- 2 files changed, 84 insertions(+), 1 deletion(-) diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethde

[dpdk-dev] [RFC 2/9] net/avf: initilization of avf PMD

2017-10-20 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- config/common_base | 5 + drivers/net/Makefile| 2 + drivers/net/avf/Makefile| 92 +++ drivers/net/avf/avf.h | 221 +++ drivers/net/avf/avf_ethdev.c| 475

[dpdk-dev] [RFC 3/9] net/avf: enable queue and device

2017-10-20 Thread Jingjing Wu
enable device and queue setup ops like: - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get - rx_queue_start - rx_queue_stop - tx_queue_start - tx_queue_stop - rx_queue_setup - rx_queue_release - tx_queue_setup - tx_queue_release Signed-off-by: Jingjing Wu --- driver

[dpdk-dev] [RFC 0/9] add new avf PMD

2017-10-20 Thread Jingjing Wu
Adaptive Virtual Function (AVF) Driver is VF driver which supports for all future Intel devices without requiring a VM update. It promises the basic high speed connectivity. And since this happens to be an adaptive VF driver, every new drop of the VF driver would add more and more advanced features

Re: [dpdk-dev] Requirement of minimum Rx burst size for PMDs

2017-10-20 Thread Bruce Richardson
On Fri, Oct 20, 2017 at 01:18:18AM +, Yongseok Koh wrote: > Hi, > > In some rx_burst functions, especially for vectorized ones (e.g. > i40e_rxtx_vec* > or mlx5_rxtx_vec*), there's actually a requirement of min burst size. > > As it manipulates 4 packets simultaneously in a loop, if nb_pkts o

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-20 Thread Ananyev, Konstantin
> >> > >>> Hi, > >>> > >>> On 2017/10/19 18:02, Ananyev, Konstantin wrote: > Hi Jia, > > > Hi > > > > > > On 10/13/2017 9:02 AM, Jia He Wrote: > >> Hi Jerin > >> > >> > >> On 10/13/2017 1:23 AM, Jerin Jacob Wrote: > >>> -Original Message- > >