[dpdk-dev] Shared compilation issue - mempool/octeontx: add build and log infrastructure

2017-10-13 Thread Hemant Agrawal
Santosh/jerin, Your patch "mempool/octeontx: add build and log infrastructure" is causing shared build failure for NXP's patch "event/dpaa2: support event eth adapter", which is still under review. http://dpdk.org/dev/patchwork/patch/30248/ In your patch, you have added mempool to be dep

Re: [dpdk-dev] [PATCH] eventdev: use new event enqueue in Rx adapter

2017-10-13 Thread Rao, Nikhil
On 10/13/2017 12:15 AM, Pavan Nikhilesh wrote: When event Rx adapter uses software based packet transfer, event op is always RTE_EVENT_OP_NEW. By using rte_event_enqueue_new_burst API the underlying event devices driver can use it as a hint to optimize enqueue operation if possible. Signed-off-b

[dpdk-dev] [dpdk-announce] release candidate 17.11-rc1

2017-10-13 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v17.11-rc1 There are 893 patches in this first drop. It is a new record! It required a lot of work from all the contributors and especially from Ferruh, thanks :) The planned release date for 17.11 is i

[dpdk-dev] [PATCH] doc: fix highlight of bumped libs in release notes

2017-10-13 Thread Thomas Monjalon
The libraries which have their ABI version increased in this release must be prepended with a + sign to make them appear clearly. Fixes: f8244c6399d9 ("ethdev: increase port id range") Fixes: ec51443cc99a ("gso: add Generic Segmentation Offload API framework") Signed-off-by: Thomas Monjalon ---

Re: [dpdk-dev] [PATCH V3] doc: minor fixes for GSO prog_guide

2017-10-13 Thread Ferruh Yigit
On 10/12/2017 5:05 PM, Mark Kavanagh wrote: > Correct two minor issues in the GSO programmer's guide: > - a note is rendered incorrectly in the middle of an unordered list; > this results in the remainder of the list appearing inside the note. > Correct indentation of the note to resolve same.

Re: [dpdk-dev] [PATCH] examples/performance-thread: fix out-of-bounds read

2017-10-13 Thread Thomas Monjalon
> > Overrunning array per_lcore_this_sched->current_lthread->tls->data of > > 1024 8-byte elements at element index 1024 using index k. > > Fixed by correct check k condition. > > > > Coverity issue: 143463 > > Fixes: 116819b9ed0d ("examples/performance-thread: add lthread > > subsystem") > > Cc:

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/performance-thread: fix out-of-bounds read

2017-10-13 Thread Thomas Monjalon
> > Overrunning array per_lcore_this_sched->current_lthread->tls->data of > > 1024 8-byte elements at element index 1024 using index k. > > Fixed by correct check k condition. > > > > Coverity issue: 143462 > > Fixes: 116819b9ed0d ("examples/performance-thread: add lthread > > subsystem") > > Cc:

Re: [dpdk-dev] [PATCH] examples/performance-thread: fix out-of-bounds read

2017-10-13 Thread Thomas Monjalon
> > Overrunning array schedcore of 128 8-byte elements at element index 128 > > using index lcoreid. > > Fixed by correct check index lcoreid condition. > > > > Coverity issue: 143461 > > Fixes: 116819b9ed0d ("examples/performance-thread: add lthread > > subsystem") > > Cc: ian.be...@intel.com > >

Re: [dpdk-dev] [PATCH] examples/performance-thread: fix out-of-bounds read

2017-10-13 Thread Thomas Monjalon
> > > Overrunning array schedcore of 128 8-byte elements at element index > > 128 > > > using index lcore_id. > > > Fixed by correct check index lcoreid condition and > > > change type of lcoreid to unsigned. > > > > > > Coverity issue: 143459 > > > Fixes: 116819b9ed0d ("examples/performance-thread

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/performance-thread: fix return check

2017-10-13 Thread Thomas Monjalon
> > There was a call for thread create function without result check. > > Added result check and message printout after failure. > > > > Coverity issue: 143441 > > Fixes: 433ba6228f9a ("examples/performance-thread: add pthread_shim > > app") > > Cc: ian.be...@intel.com > > Cc: sta...@dpdk.org > >

Re: [dpdk-dev] [PATCH v2] examples/ip_reassembly: use pktmbuf to create pool

2017-10-13 Thread Thomas Monjalon
> > Use of rte_mempool_create() with the helper provided in > > librte_mbuf: rte_pktmbuf_pool_create(). > > This is the preferred way to create a mbuf pool else > > it may not work on implementation using the HW buffer pool > > > > Signed-off-by: Ashish Jain > > Acked-by: Konstantin Ananyev Ap

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: optimised packet processing on powerpc

2017-10-13 Thread Thomas Monjalon
> > From: Gowrishankar Muthukrishnan > > > > This patch adds altivec support for lpm packet processing in powerpc. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > > Acked-by: Chao Zhu Applied, thanks

Re: [dpdk-dev] [PATCH v3] kni: fix build on SLE12 SP3

2017-10-13 Thread Ferruh Yigit
On 10/9/2017 11:04 PM, Ferruh Yigit wrote: > From: Nirmoy Das > > compilation error: > build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error: > ‘struct net_device’ has no member named ‘trans_start’ > dev->trans_start = jiffies; > > Signed-off-by: Nirmoy Das > Signed-off-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] l3fwd-power: remove the dead codes.

2017-10-13 Thread Thomas Monjalon
13/10/2017 19:20, Tonghao Zhang: > Signed-off-by: Tonghao Zhang > --- > examples/l3fwd-power/main.c | 2 -- > 1 file changed, 2 deletions(-) Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH] l3fwd-acl: fix unchecked return value

2017-10-13 Thread Thomas Monjalon
11/10/2017 09:07, Yang, Zhiyong: > Hi Kuba, > > Just a soft reminder. :) > Maintainers will make the decision. > > Ferruh, Thomas, > > Your opinion? No need to re-send. More comments: - do not top reply - title should start with examples/ - use --in-reply-to when sending a new version Than

Re: [dpdk-dev] [dpdk-stable] [PATCH] l3fwd-acl: fix unchecked return value

2017-10-13 Thread Thomas Monjalon
03/10/2017 13:48, Kuba Kozak: > Add return value check and error handling for fseek call. > > Coverity issue: 143435 > Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl") > Cc: konstantin.anan...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Kuba Kozak > Acked-by: Konstantin Ananyev Applied

Re: [dpdk-dev] [PATCH v2] examples/l2fwd_fork: fix message pool init

2017-10-13 Thread Thomas Monjalon
15/09/2017 17:37, Xueming Li: > Some invalid callback functions are provided to rte_pktmbuf_pool_init() > without their associated data causing a segmentation fault when the > function tries to use it. In this example, those callbacks are not > necessary, they can be safely replaced by NULL pointer

Re: [dpdk-dev] [PATCH v4] examples/l2fwd-cat: fix build according to API changes

2017-10-13 Thread Thomas Monjalon
19/09/2017 12:47, Bruce Richardson: > On Tue, Sep 19, 2017 at 12:40:44PM +0300, Vladimir Kuramshin wrote: > > Current version is compatible with PQOS version 1.3 > > but not compatible with higher versions. This change > > makes l2fwd-cat example compatible with versions since 1.4 > > > > Signed-o

Re: [dpdk-dev] [PATCH] example: add new service cores sample application

2017-10-13 Thread Thomas Monjalon
14/10/2017 00:20, Thomas Monjalon: > 25/09/2017 15:23, Harry van Haaren: > > This commit adds a new sample app, which showcases the value > > of running services. In particular it allows the application > > to dynamically schedule services to service-cores. > > > > The sample app itself registers

Re: [dpdk-dev] [PATCH] example: add new service cores sample application

2017-10-13 Thread Thomas Monjalon
25/09/2017 15:23, Harry van Haaren: > This commit adds a new sample app, which showcases the value > of running services. In particular it allows the application > to dynamically schedule services to service-cores. > > The sample app itself registers a number of dummy services, > and applies diffe

Re: [dpdk-dev] [PATCH v6 2/2] doc: add new introduction to sample app guides

2017-10-13 Thread Thomas Monjalon
Hi, 11/10/2017 17:51, Marko Kovacevic: > --- a/doc/guides/sample_app_ug/ipsec_secgw.rst > +++ b/doc/guides/sample_app_ug/ipsec_secgw.rst > @@ -28,6 +28,8 @@ > (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF S

Re: [dpdk-dev] [PATCH 2/2] igb_uio: fix interrupt enablement after FLR in VM

2017-10-13 Thread Ferruh Yigit
On 10/13/2017 9:54 PM, Ferruh Yigit wrote: > On 10/9/2017 9:31 PM, Jingjing Wu wrote: >> If pass-through a VF by vfio-pci to a Qemu VM, after FLR >> in VM, the interrupt setting is not recoverd correctly >> to host as below: >> in VM guest: >> Capabilities: [70] MSI-X: Enable+ Count=5 Mask

Re: [dpdk-dev] [PATCH v2 2/2] igb_uio: fix interrupt enablement after FLR in VM

2017-10-13 Thread Patil, Harish
-Original Message- From: dev on behalf of Ferruh Yigit Date: Friday, October 13, 2017 at 2:11 PM To: "Thotton, Shijith" , "Wu, Jingjing" , Harish Patil Cc: "Tan, Jianfeng" , "greg...@weka.io" , "Xing, Beilei" , "dev@dpdk.org" , "sta...@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 2/2]

Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-13 Thread Thomas Monjalon
13/10/2017 23:11, Thomas Monjalon: > 13/10/2017 23:05, Ferruh Yigit: > > On 10/13/2017 3:51 PM, Thomas Monjalon wrote: > > > Some VF drivers cannot work with igb_uio because of the > > > reset done in these functions. > > > > > > First bug report: > > > http://dpdk.org/ml/archives/dev/2017-Septe

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] igb_uio: fix interrupt enablement after FLR in VM

2017-10-13 Thread Thomas Monjalon
13/10/2017 22:54, Ferruh Yigit: > On 10/9/2017 9:31 PM, Jingjing Wu wrote: > > If pass-through a VF by vfio-pci to a Qemu VM, after FLR > > in VM, the interrupt setting is not recoverd correctly > > to host as below: > > in VM guest: > > Capabilities: [70] MSI-X: Enable+ Count=5 Masked- >

Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-13 Thread Thomas Monjalon
13/10/2017 23:05, Ferruh Yigit: > On 10/13/2017 3:51 PM, Thomas Monjalon wrote: > > Some VF drivers cannot work with igb_uio because of the > > reset done in these functions. > > > > First bug report: > > http://dpdk.org/ml/archives/dev/2017-September/075236.html > > > > A partial reset was t

Re: [dpdk-dev] [PATCH v2 2/2] igb_uio: fix interrupt enablement after FLR in VM

2017-10-13 Thread Ferruh Yigit
On 10/13/2017 9:12 AM, Shijith Thotton wrote: <...> > Hi Jingjing, > > This patch perfectly meets requirements as both resets are retained > (open and release). Tested it with LiquidIO NIC and it works fine. > I can see MSI-X re-enabled on each run with new patch. > > Gregory, Harish, > Please v

Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-13 Thread Ferruh Yigit
On 10/13/2017 3:51 PM, Thomas Monjalon wrote: > Some VF drivers cannot work with igb_uio because of the > reset done in these functions. > > First bug report: > http://dpdk.org/ml/archives/dev/2017-September/075236.html > > A partial reset was tried: > http://dpdk.org/patch/28940 > >

Re: [dpdk-dev] [PATCH 2/2] igb_uio: fix interrupt enablement after FLR in VM

2017-10-13 Thread Ferruh Yigit
On 10/9/2017 9:31 PM, Jingjing Wu wrote: > If pass-through a VF by vfio-pci to a Qemu VM, after FLR > in VM, the interrupt setting is not recoverd correctly > to host as below: > in VM guest: > Capabilities: [70] MSI-X: Enable+ Count=5 Masked- > in Host: > Capabilities: [70] MSI-X

Re: [dpdk-dev] [PATCH] doc: add arm64 to linux_gsg

2017-10-13 Thread Thomas Monjalon
> > Signed-off-by: Brian Brooks > > Reviewed-by: Song Zhu > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: remove fm10k features description for SSE

2017-10-13 Thread Thomas Monjalon
> > The features described for scalar fm10k and its vector implementations are > > the same. > > No need to distinguish them in features description. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: John McNamara Applied

Re: [dpdk-dev] [PATCH v2] doc: add note on hardware support deprecation

2017-10-13 Thread Thomas Monjalon
18/09/2017 15:59, Bruce Richardson: > Following agreement at the DPDK Technical Board meeting [1], the policy > that hardware support deprecation should be treated as though it were an > ABI break needs to be documented in the contributors guide. > > [1] http://dpdk.org/ml/archives/dev/2017-Septem

Re: [dpdk-dev] [PATCH] maintainers: sort crypto drivers list

2017-10-13 Thread Thomas Monjalon
13/10/2017 15:52, Pablo de Lara: > In order to improve consistency, the list of crypto > drivers are sorted alphabetically and the word > PMD is removed from their names. > > Signed-off-by: Pablo de Lara Applied, thanks

Re: [dpdk-dev] [PATCH] maintainers: update the email for ARM

2017-10-13 Thread Thomas Monjalon
> > Update my email to jianbo@arm.com. > > > > Signed-off-by: Jianbo Liu > > Acked-by: Jerin Jacob Applied Note: this patch is sent with email @linaro.org

Re: [dpdk-dev] Support for Intel 82579LM (8086:1502)

2017-10-13 Thread Mor, Omri
Hi Markus, Thanks for the patch! I thought that it might only need the support ‘switch’ flipped on, but wasn’t sure. It seems to work, though I get the following message when testing using `testpmd`: EAL: Error enabling MSI-X interrupts for fd 26 I’ve also seen a couple of lost packets,

Re: [dpdk-dev] [PATCH] net/mlx5: fix creation of compressed Rx completion queue

2017-10-13 Thread Thomas Monjalon
13/10/2017 22:00, Yongseok Koh: > The size of Rx completion queue should be doubled if compression is enabled > in case of non-vectorized Rx. > > Fixes: 523f5a742102 ("net/mlx5: fix configuration of Rx CQE compression") > Cc: sta...@dpdk.org > > Signed-off-by: Yongseok Koh > Acked-by: Nelio Lara

Re: [dpdk-dev] [PATCH] efd: fix build when compiler does not support AVX2

2017-10-13 Thread Thomas Monjalon
13/10/2017 20:24, Ferruh Yigit: > Compiler error: > irte_efd.o: In function `rte_efd_lookup': > rte_efd.c:(.text+0x6d6e): undefined reference to `efd_lookup_internal_avx2' > rte_efd.o: In function `rte_efd_lookup_bulk': > rte_efd.c:(.text+0x87d4): undefined reference to `efd_lookup_internal_avx2' >

[dpdk-dev] [PATCH] net/mlx5: fix creation of compressed Rx completion queue

2017-10-13 Thread Yongseok Koh
The size of Rx completion queue should be doubled if compression is enabled in case of non-vectorized Rx. Fixes: 523f5a742102 ("net/mlx5: fix configuration of Rx CQE compression") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 2 +-

Re: [dpdk-dev] [PATCH] igb_uio: fix legacy msi masking

2017-10-13 Thread Ferruh Yigit
On 10/13/2017 6:03 PM, Ferruh Yigit wrote: > On 10/13/2017 5:03 PM, Markus Theil wrote: >> MSI masks contain a 1 if interrupt is masked, 0 if unmasked. >> I got that wrong with the !!state calculation. For better >> readability, the mask is now changed like in igbuio_msi_mask_irq. >> >> Fixes: a8ea

Re: [dpdk-dev] [PATCH] vhost: fetch again ring_addrs address after NUMA reallocation

2017-10-13 Thread Thomas Monjalon
13/10/2017 11:43, Jens Freimann: > On Fri, Oct 13, 2017 at 09:30:21AM +, Maxime Coquelin wrote: > >In case of NUMA reallocation, the virtqueue struct is reallocated > >on another socket, meaning that its address changes. > > > >In translate_ring_addresses(), addr pointer was not fetched again >

Re: [dpdk-dev] [PATCH 0/2] vhost: IOTLB fixes for -rc1

2017-10-13 Thread Thomas Monjalon
> Maxime Coquelin (2): > vhost: fix deadlock on IOTLB miss > vhost: fix IOTLB on NUMA realloc Applied, thanks

Re: [dpdk-dev] [PATCH 0/8] fix port id type

2017-10-13 Thread Ferruh Yigit
On 10/13/2017 7:25 PM, Ferruh Yigit wrote: > On 10/13/2017 2:16 PM, Zhiyong Yang wrote: >> Fix port id type and update related docs. >> >> Zhiyong Yang (8): >> net/bonding: fix port id type >> net/i40e: fix port id type >> net/fm10k: fix port id type >> net/mrvl: fix port id type >> app:

Re: [dpdk-dev] [PATCH 0/8] fix port id type

2017-10-13 Thread Ferruh Yigit
On 10/13/2017 2:16 PM, Zhiyong Yang wrote: > Fix port id type and update related docs. > > Zhiyong Yang (8): > net/bonding: fix port id type > net/i40e: fix port id type > net/fm10k: fix port id type > net/mrvl: fix port id type > app: fix port id type > test: fix port id type > exam

[dpdk-dev] [PATCH] efd: fix build when compiler does not support AVX2

2017-10-13 Thread Ferruh Yigit
Compiler error: irte_efd.o: In function `rte_efd_lookup': rte_efd.c:(.text+0x6d6e): undefined reference to `efd_lookup_internal_avx2' rte_efd.o: In function `rte_efd_lookup_bulk': rte_efd.c:(.text+0x87d4): undefined reference to `efd_lookup_internal_avx2' This can be observed with a compiler that

[dpdk-dev] [PATCH] l3fwd-power: remove the dead codes.

2017-10-13 Thread Tonghao Zhang
Signed-off-by: Tonghao Zhang --- examples/l3fwd-power/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 8a8f34b..c08a775 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -752,8 +752,6 @@ static

Re: [dpdk-dev] [PATCH] igb_uio: fix legacy msi masking

2017-10-13 Thread Ferruh Yigit
On 10/13/2017 5:03 PM, Markus Theil wrote: > MSI masks contain a 1 if interrupt is masked, 0 if unmasked. > I got that wrong with the !!state calculation. For better > readability, the mask is now changed like in igbuio_msi_mask_irq. > > Fixes: a8ea1e5fb647 ("igb_uio: fix unknown MSI symbols") >

[dpdk-dev] [PATCH v8 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit

2017-10-13 Thread Jasvinder Singh
Add following CLIs in testpmd application for device traffic management; - commands to add TM hierarchy nodes (leaf and nonleaf). - command for runtime update of node weight. - command to commit the TM hierarchy Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- v8 change: - change

[dpdk-dev] [PATCH v8 2/3] app/test-pmd: add CLI for shaper and wred profiles

2017-10-13 Thread Jasvinder Singh
Add following CLIs in testpmd application for device traffic management; - commands to add/del shaper profile for TM hieraqrchy nodes. - commands to add/update shared shapers - commands to add/del WRED profiles for TM hiearchy leaf nodes. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitres

[dpdk-dev] [PATCH v8 1/3] app/test-pmd: add CLI for TM capability and stats

2017-10-13 Thread Jasvinder Singh
Add following CLIs to testpmd application for device traffic management; - commands to display TM capability information. (per port, per hierarchy level and per hierarchy node) - command to display hiearchy node type - stats collection Signed-off-by: Jasvinder Singh Tested-by: Yulong Pei Revi

Re: [dpdk-dev] Support for Intel 82579LM (8086:1502)

2017-10-13 Thread Markus Theil
Hi, I wrote a little patch for you. You can apply it to the current dpdk-master branch and test it. My Thinkpad T430 has such a NIC and shows some rx packets and the link status change with the patch, when using testpmd. Maybe 82579LM was not supported for a reason, so simply try out if it works f

[dpdk-dev] [PATCH v2 7/7] doc: update software event device

2017-10-13 Thread Pavan Nikhilesh
From: Pavan Bhagavatula Update software event device documentation to include use of service cores for event distribution. Signed-off-by: Pavan Nikhilesh Acked-by: John McNamara --- doc/guides/eventdevs/sw.rst | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v2 3/7] app/test-eventdev: update app to use service cores

2017-10-13 Thread Pavan Nikhilesh
From: Pavan Bhagavatula Use service cores for offloading event scheduling in case of centralized scheduling instead of calling the schedule api directly. This removes the dependency on dedicated scheduler core specified by giving command line option --slcore. Signed-off-by: Pavan Nikhilesh ---

[dpdk-dev] [PATCH v2 6/7] eventdev: remove eventdev schedule API

2017-10-13 Thread Pavan Nikhilesh
From: Pavan Bhagavatula remove eventdev schedule api and enforce sw driver to use service core feature for event scheduling. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/ssovf_evdev.c | 1 - drivers/event/skeleton/skeleton_eventdev.c | 2 -- drivers/event/sw/sw_evdev.c

[dpdk-dev] [PATCH v2 4/7] test/eventdev: update test to use service core

2017-10-13 Thread Pavan Nikhilesh
From: Pavan Bhagavatula Use service core for event scheduling instead of calling the event schedule api directly. Signed-off-by: Pavan Nikhilesh --- test/test/test_eventdev_sw.c | 120 --- 1 file changed, 67 insertions(+), 53 deletions(-) diff --git a/t

[dpdk-dev] [PATCH v2 5/7] examples/eventdev: update sample app to use service

2017-10-13 Thread Pavan Nikhilesh
From: Pavan Bhagavatula Update the sample app eventdev_pipeline_sw_pmd to use service cores for event scheduling in case of sw eventdev. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline_sw_pmd/main.c | 51 +--- 1 file changed, 33 insertions(+), 18 delet

[dpdk-dev] [PATCH v2 1/7] eventdev: add API to get service id

2017-10-13 Thread Pavan Nikhilesh
From: Pavan Bhagavatula In case of sw event device the scheduling can be done on a service core using the service registered at the time of probe. This patch adds a helper function to get the service id that can be used by the application to assign a lcore for the service to run on. Signed-off-b

[dpdk-dev] [PATCH v2 2/7] event/sw: extend service capability

2017-10-13 Thread Pavan Nikhilesh
From: Pavan Bhagavatula Extend the service capability of the sw event device by exposing service id to the application. The application can use service id to configure service cores to run event scheduling. Signed-off-by: Pavan Nikhilesh --- drivers/event/sw/sw_evdev.c | 9 + 1 file ch

[dpdk-dev] [PATCH] net/e1000: add pci ids for 82579LM

2017-10-13 Thread Markus Theil
This patch adds the PCI IDs for Intel 82579LM. Signed-off-by: Markus Theil --- drivers/net/e1000/em_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 6ebfa6d4c..85607c322 100644 --- a/drivers/net/e1000/em_ethdev.c +

[dpdk-dev] [PATCH] igb_uio: fix legacy msi masking

2017-10-13 Thread Markus Theil
MSI masks contain a 1 if interrupt is masked, 0 if unmasked. I got that wrong with the !!state calculation. For better readability, the mask is now changed like in igbuio_msi_mask_irq. Fixes: a8ea1e5fb647 ("igb_uio: fix unknown MSI symbols") Signed-off-by: Markus Theil Tested-by: Markus Theil -

Re: [dpdk-dev] [PATCH] doc: update oldest supported kernel

2017-10-13 Thread Luca Boccassi
On Fri, 2017-10-13 at 15:49 +, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > > Hemminger > > Sent: Tuesday, September 26, 2017 8:17 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH] doc: u

Re: [dpdk-dev] [PATCH] doc: update oldest supported kernel

2017-10-13 Thread Luca Boccassi
On Tue, 2017-09-26 at 08:17 +0100, Stephen Hemminger wrote: > The DPDK needs to stay up to date with current LTS Linux kernel > support. > If the kernel is older than LTS it is likely to be insecure and > buggy. > Therefore only require DPDK to work on oldest LTS kernel. > > If distribution vendor

Re: [dpdk-dev] [PATCH] doc: update oldest supported kernel

2017-10-13 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, September 26, 2017 8:17 AM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH] doc: update oldest supported kernel > > The DPDK needs to stay up to date with

Re: [dpdk-dev] [PATCH v2] crypto/dpaa_sec: add check for segmented buffer

2017-10-13 Thread Akhil Goyal
On 10/13/2017 9:07 PM, alok.makhar...@nxp.com wrote: From: Alok Makhariya The code would crash in case of segmented buffer if no check Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Signed-off-by: Alok Makhariya --- drivers/crypto/dpaa_sec/dpaa_sec.c | 7 +

Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: add check for segmented buffer

2017-10-13 Thread Akhil Goyal
On 10/13/2017 9:08 PM, alok.makhar...@nxp.com wrote: From: Alok Makhariya The code would crash for segmented buffer if no check. Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Cc: sta...@dpdk.org Signed-off-by: Alok Makhariya --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpsec

Re: [dpdk-dev] [PATCH V4 4/5] doc: ethdev traffic metering and policing api

2017-10-13 Thread Mcnamara, John
> -Original Message- > From: Dumitrescu, Cristian > Sent: Friday, October 13, 2017 1:22 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; adrien.mazarg...@6wind.com; Wu, Jingjing > ; Mcnamara, John ; > hemant.agra...@nxp.com; jerin.ja...@caviumnetworks.com; Singh, Jasvinder > > Subject: [

[dpdk-dev] [PATCH v2] crypto/dpaa2_sec: add check for segmented buffer

2017-10-13 Thread alok.makhariya
From: Alok Makhariya The code would crash for segmented buffer if no check. Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Cc: sta...@dpdk.org Signed-off-by: Alok Makhariya --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++- 1 file changed, 7 insertions(+), 1 del

Re: [dpdk-dev] [PATCH 8/8] doc: update port id type

2017-10-13 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Friday, October 13, 2017 2:17 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Yang, Zhiyong > > Subject: [dpdk-dev] [PATCH 8/8] doc: update port id type > > Since port id has changed from uint8_

Re: [dpdk-dev] [PATCH v7 1/4] librte_flow_classify: add librte_flow_classify library

2017-10-13 Thread Iremonger, Bernard
Hi Jasvinder, > -Original Message- > From: Singh, Jasvinder > Sent: Friday, October 6, 2017 4:01 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Yigit, Ferruh ; Ananyev, Konstantin > ; Dumitrescu, Cristian > ; adrien.mazarg...@6wind.com > Cc: Iremonger, Bernard > Subject: RE: [dpdk-dev] [PA

[dpdk-dev] [PATCH v2] crypto/dpaa_sec: add check for segmented buffer

2017-10-13 Thread alok.makhariya
From: Alok Makhariya The code would crash in case of segmented buffer if no check Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Signed-off-by: Alok Makhariya --- drivers/crypto/dpaa_sec/dpaa_sec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/dr

Re: [dpdk-dev] [PATCH 4/4] eal/x86: implement arch-specific TSC freq query

2017-10-13 Thread Bruce Richardson
On Fri, Oct 13, 2017 at 08:13:06AM -0700, Stephen Hemminger wrote: > On Fri, 13 Oct 2017 09:30:43 +0200 > Thomas Monjalon wrote: > > > 13/10/2017 05:47, Stephen Hemminger: > > > On Fri, 13 Oct 2017 02:02:47 +0200 > > > Thomas Monjalon wrote: > > > > > > > +static uint32_t > > > > +check_model

Re: [dpdk-dev] [PATCH 4/4] eal/x86: implement arch-specific TSC freq query

2017-10-13 Thread Stephen Hemminger
On Fri, 13 Oct 2017 09:30:43 +0200 Thomas Monjalon wrote: > 13/10/2017 05:47, Stephen Hemminger: > > On Fri, 13 Oct 2017 02:02:47 +0200 > > Thomas Monjalon wrote: > > > > > +static uint32_t > > > +check_model_wsm_nhm(uint8_t model) > > > +{ > > > + switch (model) { > > > + /* Westmere */ > >

Re: [dpdk-dev] [RFC 01/14] ethdev: add link status read/write functions

2017-10-13 Thread Stephen Hemminger
On Wed, 11 Oct 2017 08:32:12 + "Yang, Qiming" wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Saturday, July 15, 2017 2:30 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Stephen Hemminger > > > > Subject: [dpdk-dev] [RFC 01/14] ethdev: add lin

Re: [dpdk-dev] [PATCH v2 2/4] net/dpaa2: add API's to support event eth adapter

2017-10-13 Thread Hemant Agrawal
On 10/12/2017 10:48 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/dpaa2_ethdev.c| 67 + drivers/net/dpaa2/dpaa2_ethdev.h| 15 +++ drivers/net/dpaa2/dpaa2_rxtx.c | 20 + drivers/net/dpaa2/rte_p

Re: [dpdk-dev] 17.11 release candidate tag

2017-10-13 Thread Thomas Monjalon
13/10/2017 15:48, john miller: > > Hello, > > Is there a release candidate available for 17.11 ?I could not find a tag > in the dpdk-next-net repo. Not yet. We are late but RC1 should be closed at the end of this day.

Re: [dpdk-dev] [PATCH v2 3/4] event/dpaa2: support event eth adapter

2017-10-13 Thread Hemant Agrawal
On 10/13/2017 11:27 AM, Rao, Nikhil wrote: On 10/12/2017 10:48 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/event/Makefile | 4 +- drivers/event/dpaa2/Makefile | 2 + drivers/event/dpaa2/dpaa2_eventdev.c | 151 ++-

Re: [dpdk-dev] [PATCH v2 4/4] event/dpaa2: improve the err handling and log msg

2017-10-13 Thread Hemant Agrawal
On 10/12/2017 10:48 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 9 + drivers/event/dpaa2/dpaa2_hw_dpcon.c | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/d

[dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-13 Thread Thomas Monjalon
Some VF drivers cannot work with igb_uio because of the reset done in these functions. First bug report: http://dpdk.org/ml/archives/dev/2017-September/075236.html A partial reset was tried: http://dpdk.org/patch/28940 Second bug report after a partial revert trial: http:

Re: [dpdk-dev] [PATCH v2 1/4] drivers: add queue parameter in event processing callback

2017-10-13 Thread Hemant Agrawal
On 10/12/2017 10:48 PM, Nipun Gupta wrote: For event dequeues for ethernet queues, a dpaa2_queue structure is required to get the configuration for that ethernet queue. Based on this configuration the rte_event is to be filled at the ingress side. Signed-off-by: Nipun Gupta --- drivers/bus/fsl

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: add check for segmented buffer

2017-10-13 Thread Akhil Goyal
On 10/12/2017 6:37 PM, alok.makhar...@nxp.com wrote: From: Alok Makhariya The code would crash in case of segmented buffer if no check Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Signed-off-by: Alok Makhariya --- drivers/crypto/dpaa_sec/dpaa_sec.c | 7 +

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-10-13 Thread Shijith Thotton
On Tue, Oct 03, 2017 at 02:35:38PM +0300, Gregory Etelson wrote: > Hello, > > Can we hold with revert until proper solution will be introduced ? > > Regards, > Gregory > > On Monday, 2 October 2017 21:24:19 IDT Shijith Thotton wrote: > > On Fri, Sep 29, 2017 at 12:57:22PM +, Wu, Jingjing wro

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: add support for out of place buffers

2017-10-13 Thread Akhil Goyal
On 10/12/2017 6:37 PM, alok.makhar...@nxp.com wrote: From: Alok Makhariya Enable out of place buffer test cases in dpaa_sec Signed-off-by: Alok Makhariya --- drivers/crypto/dpaa_sec/dpaa_sec.c | 45 +++-- test/test/test_cryptodev.c | 6 +++

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add support for out of place buffers

2017-10-13 Thread Akhil Goyal
On 10/12/2017 6:37 PM, alok.makhar...@nxp.com wrote: From: Alok Makhariya Enable out of place buffer test cases in nxp dpaa2_sec Signed-off-by: Alok Makhariya --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 42 +++-- test/test/test_cryptodev.c |

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove memset of icv on decryption side

2017-10-13 Thread Akhil Goyal
On 10/12/2017 6:37 PM, alok.makhar...@nxp.com wrote: From: Alok Makhariya Since the packet lengths are modified. It is not required to explicitly reset the icv. Fixes: 13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR") Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: remove memset of icv on decryption side

2017-10-13 Thread Akhil Goyal
On 10/12/2017 6:37 PM, alok.makhar...@nxp.com wrote: From: Alok Makhariya Since the packet lengths are modified. It is not required to explicitly reset the icv. Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Signed-off-by: Alok Makhariya --- drivers/crypto/

[dpdk-dev] [PATCH] test/pmd_perf: fix for segmentation fault

2017-10-13 Thread Michal Jastrzebski
From: Daniel Mrzyglod Error can be reproduce if we run pmd_perf_autotest with more then one device in such way: RTE>>set_rxtx_sc poll_before_xmit RTE>>pmd_perf_autotest two threads are working without synchronization and we are unable to say on which port in the index will came packet. Fixes: 0

Re: [dpdk-dev] [PATCH] igb_uio: fix unknown symbols

2017-10-13 Thread Thomas Monjalon
13/10/2017 05:21, Patrick MacArthur: > On 10/12/2017 10:46 PM, Ferruh Yigit wrote: > > This patch partially reverts the commit d196343a258e and adds some > > functions from Markus' previous version of the patch [1]. > > > > igb_uio uses pci_msi_unmask_irq() and pci_msi_mask_irq() kernel APIs > > w

[dpdk-dev] [PATCH] maintainers: sort crypto drivers list

2017-10-13 Thread Pablo de Lara
In order to improve consistency, the list of crypto drivers are sorted alphabetically and the word PMD is removed from their names. Signed-off-by: Pablo de Lara --- MAINTAINERS | 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --

[dpdk-dev] 17.11 release candidate tag

2017-10-13 Thread john miller
Hello, Is there a release candidate available for 17.11 ?I could not find a tag in the dpdk-next-net repo. Thank you, -John

Re: [dpdk-dev] [PATCH] eal: call plugin init before device parse

2017-10-13 Thread Thomas Monjalon
13/10/2017 14:35, Maxime Coquelin: > > On 10/13/2017 01:55 PM, Santosh Shukla wrote: > > Default eal_init code calls > > 0. eal_plugins_init > > 1. eal_option_device_parse > > 2. rte_bus_scan > > > > IOVA commit:cf408c224 missed on calling eal_plugins_init before > > eal_option_device_parse, rte_

Re: [dpdk-dev] [PATCH] examples/power: fix build

2017-10-13 Thread Thomas Monjalon
13/10/2017 14:31, David Hunt: > Remove variable declaration from within for loop. > > Fixes: f14791a8126e ("examples/vm_power_mgr: add policy to channels") > > Signed-off-by: David Hunt Applied, thanks

Re: [dpdk-dev] [PATCH] mempool/octeontx: fix build issue with old gcc

2017-10-13 Thread Thomas Monjalon
13/10/2017 13:31, Jerin Jacob: > Replaced _Static_assert compiler function with RTE_BUILD_BUG_ON() > to fix build issue with old gcc. > > Fixes: 02fd6c744350 ("mempool/octeontx: support allocation") > Signed-off-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [PATCH] eal/x86: fix FreeBSD build

2017-10-13 Thread Thomas Monjalon
13/10/2017 15:08, Pablo de Lara: > lib/librte_eal/common/arch/x86/rte_cycles.c: In function 'rdmsr': > lib/librte_eal/common/arch/x86/rte_cycles.c:57:11: > error: unused parameter 'msr' [-Werror=unused-parameter] > rdmsr(int msr, uint64_t *val) >^ > lib/librte_eal/common/arch/x86/rte_c

[dpdk-dev] [PATCH 7/8] examples: fix port id type

2017-10-13 Thread Zhiyong Yang
Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang --- examples/distributor/main.c| 2 +- examples/ethtool/lib/rte_ethtool.c | 42 +-- examples/ethtool/lib/rte_ethtool.h | 42 +

[dpdk-dev] [PATCH 8/8] doc: update port id type

2017-10-13 Thread Zhiyong Yang
Since port id has changed from uint8_t to uint16_t in dpdk code, So update the change in related doc. Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang --- doc/guides/prog_guide/poll_mode_drv.rst | 2 +- doc/guides/prog_guide/rte_flow.rst

[dpdk-dev] [PATCH 6/8] test: fix port id type

2017-10-13 Thread Zhiyong Yang
Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang --- test/test-pipeline/init.c | 8 test/test/test_link_bonding.c | 2 +- test/test/test_link_bonding_mode4.c | 4 ++-- test/test/test_link_bonding_rssconf.c | 7 --- 4 files chang

[dpdk-dev] [PATCH 5/8] app: fix port id type

2017-10-13 Thread Zhiyong Yang
Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang --- app/pdump/main.c | 2 +- app/test-pmd/cmdline.c | 52 ++ 2 files changed, 28 insertions(+), 26 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main

[dpdk-dev] [PATCH 4/8] net/mrvl: fix port id type

2017-10-13 Thread Zhiyong Yang
port id should be defined as uint16_t. Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang --- drivers/net/mrvl/mrvl_qos.c | 2 +- drivers/net/mrvl/mrvl_qos.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mrvl/mrvl_qos.c b/drive

[dpdk-dev] [PATCH 3/8] net/fm10k: fix port id type

2017-10-13 Thread Zhiyong Yang
The variable "port" should be defined as uint16_t, fix it here. Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang --- drivers/net/fm10k/fm10k_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/n

[dpdk-dev] [PATCH 2/8] net/i40e: fix port id type

2017-10-13 Thread Zhiyong Yang
Some functions applied were still developed on top of uint8_t port_id, however port_id has been increased range to uint16_t. The patch fixes the issue. Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang --- drivers/net/i40e/i40e_ethdev.c | 2 +- drivers/net/i40e/

[dpdk-dev] [PATCH 1/8] net/bonding: fix port id type

2017-10-13 Thread Zhiyong Yang
Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang --- drivers/net/bonding/rte_eth_bond_pmd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 8cbcf6d7

  1   2   >