Re: [dpdk-dev] [PATCH] net/mlx5: release spinlock before return from function

2017-09-28 Thread Nélio Laranjeiro
Hi Pavlo, On Fri, Sep 29, 2017 at 03:03:56AM +0300, Pavlo Shcherbyna wrote: > If priv_ethtool_get_stats_n fails to retrieve statistics, lock > is not released. Next call of function, which uses the same > spinlock, will stuck trying to obtain it. > > This patch addresses the issue. > > Fixes: 4b

Re: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add API for configuration of queue region

2017-09-28 Thread Zhao1, Wei
Ok. > -Original Message- > From: Wu, Jingjing > Sent: Friday, September 29, 2017 1:05 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add API for > configuration of queue region > > General comments: > > You need to wrap i40e pri

[dpdk-dev] [PATCH v6 7/8] net/i40e: add cloud filter parsing function for GTP

2017-09-28 Thread Beilei Xing
This patch adds i40e_flow_parse_gtp_filter parsing function for GTP-C and GTP-U to support cloud filter. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.h | 2 + drivers/net/i40e/i40e_flow.c | 151 + 2 files changed, 153 insertions(+) diff

[dpdk-dev] [PATCH v6 8/8] net/i40e: enable cloud filter for GTP-C and GTP-U

2017-09-28 Thread Beilei Xing
This patch sets TEID of GTP-C and GTP-U as filter type by replacing existed filter types inner_mac and TUNNEL_KEY. This configuration will be set when adding GTP-C or GTP-U filter rules, and it will be invalid only by NIC core reset. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C and GTP-U

2017-09-28 Thread Beilei Xing
This patch adds FDIR support for GTP-C and GTP-U. The input set of GTP-C and GTP-U is TEID. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.h | 30 + drivers/net/i40e/i40e_fdir.c | 200 ++- drivers/net/i40e/i40e_flow.c | 263 ++

[dpdk-dev] [PATCH v6 1/8] mbuf: support GTP in software packet type parser

2017-09-28 Thread Beilei Xing
Add support of GTP-C and GTP-U tunnels in rte_net_get_ptype(). Signed-off-by: Beilei Xing Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ lib/librte_mbuf/rte_mbuf_ptype.h | 24 2 files changed, 26 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf

[dpdk-dev] [PATCH v6 5/8] net/i40e: finish integration FDIR with generic flow API

2017-09-28 Thread Beilei Xing
rte_eth_fdir_* structures are still used in FDIR functions. This patch adds i40e private FDIR related structures and functions to finish integration FDIR with generic flow API. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.h | 83 ++- drivers/net/i40e/i40e_fdir.c | 488 +

[dpdk-dev] [PATCH v6 2/8] net/i40e: update ptype and pctype info

2017-09-28 Thread Beilei Xing
Update new packet type and new pctype info when downloading profile. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 313 drivers/net/i40e/i40e_ethdev.h | 24 +++ drivers/net/i40e/rte_pmd_i40e.c | 6 +- 3 files changed, 342 insertions

[dpdk-dev] [PATCH v6 4/8] ethdev: add GTP items to support flow API

2017-09-28 Thread Beilei Xing
This patch adds GTP, GTPC and GTPU items for generic flow API, and also exposes item fields through the flow command. Signed-off-by: Beilei Xing Acked-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 40 ++ app/test-pmd/config.c |

[dpdk-dev] [PATCH v6 3/8] net/i40e: support RSS for new pctype

2017-09-28 Thread Beilei Xing
Enable RSS for new pctypes after downloading new profile. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index a1371dc..57d9bb3 100644

[dpdk-dev] [PATCH v6 0/8] GPT-C and GTP-U enabling

2017-09-28 Thread Beilei Xing
This patch set enables RSS/FDIR/cloud filter for GPT-C and GTP-U. It depends on Kirill's patch: http://www.dpdk.org/dev/patchwork/patch/29325/ v6 changes: - Reword description of GTP item and GTP structure, mainly support GTPv1, not include GTPv0 and GTPv2. v5 changes: - Fix code style. - R

Re: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add API for configuration of queue region

2017-09-28 Thread Wu, Jingjing
General comments: You need to wrap i40e private API by #ifdef RTE_LIBRTE_I40E_PMD #endif Otherwise it will cause compile error if I40E_PMD is not enable in config. You can refer to other implementation like cmd_ptype_mapping_get_parsed. Thanks Jingjing

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: get the supported pools for a port

2017-09-28 Thread santosh
Hi Olivier, On Monday 25 September 2017 10:52 PM, santosh wrote: > Hi Olivier, > > > On Monday 25 September 2017 08:37 AM, Olivier MATZ wrote: >>> +{ >>> + struct rte_eth_dev *dev; >>> + const char *tmp; >>> + >>> + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); >>> + >>> + if (pool =

Re: [dpdk-dev] [PATCH v5 1/3] net/i40e: queue region set and flush

2017-09-28 Thread Wu, Jingjing
> +static int > +i40e_vsi_update_queue_region_mapping(struct i40e_hw *hw, > + struct i40e_pf *pf) > +{ > + uint16_t i; > + struct i40e_vsi *vsi = pf->main_vsi; > + uint16_t queue_offset, bsf, tc_index; > + struct i40e_vsi_context ctxt; > + struct i40e_a

Re: [dpdk-dev] [PATCH v6 8/8] mempool: notify memory area to pool

2017-09-28 Thread santosh
Hi Olivier, On Monday 25 September 2017 11:18 PM, santosh wrote: > On Monday 25 September 2017 12:41 PM, Olivier MATZ wrote: >> On Thu, Sep 07, 2017 at 09:00:42PM +0530, Santosh Shukla wrote: >>> + * Mempool handler usually get notified once for the case of mempool get >>> full >>> + * range of

Re: [dpdk-dev] [PATCH v5 2/6] gso: add TCP/IPv4 GSO support

2017-09-28 Thread Jiayu Hu
Hi Mark, One comment is inline. Thanks, Jiayu On Thu, Sep 28, 2017 at 11:13:49PM +0100, Mark Kavanagh wrote: > From: Jiayu Hu > > This patch adds GSO support for TCP/IPv4 packets. Supported packets > may include a single VLAN tag. TCP/IPv4 GSO doesn't check if input > packets have correct chec

[dpdk-dev] [PATCH v5 0/3] net/i40e: API to configure queue regions for RSS

2017-09-28 Thread Wei Zhao
The patches mainly finish following functions: 1) Command line for input queue region configure parameters. 2) Set or flush queue region configutation. v2: -fix bug for packet into queue region code. -change code style for DPDK C programing. -change that "flowtype" name to " hw_flowtype " in stru

[dpdk-dev] [PATCH v5 3/3] doc/testpmd_app_ug: add doc info for queue region

2017-09-28 Thread Wei Zhao
Queue region only support PF by now, so this document is only for configuration of queue region on PF port. Signed-off-by: Wei Zhao --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 40 + 1 file changed, 40 insertions(+) diff --git a/doc/guides/testpmd_app_ug/testpmd

[dpdk-dev] [PATCH v5 2/3] app/testpmd: add API for configuration of queue region

2017-09-28 Thread Wei Zhao
This patch add a API configuration of queue region in rss. It can parse the parameters of region index, queue number, queue start index, user priority, traffic classes and so on. According to commands from command line, it will call i40e private API and start the process of set or flush queue regio

[dpdk-dev] [PATCH v5 1/3] net/i40e: queue region set and flush

2017-09-28 Thread Wei Zhao
This feature enable queue regions configuration for RSS in PF, so that different traffic classes or different packet classification types can be separated to different queues in different queue regions.This patch can set queue region range, it include queue number in a region and the index of first

Re: [dpdk-dev] [PATCH v5 4/8] ethdev: add GTP items to support flow API

2017-09-28 Thread Xing, Beilei
> -Original Message- > From: Sean Harte [mailto:sea...@gmail.com] > Sent: Thursday, September 28, 2017 9:43 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 4/8] ethdev: add GTP items to support > flow API > > On 28 September

Re: [dpdk-dev] How to use ixgbe module log?

2017-09-28 Thread Sam
My question is not clear. Actually ixgbevf driver in my system is kernel module, like this: [root@yf-mos-corp-host175 ~]# modinfo ixgbevf filename: /lib/modules/3.10.0-514.10.2.el7.mt20170307.x86_64/kernel/drivers/net/ethernet/intel/ixgbevf/ixgbevf.ko version:2.12.1-k-rh7.3 license:

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-28 Thread Yuanhan Liu
On Thu, Sep 28, 2017 at 01:50:20PM +, Tan, Jianfeng wrote: > > > +int > > > +rte_eal_primary_secondary_add_action(const char *action_name, > > > + rte_eal_primary_secondary_t action) > > > +{ > > > + struct action_entry *entry = malloc(sizeof(struct action_entry));

Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/secondary communication

2017-09-28 Thread Tan, Jianfeng
+ Reshma and Jan. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly > Sent: Thursday, September 28, 2017 11:30 PM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for > primary/secondary communication > > On 28-Sep-1

[dpdk-dev] [PATCH] net/mlx5: release spinlock before return from function

2017-09-28 Thread Pavlo Shcherbyna
If priv_ethtool_get_stats_n fails to retrieve statistics, lock is not released. Next call of function, which uses the same spinlock, will stuck trying to obtain it. This patch addresses the issue. Fixes: 4b2e6df26168 ("net/mlx5: fix extended statistics counters identification") Cc: shah...@mella

[dpdk-dev] [PATCH v5 2/6] gso: add TCP/IPv4 GSO support

2017-09-28 Thread Mark Kavanagh
From: Jiayu Hu This patch adds GSO support for TCP/IPv4 packets. Supported packets may include a single VLAN tag. TCP/IPv4 GSO doesn't check if input packets have correct checksums, and doesn't update checksums for output packets (the responsibility for this lies with the application). Additional

[dpdk-dev] [PATCH v5 6/6] doc: add GSO programmer's guide

2017-09-28 Thread Mark Kavanagh
Add programmer's guide doc to explain the design and use of the GSO library. Signed-off-by: Mark Kavanagh Signed-off-by: Jiayu Hu --- MAINTAINERS| 6 + .../generic_segmentation_offload_lib.rst | 256 +++ .../prog_guide/img/gso-output-s

[dpdk-dev] [PATCH v5 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO

2017-09-28 Thread Mark Kavanagh
From: Jiayu Hu This patch adds GSO support to the csum forwarding engine. Oversized packets transmitted over a GSO-enabled port will undergo segmentation (with the exception of packet-types unsupported by the GSO library). GSO support is disabled by default. GSO support may be toggled on a per-p

[dpdk-dev] [PATCH v5 3/6] gso: add VxLAN GSO support

2017-09-28 Thread Mark Kavanagh
This patch adds a framework that allows GSO on tunneled packets. Furthermore, it leverages that framework to provide GSO support for VxLAN-encapsulated packets. Supported VxLAN packets must have an outer IPv4 header (prepended by an optional VLAN tag), and contain an inner TCP/IPv4 packet (with an

[dpdk-dev] [PATCH v5 4/6] gso: add GRE GSO support

2017-09-28 Thread Mark Kavanagh
This patch adds GSO support for GRE-tunneled packets. Supported GRE packets must contain an outer IPv4 header, and inner TCP/IPv4 headers. They may also contain a single VLAN tag. GRE GSO doesn't check if all input packets have correct checksums and doesn't update checksums for output packets. Addi

[dpdk-dev] [PATCH v5 2/6] gso: add TCP/IPv4 GSO support

2017-09-28 Thread Mark Kavanagh
From: Jiayu Hu This patch adds GSO support for TCP/IPv4 packets. Supported packets may include a single VLAN tag. TCP/IPv4 GSO doesn't check if input packets have correct checksums, and doesn't update checksums for output packets (the responsibility for this lies with the application). Additional

[dpdk-dev] [PATCH v5 1/6] gso: add Generic Segmentation Offload API framework

2017-09-28 Thread Mark Kavanagh
From: Jiayu Hu Generic Segmentation Offload (GSO) is a SW technique to split large packets into small ones. Akin to TSO, GSO enables applications to operate on large packets, thus reducing per-packet processing overhead. To enable more flexibility to applications, DPDK GSO is implemented as a st

[dpdk-dev] [PATCH v5 0/6] Support TCP/IPv4, VxLAN and GRE GSO in DPDK

2017-09-28 Thread Mark Kavanagh
Generic Segmentation Offload (GSO) is a SW technique to split large packets into small ones. Akin to TSO, GSO enables applications to operate on large packets, thus reducing per-packet processing overhead. To enable more flexibility to applications, DPDK GSO is implemented as a standalone library.

[dpdk-dev] [PATCH v4 24/24] net/bnxt: add support for rx_queue_intr_enable/disable APIs

2017-09-28 Thread Ajit Khaparde
From: Somnath Kotur Implement Rx Queue interrupt enable/disable functions Signed-off-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- doc/guides/nics/features/bnxt.ini | 1 + drivers/net/bnxt/bnxt_ethdev.c| 54 +++ drivers/net/bnxt/bnxt_irq.h |

[dpdk-dev] [PATCH v4 22/24] net/bnxt: add dev_supported_ptypes_get dev_op

2017-09-28 Thread Ajit Khaparde
This patch adds support for dev_supported_ptypes_get Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 25 drivers/net/bnxt/bnxt_rxr.c| 43 ++ 2 files changed, 68 insertions(+) diff --git a/drivers/net/bnxt/bnx

[dpdk-dev] [PATCH v4 23/24] net/bnxt: add support for get/set EEPROM

2017-09-28 Thread Ajit Khaparde
From: Somnath Kotur Add support for get/set_eeprom, get_eeprom_length dev_ops. Defined the structures required to get/set the eeprom length/data in hsi_struct_defs hdr file along with implementation. Signed-off-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- doc/guides/nics/features/bnxt.i

[dpdk-dev] [PATCH v4 21/24] net/bnxt: prevent interrupt handler from accessing freed memory

2017-09-28 Thread Ajit Khaparde
In some cases the interrupt handler is accessing cpr, which has already been freed causing segfaults. This patch avoids such accesses. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c | 2 ++ drivers/net/bnxt/bnxt_irq

[dpdk-dev] [PATCH v4 20/24] net/bnxt: fix per queue stats display in xstats

2017-09-28 Thread Ajit Khaparde
While gathering per queue stats, we are overwriting some of the stats. This causes some of the counters in xstats to be incorrect. Fixes: 577d3dced0dc ("net/bnxt: refactor the query stats") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 38 -

[dpdk-dev] [PATCH v4 17/24] net/bnxt: add new HWRM structs to support flow filtering

2017-09-28 Thread Ajit Khaparde
HWRM structs added: hwrm_cfa_ntuple_filter_alloc, hwrm_cfa_ntuple_filter_free, hwrm_cfa_ntuple_filter_cfg, hwrm_cfa_em_flow_alloc, hwrm_cfa_em_flow_free, hwrm_cfa_em_flow_cfg Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 984 + 1 file c

[dpdk-dev] [PATCH v4 19/24] doc: update release notes

2017-09-28 Thread Ajit Khaparde
Update release doc briefly describing updates to bnxt PMD. Signed-off-by: Ajit Khaparde -- v1->v2: Update New Features section instead of Resolved Issues section. --- doc/guides/rel_notes/release_17_11.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/rele

[dpdk-dev] [PATCH v4 18/24] net/bnxt: add support for flow filter ops

2017-09-28 Thread Ajit Khaparde
This patch adds support for flow validate/create/destroy/flush, ethertype add/del ops Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. v2->v3: fix 32-bit builds. v3->v4: fix a clang error. --- drivers/net/bnxt/bnxt.h | 7 + drivers/net/bnxt/bnxt_ethdev.c | 202

[dpdk-dev] [PATCH v4 13/24] net/bnxt: set the hash_key_size

2017-09-28 Thread Ajit Khaparde
We were not setting the dev_info.hash_key_size. Setting it now. Fixes: 0a6d2a720078 ("net/bnxt: get device infos") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c

[dpdk-dev] [PATCH v4 14/24] net/bnxt: add support for rx_queue_count

2017-09-28 Thread Ajit Khaparde
add support for rx_queue_count dev_op Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. v2->v3: fix checkpatch warning. --- drivers/net/bnxt/bnxt_cpr.h| 6 +- drivers/net/bnxt/bnxt_ethdev.c | 46 ++ drivers/net/bnxt/bnxt_rxr.c

[dpdk-dev] [PATCH v4 16/24] net/bnxt: add support for tx_descriptor_status

2017-09-28 Thread Ajit Khaparde
add support for tx_descriptor_status dev_op Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. --- drivers/net/bnxt/bnxt_ethdev.c | 38 ++ drivers/net/bnxt/bnxt_txr.c| 3 +++ 2 files changed, 41 insertions(+) diff --git a/drivers/net/bn

[dpdk-dev] [PATCH v4 15/24] net/bnxt: add support for rx_descriptor_status

2017-09-28 Thread Ajit Khaparde
add support for rx_descriptor_status dev_op Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. --- drivers/net/bnxt/bnxt_ethdev.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_e

[dpdk-dev] [PATCH v4 12/24] net/bnxt: fix config rss update

2017-09-28 Thread Ajit Khaparde
We are not configuring the RSS settings updated by rss_hash_update(). Fix it. Fixes: cc0aa1edc10 ("net/bnxt: add RSS hash configuration") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 2 ++ drivers/net/bnxt/bnxt_ethdev.c | 4 drivers/net/bnxt/bnxt_rxq.c| 5 + 3

[dpdk-dev] [PATCH v4 09/24] net/bnxt: set checksum offload flags correctly

2017-09-28 Thread Ajit Khaparde
We are not correctly setting hw checksum offload for all the offload flags. This patch fixes that. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 32 +--- drivers/net/bnxt/bnxt_txr.h | 21 +

[dpdk-dev] [PATCH v4 11/24] net/bnxt: add support for xstats get by id

2017-09-28 Thread Ajit Khaparde
This patch adds support for xstats_get_by_id/xstats_get_names_by_id. Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. v2->v3: fix an issue observed while testing. --- drivers/net/bnxt/bnxt_ethdev.c | 11 + drivers/net/bnxt/bnxt_stats.c | 51 ++

[dpdk-dev] [PATCH v4 10/24] net/bnxt: update status of Rx IP/L4 CKSUM

2017-09-28 Thread Ajit Khaparde
update ol_flags with the appropriate status of IP/L4 cksum in Rx path. Fixes: 2eb53b134a ("net/bnxt: add initial Rx code") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 11 +++ drivers/net/bnxt/bnxt_rxr.h | 16 2 files changed, 27 insertions(+) diff --

[dpdk-dev] [PATCH v4 08/24] net/bnxt: fix usage of ETH_VMDQ_* flags

2017-09-28 Thread Ajit Khaparde
Map ETH_VMDQ_ACCEPT_HASH_UC to the promiscuous bit. Also, set ALLMULTI and MCAST when MCAST is set to ensure multicast traffic is received regardless of the VF driver list. Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- d

[dpdk-dev] [PATCH v4 07/24] net/bnxt: fix an issue with broadcast traffic

2017-09-28 Thread Ajit Khaparde
In bnxt_hwrm_cfa_l2_set_rx_mask, we are ignoring the previous setting of HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST and setting it again, thereby wrongly enabling Broadcast. Fixes: 244bc98b0da7 ("net/bnxt: set L2 Rx mask") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 +-- 1 f

[dpdk-dev] [PATCH v4 06/24] net/bnxt: fix rx handling and buffer allocation logic

2017-09-28 Thread Ajit Khaparde
Even when rx buffer allocation fails, we are wrongly updating the producer index. This patch fixes that. Also in case of a buffer allocation failure, reattempt buffer allocation before the rx handler exits. Fixes: 2eb53b134a ("net/bnxt: add initial Rx code") Signed-off-by: Ajit Khaparde --- dri

[dpdk-dev] [PATCH v4 05/24] net/bnxt: handle multi queue mode properly

2017-09-28 Thread Ajit Khaparde
We are currently not handling multi queue RX/RSS modes correctly. If RSS is not requested, create one VNIC per RXQ. Fixes: 6133f207970c ("net/bnxt: add Rx queue create/destroy") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 11 ++- drivers/net/bnxt/bnxt_rxq.c| 197 +

[dpdk-dev] [PATCH v4 02/24] net/bnxt: use 64-bits of address for vlan_table

2017-09-28 Thread Ajit Khaparde
We are wrongly using just 16 bits of address from rte_mem_virt2phy while filling the vlan table address instead of 64-bytes. Most likely a copy-paste error. Fixes: 36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 2

[dpdk-dev] [PATCH v4 04/24] net/bnxt: fix calculation of number of pools

2017-09-28 Thread Ajit Khaparde
The calculation for number of pools is wrong. We are wrongly overwriting the calculated value with ETH_64_POOLS. Accordingly fix the size of ff_pools array. Fix the log message as well. Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/

[dpdk-dev] [PATCH v4 00/24] bnxt patchset

2017-09-28 Thread Ajit Khaparde
This patch set includes some bug fixes and also adds support for new dev_ops like rx_queue_count, rx/tx_descriptor_status, get/set_eeprom and rx_queue_intr_enable/disable. It also adds support for the flow_filter funciton to add Flow API functionality. Please apply. Ajit Khaparde (22): net/bnxt

[dpdk-dev] [PATCH v4 01/24] net/bnxt: fix HWRM_*() macros and locking

2017-09-28 Thread Ajit Khaparde
Obtain the spinlock in HWRM_PREP() Eliminate two unnecessary arguments in HWRM_PREP(). Unlock the spinlock before returning in HWRM_ERROR_CHECK() Add new HWRM_UNLOCK() macro Update usage of the thre macros. Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments --- drivers/net/bnxt/

[dpdk-dev] [PATCH v4 03/24] net/bnxt: fix an issue with group id calculation

2017-09-28 Thread Ajit Khaparde
start_grp_id is incremented wrongly. Fixing it. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 0793

Re: [dpdk-dev] Issue with pktgen-dpdk replaying >1500bytes pcap on MCX4

2017-09-28 Thread Wiles, Keith
> On Sep 26, 2017, at 8:09 AM, Damien Clabaut > wrote: > > Hello Keith and thank you for your answer, > > The goal is indeed to generate as much traffic per machine as possible (we > use pktgen-dpdk to benchmark datacenter routers before putting them on > production). > > For this we use al

[dpdk-dev] [PATCH v5 1/3] ethdev: introduce Rx queue offloads API

2017-09-28 Thread Shahaf Shuler
Introduce a new API to configure Rx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the existing DEV_RX_OFFLOAD_* flags. To enable per-port offload, the offload should be set on both device

[dpdk-dev] [PATCH v5 2/3] ethdev: introduce Tx queue offloads API

2017-09-28 Thread Shahaf Shuler
Introduce a new API to configure Tx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the existing DEV_TX_OFFLOAD_* flags. To enable per-port offload, the offload should be set on both device

[dpdk-dev] [PATCH v5 3/3] doc: add details on ethdev offloads API

2017-09-28 Thread Shahaf Shuler
Add the programmers guide details on the new offloads API introduced by commits: commit 3ef4f4a50d2c ("ethdev: introduce Rx queue offloads API") commit a23fa10f3ea0 ("ethdev: introduce Tx queue offloads API") Signed-off-by: Shahaf Shuler Reviewed-by: John McNamara --- doc/guides/prog_guide/pol

[dpdk-dev] [PATCH v5 0/3] ethdev new offloads API

2017-09-28 Thread Shahaf Shuler
Tx offloads configuration is per queue. Tx offloads are enabled by default, and can be disabled using ETH_TXQ_FLAGS_NO* flags. This behaviour is not consistent with the Rx side where the Rx offloads configuration is per port. Rx offloads are disabled by default and enabled according to bit field

[dpdk-dev] [PATCH v3 3/3] net/mlx5: add Rx HW timestamp

2017-09-28 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by :Raslan Darawsheh Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 6 +- drivers/net/mlx5/mlx5_rxtx.c | 5 + drivers/net/mlx5/mlx5_rxtx.h | 3 ++- dri

[dpdk-dev] [PATCH v3 2/3] app/testpmd: add Rx HW timestamp

2017-09-28 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2 ++ ap

[dpdk-dev] [PATCH v3 1/3] ethdev: add Rx HW timestamp capability

2017-09-28 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- lib/librte_ether/rte_ethdev.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.h b/

Re: [dpdk-dev] [PATCH v3 18/24] net/bnxt: add support for flow filter ops

2017-09-28 Thread Ferruh Yigit
On 9/28/2017 3:13 PM, Ajit Khaparde wrote: > This patch adds support for flow validate/create/destroy/flush, > ethertype add/del ops > > Signed-off-by: Ajit Khaparde > -- > v1->v2: incorporate review comments. > v2->v3: fix 32-bit builds. <...> > +static struct rte_flow * > +bnxt_flow_create(st

Re: [dpdk-dev] [dpdk-stable] [PATCH v6] net/i40e: fix mirror rule reset when port is closed

2017-09-28 Thread Ferruh Yigit
On 9/26/2017 2:49 PM, Wu, Jingjing wrote: > > >> -Original Message- >> From: Dai, Wei >> Sent: Monday, September 25, 2017 2:37 PM >> To: Wu, Jingjing ; Xing, Beilei >> ; Ananyev, >> Konstantin >> Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org >> Subject: [PATCH v6] net/i40e: fix mirror ru

Re: [dpdk-dev] [PATCH v8] net/mlx5: support upstream rdma-core

2017-09-28 Thread Ferruh Yigit
On 9/26/2017 4:38 PM, Nelio Laranjeiro wrote: > From: Shachar Beiser > > This removes the dependency on specific Mellanox OFED libraries by > using the upstream rdma-core and linux upstream community code. > Both rdma-core upstream and Mellanox OFED are Linux user-space packages: > 1. Rdma-core

Re: [dpdk-dev] integration deadline for 17.11 features will move

2017-09-28 Thread Thomas Monjalon
21/09/2017 12:27, Thomas Monjalon: > As discussed with other maintainers, > we need to move the integration deadline by one week: > October 6 (instead of September 29) Update - the roadmap is updated with the new date: http://dpdk.org/dev/roadmap#dates

Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/secondary communication

2017-09-28 Thread Burakov, Anatoly
On 28-Sep-17 4:01 PM, Ananyev, Konstantin wrote: Hi Jianfeng, -Original Message- From: Tan, Jianfeng Sent: Thursday, September 28, 2017 2:56 PM To: dev@dpdk.org Cc: Richardson, Bruce ; Ananyev, Konstantin ; De Lara Guarch, Pablo ; tho...@monjalon.net; y...@fridaylinux.org; maxime.coq

Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/secondary communication

2017-09-28 Thread Ananyev, Konstantin
Hi Jianfeng, > -Original Message- > From: Tan, Jianfeng > Sent: Thursday, September 28, 2017 2:56 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Ananyev, Konstantin > ; De Lara Guarch, Pablo > ; tho...@monjalon.net; y...@fridaylinux.org; > maxime.coque...@redhat.com; mtetsu...@gmail.co

[dpdk-dev] [PATCH v3 18/24] net/bnxt: add support for flow filter ops

2017-09-28 Thread Ajit Khaparde
This patch adds support for flow validate/create/destroy/flush, ethertype add/del ops Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. v2->v3: fix 32-bit builds. --- drivers/net/bnxt/bnxt.h | 7 + drivers/net/bnxt/bnxt_ethdev.c | 202 +- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v3 16/24] net/bnxt: add support for tx_descriptor_status

2017-09-28 Thread Ajit Khaparde
add support for tx_descriptor_status dev_op Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. --- drivers/net/bnxt/bnxt_ethdev.c | 38 ++ drivers/net/bnxt/bnxt_txr.c| 3 +++ 2 files changed, 41 insertions(+) diff --git a/drivers/net/bn

[dpdk-dev] [PATCH v3 17/24] net/bnxt: add new HWRM structs to support flow filtering

2017-09-28 Thread Ajit Khaparde
HWRM structs added: hwrm_cfa_ntuple_filter_alloc, hwrm_cfa_ntuple_filter_free, hwrm_cfa_ntuple_filter_cfg, hwrm_cfa_em_flow_alloc, hwrm_cfa_em_flow_free, hwrm_cfa_em_flow_cfg Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 984 + 1 file c

[dpdk-dev] [PATCH v3 24/24] net/bnxt: add support for rx_queue_intr_enable/disable APIs

2017-09-28 Thread Ajit Khaparde
From: Somnath Kotur Implement Rx Queue interrupt enable/disable functions Signed-off-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- doc/guides/nics/features/bnxt.ini | 1 + drivers/net/bnxt/bnxt_ethdev.c| 54 +++ drivers/net/bnxt/bnxt_irq.h |

[dpdk-dev] [PATCH v3 22/24] net/bnxt: add dev_supported_ptypes_get dev_op

2017-09-28 Thread Ajit Khaparde
This patch adds support for dev_supported_ptypes_get Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 25 drivers/net/bnxt/bnxt_rxr.c| 43 ++ 2 files changed, 68 insertions(+) diff --git a/drivers/net/bnxt/bnx

[dpdk-dev] [PATCH v3 23/24] net/bnxt: add support for get/set EEPROM

2017-09-28 Thread Ajit Khaparde
From: Somnath Kotur Add support for get/set_eeprom, get_eeprom_length dev_ops. Defined the structures required to get/set the eeprom length/data in hsi_struct_defs hdr file along with implementation. Signed-off-by: Somnath Kotur Signed-off-by: Ajit Khaparde --- doc/guides/nics/features/bnxt.i

[dpdk-dev] [PATCH v3 21/24] net/bnxt: prevent interrupt handler from accessing freed memory

2017-09-28 Thread Ajit Khaparde
In some cases the interrupt handler is accessing cpr, which has already been freed causing segfaults. This patch avoids such accesses. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c | 2 ++ drivers/net/bnxt/bnxt_irq

[dpdk-dev] [PATCH v3 20/24] net/bnxt: fix per queue stats display in xstats

2017-09-28 Thread Ajit Khaparde
While gathering per queue stats, we are overwriting some of the stats. This causes some of the counters in xstats to be incorrect. Fixes: 577d3dced0dc ("net/bnxt: refactor the query stats") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 38 -

[dpdk-dev] [PATCH v3 15/24] net/bnxt: add support for rx_descriptor_status

2017-09-28 Thread Ajit Khaparde
add support for rx_descriptor_status dev_op Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. --- drivers/net/bnxt/bnxt_ethdev.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_e

[dpdk-dev] [PATCH v3 14/24] net/bnxt: add support for rx_queue_count

2017-09-28 Thread Ajit Khaparde
add support for rx_queue_count dev_op Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. v2->v3: fix checkpatch warning. --- drivers/net/bnxt/bnxt_cpr.h| 6 +- drivers/net/bnxt/bnxt_ethdev.c | 46 ++ drivers/net/bnxt/bnxt_rxr.c

[dpdk-dev] [PATCH v3 19/24] doc: update release notes

2017-09-28 Thread Ajit Khaparde
Update release doc briefly describing updates to bnxt PMD. Signed-off-by: Ajit Khaparde -- v1->v2: Update New Features section instead of Resolved Issues section. --- doc/guides/rel_notes/release_17_11.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/rele

[dpdk-dev] [PATCH v3 13/24] net/bnxt: set the hash_key_size

2017-09-28 Thread Ajit Khaparde
We were not setting the dev_info.hash_key_size. Setting it now. Fixes: 0a6d2a720078 ("net/bnxt: get device infos") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c

[dpdk-dev] [PATCH v3 12/24] net/bnxt: fix config rss update

2017-09-28 Thread Ajit Khaparde
We are not configuring the RSS settings updated by rss_hash_update(). Fix it. Fixes: cc0aa1edc10 ("net/bnxt: add RSS hash configuration") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 2 ++ drivers/net/bnxt/bnxt_ethdev.c | 4 drivers/net/bnxt/bnxt_rxq.c| 5 + 3

[dpdk-dev] [PATCH v3 11/24] net/bnxt: add support for xstats get by id

2017-09-28 Thread Ajit Khaparde
This patch adds support for xstats_get_by_id/xstats_get_names_by_id. Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments. v2->v3: fix an issue observed while testing. --- drivers/net/bnxt/bnxt_ethdev.c | 11 + drivers/net/bnxt/bnxt_stats.c | 51 ++

[dpdk-dev] [PATCH v3 10/24] net/bnxt: update status of Rx IP/L4 CKSUM

2017-09-28 Thread Ajit Khaparde
update ol_flags with the appropriate status of IP/L4 cksum in Rx path. Fixes: 2eb53b134a ("net/bnxt: add initial Rx code") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 11 +++ drivers/net/bnxt/bnxt_rxr.h | 16 2 files changed, 27 insertions(+) diff --

[dpdk-dev] [PATCH v3 09/24] net/bnxt: set checksum offload flags correctly

2017-09-28 Thread Ajit Khaparde
We are not correctly setting hw checksum offload for all the offload flags. This patch fixes that. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 32 +--- drivers/net/bnxt/bnxt_txr.h | 21 +

[dpdk-dev] [PATCH v3 08/24] net/bnxt: fix usage of ETH_VMDQ_* flags

2017-09-28 Thread Ajit Khaparde
Map ETH_VMDQ_ACCEPT_HASH_UC to the promiscuous bit. Also, set ALLMULTI and MCAST when MCAST is set to ensure multicast traffic is received regardless of the VF driver list. Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- d

[dpdk-dev] [PATCH v3 07/24] net/bnxt: fix an issue with broadcast traffic

2017-09-28 Thread Ajit Khaparde
In bnxt_hwrm_cfa_l2_set_rx_mask, we are ignoring the previous setting of HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST and setting it again, thereby wrongly enabling Broadcast. Fixes: 244bc98b0da7 ("net/bnxt: set L2 Rx mask") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 +-- 1 f

[dpdk-dev] [PATCH v3 06/24] net/bnxt: fix rx handling and buffer allocation logic

2017-09-28 Thread Ajit Khaparde
Even when rx buffer allocation fails, we are wrongly updating the producer index. This patch fixes that. Also in case of a buffer allocation failure, reattempt buffer allocation before the rx handler exits. Fixes: 2eb53b134a ("net/bnxt: add initial Rx code") Signed-off-by: Ajit Khaparde --- dri

[dpdk-dev] [PATCH v3 05/24] net/bnxt: handle multi queue mode properly

2017-09-28 Thread Ajit Khaparde
We are currently not handling multi queue RX/RSS modes correctly. If RSS is not requested, create one VNIC per RXQ. Fixes: 6133f207970c ("net/bnxt: add Rx queue create/destroy") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 11 ++- drivers/net/bnxt/bnxt_rxq.c| 197 +

[dpdk-dev] [PATCH v3 04/24] net/bnxt: fix calculation of number of pools

2017-09-28 Thread Ajit Khaparde
The calculation for number of pools is wrong. We are wrongly overwriting the calculated value with ETH_64_POOLS. Accordingly fix the size of ff_pools array. Fix the log message as well. Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/

[dpdk-dev] [PATCH v3 01/24] net/bnxt: fix HWRM_*() macros and locking

2017-09-28 Thread Ajit Khaparde
Obtain the spinlock in HWRM_PREP() Eliminate two unnecessary arguments in HWRM_PREP(). Unlock the spinlock before returning in HWRM_ERROR_CHECK() Add new HWRM_UNLOCK() macro Update usage of the thre macros. Signed-off-by: Ajit Khaparde -- v1->v2: incorporate review comments --- drivers/net/bnxt/

[dpdk-dev] [PATCH v3 00/24] bnxt patchset

2017-09-28 Thread Ajit Khaparde
This patch set includes some bug fixes and also adds support for new dev_ops like rx_queue_count, rx/tx_descriptor_status, get/set_eeprom and rx_queue_intr_enable/disable. It also adds support for the flow_filter funciton to add Flow API functionality. Please apply. Ajit Khaparde (22): net/bnxt

[dpdk-dev] [PATCH v3 03/24] net/bnxt: fix an issue with group id calculation

2017-09-28 Thread Ajit Khaparde
start_grp_id is incremented wrongly. Fixing it. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 0793

[dpdk-dev] [PATCH v3 02/24] net/bnxt: use 64-bits of address for vlan_table

2017-09-28 Thread Ajit Khaparde
We are wrongly using just 16 bits of address from rte_mem_virt2phy while filling the vlan table address instead of 64-bytes. Most likely a copy-paste error. Fixes: 36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 2

Re: [dpdk-dev] [PATCH 1/2] bus/dpaa: fix incorrect ccsr mem allocation

2017-09-28 Thread Shreyansh Jain
Hello Ferruh, On Thursday 28 September 2017 07:40 PM, Shreyansh Jain wrote: Fixes: 5ad2d123be48 "(bus/dpaa: introducing FMan configurations)" Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/base/fman/fman.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 2/2] config: fix DPAA PMD linking

2017-09-28 Thread Shreyansh Jain
Fixes: 41c52ee26c29 "(config: enable NXP DPAA PMD compilation)" Signed-off-by: Shreyansh Jain --- mk/rte.app.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 9e268ff..715c9e2 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -117,8 +117

[dpdk-dev] [PATCH 1/2] bus/dpaa: fix incorrect ccsr mem allocation

2017-09-28 Thread Shreyansh Jain
Fixes: 5ad2d123be48 "(bus/dpaa: introducing FMan configurations)" Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/base/fman/fman.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/bus/dpaa/base/fman/fman.c b/drivers/bus/dpaa/base/fman/fman.c index 2c6029e..d0

  1   2   3   >