[dpdk-dev] [PATCH] app/testpmd:fix invalid port id parameters

in parse_ringnuma_config/parse_portnuma_config functions,port_id should less than RTE_MAX_ETHPORTS,but port_id_is_invalid check assumes that port_id may be 255. Signed-off-by: Li Han --- app/test-pmd/parameters.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-

[dpdk-dev] Intel 82599ES send packets failed on dpdk-17.05.1 after traffic testing

hi, My test env is dell T430 server, NIC is intel 82599ES. I integrate my app with dpdk-17.05.1 version. after do some tcp traffic testing, app can receive packets from the 82599 NIC, but 82599 NIC send packets failed. But my app with dpdk-17.02 works well. If any change with ixgbe driver? or

Re: [dpdk-dev] [PATCH 0/7] Add Membership Library

On Mon, 21 Aug 2017 17:19:46 -0700 Yipeng Wang wrote: > This patch set implements two types of set-summaries, i.e., hash-table based > set-summary (HTSS) and Vector Bloom Filter (vBF). HTSS supports both the > non-cache and cache modes. The non-cache mode can incur a small chance of > false-posit

Re: [dpdk-dev] [PATCH 1/7] member: implement main API

On Mon, 21 Aug 2017 17:19:47 -0700 Yipeng Wang wrote: > +int > +rte_member_lookup(const void *ss, const void *key, > + MEMBER_SET_TYPE *set_id) > +{ > + const struct rte_member_setsum *setsum = ss; > + if (setsum == NULL || key == NULL || set_id == NULL) > + return

[dpdk-dev] [PATCH] net/virtio: fix a typo

Fixed a comment in struct virtionet_ctl, referring to the ring type Signed-off-by: Jay Zhou --- drivers/net/virtio/virtio_rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.h b/drivers/net/virtio/virtio_rxtx.h index 28f82d6..9811204 100644 -

[dpdk-dev] [PATCH] app/testpmd:fix invalid port id parameters

in parse_ringnuma_config/parse_portnuma_config functions,port_id should less than RTE_MAX_ETHPORTS,but port_id_is_invalid check assumes that port_id may be 255. Signed-off-by: Li Han --- app/test-pmd/parameters.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) mode change 100644 =>

Re: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to determine filesize

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Daniel Mrzyglod > Sent: Friday, August 18, 2017 10:18 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to > determine filesize

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO

Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, August 21, 2017 7:04 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Tan, Jianfeng > ; tho...@monjalon.net; Wu, Jingjing > ; Yao, Lei A > Subject: Re: [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO >

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO

Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, August 21, 2017 7:16 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Tan, Jianfeng > ; tho...@monjalon.net; Wu, Jingjing > ; Yao, Lei A > Subject: Re: [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO >

Re: [dpdk-dev] [PATCH v2 2/2] doc: update testpmd user guide for the heavyweight mode GRO

Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, August 21, 2017 7:04 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Tan, Jianfeng > ; tho...@monjalon.net; Wu, Jingjing > ; Yao, Lei A > Subject: Re: [PATCH v2 2/2] doc: update testpmd user guide for the > heavy

[dpdk-dev] [PATCH 6/7] test/member: add functional and perf tests

This patch adds functional and performance tests for membership library. Signed-off-by: Yipeng Wang --- test/test/Makefile | 3 + test/test/test_member.c | 550 test/test/test_member_perf.c | 643 +++ 3

[dpdk-dev] [PATCH 4/7] member: add AVX for HT mode

For key search, the signatures of all entries are compared against the signature of the key that is being looked up. Since all signatures are contguously put in a bucket, they can be compared with vector instructions (AVX2), achieving higher lookup performance. This patch adds AVX2 implementation

[dpdk-dev] [PATCH 5/7] member: enable the library

This patch enables the Membership library. Signed-off-by: Yipeng Wang --- MAINTAINERS| 7 +++ config/common_base | 5 + lib/librte_member/Makefile | 2 ++ mk/rte.app.mk | 2 ++ 4 files changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS

[dpdk-dev] [PATCH 3/7] member: implement vBF mode

Bloom Filter (BF) [1] is a well-known space-efficient probabilistic data structure that answers set membership queries. Vector of Bloom Filters (vBF) is an extension to traditional BF that supports multi-set membership testing. Traditional BF will return found or not-found for each key. vBF will al

[dpdk-dev] [PATCH 2/7] member: implement HT mode

One of the set-summray structure is hash-table based set-summary (HTSS). One example is cuckoo filter [1]. Comparing to a traditional hash table, HTSS has a much more compact structure. For each element, only one signature and its corresponding set ID is stored. No key comparison is required duri

[dpdk-dev] [PATCH 1/7] member: implement main API

Membership library is an extension and generalization of a traditional filter (for example Bloom Filter) structure. In general, the Membership library is a data structure that provides a "set-summary" and responds to set-membership queries of whether a certain element belongs to a set(s). A members

[dpdk-dev] [PATCH 0/7] Add Membership Library

DPDP Membership Library provides an API that can be used by many DPDK applications to conduct one or more set-membership tests (we mention some possible use cases below, but interested readers can refer to [1] for a wider survey of use cases). The basic functionalities of the Membership Library in

[dpdk-dev] [PATCH v2 2/2] igb_uio: conform to coding conventions

Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index 0a2f993..bd94eb4 100644 --- a/lib/librte_eal/linuxapp/igb_uio/

[dpdk-dev] [PATCH v2 1/2] igb_uio: MSI IRQ mode, irq enable/disable refactored

This patch adds MSI IRQ mode and in a way, that should also work on older kernel versions. The base for my patch was an attempt to do this in cf705bc36c which was later reverted in d8ee82745a. Compilation was tested on Linux 3.2, 4.10 and 4.12. MSI(X) setup was already using pci_alloc_irq_vectors

[dpdk-dev] [PATCH] igb_uio: MSI IRQ mode, irq enable/disable refactored

This patch adds MSI IRQ mode and in a way, that should also work on older kernel versions. The base for my patch was an attempt to do this in cf705bc36c which was later reverted in d8ee82745a. Compilation was tested on Linux 3.2, 4.10 and 4.12. MSI(X) setup was already using pci_alloc_irq_vectors

Re: [dpdk-dev] [dpdk-stable] 16.11.3 (LTS) patches review and test

On 08/21/2017 10:23 AM, Yuanhan Liu wrote: > On Mon, Aug 21, 2017 at 09:23:24AM +0100, Ferruh Yigit wrote: I think this one should go in too, as OVS hits this and writes back the wrong watermark value to the shared register which can cause problems for other ports. I've applied and t

Re: [dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close

Hi Dariusz, On Mon, Aug 21, 2017 at 11:34:42AM +0200, Dariusz Stojaczyk wrote: When user receives destroy_device signal, he does not know *why* that event happened. He does not differ between socket shutdown and virtio processing pause. User could completely delete device during transition from

[dpdk-dev] [RFC] remove redundant file header note

Some of the "All rights reserved." note looks like duplicate, there is one for each copyright note in the same line, and extra one after the copyright notes. Sample is in below patch. Although this looks like a duplication, I am not sure if this is a legal requirement, or legally has a meaning. A

Re: [dpdk-dev] [PATCH] nfp: support new medatada api

On Fri, Aug 18, 2017 at 4:51 PM, Ferruh Yigit wrote: > On 8/11/2017 3:30 PM, Alejandro Lucero wrote: > > We need to support how metadata was handled and the new api, which will > > allow to work with different metadata types and data dynamically. > > What is the API mentioned? > > This is a inter

Re: [dpdk-dev] [PATCH] nfp: handle packets with length 0 as usual ones

On 8/21/2017 2:08 PM, Alejandro Lucero wrote: > > > On Mon, Aug 21, 2017 at 11:34 AM, Ferruh Yigit > wrote: > > On 8/18/2017 5:23 PM, Alejandro Lucero wrote: > > > > > > On Fri, Aug 18, 2017 at 4:10 PM, Ferruh Yigit

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix parameters parsing

On Mon, Aug 21, 2017 at 12:02:44PM +, Matan Azrad wrote: > Hi Gaetan > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Monday, August 21, 2017 12:34 PM > > To: Matan Azrad > > Cc: dev@dpdk.org; sta...@dpdk.org > > Subject: Re: [PATCH v2] net/fai

Re: [dpdk-dev] [PATCH] nfp: handle packets with length 0 as usual ones

On Mon, Aug 21, 2017 at 11:34 AM, Ferruh Yigit wrote: > On 8/18/2017 5:23 PM, Alejandro Lucero wrote: > > > > > > On Fri, Aug 18, 2017 at 4:10 PM, Ferruh Yigit > > wrote: > > > > On 8/11/2017 11:05 AM, Alejandro Lucero wrote: > > > A DPDK app could, whateve

[dpdk-dev] [PATCH v2 15/15] docs: add notes on service cores API updates

Add a section on the service cores API changes to 17.11 release notes. Suggested-by: Neil Horman Signed-off-by: Harry van Haaren --- doc/guides/rel_notes/release_17_11.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel

[dpdk-dev] [PATCH v2 13/15] service: add component runstate

This commit adds a new flag that the component (or "backend") can use to indicate readyness. The service function callback will not be called until the component sets itself as ready. The use-case behind adding this feature is eg: a service that requires configuration before it can start. Any serv

[dpdk-dev] [PATCH v2 14/15] service: clarify documentation for register

This commit adds a section to the service register function to make it clear that registering a service, must not configure service-cores (eg: adding lcores or changing mappings). Signed-off-by: Harry van Haaren --- lib/librte_eal/common/include/rte_service_component.h | 9 +++-- 1 file chan

[dpdk-dev] [PATCH v2 12/15] service: reset core call stats on dump

This aligns with the service stats, which are currently also reset on read. A generic statistics API would be helpful for the service library in future. Signed-off-by: Harry van Haaren --- lib/librte_eal/common/rte_service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib

[dpdk-dev] [PATCH v2 11/15] service: fix lcore in wait state in lcore add

This commit ensures that after an lcore is added, that it is in the WAIT state. Previously, adding an lcore did not ensure that the core was ready for being relaunch, which would cause errors during lcore_start(). Now that the lcore is ensured to be in WAIT state by the lcore_add() function, this i

[dpdk-dev] [PATCH v2 10/15] service: fix return values of functions to 0 or 1

Previously to this commit, the return value of the following functions was the mask value, instead of a neat 0 or 1. This commit fixes this using the "!!" trick, to force the number to 1 instead of the bitmask value itself, bringing the return value in line with the function documentation. Fixes:

[dpdk-dev] [PATCH v2 09/15] service: fix loops to always scan all services

Services can be registered and unregistered, and "holes" can appear in the contiguous array of services if a service is unregistered. As a result, we must never iterate to the number of services (as counted by rte_service_count), instead scanning the service array and checking if the service is val

[dpdk-dev] [PATCH v2 08/15] service: fix and refactor atomic service accesses

This commit fixes an issue in the service runner function, where the atomic value was not cleared on exiting the service function. This resulted in future attempts to run the service to appear like the function was running, however it was in reality deadlocked. This commit refactors the atomic han

[dpdk-dev] [PATCH v2 07/15] service: rework get by name function to use id

This commit reworks the service_get_by_name() function to accept an integer, and removes the service_get_by_id() function. All functions now accept an integer argument representing the service, so it is no longer required to expose the service_spec pointers to the application. Signed-off-by: Harr

[dpdk-dev] [PATCH v2 05/15] service: rework service stats functions

This commit reworks the statistics functions to use integer ids for services instead of pointers. Passing UINT32_MAX to the dump function prints all info, similar to passing NULL previously. Signed-off-by: Harry van Haaren --- lib/librte_eal/common/include/rte_service.h | 14 -- lib/

[dpdk-dev] [PATCH v2 06/15] service: rework unregister api to use integers

This commit reworks the unregister API to accept an integer. Signed-off-by: Harry van Haaren --- v2: - Renamed unregister to rte_service_component_unregister for consistency in APIs for components. --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 +- .../common/include/rte_service

[dpdk-dev] [PATCH v2 04/15] service: rework service start stop to runstate

This commit reworks the API to move from two separate start and stop functions, to a "runstate" API which allows setting the runstate. The is_running API is replaced with an function to query the runstate. The runstate functions take a id value for service. Unit tests and the eventdev sw pmd are up

[dpdk-dev] [PATCH v2 03/15] service: rework register to return service id

This commit reworks the service register function to accept an extra parameter. The parameter is a uint32_t *, which when provided will be set to the integer service_id that the newly registered service is represented by. This is useful for services that wish to validate settings at a later point

[dpdk-dev] [PATCH v2 02/15] service: rework lcore to service map functions

This commit updates the APIs exposed to map service cores and services. The previous APIs required a pointer to a service, and used two separate functions for enable and disable. The new API uses an integer ID for the service and has a parameter for map or unmap. Unit tests are updated and passing,

[dpdk-dev] [PATCH v2 01/15] service: rework probe and get name to use ids

This commit adds a macro to easily validate a service ID, and then lookup the service pointer, or return a user-specified error code. This marco will be heavily used in the following patches as it will be ID based instead of pointer-based. The probe_capability function is reworked to use an intege

[dpdk-dev] [PATCH v2 00/15] service: API improvements and updates

This patchset reworks the service apis to be more user friendly. In particular, the various rte_service_* functions now take an integer id parameter instead of a service pointer. This both reduces the API surface (no service_get_from_id()), and allows easier debugging (gdb function calls with integ

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/failsafe: fix tx sub device deactivating

On 8/16/2017 3:19 PM, Matan Azrad wrote: > The corrupted code couldn't recognize that all sub devices > were not ready for tx traffic when failsafe PMD was trying > to switch device because of an unreachable condition using. > > Hence, the current tx sub device variable was not updated > correctly

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix packet count for PF

On 8/20/2017 9:05 PM, Qi Zhang wrote: > Previously, for PF statistics we use VSI register for packet count > but use port's register for packet bytes, that cause inconsistent > situation of PF statistics when some VF is active, since it will > cover VF's packet bytes but not packet count. > The pa

[dpdk-dev] [RFC] net/mlx5: support count flow action

Support count flow action. This patch is basic design only, do to missing features on the verbs driver. As soon as the features will be implemented on the verbs driver this will be updated and rebased on top of dpdk.org/ml/archives/dev/2017-August/072351.html (The verbs driver should be ready sta

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix parameters parsing

Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Monday, August 21, 2017 12:34 PM > To: Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2] net/failsafe: fix parameters parsing > > Hi Matan, > > On Sun, Aug 20, 2017 at 01:

[dpdk-dev] [PATCH] net/igb: add i210 flashless device ids

This patch adds two missing device IDs for Intel i210 chips in flashless mode. Copper flashless mode was tested on a PC Engines APU2C4 board. Signed-off-by: Markus Theil --- drivers/net/e1000/igb_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/driv

[dpdk-dev] errors while working with dpdk cuckoo hash

Hi, I am running an application over dpdk ver 16.04. My application massively inserting and deleting from a hash table using a key that can be very similar for many instances. I noticed that in some cases I am unable to find an entry while I am certain it was inserted successfully. I wrote a test

Re: [dpdk-dev] [PATCH] doc/failsafe: fix typos in nics guide

On 8/18/2017 12:23 PM, Gaëtan Rivet wrote: > On Fri, Aug 18, 2017 at 06:57:48AM -0400, Yong Wang wrote: Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: sta...@dpdk.org >> Signed-off-by: Yong Wang > > Acked-by: Gaetan Rivet Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO

On 8/17/2017 10:08 AM, Jiayu Hu wrote: > The GRO library provides two reassembly modes: lightweight mode and > heavyweight mode. This patch is to support the heavyweight mode in > csum forwarding engine. > > With the command "set port gro (heavymode|lightmode) (on|off)", > users can select the li

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO

On 8/17/2017 10:08 AM, Jiayu Hu wrote: > The GRO library provides two reassembly modes: lightweight mode and > heavyweight mode. This patch is to support the heavyweight mode in > csum forwarding engine. > > With the command "set port gro (heavymode|lightmode) (on|off)", > users can select the li

Re: [dpdk-dev] [PATCH v2 2/2] doc: update testpmd user guide for the heavyweight mode GRO

On 8/17/2017 10:08 AM, Jiayu Hu wrote: > This patch is to update testpmd user guide for the heavyweight mode GRO. Documentation can be part of the implementation patch. It is good to split patches logically, but I don't see the benefit of splitting patch as documentation and implementation. > >

Re: [dpdk-dev] [RFC PATCH 1/4] rte_security: API definitions

Hi Boris, On 8/21/2017 4:02 PM, Boris Pismenny wrote: For drafting, we have opened this github repository: https://github.com/Mellanox/dpdk-next-crypto Akhil/Hemant could you please push your rte_security patches there? I have pushed the patches on this tree. Regards, Akhil

Re: [dpdk-dev] [PATCH] nfp: handle packets with length 0 as usual ones

On 8/18/2017 5:23 PM, Alejandro Lucero wrote: > > > On Fri, Aug 18, 2017 at 4:10 PM, Ferruh Yigit > wrote: > > On 8/11/2017 11:05 AM, Alejandro Lucero wrote: > > A DPDK app could, whatever the reason, send packets with size 0. > > The PMD is not sendin

Re: [dpdk-dev] [RFC PATCH 1/4] rte_security: API definitions

For drafting, we have opened this github repository: https://github.com/Mellanox/dpdk-next-crypto Akhil/Hemant could you please push your rte_security patches there? > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, August 18, 2017 12:17 > To: Heman

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix parameters parsing

Hi Matan, On Sun, Aug 20, 2017 at 01:07:23AM +0300, Matan Azrad wrote: > The corrupted code used wrongly snprintf return value as the > number of characters actually copied, in spite of the meanning > is the number of characters which would be generated for the > given input. > > It caused to rem

Re: [dpdk-dev] [dpdk-stable] 16.11.3 (LTS) patches review and test

On Mon, Aug 21, 2017 at 09:23:24AM +0100, Ferruh Yigit wrote: > >> I think this one should go in too, as OVS hits this and writes back the > >> wrong watermark value to the shared register which can cause problems > >> for other ports. I've applied and tested it with DPDK 16.11. > >> > >> commit 0e

Re: [dpdk-dev] [dpdk-stable] 16.11.3 (LTS) patches review and test

On 8/21/2017 4:40 AM, Yuanhan Liu wrote: > On Fri, Aug 18, 2017 at 06:29:02PM +0100, Kevin Traynor wrote: >> On 08/18/2017 11:45 AM, Yuanhan Liu wrote: >>> Hi all, >>> >>> Here is a list of patches targeted for LTS release 16.11.3. Please >>> help review and test. The planned date for the final rel

[dpdk-dev] [PATCH] app/testpmd:fix invalid port id parameters

in parse_ringnuma_config/parse_portnuma_config functions,port_id should less than RTE_MAX_ETHPORTS,but port_id_is_invalid check assumes that port_id may be 255. Signed-off-by: Li Han --- app/test-pmd/parameters.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) mode change 100644 =>

[dpdk-dev] [PATCH] net/ixgbe: fix mapping of user priority to TC

This patch fixes the mapping of user priority to traffic class in Rx/Tx path of DCB configuration. Each DCB traffic class should include all user priorities mapping to it in both Rx and Tx path. Fixes: 0807f80d35d0 ("ixgbe: DCB / flow control") Cc: sta...@dpdk.org Signed-off-by: Wei Dai --- dri

[dpdk-dev] [PATCH 1/2] net/mlx5: replace memory barrier type

From: Shahaf Shuler The reason for the requirement of a barrier between the txq writes and the doorbell record writes is to avoid a case where the device reads the doorbell record's new value before the txq writes are flushed to memory. The current use of rte_wmb is not necessary, and can be rep

[dpdk-dev] [PATCH 0/2] mlx5 high latency observed on send operations

When measuring latency when running a latency critical workload on mlx5 pmd drivers we noticed high latency can occur due to delayed doorbell record update flush. This can be reproduced using the simple program [1] against testpmd macswap fwd mode. This utility sends a raw ethernet frame to the dp

[dpdk-dev] [PATCH 2/2] net/mlx5: don't map doorbell register to write combining

From: Shahaf Shuler By default, Verbs maps the doorbell register to write combining. Working with write combining is useful for drivers which use blue flame for the doorbell write. Since mlx5 PMD uses only doorbells and write combining mapping requires an extra memory barrier to flush the doorbe