Re: [dpdk-dev] [PATCH] net/failsafe: safer subdev iterator

2017-08-17 Thread Stephen Hemminger
On Thu, 17 Aug 2017 17:52:09 +0200 Gaetan Rivet wrote: > The sub_device iterator macro should follow the general gist of the > tailq API for an easier understanding and safer use. > > Once the loop has finished, the iterator should be set to NULL. > If no sub_device was iterated upon, the iterat

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: new API to add VF MAC address from PF

2017-08-17 Thread Stephen Hemminger
On Fri, 18 Aug 2017 02:33:42 +0800 Wenzhuo Lu wrote: > Currently, rte_eth_dev_mac_addr_add is used by a > testpmd CLI to add a MAC address for VF. But the > parameter 'pool' of this API means the VMDq pool, > not VF. > So, it's wrong to use it to add the VF MAC address. > This patch provides a ne

Re: [dpdk-dev] [PATCH] net/failsafe: fix parameters parsing

2017-08-17 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, August 17, 2017 7:25 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org > Subject: Re: [PATCH] net/failsafe: fix parameters parsing > > On Thu, Aug 17, 2017 at 03:54:23PM

[dpdk-dev] [PATCH v3 2/2] app/testpmd: fix wrong API of adding VF MAC

2017-08-17 Thread Wenzhuo Lu
When adding a VF MAC address, rte_eth_dev_mac_addr_add is called. It's not right, because this API is used to add a MAC address for a VMDq pool not a VF. Although it can work on ixgbe as VMDq pool and VF mean the same thing on ixgbe. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 19

[dpdk-dev] [PATCH v3 1/2] net/i40e: new API to add VF MAC address from PF

2017-08-17 Thread Wenzhuo Lu
Currently, rte_eth_dev_mac_addr_add is used by a testpmd CLI to add a MAC address for VF. But the parameter 'pool' of this API means the VMDq pool, not VF. So, it's wrong to use it to add the VF MAC address. This patch provides a new API that can be used to add VF MAC address on i40e. Signed-off-b

[dpdk-dev] [PATCH v3 0/2] fix adding VF MAC in testpmd

2017-08-17 Thread Wenzhuo Lu
In testpmd, it's wrong to call rte_eth_dev_mac_addr_add to add a MAC address for a VF. Because this API is used to add a MAC address for a VMDq pool. v3: - split the patch to 2. One for adding a new API. One for fixing the CLI. Wenzhuo Lu (2): net/i40e: new API to add VF MAC address from PF

Re: [dpdk-dev] [PATCH] net/failsafe: fix parameters parsing

2017-08-17 Thread Gaëtan Rivet
On Thu, Aug 17, 2017 at 03:54:23PM +, Matan Azrad wrote: > > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Thursday, August 17, 2017 6:26 PM > > To: Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org > > Subject: Re: [PATCH] net/fail

[dpdk-dev] [RFC PATCH 1/1] eventtimer: introduce event timer wheel

2017-08-17 Thread Jerin Jacob
Some of the NPU class of networking hardwares has timer hardware where the user can arm and cancel the event timer. On the expiry of the timeout time, the hardware will post the notification as an event to eventdev HW, Instead of calling a callback like CPU based timer scheme. It enables, high reso

[dpdk-dev] [RFC PATCH 0/1] eventtimer: introduce event timer wheel

2017-08-17 Thread Jerin Jacob
Some of the NPU class of networking hardwares has timer hardware where the user can arm and cancel the event timer. On the expiry of the timeout time, the hardware will post the notification as an event to eventdev HW, Instead of calling a callback like CPU based timer scheme. It enables, highresol

Re: [dpdk-dev] [PATCH] net/failsafe: fix parameters parsing

2017-08-17 Thread Matan Azrad
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, August 17, 2017 6:26 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org > Subject: Re: [PATCH] net/failsafe: fix parameters parsing > > Hi Matan, > > Thanks for spotting the bug.

[dpdk-dev] [PATCH] net/failsafe: safer subdev iterator

2017-08-17 Thread Gaetan Rivet
The sub_device iterator macro should follow the general gist of the tailq API for an easier understanding and safer use. Once the loop has finished, the iterator should be set to NULL. If no sub_device was iterated upon, the iterator should still be NULL. Signed-off-by: Gaetan Rivet --- drivers

Re: [dpdk-dev] [PATCH] net/failsafe: fix parameters parsing

2017-08-17 Thread Gaëtan Rivet
Hi Matan, Thanks for spotting the bug. On Thu, Aug 17, 2017 at 05:19:41PM +0300, Matan Azrad wrote: > The corrupted code used wrongly snprintf return value as the > number of characters actually copied, in spite of the meanning > is the number of characters which would be generated for the > give

Re: [dpdk-dev] [RFCv2 00/40] Building DPDK with meson and ninja

2017-08-17 Thread Luca Boccassi
On Thu, 2017-08-17 at 16:10 +0200, Marco Varlese wrote: > Hi Bruce, > > On Mon, 2017-08-14 at 10:51 +0100, Bruce Richardson wrote: > > Following on from previous RFC [http://dpdk.org/dev/patchwork/patch > > /25104/] > > here is a second draft implementation for building DPDK with meson > > and > >

Re: [dpdk-dev] [PATCH v6 08/12] linuxapp/eal: auto detect iova mode

2017-08-17 Thread santosh
On Wednesday 16 August 2017 11:08 PM, Aaron Conole wrote: > Santosh Shukla writes: > >> - Moving late bus scanning to up..just after eal_parsing. >> - Auto detect iova mapping mode, based on the result of >> rte_bus_scan_iommu_class. >> >> Signed-off-by: Santosh Shukla >> Signed-off-by: Jerin

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: remove pdentic pragma

2017-08-17 Thread Ferruh Yigit
On 8/1/2017 1:09 PM, Nelio Laranjeiro wrote: > Those are useless since DPDK headers have been cleaned up. > > Signed-off-by: Nelio Laranjeiro > Acked-by: Shahaf Shuler <...> > > -/* DPDK headers don't like -pedantic. */ > -#ifdef PEDANTIC > -#pragma GCC diagnostic ignored "-Wpedantic" > -#en

Re: [dpdk-dev] [PATCH 3/5] net/mlx5: fix non working secondary process by removing it

2017-08-17 Thread Ferruh Yigit
On 8/1/2017 1:09 PM, Nelio Laranjeiro wrote: > Secondary process is a copy/paste of the mlx4 drivers, it was never > tested and it even segfault at the secondary process start in the > mlx5_pci_probe(). Does this means multi process support for mlx5 broken with this patch? If so features file and

Re: [dpdk-dev] [PATCH 4/5] net/mlx5: remove multiple drop RSS queues

2017-08-17 Thread Ferruh Yigit
On 8/1/2017 1:09 PM, Nelio Laranjeiro wrote: > Since MLNX_OFED 4.1 this code is no more useful. Can you please elaborate what is changed with MLNX_OFED 4.1? Also how one can know his MLNX_OFED version? > > Signed-off-by: Nelio Laranjeiro > Acked-by: Shahaf Shuler <...>

Re: [dpdk-dev] [PATCH 5/5] net/mlx5: remove old MLNX_OFED 3.3 verification

2017-08-17 Thread Ferruh Yigit
On 8/1/2017 1:09 PM, Nelio Laranjeiro wrote: > This version of MLNX_OFED is no more supported. Does it make sense to document minimum supported MLNX_OFED version? > > Signed-off-by: Nelio Laranjeiro > Acked-by: Shahaf Shuler <...>

[dpdk-dev] [PATCH] net/failsafe: fix parameters parsing

2017-08-17 Thread Matan Azrad
The corrupted code used wrongly snprintf return value as the number of characters actually copied, in spite of the meanning is the number of characters which would be generated for the given input. It caused to remain zerod bytes between the failsafe command line non sub device parameters indicate

Re: [dpdk-dev] [RFCv2 00/40] Building DPDK with meson and ninja

2017-08-17 Thread Marco Varlese
Hi Bruce, On Mon, 2017-08-14 at 10:51 +0100, Bruce Richardson wrote: > Following on from previous RFC [http://dpdk.org/dev/patchwork/patch/25104/] > here is a second draft implementation for building DPDK with meson and > ninja. While still not building all of DPDK, and needing patch cleanup so >

Re: [dpdk-dev] [PATCH v2] net/i40e: new API to add VF MAC address from PF

2017-08-17 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, August 17, 2017 9:05 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Stephen Hurd ; Ajit Khaparde > > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: new API to add VF MAC address > from PF >

Re: [dpdk-dev] [PATCH v2] net/i40e: new API to add VF MAC address from PF

2017-08-17 Thread Ferruh Yigit
On 7/25/2017 3:09 PM, Wenzhuo Lu wrote: > Currently, on i40e the parameter 'pool' of API > rte_eth_dev_mac_addr_add means the VMDq pool, not VF. The argument "pool" in rte_eth_dev_mac_addr_add() IS VMDq pool. This is not just for i40e, this is by API definition. > So, it's wrong to use it to set

Re: [dpdk-dev] [PATCH v6 09/12] bsdapp/eal: auto detect iova mapping mode

2017-08-17 Thread Aaron Conole
Santosh Shukla writes: > - Moving late bus scanning to up..just after eal_parsing. > - Mapping mode would be default for bsdapp. It supports > only one pass through mode (RTE_KDRV_NIC_UIO) > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob > Reviewed-by: Maxime Coquelin > --- Sa

Re: [dpdk-dev] [PATCH v6 03/12] eal/pci: get iommu class

2017-08-17 Thread Aaron Conole
Santosh Shukla writes: > Introducing rte_pci_get_iommu_class API which helps to get iommu class > of PCI device on the bus and returns preferred iova mapping mode for > PCI bus. > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob > Reviewed-by: Maxime Coquelin > --- I think 3/12 an

Re: [dpdk-dev] [PATCH v6 01/12] eal/pci: introduce PCI driver iova as va flag

2017-08-17 Thread Aaron Conole
Santosh Shukla writes: > Introducing RTE_PCI_DRV_IOVA_AS_VA flag. Flag used when driver needs > to operate in iova=va mode. > > Why driver need iova=va mapping? > > On NPU style co-processors like Octeontx, the buffer recycling has been > done in HW, unlike SW model. Here is the data flow: > 1) O

[dpdk-dev] [PATCH] vfio: refactor PCI BAR mapping

2017-08-17 Thread Jonas Pfefferle
Split pci_vfio_map_resource for primary and secondary processes. Save all relevant mapping data in primary process to allow the secondary process to perform mappings. Signed-off-by: Jonas Pfefferle --- lib/librte_eal/common/include/rte_pci.h| 7 + lib/librte_eal/linuxapp/eal/eal_pci_vfio.c

Re: [dpdk-dev] eth_fm10k_dev_init failed as there is no Glort update

2017-08-17 Thread Chen, Jing D
Some corretness. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chen, Jing D > Sent: Thursday, August 17, 2017 5:06 PM > To: Krishna S > Cc: dev@dpdk.org; Wang, Xiao W > Subject: Re: [dpdk-dev] eth_fm10k_dev_init failed as there is no Glort update > > Hi, >

[dpdk-dev] [PATCH v2 2/2] doc: update testpmd user guide for the heavyweight mode GRO

2017-08-17 Thread Jiayu Hu
This patch is to update testpmd user guide for the heavyweight mode GRO. Signed-off-by: Jiayu Hu --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 37 +++-- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/g

[dpdk-dev] [PATCH v2 0/2] Support the Heavyweight Mode GRO in Testpmd

2017-08-17 Thread Jiayu Hu
The GRO library provides two reassembly modes: lightweight mode and heavyweight mode. The lightweight mode has been supported by testpmd. This patchset is to support the heavyweight mode in testpmd. Change log == v2: - use "set" and "show" as the root level command - add a new command to s

[dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO

2017-08-17 Thread Jiayu Hu
The GRO library provides two reassembly modes: lightweight mode and heavyweight mode. This patch is to support the heavyweight mode in csum forwarding engine. With the command "set port gro (heavymode|lightmode) (on|off)", users can select the lightweight mode or the heavyweight mode to use. With

Re: [dpdk-dev] eth_fm10k_dev_init failed as there is no Glort update

2017-08-17 Thread Chen, Jing D
Hi, > -Original Message- > From: Krishna S [mailto:k.shar...@gmail.com] > Sent: Thursday, August 17, 2017 5:02 PM > To: Chen, Jing D > Cc: dev@dpdk.org; Wang, Xiao W > Subject: Re: eth_fm10k_dev_init failed as there is no Glort update > > Hi Everyone, > > Can anyone help me on this? >