[dpdk-dev] [PATCH v9 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-29 Thread Jiayu Hu
In this patch, we introduce five APIs to support TCP/IPv4 GRO. - gro_tcp_tbl_create: create a TCP reassembly table, which is used to merge packets. - gro_tcp_tbl_destroy: free memory space of a TCP reassembly table. - gro_tcp_tbl_timeout_flush: flush timeout packets from a TCP reassembly ta

[dpdk-dev] [PATCH v9 0/3] Support TCP/IPv4 GRO in DPDK

2017-06-29 Thread Jiayu Hu
Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. Therefore, we propose to support GRO in DPDK. To enable more flexibility to applications, DPDK GRO is implement

[dpdk-dev] [PATCH v9 1/3] lib: add Generic Receive Offload API framework

2017-06-29 Thread Jiayu Hu
Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, this patch implements a GRO API framework. To enable m

[dpdk-dev] [PATCH v9 3/3] app/testpmd: enable TCP/IPv4 GRO

2017-06-29 Thread Jiayu Hu
This patch enables TCP/IPv4 GRO library in csum forwarding engine. By default, GRO is turned off. Users can use command "gro (on|off) (port_id)" to enable or disable GRO for a given port. If a port is enabled GRO, all TCP/IPv4 packets received from the port are performed GRO. Besides, users can set

Re: [dpdk-dev] [PATCH] crypto/qat: fix typo

2017-06-29 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jain, Deepak K > Sent: Thursday, June 29, 2017 8:46 PM > To: De Lara Guarch, Pablo ; Trahe, Fiona > ; Griffin, John > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] crypto/qat: fix typo > > > > > -Original Message- > > From: De Lara Guarc

Re: [dpdk-dev] [PATCH v4 5/5] app/testpmd: enhance command to test NIC reset

2017-06-29 Thread Peng, Yuan
Tested-by: Peng, Yuan - Tested commit bbe569daa7e99b36d44b12bb3d23ddfbc26d383c+the 5 patches. - OS: 4.8.6-300.fc25.x86_64 - GCC: gcc version 6.2.1 20160916 (Red Hat 6.2.1-2) (GCC) - CPU: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz - NIC: Ethernet controller [0200]: Intel Corporation Ethernet Contro

Re: [dpdk-dev] [PATCH v4 0/5] Support NIC reset and keep same port id

2017-06-29 Thread Peng, Yuan
Tested-by: Peng, Yuan - Tested commit bbe569daa7e99b36d44b12bb3d23ddfbc26d383c+the 5 patches. - OS: 4.8.6-300.fc25.x86_64 - GCC: gcc version 6.2.1 20160916 (Red Hat 6.2.1-2) (GCC) - CPU: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz - NIC: Ethernet controller [0200]: Intel Corporation Ethernet Contro

Re: [dpdk-dev] Service lcores and Application lcores

2017-06-29 Thread Jerin Jacob
-Original Message- > Date: Thu, 29 Jun 2017 16:57:08 +0100 > From: Bruce Richardson > To: "Van Haaren, Harry" > CC: "dev@dpdk.org" , 'Jerin Jacob' > , "tho...@monjalon.net" > , "Wiles, Keith" > Subject: Re: Service lcores and Application lcores > User-Agent: Mutt/1.8.1 (2017-04-11) >

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e

2017-06-29 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Thursday, June 29, 2017 12:38 PM > To: Zhang, Helin ; Wu, Jingjing > > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e > > From: "Guo, Jia" > > This patch enable the hot plug feature in i40e, by

Re: [dpdk-dev] [PATCH v3 1/2] eal: add uevent api for hot plug

2017-06-29 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Thursday, June 29, 2017 12:38 PM > To: Zhang, Helin ; Wu, Jingjing > > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH v3 1/2] eal: add uevent api for hot plug > > From: "Guo, Jia" > > This patch aim to add a variable "uevent_fd" in structur

Re: [dpdk-dev] [RFC] Add hot plug event in rte eal interrupt and inplement it in i40e driver.

2017-06-29 Thread Wu, Jingjing
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, June 30, 2017 1:28 AM > To: Wu, Jingjing > Cc: Gaëtan Rivet ; Guo, Jia ; > Zhang, Helin ; Richardson, Bruce > ; Ananyev, Konstantin > ; Liu, Yuanhan ; > dev@dpdk.org > Subject: Re: [dpdk-de

Re: [dpdk-dev] [PATCH] ether: add support for vtune task tracing

2017-06-29 Thread Jerin Jacob
-Original Message- > Date: Tue, 27 Jun 2017 16:16:01 +0300 > From: ilia.kura...@intel.com > To: dev@dpdk.org > CC: konstantin.anan...@intel.com, keith.wi...@intel.com, > dmitry.gala...@intel.com, Ilia Kurakin > Subject: [dpdk-dev] [PATCH] ether: add support for vtune task tracing > X-Mail

[dpdk-dev] [PATCH] app/testpmd:add bond type description

2017-06-29 Thread RongQiang Xie
In function cmd_show_bonding_config_parsed() used number represent the bond type,in order more detailed,add bond type description otherwise we may confused about the number type. And also,the primary port just use in mode active backup and tlb, so,when the mode is active backup or tlb show the prim

Re: [dpdk-dev] [PATCH 6/7] net/bnxt: fix some link related issues

2017-06-29 Thread Ajit Khaparde
On Thu, Jun 29, 2017 at 5:55 AM, Ferruh Yigit wrote: > On 6/29/2017 3:51 AM, Ajit Khaparde wrote: > > This patch fixes some link related issues that can occur because: > > > > bnxt_hwrm_port_phy_cfg() was setting enables inappropriately. > > bnxt_hwrm_port_phy_qcfg() was overly complex. > > bnxt_

Re: [dpdk-dev] [PATCH 2/7] net/bnxt: fix mtu configuration for the function

2017-06-29 Thread Ajit Khaparde
On Thu, Jun 29, 2017 at 5:55 AM, Ferruh Yigit wrote: > Just question, would this cause larger frames than expected in application? No. It just initializes the hardware early. T​he bp->eth_dev->data->mtu still controls what goes to the application.

Re: [dpdk-dev] [PATCH v8 3/3] app/testpmd: enable TCP/IPv4 GRO

2017-06-29 Thread Wu, Jingjing
> -Original Message- > From: Hu, Jiayu > Sent: Thursday, June 29, 2017 6:59 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Tan, Jianfeng > ; y...@fridaylinux.org; step...@networkplumber.org; > Wu, Jingjing ; Bie, Tiwei ; Yao, > Lei A ; Hu, Jiayu > Subject: [PATCH v8 3/3] app/testpmd:

Re: [dpdk-dev] [PATCH 5/5] event/octeontx: add enqueue fwd op variant

2017-06-29 Thread Eads, Gage
Hi Jerin, This patch set looks good. For the series: Acked-by: Gage Eads > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Thursday, June 29, 2017 9:20 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Ead

Re: [dpdk-dev] [PATCH v8 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-29 Thread Jiayu Hu
Hi Stephen, On Thu, Jun 29, 2017 at 10:51:50AM -0700, Stephen Hemminger wrote: > On Thu, 29 Jun 2017 18:58:59 +0800 > Jiayu Hu wrote: > > > + /* allocate a reassembly table for TCP/IPv4 GRO */ > > + uint32_t tcp_item_num = RTE_MIN(item_num, > > + RTE_GRO_MAX_BURST_ITEM_NUM)

[dpdk-dev] [PATCH] app/testpmd:add bond type description

2017-06-29 Thread RongQiang Xie
In function cmd_show_bonding_config_parsed() use number represent the bond type,in order more detailed,add bond type description otherwise we may confused about the number type. And also,The primary port just use in mode active backup and tlb,so,when the mode is the active backup or tlb we show th

Re: [dpdk-dev] [PATCH 5/5] doc: update documentation for dpaa2_sec supported algos

2017-06-29 Thread Akhil Goyal
Hi Pablo, On 6/30/2017 2:37 AM, De Lara Guarch, Pablo wrote: Hi Akhil -Original Message- From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] Sent: Thursday, June 29, 2017 9:49 PM To: dev@dpdk.org Cc: hemant.agra...@nxp.com; De Lara Guarch, Pablo ; Doherty, Declan ; Akhil Goyal Subj

Re: [dpdk-dev] [pull-request] next-crypto 17.08 pre-rc1

2017-06-29 Thread Thomas Monjalon
24/06/2017 12:37, Pablo de Lara: > http://dpdk.org/git/next/dpdk-next-crypto Pulled after your last changes plus a build fix. Thanks

Re: [dpdk-dev] [PATCH v2 08/12] cryptodev: add PCI driver helpers

2017-06-29 Thread Thomas Monjalon
21/06/2017 08:28, Pablo de Lara: > +#ifndef _RTE_CRYPTODEV_PCI_H_ > +#define _RTE_CRYPTODEV_PCI_H_ > + > +#include > +#include The build fails because of the brackets instead of quotes. In a fresh build the cryptodev header is not available while compiling cryptodev. I am fixing it directly in m

Re: [dpdk-dev] [PATCH 5/5] doc: update documentation for dpaa2_sec supported algos

2017-06-29 Thread De Lara Guarch, Pablo
Hi Akhil > -Original Message- > From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > Sent: Thursday, June 29, 2017 9:49 PM > To: dev@dpdk.org > Cc: hemant.agra...@nxp.com; De Lara Guarch, Pablo > ; Doherty, Declan > ; Akhil Goyal > Subject: [PATCH 5/5] doc: update documentation for dp

Re: [dpdk-dev] [PATCH v7 14/15] dev: use new hotplug API in attach / detach

2017-06-29 Thread Thomas Monjalon
29/06/2017 20:22, Jan Blunck: > Using the new generic API allows attach and detach to be backwards > compatible while decoupling from the concrete bus implementations. > > Signed-off-by: Jan Blunck > --- > int rte_eal_dev_attach(const char *name, const char *devargs) > { > - struct rte_pci_

Re: [dpdk-dev] [PATCH v7 15/15] ethdev: Use embedded rte_device to detach driver

2017-06-29 Thread Thomas Monjalon
29/06/2017 20:22, Jan Blunck: > --- a/lib/librte_eal/common/eal_common_dev.c > +++ b/lib/librte_eal/common/eal_common_dev.c > +int rte_eal_device_detach(struct rte_device *dev) [...] > int rte_eal_dev_detach(const char *name) I would be in favor of breaking the API without notice, and keep the na

Re: [dpdk-dev] [PATCH v3] efd: support lookup using neon intrinsics

2017-06-29 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: Sekhar, Ashwin [mailto:ashwin.sek...@cavium.com] > Sent: Tuesday, May 2, 2017 9:05 AM > To: Jacob, Jerin ; > jianbo@linaro.org > Cc: Marohn, Byron ; De Lara Guarch, Pablo > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] efd: support lookup using ne

[dpdk-dev] [PATCH 5/5] doc: update documentation for dpaa2_sec supported algos

2017-06-29 Thread akhil.goyal
From: Akhil Goyal Signed-off-by: Akhil Goyal --- doc/guides/cryptodevs/dpaa2_sec.rst | 9 - doc/guides/cryptodevs/features/dpaa2_sec.ini | 6 ++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/doc/guides/cryptodevs/dpaa2_sec.rst b/doc/guides/cryptodevs/dpaa2

[dpdk-dev] [PATCH 4/5] test/test: add test cases for gcm and ctr in dpaa2_sec test suite

2017-06-29 Thread akhil.goyal
From: Akhil Goyal dpaa2_sec test cases updated for various supported crypto alogorithms. Signed-off-by: Akhil Goyal --- test/test/test_cryptodev.c | 94 test/test/test_cryptodev_aes_test_vectors.h | 78 +++ test/test/test_cryp

[dpdk-dev] [PATCH 3/5] crypto/dpaa2_sec: add support for AES-GCM and CTR

2017-06-29 Thread akhil.goyal
From: Akhil Goyal AES-GCM support is added as per the AEAD type of crypto operations. Support for AES-CTR is also added. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 315 ++-- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 98 ++--- 2

[dpdk-dev] [PATCH 1/5] crypto/dpaa2_sec: add per device mempool to store frame list entries

2017-06-29 Thread akhil.goyal
From: Akhil Goyal rte_malloc uses common memory area for all cores. Now rte_malloc are replaced by per device mempool to allocate space for FLE. This removes contention and improves performance. Signed-off-by: Akhil Goyal --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 7 +++ drivers/crypt

[dpdk-dev] [PATCH 0/5] crypto/dpaa2_sec optimization and feature update

2017-06-29 Thread akhil.goyal
From: Akhil Goyal This patchset updates dpaa2_sec crypto driver with following: - optimization in data path for memory allocation - add support for additional AES algorithms like AES-GCM and AES-CTR - Update test cases in test_cryptodev for all the supported test cases. - Update documentation for

Re: [dpdk-dev] Service lcores and Application lcores

2017-06-29 Thread Thomas Monjalon
29/06/2017 18:35, Van Haaren, Harry: > 3) The problem; >If a service core runs the SW PMD schedule() function (option 2) *AND* >the application lcore runs schedule() func (option 1), the result is that >two threads are concurrently running a multi-thread unsafe function. Which function

Re: [dpdk-dev] [PATCH] crypto/qat: fix typo

2017-06-29 Thread Jain, Deepak K
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, June 29, 2017 12:16 PM > To: Trahe, Fiona ; Griffin, John > ; Jain, Deepak K > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix typo > > Fixed a comment in QAT, referring t

[dpdk-dev] [PATCH] net/vmxnet3: avoid code duplication

2017-06-29 Thread Charles (Chas) Williams
Refactor vmxnet3_post_rx_bufs() to call vmxnet3_renew_desc() to update the newly allocated mbufs. While here, relocate the relevant comments to vmxnet3_renew_desc(). Signed-off-by: Chas Williams --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 61 +- 1 file changed,

[dpdk-dev] [PATCH v3 26/26] cryptodev: remove AAD from authentication structure

2017-06-29 Thread Pablo de Lara
Now that AAD is only used in AEAD algorithms, there is no need to keep AAD in the authentication structure. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- app/test-crypto-perf/cperf_ops.c | 2 -- doc/guides/prog_guide/cryptodev_lib.rst | 6 -- doc/guides/rel_notes/release

[dpdk-dev] [PATCH v3 25/26] cryptodev: use AES-GCM/CCM as AEAD algorithms

2017-06-29 Thread Pablo de Lara
Now that all the structures/functions for AEAD algorithms are in place, migrate the two supported algorithms AES-GCM and AES-CCM to these, instead of using cipher and authentication parameters. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/sample_app_ug/ipsec_secgw.rst

[dpdk-dev] [PATCH v3 24/26] examples/l2fwd-crypto: add AEAD parameters

2017-06-29 Thread Pablo de Lara
Since there is a new operation type (AEAD), add parameters for this in the application. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/sample_app_ug/l2_forward_crypto.rst | 24 +- examples/l2fwd-crypto/main.c | 388 + 2 files changed

[dpdk-dev] [PATCH v3 22/26] app/test-crypto-perf: add AEAD parameters

2017-06-29 Thread Pablo de Lara
Since there is a new operation type (AEAD), add parameters for this in the application. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- app/test-crypto-perf/cperf_ops.c | 138 ++- app/test-crypto-perf/cperf_options.h | 22 +++- app/test-cr

[dpdk-dev] [PATCH v3 20/26] cryptodev: add AEAD parameters in crypto operation

2017-06-29 Thread Pablo de Lara
AEAD operation parameters can be set in the new aead structure, in the crypto operation. This structure is within a union with the cipher and authentication parameters, since operations can be: - AEAD: using the aead structure - Cipher only: using only the cipher structure - Auth only: using only

[dpdk-dev] [PATCH v3 23/26] examples/ipsec-secgw: add AEAD parameters

2017-06-29 Thread Pablo de Lara
Since there is a new operation type (AEAD), add parameters for this in the application. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/sample_app_ug/ipsec_secgw.rst | 32 +++-- examples/ipsec-secgw/ipsec.h | 1 + examples/ipsec-secgw/sa.c| 1

[dpdk-dev] [PATCH v3 21/26] examples/l2fwd-crypto: avoid too many tabs

2017-06-29 Thread Pablo de Lara
Some extra functions have been created to avoid too many nested conditionals. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- examples/l2fwd-crypto/main.c | 125 ++- 1 file changed, 77 insertions(+), 48 deletions(-) diff --git a/examples/l2fwd-cry

[dpdk-dev] [PATCH v3 19/26] cryptodev: add AEAD specific data

2017-06-29 Thread Pablo de Lara
AEAD algorithms such as AES-GCM needed to be used as a concatenation of a cipher transform and an authentication transform. Instead, a new transform and functions to handle it are created to support these kind of algorithms, making their use easier. Signed-off-by: Pablo de Lara Acked-by: Akhil G

[dpdk-dev] [PATCH v3 18/26] cryptodev: set AES-GMAC as auth-only algo

2017-06-29 Thread Pablo de Lara
AES-GMAC is an authentication algorithm, based on AES-GCM without encryption. To simplify its usage, now it can be used setting the authentication parameters, without requiring to concatenate a ciphering transform. Therefore, it is not required to set AAD, but authentication data length and offset

[dpdk-dev] [PATCH v3 17/26] cryptodev: remove digest length from crypto op

2017-06-29 Thread Pablo de Lara
Digest length was duplicated in the authentication transform and the crypto operation structures. Since digest length is not expected to change in a same session, it is removed from the crypto operation. Also, the length has been shrunk to 16 bits, which should be sufficient for any digest. Sign

[dpdk-dev] [PATCH v3 15/26] cryptodev: do not use AAD in wireless algorithms

2017-06-29 Thread Pablo de Lara
For wireless algorithms (SNOW3G, KASUMI, ZUC), the IV for the authentication algorithms (F9, UIA2 and EIA3) was taken from the AAD parameter, as there was no IV parameter in the authentication structure. Now that IV is available for all algorithms, there is need to keep doing this, so AAD is not u

[dpdk-dev] [PATCH v3 16/26] cryptodev: remove AAD length from crypto op

2017-06-29 Thread Pablo de Lara
Additional authenticated data (AAD) information was duplicated in the authentication transform and in the crypto operation structures. Since AAD length is not meant to be changed in a same session, it is removed from the crypto operation structure. Signed-off-by: Pablo de Lara Acked-by: Akhil Go

[dpdk-dev] [PATCH v3 14/26] cryptodev: add auth IV

2017-06-29 Thread Pablo de Lara
Authentication algorithms, such as AES-GMAC or the wireless algorithms (like SNOW3G) use IV, like cipher algorithms. So far, AES-GMAC has used the IV from the cipher structure, and the wireless algorithms have used the AAD field, which is not technically correct. Therefore, authentication IV param

[dpdk-dev] [PATCH v3 13/26] cryptodev: move IV parameters to crypto session

2017-06-29 Thread Pablo de Lara
Since IV parameters (offset and length) should not change for operations in the same session, these parameters are moved to the crypto transform structure, so they will be stored in the sessions. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- app/test-crypto-perf/cperf_ops.c

[dpdk-dev] [PATCH v3 12/26] cryptodev: pass IV as offset

2017-06-29 Thread Pablo de Lara
Since IV now is copied after the crypto operation, in its private size, IV can be passed only with offset and length. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- app/test-crypto-perf/cperf_ops.c| 49 +++-- doc/guides/prog_guide/cryptodev_lib.rst | 3 +- doc

[dpdk-dev] [PATCH v3 11/26] examples/ipsec-secgw: move IV to crypto op private data

2017-06-29 Thread Pablo de Lara
Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara Acked-by

[dpdk-dev] [PATCH v3 08/26] test/crypto-perf: move IV to crypto op private data

2017-06-29 Thread Pablo de Lara
Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara Acked-by

[dpdk-dev] [PATCH v3 10/26] examples/l2fwd-crypto: move IV to crypto op private data

2017-06-29 Thread Pablo de Lara
Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara Acked-by

[dpdk-dev] [PATCH v3 09/26] app/crypto-perf: move IV to crypto op private data

2017-06-29 Thread Pablo de Lara
Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara Acked-by

[dpdk-dev] [PATCH v3 07/26] test/crypto: move IV to crypto op private data

2017-06-29 Thread Pablo de Lara
Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara Acked-by

[dpdk-dev] [PATCH v3 06/26] cryptodev: add crypto op helper macros

2017-06-29 Thread Pablo de Lara
In order to facilitate the access to the private data, after the crypto operation, two new macros have been implemented: - rte_crypto_op_ctod_offset(c,t,o), which returns a pointer to "o" bytes after the start of the crypto operation (rte_crypto_op) - rte_crypto_op_ctophys_offset(c, o), which

[dpdk-dev] [PATCH v3 05/26] cryptodev: remove useless alignment

2017-06-29 Thread Pablo de Lara
rte_crypto_op and rte_crypto_sym_op structures were marked as cache aligned. However, since these structures are always initialized in a mempool, this alignment is useless, since the mempool forces the alignment of its objects. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- lib/librte_c

[dpdk-dev] [PATCH v3 04/26] cryptodev: do not store pointer to op specific params

2017-06-29 Thread Pablo de Lara
Instead of storing a pointer to operation specific parameters, such as symmetric crypto parameters, use a zero-length array, to mark that these parameters will be stored after the generic crypto operation structure, which was already assumed in the code, reducing the memory footprint of the crypto

[dpdk-dev] [PATCH v3 02/26] cryptodev: replace enums with 1-byte variables

2017-06-29 Thread Pablo de Lara
Instead of storing some crypto operation flags, such as operation status, as enumerations, store them as uint8_t, for memory efficiency. Also, reserve extra 5 bytes in the crypto operation, for future additions. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/rel_notes/releas

[dpdk-dev] [PATCH v3 01/26] cryptodev: move session type to generic crypto op

2017-06-29 Thread Pablo de Lara
Session type (operation with or without session) is not something specific to symmetric operations. Therefore, the variable is moved to the generic crypto operation structure. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/prog_guide/cryptodev_lib.rst | 21 ++-

[dpdk-dev] [PATCH v3 03/26] cryptodev: remove opaque data pointer in crypto op

2017-06-29 Thread Pablo de Lara
Storing a pointer to the user data is unnecessary, since user can store additional data, after the crypto operation. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- app/test-crypto-perf/cperf_test_latency.c | 36 +-- doc/guides/prog_guide/cryptodev_lib.rst |

[dpdk-dev] [PATCH v3 00/26] Crypto operation restructuring

2017-06-29 Thread Pablo de Lara
This patchset attempts to correct and improve the current crypto operation (rte_crypto_op) and symmetric crypto operation (rte_crypto_sym_op) structures, shrinking their sizes to fit both structures into two 64-byte cache lines (with extra space for the IV and other user data) as one of the goals.

Re: [dpdk-dev] [PATCH v6 05/11] bus: introduce hotplug functionality

2017-06-29 Thread Jan Blunck
On Thu, Jun 29, 2017 at 2:59 PM, Gaëtan Rivet wrote: > > Hi all, > > We are all for having "true" hotplug support in DPDK. > By true hotplug, it means that at some point, a new device exists on the > system, while the DPDK bus on which it should be probed does not yet > have its metadata. Somethin

[dpdk-dev] [PATCH] crypto/qat: fix typo

2017-06-29 Thread Pablo de Lara
Fixed a comment in QAT, referring to the IV size for AES-GCM, that should be in bytes, and not bits. Fixes: 53d8971cbe81 ("qat: fix AES-GCM decryption") CC: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/crypto/qat/qat_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[dpdk-dev] [PATCH v7 15/15] ethdev: Use embedded rte_device to detach driver

2017-06-29 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_dev.c| 43 --- lib/librte_eal/common/include/rte_dev.h | 8 + lib/librte_ether/rte_ethdev.c | 3 +- 4 files changed, 36

[dpdk-dev] [PATCH v7 13/15] eal: add hotplug add/remove functions

2017-06-29 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 + lib/librte_eal/common/eal_common_dev.c | 68 + lib/librte_eal/common/include/rte_dev.h | 28 ++ lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 + 4 files ch

[dpdk-dev] [PATCH v7 14/15] dev: use new hotplug API in attach / detach

2017-06-29 Thread Jan Blunck
Using the new generic API allows attach and detach to be backwards compatible while decoupling from the concrete bus implementations. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_dev.c | 76 -- 1 file changed, 53 insertions(+), 23 deletions(-) d

[dpdk-dev] [PATCH v7 12/15] pci: implement hotplug bus operation

2017-06-29 Thread Jan Blunck
From: Gaetan Rivet Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index e449758..5ee100e 100644 --- a/

[dpdk-dev] [PATCH v7 07/15] bus: add bus iterator to find a device

2017-06-29 Thread Jan Blunck
Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 15 ++ lib/librte_eal/common/include/rte_bus.h | 26 + lib/librte_eal/linuxapp/eal/rte_e

[dpdk-dev] [PATCH v7 11/15] vdev: implement unplug bus operation

2017-06-29 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 9bb7427..baf3c5b 100644 --- a/lib/librte_eal/common/eal_common_vdev.c

[dpdk-dev] [PATCH v7 10/15] bus: introduce device plug/unplug functionality

2017-06-29 Thread Jan Blunck
This allows the buses to plug and probe specific devices. This is meant to be a building block for hotplug support. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_bus.c | 2 ++ lib/librte_eal/common/include/rte_bus.h | 32 2 files changed, 34 in

[dpdk-dev] [PATCH v7 09/15] bus: add rte_bus_find_by_name

2017-06-29 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_bus.c | 14 ++ lib/librte_eal/common/include/rte_bus.h | 5 + 2 files changed, 19 insertions(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c index d0e652e..418804a 10

[dpdk-dev] [PATCH v7 04/15] pci: implement find_device bus operation

2017-06-29 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_pci.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 479c62d..e449758 100644 --- a/lib/librte_eal/common/eal_common_pci

[dpdk-dev] [PATCH v7 05/15] bus/fslmc: implement find_device bus operation

2017-06-29 Thread Jan Blunck
Signed-off-by: Jan Blunck --- drivers/bus/fslmc/fslmc_bus.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index b24642d..1e3bbee 100644 --- a/drivers/bus/fslmc/fslmc_bus.c +++ b/drivers/bus/fslmc/fslmc_bu

[dpdk-dev] [PATCH v7 08/15] bus: require buses to implement find_device operation

2017-06-29 Thread Jan Blunck
Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c index 61aa947..d0e652e 100644 --- a/lib/librte_eal/common/eal_common_bus.c +++ b/lib/librte_eal

[dpdk-dev] [PATCH v7 06/15] bus: add helper to find which bus holds a device

2017-06-29 Thread Jan Blunck
Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 23 +++ lib/librte_eal/common/include/rte_bus.h | 5 + lib/librte_eal/linuxapp/eal/rte_eal_version.

[dpdk-dev] [PATCH v7 02/15] bus: add find_device bus operation

2017-06-29 Thread Jan Blunck
This new method allows buses to expose their devices in a controlled manner. A comparison function is provided by the user to discriminate between devices, using arbitrary data as identifier. It is possible to start an iteration from a specific point, in order to continue a search. Signed-off-by:

[dpdk-dev] [PATCH 00/15] bus attach/detach API and hotplug rework

2017-06-29 Thread Jan Blunck
Following the work from Gaetan, who based his work on my original series. -- v7 * Revert removal of RTE_VERIFY on find_device operation since a bus that isn't able to even iterate its devices is pointless * Revert plug() changes that have been introduced in v3: int (*rte_bus_plug_t)(struct r

[dpdk-dev] [PATCH v7 01/15] bus: add bus iterator to find a bus

2017-06-29 Thread Jan Blunck
This helper allows to iterate over all registered buses and find one matching data used as parameter. Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 19 +++ lib/librte_ea

[dpdk-dev] [PATCH v7 03/15] vdev: implement find_device bus operation

2017-06-29 Thread Jan Blunck
Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index b4db2be..9bb7427 100644 --- a/lib/

Re: [dpdk-dev] [PATCH v8 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-29 Thread Stephen Hemminger
On Thu, 29 Jun 2017 18:58:59 +0800 Jiayu Hu wrote: > + /* allocate a reassembly table for TCP/IPv4 GRO */ > + uint32_t tcp_item_num = RTE_MIN(item_num, > + RTE_GRO_MAX_BURST_ITEM_NUM); > + struct gro_tcp_tbl tcp_tbl; > + struct gro_tcp_key tcp_keys[tcp_item_num

[dpdk-dev] [PATCH v2] bonding: allow to create master bonding

2017-06-29 Thread Tomasz Kulasek
This patch removes restrictions in bonded device library which prevent a bonded device to be added to another bonded device. Added link speed calculation for a bonding with fallowed rules: - BROADCAST - Minimal slaves link speed - ACTIVE_BACKUP - Current primary slave - ROUND_ROBIN, BALANCE, 80

Re: [dpdk-dev] [RFC] Add hot plug event in rte eal interrupt and inplement it in i40e driver.

2017-06-29 Thread Stephen Hemminger
On Wed, 7 Jun 2017 07:40:37 + "Wu, Jingjing" wrote: > > > > > >Secondly, in order to read out the uevent that monitoring, we need to add > > >uevent API in rte > > layer. We plan add 2 , rte_uevent_connect and rte_get_uevent. All driver > > interrupt handler > > could use these API to en

Re: [dpdk-dev] [PATCH v2] lib/librte_sched: fix update tc_credits

2017-06-29 Thread Stephen Hemminger
On Thu, 29 Jun 2017 16:35:42 +0200 Olivier Chirossel wrote: > /* Subport TCs */ > if (unlikely(port->time >= subport->tc_time)) { > - subport->tc_credits[0] = subport->tc_credits_per_period[0]; > - subport->tc_credits[1] = subport->tc_credits_per_period[1]; > -

Re: [dpdk-dev] [PATCH v5 4/4] app/testpmd: add isolated mode parameter

2017-06-29 Thread Adrien Mazarguil
On Wed, Jun 28, 2017 at 05:03:57PM +0300, Vasily Philipov wrote: > In case if --isolated-mode parameter was added to the command line > the rte flow isolate action will be applied on each port before > the device configuring. > > Signed-off-by: Vasily Philipov The patch itself looks OK but I thi

Re: [dpdk-dev] [PATCH v5 3/4] net/mlx4: support for the RSS flow action

2017-06-29 Thread Adrien Mazarguil
On Wed, Jun 28, 2017 at 05:03:56PM +0300, Vasily Philipov wrote: > The isolated mode should be enabled. > The number of queues in RSS ring must be power of 2. > The sharing a queue between several RSS rings is impossible. > > Signed-off-by: Vasily Philipov Alternative suggestion for commit log:

Re: [dpdk-dev] [PATCH v5 2/4] net/mlx4: implement isolated mode from flow API

2017-06-29 Thread Adrien Mazarguil
On Wed, Jun 28, 2017 at 05:03:55PM +0300, Vasily Philipov wrote: > The user must request isolated mode before device configuration, > the default RSS ring isn't created in this case. > > Signed-off-by: Vasily Philipov Minor nit, please see below. > --- > drivers/net/mlx4/mlx4.c | 58 > ++

Re: [dpdk-dev] [PATCH v5 1/4] net/mlx4: RSS parent queues new method maintenance

2017-06-29 Thread Adrien Mazarguil
Hi Vasily, You should rearrange this series more logically, currently: - 1/4 adds the ability to have multiple RSS parent QPs in mlx4. - 2/4 adds rte_flow isolated mode support to mlx4 with the limitation that it must be enabled during init. - 3/4 updates mlx4 to support the rte_flow RSS ac

Re: [dpdk-dev] [PATCH v2 00/27] Crypto operation restructuring

2017-06-29 Thread Akhil Goyal
On 6/26/2017 3:52 PM, Pablo de Lara wrote: This patchset attempts to correct and improve the current crypto operation (rte_crypto_op) and symmetric crypto operation (rte_crypto_sym_op) structures, shrinking their sizes to fit both structures into two 64-byte cache lines (with extra space for the

Re: [dpdk-dev] Service lcores and Application lcores

2017-06-29 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, June 29, 2017 4:16 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; 'Jerin Jacob' ; Wiles, Keith > ; Richardson, Bruce > Subject: Re: Service lcores and Application lcores > > 29/06/2017 16:36, Van Haaren, Harry: > > The topic

Re: [dpdk-dev] [PATCH v2] doc: add generic compilation doc for all sample apps

2017-06-29 Thread Mcnamara, John
> -Original Message- > From: Lipiec, Herakliusz > Sent: Thursday, June 29, 2017 9:41 AM > To: Mcnamara, John > Cc: heraklusz.lip...@intel.com; dev@dpdk.org > Subject: [PATCH v2] doc: add generic compilation doc for all sample apps > > Moved duplicated, and occasionally outdated, doc secti

[dpdk-dev] [PATCH v2 2/2] test-pmd: add set bonding slow_queue hw/sw

2017-06-29 Thread Tomasz Kulasek
This patch adds new command: set bonding slow_queue [sw|hw] "set bonding slow_queue hw" sets hardware management of slow packets and chooses simplified paths for tx/rx bursts. "set bonding slow_queue sw" turns back to the software handling of slow packets. This option is default. Example

[dpdk-dev] [PATCH v2 1/2] LACP control packet filtering offload

2017-06-29 Thread Tomasz Kulasek
New API functions implemented: rte_eth_bond_8023ad_slow_pkt_hw_filter_enable(uint8_t port_id); rte_eth_bond_8023ad_slow_pkt_hw_filter_disable(uint8_t port_id); rte_eth_bond_8023ad_slow_pkt_hw_filter_enable should be called before bonding port start to enable new path. When this option is e

[dpdk-dev] [PATCH v2 0/2] LACP control packet filtering offload

2017-06-29 Thread Tomasz Kulasek
1. Overview Packet processing in the current path for bonding in mode 4, requires parse all packets in the fast path, to classify and process LACP packets. The idea of performance improvement is to use hardware offloads to improve packet classification. 2. Scope of work a) Optimiza

Re: [dpdk-dev] [PATCH v8 0/4] Userspace Network Control Interface (UNCI)

2017-06-29 Thread Ferruh Yigit
On 6/26/2017 12:39 PM, Bruce Richardson wrote: > On Wed, Jun 21, 2017 at 12:06:47PM +0100, Ferruh Yigit wrote: >> Userspace Network Control Interface (UNCI), (formerly KCP). >> >> When a NIC bound to the DPDK, it can't be controlled by Linux tools. >> >> This patch creates a virtual network interfa

Re: [dpdk-dev] Service lcores and Application lcores

2017-06-29 Thread Bruce Richardson
On Thu, Jun 29, 2017 at 03:36:04PM +0100, Van Haaren, Harry wrote: > Hi All, > > > The recently posted service cores patchset[1], introduces service lcores to > run services for DPDK applications. Services are just an ordinary function > for eg: eventdev scheduling, NIC RX, statistics and monit

[dpdk-dev] [PATCH v4 2/3] doc: add sw eventdev pipeline to sample app ug

2017-06-29 Thread David Hunt
From: Harry van Haaren Add a new entry in the sample app user-guides, which details the working of the eventdev_pipeline_sw. Signed-off-by: Harry van Haaren Signed-off-by: David Hunt --- doc/guides/sample_app_ug/eventdev_pipeline_sw.rst | 190 ++ doc/guides/sample_app_ug/i

[dpdk-dev] [PATCH v4 3/3] doc: add eventdev library to programmers guide

2017-06-29 Thread David Hunt
From: Harry van Haaren This commit adds an entry in the programmers guide explaining the eventdev library. The rte_event struct, queues and ports are explained. An API walktrough of a simple two stage atomic pipeline provides the reader with a step by step overview of the expected usage of the E

[dpdk-dev] [PATCH v4 1/3] examples/eventdev_pipeline: added sample app

2017-06-29 Thread David Hunt
From: Harry van Haaren This commit adds a sample app for the eventdev library. The app has been tested with DPDK 17.05-rc2, hence this release (or later) is recommended. The sample app showcases a pipeline processing use-case, with event scheduling and processing defined per stage. The applicati

[dpdk-dev] [PATCH v4 0/3] next-eventdev: evendev pipeline sample app

2017-06-29 Thread David Hunt
This patchset introduces a sample application that demonstrates a pipeline model for packet processing. Running this sample app with 17.05-rc2 or later is recommended. Changes in patch v2: * None, incorrect patch upload Changes in patch v3: * Re-work based on comments on mailing list. No majo

Re: [dpdk-dev] [PATCH 25/38] net/dpaa: add support for MTU update

2017-06-29 Thread Ferruh Yigit
On 6/29/2017 3:56 PM, Shreyansh Jain wrote: > On Wednesday 28 June 2017 09:15 PM, Ferruh Yigit wrote: >> On 6/16/2017 6:40 AM, Shreyansh Jain wrote: >>> Signed-off-by: Hemant Agrawal >>> Signed-off-by: Shreyansh Jain <...> >>> + dev->data->dev_conf.rxmode.jumbo_frame = 0; >>> + >>> + dev->d

  1   2   3   >