[dpdk-dev] [PATCH] cxgbe: fix alignment for data offset in mbufs

2017-06-14 Thread Rahul Lakkireddy
Fixup alignment for data offset when refilling mbufs. Fixes: edd04c619685 ("net/cxgbe: update Rx path for Chelsio T6") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/sge.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/c

Re: [dpdk-dev] [PATCH v2 07/12] pdump: disabled by default

2017-06-14 Thread Gaëtan Rivet
Hi Ferruh, On Tue, Jun 13, 2017 at 06:15:45PM +0100, Ferruh Yigit wrote: > On 6/11/2017 8:42 PM, Gaëtan Rivet wrote: > > Hi Reshma, > > > > On Fri, Jun 09, 2017 at 02:24:58PM +, Pattan, Reshma wrote: > >> Hi, > >> > >>> -Original Message- > >>> From: dev [mailto:dev-boun...@dpdk.org]

Re: [dpdk-dev] [PATCH] dpdk: remove typos using codespell utility

2017-06-14 Thread Thomas Monjalon
> > Fixing typos across dpdk source code using codespell utility. > > Skipped the ethdev driver's base code fixes to keep the base > > code intact. > > > > Signed-off-by: Jerin Jacob > > Good work. More people should run spell checks on their code. It is an easy > fix > that improves the overal

Re: [dpdk-dev] [PATCH] pdump: remove unnecessary header file

2017-06-14 Thread Thomas Monjalon
12/06/2017 11:46, Reshma Pattan: > Missed to remove unnecessary header file rte_pci.h. > Removed it now. > > Fixes: bb900072("pdump: revert PCI device name conversion") > > Signed-off-by: Reshma Pattan Applied, thanks

Re: [dpdk-dev] [PATCH v4] ethdev: add isolated mode to flow API

2017-06-14 Thread Thomas Monjalon
14/06/2017 17:41, Andrew Rybchenko: > On 06/14/2017 05:48 PM, Adrien Mazarguil wrote: > > Isolated mode can be requested by applications on individual ports to avoid > > ingress traffic outside of the flow rules they define. > > > > Besides making ingress more deterministic, it allows PMDs to safel

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: modify callback process API

2017-06-14 Thread Thomas Monjalon
Hi, 12/06/2017 17:18, Bernard Iremonger: > Change the rte_eth_dev_callback_process function to return int, > and add a void *ret_param parameter. You should squash tests and examples changes in this change to avoid breaking compilation. Doc patch can also be squashed. > --- a/lib/librte_ether/rt

Re: [dpdk-dev] [PATCH 1/5] kni: fix build with gcc 7.1

2017-06-14 Thread Thomas Monjalon
Series applied, thanks

Re: [dpdk-dev] [pull-request] next-net 17.08 PRE-RC1

2017-06-14 Thread Thomas Monjalon
12/06/2017 18:23, Ferruh Yigit: > http://dpdk.org/git/next/dpdk-next-net Pulled, thanks

Re: [dpdk-dev] [PATCH] doc: add generic compilation doc for all sample apps

2017-06-14 Thread Mcnamara, John
> -Original Message- > From: Lipiec, Herakliusz > Sent: Thursday, June 1, 2017 5:36 PM > To: Mcnamara, John > Cc: Lipiec, Herakliusz ; dev@dpdk.org > Subject: [PATCH] doc: add generic compilation doc for all sample apps > > Moved duplicated, and occasionally outdated, doc sections from

[dpdk-dev] Compilation error by "net/bnxt: add support to set VF rxmode"

2017-06-14 Thread Yongseok Koh
Hi, Ajit It looks you missed some #ifdef/endif when you made newer version for the following patch. http://dpdk.org/dev/patchwork/patch/25011 Currently, if RTE_LIBRTE_IXGBE_PMD isn't enabled, a compilation error occurs. > CC cperf_test_latency.o > LD dpdk-pdump > app/test-pmd/cmdline.c:1381

Re: [dpdk-dev] [PATCH v4] ethdev: add isolated mode to flow API

2017-06-14 Thread Andrew Rybchenko
On 06/14/2017 05:48 PM, Adrien Mazarguil wrote: Isolated mode can be requested by applications on individual ports to avoid ingress traffic outside of the flow rules they define. Besides making ingress more deterministic, it allows PMDs to safely reuse resources otherwise assigned to handle the

[dpdk-dev] [PATCH v4] ethdev: add isolated mode to flow API

2017-06-14 Thread Adrien Mazarguil
Isolated mode can be requested by applications on individual ports to avoid ingress traffic outside of the flow rules they define. Besides making ingress more deterministic, it allows PMDs to safely reuse resources otherwise assigned to handle the remaining traffic, such as global RSS configuratio

Re: [dpdk-dev] [PATCH 0/7] Fix Rx interrupt support in mlx4 and mlx5

2017-06-14 Thread Nélio Laranjeiro
On Wed, Jun 14, 2017 at 01:49:10PM +0200, Adrien Mazarguil wrote: > Several issues mainly related to error handling were found in both > implementations as they share most of their Rx interrupts handling code. > > Another problem with the mlx4 implementation is that it does not work > properly wit

Re: [dpdk-dev] [PATCH v3] ethdev: add isolated mode to flow API

2017-06-14 Thread Andrew Rybchenko
On 06/14/2017 04:35 PM, Adrien Mazarguil wrote: On Wed, Jun 14, 2017 at 04:01:46PM +0300, Andrew Rybchenko wrote: On 06/14/2017 03:45 PM, Adrien Mazarguil wrote: Isolated mode can be requested by applications on individual ports to avoid ingress traffic outside of the flow rules they define. B

Re: [dpdk-dev] [PATCH v3] ethdev: add isolated mode to flow API

2017-06-14 Thread Adrien Mazarguil
On Wed, Jun 14, 2017 at 04:01:46PM +0300, Andrew Rybchenko wrote: > On 06/14/2017 03:45 PM, Adrien Mazarguil wrote: > >Isolated mode can be requested by applications on individual ports to avoid > >ingress traffic outside of the flow rules they define. > > > >Besides making ingress more determinist

Re: [dpdk-dev] [PATCH 4/5] net/mlx5: fix build with gcc 7.1

2017-06-14 Thread Adrien Mazarguil
On Tue, Jun 13, 2017 at 05:42:11PM +0100, Ferruh Yigit wrote: > build error: > .../dpdk/drivers/net/mlx5/mlx5_fdir.c: > In function ‘fdir_filter_to_flow_desc’: > .../dpdk/drivers/net/mlx5/mlx5_fdir.c:146:18: > error: this statement may fall through [-Werror=implicit-fallthrough=] >desc->dst_

Re: [dpdk-dev] [PATCH v3] ethdev: add isolated mode to flow API

2017-06-14 Thread Andrew Rybchenko
On 06/14/2017 03:45 PM, Adrien Mazarguil wrote: Isolated mode can be requested by applications on individual ports to avoid ingress traffic outside of the flow rules they define. Besides making ingress more deterministic, it allows PMDs to safely reuse resources otherwise assigned to handle the

[dpdk-dev] [PATCH v3] ethdev: add isolated mode to flow API

2017-06-14 Thread Adrien Mazarguil
Isolated mode can be requested by applications on individual ports to avoid ingress traffic outside of the flow rules they define. Besides making ingress more deterministic, it allows PMDs to safely reuse resources otherwise assigned to handle the remaining traffic, such as global RSS configuratio

[dpdk-dev] [PATCH 7/7] net/mlx5: fix Rx interrupts management

2017-06-14 Thread Adrien Mazarguil
This commit addresses various issues that may lead to undefined behavior when configuring Rx interrupts. While failure to create a Rx queue completion channel in rxq_ctrl_setup() prevents that queue from being created, existing queues still have theirs. Since the error handler disables dev_conf.in

[dpdk-dev] [PATCH 6/7] net/mlx5: fix return value in Rx interrupts code

2017-06-14 Thread Adrien Mazarguil
A negative return value is documented for that function in case of error. Fixes: 3c7d44af252a ("net/mlx5: support user space Rx interrupt event") Cc: sta...@dpdk.org Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 4/7] net/mlx5: fix misplaced Rx interrupts functions

2017-06-14 Thread Adrien Mazarguil
These functions do not belong to the data path. Their prototypes are also misplaced. Fixes: 3c7d44af252a ("net/mlx5: support user space Rx interrupt event") Cc: sta...@dpdk.org Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxq.c | 73 +++ drivers

[dpdk-dev] [PATCH 5/7] net/mlx5: fix Rx interrupts support checks

2017-06-14 Thread Adrien Mazarguil
Not exposing Rx interrupts callbacks when this feature is unsupported is less intrusive than having two different versions for these functions. Fixes: 3c7d44af252a ("net/mlx5: support user space Rx interrupt event") Cc: sta...@dpdk.org Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH 3/7] net/mlx4: fix Rx interrupts management

2017-06-14 Thread Adrien Mazarguil
This commit addresses various issues that may lead to undefined behavior when configuring Rx interrupts. While failure to create a Rx queue completion channel in rxq_setup() prevents that queue from being created, existing queues still have theirs. Since the error handler disables dev_conf.intr_co

[dpdk-dev] [PATCH 0/7] Fix Rx interrupt support in mlx4 and mlx5

2017-06-14 Thread Adrien Mazarguil
Several issues mainly related to error handling were found in both implementations as they share most of their Rx interrupts handling code. Another problem with the mlx4 implementation is that it does not work properly with multiple ports adapters that share a common PCI device. Adrien Mazarguil

[dpdk-dev] [PATCH 2/7] net/mlx4: fix Rx interrupts with multiple ports

2017-06-14 Thread Adrien Mazarguil
Several Ethernet device structures are allocated on top of a common PCI device for mlx4 adapters with multiple ports. These inherit a common interrupt handle from their parent PCI device, which prevents Rx interrupts from working properly on all ports as their configuration is overwritten. Use a l

[dpdk-dev] [PATCH 1/7] net/mlx4: fix typos from prior commit

2017-06-14 Thread Adrien Mazarguil
Fixes: 9f05a4b81809 ("net/mlx4: support user space Rx interrupt event") Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro Acked-by: Moti Haimovsky --- drivers/net/mlx4/mlx4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/

Re: [dpdk-dev] [PATCH 2/2] event/sw: advertise the burst mode capability

2017-06-14 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, June 14, 2017 5:58 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; Jerin Jacob > Subject: [dpdk

Re: [dpdk-dev] [PATCH 1/2] eventdev: introduce burst mode capabality

2017-06-14 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, June 14, 2017 5:58 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; Jerin Jacob > Subject: [dpdk

[dpdk-dev] [PATCH] net/szedata2: use macro from common library

2017-06-14 Thread Matej Vido
Macro for alignment is defined in the common library. Use macro from the common library in own macro definition. Signed-off-by: Matej Vido --- drivers/net/szedata2/rte_eth_szedata2.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/szedata2/rte_eth_szedata2.h b

[dpdk-dev] [PATCH] net/bonding: support bifurcated driver in eal cli using --vdev

2017-06-14 Thread Gowrishankar
From: Gowrishankar Muthukrishnan At present, creating bonding devices using --vdev is broken for PMD like mlx5 as it is neither UIO nor VFIO based and hence PMD driver is unknown to find_port_id_by_pci_addr(), as below. testpmd --vdev 'net_bonding0,mode=1,slave=,socket_id=0' PMD: bond_ethdev_p

Re: [dpdk-dev] [PATCH 1/2] ethdev: add function to adjust number of descriptors

2017-06-14 Thread Andrew Rybchenko
On 05/25/2017 08:40 PM, Stephen Hemminger wrote: On Thu, 25 May 2017 16:57:53 +0100 Andrew Rybchenko wrote: From: Roman Zhukov Check that numbers of Rx and Tx descriptors satisfy descriptors limits from the Ethernet device information, otherwise adjust them to boundaries. Signed-off-by: Rom

[dpdk-dev] [PATCH] net/bonding: enable bonding pmd in ppc64le

2017-06-14 Thread Gowrishankar
From: Gowrishankar Muthukrishnan Earlier bonding pmd was disabled in default config for ppc64le. Same has been verified, with active-backup mode for an instance (to bond two VFs in each phy port): testpmd-bonding-cmd.txt: create bonded device 1 0 create bonded device 1 0 add bonding slave 0 4 ad

Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: add fragmentation size support

2017-06-14 Thread Ananyev, Konstantin
> -Original Message- > From: Jain Ashish-B46179 [mailto:ashish.j...@nxp.com] > Sent: Wednesday, June 14, 2017 10:20 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Subject: Re: [PATCH] examples/ip_fragmentation: add fragmentation size support > > Hi Konstantin, > > On 6/4/2017 9:14 PM, An

Re: [dpdk-dev] [PATCH v4 05/19] net/ixgbe: properly reference PCI header

2017-06-14 Thread Gaëtan Rivet
Hi, On Wed, Jun 14, 2017 at 09:33:14AM +, Dai, Wei wrote: > Why to introduce this change ? > > Even without this patch, all files can be built successfully. > Each.*.o.d files in x86_64-native-linuxapp-gcc keeps same in both with and > without this patch. > So there is no need to add the lin

Re: [dpdk-dev] [PATCH v4 05/19] net/ixgbe: properly reference PCI header

2017-06-14 Thread Dai, Wei
Why to introduce this change ? Even without this patch, all files can be built successfully. Each.*.o.d files in x86_64-native-linuxapp-gcc keeps same in both with and without this patch. So there is no need to add the line at least in the config of x86_64-native-linuxapp-gcc. > -Original

Re: [dpdk-dev] [PATCH v2 07/12] pdump: disabled by default

2017-06-14 Thread Gaëtan Rivet
On Wed, Jun 14, 2017 at 09:09:18AM +, Pattan, Reshma wrote: > Hi, > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Sunday, June 11, 2017 8:42 PM > > To: Pattan, Reshma > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 07/12] pdump: dis

Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: add fragmentation size support

2017-06-14 Thread Jain Ashish-B46179
Hi Konstantin, On 6/4/2017 9:14 PM, Ananyev, Konstantin wrote: Hi, -Original Message- From: Ashish Jain [mailto:ashish.j...@nxp.com] Sent: Thursday, April 20, 2017 8:18 AM To: dev@dpdk.org; Ananyev, Konstantin Subject: [PATCH] examples/ip_fragmentation: add fragmentation size support

Re: [dpdk-dev] [PATCH v2 07/12] pdump: disabled by default

2017-06-14 Thread Pattan, Reshma
Hi, > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Sunday, June 11, 2017 8:42 PM > To: Pattan, Reshma > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 07/12] pdump: disabled by default > > > > > Since, you already mentioned in other mail to Ferruh

Re: [dpdk-dev] [PATCH v5 01/11] net/e1000: store and restore TCP SYN filter

2017-06-14 Thread Zhao1, Wei
Hi,Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Monday, June 12, 2017 6:46 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v5 01/11] net/e1000: store and restore TCP > SYN filter > > On 6/12/2017 7:48 AM, Wei Zhao wrote: > > Add support

[dpdk-dev] [PATCH] doc: add igb generic api features update

2017-06-14 Thread Wei Zhao
Add release notes update to announce support of rte_flow on igb nic, and nic features update of this feature. Signed-off-by: Wei Zhao --- doc/guides/nics/features/igb.ini | 1 + doc/guides/rel_notes/release_17_08.rst | 9 + 2 files changed, 10 insertions(+) diff --git a/doc/guides

[dpdk-dev] [PATCH] app/crypto-perf: fix wait for lcores

2017-06-14 Thread Kirill Rybalchenko
After test is finished the main thread waits only for lcores where runners were started, because it is responsibility of multicore scheduler to stop and wait for workers lcores. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") CC: sta...@dpdk.org Signed-off-by: Kiri

[dpdk-dev] [PATCH] app/crypto-perf: stop crypto devices after test is finished

2017-06-14 Thread Kirill Rybalchenko
Call of rte_cryptodev_stop() function from test destructors is added. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: sta...@dpdk.org Signed-off-by: Kirill Rybalchenko --- app/test-crypto-perf/cperf_test_latency.c| 3 ++- app/test-crypto-perf/cperf_test_t

[dpdk-dev] [PATCH] cryptodev: fix device stop function

2017-06-14 Thread Kirill Rybalchenko
Flag dev_started should be cleared after dev_stop() function call because the flag is checked inside the dev_stop() function. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Kirill Rybalchenko --- lib/librte_cryptodev/rte_cry

[dpdk-dev] [PATCH] net/szedata2: remove unused macro

2017-06-14 Thread Matej Vido
Removed macro is not used since commit: 2f3193c ("pci: inherit common driver in PCI driver") Signed-off-by: Matej Vido --- drivers/net/szedata2/rte_eth_szedata2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c

Re: [dpdk-dev] [PATCH] vhost: clean up per-socket mutex

2017-06-14 Thread Jens Freimann
On Mon, Jun 12, 2017 at 02:29:04PM -0700, Daniel Verkamp wrote: > vsocket->conn_mutex was allocated with pthread_mutex_init() but never > freed with pthread_mutex_destroy(). This is a potential memory leak, > depending on how pthread_mutex_t is implemented. > > Signed-off-by: Daniel Verkamp > --

Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: disabled by default

2017-06-14 Thread Gaëtan Rivet
Hi Pablo, On Fri, Jun 09, 2017 at 03:03:08PM +, De Lara Guarch, Pablo wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > > Sent: Thursday, June 08, 2017 12:59 AM > > To: dev@dpdk.org > > Cc: Gaetan Rivet > > Subject: [dpdk-dev] [

Re: [dpdk-dev] [PATCH] net/virtio: zero the whole memory zone

2017-06-14 Thread Jens Freimann
On Mon, Jun 12, 2017 at 12:34:30PM +0800, Tiwei Bie wrote: > Zero the whole memory zone instead of the first few bytes. > > Fixes: c1f86306a026 ("virtio: add new driver") > Cc: sta...@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 2 +- > 1 file changed, 1 in