Re: [dpdk-dev] [PATCH v2 0/3] net/ixgbe: enable signature match and ipv6 for consistent API.

2017-06-07 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, June 8, 2017 7:09 AM > To: Lu, Wenzhuo; Zhang, Helin > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2 0/3] net/ixgbe: enable signature match and ipv6 for > consistent API. > > The patchset is based on > http://dpdk.org/dev

[dpdk-dev] DPDK reception

2017-06-07 Thread reshma sarat
Hi, I am integrating a tool with DPDK. My requirement is to replace the libpcap functions with the DPDK APIs to receive the packet from the NIC card. I tried to replace pcap_open_live() with rte_eth_rx_burst () function. But it is not working as expected. Is there anything wrong with this method.

[dpdk-dev] [PATCH v2 2/3] net/ixgbe: enable signature match for consistent API

2017-06-07 Thread Qi Zhang
Enable signature match for rte_flow API. RTE_FLOW_ITEM_TYPE_FUZZY specify a signature match. Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_flow.c | 71 +++--- 1 file changed, 59 insertions(+), 12 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c

[dpdk-dev] [PATCH v2 1/3] net/ixgbe: replace macro with inline function

2017-06-07 Thread Qi Zhang
Code clean with 2 purposes. 1. No variable "index" needed 2. inline function make it easy and safe when be nest into a loop. Signed-off-by: Qi Zhang --- v2: - Update the commit log drivers/net/ixgbe/ixgbe_flow.c | 208 +++-- 1 file changed, 73 insertions(+),

[dpdk-dev] [PATCH v2 3/3] net/ixgbe: enable IPv6 for consistent API

2017-06-07 Thread Qi Zhang
Enable IPv6 support with rte_flow API. Only support Sigature Match. Signed-off-by: Qi Zhang --- v2: - fix flow type assignment. drivers/net/ixgbe/ixgbe_flow.c | 118 + 1 file changed, 107 insertions(+), 11 deletions(-) diff --git a/drivers/net/ixgbe/ixg

[dpdk-dev] [PATCH v2 0/3] net/ixgbe: enable signature match and ipv6 for consistent API.

2017-06-07 Thread Qi Zhang
The patchset is based on http://dpdk.org/dev/patchwork/patch/25015 http://dpdk.org/dev/patchwork/patch/25185 v2: - add comment to explain macro replacement - fix wrong flow type assignment Qi Zhang (3): net/ixgbe: replace macro with inline function net/ixgbe: enable signature match for cons

[dpdk-dev] [PATCH v2] ethdev: add fuzzy match pattern

2017-06-07 Thread Qi Zhang
Add new meta pattern item RTE_FLOW_TYPE_ITEM_FUZZY. This is for device that support fuzzy match option. Usually a fuzzy match is fast but the cost is accuracy. i.e. Signature Match only match pattern's hash value, but it is possible two different patterns have the same hash value. Matching accur

Re: [dpdk-dev] [PATCH v2 01/11] bus: add bus iterator to find a particular bus

2017-06-07 Thread Shreyansh Jain
Hello Gaëtan, > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, June 07, 2017 6:58 PM > To: Shreyansh Jain > Cc: dev@dpdk.org; Jan Blunck > Subject: Re: [PATCH v2 01/11] bus: add bus iterator to find a particular bus > > On Wed, Jun 07, 2017 at

Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: support ether pattern for FDIR

2017-06-07 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Wednesday, June 7, 2017 4:10 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 4/4] net/i40e: support ether pattern for FDIR > > Previously, i40e PMD will select ethe

Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: support flexible payload parsing for FDIR

2017-06-07 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Wednesday, June 7, 2017 4:10 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/4] net/i40e: support flexible payload > parsing for FDIR > > This patch adds flexible

[dpdk-dev] [PATCH] doc: fix some typos in prog_guide

2017-06-07 Thread Xingyou Chen
Signed-off-by: Xingyou Chen --- doc/guides/prog_guide/perf_opt_guidelines.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/perf_opt_guidelines.rst b/doc/guides/prog_guide/perf_opt_guidelines.rst index 7c24aa485..286bf9837 100644 --- a/doc/guides/prog_

[dpdk-dev] [PATCH v2 4/4] net/mlx5: net bus support

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/mlx5/mlx5.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index bcb2c1b..0ba13e9 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -58,6 +58,7 @@ #include #include

[dpdk-dev] [PATCH v2 3/4] net/mlx4: net bus support

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/mlx4/mlx4.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index b9554d5..9dfff5f 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -62,6 +62

[dpdk-dev] [PATCH v5 12/12] net/failsafe: support flow API isolation mode

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ether.c | 34 +++-- drivers/net/failsafe/failsafe_flow.c| 29 drivers/net/failsafe/failsafe_private.h | 4 3 files changed, 65 insertions(+), 2 deletions(-) diff --g

[dpdk-dev] [PATCH v2 1/4] bus/net: introduce net bus

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- MAINTAINERS | 6 + config/common_linuxapp| 2 + drivers/bus/Makefile | 2 + drivers/bus/net/Makefile | 66 +++ drivers/bus/net/bsd/Makefile

[dpdk-dev] [PATCH v2 0/4] Introduce net bus

2017-06-07 Thread Gaetan Rivet
This new bus takes as devices kernel netdevices. It offers an API for drivers to register a translation layer that would transform the netdev name to one their regular PMD would be able to probe. This is PoC. It currently only works for MLX4 and MLX5 PMDs as they were bifurcated and had very littl

[dpdk-dev] [PATCH v2 2/4] bus/net: implement hotplug bus operations

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/net/rte_bus_net.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/drivers/bus/net/rte_bus_net.c b/drivers/bus/net/rte_bus_net.c index 27a43f4..f5c7c95 100644 --- a/drivers/bus/net/rte_bus_net.c +++ b/driv

[dpdk-dev] [PATCH v5 08/12] net/failsafe: support offload capabilities

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- doc/guides/nics/features/failsafe.ini | 6 ++ drivers/net/failsafe/failsafe_ops.c | 131 +- 2 files changed, 135 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guide

[dpdk-dev] [PATCH v5 11/12] net/failsafe: support link status change event

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_ether.c | 15 +++ drivers/net/failsafe/failsafe_ops.c | 23 +++ drivers/net/failsafe/failsafe_private

[dpdk-dev] [PATCH v5 10/12] net/failsafe: support device removal

2017-06-07 Thread Gaetan Rivet
Listen to INTR_RMV events issued by slaves. Add atomic flags on slave queues to detect use of slave bursts function. If a removal is detected, set the recollection flag on this slave. During a slave upkeep round, if its recollection flag is set and its burst functions are not in use by any thread,

[dpdk-dev] [PATCH v5 09/12] net/failsafe: add fast burst functions

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- drivers/net/failsafe/failsafe_private.h | 8 +++ drivers/net/failsafe/failsafe_rxtx.c| 124 ++-- 2 files changed, 112 insertions(+), 20 deletions(-) diff --git a/drivers/net/failsafe/failsafe_private.h b/dri

[dpdk-dev] [PATCH v5 07/12] net/failsafe: support flow API

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/Makefile | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_eal.c | 1 + drivers/net/failsafe/failsafe_ether.c | 70 +

[dpdk-dev] [PATCH v5 05/12] net/failsafe: add plug-in support

2017-06-07 Thread Gaetan Rivet
Periodically check for the existence of a device. If a device has not been initialized and exists on the system, then it is probed and configured. The configuration process strives to synchronize the states between the plugged-in sub-device and the fail-safe device. Signed-off-by: Gaetan Rivet A

[dpdk-dev] [PATCH v5 04/12] net/failsafe: add fail-safe PMD

2017-06-07 Thread Gaetan Rivet
Introduce the fail-safe poll mode driver initialization and enable its build infrastructure. This PMD allows for applications to benefit from true hot-plugging support without having to implement it. It intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes

[dpdk-dev] [PATCH v5 06/12] net/failsafe: add flexible device definition

2017-06-07 Thread Gaetan Rivet
Add the "exec" device type. The parameters given to this type of device will be executed in a shell. The output of this command is then used as a definition for a device. That command can be re-interpreted if the related device is not plugged-in. It allows for a device definition to react to syste

[dpdk-dev] [PATCH v5 02/12] ethdev: add deferred intermediate device state

2017-06-07 Thread Gaetan Rivet
This device state means that the device is managed externally, by whichever party has set this state (PMD or application). Note: this new device state is only an information. The related device structure and operators are still valid and can be used normally. It is however made private by device

[dpdk-dev] [PATCH v5 03/12] ethdev: count devices consistently

2017-06-07 Thread Gaetan Rivet
Make the rte_eth_dev_count() return the number of available devices even after some are detached by the hotplug API or put in a deferred state. Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 16 +--- lib/librte_ether/rte_ethdev.h | 13 ++--- 2 files changed,

[dpdk-dev] [PATCH v5 00/12] introduce fail-safe PMD

2017-06-07 Thread Gaetan Rivet
This PMD intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes them transparently when brought back so that existing applications do not need to be modified to benefit from true hot-plugging support. The stacked PMD approach shares many similarities with the

[dpdk-dev] [PATCH v5 01/12] ethdev: save VLAN filter setting

2017-06-07 Thread Gaetan Rivet
Other configuration items (i.e. MAC addresses) are stored within rte_eth_dev_data, but not this one. Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 19 ++- lib/librte_ether/rte_ethdev.h | 10 ++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2 10/12] bus/pci: follow checkpatch

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/pci/include/rte_pci.h | 102 -- 1 file changed, 64 insertions(+), 38 deletions(-) diff --git a/drivers/bus/pci/include/rte_pci.h b/drivers/bus/pci/include/rte_pci.h index 45c5082..25adbed 100644 --- a/drivers/bus/pc

[dpdk-dev] [PATCH v2 12/12] drivers: update cryptodev dependencies

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/Makefile b/drivers/Makefile index 84a4864..4a92422 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -39,7 +39,7 @@ DEPDIRS-mempool := bus DIRS-y += net DEPDIRS-net

[dpdk-dev] [PATCH v2 11/12] drivers: update eventdev dependencies

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/Makefile b/drivers/Makefile index f3f9417..84a4864 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -41,5 +41,6 @@ DEPDIRS-net := bus pmdinfogen mempool DIRS-$(CONFIG_RTE_LIBRTE_CR

[dpdk-dev] [PATCH v2 07/12] pdump: disabled by default

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- config/common_base | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_base b/config/common_base index cade611..8ec5e4e 100644 --- a/config/common_base +++ b/config/common_base @@ -700,7 +700,7 @@ CONFIG_RTE_KNI_PREEMPT_DEFAULT=y # #

[dpdk-dev] [PATCH v2 08/12] kni: disabled by default

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- config/common_linuxapp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_linuxapp b/config/common_linuxapp index b3cf41b..cc85cc6 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -38,7 +38,7 @@ CONFIG_RTE_EXEC_ENV_

[dpdk-dev] [PATCH v2 05/12] pmdinfogen: move to drivers subdirectory

2017-06-07 Thread Gaetan Rivet
pmdinfogen has a dependency on the PCI bus. The latter must be built first. Signed-off-by: Gaetan Rivet --- GNUmakefile| 2 +- MAINTAINERS| 2 +- buildtools/Makefile| 36 buildtools/pmdinfogen/Makefile | 47 - bui

[dpdk-dev] [PATCH v2 06/12] cryptodev: disabled by default

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- config/common_base | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_base b/config/common_base index 0e0b732..cade611 100644 --- a/config/common_base +++ b/config/common_base @@ -430,7 +430,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y # #

[dpdk-dev] [PATCH 0/8] bus/pci: remove PCI bus from EAL

2017-06-07 Thread Gaetan Rivet
This patchset moves the PCI bus out of the EAL to the drivers/bus subdirectory. The last remaining dependencies have been worked out and the PCI bus is now ready to be moved. Several issues remain: * librte_cryptodev * librte_pdump * librte_kni All depend on the PCI bus being available within

[dpdk-dev] [PATCH v2 03/12] bus: properly include rte_debug

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c index bad1bd9..ebb5587 100644 --- a/lib/librte_eal/common/eal_common_bus.c +++ b/lib/librte_e

[dpdk-dev] [PATCH v2 04/12] eal: remove references to PCI

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/eal.c | 1 - lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +- lib/librte_eal/common/eal_common_pci.c | 2 +- lib/librte_eal/common/eal_common_pci_uio.c | 3 +- lib/librte_eal/common/eal_private.h |

[dpdk-dev] [PATCH v2 01/12] eal: expose rte_eal_using_phys_addrs

2017-06-07 Thread Gaetan Rivet
This function was previously private to the EAL layer. Other subsystems requires it, such as the PCI bus. This function is only exposed for linuxapps. In order not to force other components to include stdbool, which is incompatible with several NIC drivers, the return type has been changed from b

[dpdk-dev] [PATCH v2 02/12] ethdev: remove useless PCI dependency

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index bc603c1..2446ed9 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -47,7 +47,6 @@ #

[dpdk-dev] [PATCH v3 2/3] dev: remove vdev function dependency

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 50 -- 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index 8ef9b98..247c9c1 100644 --- a/lib/

[dpdk-dev] [PATCH v3 3/3] vdev: use standard bus registration function

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index d921345..d007e7e 100644 --- a/lib/librte_eal/comm

[dpdk-dev] [PATCH v3 0/3] eal: complete attach / detach support

2017-06-07 Thread Gaetan Rivet
Implements attach / detach for the PCI bus, and a streamlined attach for the virtual bus. This is necessary to remove the final dependencies of the EAL on the virtual and PCI buses, due to the rte_eal_dev_attach and rte_eal_dev_detach functions. This patchset depends on: pci: implement find_devi

[dpdk-dev] [PATCH v3 1/3] pci: implement hotplug bus operation

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 67 ++ 1 file changed, 67 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index b4f8056..6049b49 100644 --- a/lib/librte_eal/common

[dpdk-dev] [PATCH v4 19/19] eal: change whitelist / blacklist command line doc

2017-06-07 Thread Gaetan Rivet
The use of these commands have evolved. It is now possible to use whitelist and blacklist on any bus. Update the source code accordingly. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_options.c | 18 +- lib/librte_eal/common/eal_options.h| 8

[dpdk-dev] [PATCH v4 18/19] devargs: remove function

2017-06-07 Thread Gaetan Rivet
This function is now necessary due to the new unplug rte_bus API. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_devargs.c | 18 ++ lib/librte_eal/common/include/rte_devargs.h | 14 ++

[dpdk-dev] [PATCH v4 17/19] devargs: clone function

2017-06-07 Thread Gaetan Rivet
This function returns a deep copy of an rte_devargs. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_devargs.c | 20 lib/librte_eal/common/include/rte_devargs.h | 12 lib/librte_ea

[dpdk-dev] [PATCH v4 14/19] net/virtio: do not reference device type

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/virtio/virtio_pci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c index b7b3d61..cd48fb5 100644 --- a/drivers/net/virtio/virtio_pci.c +++ b/drivers/net/virtio/v

[dpdk-dev] [PATCH v4 13/19] pci: update device name

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 83ae378..a31e490 100644 --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_e

[dpdk-dev] [PATCH v4 15/19] devargs: generic device types

2017-06-07 Thread Gaetan Rivet
rte_devargs now represents any device from any bus. The related devtypes do not identify a bus anymore, only which scan policy the device subscribes to. The bus itself is identified by a bus handle previously introduced. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c

[dpdk-dev] [PATCH v4 16/19] devargs: introduce cleaner parsing helper

2017-06-07 Thread Gaetan Rivet
Introduce a more versatile helper to parse device strings. This helper expects a generic rte_devargs structure as storage in order not to require any API changes in the future, should this structure be updated. The old equivalent function is thus being deprecated, as its API does not allow to acco

[dpdk-dev] [PATCH v4 12/19] devargs: generic device representation

2017-06-07 Thread Gaetan Rivet
Remove the dependency of this subsystem upon bus specific device representation. Devargs only validates that a device declaration is correct and handled by a bus. The device interpretation is done afterward within the bus. Signed-off-by: Gaetan Rivet --- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v4 08/19] test: properly reference PCI header

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- test/test/virtual_pmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c index e9dd8ac..f3ee82f 100644 --- a/test/test/virtual_pmd.c +++ b/test/test/virtual_pmd.c @@ -33,6 +33,7 @@ #include #include +#inclu

[dpdk-dev] [PATCH v4 11/19] devargs: parse bus policies

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 8bb72a2..a5014bf 100644 --- a/lib/librte_eal/common/eal_co

[dpdk-dev] [PATCH v4 09/19] dev: device kernel module is a device attribute

2017-06-07 Thread Gaetan Rivet
It is used in generic device structures and must not be tied to a bus. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_dev.h | 12 lib/librte_eal/common/include/rte_pci.h | 9 - 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH v4 10/19] bus: introduce bus scan policies

2017-06-07 Thread Gaetan Rivet
Scan policies describe the way a bus should scan the system to search for possible devices. Three flags are introduced: RTE_BUS_SCAN_UNDEFINED: Configuration is irrelevant for this bus RTE_BUS_SCAN_WHITELIST: Scanning should be limited to declared devices RTE_BUS_SCAN_BLACKLIST: Scanning sho

[dpdk-dev] [PATCH v4 07/19] app/testpmd: properly reference PCI header

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- app/test-pmd/testpmd.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 1838241..90a6568 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -34,6 +34,8 @@ #ifndef _TESTPMD_H_ #define _TES

[dpdk-dev] [PATCH v4 06/19] net/sfc: properly reference PCI header

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/sfc/sfc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h index 007ed24..41dff48 100644 --- a/drivers/net/sfc/sfc.h +++ b/drivers/net/sfc/sfc.h @@ -34,6 +34,7 @@ #include +#include #include #in

[dpdk-dev] [PATCH v4 05/19] net/ixgbe: properly reference PCI header

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/ixgbe/ixgbe_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h index e2d0139..bb5ecd5 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.h +++ b/drivers/net/ixgbe/ixgbe_ethdev.h @@ -

[dpdk-dev] [PATCH v4 04/19] net/e1000: properly reference PCI header

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/e1000/e1000_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/e1000_ethdev.h b/drivers/net/e1000/e1000_ethdev.h index 4979895..ac380ed 100644 --- a/drivers/net/e1000/e1000_ethdev.h +++ b/drivers/net/e1000/e1000_ethdev.h @@ -

[dpdk-dev] [PATCH v4 03/19] net/mlx5: properly reference PCI header

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/mlx5/mlx5.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 1148dee..9ef2c11 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -54,6 +54,7 @@ #ifdef PEDANTIC #pragma GCC d

[dpdk-dev] [PATCH v4 01/19] net/bonding: properly reference PCI header

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/bonding/rte_eth_bond_args.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index dc468d2..ed217fb 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/

[dpdk-dev] [PATCH v4 00/19] Generic devargs parsing

2017-06-07 Thread Gaetan Rivet
The second part of the work outlined in [1] and [2]. The first part is at [3]. In this patchset, the representation of devices in rte_devargs is made generic to remove some dependencies of the EAL on specific buses implementations. Following the device types being characterized by their bus, the D

[dpdk-dev] [PATCH v4 02/19] net/bnxt: properly reference PCI header

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/bnxt/bnxt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 54428ba..4609792 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -38,6 +38,7 @@ #include #include +#inclu

[dpdk-dev] [PATCH v4 9/9] devargs: parse bus info

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 17 - lib/librte_eal/common/eal_common_vdev.c | 6 -- lib/librte_eal/common/include/rte_devargs.h | 3 +++ 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/

[dpdk-dev] [PATCH v4 6/9] bus: add helper to find a bus from a bus name

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++ lib/librte_eal/common/eal_common_bus.c | 19 +++ lib/librte_eal/common/include/rte_bus.h | 14 ++ lib/librte_eal/linuxapp/eal/rte_eal_version.map | 7 +++

[dpdk-dev] [PATCH v4 4/9] vdev: implement parse bus operation

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 60 + 1 file changed, 31 insertions(+), 29 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 22e4640..8dd4c88 100644 --- a/li

[dpdk-dev] [PATCH v4 8/9] vdev: expose bus name

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 2 +- lib/librte_eal/common/include/rte_vdev.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 8dd4c88..221146e

[dpdk-dev] [PATCH v4 7/9] bus: add helper to find a bus from a device name

2017-06-07 Thread Gaetan Rivet
Find which bus should be able to parse this device name into an internal device representation. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 15 +++ lib/librte_eal/common/include/rte_bus.h

[dpdk-dev] [PATCH v4 5/9] pci: implement parse bus operation

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 5a8478c..3075eee 100644 --- a/lib/librte_eal/common/eal_common_pci

[dpdk-dev] [PATCH v4 3/9] bus: introduce parsing functionality

2017-06-07 Thread Gaetan Rivet
This operation can be used either to validate that a device representation can be understood by a bus, as well as store the resulting specialized device representation in any format determined by the bus. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 21 ++

[dpdk-dev] [PATCH v4 2/9] bus: verify bus name on registration

2017-06-07 Thread Gaetan Rivet
Verify that a bus name is legal. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 13 + lib/librte_eal/common/eal_private.h| 16 2 files changed, 29 insertions(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/commo

[dpdk-dev] [PATCH v4 0/9] rte_bus parse API

2017-06-07 Thread Gaetan Rivet
Following the evolutions announced in [1], here is the first part of the rte_devargs rework planned for 17.08. The rationale has been partially explained in [2]. This first part covers the introduction of the necessary facilities in rte_bus to allow for generic device parsing. This API is implemen

[dpdk-dev] [PATCH v4 1/9] bus: fix bus name registration

2017-06-07 Thread Gaetan Rivet
The default bus registration function should not result in buses registering with double quotes within their names. Fixes: a97725791eec ("bus: introduce bus abstraction") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 2 +- 1 file changed, 1 insert

[dpdk-dev] [PATCH v3] pci: implement find_device bus operation

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- This patch depends on: bus: attach / detach API http://dpdk.org/ml/archives/dev/2017-May/066330.html http://dpdk.org/dev/patchwork/patch/24489/ v1 --> v2 * Use the newly defined rte_dev_match_t type v2 --> v3 * Use new comparison behavior. --- lib/librte_ea

[dpdk-dev] [PATCH v3 10/10] net/ring: fix dev handle in eth_dev

2017-06-07 Thread Gaetan Rivet
The ring PMD uses special eth_dev allocators, which cannot be updated to accept an rte_vdev_device. Circumvent the limitation and store the rte_device handle in the rte_eth_dev structure. Fixes: 050fe6e9ff97 ("drivers/net: use ethdev allocation helper for vdev") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v3 09/10] ethdev: use embedded rte_device to detach driver

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_dev.c| 43 --- lib/librte_eal/common/include/rte_dev.h | 11 +++ lib/librte_ether/rte_ethd

[dpdk-dev] [PATCH v3 08/10] eal: make virtual driver probe and remove take rte_vdev_device

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck This is a preparation to embed the generic rte_device into the rte_eth_dev also for virtual devices. Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 93 ++ 1 file changed, 71 insertions(+), 22

[dpdk-dev] [PATCH v3 07/10] vdev: implement hotplug functionality

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 36 + 1 file changed, 36 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 52528ef..22e4640 100644 --- a/lib/librte_eal/comm

[dpdk-dev] [PATCH v3 06/10] vdev: implement find_device bus operation

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 0037a64..52528ef 100644

[dpdk-dev] [PATCH v3 03/10] bus: add helper to find bus for a particular device

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 24 lib/librte_eal/common/include/rte_bus.h | 5 + lib/librte_eal/linuxapp/

[dpdk-dev] [PATCH v3 05/10] bus: introduce hotplug functionality

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 2 ++ lib/librte_eal/common/include/rte_bus.h | 31 +++ 2 files changed, 33 insertions(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/li

[dpdk-dev] [PATCH v3 04/10] bus: add bus helper iterator to find a particular device

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 25 + lib/librte_eal/common/include/rte_bus.h | 23 +++ lib/l

[dpdk-dev] [PATCH v3 02/10] bus: add device iterator

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 7 +++ lib/librte_eal/common/include/rte_dev.h | 17 + 2 files changed, 24 insertions(+) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte

[dpdk-dev] [PATCH v3 00/10] bus: attach / detach API

2017-06-07 Thread Gaetan Rivet
Following the work from Jan: This patchset introduces the attach / detach API to rte_bus. The rte_device structure is used as the generic device representation. This API is implemented for the virtual bus. The functions rte_eal_dev_attach and rte_eal_dev_detach are updated to use this new interfa

[dpdk-dev] [PATCH v3 01/10] bus: add bus iterator to find a particular bus

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 11 lib/librte_eal/common/include/rte_bus.h | 34 + lib/librte_eal/linux

Re: [dpdk-dev] [RFC PATCH] replace DPDK config and build system

2017-06-07 Thread Stephen Hemminger
On Wed, 7 Jun 2017 11:47:42 +0100 Bruce Richardson wrote: > The prototype is incomplete, but it does build a reasonable number of our > libraries, some unit tests, the i40e PMD and the testpmd binary, and I have > successfully passed traffic using testpmd from the build. Some things are > not fu

Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver

2017-06-07 Thread Gaëtan Rivet
Hi Pablo, On Wed, May 24, 2017 at 04:27:02PM +0100, Pablo de Lara wrote: > Following the same aproach taken for ethdev, this patch series > removes the PCI specific structure cryptodev driver from rte_cryptodev. > > The patchset makes the following changes: > > - Moves the virtual and PCI device

Re: [dpdk-dev] [PATCH v2 04/11] bus: add bus helper iterator to find a particular device

2017-06-07 Thread Gaëtan Rivet
On Wed, Jun 07, 2017 at 06:41:58PM +0200, Jan Blunck wrote: > On Wed, May 31, 2017 at 3:17 PM, Gaetan Rivet wrote: > > From: Jan Blunck > > > > Signed-off-by: Jan Blunck > > Signed-off-by: Gaetan Rivet > > --- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > lib/librte_eal/commo

Re: [dpdk-dev] [PATCH 7/9] bus: add helper to find a bus from a device name

2017-06-07 Thread Gaëtan Rivet
On Wed, Jun 07, 2017 at 07:28:07PM +0200, Jan Blunck wrote: > On Wed, May 24, 2017 at 5:12 PM, Gaetan Rivet wrote: > > Find which bus should be able to parse this device name into an internal > > device representation. > > > > No, please don't add this. One should know to what bus a device > belo

Re: [dpdk-dev] [PATCH 0/9] rte_bus parse API

2017-06-07 Thread Gaëtan Rivet
On Wed, Jun 07, 2017 at 07:22:05PM +0200, Jan Blunck wrote: > On Wed, May 24, 2017 at 5:12 PM, Gaetan Rivet wrote: > > Following the evolutions announced in [1], here is the first part of > > the rte_devargs rework planned for 17.08. The rationale has been partially > > explained in [2]. > > > > T

Re: [dpdk-dev] [PATCH 2/2] vhost: fix IP csum not calculated

2017-06-07 Thread Maxime Coquelin
On 06/07/2017 08:41 AM, Jianfeng Tan wrote: There is no way to bypass IP checksum verification in Linux kernel, no matter skb->ip_summed is assigned as CHECKSUM_UNNECESSARY or CHECKSUM_PARTIAL. So any packets with bad IP checksum will be dropped at VM IP layer. To correct, we check this flag

Re: [dpdk-dev] [PATCH 1/2] vhost: fix TCP csum not set

2017-06-07 Thread Maxime Coquelin
On 06/07/2017 08:41 AM, Jianfeng Tan wrote: As PKT_TX_TCP_SEG flag in mbuf->ol_flags implies PKT_TX_TCP_CKSUM, applications, e.g., testpmd, don't set PKT_TX_TCP_CKSUM when TSO is set. This leads to that packets get dropped in VM tcp stack layer because of bad TCP csum. To fix this, we make su

Re: [dpdk-dev] [RFC PATCH] build for DPDK with meson and ninja

2017-06-07 Thread Jerin Jacob
-Original Message- > Date: Wed, 7 Jun 2017 11:47:43 +0100 > From: Bruce Richardson > To: dev@dpdk.org > CC: Bruce Richardson > Subject: [dpdk-dev] [RFC PATCH] build for DPDK with meson and ninja > X-Mailer: git-send-email 2.9.4 > > to use, need to have meson >= 0.4 and ninja-build packag

Re: [dpdk-dev] [PATCH v4 00/12] introduce fail-safe PMD

2017-06-07 Thread Stephen Hemminger
On Mon, 29 May 2017 15:42:12 +0200 Gaetan Rivet wrote: > This PMD intercepts and manages Ethernet device removal events issued by > slave PMDs and re-initializes them transparently when brought back so that > existing applications do not need to be modified to benefit from true > hot-plugging sup

Re: [dpdk-dev] [PATCH 7/9] bus: add helper to find a bus from a device name

2017-06-07 Thread Jan Blunck
On Wed, May 24, 2017 at 5:12 PM, Gaetan Rivet wrote: > Find which bus should be able to parse this device name into an internal > device representation. > No, please don't add this. One should know to what bus a device belongs to before plugging it. Artificially encoding the parent bus into the d

Re: [dpdk-dev] [PATCH 0/9] rte_bus parse API

2017-06-07 Thread Jan Blunck
On Wed, May 24, 2017 at 5:12 PM, Gaetan Rivet wrote: > Following the evolutions announced in [1], here is the first part of > the rte_devargs rework planned for 17.08. The rationale has been partially > explained in [2]. > > This first part covers the introduction of the necessary facilities in >

Re: [dpdk-dev] [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots

2017-06-07 Thread Ferruh Yigit
On 5/11/2017 12:51 PM, Gowrishankar wrote: > From: Gowrishankar Muthukrishnan > > In kni_allocate_mbufs(), we attempt to add max_burst (32) count of mbuf > always into alloc_q, which is excessively leading too many rte_pktmbuf_ > free() when alloc_q is contending at high packet rate (for eg 10Gig

Re: [dpdk-dev] [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots

2017-06-07 Thread Ferruh Yigit
On 6/6/2017 3:43 PM, gowrishankar muthukrishnan wrote: > Hi Ferruh, > Just wanted to check with you on the verdict of this patch, whether we > are waiting for > any objection/ack ?. I was waiting for more comment, I will ack explicitly. > > Thanks, > Gowrishankar > > On Thursday 01 June 2017 0

  1   2   >