[dpdk-dev] [PATCH] doc: update virtio doc

2017-05-09 Thread Zhiyong Yang
Add more explanations about vring size changes and virtio_header size. Signed-off-by: Zhiyong Yang --- doc/guides/nics/virtio.rst | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 91bedea..36ddd08 10064

Re: [dpdk-dev] [PATCH v2] doc: update release notes for 17.05

2017-05-09 Thread Shreyansh Jain
On Wednesday 10 May 2017 10:29 AM, Shreyansh Jain wrote: Hello John, Some super trivial comments inline: On Tuesday 09 May 2017 10:26 PM, John McNamara wrote: Fix grammar, spelling and formatting of DPDK 17.05 release notes. Signed-off-by: John McNamara --- V2: Added updated MLX4/5 text. Th

Re: [dpdk-dev] [PATCH v2] doc: update release notes for 17.05

2017-05-09 Thread Shreyansh Jain
Hello John, Some super trivial comments inline: On Tuesday 09 May 2017 10:26 PM, John McNamara wrote: Fix grammar, spelling and formatting of DPDK 17.05 release notes. Signed-off-by: John McNamara --- V2: Added updated MLX4/5 text. This patch supercedes patch 24166. doc/guides/rel_notes/re

Re: [dpdk-dev] [PATCH 5/5] examples/l3fwd: add neon support for l3fwd

2017-05-09 Thread Jianbo Liu
Hi Ashwin, On 9 May 2017 at 16:10, Sekhar, Ashwin wrote: > On Fri, 2017-05-05 at 13:43 +0800, Jianbo Liu wrote: >> On 5 May 2017 at 12:24, Sekhar, Ashwin >> wrote: >> > >> > On Thu, 2017-05-04 at 16:42 +0800, Jianbo Liu wrote: >> > > >> > > Hi Ashwin, >> > > >> > > On 3 May 2017 at 13:24, Jianbo

Re: [dpdk-dev] [PATCH v2 02/42] eal: parse "driver" device argument before probing drivers

2017-05-09 Thread Ferruh Yigit
On 4/11/2017 4:44 PM, Gaetan Rivet wrote: > From: Jan Blunck > > In some cases the virtual device name should be totally different than > the driver being used for the device. Therefore lets parse the devargs for > the "driver" argument before probing drivers in vdev_probe_all_drivers(). Hi Gaet

[dpdk-dev] [PATCH v2 6/7] examples/l3fwd: add the times of hash multi-lookup for different Archs

2017-05-09 Thread Jianbo Liu
New micro to define how many times of hash lookup in one time, and this makes the code more concise. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_em_hlm.h | 241 +- 1 file changed, 71 insertions(+), 170 deletions(-) diff --git a/examples/l3fwd/l3fwd

[dpdk-dev] [PATCH v2 4/7] examples/l3fwd: rearrange the code for lpm_l3fwd

2017-05-09 Thread Jianbo Liu
Signed-off-by: Jianbo Liu Some common code can be used by other ARCHs, move to l3fwd_lpm.c --- examples/l3fwd/l3fwd_lpm.c | 83 ++ examples/l3fwd/l3fwd_lpm.h | 26 + examples/l3fwd/l3fwd_lpm_sse.h | 66 -

[dpdk-dev] [PATCH v2 7/7] examples/l3fwd: change the guard micro name for header file

2017-05-09 Thread Jianbo Liu
As l3fwd_em_sse.h is renamed to l3fwd_em_sequential.h, change the macro to __L3FWD_EM_SEQUENTIAL_H__ to maintain consistency. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_em_sequential.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/l3fwd/l3fwd_em_seque

[dpdk-dev] [PATCH v2 5/7] examples/l3fwd: add neon support for l3fwd

2017-05-09 Thread Jianbo Liu
Use ARM NEON intrinsics to accelerate l3 fowarding. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_em.c| 4 +- examples/l3fwd/l3fwd_em_hlm.h| 19 ++- examples/l3fwd/l3fwd_em_hlm_neon.h | 74 ++ examples/l3fwd/l3fwd_em_sequential.h | 20 ++- examples/l3fwd/l

[dpdk-dev] [PATCH v2 2/7] examples/l3fwd: rename l3fwd_em_sse.h to l3fwd_em_sequential.h

2017-05-09 Thread Jianbo Liu
The l3fwd_em_sse.h is enabled by NO_HASH_LOOKUP_MULTI. Renaming it because it's only for sequential hash lookup, and doesn't include any x86 SSE instructions. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_em.c| 2 +- examples/l3fwd/{l3fwd_em_sse.h => l3fwd_em

[dpdk-dev] [PATCH v2 1/7] examples/l3fwd: extract arch independent code from multi hash lookup

2017-05-09 Thread Jianbo Liu
Extract common code from l3fwd_em_hlm_sse.h, and add to the new file l3fwd_em_hlm.h. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_em.c | 2 +- examples/l3fwd/l3fwd_em_hlm.h | 302 ++ examples/l3fwd/l3fwd_em_hlm_sse.h | 280 +

[dpdk-dev] [PATCH v2 0/7] accelerate examples/l3fwd with NEON on ARM64 platform

2017-05-09 Thread Jianbo Liu
v2: - change name of l3fwd_em_sse.h to l3fwd_em_sequential.h - add the times of hash multi-lookup for different Archs - performance tuning on ThunderX: prefetching, set NO_HASH_LOOKUP_MULTI ... Jianbo Liu (7): examples/l3fwd: extract arch independent code from multi hash lookup examples/

[dpdk-dev] [PATCH v2 3/7] examples/l3fwd: extract common code from multi packet send

2017-05-09 Thread Jianbo Liu
Keep x86 related code in l3fwd_sse.h, and move common code to l3fwd_common.h, which will be used by other Archs. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_common.h | 293 ++ examples/l3fwd/l3fwd_sse.h| 255 +---

Re: [dpdk-dev] [PATCH v2] vhost: workaround MQ fails to startup

2017-05-09 Thread Yang, Zhiyong
Hi, all: The patch which is used to fix the Qemu bug has been accepted in qemu community. http://patchwork.ozlabs.org/patch/760118/ Thanks Zhiyong > -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Friday, April 28, 2017 12:29 PM > To: Maxime C

[dpdk-dev] [PATCH v2] doc: update ixgbe doc about mdd in kernel pf

2017-05-09 Thread Wenzhuo Lu
Add a better explanation about how to disable MDD (Malicious Driver Detection) in a kernel PF. Signed-off-by: Wenzhuo Lu --- V2: fix wording. doc/guides/nics/ixgbe.rst | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ix

Re: [dpdk-dev] [PATCH] doc: update ixgbe doc

2017-05-09 Thread Lu, Wenzhuo
Hi John, > -Original Message- > From: Mcnamara, John > Sent: Wednesday, May 10, 2017 12:39 AM > To: Lu, Wenzhuo; dev@dpdk.org > Subject: RE: [PATCH] doc: update ixgbe doc > > > > > -Original Message- > > From: Lu, Wenzhuo > > Sent: Wednesday, May 3, 2017 6:55 AM > > To: dev@dpdk

Re: [dpdk-dev] [PATCH v2 0/2] net/mlx5: fix erroneous index handling for Tx ring

2017-05-09 Thread Adrien Mazarguil
On Tue, May 09, 2017 at 01:49:29PM -0700, Yongseok Koh wrote: > This patchset is to fix a critical bug which can occur in case of resource > deficiency on Tx path. Flowing multi-segment packets can accelerate the > occurrence rate. > > v2: > * Split the patch into two separate ones to make back-po

Re: [dpdk-dev] [PATCH] vfio: use right index when tracking devices in a vfio group

2017-05-09 Thread Alejandro Lucero
Hi Anatoly, On Tue, May 9, 2017 at 4:18 PM, Burakov, Anatoly wrote: > Hi Alejandro, > > > From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] > > Sent: Monday, May 8, 2017 6:44 PM > > To: dev@dpdk.org > > Cc: Burakov, Anatoly ; > > jerin.ja...@caviumnetworks.com; tho...@monjalon.net >

[dpdk-dev] Question about driver/controller MTU enforcement with MTU less than jumbo frame size

2017-05-09 Thread Coulson, Ken
Is it possible to have an MTU enforced on rx that is less than jumbo size frames? >From the DPDK driver code snippet for ixgbe if MTU < 1518 then the jumbo_frame >control bit in the chip is set to 0. The controller manual says the maximum frame size is only meaningful when the jumbo_frame contro

[dpdk-dev] [PATCH v2 2/2] net/mlx5: change error-prone code on Tx path

2017-05-09 Thread Yongseok Koh
In the main loop of mlx5_tx_burst(), poitners/indexes are advanced at the beginning. Therefore, those should be rolled back if checking resource availability fails and breaks the loop. And some of them are even redundant. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 34

[dpdk-dev] [PATCH v2 1/2] net/mlx5: fix erroneous index handling for Tx ring

2017-05-09 Thread Yongseok Koh
In case of resource deficiency on Tx, mlx5_tx_burst() breaks the loop without rolling back consumed resources (txq->wqes[] and txq->elts[]). This can make application crash because unposted mbufs can be freed while processing completions. Other Tx functions don't have this issue. Fixes: 3f13f8c23a

[dpdk-dev] [PATCH v2 0/2] net/mlx5: fix erroneous index handling for Tx ring

2017-05-09 Thread Yongseok Koh
This patchset is to fix a critical bug which can occur in case of resource deficiency on Tx path. Flowing multi-segment packets can accelerate the occurrence rate. v2: * Split the patch into two separate ones to make back-port easier. * Added "Fiexes:" tag and "CC: sta...@dpdk.org" for the bug fix

[dpdk-dev] [RFC] eventdev: add event adapter for ethernet Rx queues

2017-05-09 Thread Gage Eads
From: Nikhil Rao Eventdev-based networking applications require a component to dequeue packets from NIC Rx queues and inject them into eventdev queues[1]. While some platforms (e.g. Cavium Octeontx) do this operation in hardware, other platforms use software. This RFC introduces an ethernet Rx e

Re: [dpdk-dev] [PATCH] eventdev: abstract ethdev HW capability to inject packets

2017-05-09 Thread Eads, Gage
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Saturday, May 6, 2017 8:08 AM > To: Eads, Gage > Cc: dev@dpdk.org; tho...@monjalon.net; Richardson, Bruce > ; Van Haaren, Harry > ; hemant.agra...@nxp.com; > nipun.gu...@nxp.com; Vangati, Nar

Re: [dpdk-dev] [RFC 17.08] Flow classification library

2017-05-09 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, May 9, 2017 3:38 PM > To: Morten Brørup; Mcnamara, John; dev@dpdk.org > Cc: Tahhan, Maryam; Gaëtan Rivet > Subject: Re: [dpdk-dev] [RFC 17.08] Flow classification library > > On 5/6/20

Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev

2017-05-09 Thread Ananyev, Konstantin
> > This is an ABI change notice for DPDK 17.08 in librte_ether > about changes in rte_eth_txmode structure. > > Currently Tx offloads are enabled by default, and can be disabled > using ETH_TXQ_FLAGS_NO* flags. This behaviour is not consistent with > the Rx side where the Rx offloads are disab

[dpdk-dev] Missing Null check in ip_frag_find?

2017-05-09 Thread Padam Jeet Singh
Hi, I have been trying to trace a segfault in ip_frag_find which I am seeing in production for some time now. In the following code in function ip_frag_find from ip_frag_internal.c, the lru is not being validated for being not null. At this point the table is guaranteed to have an entry in the

Re: [dpdk-dev] Fwd: Sharing tables among pipelines

2017-05-09 Thread Nidhia Varghese
Hi all, Thanks for your reply. As given in the link(3rd point), what I need is single writer thread(pipeline) performing table entry add/delete operations and another thread(which is in turn another pipeline) that performs lookup operations to the same table entries. Thanks, Nidhia Varghese

[dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update beginning in 17.05-rc3?

2017-05-09 Thread Roger B Melton
After updating to 17.05-rc4 I hit a crash in drivers/net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update(). The issue was a NULL get_media_type FV for the VF driver. Looking at recent commits, I see the following added the get_media_type() check: commit c12d22f65b132c56db7b4fdbfd5ddce27d1e957

Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev

2017-05-09 Thread Jerin Jacob
-Original Message- > Date: Tue, 9 May 2017 15:40:04 +0200 > From: Adrien Mazarguil > To: Shahaf Shuler , Konstantin Ananyev > , Olivier Matz , > Tomasz Kulasek > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev > > On Mon, May 01, 2017 at 09:58:12AM

[dpdk-dev] [PATCH v2] doc: update release notes for 17.05

2017-05-09 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 17.05 release notes. Signed-off-by: John McNamara --- V2: Added updated MLX4/5 text. This patch supercedes patch 24166. doc/guides/rel_notes/release_17_05.rst | 197 +++-- 1 file changed, 91 insertions(+), 106 deletions(-

Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev

2017-05-09 Thread Shahaf Shuler
Tuesday, May 9, 2017 4:49 PM, Ferruh Yigit: > On 5/1/2017 7:58 AM, Shahaf Shuler wrote: > > I understand the consistency part, but why PMD performs better when Tx > offload disabled? > Well Adrien pretty much summarized it [1]. Tx offload consumes cycles, for examples checksum or TSO. Since tho

Re: [dpdk-dev] How to using add/lookup hash table in multithread environment

2017-05-09 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > vuon...@viettel.com.vn > Sent: Friday, May 5, 2017 5:52 AM > To: dev@dpdk.org > Subject: [dpdk-dev] How to using add/lookup hash table in multithread > environment > > Hi DPDK team, > I am using DPDK to build a

Re: [dpdk-dev] How to using add/lookup hash table in multithread environment

2017-05-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Dumitrescu, Cristian > Sent: Tuesday, May 9, 2017 7:49 PM > To: 'vuon...@viettel.com.vn' ; dev@dpdk.org > Subject: RE: [dpdk-dev] How to using add/lookup hash table in multithread > environment > > > > > -Original Message- > > From: dev [mailto:dev-

Re: [dpdk-dev] [PATCH] doc: API change notice for librte_table

2017-05-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > Sent: Tuesday, May 2, 2017 7:23 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: API change notice for librte_table > > Signed-off-by: Cristian Dumitrescu > --- > doc/guides/rel_no

Re: [dpdk-dev] [PATCH] doc: update ixgbe doc

2017-05-09 Thread Mcnamara, John
> -Original Message- > From: Lu, Wenzhuo > Sent: Wednesday, May 3, 2017 6:55 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; Lu, Wenzhuo > > Subject: [PATCH] doc: update ixgbe doc > > Add more explanation about how to disable MDD on kernel PF. > > Signed-off-by: Wenzhuo Lu > --- > doc/g

Re: [dpdk-dev] [PATCH] doc: API change notice for librte_table

2017-05-09 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > Sent: Tuesday, May 2, 2017 7:23 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: API change notice for librte_table > > Signed-off-by: Cristian Dumitrescu > --- > doc/guides/rel_no

Re: [dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2017-05-09 Thread Mcnamara, John
> -Original Message- > From: Pei, Yulong > Sent: Thursday, May 4, 2017 5:43 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; tho...@monjalon.net > Subject: [PATCH] doc: add tested Intel platforms with Intel NICs > > Add tested Intel platforms with Intel NICs to the release note. > > Signed-

Re: [dpdk-dev] [PATCH] doc: fix mlx PMD release notes

2017-05-09 Thread Mcnamara, John
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Tuesday, May 9, 2017 1:15 PM > To: Mcnamara, John ; tho...@monjalon.net > Cc: dev@dpdk.org; ol...@mellanox.com > Subject: [PATCH] doc: fix mlx PMD release notes > > Fixes: bae96f1c114e ("doc: update mlx releas

Re: [dpdk-dev] Fwd: Sharing tables among pipelines

2017-05-09 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Singh, Jasvinder > Sent: Monday, May 8, 2017 11:37 AM > To: Nidhia Varghese ; dev@dpdk.org; > us...@dpdk.org > Subject: Re: [dpdk-dev] Fwd: Sharing tables among pipelines > > Hi Nidhia, > > > For my pipeline ap

[dpdk-dev] [PATCH v1] doc: update release notes for 17.05

2017-05-09 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 17.05 release notes. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_17_05.rst | 192 +++-- 1 file changed, 88 insertions(+), 104 deletions(-) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides

[dpdk-dev] [PATCH] app/crypto-perf: add minimise-offload-cost flag

2017-05-09 Thread Fiona Trahe
The throughput test enqueues and dequeues bursts of operations to the device. For software devices the full burst size will usually be successfully en/dequeued, on hardware devices however the CPU can call the API more frequently than necessary, as it has nothing else to do. Minimum offload cost is

Re: [dpdk-dev] [PATCH] vfio: use right index when tracking devices in a vfio group

2017-05-09 Thread Burakov, Anatoly
Hi Alejandro, > From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] > Sent: Monday, May 8, 2017 6:44 PM > To: dev@dpdk.org > Cc: Burakov, Anatoly ; > jerin.ja...@caviumnetworks.com; tho...@monjalon.net > Subject: [PATCH] vfio: use right index when tracking devices in a vfio group > > P

[dpdk-dev] [RFC][PATCH 5/5] examples: updated IPSec sample app to support inline IPSec

2017-05-09 Thread Radu Nicolau
Added new SA types: ipv4-inline and ipv6-inline. Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/esp.c | 7 +- examples/ipsec-secgw/ipsec.h | 2 + examples/ipsec-secgw/sa.c| 165 --- 3 files changed, 117 insertions(+), 57 deletions(-) diff

[dpdk-dev] [RFC][PATCH 4/5] cryptodev: added new crypto PMD supporting inline IPSec for IXGBE

2017-05-09 Thread Radu Nicolau
Implemented new cryprodev PMD and updated the net/ixgbe driver. Signed-off-by: Radu Nicolau --- config/common_base | 7 + drivers/crypto/Makefile| 2 + drivers/crypto/ixgbe/Makefile | 63 +++ drivers/crypto/ixg

[dpdk-dev] [RFC][PATCH 3/5] mbuff: added inline IPSec flags and metadata

2017-05-09 Thread Radu Nicolau
Added inline IPSec status flags to ol_flags and added new member for IPSec metadata. Signed-off-by: Radu Nicolau --- lib/librte_mbuf/rte_mbuf.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 9097f18..e4eb

[dpdk-dev] [RFC][PATCH 2/5] pci: allow shared device instances.

2017-05-09 Thread Radu Nicolau
Updated PCI initialization code to allow devices to be shared across multiple PMDs. Signed-off-by: Radu Nicolau --- lib/librte_eal/common/eal_common_pci.c | 15 --- lib/librte_eal/common/include/rte_pci.h | 18 ++ 2 files changed, 26 insertions(+), 7 deletions(-) d

[dpdk-dev] [RFC][PATCH 0/5] cryptodev: Adding support for inline crypto processing of IPsec flows

2017-05-09 Thread Radu Nicolau
In this RFC we introduce a mechanism to support inline hardware acceleration of symmetric crypto processing of IPsec flows on Ethernet adapters within the cryptodev framework, specifically this RFC includes the initial enablement work for the Intel® 82599 10 GbE Controller (IXGBE). A number of

[dpdk-dev] [RFC][PATCH 1/5] cryptodev: Updated API to add suport for inline IPSec.

2017-05-09 Thread Radu Nicolau
Added new xform, rte_crypto_ipsec_xform Signed-off-by: Radu Nicolau --- lib/librte_cryptodev/rte_crypto_sym.h | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h inde

[dpdk-dev] [DPDK] net/i40e: add return value checks

2017-05-09 Thread Herakliusz Lipiec
Coverity issue: 1379362 Coverity issue: 1379365 Fixes: 71d35259ff67 ("i40e: tear down flow director") Signed-off-by: Herakliusz Lipiec --- drivers/net/i40e/i40e_fdir.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e

Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev

2017-05-09 Thread Ferruh Yigit
On 5/1/2017 7:58 AM, Shahaf Shuler wrote: > This is an ABI change notice for DPDK 17.08 in librte_ether > about changes in rte_eth_txmode structure. > > Currently Tx offloads are enabled by default, and can be disabled > using ETH_TXQ_FLAGS_NO* flags. This behaviour is not consistent with > the Rx

Re: [dpdk-dev] [PATCH] doc: notice for changes in kni structures

2017-05-09 Thread Ferruh Yigit
On 5/8/2017 10:46 AM, Hemant Agrawal wrote: > On 5/4/2017 10:20 PM, Ferruh Yigit wrote: >> On 5/3/2017 12:31 PM, Hemant Agrawal wrote: >>> Signed-off-by: Hemant Agrawal >>> --- >>> doc/guides/rel_notes/deprecation.rst | 7 +++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/doc/guide

Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev

2017-05-09 Thread Adrien Mazarguil
On Mon, May 01, 2017 at 09:58:12AM +0300, Shahaf Shuler wrote: > This is an ABI change notice for DPDK 17.08 in librte_ether > about changes in rte_eth_txmode structure. > > Currently Tx offloads are enabled by default, and can be disabled > using ETH_TXQ_FLAGS_NO* flags. This behaviour is not con

Re: [dpdk-dev] [PATCH v1 1/1] app/procinfo: resource leak fix.

2017-05-09 Thread Pattan, Reshma
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Roman Korynkevych > Sent: Friday, May 5, 2017 3:47 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Tahhan, Maryam > ; Korynkevych, RomanX > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/1] app/procinfo: r

Re: [dpdk-dev] [RFC 17.08] Flow classification library

2017-05-09 Thread Ferruh Yigit
On 5/6/2017 3:04 PM, Morten Brørup wrote: > Carthago delenda est: Again with the callbacks... why not just let the > application call the library's processing functions where appropriate. The > hook+callback design pattern tends to impose a specific framework (or order > of execution) on the DPD

Re: [dpdk-dev] [RFC 17.08] Flow classification library

2017-05-09 Thread Ferruh Yigit
On 4/21/2017 11:38 AM, Gaëtan Rivet wrote: > Hi Ferruh, > > On Thu, Apr 20, 2017 at 07:54:47PM +0100, Ferruh Yigit wrote: >> DPDK works with packets, but some network administration tools works based on >> flow information. >> >> This library is suggested to provide helper APIs to convert packet b

Re: [dpdk-dev] Fw: New Defects reported by Coverity Scan for DPDK Data Plane Development Kit

2017-05-09 Thread Adrien Mazarguil
Hi, On Mon, May 08, 2017 at 08:35:16AM -0700, Stephen Hemminger wrote: > Lots of new warnings. Most of them from the ARK driver. [...] > ** CID 144519: Parse warnings (PARSE_ERROR) > /tmp/auto-config-h.sh.10760.c: 3 in () > > > __

[dpdk-dev] [PATCH] doc: fix mlx PMD release notes

2017-05-09 Thread Shahaf Shuler
Fixes: bae96f1c114e ("doc: update mlx release notes") Acked-by: Olga Shern Signed-off-by: Shahaf Shuler --- doc/guides/rel_notes/release_17_05.rst | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_no

[dpdk-dev] [PATCH 1/2] eal: remove duplicated license

2017-05-09 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- lib/librte_eal/common/eal_common_pci.c | 31 +- .../common/include/arch/x86/rte_cycles.h | 31 +- lib/librte_eal/common/include/generic/rte_cycles.h | 31 +- lib/librte_eal/common/inc

[dpdk-dev] [PATCH 2/2] app/testpmd: remove duplicated license

2017-05-09 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- As a reference, get the list with following command: git grep "BSD LICENSE" | cut -d ":" -f1 | sort | uniq -c | grep -v 1 --- app/test-pmd/config.c | 31 +-- 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/app/test-pmd/conf

Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev

2017-05-09 Thread Shahaf Shuler
Monday, May 1, 2017 9:58 AM, Shahaf Shuler: > > This is an ABI change notice for DPDK 17.08 in librte_ether about changes in > rte_eth_txmode structure. > > Currently Tx offloads are enabled by default, and can be disabled using > ETH_TXQ_FLAGS_NO* flags. This behaviour is not consistent with the

Re: [dpdk-dev] [PATCH] doc: announce crypto structures rework

2017-05-09 Thread Jerin Jacob
-Original Message- > Date: Fri, 28 Apr 2017 19:06:44 +0100 > From: Pablo de Lara > To: dev@dpdk.org > CC: declan.dohe...@intel.com, akhil.go...@nxp.com, hemant.agra...@nxp.com, > zbigniew.bo...@caviumnetworks.com, jerin.ja...@caviumnetworks.com, Pablo > de Lara > Subject: [PATCH] doc: a

[dpdk-dev] [PATCH v4 4/4] test: add tests for arm64 CRC neon versions

2017-05-09 Thread Ashwin Sekhar T K
Verified the changes with crc_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- v2: * Fixed checkpatch errors/warnings test/test/test_crc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/test/test/test_crc.c b/test/test/test_crc.c index cd5af69..9f2a17d 100644 --- a/tes

[dpdk-dev] [PATCH v4 3/4] net: add arm64 neon version of CRC compute APIs

2017-05-09 Thread Ashwin Sekhar T K
Added CRC compute APIs for arm64 utilizing the pmull capability Added new file net_crc_neon.h to hold the arm64 pmull CRC implementation Verified the changes with crc_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- v2: * Fixed merge conflict in MAINTAINERS v3: * Moved feature dete

[dpdk-dev] [PATCH v4 2/4] eal: move gcc version definition to common header

2017-05-09 Thread Ashwin Sekhar T K
Moved the definition of GCC_VERSION from lib/librte_table/rte_lru.h to lib/librte_eal/common/include/rte_common.h. Tested compilation on: * arm64 with gcc * x86 with gcc and clang Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jan Viktorin --- v3: * Moved changes for GCC_VERSION into a separat

[dpdk-dev] [PATCH v4 1/4] mk: add crypto capability for generic armv8a and thunderx

2017-05-09 Thread Ashwin Sekhar T K
armv8-a has optional CRYPTO extension which adds the AES, PMULL, SHA1 and SHA2 capabilities. -march=armv8-a+crypto enables code generation for the ARMv8-A architecture together with the optional CRYPTO extensions. added the following flags to detect the corresponding capability at compile time *

[dpdk-dev] [PATCH] hash: add switch fall-through comments for arm64

2017-05-09 Thread Jerin Jacob
This fixes compiler warnings with GCC 7 for arm64 build. Fixes: da8dcc27f644 ("hash: use armv8-a CRC32 instructions") Signed-off-by: Jerin Jacob --- lib/librte_hash/rte_crc_arm64.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_hash/rte_crc_arm64.h b/lib/librte_hash/rte_crc_arm

Re: [dpdk-dev] [PATCH] doc: announce API changes in crypto library

2017-05-09 Thread Akhil Goyal
On 5/4/2017 9:07 PM, Tomasz Kulasek wrote: API changes are planned for 17.08 to made sessions agnostic to the underlaying devices, removing coupling with crypto PMDs, so a single session can be used on multiple devices. It requires to change "struct rte_cryptodev_sym_session" to store more than

Re: [dpdk-dev] [PATCH] doc: announce crypto device type enumeration removal

2017-05-09 Thread Akhil Goyal
On 5/5/2017 4:54 PM, Slawomir Mrozowicz wrote: Refer to RFC patch - cryptodev: remove crypto device type enumeration It is planned to remove device type enumeration rte_cryptodev_type from library to remove the coupling between crypto PMD and the librte_cryptodev. In this case following stuctur

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix mempool creation by socket id

2017-05-09 Thread Wu, Jingjing
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Tuesday, May 9, 2017 3:29 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; tho...@monjalon.net; sta...@dpdk.org > Subject: [PATCH v4] app/testpmd: fix mempool creation by socket id > > The test assumes the socket

[dpdk-dev] [PATCH 2/2] contigmem: don't zero the pages during each mmap

2017-05-09 Thread Tiwei Bie
Don't zero the pages during each mmap. Instead, only zero the pages when they are not already mmapped. Otherwise, the multi-process support will be broken, as the pages will be zeroed when secondary processes map the memory. Besides, track the open and mmap operations on the cdev, and prevent the m

[dpdk-dev] [PATCH 0/2] Various fixes for contigmem

2017-05-09 Thread Tiwei Bie
Tiwei Bie (2): contigmem: free the allocated memory when error occurs contigmem: don't zero the pages during each mmap lib/librte_eal/bsdapp/contigmem/contigmem.c | 186 1 file changed, 161 insertions(+), 25 deletions(-) -- 2.12.1

[dpdk-dev] [PATCH 1/2] contigmem: free the allocated memory when error occurs

2017-05-09 Thread Tiwei Bie
Fixes: 764bf26873b9 ("add FreeBSD support") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_eal/bsdapp/contigmem/contigmem.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/bsdapp/contigmem/contigmem.c b/lib/librte_eal/bsdapp/c

Re: [dpdk-dev] [PATCH] ethdev: fix wrong sizeof argument in malloc function

2017-05-09 Thread Van Haaren, Harry
> From: Kozak, KubaX > Sent: Tuesday, May 9, 2017 6:22 AM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K > ; > Jastrzebski, MichalX K ; Kozak, KubaX > > Subject: [PATCH] ethdev: fix wrong sizeof argument in malloc function > > From: Michal Jastrzebski > > Coverity reported that a

Re: [dpdk-dev] [PATCH] proc-info: wrong sizeof argument in malloc function

2017-05-09 Thread Van Haaren, Harry
> From: Kozak, KubaX > Sent: Tuesday, May 9, 2017 6:23 AM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K > ; > Jastrzebski, MichalX K ; Kozak, KubaX > > Subject: [PATCH] proc-info: wrong sizeof argument in malloc function > > From: Michal Jastrzebski > > Coverity reported that an

Re: [dpdk-dev] [PATCH 5/5] examples/l3fwd: add neon support for l3fwd

2017-05-09 Thread Sekhar, Ashwin
On Fri, 2017-05-05 at 13:43 +0800, Jianbo Liu wrote: > On 5 May 2017 at 12:24, Sekhar, Ashwin > wrote: > > > > On Thu, 2017-05-04 at 16:42 +0800, Jianbo Liu wrote: > > > > > > Hi Ashwin, > > > > > > On 3 May 2017 at 13:24, Jianbo Liu wrote: > > > > > > > > > > > > Hi Ashwin, > > > > > > > >

[dpdk-dev] [PATCH v3] eal: Set numa node value for system which not support it.

2017-05-09 Thread Tonghao Zhang
The NUMA node information for PCI devices provided through sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx on Red Hat Enterprise Linux 6, and VMs on some hypervisors. It is good to see more checking for valid values. Signed-off-by: Tonghao Zhang --- lib/librte_eal/linuxapp/eal/eal_p

[dpdk-dev] [PATCH v4] app/testpmd: fix mempool creation by socket id

2017-05-09 Thread Shahaf Shuler
The test assumes the socket ids are contiguous. This is not necessarily the case on all servers and may cause mempool creation to fail. Fixing it by detecting the list of valid socket ids and use it for the mempool creation. Fixes: 7acf894d07d1 ("app/testpmd: detect numa socket count") CC: sta..

Re: [dpdk-dev] [PATCH] net/null: do not touch mbuf next or nb segs on Rx

2017-05-09 Thread Olivier Matz
On Thu, 4 May 2017 16:43:58 +0100, Ferruh Yigit wrote: > mbuf next and nb_segs fields already have the default values when get > from mempool, no need to update them in PMD. > > See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") > > Signed-off-by: Ferruh Yigit > --- > Cc: Olivier Matz