Re: [dpdk-dev] [PATCH v7 0/3] net/i40e: configurable PTYPE mapping

2017-04-04 Thread Zhang, Qi Z
> -Original Message- > From: Jianbo Liu [mailto:jianbo@linaro.org] > Sent: Wednesday, April 5, 2017 1:46 PM > To: Thomas Monjalon > Cc: Zhang, Qi Z ; dev@dpdk.org; Yigit, Ferruh > ; Wu, Jingjing ; Zhang, > Helin ; Jerin Jacob > ; Chao Zhu > > Subject: Re: [dpdk-dev] [PATCH v7 0/3] n

Re: [dpdk-dev] [PATCH v7 0/3] net/i40e: configurable PTYPE mapping

2017-04-04 Thread Jianbo Liu
On 5 April 2017 at 04:22, Thomas Monjalon wrote: > 2017-04-04 10:30, Ferruh Yigit: >> On 4/4/2017 2:55 AM, Qi Zhang wrote: >> > The patch set create new APIs that help to change the mapping from hardware >> > defined packet type to software defined packet type for i40e NICs. >> > Keep these APIs p

Re: [dpdk-dev] [PATCH v4 0/3] net/i40e: vf port reset

2017-04-04 Thread Zhao1, Wei
Hi, jingjing > -Original Message- > From: Wu, Jingjing > Sent: Thursday, March 30, 2017 8:33 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 0/3] net/i40e: vf port reset > > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix overflow

2017-04-04 Thread Yuanhan Liu
On Wed, Apr 05, 2017 at 02:22:27AM +0200, Thomas Monjalon wrote: > 2017-03-15 16:08, Yuanhan Liu: > > On Tue, Mar 14, 2017 at 10:09:56AM +, Wenfeng Liu wrote: > > > virtio-user limits the qeueue number to 8 but provides no limit > > > check against the queue number input from user. If a bigger

Re: [dpdk-dev] [PATCH v4 19/22] vhost: rename header file

2017-04-04 Thread Yuanhan Liu
On Wed, Apr 05, 2017 at 02:26:20AM +0200, Thomas Monjalon wrote: > 2017-04-01 15:22, Yuanhan Liu: > > Rename "rte_virtio_net.h" to "rte_vhost.h", to not let it be virtio > > net specific. > > > > Signed-off-by: Yuanhan Liu > > Reviewed-by: Maxime Coquelin > > --- > > doc/guides/rel_notes/deprec

Re: [dpdk-dev] Query on VM_BUS and HyperV PMD

2017-04-04 Thread Dey, Souvik
Ok thanks. -Original Message- From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] Sent: Wednesday, April 5, 2017 12:10 AM To: Dey, Souvik Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Query on VM_BUS and HyperV PMD On Wed, Apr 05, 2017 at 03:23:36AM +, Dey, Souvik wrote: > Hi All, >

Re: [dpdk-dev] [PATCH v3 7/9] net/virtio: Add MTU feature support

2017-04-04 Thread Tan, Jianfeng
Hi Maxime, Have some confusion about this feature. Please help confirm. (1) With this feature, we only support to advertise MTU value which is defined by QEMU to frontend and backend driver separately. (2) But it does not allow frontend driver to set a different MTU to QEMU and then to vhost

[dpdk-dev] [dpdk-dev 2/2] app/testpmd: fix ipv6 tunnel csum issue

2017-04-04 Thread Jeff Guo
When ipv6 packet is tunnel packet, "PKT_TX_OUTER_IPV6" flag must be set, to let prepare the correct mbuf meta data for tx forward. Fixes: 2b76648872c9 ("net/e1000: add Tx preparation") Signed-off-by: Jeff Guo --- app/test-pmd/csumonly.c | 11 +++ 1 file changed, 7 insertions(+), 4 deleti

[dpdk-dev] [dpdk-dev 1/2] lib: fix ipv6 tunnel csum issue

2017-04-04 Thread Jeff Guo
When packet is flag of "PKT_TX_OUTER_IPV6", it also need to be considered to be tunnel case, in order to calculate the correct csum value. Fixes: 2b76648872c9 ("net/e1000: add Tx preparation") Signed-off-by: Jeff Guo --- lib/librte_net/rte_net.h | 3 ++- 1 file changed, 2 insertions(+), 1 delet

Re: [dpdk-dev] Query on VM_BUS and HyperV PMD

2017-04-04 Thread Yuanhan Liu
On Wed, Apr 05, 2017 at 03:23:36AM +, Dey, Souvik wrote: > Hi All, > As DPDK 16.11 is an LTS release is there any plans to backport > the VM-BUS and HyperV PMD from 17.05 to 16.11. The generic rule is we don't backport features to a LTS release. Thus, the answer is no.

[dpdk-dev] Query on VM_BUS and HyperV PMD

2017-04-04 Thread Dey, Souvik
Hi All, As DPDK 16.11 is an LTS release is there any plans to backport the VM-BUS and HyperV PMD from 17.05 to 16.11. -- Regards, Souvik

Re: [dpdk-dev] [PATCH] net/i40e: fix eth pattern parsing

2017-04-04 Thread Xing, Beilei
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, April 4, 2017 8:52 PM > To: Yigit, Ferruh ; dev@dpdk.org; Xing, Beilei > > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix eth pattern parsing > > Hi Ferruh, > > > -Original Message- > > From: Yigi

Re: [dpdk-dev] [pull-request] next-net 17.05 RC1

2017-04-04 Thread Thomas Monjalon
2017-04-04 15:22, Ferruh Yigit: > http://dpdk.org/git/next/dpdk-next-net Pulled, except the series "net/i40e: configurable PTYPE mapping" (mail sent). Thanks for the huge work!

Re: [dpdk-dev] [PATCH v4 19/22] vhost: rename header file

2017-04-04 Thread Thomas Monjalon
2017-04-01 15:22, Yuanhan Liu: > Rename "rte_virtio_net.h" to "rte_vhost.h", to not let it be virtio > net specific. > > Signed-off-by: Yuanhan Liu > Reviewed-by: Maxime Coquelin > --- > doc/guides/rel_notes/deprecation.rst | 9 - > doc/guides/rel_notes/release_17_05.rst | 3 + > drivers/

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix overflow

2017-04-04 Thread Thomas Monjalon
2017-03-15 16:08, Yuanhan Liu: > On Tue, Mar 14, 2017 at 10:09:56AM +, Wenfeng Liu wrote: > > virtio-user limits the qeueue number to 8 but provides no limit > > check against the queue number input from user. If a bigger queue > > number (> 8) is given, there is an overflow issue. Doing a sani

Re: [dpdk-dev] [PATCH v4 12/22] vhost: drop the Rx and Tx queue macro

2017-04-04 Thread Thomas Monjalon
2017-04-01 15:22, Yuanhan Liu: > They are virtio-net specific and should be defined inside the virtio-net > driver. > > Signed-off-by: Yuanhan Liu > Reviewed-by: Maxime Coquelin > --- > > v2: - update release note > --- > doc/guides/rel_notes/release_17_05.rst | 6 ++ > drivers/net/vhost/r

Re: [dpdk-dev] [PATCH v4 01/22] vhost: introduce driver features related APIs

2017-04-04 Thread Thomas Monjalon
2017-04-01 15:22, Yuanhan Liu: > +/** > + * Set the feature bits the vhost-user driver supports. > + * > + * @param path > + * The vhost-user socket file path > + * @return > + * 0 on success, -1 on failure > + */ > +int rte_vhost_driver_set_features(const char *path, uint64_t features); The par

Re: [dpdk-dev] [PATCH v7 1/7] net/ark: stub PMD for Atomic Rules Arkville

2017-04-04 Thread Ed Czeck
Hi Ferruh, The patch series was updated to apply on the latest dpdk-next-net (d7f06ea2) On Fri, Mar 31, 2017 at 10:51 AM, Ferruh Yigit wrote: > > On 3/29/2017 10:32 PM, Ed Czeck wrote: > > Enable Arkville on supported configurations > > > Can you please update release notes [1] to announce the A

Re: [dpdk-dev] [PATCH v7 0/3] net/i40e: configurable PTYPE mapping

2017-04-04 Thread Thomas Monjalon
2017-04-04 10:30, Ferruh Yigit: > On 4/4/2017 2:55 AM, Qi Zhang wrote: > > The patch set create new APIs that help to change the mapping from hardware > > defined packet type to software defined packet type for i40e NICs. > > Keep these APIs private is because currently they are only meaningful for

Re: [dpdk-dev] [PATCH v9 0/3] librte_net: add crc computation support

2017-04-04 Thread Thomas Monjalon
2017-03-30 17:15, Jasvinder Singh: > In some applications, CRC (Cyclic Redundancy Check) needs to be computed > or updated during packet processing operations. This patchset adds > software implementation of some common standard CRCs (32-bit Ethernet > CRC as per Ethernet/[ISO/IEC 8802-3] and 16-bi

Re: [dpdk-dev] [PATCH v9 1/3] librte_net: add crc compute APIs

2017-04-04 Thread Thomas Monjalon
2017-03-30 17:15, Jasvinder Singh: > +/** > + * CRC compute API > + * > + * @param data > + * Pointer to the packet data for CRC computation > + * @param data_len > + * Data length for CRC computation > + * @param type > + * CRC type (enum rte_net_crc_type) > + * > + * @return > + * CRC val

Re: [dpdk-dev] [PATCH v9 3/3] maintainers: add packet crc section and claim maintainership

2017-04-04 Thread Thomas Monjalon
2017-03-30 17:15, Jasvinder Singh: > +Packet CRC > +M: Jasvinder Singh > +F: lib/librte_net/rte_net_crc* > +F: lib/librte_net/rte_net_crc_sse.h The above lines should be in the first patch. > +F: test/test/test_crc.c This line should be in the second patch.

[dpdk-dev] [PATCH v8 5/7] net/ark: packet Tx support initial version

2017-04-04 Thread Ed Czeck
* Core TX packet moving functions * Flesh out ark_adapter struct to support TX code (not all fields used at this patch v6: * Unify messages and logging * improve comments * Use of PRIu32 format where needed Signed-off-by: Ed Czeck Conflicts: drivers/net/ark/ark_global.h --- drivers/net

[dpdk-dev] [PATCH v8 6/7] net/ark: packet Rx support initial version

2017-04-04 Thread Ed Czeck
* Core RX packet moving functions v6: * Unify messaging and logging * Use PRIu32 format where needed * Address review comments Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile| 1 + drivers/net/ark/ark_ethdev_rx.c | 672 drivers/net/ark/ark

[dpdk-dev] [PATCH v8 7/7] net/ark: arkville PMD component integration

2017-04-04 Thread Ed Czeck
* Flesh out device configuration * Add links dev_ops * allow dynamic extension loading * update release notes and feature listing v8: * update release notes v7: * Address clang compile issue v6: * Address review issues * Unify messages and logging * Improved error capturing Signed-off-by: Shepa

[dpdk-dev] [PATCH v8 2/7] net/ark: provide API for hardware modules mpu rqp and pktdir

2017-04-04 Thread Ed Czeck
Provide C-level interface for Arkville's internal HW resources mpu, (Memory Prefetch Unit) pktdir (Packet director), and rqp (Request Pacer) modules v6: * Unify messaging and logging * Expand comments Signed-off-by: Ed Czeck Conflicts: drivers/net/ark/Makefile --- drivers/net/ark/Makef

[dpdk-dev] [PATCH v8 3/7] net/ark: provide API for hardware modules udm and ddm

2017-04-04 Thread Ed Czeck
Provide C-level interface for Arkville's internal HW resources ddm (Downstream Data Mover) and udm (Upstream Data Mover) modules v6: * Unify messaging and logging Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile | 2 + drivers/net/ark/ark_ddm.c | 151 +++ driv

[dpdk-dev] [PATCH v8 4/7] net/ark: provide API for hardware modules pktchkr and pktgen

2017-04-04 Thread Ed Czeck
Provide C-level interface for Arkville's internal HW resources pktchkr and pktgen v6: * bug fix handing empty dev arguments. * Unify messaging and logging * Improve comments Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile | 2 + drivers/net/ark/ark_pktchkr.c | 474 ++

[dpdk-dev] [PATCH v8 1/7] net/ark: stub PMD for Atomic Rules Arkville

2017-04-04 Thread Ed Czeck
Enable Arkville on supported configurations Add overview documentation Minimum driver support for valid compile Arkville PMD is not supported on ARM or PowerPC at this time v8: * Update to allow patch application from dpdk-next-net v6: * Address review comments * Unify messaging, logging and debu

[dpdk-dev] [PATCH v2] config: compile avp driver only on intel 64 bit

2017-04-04 Thread Allain Legacy
The AVP devices are only supported on Intel 64-bit architectures so adjusting the defconfig attributes accordingly. Fixes: 0485859868a9 ("net/avp: support driver registration") Signed-off-by: Allain Legacy --- config/defconfig_arm-armv7a-linuxapp-gcc| 1 + config/defconfig_arm64-armv8a-linu

Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

2017-04-04 Thread Ferruh Yigit
On 4/4/2017 6:17 PM, Legacy, Allain wrote: >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Tuesday, April 04, 2017 1:12 PM > <...> >> >> Right now compiler config files only have compiler and architecture configs, >> although it is OK to update them, to

Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

2017-04-04 Thread Legacy, Allain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, April 04, 2017 1:12 PM <...> > > Right now compiler config files only have compiler and architecture configs, > although it is OK to update them, to be consistent with what other PMDs did, > what do

Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

2017-04-04 Thread Ferruh Yigit
On 4/4/2017 5:36 PM, Allain Legacy wrote: > The AVP devices are only supported on Intel 64-bit architectures so > adjusting the defconfig attributes accordingly. > > Fixes: c5ab4707ba97 ("net/avp: support driver registration") > > Signed-off-by: Allain Legacy > --- > config/common_linuxapp

[dpdk-dev] [PATCH v3 7/8] app/testpmd: new command to dump log types

2017-04-04 Thread Olivier Matz
Signed-off-by: Olivier Matz --- app/test-pmd/cmdline.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 47f935d20..697228fa6 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -7679,6 +7679,8 @@ static v

[dpdk-dev] [PATCH v3 8/8] net/i40e: use dynamic log type for control logs

2017-04-04 Thread Olivier Matz
This is an example of how a dynamic log type can be used in a PMD. Signed-off-by: Olivier Matz --- config/common_base | 2 -- drivers/net/i40e/i40e_ethdev.c | 18 -- drivers/net/i40e/i40e_fdir.c | 4 drivers/net/i40e/i40e_logs.h | 17 ++--- 4 fi

[dpdk-dev] [PATCH v3 6/8] app/test: new command to dump log types

2017-04-04 Thread Olivier Matz
Signed-off-by: Olivier Matz --- test/test/commands.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/test/commands.c b/test/test/commands.c index 551c81dcf..4097a3310 100644 --- a/test/test/commands.c +++ b/test/test/commands.c @@ -158,13 +158,15 @@ static void cmd_dum

[dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-04 Thread Olivier Matz
Example of use: ./app/test-pmd --log-level='pmd\.i40e.*,8' This enables debug logs for all dynamic logs whose type starts with 'pmd.i40e'. Signed-off-by: Olivier Matz --- lib/librte_eal/bsdapp/eal/eal.c| 4 +-- lib/librte_eal/common/eal_common_options.c | 49 +

[dpdk-dev] [PATCH v3 5/8] eal: deprecate log functions

2017-04-04 Thread Olivier Matz
Deprecate the following functions: - rte_set_log_level(), replaced by rte_log_set_global_level() - rte_get_log_level(), replaced by rte_log_get_global_level() - rte_set_log_type(), replaced by rte_log_set_level() - rte_get_log_type(), replaced by rte_log_get_level() The new functions provide a bet

[dpdk-dev] [PATCH v3 3/8] eal: change several log levels matching a regexp

2017-04-04 Thread Olivier Matz
Introduce a function to set the log level of several log types that match a regular expression. Signed-off-by: Olivier Matz --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_log.c | 21 + lib/librte_eal/common/include/rte_lo

[dpdk-dev] [PATCH v3 2/8] eal: dump registered log types

2017-04-04 Thread Olivier Matz
Introduce a function to dump the global level and the registered log types. Signed-off-by: Olivier Matz --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_log.c | 34 + lib/librte_eal/common/include/rte_log.h | 10

[dpdk-dev] [PATCH v3 1/8] eal: support dynamic log types

2017-04-04 Thread Olivier Matz
Introduce 2 new functions to support dynamic log types: - rte_log_register(): register a log name, and return a log type id - rte_log_set_level(): set the log level of a given log type Signed-off-by: Olivier Matz --- doc/guides/contributing/coding_style.rst| 30 -- doc/guides/rel_n

[dpdk-dev] [PATCH v3 0/8] eal: dynamic logs

2017-04-04 Thread Olivier Matz
The objective of this patchset is to introduce a framework to support dynamic log types in EAL. It also provides one example of use (in i40e). Features: - log types are identified by a string - at registration, a uniq identifier is associated to a log type - each log type can have its level change

[dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

2017-04-04 Thread Allain Legacy
The AVP devices are only supported on Intel 64-bit architectures so adjusting the defconfig attributes accordingly. Fixes: c5ab4707ba97 ("net/avp: support driver registration") Signed-off-by: Allain Legacy --- config/common_linuxapp| 1 - config/defconfig_i686-native-lin

[dpdk-dev] [PATCH v2 7/8] mbuf: move sequence number in second cache line

2017-04-04 Thread Olivier Matz
Move this field in the second cache line, since no driver use it in Rx path. The freed space will be used by a timestamp in next commit. Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h

[dpdk-dev] [PATCH v2 8/8] mbuf: add a timestamp field

2017-04-04 Thread Olivier Matz
The field itself is not fully described yet, but this commit reserves the room in the mbuf. Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.c | 2 ++ lib/librte_mbuf/rte_mbuf.h | 12 2 files changed, 14 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mb

[dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nb segments

2017-04-04 Thread Olivier Matz
Change the size of m->port and m->nb_segs to 16 bits. It is now possible to reference a port identifier larger than 256 and have a mbuf chain larger than 256 segments. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 4 ++-- .../linuxapp/eal/include

[dpdk-dev] [PATCH v2 3/8] mbuf: set mbuf fields while in pool

2017-04-04 Thread Olivier Matz
Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next to NULL when the mbuf is stored inside the mempool (unused). This is done in rte_pktmbuf_prefree_seg(), before freeing or recycling a mbuf. Before this patch, the value of m->refcnt was expected to be 0 while in pool. The objectives are

[dpdk-dev] [PATCH v2 5/8] mbuf: make rearm data address naturally aligned

2017-04-04 Thread Olivier Matz
From: Jerin Jacob To avoid multiple stores on fast path, Ethernet drivers aggregate the writes to data_off, refcnt, nb_segs and port to an uint64_t data and write the data in one shot with uint64_t* at &mbuf->rearm_data address. Some of the non-IA platforms have store operation overhead if the s

[dpdk-dev] [PATCH v2 4/8] drivers/net: don't touch mbuf next or nb segs on Rx

2017-04-04 Thread Olivier Matz
Now that the m->next pointer and m->nb_segs is expected to be set (to NULL and 1 respectively) after a mempool_get(), we can avoid to write them in the Rx functions of drivers. Only some drivers are patched, it's not an exhaustive patch. It gives the idea to do the same in other drivers. Signed-o

[dpdk-dev] [PATCH v2 1/8] mbuf: make segment prefree function public

2017-04-04 Thread Olivier Matz
Document the function and make it public, since it is used at several places in the drivers. The old one is marked as deprecated. Signed-off-by: Olivier Matz --- drivers/net/enic/enic_rxtx.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c| 6 +++--- drivers/net/fm10k/fm10k_rxtx

[dpdk-dev] [PATCH v2 2/8] mbuf: make raw free function public

2017-04-04 Thread Olivier Matz
Rename __rte_mbuf_raw_free() as rte_mbuf_raw_free() and make it public. The old function is kept for compat but is marked as deprecated. The next commit changes the behavior of rte_mbuf_raw_free() to make it more consistent with rte_mbuf_raw_alloc(). Signed-off-by: Olivier Matz --- drivers/net/

[dpdk-dev] [PATCH v2 0/8] mbuf: structure reorganization

2017-04-04 Thread Olivier Matz
Based on discussions done in [1] and in this thread, this patchset reorganizes the mbuf. The main changes are: - reorder structure to increase vector performance on some non-ia platforms. - add a 64bits timestamp field in the 1st cache line. This timestamp is not normalized, i.e. no unit or ti

Re: [dpdk-dev] vfio: failed to select IOMMU type

2017-04-04 Thread Burakov, Anatoly
Hi Andrew, > Please, take a look at http://dpdk.org/dev/patchwork/patch/23202/ I took a quick look. It should fix the problem (closing the group will cause container detachment, so we can always assume that if there's no container associated with the group, there are no devices within that grou

Re: [dpdk-dev] [PATCH v3 1/3] add new xstats API retrieving by id

2017-04-04 Thread Thomas Monjalon
2017-04-04 15:45, Van Haaren, Harry: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2017-04-03 14:09, Jacek Piasecki: > > > From: Michal Jastrzebski > > > > > > Extended xstats API in ethdev library to allow grouping of stats > > > logically so they can be retrieved per logical gro

Re: [dpdk-dev] vfio: failed to select IOMMU type

2017-04-04 Thread Andrew Rybchenko
On 04/04/2017 06:52 PM, Burakov, Anatoly wrote: Hi Andrew, I think a key to the main problem is the same IOMMU group used for both PCI functions. It tries to set IOMMU type using the same file descriptor twice. The second set is dummy, since the same value is set, but still fails, I guess, be

[dpdk-dev] [PATCH] vfio: set IOMMU type for the container once

2017-04-04 Thread Andrew Rybchenko
If more than one used PCI device belongs to one IOMMU group, it is still one IOMMU group and the container IOMMU type should be set only once. Fixes: 94c0776b1bad ("vfio: support hotplug") Signed-off-by: Andrew Rybchenko --- My testing of the patch is limitted to my configuration with 2 PCI func

Re: [dpdk-dev] vfio: failed to select IOMMU type

2017-04-04 Thread Burakov, Anatoly
Hi Andrew, > I think a key to the main problem is the same IOMMU group used for both PCI > functions. > It tries to set IOMMU type using the same file descriptor twice. The second > set is dummy, since the same value is set, but still fails, I guess, because > it is already in use. > See logs w

Re: [dpdk-dev] [pull-request] next-net 17.05 RC1

2017-04-04 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, April 4, 2017 3:22 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [dpdk-dev] [pull-request] next-net 17.05 RC1 > > The following changes since commit > a29491c

Re: [dpdk-dev] [PATCH v3 1/3] add new xstats API retrieving by id

2017-04-04 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Tuesday, April 4, 2017 4:04 PM > To: Piasecki, JacekX ; Jastrzebski, MichalX K > > Cc: dev@dpdk.org; Van Haaren, Harry ; Kozak, KubaX > ; Kulasek, TomaszX > Subject: Re: [dpdk-dev] [PATCH v3 1/3] add new xstats API retrieving by i

[dpdk-dev] [PATCH 2/2] eal: deprecate rte_cpu_check_supported

2017-04-04 Thread Aaron Conole
It's likely that this function isn't used anywhere, but since it was part of the public API, mark the function for deprecation for at least one release. Signed-off-by: Aaron Conole --- lib/librte_eal/common/include/generic/rte_cpuflags.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/

[dpdk-dev] [PATCH] crypto/scheduler: fix typo

2017-04-04 Thread Fan Zhang
This patch fixes a naming typo in set and get mode APIs. Fixes: 097ab0bac017 ("crypto/scheduler: add API") Signed-off-by: Fan Zhang --- drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 4 ++-- drivers/crypto/scheduler/rte_cryptodev_scheduler.h | 4 ++-- test/test/test_cryptodev.c

[dpdk-dev] [PATCH 1/2] eal: add rte_cpu_is_supported to map

2017-04-04 Thread Aaron Conole
This function is now part of the public ABI, so should be advertised as such. Signed-off-by: Aaron Conole --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++ lib/librte_eal/linuxapp/eal/rte_eal_version.map | 7 +++ 2 files changed, 14 insertions(+) diff --git a/lib/librte_eal/b

Re: [dpdk-dev] vfio: failed to select IOMMU type

2017-04-04 Thread Andrew Rybchenko
On 04/03/2017 07:11 PM, Burakov, Anatoly wrote: From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Saturday, April 1, 2017 11:47 AM To: dev@dpdk.org; Alejandro Lucero Cc: Burakov, Anatoly Subject: vfio: failed to select IOMMU type Hi, after the following commit (it was picked up

Re: [dpdk-dev] [PATCH v3 1/2] test/test: free mempool on exit

2017-04-04 Thread santosh
Hi Hemant, [Noticed that my first reply couldn't reach out to ML so re-sending] On Tuesday 04 April 2017 11:27 AM, Hemant Agrawal wrote: > From: Shreyansh Jain > > mempool autotest was not freeing the mempools. > > Fixes: 8ef772ae ("app/test: rework mempool tes") > Cc: sta...@dpdk.org > > Signe

Re: [dpdk-dev] [PATCH v4] crypto/scheduler: add more EAL options

2017-04-04 Thread De Lara Guarch, Pablo
> -Original Message- > From: Doherty, Declan > Sent: Tuesday, April 04, 2017 2:38 PM > To: Zhang, Roy Fan; dev@dpdk.org > Cc: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio > Subject: Re: [PATCH v4] crypto/scheduler: add more EAL options > > On 03/04/17 16:33, Fan Zhang wrote: > > This p

Re: [dpdk-dev] [PATCH v3] crypto/scheduler: fix session free

2017-04-04 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, April 04, 2017 10:31 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; sta...@dpdk.org > Subject: [PATCH v3] crypto/scheduler: fix session free > > This patch fixes the incorrection slave session free operation. > > Fixes: 57

[dpdk-dev] [PATCH v6 2/2] eal: clean up interrupt handle

2017-04-04 Thread Qi Zhang
The patch change the prototype of callback function (rte_intr_callback_fn) by removing the unnecessary parameter. Signed-off-by: Qi Zhang --- v5: - Update mlx4 driver which is missed in previous version. v4: - Update mlx5 driver which is missed in v1, v2, v3. v3: - Update bnx2x driver which

[dpdk-dev] [PATCH v6 3/3] test/test: update test code

2017-04-04 Thread Qi Zhang
Update the test code to algin with interrupt callback prototype change Signed-off-by: Qi Zhang --- v6: - sync with latest test code. test/test/test_interrupts.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/test/test/test_interrupts.c b/test/tes

[dpdk-dev] [PATCH v6 1/2] vfio: keep interrupt source read only

2017-04-04 Thread Qi Zhang
Remove the inappropriate modification on get_max_intr field that keep the intr_source read only. Signed-off-by: Qi Zhang --- v4: - Add back this patch to make patch set complete though it already be applied. v2: - Seperate patch 1 of v1 into 2 patches.(part 1) lib/librte_eal/linuxapp/eal/ea

[dpdk-dev] [PATCH v6 0/3] clean up interrupt handle

2017-04-04 Thread Qi Zhang
It seems its not necessary to register an intr_handle for interrupt callback function. "void* cb_arg" shows enough when be used to pass the object that contain the information be required to handle the interrupt event( A typical way which is implemented by almost all driver is by passing a rte_ethd

Re: [dpdk-dev] [PATCH v3] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3

2017-04-04 Thread Thomas Monjalon
2017-04-04 15:46, Ferruh Yigit: > On 4/4/2017 3:16 PM, Nirmoy Das wrote: > > Add support for SLES12SP3, which uses kernel 4.4, > > but backported features from newer kernels. > > > > Signed-off-by: Nirmoy Das > > Acked-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] test/test: improve dequeue logic for crypto operation

2017-04-04 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > Sent: Monday, April 03, 2017 11:53 AM > To: dev@dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo; Akhil Goyal > Subject: [PATCH] test/test: improve dequeue logic for crypto operation > > From: A

Re: [dpdk-dev] [PATCH v3 1/3] add new xstats API retrieving by id

2017-04-04 Thread Thomas Monjalon
2017-04-03 14:09, Jacek Piasecki: > From: Michal Jastrzebski > > Extended xstats API in ethdev library to allow grouping of stats > logically so they can be retrieved per logical grouping – managed > by the application. > Changed existing functions rte_eth_xstats_get_names and > rte_eth_xstats_ge

[dpdk-dev] [PATCH] pci: do not log false failures for non-whitelisted devices

2017-04-04 Thread Andrew Rybchenko
If probe of the whitelisted PCI device fails, reset ret to zero to silently skip non-whitelisted PCI devices. Fixes: 10f6c93cea38 ("eal: do not panic on PCI failures") Signed-off-by: Andrew Rybchenko --- lib/librte_eal/common/eal_common_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [dpdk-dev] [PATCH v5 0/2] clean up interrupt handle

2017-04-04 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Tuesday, April 4, 2017 10:50 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [PATCH v5 0/2] clean up interrupt handle > > 2017-04-05 06:27, Qi Zhang: > > It seems its not necessary to register

Re: [dpdk-dev] [PATCH v5 0/2] clean up interrupt handle

2017-04-04 Thread Thomas Monjalon
2017-04-05 06:27, Qi Zhang: > It seems its not necessary to register an intr_handle for interrupt callback > function. "void* cb_arg" shows enough when be used to pass the object that > contain the information be required to handle the interrupt event( A typical > way which is implemented by almost

Re: [dpdk-dev] [PATCH v3] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3

2017-04-04 Thread Ferruh Yigit
On 4/4/2017 3:16 PM, Nirmoy Das wrote: > Add support for SLES12SP3, which uses kernel 4.4, > but backported features from newer kernels. > > Signed-off-by: Nirmoy Das Acked-by: Ferruh Yigit

Re: [dpdk-dev] next technical board meeting, 2017-04-06

2017-04-04 Thread Wiles, Keith
> On Apr 4, 2017, at 12:01 AM, Vincent Jardin wrote: > > > > Le 4 avril 2017 4:28:47 AM Stephen Hemminger a > écrit : > >> On Mon, 3 Apr 2017 22:53:06 + >> "Wiles, Keith" wrote: >> >>> > On Apr 3, 2017, at 2:51 PM, Stephen Hemminger >>> > wrote: >>> > >>> > On Thu, 30 Mar 2017 18:09

[dpdk-dev] [PATCH v5 2/2] eal: clean up interrupt handle

2017-04-04 Thread Qi Zhang
The patch change the prototype of callback function (rte_intr_callback_fn) by removing the unnecessary parameter. Signed-off-by: Qi Zhang --- v5: - Update mlx4 driver which is missed in previous version. v4: - Update mlx5 driver which is missed in v1, v2, v3. v3: - Update bnx2x driver which

[dpdk-dev] [PATCH v5 1/2] vfio: keep interrupt source read only

2017-04-04 Thread Qi Zhang
Remove the inappropriate modification on get_max_intr field that keep the intr_source read only. Signed-off-by: Qi Zhang --- v4: - Add back this patch to make patch set complete though it already be applied. v2: - Seperate patch 1 of v1 into 2 patches.(part 1) lib/librte_eal/linuxapp/eal/ea

[dpdk-dev] [PATCH v5 0/2] clean up interrupt handle

2017-04-04 Thread Qi Zhang
It seems its not necessary to register an intr_handle for interrupt callback function. "void* cb_arg" shows enough when be used to pass the object that contain the information be required to handle the interrupt event( A typical way which is implemented by almost all driver is by passing a rte_ethd

Re: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle

2017-04-04 Thread Zhang, Qi Z
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Tuesday, April 4, 2017 9:54 PM > To: Zhang, Qi Z ; thomas.monja...@6wind.com > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle > > Wednesday, April 5, 2017 12:21 AM,

Re: [dpdk-dev] [PATCH v5 0/6] librte_cfgfile enhancements

2017-04-04 Thread Thomas Monjalon
2017-03-31 09:51, Allain Legacy: > This patchset includes some minor enhancements that we have developped for > our DPDK application. We would like to contribute them upstream to help > ease adoption of the DPDK by anyone looking for this type of > functionality. The commit logs on each patch sho

[dpdk-dev] [pull-request] next-net 17.05 RC1

2017-04-04 Thread Ferruh Yigit
The following changes since commit a29491c2f417c58cf02ace231d7a0215315e1346: doc: fix a typo in howto guide (2017-04-04 15:07:25 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to 33383c6ffcd4bdf3ba2fb4fb82f163e7771a4cad:

[dpdk-dev] [PATCH v3] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3

2017-04-04 Thread Nirmoy Das
Add support for SLES12SP3, which uses kernel 4.4, but backported features from newer kernels. Signed-off-by: Nirmoy Das --- lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompa

Re: [dpdk-dev] [PATCH] eal: deprecate rte_cpu_check_supported

2017-04-04 Thread Thomas Monjalon
2017-04-04 09:39, Aaron Conole: > Hi Thomas, > > Thomas Monjalon writes: > > > 2017-03-31 14:31, Aaron Conole: > >> It's likely that this function isn't used anywhere, but since it was part > >> of > >> the public API, mark the function for deprecation for at least one release. > >> > >> Signe

Re: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle

2017-04-04 Thread Shahaf Shuler
Wednesday, April 5, 2017 12:21 AM, Qi Zhang: > The patch change the prototype of callback function > (rte_intr_callback_fn) by removing the unnecessary parameter. > > Signed-off-by: Qi Zhang > --- > > v4: > > - Update mlx5 driver which is missed in v1, v2, v3. Thanks for the update of mlx5. Th

Re: [dpdk-dev] [PATCH v2] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3

2017-04-04 Thread Ferruh Yigit
On 4/4/2017 2:19 PM, Nirmoy Das wrote: > Add support for SLES12SP3, which uses kernel 4.4, > but backported features from newer kernels. > > Signed-off-by: Nirmoy Das > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > d

Re: [dpdk-dev] [PATCH] eal: deprecate rte_cpu_check_supported

2017-04-04 Thread Aaron Conole
Hi Thomas, Thomas Monjalon writes: > 2017-03-31 14:31, Aaron Conole: >> It's likely that this function isn't used anywhere, but since it was part of >> the public API, mark the function for deprecation for at least one release. >> >> Signed-off-by: Aaron Conole Thanks so much for the review!

Re: [dpdk-dev] [PATCH v4] crypto/scheduler: add more EAL options

2017-04-04 Thread Declan Doherty
On 03/04/17 16:33, Fan Zhang wrote: This patch adds initial mode and ordering enable/disable EAL options to cryptodev scheduler PMD. Signed-off-by: Fan Zhang --- ... Acked-by: Declan Doherty

[dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle

2017-04-04 Thread Qi Zhang
The patch change the prototype of callback function (rte_intr_callback_fn) by removing the unnecessary parameter. Signed-off-by: Qi Zhang --- v4: - Update mlx5 driver which is missed in v1, v2, v3. v3: - Update bnx2x driver which is missed in v1,v2 v2: - Seperate patch 1 of v1 into 2 patche

[dpdk-dev] [PATCH v4 1/2] vfio: keep interrupt source read only

2017-04-04 Thread Qi Zhang
Remove the inappropriate modification on get_max_intr field that keep the intr_source read only. Signed-off-by: Qi Zhang --- v4: - Add back this patch to make patch set complete though it already be applied. v2: - Seperate patch 1 of v1 into 2 patches.(part 1) lib/librte_eal/linuxapp/eal/eal

[dpdk-dev] [PATCH v4 0/2] clean up interrupt handle

2017-04-04 Thread Qi Zhang
It seems its not necessary to register an intr_handle for interrupt callback function. "void* cb_arg" shows enough when be used to pass the object that contain the information be required to handle the interrupt event( A typical way which is implemented by almost all driver is by passing a rte_ethd

Re: [dpdk-dev] [PATCH] eal: deprecate rte_cpu_check_supported

2017-04-04 Thread Thomas Monjalon
2017-03-31 14:31, Aaron Conole: > It's likely that this function isn't used anywhere, but since it was part of > the public API, mark the function for deprecation for at least one release. > > Signed-off-by: Aaron Conole [...] > --- a/lib/librte_eal/common/arch/x86/rte_spinlock.c > +++ b/lib/libr

[dpdk-dev] [PATCH v2] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3

2017-04-04 Thread Nirmoy Das
Add support for SLES12SP3, which uses kernel 4.4, but backported features from newer kernels. Signed-off-by: Nirmoy Das --- lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcomp

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] net/sfc/base: fix failure path in EF10 Tx queue PIO enable

2017-04-04 Thread Ferruh Yigit
On 4/4/2017 1:13 PM, Andrew Rybchenko wrote: > From: Andy Moreton > > Coverity issue: 1387551 > Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support") > Cc: sta...@dpdk.org > > Signed-off-by: Andy Moreton > Signed-off-by: Andrew Rybchenko Series applied to dpdk-next-net/master, t

Re: [dpdk-dev] [PATCH] net/sfc: do not dereference pointer before check vs NULL

2017-04-04 Thread Ferruh Yigit
On 4/4/2017 1:49 PM, Andrew Rybchenko wrote: > Coverity issue: 1423925 > Fixes: e18dbbd3083a ("net/sfc: remove EvQ info array to simplify reconfigure") > > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton > --- > It may be squashed into e18dbbd3083a. Squashed into relevant commit in

Re: [dpdk-dev] [PATCH] doc: fix a typo in howto guide

2017-04-04 Thread Thomas Monjalon
2017-03-29 09:58, Mcnamara, John: > From: Yong Wang [mailto:wang.yon...@zte.com.cn] > Sent: Wednesday, March 29, 2017 9:28 AM > > > > Signed-off-by: Yong Wang > > > Good catch. Thanks. > > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script

2017-04-04 Thread Ferruh Yigit
On 3/30/2017 9:42 PM, Thomas Monjalon wrote: > For info, Ferruh did a similar patch: > http://dpdk.org/patch/22443 > Ferruh, OK to keep Bruce one? Sure, go for it, they both do same thing. > > 2017-03-30 16:33, Bruce Richardson: >> On Thu, Mar 30, 2017 at 04:36:11PM +0200, Thomas Monjalon

Re: [dpdk-dev] [PATCH v1] lib: fix coverity issues in distributor allocation

2017-04-04 Thread Thomas Monjalon
2017-04-04 03:42, David Hunt: > Coverity issue 143258: not freeing distributor instance > Coverity issue 143254: not checking return code from malloc > > Fixes: 775003ad2f96 ("distributor: add new burst-capable library") > > Signed-off-by: David Hunt Applied with this title: distributor

  1   2   >