Re: [dpdk-dev] [PATCH v2] eventdev: event device to contain rte device holder

2017-03-06 Thread Jerin Jacob
On Fri, Mar 03, 2017 at 09:03:02PM +0530, Nipun Gupta wrote: > rte_device is a generic device which is available to the applications > and EAL. This patch replaces rte_pci_device in 'struct rte_eventdev' > and in 'struct rte_event_dev_info' with common rte_device. Does anyone have any objection on

Re: [dpdk-dev] [PATCH v2] eventdev: Fix links_map initialization for sw PMD

2017-03-06 Thread Jerin Jacob
On Mon, Mar 06, 2017 at 11:02:48AM -0600, Gage Eads wrote: Please fix the check-git-log.sh errors with this patch. With that change, Acked-by: Jerin Jacob ➜ $ ./devtools/check-git-log.sh Wrong headline format: eventdev: Fix links_map initialization for sw PMD Wrong headline uppercase:

Re: [dpdk-dev] [PATCH 2/2] net/i40e: configurable PTYPE mapping

2017-03-06 Thread Zhang, Qi Z
Hi Ferruh: Thanks all the good suggestion and help. > -Original Message- > From: Yigit, Ferruh > Sent: Monday, March 6, 2017 11:32 PM > To: Zhang, Qi Z ; Wu, Jingjing > ; Zhang, Helin > Cc: dev@dpdk.org; Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH 2/2] net/i40e

Re: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd

2017-03-06 Thread Ravi Kerur
Hi John, Should I work with documentation team to update the document? If yes, please let me know the contact information. Thanks. On Mon, Mar 6, 2017 at 5:33 AM, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kerur > > Sent:

Re: [dpdk-dev] [v3 2/3] LPM config file read option.

2017-03-06 Thread Ravi Kerur
Sure Stephen will make the changes. On Mon, Mar 6, 2017 at 8:46 AM, Stephen Hemminger < step...@networkplumber.org> wrote: > On Sat, 4 Mar 2017 12:44:18 -0800 > Ravi Kerur wrote: > > > +/* Bypass comment and empty lines */ > > +static inline int > > +is_bypass_line(char *buff) > > +{ > > +

Re: [dpdk-dev] [PATCH v2 4/7] net/vmxnet3: add receive data ring support

2017-03-06 Thread Shrikrishna Khare
On Mon, 6 Mar 2017, Thomas Monjalon wrote: > 2017-03-06 09:17, Shrikrishna Khare: > > Receive Data Ring buffer length is configurable via ethtool -G ethX rx-mini > > Are you configuring the ring length before unbinding from the kernel driver? Changing rx data ring requires changing the code an

[dpdk-dev] [PATCH v3 2/7] net/vmxnet3: introduce generalized cmd interface

2017-03-06 Thread Shrikrishna Khare
Shared memory is used to exchange information between the vmxnet3 driver and the emulation. In order to request emulation to perform a task, the driver first populates specific fields in this shared memory and then issues corresponding command by writing to the command register(CMD). The layout of

[dpdk-dev] [PATCH v3 7/7] net/vmxnet3: update to version 3

2017-03-06 Thread Shrikrishna Khare
With all vmxnet3 version 3 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 3, provided the emulation advertises support for version 3. This patch also updates release notes. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: J

[dpdk-dev] [PATCH v3 0/7] vmxnet3: upgrade to version 3

2017-03-06 Thread Shrikrishna Khare
vmxnet3 emulation has recently added several new features which includes support for new commands the driver can issue to emulation, change in descriptor fields etc. This patch series extends the vmxnet3 driver to leverage these new features. Compatibility is maintained using existing vmxnet3 vers

[dpdk-dev] [PATCH v3 5/7] net/vmxnet3: add reserved version 3 command

2017-03-06 Thread Shrikrishna Khare
This command is reserved. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h

[dpdk-dev] [PATCH v3 6/7] net/vmxnet3: add cmd to register memory region

2017-03-06 Thread Shrikrishna Khare
In vmxnet3 version 3, the emulation added support for the vmxnet3 driver to communicate information about the memory regions the driver will use for rx/tx buffers. The driver can also indicate which rx/tx queue the memory region is applicable for. If this information is communicated to the emulatio

[dpdk-dev] [PATCH v3 4/7] net/vmxnet3: add receive data ring support

2017-03-06 Thread Shrikrishna Khare
vmxnet3 driver preallocates buffers for receiving packets and posts the buffers to the emulation. In order to deliver a received packet to the guest, the emulation must map buffer(s) and copy the packet into it. To avoid this memory mapping overhead, this patch introduces the receive data ring - a

[dpdk-dev] [PATCH v3 1/7] net/vmxnet3: prepare for version 3 changes

2017-03-06 Thread Shrikrishna Khare
Cleanup some code in preparation of vmxnet3 version 3 changes. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 17 + drivers/net/vmxnet3/vmxnet3_ethdev.h | 9 + 2 files changed, 22 insertions(+), 4 delet

[dpdk-dev] [PATCH v3 3/7] net/vmxnet3: variable length transmit data ring

2017-03-06 Thread Shrikrishna Khare
vmxnet3 driver supports transmit data ring viz. a set of fixed size buffers used by the driver to copy packet headers. Small packets that fit these buffers are copied into these buffers entirely. Currently this buffer size of fixed at 128 bytes. This patch extends transmit data ring implementation

Re: [dpdk-dev] [PATCH v2 4/7] net/vmxnet3: add receive data ring support

2017-03-06 Thread Thomas Monjalon
2017-03-06 09:17, Shrikrishna Khare: > Receive Data Ring buffer length is configurable via ethtool -G ethX rx-mini Are you configuring the ring length before unbinding from the kernel driver?

[dpdk-dev] [dpdk-announce] Live TCP latency monitoring and visualisation in 3D with Ruru

2017-03-06 Thread Richard Cziva
Hello DPDK community, REANNZ (New Zealand’s Research and Education Advanced Network provider) has announced Ruru, a real-time TCP latency monitor, built using DPDK. If you are interested, check this news article on Ruru (also linked on http://dpdk.org/news ): https://rea

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API

2017-03-06 Thread Stephen Hemminger
On Mon, 6 Mar 2017 20:41:27 + "Wiles, Keith" wrote: > Being able to add features without having to change DPDK maybe a strong > feature for companies that have special needs for its application. They just > need to add a rte_eth_capability enum in a range that they want to control > (which

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API

2017-03-06 Thread Wiles, Keith
> On Mar 6, 2017, at 2:21 PM, Thomas Monjalon wrote: > >> From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] >>> 2017-03-06 16:35, Dumitrescu, Cristian: >> +int rte_eth_dev_capability_ops_get(uint8_t port_id, >> +enum rte_eth_capability cap, void *arg); > > What is

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API

2017-03-06 Thread Thomas Monjalon
> From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2017-03-06 16:35, Dumitrescu, Cristian: > > > > > +int rte_eth_dev_capability_ops_get(uint8_t port_id, > > > > > + enum rte_eth_capability cap, void *arg); > > > > > > > > What is the benefit of getting different kind of capabilitie

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-06 Thread Thomas Monjalon
2017-03-06 16:59, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2017-03-04 01:10, Cristian Dumitrescu: > > > This patch introduces the generic ethdev API for the traffic manager > > > capability, which includes: hierarchical scheduling, traffic shaping, > > >

Re: [dpdk-dev] [PATCH 01/21] net/qede/base: fix incorrect typecasting of flag

2017-03-06 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, March 02, 2017 5:04 AM > > On 2/27/2017 7:51 AM, Rasesh Mody wrote: > > dcbx-update-flag is incorrectly converted to boolean before assigining > > it to ramrod data, fix this typecasting. Also, added more debug > > messages in

Re: [dpdk-dev] [PATCH 30/38] net/qede: Don't use eth_driver

2017-03-06 Thread Harish Patil
>Signed-off-by: Jan Blunck >--- > drivers/net/qede/qede_ethdev.c | 60 >+- > drivers/net/qede/qede_ethdev.h | 1 + > 2 files changed, 37 insertions(+), 24 deletions(-) > >diff --git a/drivers/net/qede/qede_ethdev.c >b/drivers/net/qede/qede_ethdev.c >index 0

Re: [dpdk-dev] [PATCH 17/38] net/bnx2x: Don't use eth_driver

2017-03-06 Thread Harish Patil
> >Signed-off-by: Jan Blunck >--- > drivers/net/bnx2x/bnx2x_ethdev.c | 64 >+++- > 1 file changed, 44 insertions(+), 20 deletions(-) > >diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c >b/drivers/net/bnx2x/bnx2x_ethdev.c >index a0b0dfa..e295951 100644 >--- a/driver

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API

2017-03-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Monday, March 6, 2017 4:57 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hemant.agra...@nxp.com; > shreyansh.j...@nxp.com; W

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, March 6, 2017 4:15 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; thomas.monja...@6wind.com; > jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hemant.agra...@nxp.

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] net/ixgbe: fix multi-queue mode check in SRIOV mode

2017-03-06 Thread Ferruh Yigit
On 2/28/2017 6:26 AM, Jingjing Wu wrote: > In SRIOV case, ETH_MQ_RX_VMDQ_DCB and ETH_MQ_RX_DCB should be considered as > the same meaning, due to the multi-queue mapping is the same SRIOV and VMDq > in ixgbe. > > Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific > drivers"

Re: [dpdk-dev] [PATCH 0/7] vmxnet3: upgrade to version 3

2017-03-06 Thread Shrikrishna Khare
On Fri, 3 Mar 2017, Ferruh Yigit wrote: > > Shrikrishna Khare (7): > > vmxnet3: prepare for version 3 changes > > vmxnet3: introduce generalized command interface to configure the > > device > > vmxnet3: allow variable length transmit data ring buffer > > vmxnet3: add receive data ri

[dpdk-dev] [PATCH v2 5/7] net/vmxnet3: add reserved version 3 command

2017-03-06 Thread Shrikrishna Khare
This command is reserved. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h

[dpdk-dev] [PATCH v2 1/7] net/vmxnet3: prepare for version 3 changes

2017-03-06 Thread Shrikrishna Khare
Cleanup some code in preparation of vmxnet3 version 3 changes. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 17 + drivers/net/vmxnet3/vmxnet3_ethdev.h | 9 + 2 files changed, 22 insertions(+), 4 delet

[dpdk-dev] [PATCH v2 2/7] net/vmxnet3: introduce generalized cmd interface

2017-03-06 Thread Shrikrishna Khare
Shared memory is used to exchange information between the vmxnet3 driver and the emulation. In order to request emulation to perform a task, the driver first populates specific fields in this shared memory and then issues corresponding command by writing to the command register(CMD). The layout of

[dpdk-dev] [PATCH v2 7/7] net/vmxnet3: update to version 3

2017-03-06 Thread Shrikrishna Khare
With all vmxnet3 version 3 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 3, provided the emulation advertises support for version 3. This patch also updates release notes. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: J

[dpdk-dev] [PATCH v2 0/7] vmxnet3: upgrade to version 3

2017-03-06 Thread Shrikrishna Khare
vmxnet3 emulation has recently added several new features which includes support for new commands the driver can issue to emulation, change in descriptor fields etc. This patch series extends the vmxnet3 driver to leverage these new features. Compatibility is maintained using existing vmxnet3 vers

[dpdk-dev] [PATCH v2 4/7] net/vmxnet3: add receive data ring support

2017-03-06 Thread Shrikrishna Khare
vmxnet3 driver preallocates buffers for receiving packets and posts the buffers to the emulation. In order to deliver a received packet to the guest, the emulation must map buffer(s) and copy the packet into it. To avoid this memory mapping overhead, this patch introduces the receive data ring - a

[dpdk-dev] [PATCH v2 6/7] net/vmxnet3: add cmd to register memory region

2017-03-06 Thread Shrikrishna Khare
In vmxnet3 version 3, the emulation added support for the vmxnet3 driver to communicate information about the memory regions the driver will use for rx/tx buffers. The driver can also indicate which rx/tx queue the memory region is applicable for. If this information is communicated to the emulatio

[dpdk-dev] [PATCH v2 3/7] net/vmxnet3: variable length transmit data ring

2017-03-06 Thread Shrikrishna Khare
vmxnet3 driver supports transmit data ring viz. a set of fixed size buffers used by the driver to copy packet headers. Small packets that fit these buffers are copied into these buffers entirely. Currently this buffer size of fixed at 128 bytes. This patch extends transmit data ring implementation

[dpdk-dev] [PATCH v2 2/4] net/tap: add preliminary support for rte_flow

2017-03-06 Thread Pascal Mazon
The flow API provides the ability to classify packets received by a tap netdevice. This patch only implements skeleton functions for flow API support, no patterns are supported yet. Signed-off-by: Pascal Mazon Acked-by: Olga Shern --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/M

[dpdk-dev] [PATCH v2 4/4] net/tap: add basic flow API patterns and actions

2017-03-06 Thread Pascal Mazon
Supported flow rules are now mapped to TC rules on the tap netdevice. The netlink message used for creating the TC rule is stored in struct rte_flow. That way, by simply changing a metadata in it, we can require for the rule deletion without further parsing. Supported items: - eth: src and dst (wi

[dpdk-dev] [PATCH v2 3/4] net/tap: add netlink back-end for flow API

2017-03-06 Thread Pascal Mazon
Each kernel netdevice may have queueing disciplines set for it, which determine how to handle the packet (mostly on egress). That's part of the TC (Traffic Control) mechanism. Through TC, it is possible to set filter rules that match specific packets, and act according to what is in the rule. This

[dpdk-dev] [PATCH v2 1/4] net/tap: move private elements to external header

2017-03-06 Thread Pascal Mazon
In the next patch, access to struct pmd_internals will be necessary in tap_flow.c to store the flows. Signed-off-by: Pascal Mazon Acked-by: Olga Shern --- drivers/net/tap/Makefile | 1 + drivers/net/tap/rte_eth_tap.c | 34 ++-- drivers/net/tap/tap.h | 73 ++

[dpdk-dev] [PATCH v2 0/4] net/tap: support flow API

2017-03-06 Thread Pascal Mazon
This series add support for the flow API in tap PMD. It enables filtering specific packets incoming on the tap netdevice, to process only desired ones. Under the hood, it uses kernel TC (traffic control), which takes place very early in the stack, and supports most common pattern items and actions

[dpdk-dev] [PATCH v2] eventdev: Fix links_map initialization for sw PMD

2017-03-06 Thread Gage Eads
This patch initializes the links_map array entries to EVENT_QUEUE_SERVICE_PRIORITY_INVALID, as expected by rte_event_port_links_get(). This is necessary for the sw eventdev PMD, which does not initialize links_map when rte_event_port_setup() calls rte_event_port_unlink(). Signed-off-by: Gage Eads

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Monday, March 6, 2017 10:39 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hemant.agra...@nxp.com; > shreyansh.j...@nxp.com >

Re: [dpdk-dev] [PATCH] eventdev: Fix links_map initialization

2017-03-06 Thread Jerin Jacob
On Mon, Mar 06, 2017 at 02:38:05PM +, Eads, Gage wrote: > > -Original Message- > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Monday, March 6, 2017 7:06 AM > > To: Eads, Gage > > Cc: dev@dpdk.org; Richardson, Bruce ; > > hemant.agra...@nxp.com; Van Haaren

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API

2017-03-06 Thread Thomas Monjalon
2017-03-06 16:35, Dumitrescu, Cristian: > Hi Thomas, > > Thanks for reviewing this proposal. > > > > > Signed-off-by: Cristian Dumitrescu > > > Acked-by: Keith Wiles > > > Acked-by: Jerin Jacob > > > Acked-by: Hemant Agrawal > > [...] > > > +enum rte_eth_capability { > > > + RTE_ETH_CAPABILI

Re: [dpdk-dev] [PATCH v2] cryptodev: enable BPI for Cablelabs DOCSIS security spec

2017-03-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, February 23, 2017 2:03 PM > To: Doherty, Declan; Trahe, Fiona > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2] cryptodev: enable BPI for Cablelabs DOCSIS security > spec > > Extend the DPDK cryptodev API

Re: [dpdk-dev] [PATCH v3] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le

2017-03-06 Thread Burakov, Anatoly
> From: Gowrishankar [mailto:gowrishanka...@linux.vnet.ibm.com] > Sent: Monday, March 6, 2017 3:04 PM > To: dev@dpdk.org > Cc: Chao Zhu ; Burakov, Anatoly > ; Thomas Monjalon > ; Gowrishankar Muthukrishnan > > Subject: [PATCH v3] eal: sPAPR IOMMU support in pci probing for vfio-pci in > ppc64le >

Re: [dpdk-dev] [v3 2/3] LPM config file read option.

2017-03-06 Thread Stephen Hemminger
On Sat, 4 Mar 2017 12:44:18 -0800 Ravi Kerur wrote: > +/* Bypass comment and empty lines */ > +static inline int > +is_bypass_line(char *buff) > +{ > + int i = 0; > + > + /* comment line */ > + if (buff[0] == COMMENT_LEAD_CHAR) > + return 1; > + /* empty line */ > +

Re: [dpdk-dev] [v3 2/3] LPM config file read option.

2017-03-06 Thread Stephen Hemminger
On Sat, 4 Mar 2017 12:44:18 -0800 Ravi Kerur wrote: > +#define GET_CB_FIELD(in, fd, base, lim, dlm) do {\ > + unsigned long val; \ > + char *end; \ > + errno = 0;

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API

2017-03-06 Thread Dumitrescu, Cristian
> > It is difficult to follow previous discussions as you do not > keep threading with --in-reply-to. > Apologies, will do in the future.

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix invalid latency for QAT PMD

2017-03-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir > Mrozowicz > Sent: Thursday, February 16, 2017 3:51 PM > To: Doherty, Declan > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix invalid latency for QAT > PMD > >

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API

2017-03-06 Thread Dumitrescu, Cristian
Hi Thomas, Thanks for reviewing this proposal. > > Signed-off-by: Cristian Dumitrescu > > Acked-by: Keith Wiles > > Acked-by: Jerin Jacob > > Acked-by: Hemant Agrawal > [...] > > +enum rte_eth_capability { > > + RTE_ETH_CAPABILITY_FLOW = 0, /**< Flow */ > > + RTE_ETH_CAPABILITY_TM, /**<

[dpdk-dev] [PATCH v2 6/6] net/tap: add flow control management

2017-03-06 Thread Pascal Mazon
A tap netdevice does not support flow control; ensure nothing but RTE_FC_NONE mode can be set. Signed-off-by: Pascal Mazon --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 19 +++ 2 files changed, 20 insertions(+) diff --git a/doc/guides/nics/featu

[dpdk-dev] [PATCH v2 5/6] net/tap: add packet type management

2017-03-06 Thread Pascal Mazon
Advertize RTE_PTYPE_UNKNOWN since tap does not report any packet type. Signed-off-by: Pascal Mazon --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 15 +++ 2 files changed, 16 insertions(+) diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nic

[dpdk-dev] [PATCH v2 3/6] net/tap: add multicast addresses management

2017-03-06 Thread Pascal Mazon
A tap netdevice actually receives every packet, without any filtering whatsoever. There is no need for any multicast address registration to receive multicast packets. Signed-off-by: Pascal Mazon --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 13 + 2

[dpdk-dev] [PATCH v2 4/6] net/tap: add MTU management

2017-03-06 Thread Pascal Mazon
The MTU is assigned to the tap netdevice according to the argument, but packet transmission and reception just write/read on an fd with the default limit being the socket buffer size. Signed-off-by: Pascal Mazon --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 37 +

[dpdk-dev] [PATCH v2 0/6] net/tap: add additional management ops

2017-03-06 Thread Pascal Mazon
Add a few eth_dev ops to the tap PMD for completeness. We want it to behave as much as possible as a standard PMD. v2 change: - use snprintf in tap_mtu set Pascal Mazon (6): net/tap: add MAC address management ops net/tap: add speed capabilities net/tap: add multicast addresses management

[dpdk-dev] [PATCH v2 2/6] net/tap: add speed capabilities

2017-03-06 Thread Pascal Mazon
Tap PMD is flexible, it supports any speed. Signed-off-by: Pascal Mazon --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 35 +++ 2 files changed, 36 insertions(+) diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/featu

[dpdk-dev] [PATCH v2 1/6] net/tap: add MAC address management ops

2017-03-06 Thread Pascal Mazon
Set a random MAC address when probing the device, as to not leave an empty MAC in pmd->eth_addr. This MAC will be set on the tap netdevice as soon as it's been created using tun_alloc(). As the tap_mac_add() function depend on the fd in the first rxq, move code from tun_alloc() to tap_setup_queue(

Re: [dpdk-dev] [PATCH] doc: fix renamed bind tool

2017-03-06 Thread Thomas Monjalon
2017-03-06 17:15, Julien Castets: > From: Julien Castets > > Signed-off-by: Julien Castets Applied, thanks

[dpdk-dev] [PATCH v9 18/18] maintainers: add to distributor lib maintainers

2017-03-06 Thread David Hunt
Signed-off-by: David Hunt --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5030c1c..42eece0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -501,6 +501,7 @@ F: doc/guides/sample_app_ug/ip_reassembly.rst Distributor M: Bruce Richardson +M: Davi

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix all queues drop setting of DCB

2017-03-06 Thread Ferruh Yigit
On 2/27/2017 5:34 AM, Wenzhuo Lu wrote: > DCB is split to RX and TX mode. All-queues-drop is set > for TX mode. It's not appropriate because all-queue-drop > is a RX feature. Move this setting from TX to RX. > > Fixes: 0807f80d35d0 (ixgbe: DCB / flow control) > CC: sta...@dpdk.org > > Signed-off-

[dpdk-dev] [PATCH] doc: fix renamed bind tool

2017-03-06 Thread Julien Castets
From: Julien Castets Signed-off-by: Julien Castets --- doc/guides/linux_gsg/build_dpdk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/linux_gsg/build_dpdk.rst b/doc/guides/linux_gsg/build_dpdk.rst index eadade276..9d245737d 100644 --- a/doc/guides/linux_gsg/

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-06 Thread Stephen Hemminger
On Sat, 4 Mar 2017 01:10:20 + Cristian Dumitrescu wrote: > +/* Get generic traffic manager operations structure from a port. */ > +const struct rte_tm_ops * > +rte_tm_ops_get(uint8_t port_id, struct rte_tm_error *error) > +{ > + struct rte_eth_dev *dev = &rte_eth_devices[port_id]; > +

Re: [dpdk-dev] [PATCH v3] net/tap: fix dev name look-up

2017-03-06 Thread Wiles, Keith
> On Mar 6, 2017, at 10:03 AM, Yigit, Ferruh wrote: > > On 3/6/2017 3:42 PM, Ferruh Yigit wrote: >> On 3/6/2017 3:16 PM, Wiles, Keith wrote: >>> On Mar 6, 2017, at 9:13 AM, Pascal Mazon wrote: Store the device name in dev->data->name, to have symmetrical behavior between r

[dpdk-dev] [PATCH v9 16/18] examples/distributor: give Rx thread a core

2017-03-06 Thread David Hunt
This so that with the increased amount of stats we are counting, we don't interfere with the rx core. Signed-off-by: David Hunt --- examples/distributor/main.c | 50 ++--- 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/examples/distributor

[dpdk-dev] [PATCH v9 17/18] doc: distributor library changes for new burst API

2017-03-06 Thread David Hunt
Signed-off-by: David Hunt --- doc/guides/prog_guide/packet_distrib_lib.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/prog_guide/packet_distrib_lib.rst b/doc/guides/prog_guide/packet_distrib_lib.rst index b5bdabb..e0adcaa 100644 --- a/doc/guides/prog_guide/packet_distrib_l

[dpdk-dev] [PATCH v9 15/18] examples/distributor: limit number of Tx rings

2017-03-06 Thread David Hunt
Signed-off-by: David Hunt --- examples/distributor/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index e9ebe5e..cf2e826 100644 --- a/examples/distributor/main.c +++ b/examples/distribut

[dpdk-dev] [PATCH v9 14/18] examples/distributor: give distributor a core

2017-03-06 Thread David Hunt
Signed-off-by: David Hunt --- examples/distributor/main.c | 181 ++-- 1 file changed, 123 insertions(+), 58 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index aeb75a8..e9ebe5e 100644 --- a/examples/distributor/main.c

[dpdk-dev] [PATCH v9 13/18] sample: distributor: wait for ports to come up

2017-03-06 Thread David Hunt
On some machines, ports take several seconds to come up. This patch causes the app to wait. Signed-off-by: David Hunt --- examples/distributor/main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index 3657e5d

[dpdk-dev] [PATCH v9 12/18] examples/distributor: allow for extra stats

2017-03-06 Thread David Hunt
This will allow us to see what's going on at various stages throughout the sample app, with per-second visibility Signed-off-by: David Hunt --- examples/distributor/main.c | 139 +++- 1 file changed, 123 insertions(+), 16 deletions(-) diff --git a/example

[dpdk-dev] [PATCH v9 11/18] test: add perf test for distributor burst mode

2017-03-06 Thread David Hunt
Signed-off-by: David Hunt --- test/test/test_distributor_perf.c | 75 ++- 1 file changed, 51 insertions(+), 24 deletions(-) diff --git a/test/test/test_distributor_perf.c b/test/test/test_distributor_perf.c index 1dd326b..732d86d 100644 --- a/test/test/test_d

[dpdk-dev] [PATCH v9 10/18] test: test single and burst distributor API

2017-03-06 Thread David Hunt
Signed-off-by: David Hunt --- test/test/test_distributor.c | 116 ++- 1 file changed, 82 insertions(+), 34 deletions(-) diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c index 7a30513..890a852 100644 --- a/test/test/test_distributor.

[dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor

2017-03-06 Thread David Hunt
Also bumped up the ABI version number in the Makefile Signed-off-by: David Hunt --- lib/librte_distributor/Makefile| 2 +- lib/librte_distributor/rte_distributor.c | 57 +++--- lib/librte_distributor/rte_distributor_v1705.h | 89 ++

[dpdk-dev] [PATCH v9 08/18] lib: make v20 header file private

2017-03-06 Thread David Hunt
Signed-off-by: David Hunt --- lib/librte_distributor/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile index a812fe4..2b28eff 100644 --- a/lib/librte_distributor/Makefile +++ b/lib/librte_distributor/Makefile @@ -57,7 +57

[dpdk-dev] [PATCH v9 06/18] test/distributor: extra params for autotests

2017-03-06 Thread David Hunt
In the next few patches, we'll want to test old and new API, so here we're allowing different parameters to be passed to the tests, instead of just a distributor struct. Signed-off-by: David Hunt --- test/test/test_distributor.c | 64 +--- 1 file changed,

[dpdk-dev] [PATCH v9 07/18] lib: switch distributor over to new API

2017-03-06 Thread David Hunt
This is the main switch over between the legacy API and the new burst API. We rename all the functions in rte_distributor.c to remove the _v1705, and we add in _v20 in the rte_distributor_v20.c At the same time, we need the autotests and sample app to compile properly, hence thosie changes are in

[dpdk-dev] [PATCH v9 05/18] lib: add SIMD flow matching to distributor

2017-03-06 Thread David Hunt
Add an optimised version of the in-flight flow matching algorithm using SIMD instructions. This should give up to 1.5x over the scalar versions performance. Falls back to scalar version if SSE4.2 not available Signed-off-by: David Hunt --- lib/librte_distributor/Makefile| 1

[dpdk-dev] [PATCH v9 03/18] lib: add new burst oriented distributor structs

2017-03-06 Thread David Hunt
Signed-off-by: David Hunt --- lib/librte_distributor/rte_distributor_private.h | 56 1 file changed, 56 insertions(+) diff --git a/lib/librte_distributor/rte_distributor_private.h b/lib/librte_distributor/rte_distributor_private.h index 6d72f1c..d3a470e 100644 --- a/lib

[dpdk-dev] [PATCH v9 04/18] lib: add new distributor code

2017-03-06 Thread David Hunt
This patch includes public header file which will be used once we add in the symbol versioning for v20 and v1705 APIs. Also includes v1702 header file, and code for new burst-capable distributor library. This will be re-named as rte_distributor.h later in the patch-set The new distributor code co

[dpdk-dev] [PATCH v9 01/18] lib: rename legacy distributor lib files

2017-03-06 Thread David Hunt
Move files out of the way so that we can replace with new versions of the distributor libtrary. Files are named in such a way as to match the symbol versioning that we will apply for backward ABI compatibility. Signed-off-by: David Hunt --- lib/librte_distributor/Makefile|

[dpdk-dev] [PATCH v9 02/18] lib: create private header file

2017-03-06 Thread David Hunt
We'll be adding internal implementation definitions in here that are common to both burst and legacy APIs. Signed-off-by: David Hunt --- lib/librte_distributor/rte_distributor_private.h | 136 +++ lib/librte_distributor/rte_distributor_v20.c | 72 +--- 2 files ch

[dpdk-dev] [PATCH v9 00/18] distributor lib performance enhancements

2017-03-06 Thread David Hunt
This patch aims to improve the throughput of the distributor library. It uses a similar handshake mechanism to the previous version of the library, in that bits are used to indicate when packets are ready to be sent to a worker and ready to be returned from a worker. One main difference is that in

Re: [dpdk-dev] [PATCH v3] net/tap: fix dev name look-up

2017-03-06 Thread Ferruh Yigit
On 3/6/2017 3:55 PM, Pascal Mazon wrote: > On Mon, 6 Mar 2017 15:41:14 + > Ferruh Yigit wrote: > >> On 3/6/2017 3:13 PM, Pascal Mazon wrote: >>> Store the device name in dev->data->name, to have symmetrical >>> behavior between rte_pmd_tap_probe(name) and >>> rte_pmd_tap_remove(name). >>> >>>

Re: [dpdk-dev] [PATCH v3] net/tap: fix dev name look-up

2017-03-06 Thread Ferruh Yigit
On 3/6/2017 3:42 PM, Ferruh Yigit wrote: > On 3/6/2017 3:16 PM, Wiles, Keith wrote: >> >>> On Mar 6, 2017, at 9:13 AM, Pascal Mazon wrote: >>> >>> Store the device name in dev->data->name, to have symmetrical behavior >>> between rte_pmd_tap_probe(name) and rte_pmd_tap_remove(name). >>> >>> The ne

Re: [dpdk-dev] [PATCH v3] net/tap: fix dev name look-up

2017-03-06 Thread Pascal Mazon
On Mon, 6 Mar 2017 15:41:14 + Ferruh Yigit wrote: > On 3/6/2017 3:13 PM, Pascal Mazon wrote: > > Store the device name in dev->data->name, to have symmetrical > > behavior between rte_pmd_tap_probe(name) and > > rte_pmd_tap_remove(name). > > > > The netdevice name (linux interface name) is s

Re: [dpdk-dev] [PATCH v3] net/tap: fix dev name look-up

2017-03-06 Thread Ferruh Yigit
On 3/6/2017 3:16 PM, Wiles, Keith wrote: > >> On Mar 6, 2017, at 9:13 AM, Pascal Mazon wrote: >> >> Store the device name in dev->data->name, to have symmetrical behavior >> between rte_pmd_tap_probe(name) and rte_pmd_tap_remove(name). >> >> The netdevice name (linux interface name) is stored in

Re: [dpdk-dev] [PATCH v3] net/tap: fix dev name look-up

2017-03-06 Thread Ferruh Yigit
On 3/6/2017 3:13 PM, Pascal Mazon wrote: > Store the device name in dev->data->name, to have symmetrical behavior > between rte_pmd_tap_probe(name) and rte_pmd_tap_remove(name). > > The netdevice name (linux interface name) is stored in the name field of > struct pmd_internals. > > snprintf(data-

Re: [dpdk-dev] [PATCH 2/2] net/i40e: configurable PTYPE mapping

2017-03-06 Thread Ferruh Yigit
On 2/27/2017 4:56 AM, Qi Zhang wrote: > The patch adds 4 APIs to support configurable > PTYPE mapping for i40e device. > rte_pmd_i40e_update_ptype_mapping. > rte_pmd_i40e_reset_ptype_mapping. > rte_pmd_i40e_get_ptype_mapping. > rte_pmd_i40e_replace_ptype_mapping. Hi Qi, These are added as PMD spe

Re: [dpdk-dev] [PATCH] Fix doc: dpdk_nic_bind.py renamed to dpdk-devbind.py

2017-03-06 Thread Thomas Monjalon
2017-03-06 14:58, Julien Castets: > From: Julien Castets Please add a Signed-off-by: About the title, it may be "doc: fix renamed bind tool" Thanks

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-06 Thread Thomas Monjalon
2017-03-02 13:03, Singh, Jasvinder: > Hi Thomas, > > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > Sent: Wednesday, March 1, 2017 6:46 PM > > To: Singh, Jasvinder > > Cc: dev@dpdk.org; Doherty, Declan > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] libr

Re: [dpdk-dev] [PATCH 6/6] doc: introduction to prgdev

2017-03-06 Thread Thomas Monjalon
2017-03-02 12:03, Chen Jing D: > +Overview > + I think the first review pass of this series must be focused on the overview you give here (thanks for the detailed explanations). I'll try to sum up while commenting. [...] The target is programmable devices. > +The major purpose of prgdev

Re: [dpdk-dev] [PATCH v3] net/tap: fix dev name look-up

2017-03-06 Thread Wiles, Keith
> On Mar 6, 2017, at 9:13 AM, Pascal Mazon wrote: > > Store the device name in dev->data->name, to have symmetrical behavior > between rte_pmd_tap_probe(name) and rte_pmd_tap_remove(name). > > The netdevice name (linux interface name) is stored in the name field of > struct pmd_internals. > >

[dpdk-dev] [PATCH v3] net/tap: fix dev name look-up

2017-03-06 Thread Pascal Mazon
Store the device name in dev->data->name, to have symmetrical behavior between rte_pmd_tap_probe(name) and rte_pmd_tap_remove(name). The netdevice name (linux interface name) is stored in the name field of struct pmd_internals. snprintf(data->name) has been moved closer to the rte_ethdev_allocate

[dpdk-dev] [PATCH v3] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le

2017-03-06 Thread Gowrishankar
From: Gowrishankar Muthukrishnan Below changes adds pci probing support for vfio-pci devices in power8. v3 - better validation for kernel not implementing few iocts called v2 - kernel version checked and doc updated Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/rel_notes/release_17

Re: [dpdk-dev] [PATCH] devtools: add long lines to the list of options

2017-03-06 Thread Thomas Monjalon
2017-03-01 12:44, Allain Legacy: > The checkpatch.pl tool is flagging warnings on long debug log strings. > Since splitting these strings makes it difficult to search for logs it is > preferred to allow these as exceptions to the long line rule. The addition > of the LONG_LINE_STRINGS to the list

Re: [dpdk-dev] [PATCH v2] net/tap: fix dev name look-up

2017-03-06 Thread Pascal Mazon
On Mon, 6 Mar 2017 14:27:18 + Ferruh Yigit wrote: > On 3/6/2017 1:51 PM, Pascal Mazon wrote: > > Store the device name in dev->data->name, to have symmetrical > > behavior between rte_pmd_tap_probe(name) and > > rte_pmd_tap_remove(name). > > > > The netdevice name (linux interface name) is s

Re: [dpdk-dev] [PATCH 1/4] net/tap: move private elements to external header

2017-03-06 Thread Wiles, Keith
> On Mar 6, 2017, at 8:18 AM, Pascal Mazon wrote: > > On Fri, 3 Mar 2017 15:38:11 + > "Wiles, Keith" wrote: > >> >>> On Mar 3, 2017, at 4:45 AM, Pascal Mazon >>> wrote: >>> >>> In the next patch, access to struct pmd_internals will be necessary >>> in tap_flow.c to store the flows. >>>

Re: [dpdk-dev] [PATCH 5/6] net/tap: add packet type management

2017-03-06 Thread Wiles, Keith
> On Mar 6, 2017, at 8:10 AM, Pascal Mazon wrote: > > On Fri, 3 Mar 2017 15:31:14 + > "Wiles, Keith" wrote: > >> >>> On Mar 3, 2017, at 3:46 AM, Pascal Mazon >>> wrote: >>> >>> Advertize RTE_PTYPE_UNKNOWN since tap does not report any packet >>> type. >>> >>> Signed-off-by: Pascal Mazo

Re: [dpdk-dev] [PATCH 2/6] net/tap: add speed capabilities

2017-03-06 Thread Wiles, Keith
> On Mar 6, 2017, at 7:58 AM, Pascal Mazon wrote: > > On Fri, 3 Mar 2017 15:27:12 + > "Wiles, Keith" wrote: > >> >>> On Mar 3, 2017, at 3:46 AM, Pascal Mazon >>> wrote: >>> >>> Tap PMD is flexible, it supports any speed. >>> >>> Signed-off-by: Pascal Mazon >>> --- >>> doc/guides/nics/

Re: [dpdk-dev] [PATCH] eventdev: Fix links_map initialization

2017-03-06 Thread Eads, Gage
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 6, 2017 7:06 AM > To: Eads, Gage > Cc: dev@dpdk.org; Richardson, Bruce ; > hemant.agra...@nxp.com; Van Haaren, Harry ; > nipun.gu...@nxp.com > Subject: Re: [PATCH] eventdev: Fix l

  1   2   3   >