Re: [dpdk-dev] rte_eth_from_rings

2017-01-27 Thread Sridhar Pitchai
Thanks Bruce. I have created eth_dev from the rings as below. rt = rte_eth_from_rings(port_p->name, (struct rte_ring * const*)port_p->rx_ring_p, 2, (struct rte_ring * const*)port_p->tx_ring_p, 2, rte_socket_id()); Lets say I ha

Re: [dpdk-dev] rte_eth_from_rings

2017-01-27 Thread Bruce Richardson
On Fri, Jan 27, 2017 at 07:16:25PM +, Sridhar Pitchai wrote: > Hi, > > I am trying to write a data path for packets punted to CPU(slowpath) from > vender silicon like broadcom. I am planing to use "rte_eth_from_rings" like > model where I will be able to read and write to the ring for the pa

[dpdk-dev] [RFC 17.05 v1 1/3] Merge l3fwd-acl and l3fwd

2017-01-27 Thread Ravi Kerur
v1: l3fwd-acl changes: > Merge common init code in l3fwd-acl and l3fwd into main.c. > Move non-critical inline functions to l3fwd_acl.h. > Move critial packet processing inline functions to l3fwd

[dpdk-dev] [RFC 17.05 v1 3/3] EM config file read option

2017-01-27 Thread Ravi Kerur
v1: > Remove static array configuration of Dest IP,Src IP, Dest port, Src port, Proto and IF_OUT for EM and EM6 config. > Add reading configuration from a file. > Format of configuration file is as follows #EM route entries, #D

[dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-01-27 Thread Ravi Kerur
Thanks to Konstantin and Bruce on first internal review comments. This patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file read options to build LPM and EM tables. Ravi Kerur (3): Merge l3fwd-acl and l3fwd LPM config file read option EM config file read option examples/l3

[dpdk-dev] [RFC 17.05 v1 2/3] LPM config file read option

2017-01-27 Thread Ravi Kerur
v1: > Remove static array configuration of Destination IP, MASK and IF_OUT for LPM and LPM6 config. > Add reading configuration from a file. > Format of configuration file is as follows #LPM route entries Dest-IP/Mask IF_OUT L1

[dpdk-dev] SIOCSIFFLAGS: Timer expired

2017-01-27 Thread Sridhar Pitchai
Hi , I am creating KNI interface and getting the following error when trying to config IP address. rte_kni_init rte_kni_alloc rte_kni_register_handlers all went through fine. the call back reg for if UP/down is never getting called. What am i missing ? ** the eth_dev here is created with "r

[dpdk-dev] rte_eth_from_rings

2017-01-27 Thread Sridhar Pitchai
Hi, I am trying to write a data path for packets punted to CPU(slowpath) from vender silicon like broadcom. I am planing to use "rte_eth_from_rings" like model where I will be able to read and write to the ring for the packets punted from vendor chip. the eth_dev abstraction provided by "rte_

Re: [dpdk-dev] [PATCH] net/enic: fix MAC address add and remove

2017-01-27 Thread John Daley (johndale)
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, January 27, 2017 3:07 AM > To: John Daley (johndale) > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/enic: fix MAC address add and remove > > On 1/26/2017 8:12 PM, John Daley wrote: > > The mac_addr_

[dpdk-dev] [PATCH v5 3/3] net/vhost: vHost support to free consumed buffers

2017-01-27 Thread Billy McFall
Add support to the vHostdriver for the new API to force free consumed buffers on Tx ring. vHost does not cache the mbufs so there is no work to do. Signed-off-by: Billy McFall --- doc/guides/nics/features/vhost.ini | 1 + drivers/net/vhost/rte_eth_vhost.c | 11 +++ 2 files changed, 12

[dpdk-dev] [PATCH v5 2/3] net/e1000: e1000 igb support to free consumed buffers

2017-01-27 Thread Billy McFall
Add support to the e1000 igb driver for the new API to force free consumed buffers on Tx ring. e1000 igb driver does not implement a tx_rs_thresh to free mbufs, it frees a slot in the ring as needed, so a new function needed to be written. Signed-off-by: Billy McFall --- doc/guides/nics/features

[dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-01-27 Thread Billy McFall
Add a new API to force free consumed buffers on Tx ring. API will return the number of packets freed (0-n) or error code if feature not supported (-ENOTSUP) or input invalid (-ENODEV). Signed-off-by: Billy McFall --- doc/guides/nics/features/default.ini | 1 + doc/guides/prog_guide/mempool_lib

[dpdk-dev] [PATCH v5 0/3] new API to free consumed buffers in Tx ring

2017-01-27 Thread Billy McFall
See request from 11/21/2016: http://dpdk.org/ml/archives/dev/2016-November/050585.html Add a new API to free consumed buffers on TX ring. This addresses two scenarios: 1) Flooding a packet and want to reuse existing mbuf to avoid a packet copy. Increment the reference count of the packet and pol

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix VLAN validation

2017-01-27 Thread Ferruh Yigit
On 1/27/2017 3:35 PM, Nelio Laranjeiro wrote: > TCI field is read from the wrong place due to an invalid cast. Moreover > there is no need to limit matching to VID since PCP and DEI bits can be > matched as well. > > Fixes: 12475fb203ad ("net/mlx5: support VLAN flow item") > > Signed-off-by: Neli

[dpdk-dev] [PATCH v5] ethdev: fix MAC address replay

2017-01-27 Thread Steve Shin
This patch fixes a bug in replaying MAC address to the hardware in rte_eth_dev_config_restore() routine. Added default MAC replay as well. Fixes: 4bdefaade6d1 ("ethdev: VMDQ enhancements") --- v2: Added default MAC replay & Code optimization. v3: Covered a case (ex, SR-IOV) where multiple pools

Re: [dpdk-dev] [PATCH 1/9] net/ixgbe: remove redundant EOL character from logs

2017-01-27 Thread Stephen Hemminger
On Fri, 27 Jan 2017 17:46:11 + Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit Thanks for fixing this. Acked-by: Stephen Hemminger

[dpdk-dev] [PATCH 9/9] net/virtio: remove redundant EOL char from logs

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/virtio/virtio_ethdev.c | 14 +++--- drivers/net/virtio/virtio_rxtx.c | 2 +- drivers/net/virtio/virtio_user/virtio_user_dev.c | 4 ++-- drivers/net/virtio/virtio_user_ethdev.c | 8 4 files chang

[dpdk-dev] [PATCH 7/9] net/qede: remove redundant EOL char from logs

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/qede/qede_rxtx.c | 68 ++-- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 821ffbc..01ea9b4 100644 --- a/drivers/net/qede/qede_rxt

[dpdk-dev] [PATCH 8/9] net/sfc: remove redundant EOL char from logs

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/sfc/sfc_ev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c index fe6de6f..f717faa 100644 --- a/drivers/net/sfc/sfc_ev.c +++ b/drivers/net/sfc/sfc_ev.c @@ -104,7 +104,7 @@ sfc_

[dpdk-dev] [PATCH 6/9] net/nfp: remove redundant EOL char from logs

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/nfp/nfp_net.c | 58 +++ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 1020d9e..173bebf 100644 --- a/drivers/net/nfp/nfp_net.c +++ b

[dpdk-dev] [PATCH 5/9] net/ena: remove redundant EOL char from logs

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/ena/ena_ethdev.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index a580345..ff36c64 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/en

[dpdk-dev] [PATCH 1/9] net/ixgbe: remove redundant EOL character from logs

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/ixgbe/ixgbe_ethdev.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index edbf75b..5b625a3 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/driver

[dpdk-dev] [PATCH 2/9] net/i40e: remove redundant EOL char from logs

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.c| 51 ++- drivers/net/i40e/i40e_ethdev_vf.c | 31 drivers/net/i40e/i40e_fdir.c | 2 +- drivers/net/i40e/i40e_pf.c| 4 +-- drivers/net/i40e/i40e_rxtx.c

[dpdk-dev] [PATCH 3/9] net/e1000: remove redundant EOL char from logs

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/e1000/em_ethdev.c | 4 ++-- drivers/net/e1000/igb_ethdev.c | 12 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index d67fdef..d778785 100644 --- a/drivers/net/

[dpdk-dev] [PATCH 4/9] net/bnx2x: remove redundant EOL char from logs

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/bnx2x/bnx2x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 0d16a73..cc380bd 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -2220,7 +2220,7 @@ i

Re: [dpdk-dev] [PATCH 25/25] rte_eal_init: add info about rte_errno codes

2017-01-27 Thread Stephen Hemminger
On Fri, 27 Jan 2017 16:47:40 + Bruce Richardson wrote: > On Fri, Jan 27, 2017 at 08:33:46AM -0800, Stephen Hemminger wrote: > > On Fri, 27 Jan 2017 09:57:03 -0500 > > Aaron Conole wrote: > > > > > diff --git a/lib/librte_eal/common/include/rte_eal.h > > > b/lib/librte_eal/common/include/

[dpdk-dev] [PATCH v2] doc: automate examples file list for API doc

2017-01-27 Thread Ferruh Yigit
These files are linked to API documentation as usage samples, list of files created automatically during doc creation. Remove manually updated old one. Signed-off-by: Ferruh Yigit --- doc/api/doxy-api.conf | 1 - doc/api/examples.dox | 115 --

Re: [dpdk-dev] [PATCH] doc: update examples list for API

2017-01-27 Thread Ferruh Yigit
On 1/27/2017 3:56 PM, Thomas Monjalon wrote: > 2017-01-27 11:55, Ferruh Yigit: >> These files are linked to API documentation as usage samples, added >> missing examples files and sorted list alphabetically. >> >> Signed-off-by: Ferruh Yigit > > Why not replacing this list with a "find examples -

Re: [dpdk-dev] [PATCH 25/25] rte_eal_init: add info about rte_errno codes

2017-01-27 Thread Bruce Richardson
On Fri, Jan 27, 2017 at 08:33:46AM -0800, Stephen Hemminger wrote: > On Fri, 27 Jan 2017 09:57:03 -0500 > Aaron Conole wrote: > > > diff --git a/lib/librte_eal/common/include/rte_eal.h > > b/lib/librte_eal/common/include/rte_eal.h > > index 03fee50..46e427f 100644 > > --- a/lib/librte_eal/common

Re: [dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init

2017-01-27 Thread Bruce Richardson
On Fri, Jan 27, 2017 at 08:31:55AM -0800, Stephen Hemminger wrote: > On Fri, 27 Jan 2017 09:56:53 -0500 > Aaron Conole wrote: > > > + if (rte_eal_alarm_init() < 0) { > > + RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n"); > > + /* rte_eal_alarm_init sets rte_err

Re: [dpdk-dev] [PATCH 25/25] rte_eal_init: add info about rte_errno codes

2017-01-27 Thread Stephen Hemminger
On Fri, 27 Jan 2017 09:57:03 -0500 Aaron Conole wrote: > diff --git a/lib/librte_eal/common/include/rte_eal.h > b/lib/librte_eal/common/include/rte_eal.h > index 03fee50..46e427f 100644 > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -159,7 +1

Re: [dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init

2017-01-27 Thread Stephen Hemminger
On Fri, 27 Jan 2017 09:56:53 -0500 Aaron Conole wrote: > + if (rte_eal_alarm_init() < 0) { > + RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n"); > + /* rte_eal_alarm_init sets rte_errno on failure. */ > + errno = rte_errno; Hmm. DPDK in genera

Re: [dpdk-dev] [PATCH 14/25] eal: do not panic on tailq init

2017-01-27 Thread Stephen Hemminger
On Fri, 27 Jan 2017 09:56:52 -0500 Aaron Conole wrote: > + /* no need to TAILQ_REMOVE, we are going to disallow > re-attemtps > + * for rte_eal_init(). */ Please put multi-line comments in form: /* * this is a long comment

Re: [dpdk-dev] [PATCH 07/25] eal: Signal error when CPU isn't supported

2017-01-27 Thread Stephen Hemminger
On Fri, 27 Jan 2017 09:56:45 -0500 Aaron Conole wrote: > It's now possible to gracefully exit the application, or for > applications which support non-dpdk datapaths working in concert with > DPDK datapaths, there no longer is the possibility of exiting for > unsupported CPUs. > > Signed-off-by:

Re: [dpdk-dev] [PATCH] doc: fix incomplete crypto dev matrices

2017-01-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, January 18, 2017 5:36 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] doc: fix incomplete crypto dev matrices > > When ZUC PMD was added, it was not added in the > Crypto Device Supported Functiona

Re: [dpdk-dev] [PATCH] mk: fix build of assembly files for ARM64

2017-01-27 Thread Thomas Monjalon
2017-01-18 12:31, Zbigniew Bodek: > > On 17.01.2017 23:45, Thomas Monjalon wrote: > > 2017-01-17 15:35, zbigniew.bo...@caviumnetworks.com: > >> -# for now, we don't use as but nasm. > >> -# AS = $(CROSS)as > > > > It looks to be a very very old comment. > > > >> +ifeq ($(CONFIG_RTE_ARCH_X86),

Re: [dpdk-dev] [PATCH] doc: update examples list for API

2017-01-27 Thread Thomas Monjalon
2017-01-27 11:55, Ferruh Yigit: > These files are linked to API documentation as usage samples, added > missing examples files and sorted list alphabetically. > > Signed-off-by: Ferruh Yigit Why not replacing this list with a "find examples -type f" in mk/rte.sdkdoc.mk?

Re: [dpdk-dev] [PATCH 00/24] linux/eal: Remove most causes of panic on init

2017-01-27 Thread Aaron Conole
Aaron Conole writes: > In many cases, it's enough to simply let the application know that the > call to initialize DPDK has failed. A complete halt can then be > decided by the application based on error returned (and the app could > even attempt a possible re-attempt after some corrective actio

[dpdk-dev] [PATCH 2/2] net/mlx5: fix validation

2017-01-27 Thread Nelio Laranjeiro
Size of the mask is wrongly computed and make the validation process only verify the first 4 bytes of the layer. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[dpdk-dev] [PATCH 1/2] net/mlx5: fix VLAN validation

2017-01-27 Thread Nelio Laranjeiro
TCI field is read from the wrong place due to an invalid cast. Moreover there is no need to limit matching to VID since PCP and DEI bits can be matched as well. Fixes: 12475fb203ad ("net/mlx5: support VLAN flow item") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 11 ---

[dpdk-dev] [PATCH 11/25] eal: Do not panic on pci-probe

2017-01-27 Thread Aaron Conole
This will usually be an issue because of permissions. However, it could also be caused by OOM. In either case, errno will contain the underlying cause. It is safe to re-init the system here, so allow the application to take corrective action and reinit. Signed-off-by: Aaron Conole --- lib/lib

[dpdk-dev] [PATCH 09/25] eal: set errno when exiting for already called

2017-01-27 Thread Aaron Conole
Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index cc1bcb5..f5f6629 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_ea

[dpdk-dev] [PATCH 01/25] eal: CPU init will no longer panic

2017-01-27 Thread Aaron Conole
After this change, the EAL CPU NUMA node resolution step can no longer emit an rte_panic. This aligns with the code in rte_eal_init, which expects failures to return an error code. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_lcore.c | 7 --- 1 file changed, 4 insertions

[dpdk-dev] [PATCH 03/25] eal: No panic on hugepages info init

2017-01-27 Thread Aaron Conole
When attempting to scan hugepages, signal to the eal.c that an error has occured, rather than performing a panic. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/

[dpdk-dev] [PATCH 25/25] rte_eal_init: add info about rte_errno codes

2017-01-27 Thread Aaron Conole
The rte_eal_init function will now pass failure reason hints to the application. To help app developers deciper this, add some brief information about what the codes are indicating. Signed-off-by: Aaron Conole --- lib/librte_eal/common/include/rte_eal.h | 24 +++- 1 file cha

[dpdk-dev] [PATCH 23/25] eal: do not panic (or abort) if vdev init fails

2017-01-27 Thread Aaron Conole
Seems like it's possible to continue. At least, the error is reflected properly in the logs. A user could then go and correct or investigate the situation. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/

[dpdk-dev] [PATCH 24/25] eal: do not panic when bus probe fails

2017-01-27 Thread Aaron Conole
Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index ecb6ac8..2783755 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librt

[dpdk-dev] [PATCH 22/25] eal_common_dev: continue initializing vdevs

2017-01-27 Thread Aaron Conole
Even if one vdev should fail, there's no need to prevent further processing. Log the error, and reflect it to the higher levels to decide. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_e

[dpdk-dev] [PATCH 20/25] eal_pci: Continue probing even on failures

2017-01-27 Thread Aaron Conole
Some devices may be inaccessible for a variety of reasons, or the PCI-bus may be unavailable causing the whole thing to fail. Still, better to continue attempts at probes. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_pci.c | 15 ++- 1 file changed, 10 insertions(

[dpdk-dev] [PATCH 21/25] eal: do not panic on failed PCI probe

2017-01-27 Thread Aaron Conole
It may even be possible to simply log the error and continue on letting the user check the logs and restart the application when things are failed. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/lib

[dpdk-dev] [PATCH 19/25] eal: do not error if plugins fail to init

2017-01-27 Thread Aaron Conole
Plugins are useful and important. However, it seems crazy to abort everything just because they don't initialize properly. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c

[dpdk-dev] [PATCH 18/25] eal: Do not panic on interrupt thread init

2017-01-27 Thread Aaron Conole
When initializing the interrupt thread, there are a number of possible reasons for failure - some of which are correctable by the application. Do not panic() needlessly, and give the application a change to reflect this information to the user. Signed-off-by: Aaron Conole --- lib/librte_eal/linu

[dpdk-dev] [PATCH 17/25] eal: change the private pipe call to reflect errno

2017-01-27 Thread Aaron Conole
There could be some confusion as to why the call failed - this change will always reflect the value of the error in rte_error. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linux

[dpdk-dev] [PATCH 16/25] eal: convert timer_init not to call panic

2017-01-27 Thread Aaron Conole
After code inspection, there is no way for eal_timer_init() to fail. It simply returns 0 in all cases. As such, this test could either go-away or stay here as 'future-proofing'. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 de

[dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init

2017-01-27 Thread Aaron Conole
rte_eal_alarm_init() call uses the linux timerfd framework to create a poll()-able timer using standard posix file operations. This could fail for a few reasons given in the man-pages, but many could be corrected by the user application. No need to panic. Signed-off-by: Aaron Conole --- lib/li

[dpdk-dev] [PATCH 14/25] eal: do not panic on tailq init

2017-01-27 Thread Aaron Conole
There are some theoretical racy conditions in the system that _could_ cause early tailq init to fail; however, no need to panic the application. While it can't continue using DPDK, it could make better alerts to the user. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_tailqs.

[dpdk-dev] [PATCH 10/25] eal: Do not panic on log failures

2017-01-27 Thread Aaron Conole
When log initialization fails, it's generally because the fopencookie failed. While this is rare in practice, it could happen, and it is likely because of memory pressure. So, flag the error, and allow the user to retry. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 8 +++

[dpdk-dev] [PATCH 13/25] eal: do not panic on memory init

2017-01-27 Thread Aaron Conole
This can only happen when access to hugepages (either as primary or secondary process) fails (and that is usually permissions). Since the manner of failure is not reversible, we cannot allow retry. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5

[dpdk-dev] [PATCH 12/25] eal: do not panic on vfio failure

2017-01-27 Thread Aaron Conole
Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index bea9a23..cfeefad 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/libr

[dpdk-dev] [PATCH 07/25] eal: Signal error when CPU isn't supported

2017-01-27 Thread Aaron Conole
It's now possible to gracefully exit the application, or for applications which support non-dpdk datapaths working in concert with DPDK datapaths, there no longer is the possibility of exiting for unsupported CPUs. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 5 - 1 fi

[dpdk-dev] [PATCH 08/25] eal: do not panic on memzone initialization fails

2017-01-27 Thread Aaron Conole
When memzone initialization fails, report the error to the calling application rather than panic(). Without a good way of detaching / releasing hugepages, at this point the application will have to restart. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file ch

[dpdk-dev] [PATCH 06/25] eal-common: introduce a way to query cpu support

2017-01-27 Thread Aaron Conole
This adds a new API to check for the eal cpu versions. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_cpuflags.c | 13 +++-- lib/librte_eal/common/include/generic/rte_cpuflags.h | 9 + 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH 05/25] eal: failure to parse args returns error

2017-01-27 Thread Aaron Conole
It's possible that the application could take a corrective action here, and either prompt the user for different arguments, or at least perform a better logging. Exiting this early prevents any useful information gathering from the application layer. Signed-off-by: Aaron Conole --- lib/librte_e

[dpdk-dev] [PATCH 02/25] eal: return error instead of panic for cpu init

2017-01-27 Thread Aaron Conole
There may be no way to gracefully recover, but the application should be notified that a failure happened, rather than completely aborting. This allows the user to proceed with a "slow-path" type solution. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file cha

[dpdk-dev] [PATCH 00/24] linux/eal: Remove most causes of panic on init

2017-01-27 Thread Aaron Conole
In many cases, it's enough to simply let the application know that the call to initialize DPDK has failed. A complete halt can then be decided by the application based on error returned (and the app could even attempt a possible re-attempt after some corrective action by the user or application).

[dpdk-dev] [PATCH 04/25] eal: do not panic on failed hugepage query

2017-01-27 Thread Aaron Conole
If we fail to acquire hugepage information, simply signal an error to the application. This clears the run_once counter, allowing the user or application to take a corrective action and retry. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 8 ++-- 1 file changed, 6 inse

[dpdk-dev] [PATCH v2] app/testpmd: fix memory leak

2017-01-27 Thread Pablo de Lara
Free memory when port flow entry creation fails. Coverity issue: 139600 Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") Signed-off-by: Pablo de Lara --- Changes in v2: - Removed unnecessary conditional app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [dpdk-dev] [PATCH] efd: fix compilation by removing dep to libmath

2017-01-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, January 27, 2017 2:23 PM > To: dev@dpdk.org; Marohn, Byron; De Lara Guarch, Pablo > Subject: [PATCH] efd: fix compilation by removing dep to libmath > > When we compile the dpdk with: > CONFIG_RTE

[dpdk-dev] [PATCH] efd: fix compilation by removing dep to libmath

2017-01-27 Thread Olivier Matz
When we compile the dpdk with: CONFIG_RTE_LIBRTE_EFD=y CONFIG_RTE_LIBRTE_NFP_PMD=n CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=n CONFIG_RTE_LIBRTE_SCHED=n CONFIG_RTE_LIBRTE_METER=n The linker gives the following error: lib/librte_efd.a(rte_efd.o): In function `rte_efd_create': lib/librte_ef

Re: [dpdk-dev] [PATCH] net/i40e: fix API comments for doxygen

2017-01-27 Thread Ferruh Yigit
On 1/27/2017 12:27 PM, Ferruh Yigit wrote: > Fixes: a541407fe4bc ("net/i40e: set VF MAC anti-spoofing from PF") > Fixes: 4cbc41efcbb2 ("net/i40e: set VF VLAN anti-spoofing from PF") > Fixes: c0ec14757c5f ("net/i40e: set VF unicast promiscuous mode from PF") > Fixes: ae57070ca8b7 ("net/i40e: set VF

Re: [dpdk-dev] [PATCH] net/ixgbe: fix API comments for doxygen

2017-01-27 Thread Ferruh Yigit
On 1/27/2017 12:27 PM, Ferruh Yigit wrote: > Fixes: 57aa1fd284d5 ("net/ixgbe: move set VF functions from the ethdev") > > Signed-off-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH v6 1/3] net/i40e: fix segmentation fault in close

2017-01-27 Thread Ferruh Yigit
On 1/27/2017 10:22 AM, Bernard Iremonger wrote: > Change the order of releasing the vsi's. > Release the vmdq vsi's first, then release the main vsi. > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > CC: sta...@dpdk.org > > Signed-off-by: Bernard Iremonger > Acked-by: Jingjing Wu

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length

2017-01-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, January 27, 2017 1:16 PM > To: adrien.mazarg...@6wind.com; Wu, Jingjing > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] crypto/aesni_mb: add missing digest length > > AESNI MB now supports authentication only

[dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length

2017-01-27 Thread Pablo de Lara
AESNI MB now supports authentication only operations, but the array containing all the possible digest lengths was not updated to reflect the new algorithm NULL_HASH, causing an "Out-of-bounds access". Coverity issue: 140977 Fixes: 8772c3f713e2 ("crypto/aesni_mb: add single operation functionality

[dpdk-dev] [PATCH] app/testpmd: fix memory leak

2017-01-27 Thread Pablo de Lara
Free memory when port flow entry creation fails. Coverity issue: 139600 Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") Signed-off-by: Pablo de Lara --- app/test-pmd/config.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/con

Re: [dpdk-dev] [PATCH] doc: update examples list for API

2017-01-27 Thread De Lara Guarch, Pablo
Hi Ferruh, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, January 27, 2017 11:56 AM > To: Mcnamara, John > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [dpdk-dev] [PATCH] doc: update examples list for API > > These files are linked t

[dpdk-dev] [PATCH] net/i40e: fix API comments for doxygen

2017-01-27 Thread Ferruh Yigit
Fixes: a541407fe4bc ("net/i40e: set VF MAC anti-spoofing from PF") Fixes: 4cbc41efcbb2 ("net/i40e: set VF VLAN anti-spoofing from PF") Fixes: c0ec14757c5f ("net/i40e: set VF unicast promiscuous mode from PF") Fixes: ae57070ca8b7 ("net/i40e: set VF multicast promiscuous mode from PF") Fixes: 83bb95e

[dpdk-dev] [PATCH] net/ixgbe: fix API comments for doxygen

2017-01-27 Thread Ferruh Yigit
Fixes: 57aa1fd284d5 ("net/ixgbe: move set VF functions from the ethdev") Signed-off-by: Ferruh Yigit --- drivers/net/ixgbe/rte_pmd_ixgbe.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h index d4ef

[dpdk-dev] [PATCH] doc: add PMD specific API

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/api/doxy-api-index.md | 4 doc/api/doxy-api.conf | 2 ++ 2 files changed, 6 insertions(+) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index f9958c4..525d2e1 100644 --- a/doc/api/doxy-api-index.md +++ b/doc/api/doxy-api-index.md

[dpdk-dev] [PATCH] doc: update examples list for API

2017-01-27 Thread Ferruh Yigit
These files are linked to API documentation as usage samples, added missing examples files and sorted list alphabetically. Signed-off-by: Ferruh Yigit --- doc/api/examples.dox | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/doc/api/examples.dox b/doc/

Re: [dpdk-dev] [PATCH] net/enic: fix MAC address add and remove

2017-01-27 Thread Ferruh Yigit
On 1/26/2017 8:12 PM, John Daley wrote: > The mac_addr_add callback function was simply replacing the primary MAC > address instead of adding new ones and the mac_addr_remove callback would > only remove the primary MAC form the adapter. Fix the functions to add or > remove new address. Allow up to

Re: [dpdk-dev] [PATCH] drivers/net: make PCI device id struct const

2017-01-27 Thread Ferruh Yigit
On 1/27/2017 7:10 AM, Shreyansh Jain wrote: > On Thursday 26 January 2017 07:37 PM, Ferruh Yigit wrote: >> Signed-off-by: Ferruh Yigit >> --- >> drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++-- >> drivers/net/bnxt/bnxt_ethdev.c | 2 +- >> drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- >> drivers/net/ena/en

Re: [dpdk-dev] Understanding of Acked-By

2017-01-27 Thread Ferruh Yigit
On 1/27/2017 10:32 AM, Mcnamara, John wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shreyansh Jain >> Sent: Friday, January 27, 2017 10:25 AM >> To: Richardson, Bruce >> Cc: Thomas Monjalon ; Van Haaren, Harry >> ; dev@dpdk.org; Yigit, Ferruh >>

[dpdk-dev] [PATCH v6 0/2] app/testpmd: enable VMDq in testpmd

2017-01-27 Thread Bernard Iremonger
Changes in v6: Rebased to latest dpdk-next-net Removed i40e patch from this patchset and sent it as a standalone patch. Fixed checkpatch warning in testpmd.c. Changes in v5: Rebase to latest dpdk-next-net Reworked init_port_vmdq_config() function in testpmd. Added patch 3, fix to stop_port() func

[dpdk-dev] [PATCH v6 1/2] app/testpmd: add command to configure VMDq

2017-01-27 Thread Bernard Iremonger
Add the following command to configure VMDq: port config vmdq Add the following command to set number of pools: set nbpool Add new commands to testpmd user guide. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 72 - app/test-pmd/config.c

[dpdk-dev] [PATCH v6 2/2] app/testpmd: fix port stop

2017-01-27 Thread Bernard Iremonger
The rte_eth_dev_stop function is not called if the port_status is not RTE_PORT_STARTED. This can happen if the rte_eth_dev_start function is called directly, ie not through the start_port function. Make sure rte_eth_dev_stop is always called in stop_port function. Fixes: ce8d561418d4 ("app/testpm

Re: [dpdk-dev] Understanding of Acked-By

2017-01-27 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shreyansh Jain > Sent: Friday, January 27, 2017 10:25 AM > To: Richardson, Bruce > Cc: Thomas Monjalon ; Van Haaren, Harry > ; dev@dpdk.org; Yigit, Ferruh > ; Igor Ryzhov ; Steve Shin > > Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH v6 1/3] net/i40e: fix segmentation fault in close

2017-01-27 Thread Bernard Iremonger
Change the order of releasing the vsi's. Release the vmdq vsi's first, then release the main vsi. Fixes: 4861cde46116 ("i40e: new poll mode driver") CC: sta...@dpdk.org Signed-off-by: Bernard Iremonger Acked-by: Jingjing Wu --- Changes in v6: Rebased to latest dpdk-next-net This was previously

Re: [dpdk-dev] Understanding of Acked-By

2017-01-27 Thread Shreyansh Jain
On Friday 27 January 2017 03:43 PM, Bruce Richardson wrote: On Fri, Jan 27, 2017 at 12:48:06PM +0530, Shreyansh Jain wrote: On Wednesday 25 January 2017 08:28 PM, Thomas Monjalon wrote: 2017-01-25 13:53, Van Haaren, Harry: There was an idea (from Thomas) to better document the Acked-by and Rev

Re: [dpdk-dev] Understanding of Acked-By

2017-01-27 Thread Bruce Richardson
On Fri, Jan 27, 2017 at 12:48:06PM +0530, Shreyansh Jain wrote: > On Wednesday 25 January 2017 08:28 PM, Thomas Monjalon wrote: > > 2017-01-25 13:53, Van Haaren, Harry: > > > There was an idea (from Thomas) to better document the Acked-by and > > > Reviewed-By in the above thread, which I think is

Re: [dpdk-dev] [PATCH v4 1/6] eventdev: introduce event driven programming model

2017-01-27 Thread Bruce Richardson
On Thu, Jan 26, 2017 at 08:39:57PM +, Eads, Gage wrote: > > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Thursday, January 26, 2017 3:39 AM > > To: Eads, Gage > > Cc: Richardson, Bruce ; 'dev@dpdk.org' > > ; 'thomas.monja...@6wi

[dpdk-dev] [PATCH] app/test: make PCI device id struct const

2017-01-27 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- app/test/test_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c index cda186d..7985376 100644 --- a/app/test/test_pci.c +++ b/app/test/test_pci.c @@ -66,12 +66,12 @@ static int my_driver_init(str

Re: [dpdk-dev] [dpdk-users] net/i40e: TX descriptor is not done

2017-01-27 Thread Muhammad Zain-ul-Abideen
Mbufs are not being freed inside the ring fast enough to accommodate the incoming traffic.

Re: [dpdk-dev] [PATCH] drivers/net: make PCI device id struct const

2017-01-27 Thread Ferruh Yigit
On 1/27/2017 7:10 AM, Shreyansh Jain wrote: > On Thursday 26 January 2017 07:37 PM, Ferruh Yigit wrote: >> Signed-off-by: Ferruh Yigit >> --- >> drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++-- >> drivers/net/bnxt/bnxt_ethdev.c | 2 +- >> drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- >> drivers/net/ena/en

Re: [dpdk-dev] [PATCH] crypto/qat: make PCI device id struct const

2017-01-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Friday, January 27, 2017 7:11 AM > To: Yigit, Ferruh > Cc: dev@dpdk.org; Thomas Monjalon; De Lara Guarch, Pablo > Subject: Re: [PATCH] crypto/qat: make PCI device id struct const > > On Thursday 26 Januar

Re: [dpdk-dev] technical board meeting minutes 2017-01-25

2017-01-27 Thread Thomas Monjalon
2017-01-26 23:14, St Leger, Jim: > It can be decided to remove a member if there is an approval of 2/3 of the > whole technical board. > It can be decided either to replace the member, or to redefine the size of > the board. > > > [>] Did you decide how the discussion or topic to remove a board