Re: [dpdk-dev] Understanding of Acked-By

2017-01-26 Thread Shreyansh Jain
On Wednesday 25 January 2017 08:28 PM, Thomas Monjalon wrote: 2017-01-25 13:53, Van Haaren, Harry: There was an idea (from Thomas) to better document the Acked-by and Reviewed-By in the above thread, which I think is worth doing to make the process clearer. I'll kick off a thread*, and offer t

Re: [dpdk-dev] [PATCH] crypto/qat: make PCI device id struct const

2017-01-26 Thread Shreyansh Jain
On Thursday 26 January 2017 07:37 PM, Ferruh Yigit wrote: Signed-off-by: Ferruh Yigit --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c index 9594067..a4

Re: [dpdk-dev] [PATCH] drivers/net: make PCI device id struct const

2017-01-26 Thread Shreyansh Jain
On Thursday 26 January 2017 07:37 PM, Ferruh Yigit wrote: Signed-off-by: Ferruh Yigit --- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++-- drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +- drivers/net/nfp/nfp_net.c| 2 +-

Re: [dpdk-dev] technical board meeting minutes 2017-01-25

2017-01-26 Thread St Leger, Jim
Comments inline below. Jim -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon Sent: Thursday, January 26, 2017 3:14 PM To: dev@dpdk.org Cc: techbo...@dpdk.org Subject: [dpdk-dev] technical board meeting minutes 2017-01-25 There was a DPDK technical boa

[dpdk-dev] [PATCH] vfio: fix file descriptor leak in multi-process applications

2017-01-26 Thread Patrick MacArthur
When a secondary process wants access to the VFIO container file descriptor, the primary process calls vfio_get_container_fd() which always opens an entirely new file descriptor on /dev/vfio/vfio. However, once the file descriptor has been passed to the subprocess, it is effectively duplicated, mea

[dpdk-dev] technical board meeting minutes 2017-01-25

2017-01-26 Thread Thomas Monjalon
There was a DPDK technical board meeting yesterday. The goal was to reply questions asked recently in the community. Most of them originate from the meetings about moving to Linux Foundation. Here are the minutes. * Should we change the size of the tech board? Yes we must increase the number of me

Re: [dpdk-dev] [PATCH v4 1/6] eventdev: introduce event driven programming model

2017-01-26 Thread Eads, Gage
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Thursday, January 26, 2017 3:39 AM > To: Eads, Gage > Cc: Richardson, Bruce ; 'dev@dpdk.org' > ; 'thomas.monja...@6wind.com' > ; 'hemant.agra...@nxp.com' > ; Van Haaren, Harry > ; McDaniel,

[dpdk-dev] [PATCH] net/enic: fix MAC address add and remove

2017-01-26 Thread John Daley
The mac_addr_add callback function was simply replacing the primary MAC address instead of adding new ones and the mac_addr_remove callback would only remove the primary MAC form the adapter. Fix the functions to add or remove new address. Allow up to 64 MAC addresses per port. Fixes: fefed3d1e62c

Re: [dpdk-dev] [PATCHv6 00/33] NXP DPAA2 PMD

2017-01-26 Thread Thomas Monjalon
2017-01-26 17:48, Hemant Agrawal: > On 1/26/2017 5:25 PM, Ferruh Yigit wrote: > > On 1/23/2017 5:56 PM, Ferruh Yigit wrote: > >> I have some concerns about this PMD, > >> > >> - This is a big one, as seen above, and it is hard to review it all, I > >> don't feel confident about the amount of review

Re: [dpdk-dev] [PATCH v4 4/4] doc: describe new performance test application

2017-01-26 Thread Thomas Monjalon
2017-01-26 15:21, Ferruh Yigit: > Congratulations!, > > this is the 2. patch in patchwork: > http://dpdk.org/dev/patchwork/patch/2/ > > There should be a price for the author of the each 10K. patch ;) > > 20.000 patches!!, good work community. > (Assuming numbering started from 1 :) ) P

Re: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags

2017-01-26 Thread Ananyev, Konstantin
> -Original Message- > From: Olivier MATZ [mailto:olivier.m...@6wind.com] > Sent: Thursday, January 26, 2017 3:58 PM > To: Ananyev, Konstantin > Cc: Olivier MATZ ; Wu, Jingjing > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags > > On Thu, 26 J

Re: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags

2017-01-26 Thread Olivier MATZ
On Thu, 26 Jan 2017 15:35:29 +, "Ananyev, Konstantin" wrote: > Hi Olivier, > > > -Original Message- > > From: Olivier MATZ [mailto:olivier.m...@6wind.com] > > Sent: Thursday, January 26, 2017 3:05 PM > > To: Ananyev, Konstantin > > Cc: Wu, Jingjing ; dev@dpdk.org > > Subject: Re: [dp

Re: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags

2017-01-26 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.m...@6wind.com] > Sent: Thursday, January 26, 2017 3:05 PM > To: Ananyev, Konstantin > Cc: Wu, Jingjing ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags > > On Thu, 26 Jan 2017

Re: [dpdk-dev] [PATCH v4 4/4] doc: describe new performance test application

2017-01-26 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, January 26, 2017 3:21 PM > To: Mrozowicz, SlawomirX ; dev@dpdk.org > Cc: Azarewicz, PiotrX T ; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PATCH v4 4/4] doc: describe new performan

Re: [dpdk-dev] [PATCH v4 4/4] doc: describe new performance test application

2017-01-26 Thread Ferruh Yigit
On 1/25/2017 4:27 PM, Slawomir Mrozowicz wrote: > Add documentation to describe using the new performance test application. > > Signed-off-by: Slawomir Mrozowicz > Signed-off-by: Piotr Azarewicz Congratulations!, this is the 2. patch in patchwork: http://dpdk.org/dev/patchwork/patch/2/

Re: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags

2017-01-26 Thread Olivier MATZ
On Thu, 26 Jan 2017 14:58:08 +, "Ananyev, Konstantin" wrote: > Hi Jingjng, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jingjing Wu > > Sent: Tuesday, January 24, 2017 11:48 AM > > To: dev@dpdk.org > > Cc: Wu, Jingjing > > Subject: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags

2017-01-26 Thread Ananyev, Konstantin
Hi Jingjng, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jingjing Wu > Sent: Tuesday, January 24, 2017 11:48 AM > To: dev@dpdk.org > Cc: Wu, Jingjing > Subject: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags > > Some Tx offload flags are misse

Re: [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags

2017-01-26 Thread Ferruh Yigit
On 1/24/2017 11:50 AM, Jingjing Wu wrote: > Some Tx offload flags are missed in bitmask of all supported packet > Tx offload features flags. > This patch fixes it. > > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") > Signed-off-by: Jingjing Wu Cc: Olivier MATZ <...>

[dpdk-dev] [PATCH] devtools: add git log checks for nvm, tso, Vlan

2017-01-26 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- devtools/check-git-log.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index 62b5f43..52b8659 100755 --- a/devtools/check-git-log.sh +++ b/devtools/check-git-log.sh @@ -128,13 +128,15 @

[dpdk-dev] [PATCH] crypto/qat: make PCI device id struct const

2017-01-26 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c index 9594067..a492dc0 100644 --- a/drivers/crypto/qat/rte_qat_cryptodev.c ++

[dpdk-dev] [PATCH] drivers/net: make PCI device id struct const

2017-01-26 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++-- drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +- drivers/net/nfp/nfp_net.c| 2 +- drivers/net/qede/qede_ethdev.c | 4 ++-- 6 files changed

[dpdk-dev] [PATCH] devtools: update headline prefix for drivers

2017-01-26 Thread Ferruh Yigit
For the patches that touch multiple drivers in same driver group, script forces headline prefix start with drv group. Like for net/a net/b net/c, patch title should be "net: x y z" Update rule to let "driver" prefix in headline, for above sample patch title becomes: "drivers/net: x y z" This pre

Re: [dpdk-dev] [PATCHv6 00/33] NXP DPAA2 PMD

2017-01-26 Thread Hemant Agrawal
On 1/26/2017 5:25 PM, Ferruh Yigit wrote: On 1/23/2017 5:56 PM, Ferruh Yigit wrote: On 1/23/2017 11:59 AM, Hemant Agrawal wrote: <...> Hemant Agrawal (33): mk/dpaa2: add the crc support to the machine type drivers/common/dpaa2: adding qbman driver bus/fslmc: introducing fsl-mc bus drive

Re: [dpdk-dev] [PATCHv6 16/33] drivers/pool/dpaa2: adding hw offloaded mempool

2017-01-26 Thread Shreyansh Jain
Hello Neil, > -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Wednesday, January 25, 2017 8:37 PM > To: Shreyansh Jain > Cc: Thomas Monjalon ; Hemant Agrawal > ; Ferruh Yigit ; > dev@dpdk.org; bruce.richard...@intel.com; john.mcnam...@intel.com; > jerin.ja...

Re: [dpdk-dev] [PATCHv6 00/33] NXP DPAA2 PMD

2017-01-26 Thread Ferruh Yigit
On 1/23/2017 5:56 PM, Ferruh Yigit wrote: > On 1/23/2017 11:59 AM, Hemant Agrawal wrote: > <...> > >> >> Hemant Agrawal (33): >> mk/dpaa2: add the crc support to the machine type >> drivers/common/dpaa2: adding qbman driver >> bus/fslmc: introducing fsl-mc bus driver >> bus/fslmc: introduc

Re: [dpdk-dev] [PATCH] net/bonding: remove useless assignment

2017-01-26 Thread Ferruh Yigit
On 1/25/2017 12:11 PM, Ferruh Yigit wrote: > On 1/24/2017 9:15 PM, Emmanuel Roullit wrote: >> Found with clang static analysis: >> drivers/net/bonding/rte_eth_bond_pmd.c:903:3: >> warning: Value stored to 'num_not_send' is never read >> num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - nu

Re: [dpdk-dev] [PATCH 1/3] net/cxgbe: init data value before reading seeprom

2017-01-26 Thread Ferruh Yigit
On 1/25/2017 12:12 PM, Ferruh Yigit wrote: > On 1/24/2017 8:48 PM, Emmanuel Roullit wrote: >> data value could have been garbage if VPD access timed out for VPD read >> request could not been issued. >> >> Found with clang static analysis: >> drivers/net/cxgbe/base/t4_hw.c:1577:22: >> warning: The

Re: [dpdk-dev] [PATCH 2/3] net/cxgbe: remove unused variable usage

2017-01-26 Thread Ferruh Yigit
On 1/26/2017 4:41 AM, Rahul Lakkireddy wrote: > On Wednesday, January 01/25/17, 2017 at 17:43:57 +0530, Ferruh Yigit wrote: >> On 1/24/2017 8:48 PM, Emmanuel Roullit wrote: >>> Found with clang static analysis: >>> drivers/net/cxgbe/sge.c:900:3: warning: >>> Value stored to 'in_use' is never read >

Re: [dpdk-dev] [PATCH v4 0/4] Introduce new performance test application

2017-01-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, January 25, 2017 3:59 PM > To: Mrozowicz, SlawomirX; dev@dpdk.org > Cc: Mrozowicz, SlawomirX > Subject: Re: [dpdk-dev] [PATCH v4 0/4] Introduce new performance test > app

Re: [dpdk-dev] [PATCH v4 1/6] eventdev: introduce event driven programming model

2017-01-26 Thread Jerin Jacob
On Wed, Jan 25, 2017 at 10:36:21PM +, Eads, Gage wrote: > > > > > Subject: [dpdk-dev] [PATCH v4 > > > 1/6] eventdev: introduce event driven > > programming model > > > > > > > +/** > > + * Enqueue a burst > > > of events objects or an event object supplied > > in > > > > > *rte