On Wed, Jan 25, 2017 at 01:13:32PM +0800, Lu, Wenzhuo wrote:
> Hi Tiwei,
>
> > -Original Message-
> > From: Bie, Tiwei
> > Sent: Wednesday, January 25, 2017 11:17 AM
> > To: Lu, Wenzhuo
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get
> >
>
Hi Tiwei,
> -Original Message-
> From: Bie, Tiwei
> Sent: Wednesday, January 25, 2017 11:17 AM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get
>
> On Wed, Jan 25, 2017 at 10:39:22AM +0800, Wenzhuo Lu wrote:
> > It'not appropr
On Wed, 25 Jan 2017 10:18:01 +0530
Shreyansh Jain wrote:
> On Wednesday 18 January 2017 02:46 PM, Hemant Agrawal wrote:
> > This makes struct rte_cryptodev independent of struct rte_pci_device by
> > replacing it with a pointer to the generic struct rte_device.
> >
> > This is inline with the rec
On Wednesday 18 January 2017 02:46 PM, Hemant Agrawal wrote:
This makes struct rte_cryptodev independent of struct rte_pci_device by
replacing it with a pointer to the generic struct rte_device.
This is inline with the recent changes in ethdev
Signed-off-by: Hemant Agrawal
---
drivers/crypto/
On 1/24/2017 4:55 PM, Ferruh Yigit wrote:
On 1/23/2017 5:58 PM, Ferruh Yigit wrote:
On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
<...>
Hemant Agrawal (33):
mk/dpaa2: add the crc support to the machine type
drivers/common/dpaa2: adding qbman driver
bus/fslmc: introducing fsl-mc bus drive
> On Jan 24, 2017, at 2:04 PM, Stephen Hemminger
> wrote:
>
> On Tue, 24 Jan 2017 20:09:07 +
> "Wiles, Keith" wrote:
>
>>> On Jan 24, 2017, at 12:45 PM, Ananyev, Konstantin
>>> wrote:
>>>
>>>
>>>
-Original Message-
From: Wiles, Keith
Sent: Tuesday, January 24,
On Wed, Jan 25, 2017 at 10:39:22AM +0800, Wenzhuo Lu wrote:
> It'not appropriate to call rte_eth_dev_info_get in PMD,
> as rte_eth_dev_info_get need to get info from PMD.
> Remove rte_eth_dev_info_get from PMD code and get the
> info directly.
>
> Signed-off-by: Wenzhuo Lu
> ---
> drivers/net/ix
It'not appropriate to call rte_eth_dev_info_get in PMD,
as rte_eth_dev_info_get need to get info from PMD.
Remove rte_eth_dev_info_get from PMD code and get the
info directly.
Signed-off-by: Wenzhuo Lu
---
drivers/net/ixgbe/ixgbe_ethdev.c | 144 ++-
1 file cha
When no error reported in Rx descriptor, we should set
CKSUM_GOOD flag before return.
Fixes: 9966a00a0688 ("net/i40e: enable bad checksum flags in vector Rx")
Signed-off-by: Qi Zhang
---
v2:
- remove debug code
drivers/net/i40e/i40e_rxtx_vec_sse.c | 37
1 f
Please ignore this, I forgot to remove the debug line.
> -Original Message-
> From: Zhang, Qi Z
> Sent: Wednesday, January 25, 2017 2:49 AM
> To: Wu, Jingjing ; Zhang, Helin
>
> Cc: dev@dpdk.org; Zhang, Qi Z
> Subject: [PATCH] net/i40e: fix x86 vPMD Rx checksum flag
>
> When no error r
When no error reported in Rx descriptor, we should set
CKSUM_GOOD flag before return.
Fixes: 9966a00a0688 ("net/i40e: enable bad checksum flags in vector Rx")
Signed-off-by: Qi Zhang
---
drivers/net/i40e/i40e_rxtx_vec_sse.c | 38
1 file changed, 30 insertion
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dai, Wei
> Sent: Wednesday, January 25, 2017 9:40 AM
> To: Yuanhan Liu ; Yi Zhang
>
> Cc: Zhang, Helin ; Ananyev, Konstantin
> ; dev@dpdk.org; Lu, Wenzhuo
>
> Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe:fix max p
I think your patch does fix an error in ixgbevf and I can acknowledge it after
I have checked with 82599 and x540 and x550 datasheet.
In 82599 datasheet, there is an annotation in the chapter 1.3 Features Summary
(page 29)
The 82599 supports full-size 15.5 KB (15872-byte) jumbo packets while in
Hi Yi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yi Zhang
> Sent: Thursday, December 15, 2016 2:50 AM
> To: maintai...@some.org
> Cc: dev@dpdk.org; Yi Zhang
> Subject: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf
>
> Current ixgbevf
> -Original Message-
> From: Emmanuel Roullit [mailto:emmanuel.roul...@gmail.com]
> Sent: Tuesday, January 24, 2017 8:39 PM
> To: Dumitrescu, Cristian
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH] rte_table: ensure prev bucket has a valid pointer
>
> Fixes: 43f15e28377f ("table
Found with clang static analysis:
drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
warning: Value stored to 'num_not_send' is never read
num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
^
Fixes: 73db5badb042 ("net
On Tue, 24 Jan 2017 20:09:07 +
"Wiles, Keith" wrote:
> > On Jan 24, 2017, at 12:45 PM, Ananyev, Konstantin
> > wrote:
> >
> >
> >
> >> -Original Message-
> >> From: Wiles, Keith
> >> Sent: Tuesday, January 24, 2017 2:49 PM
> >> To: Ananyev, Konstantin
> >> Cc: Stephen Hemminge
Found with clang build:
error: taking address of packed member 'mlock' of class or structure
'rte_mem_config' may result in an unaligned pointer value
[-Werror,-Waddress-of-packed-member]
Fixes: 29361d4c91ed ("mk: fix build with clang < 3.5")
Fixes: b2bb3a5daaac ("mk: stop on warning only in devel
data value could have been garbage if VPD access timed out for VPD read
request could not been issued.
Found with clang static analysis:
drivers/net/cxgbe/base/t4_hw.c:1577:22:
warning: The left operand of '&' is a garbage value
} while ((stats_reg & 0x1) && --max_poll);
Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API")
Signed-off-by: Emmanuel Roullit
---
drivers/net/cxgbe/sge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
index 42051ca01..37b609040 100644
--- a/driver
Found with clang static analysis:
drivers/net/cxgbe/sge.c:900:3: warning:
Value stored to 'in_use' is never read
in_use += q->size;
^ ~~~
Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API")
Signed-off-by: Emmanuel Roullit
---
drivers/net/cxgbe/sge
Found with clang static analysis:
drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
warning: Value stored to 'num_not_send' is never read
num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
^
ixes: 73db5badb042 ("net:
Fixes: 43f15e28377f ("table: fix verification on hash bucket header alignment")
Signed-off-by: Emmanuel Roullit
---
lib/librte_table/rte_table_hash_key16.c | 7 +--
lib/librte_table/rte_table_hash_key32.c | 7 +--
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/lib/librte
Found with clang static analysis:
lib/librte_vhost/virtio_net.c:723:17: warning:
Access to field 'data_off' results in a dereference of a null pointer
(loaded from variable 'tcp_hdr')
m->l4_len = (tcp_hdr->data_off & 0xf0) >> 2;
^
Fixes: 2a51b1091cb5 ("
Found with clang static analysis:
lib/librte_vhost/vhost_user.c:996:3: warning:
Value stored to 'ret' is never read
ret = vhost_user_get_vring_base(dev, &msg.payload.state);
^ ~~
Fixes: 73c8f9f69c6c ("vhost: introduce reply ack fe
Found with clang static analysis:
lib/librte_ether/rte_ethdev.c:2467:22:
warning: Value stored to 'dev' during its initialization is never read
struct rte_eth_dev *dev = &rte_eth_devices[port_id];
^~~ ~
Fixes: 61207d014fc9 ("ethdev: fix data reset when
The pointer set by strdup() needs to be cleared on failure to avoid a
potential double-free from the caller.
Found with clang static analysis:
lib/librte_eal/common/eal_common_devargs.c:123:2:
warning: Attempt to free released memory
free(buf);
^
Fixes: 3fe2e5fec82b ("eal:
Found with clang static analysis:
lib/librte_eal/linuxapp/eal/eal_memory.c:1004:11:
warning: Call to 'malloc' has an allocation size of 0 bytes
tmp_hp = malloc(nr_hugepages * sizeof(struct hugepage_file));
^~~
The --no-huge case, where nr_hu
> On Jan 24, 2017, at 12:45 PM, Ananyev, Konstantin
> wrote:
>
>
>
>> -Original Message-
>> From: Wiles, Keith
>> Sent: Tuesday, January 24, 2017 2:49 PM
>> To: Ananyev, Konstantin
>> Cc: Stephen Hemminger ; Hu, Jiayu
>> ; dev@dpdk.org; Kinsella, Ray
>> ; Gilmore, Walter E ;
>> Ven
> -Original Message-
> From: Wiles, Keith
> Sent: Tuesday, January 24, 2017 2:49 PM
> To: Ananyev, Konstantin
> Cc: Stephen Hemminger ; Hu, Jiayu
> ; dev@dpdk.org; Kinsella, Ray
> ; Gilmore, Walter E ;
> Venkatesan, Venky ;
> yuanhan@linux.intel.com
> Subject: Re: [dpdk-dev] [RFC]
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal
> Sent: Wednesday, January 18, 2017 9:16 AM
> To: dev@dpdk.org
> Cc: thomas.monja...@6wind.com; Doherty, Declan
> ; shreyansh.j...@nxp.com; De Lara Guarch,
> Pablo ; jblu...@infradead.org
> Subject:
2017-01-24 20:07, Hemant Agrawal:
> On 1/24/2017 4:19 PM, Ferruh Yigit wrote:
> > On 1/24/2017 9:12 AM, Shreyansh Jain wrote:
> >> On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote:
> >>> On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
> +# library dependencies
> +DEPDIRS-$(CONFIG_RTE_L
2017-01-24 16:46, Fan Zhang:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -444,6 +444,11 @@ M: Deepak Kumar Jain
> F: drivers/crypto/qat/
> F: doc/guides/cryptodevs/qat.rst
>
> +SCHEDULER PMD
> +M: Fan Zhang
> +F: drivers/crypto/scheduler/
> +F: doc/guides/cryptodevs/scheduler.rst
I think th
On 1/24/2017 2:22 PM, Jakub Palider wrote:
> While ENA can handle checksum calculations in almost all cases,
> it cannot do so when DF bit in IPv4 header is not set,
> that is DF=0, and TSO is requested. For that situation pseudo
> header must be prepared manually.
>
> Signed-off-by: Jakub Palider
2017-01-24 14:39, Shreyansh Jain:
> You might have noticed that we have exposed a lot of symbols from
> drivers/common and drivers/bus for drivers/net and drivers/crypto. All these
> symbols are not rte_* as what has been suggested for exported symbols.
>
> Review comments have been received for
> -Original Message-
> From: Zhang, Roy Fan
> Sent: Tuesday, January 24, 2017 4:47 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH] maintainers: add crypto scheduler PMD maintainer
>
> Signed-off-by: Fan Zhang
Acked-by: Pablo de Lara
Signed-off-by: Fan Zhang
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f071138..098f341 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -444,6 +444,11 @@ M: Deepak Kumar Jain
F: drivers/crypto/qat/
F: doc/guides/cryptodevs/qat.rst
+SCH
On 1/24/2017 2:37 PM, Hemant Agrawal wrote:
> On 1/24/2017 4:19 PM, Ferruh Yigit wrote:
>> On 1/24/2017 9:12 AM, Shreyansh Jain wrote:
>>> On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote:
On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
> Adding NXP DPAA2 architecture specific mempool s
On 1/24/2017 2:39 PM, Shreyansh Jain wrote:
> Hello,
>
> We are facing a peculiar problem with respect to symbol namespace in DPDK. I
> think Ferruh and Thomas would have fair idea about it as they have already
> reviewed and commented on it. I was hoping to get some input to take it
> forward fro
> -Original Message-
> From: Zhang, Roy Fan
> Sent: Tuesday, January 24, 2017 4:24 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan; De Lara Guarch, Pablo
> Subject: [PATCH v7 00/11] crypto/scheduler: add driver for scheduler
> crypto pmd
>
...
>
> Fan Zhang (11):
Series-acked-by: Pablo de
On 1/24/2017 4:05 PM, Matej Vido wrote:
> On 24.01.2017 16:24, Ferruh Yigit wrote:
>> On 1/24/2017 10:49 AM, Matej Vido wrote:
>>> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
>>>
>>> Signed-off-by: Matej Vido
>> Reviewed-by: Ferruh Yigit
>>
>> Cc: sta...@dpdk.org
>>
>
Same as other cryptodev PMDs, it is necessary to carry out the unit
test for scheduler PMD. Currently the test is designed to attach 2
AESNI-MB cryptodev PMDs as slaves, sets the scheduling mode as round-
robin, and runs almost all AESNI-MB test items (except for sessionless
tests). In the end, the
Adds scheduler PMD enable and debug flags to config/common_base.
Signed-off-by: Fan Zhang
---
config/common_base | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/config/common_base b/config/common_base
index b9fb8e2..cd4a0f3 100644
--- a/config/common_base
+++ b/config/
Adds the description of the cryptodev scheduler PMD overview,
limitations, build, instructions, modes, etc.
Signed-off-by: Fan Zhang
---
doc/guides/cryptodevs/img/scheduler-overview.svg | 277 +++
doc/guides/cryptodevs/index.rst | 3 +-
doc/guides/cryptodev
Adds Makefile for scheduler cryptodev PMD, and updates existing
Makefiles. Different than other cryptodev PMDs, scheduler PMD
is required to be built as shared libraries.
Signed-off-by: Fan Zhang
---
drivers/crypto/Makefile | 3 +-
drivers/crypto/scheduler/Makefile | 66 ++
Implements all standard operations required for cryptodev,
and register them to cryptodev operation function pointer table.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/scheduler_pmd_ops.c | 490 +++
1 file changed, 490 insertions(+)
create mode 100644 drivers/c
Adds crypto scheduler's PMD's probe and remove function and the device's
enqueue and dequeue burst functions. A cryptodev scheduler PMD is
then registered in the end.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/scheduler_pmd.c | 361 +++
1 file changed, 361
Adds APIs and function prototypes for the scheduler PMD to perform extra
operations other than standard cryptodev APIs.
Signed-off-by: Fan Zhang
Signed-off-by: Declan Doherty
---
drivers/crypto/scheduler/rte_cryptodev_scheduler.h | 162 +
.../scheduler/rte_cryptodev_schedule
Implements round-robin scheduling mode and register into cryptodev
scheduler ops structure. This mode enqueues a burst of operation
to one of its slaves, and iterates the next burst to the other
slave. Same procedure is done on dequeueing operations.
Signed-off-by: Fan Zhang
Signed-off-by: Declan
Adds the implementations of the APIs for scheduler cryptodev PMD.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 464 +
1 file changed, 464 insertions(+)
create mode 100644 drivers/crypto/scheduler/rte_cryptodev_scheduler.c
diff --git a/dr
Adds a number of internal structures for the cryptodev scheduler PMD. The
structures include the scheduler context, slave, queue pair context,
and session.
Signed-off-by: Fan Zhang
Signed-off-by: Declan Doherty
---
drivers/crypto/scheduler/scheduler_pmd_private.h | 115 +++
This patch adds the cryptodev scheduler PMD name and type identifier to
librte_cryptodev.
Signed-off-by: Fan Zhang
---
lib/librte_cryptodev/rte_cryptodev.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h
b/lib/librte_cryptodev/rte_cryptodev.h
index f2
This patch provides the initial implementation of the scheduler poll mode
driver using DPDK cryptodev framework.
Scheduler PMD is used to schedule and enqueue the crypto ops to the
hardware and/or software crypto devices attached to it (slaves). The
dequeue operation from the slave(s), and the pos
The log "Debug logs available - lower performance" should
now only be displayed when dataplane debug logs are enabled.
The issue occurs only if the default log level (CONFIG_RTE_LOG_LEVEL) is
set to DEBUG in the configuration, which is not the case by default.
Fixes: 5d8f0baf69ea ("log: do not dr
On Tue, 24 Jan 2017 19:57:13 +0400, Ilya Matveychikov
wrote:
> > On Jan 24, 2017, at 4:56 PM, Olivier MATZ
> > wrote:
> >
> > Hi,
> >
> > On Sat, 21 Jan 2017 16:28:29 +, "Ananyev, Konstantin"
> > wrote:
> >>> -Original Message-
> >>> From: dev [mailto:dev-boun...@dpdk.org] On Beh
On Tue, 24 Jan 2017 15:59:08 +, Bruce Richardson
wrote:
> On Tue, Jan 24, 2017 at 04:19:25PM +0100, Olivier Matz wrote:
> > Based on discussion done in [1], this patchset reorganizes the mbuf.
> >
>
> Hi Olivier,
>
> thanks for all the work on this. From a quick scan of the patches, and
>
On 1/24/2017 3:55 PM, Matej Vido wrote:
> On 24.01.2017 16:11, Ferruh Yigit wrote:
>> On 1/24/2017 2:02 PM, Matej Vido wrote:
>>> On 24.01.2017 12:58, Ferruh Yigit wrote:
On 1/24/2017 10:49 AM, Matej Vido wrote:
> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
>>>
Adds the description of the cryptodev scheduler PMD overview,
limitations, build, instructions, modes, etc.
Signed-off-by: Fan Zhang
---
doc/guides/cryptodevs/img/scheduler-overview.svg | 277 +++
doc/guides/cryptodevs/index.rst | 3 +-
doc/guides/cryptodev
Adds scheduler PMD enable and debug flags to config/common_base.
Signed-off-by: Fan Zhang
---
config/common_base | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/config/common_base b/config/common_base
index b9fb8e2..cd4a0f3 100644
--- a/config/common_base
+++ b/config/
Same as other cryptodev PMDs, it is necessary to carry out the unit
test for scheduler PMD. Currently the test is designed to attach 2
AESNI-MB cryptodev PMDs as slaves, sets the scheduling mode as round-
robin, and runs almost all AESNI-MB test items (except for sessionless
tests). In the end, the
Adds Makefile for scheduler cryptodev PMD, and updates existing
Makefiles. Different than other cryptodev PMDs, scheduler PMD
is required to be built as shared libraries.
Signed-off-by: Fan Zhang
---
drivers/crypto/Makefile | 3 +-
drivers/crypto/scheduler/Makefile | 66 ++
Adds crypto scheduler's PMD's probe and remove function and the device's
enqueue and dequeue burst functions. A cryptodev scheduler PMD is
then registered in the end.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/scheduler_pmd.c | 361 +++
1 file changed, 361
Implements all standard operations required for cryptodev,
and register them to cryptodev operation function pointer table.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/scheduler_pmd_ops.c | 490 +++
1 file changed, 490 insertions(+)
create mode 100644 drivers/c
Adds the implementations of the APIs for scheduler cryptodev PMD.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 464 +
1 file changed, 464 insertions(+)
create mode 100644 drivers/crypto/scheduler/rte_cryptodev_scheduler.c
diff --git a/dr
Implements round-robin scheduling mode and register into cryptodev
scheduler ops structure. This mode enqueues a burst of operation
to one of its slaves, and iterates the next burst to the other
slave. Same procedure is done on dequeueing operations.
Signed-off-by: Fan Zhang
---
drivers/crypto/s
Adds a number of internal structures for the cryptodev scheduler PMD. The
structures include the scheduler context, slave, queue pair context,
and session.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/scheduler_pmd_private.h | 115 +++
1 file changed, 115 insertions(
Adds APIs and function prototypes for the scheduler PMD to perform extra
operations other than standard cryptodev APIs.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/rte_cryptodev_scheduler.h | 162 +
.../scheduler/rte_cryptodev_scheduler_operations.h | 71 +
This patch adds the cryptodev scheduler PMD name and type identifier to
librte_cryptodev.
Signed-off-by: Fan Zhang
---
lib/librte_cryptodev/rte_cryptodev.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h
b/lib/librte_cryptodev/rte_cryptodev.h
index f2
This patch provides the initial implementation of the scheduler poll mode
driver using DPDK cryptodev framework.
Scheduler PMD is used to schedule and enqueue the crypto ops to the
hardware and/or software crypto devices attached to it (slaves). The
dequeue operation from the slave(s), and the pos
On 24.01.2017 16:24, Ferruh Yigit wrote:
On 1/24/2017 10:49 AM, Matej Vido wrote:
Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
Signed-off-by: Matej Vido
Reviewed-by: Ferruh Yigit
Cc: sta...@dpdk.org
Applied to dpdk-next-net/master, thanks.
I'm not sure about the
On Tue, Jan 24, 2017 at 04:19:25PM +0100, Olivier Matz wrote:
> Based on discussion done in [1], this patchset reorganizes the mbuf.
>
Hi Olivier,
thanks for all the work on this. From a quick scan of the patches, and
the description below, it looks like a good set of changes. Comments
below to
> On Jan 24, 2017, at 4:56 PM, Olivier MATZ wrote:
>
> Hi,
>
> On Sat, 21 Jan 2017 16:28:29 +, "Ananyev, Konstantin"
> wrote:
>>> -Original Message-
>>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ilya
>>> Matveychikov Sent: Saturday, January 21, 2017 3:08 PM
>>> To: Yigit
On 1/24/2017 9:00 AM, Tiwei Bie wrote:
> Add checks to rte_pmd_ixgbe_macsec_* APIs to ensure that the
> port is an ixgbe port.
>
> Fixes: b35d309710fe ("net/ixgbe: add MACsec offload")
>
> Signed-off-by: Tiwei Bie
Applied to dpdk-next-net/master, thanks.
On 24.01.2017 16:11, Ferruh Yigit wrote:
On 1/24/2017 2:02 PM, Matej Vido wrote:
On 24.01.2017 12:58, Ferruh Yigit wrote:
On 1/24/2017 10:49 AM, Matej Vido wrote:
Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
Signed-off-by: Matej Vido
Unrelated from this patch, in
On 1/24/2017 8:51 AM, Lu, Wenzhuo wrote:
<...>
>>
>> Ignore the error=IXGBE_ERR_SFP_NOT_PRESENT when SFP is not present.
>> If it is not ignored, testpmd will in the NIC initialization process.
>> Ixgbe kernel driver ignores this error and works well. So DPDK does same
>> thing.
>>
>> Signed-off-b
On 1/24/2017 5:38 AM, Rasesh Mody wrote:
> Check if promisc mode was set when setting allmulti mode and visa-versa.
> Introduced BNX2X_RX_MODE_ALLMULTI_PROMISC for the same. If check is
> absent the filter configuration gets over written.
>
> Fixes: 540a211084a7 ("bnx2x: driver core")
> Fixes: 5db
On Tue, Jan 24, 2017 at 04:19:28PM +0100, Olivier Matz wrote:
> Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next
> to NULL when the mbuf is stored inside the mempool (unused).
> This is done in rte_pktmbuf_prefree_seg(), before freeing or
> recycling a mbuf.
>
> Before this patch, the
Hi,
> -Original Message-
> From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com]
> Sent: Friday, January 20, 2017 2:05 PM
> To: dev@dpdk.org
> Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo;
> Mcnamara, John; nhor...@tuxdriver.com; Akhil Goyal
> Subject: [PATCH v3 0
On Thu, 13 Oct 2016 14:35:06 +, Oleg Kuporosov
wrote:
> The hard requirement of financial services industry is accurate
> timestamping aligned with the packet itself. This patch is to satisfy
> this requirement:
>
> - include uint64_t timestamp field into rte_mbuf with minimal impact
> to thr
From: Jerin Jacob
To avoid multiple stores on fast path, Ethernet drivers
aggregate the writes to data_off, refcnt, nb_segs and port
to an uint64_t data and write the data in one shot
with uint64_t* at &mbuf->rearm_data address.
Some of the non-IA platforms have store operation overhead
if the s
On Wed, 18 Jan 2017 21:11:28 +0100, Olivier Matz
wrote:
> Hi guys,
>
> On Tue, 17 Jan 2017 21:55:16 +0530, Jerin Jacob
> > Oliver,
> >
> > Could you please suggest how to proceed further?
> >
>
> Sorry for the lack of response. I know people are waiting for
> me, but these days I have too ma
On 1/24/2017 10:49 AM, Matej Vido wrote:
> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
>
> Signed-off-by: Matej Vido
Reviewed-by: Ferruh Yigit
Cc: sta...@dpdk.org
Applied to dpdk-next-net/master, thanks.
Now that the m->next pointer and m->nb_segs is expected to be set (to
NULL and 1 respectively) after a mempool_get(), we can avoid to write them
in the Rx functions of drivers.
Only some drivers are patched, it's not an exhaustive patch. It gives
the idea to do the same in other drivers.
Signed-o
The field itself is not fully described yet, but this commit reserves
the room in the mbuf.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.c | 2 ++
lib/librte_mbuf/rte_mbuf.h | 10 ++
2 files changed, 12 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf
Move this field in the second cache line, since no driver use it
in Rx path. The freed space will be used by a timestamp in next
commit.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h
It is now possible to reference a port identifier larger than 256
and have a mbuf chain larger than 256 segments.
Signed-off-by: Olivier Matz
---
app/test-pmd/csumonly.c | 4 ++--
lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h | 4 ++--
lib/li
Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next
to NULL when the mbuf is stored inside the mempool (unused).
This is done in rte_pktmbuf_prefree_seg(), before freeing or
recycling a mbuf.
Before this patch, the value of m->refcnt was expected to be 0
while in pool.
The objectives are
Based on discussion done in [1], this patchset reorganizes the mbuf.
The main changes are:
- reorder structure to increase vector performance on some non-ia
platforms.
- add a 64bits timestamp field in the 1st cache line
- m->next, m->nb_segs, and m->refcnt are always initialized for mbufs
in
Rename __rte_mbuf_raw_free() as rte_mbuf_raw_free() and make
it public. The old function is kept for compat but is marked as
deprecated.
The next commit changes the behavior of rte_mbuf_raw_free() to
make it more consistent with rte_mbuf_raw_alloc().
Signed-off-by: Olivier Matz
---
drivers/net/
Document the function and make it public, since it is used at several
places in the drivers. The old one is marked as deprecated.
Signed-off-by: Olivier Matz
---
drivers/net/enic/enic_rxtx.c | 2 +-
drivers/net/fm10k/fm10k_rxtx.c| 6 +++---
drivers/net/fm10k/fm10k_rxtx
On 1/24/2017 2:44 AM, Beilei Xing wrote:
> VNI of VXLAN is parsed wrongly. The root cause is that
> array vni in item VXLAN also uses network byte ordering.
>
> Fixes: d416530e6358 ("net/i40e: parse tunnel filter")
>
> Signed-off-by: Beilei Xing
> ---
> drivers/net/i40e/i40e_flow.c | 22 +++
On Tue, Jan 24, 2017 at 12:04:09PM +0530, Akhil Goyal wrote:
> On 1/21/2017 1:01 AM, Neil Horman wrote:
> > On Fri, Jan 20, 2017 at 06:47:49PM +0530, Akhil Goyal wrote:
> > > On 1/20/2017 6:02 PM, Neil Horman wrote:
> > > > On Fri, Jan 20, 2017 at 07:35:02PM +0530, akhil.go...@nxp.com wrote:
> > >
On 1/24/2017 2:02 PM, Matej Vido wrote:
> On 24.01.2017 12:58, Ferruh Yigit wrote:
>> On 1/24/2017 10:49 AM, Matej Vido wrote:
>>> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
>>>
>>> Signed-off-by: Matej Vido
>> Unrelated from this patch, in maintainers file, you have
Secondary processes were blanket zeroing ethernet device memory,
resulting in NULL dereference crashes in multi-process setups.
Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
Signed-off-by: Remy Horton
---
doc/guides/rel_notes/release_17_02.rst | 5 +
lib/librte_ether/rte
Hello,
We are facing a peculiar problem with respect to symbol namespace in DPDK. I
think Ferruh and Thomas would have fair idea about it as they have already
reviewed and commented on it. I was hoping to get some input to take it
forward from here.
Brief Intro to DPAA2 Architecture:
This is bri
> On Jan 24, 2017, at 7:50 AM, Olivier MATZ wrote:
>
> On Tue, 24 Jan 2017 13:26:41 +, "Richardson, Bruce"
> wrote:
>>
>> Ok. Point taken for the lower-core count parts.
>>
>> Thomas - can at least one of these patches be merged into 17.02,
>> since it will definitely help us developers?
> On Jan 24, 2017, at 3:33 AM, Ananyev, Konstantin
> wrote:
>
>
>
>> -Original Message-
>> From: Wiles, Keith
>> Sent: Tuesday, January 24, 2017 5:26 AM
>> To: Ananyev, Konstantin
>> Cc: Stephen Hemminger ; Hu, Jiayu
>> ; dev@dpdk.org; Kinsella, Ray
>> ; Gilmore, Walter E ;
>> Venk
On 1/24/2017 4:19 PM, Ferruh Yigit wrote:
On 1/24/2017 9:12 AM, Shreyansh Jain wrote:
On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote:
On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
Adding NXP DPAA2 architecture specific mempool support
Each mempool instance is represented by a DPBP objec
On Tue, 24 Jan 2017 13:26:41 +, "Richardson, Bruce"
wrote:
>
> Ok. Point taken for the lower-core count parts.
>
> Thomas - can at least one of these patches be merged into 17.02,
> since it will definitely help us developers? [If Olivier's is too big
> a change at this point in the cycle, c
Signed-off-by: Matej Vido
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f071138..21d0ef9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -311,7 +311,7 @@ F: drivers/net/enic/
F: doc/guides/nics/enic.rst
Combo szedata2
-M: Mat
1 - 100 of 149 matches
Mail list logo
