Re: [dpdk-dev] [PATCH v2 0/4] enhancement to i40e PF host driver

2017-01-15 Thread Vincent JARDIN
Le 16/01/2017 à 01:55, Zhang, Helin a écrit : Acked-by: Helin Zhang Acked-by: Vincent Jardin

Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

2017-01-15 Thread Yuanhan Liu
On Wed, Jan 11, 2017 at 10:56:20AM -0800, Stephen Hemminger wrote: > Please write generic code. Something like the following (untested). Despite there are few compile errors (which are easy to fix), it works fine. More importantly, it saves near 2000 cycles if I apply the bulk free to virtio_xmit

Re: [dpdk-dev] [PATCH v10 26/26] doc: update doc for VFD

2017-01-15 Thread Vincent JARDIN
Le 16/01/2017 à 06:51, Wenzhuo Lu a écrit : + As an EXPERIMENTAL feature, please aware it can be changed or even + removed without prior notice. thank you.

[dpdk-dev] a question about the commit "414b202343ce8ad"(bonding: fix initial link status of slave)

2017-01-15 Thread wangyunjian
The commit 414b202343ce8ad (bonding: fix initial link status of slave) invokes lsc callback, the lsc callback may be executed at same time when slave_configure() and bond_ethdev_slave_link_status_change_monitor () competing for calling the lsc callback. The panic will be triggered when bond ethd

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-15 Thread Yuanhan Liu
On Fri, Jan 13, 2017 at 02:13:09PM +0800, Yuanhan Liu wrote: > But it's not the test methodology I'd expect. You are purely testing > the instruction cycles. The drop on ARM is something more like "the > if instruction takes more cycles than the simple assignment". > > This macro is used in the ca

Re: [dpdk-dev] [PATCH v9 1/5] ethdev: add firmware version get

2017-01-15 Thread Andrew Rybchenko
On 01/16/2017 08:44 AM, Qiming Yang wrote: This patch adds a new API 'rte_eth_dev_fw_version_get' for fetching firmware version by a given device. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/default.ini | 1 + doc/guides/rel_notes/deprecation.rst | 4

Re: [dpdk-dev] A question about the function fill_vec_buf

2017-01-15 Thread Yuanhan Liu
On Fri, Jan 13, 2017 at 10:20:55AM +, wangyunjian wrote: > In function fill_vec_buf, it will happen uint32_t cast to uint16_t, when the > *desc_chain_len is assigned by the len. > > This maybe result in data truncation. Do you have a real example? I don't think data truncation could happen h

Re: [dpdk-dev] [PATCH v3 0/8] Add crypto PMD optimized for ARMv8

2017-01-15 Thread Hemant Agrawal
Hi Zbigniew, > -Original Message- > From: Zbigniew Bodek [mailto:zbigniew.bo...@caviumnetworks.com] > Subject: Re: [PATCH v3 0/8] Add crypto PMD optimized for ARMv8 > On 13.01.2017 09:07, Hemant Agrawal wrote: > > On 1/4/2017 11:03 PM, zbigniew.bo...@caviumnetworks.com wrote: > >> From: Z

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-15 Thread Yuanhan Liu
On Mon, Jan 09, 2017 at 06:46:25PM +0100, Olivier Matz wrote: > The virtio specifications requires that the L4 checksum is set to the > pseudo header checksum. You can search for "pseudo header" in the > following doc: > http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.pdf > > E

Re: [dpdk-dev] [PATCH] net/virtio: fix advertised Rx offload capabilities

2017-01-15 Thread Yuanhan Liu
On Wed, Jan 11, 2017 at 06:05:25PM +0100, Olivier Matz wrote: > When the virtio PMD is used on top of a vhost that does not support > offloads, Rx offload capabilities are still advertised by > virtio_dev_info_get(). But if an application tries to start the PMD with > Rx offloads enabled (rxmode.hw

Re: [dpdk-dev] [PATCH v4 8/8] doc: add guide to use virtio_user as exceptional path

2017-01-15 Thread Yuanhan Liu
> > Besides, it's more like a howto doc instead of prog guide to me, that > it's better to put it to doc/guides/howto? Cc Thomas. --yliu

Re: [dpdk-dev] [PATCH v3 2/8] lib: add cryptodev type for the upcoming ARMv8 PMD

2017-01-15 Thread Jianbo Liu
On 13 January 2017 at 16:16, Hemant Agrawal wrote: > On 1/4/2017 11:03 PM, zbigniew.bo...@caviumnetworks.com wrote: >> >> From: Zbigniew Bodek >> >> Add type and name for ARMv8 crypto PMD >> >> Signed-off-by: Zbigniew Bodek >> --- >> lib/librte_cryptodev/rte_cryptodev.h | 3 +++ >> 1 file chang

Re: [dpdk-dev] [PATCH v4 8/8] doc: add guide to use virtio_user as exceptional path

2017-01-15 Thread Yuanhan Liu
On Fri, Jan 13, 2017 at 12:18:41PM +, Jianfeng Tan wrote: > Signed-off-by: Jianfeng Tan > --- > .../img/virtio_user_as_excpetional_path.png| Bin 0 -> 38600 bytes > doc/guides/prog_guide/index.rst| 1 + > .../prog_guide/virtio_user_as_exceptional_path.rst | 104

[dpdk-dev] [PATCH v10 23/26] app/testpmd: handle i40e in VF VLAN filter command

2017-01-15 Thread Wenzhuo Lu
From: Bernard Iremonger modify set_vf_rx_vlan function to handle the i40e PMD. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 38 +++--- app/test-pmd/config.c | 13 - app/test-pmd/testpmd.h | 2 -- 3 files changed, 31 insertions(+),

[dpdk-dev] [PATCH v10 26/26] doc: update doc for VFD

2017-01-15 Thread Wenzhuo Lu
Update the NIC doc and release note. Signed-off-by: Wenzhuo Lu --- doc/guides/nics/i40e.rst | 1 + doc/guides/rel_notes/release_17_02.rst | 29 + 2 files changed, 30 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 0

[dpdk-dev] [PATCH v10 25/26] net/i40e: set/clear VF stats from PF

2017-01-15 Thread Wenzhuo Lu
From: Qi Zhang This patch add support to get/clear VF statistics from PF side. Two APIs are added: rte_pmd_i40e_get_vf_stats. rte_pmd_i40e_reset_vf_stats. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c| 79 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v10 24/26] net/i40e: enhance in sanity check of MAC

2017-01-15 Thread Wenzhuo Lu
From: "Chen Jing D(Mark)" When VF sends request to add a new MAC address, PF host will check if it's a non-zero or unicast address, or it will return with error. In fact, VF still can set multicast address. This change remove to check if it's a unicast address. Signed-off-by: Chen Jing D(Mark)

[dpdk-dev] [PATCH v10 20/26] app/testpmd: use multicast promiscuous mode on i40e

2017-01-15 Thread Wenzhuo Lu
Add testpmd CLI to set VF multicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 93 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 102 insertions(+) diff --git a/app/test-pmd/cmdline.

[dpdk-dev] [PATCH v10 22/26] app/testpmd: add command to test VF VLAN tag on i40e

2017-01-15 Thread Wenzhuo Lu
From: Bernard Iremonger command is: set vf vlan tag port_id vf_id on|off Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 99 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ 2 files changed, 106 insertions(+) diff --git a/ap

[dpdk-dev] [PATCH v10 21/26] app/testpmd: add command to test VF broadcast mode on i40e

2017-01-15 Thread Wenzhuo Lu
From: Bernard Iremonger Add command to call rte_pmd_i40e_set_vf_broadcast. Add set vf broadcast in testpmd_funcs.rst file. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 93 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++

[dpdk-dev] [PATCH v10 18/26] app/testpmd: use VFD APIs on i40e

2017-01-15 Thread Wenzhuo Lu
The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd code to use them, including VF MAC anti-spoofing, VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. Signed-off-by: Wenzhuo Lu Signed-off-by: Chen Jing D(Mark) Signed-off-by: Bernard Iremonger --- app/test-pmd/

[dpdk-dev] [PATCH v10 17/26] net/i40e: set VF VLAN filter from PF

2017-01-15 Thread Wenzhuo Lu
From: Bernard Iremonger add rte_pmd_i40e_set_vf_vlan_filter API. User can call the API on PF to enable/disable a set of VF's VLAN filters. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 63 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v10 19/26] app/testpmd: use unicast promiscuous mode on i40e

2017-01-15 Thread Wenzhuo Lu
Add testpmd CLI to set VF unicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 93 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 102 insertions(+) diff --git a/app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v10 16/26] net/i40e: set VF VLAN tag from PF

2017-01-15 Thread Wenzhuo Lu
From: Bernard Iremonger Add rte_pmd_i40e_set_vf_vlan_tag API. User can call the API on PF to enable/disable a specific VF's VLAN tag. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 68 +++ drivers/net/i40e/rte_pmd_i40e.h |

[dpdk-dev] [PATCH v10 15/26] net/i40e: set VF broadcast mode from PF

2017-01-15 Thread Wenzhuo Lu
From: Bernard Iremonger Support enabling/disabling VF broadcast mode from PF. User can call the API on PF to enable/disable a specific VF's broadcast mode. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 56 +++ drivers/net/i40e/rte_

[dpdk-dev] [PATCH v10 14/26] net/i40e: set VF VLAN insertion from PF

2017-01-15 Thread Wenzhuo Lu
From: Bernard Iremonger Support inserting VF VLAN id from PF. User can call the API on PF to insert a VLAN id to a specific VF. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 65 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 ++

[dpdk-dev] [PATCH v10 12/26] net/i40e: fix VF MAC address assignment

2017-01-15 Thread Wenzhuo Lu
From: Ferruh Yigit If PF sets vf->mac_addr, in VF initialization hw->mac.addr will be set to that same value. It is possible to check if PF set a MAC address or not through the hw->mac.addr variable. hw->mac.addr set by i40e_vf_parse_hw_config(), call stack is: In PF side i40e_pf_host_process_c

[dpdk-dev] [PATCH v10 11/26] net/i40e: set VF MAC from VF support

2017-01-15 Thread Wenzhuo Lu
From: Ferruh Yigit Support changing VF default MAC address. This function is not supported if PF set the MAC address for the PF. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.h| 4 +++- drivers/net/i40e/i40e_ethdev_vf.c | 49 +-- 2 files

[dpdk-dev] [PATCH v10 08/26] net/i40e: enable VF MTU change

2017-01-15 Thread Wenzhuo Lu
From: Qi Zhang This patch implement mtu_set ops for i40e VF. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index f50ac2d

[dpdk-dev] [PATCH v10 10/26] net/i40e: set VF MAC from PF support

2017-01-15 Thread Wenzhuo Lu
From: Ferruh Yigit Support setting VF MAC address from PF. User can call the API on PF to set a specific VF's MAC address. PF should set MAC address before VF initialized, if PF sets the MAC address after VF initialized, new MAC address won't be effective until VF reinitialized. This will remov

[dpdk-dev] [PATCH v10 13/26] net/i40e: set VF VLAN strip from PF

2017-01-15 Thread Wenzhuo Lu
From: "Chen Jing D(Mark)" Add a function to configure vlan strip enable/disable for specific SRIOV VF device. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_ethdev.c| 37 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 dr

[dpdk-dev] [PATCH v10 09/26] net/i40e: fix VF reset flow

2017-01-15 Thread Wenzhuo Lu
From: Qi Zhang Add missing step during VF reset: PF should set I40E_VFGEN_RSTAT to ACTIVE at end of the VF reset operation or VF driver may not able to detect that reset is already completed. This patch also remove the unnecessary enum for vfr state. Fixes: 4861cde46116 ("i40e: new poll mode dri

[dpdk-dev] [PATCH v10 07/26] net/i40e: set VF multicast promisc mode from PF

2017-01-15 Thread Wenzhuo Lu
Support enabling/disabling VF multicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's multicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 41 +++ drivers/net/i40e/rte_pmd_i40e.

[dpdk-dev] [PATCH v10 06/26] net/i40e: set VF unicast promisc mode from PF

2017-01-15 Thread Wenzhuo Lu
Support enabling/disabling VF unicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's unicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 41 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v10 05/26] net/i40e: set Tx loopback from PF

2017-01-15 Thread Wenzhuo Lu
Support enabling/disabling TX loopback from PF. User can call the API on PF to enable/disable TX loopback for all the PF and VFs. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 241 ++ drivers/net/i40e/rte_pmd_i40e.h | 16 ++ driv

[dpdk-dev] [PATCH v10 03/26] net/i40e: set VF MAC anti-spoofing from PF

2017-01-15 Thread Wenzhuo Lu
Support enabling/disabling VF MAC anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's MAC anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 65 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 +

[dpdk-dev] [PATCH v10 01/26] net/i40e: support link status notification

2017-01-15 Thread Wenzhuo Lu
Add an API to expose the ability, that PF can notify VF when link status changes, to APP. So if PF APP doesn't want to enable interruption but check link status by itself, PF APP can let VF know link status changed. Signed-off-by: Wenzhuo Lu --- MAINTAINERS | 1 +

[dpdk-dev] [PATCH v10 04/26] net/i40e: set VF VLAN anti-spoofing from PF

2017-01-15 Thread Wenzhuo Lu
Support enabling/disabling VF VLAN anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's VLAN anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 140 -- drivers/net/i40e/i40e_ethdev.h|

[dpdk-dev] [PATCH v10 02/26] net/i40e: add callback to user on VF to PF mbox msg

2017-01-15 Thread Wenzhuo Lu
The callback asks the user application if it is allowed to perform the mailbox messages. If the return value from user is RTE_PMD_I40E_MB_EVENT_PROCEED then continue. If ACK or NACK, do nothing and send not_supported to VF. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_pf.c | 230 +++

[dpdk-dev] [PATCH v10 00/26] Support VFD on i40e - EXPERIMENTAL

2017-01-15 Thread Wenzhuo Lu
1, VF Daemon (VFD) VFD is an idea to control all the VFs from PF. As we need to support the scenario kernel PF + DPDK VF, DPDK follows the interface between kernel PF + kernel VF. We don't want to introduce too many new messages between PF and VF. So this patch set adds some new APIs to control VFs

[dpdk-dev] [PATCH v9 1/5] ethdev: add firmware version get

2017-01-15 Thread Qiming Yang
This patch adds a new API 'rte_eth_dev_fw_version_get' for fetching firmware version by a given device. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/default.ini | 1 + doc/guides/rel_notes/deprecation.rst | 4 doc/guides/rel_notes/release_17_02.rst |

[dpdk-dev] [PATCH v9 5/5] ethtool: display firmware version

2017-01-15 Thread Qiming Yang
This patch enhances the ethtool example to support to show firmware version, in the same way that the Linux kernel ethtool does. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- examples/ethtool/ethtool-app/ethapp.c | 1 + examples/ethtool/lib/rte_ethtool.c| 9 + 2 files changed

[dpdk-dev] [PATCH v9 4/5] net/i40e: add firmware version get

2017-01-15 Thread Qiming Yang
This patch add a new function i40e_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/i40e.ini | 1 + drivers/net/i40e/i40e_ethdev.c| 32 2 files changed, 33 insertions(+) diff --git a/doc/guides/nics/features/i40

[dpdk-dev] [PATCH v9 3/5] net/ixgbe: add firmware version get

2017-01-15 Thread Qiming Yang
This patch adds a new function ixgbe_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/ixgbe.ini | 1 + drivers/net/ixgbe/ixgbe_ethdev.c | 25 + 2 files changed, 26 insertions(+) diff --git a/doc/guides/nics/features/ixgbe.

[dpdk-dev] [PATCH v9 2/5] net/e1000: add firmware version get

2017-01-15 Thread Qiming Yang
This patch adds a new function eth_igb_fw_version_get. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- doc/guides/nics/features/igb.ini | 1 + drivers/net/e1000/igb_ethdev.c | 56 2 files changed, 57 insertions(+) diff --git a/doc/guides/nics/fe

[dpdk-dev] [PATCH v9 0/5] new API 'rte_eth_dev_fw_version_get'

2017-01-15 Thread Qiming Yang
v9: - when fw_size is insufficient, return the size of the non truncated string as snprintf does. v8: - defined the minimum fw version size as a macro. v7: - rebased v6: - renamed fw_length -> fw_size - added return value for insufficient fw_size - fixed the indentation problem in

Re: [dpdk-dev] [PATCH v4 1/5] efd: new Elastic Flow Distributor library

2017-01-15 Thread Jerin Jacob
On Sun, Jan 15, 2017 at 12:04:31PM +, Pablo de Lara wrote: > Elastic Flow Distributor (EFD) is a distributor library that uses > perfect hashing to determine a target/value for a given incoming flow key. > It has the following advantages: > > - First, because it uses perfect hashing, it does n

Re: [dpdk-dev] [PATCH v4 4/5] doc: add EFD library section in Programmers guide

2017-01-15 Thread Jerin Jacob
On Sun, Jan 15, 2017 at 12:04:34PM +, Pablo de Lara wrote: > Signed-off-by: Sameh Gobriel > Acked-by: Christian Maciocco Looks like trailing white space error on git am. Please check it ➜ [dpdk] $ pwclient git-am 19363 Applying patch #19363 using 'git am' Description: [dpdk-dev,v4,4/5] doc:

Re: [dpdk-dev] [PATCH v3 11/29] eal: generic implementation for I/O device read/write access

2017-01-15 Thread Jerin Jacob
On Sun, Jan 15, 2017 at 10:29:42PM +0100, Thomas Monjalon wrote: > 2017-01-12 14:47, Jerin Jacob: > > +#define rte_read8_relaxed(addr) \ > > + ({ uint8_t __v = *(const volatile uint8_t *)addr; __v; }) > > Why do you prefer a macro over an inline function? In this case, I thought of avoiding any

[dpdk-dev] [PATCH v7] app/testpmd: supported offload capabilities query

2017-01-15 Thread Qiming Yang
Add two new commands "show port cap " and "show port cap all"to diaplay what offload capabilities supported in ports. It will not only display all the capabilities of the port, but also the enabling condition for each capability in the running time. Signed-off-by: Qiming Yang Acked-by: Jingjing W

Re: [dpdk-dev] [PATCH v7 3/6] ethdev: add MACsec offload capability flags

2017-01-15 Thread Ananyev, Konstantin
> > If these flags are advertised by a PMD, the NIC supports the MACsec > offload. The incoming MACsec traffics can be offloaded transparently > after the MACsec offload is configured correctly by the application. > And the application can set the PKT_TX_MACSEC flag in mbufs to enable > the MACs

Re: [dpdk-dev] [PATCH v7 2/6] ethdev: add event type for MACsec

2017-01-15 Thread Ananyev, Konstantin
> > This commit adds a below event type: > > - RTE_ETH_EVENT_MACSEC > > This event will occur when the PN counter in a MACsec connection > reaches the exhaustion threshold. > > Signed-off-by: Tiwei Bie > --- > lib/librte_ether/rte_ethdev.h | 1 + > 1 file changed, 1 insertion(+) > > diff -

Re: [dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities query

2017-01-15 Thread Yang, Qiming
Hi, Pablo I have checked with Wenzhuo, this capability has no way to disable and is always enable if NIC have this capability. So I'll change the print to " RX Outer IPv4 checksum:on". -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Qiming Sent: Satur

Re: [dpdk-dev] [PATCH v2 0/4] enhancement to i40e PF host driver

2017-01-15 Thread Zhang, Helin
Acked-by: Helin Zhang -Original Message- From: Chen, Jing D Sent: Friday, January 13, 2017 11:13 AM To: dev@dpdk.org Cc: dani...@research.att.com; Zhang, Helin ; Yigit, Ferruh ; vincent.jar...@6wind.com; Wu, Jingjing ; Chen, Jing D Subject: [PATCH v2 0/4] enhancement to i40e PF host d

Re: [dpdk-dev] [PATCH v9 01/26] net/i40e: support link status notification

2017-01-15 Thread Lu, Wenzhuo
Hi Vincent, > -Original Message- > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > Sent: Monday, January 16, 2017 7:35 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 01/26] net/i40e: support link status > notification > > Le 13/01/2017 à 07:52, Wenzhu

Re: [dpdk-dev] [PATCH v9 00/26] Support VFD on i40e - EXPERIMENTAL

2017-01-15 Thread Vincent JARDIN
Le 13/01/2017 à 19:32, Ferruh Yigit a écrit : Please aware VFD is an EXPERIMENTAL feature, it can be changed or even removed without prior notice. So new version sent with a experimental tag, this can provide some flexibility to the feature until proper DPDK PF discussion concluded. Is there a

Re: [dpdk-dev] [PATCH v9 01/26] net/i40e: support link status notification

2017-01-15 Thread Vincent JARDIN
Le 13/01/2017 à 07:52, Wenzhuo Lu a écrit : + * @b EXPERIMENTAL: this API may change without prior notice a minor comment here: + including be removed.

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2017-01-15 Thread Vincent JARDIN
Thanks John for the kernel support. I'd like to add one thought on this need from Joshi: Also, the kernel drivers have no concept of passing VF messages to upstream "decision making” (or policy enforcement) software like VFd. It shall be possible to define some Netlink or policy management

Re: [dpdk-dev] [PATCH v3 11/29] eal: generic implementation for I/O device read/write access

2017-01-15 Thread Thomas Monjalon
2017-01-12 14:47, Jerin Jacob: > +#define rte_read8_relaxed(addr) \ > + ({ uint8_t __v = *(const volatile uint8_t *)addr; __v; }) Why do you prefer a macro over an inline function? It won't provide the same "debuggability".

Re: [dpdk-dev] [PATCH v8 1/5] ethdev: add firmware version get

2017-01-15 Thread Thomas Monjalon
2017-01-12 14:31, Qiming Yang: > + * @param fw_size > + * The size of the array pointed by fw_version, which should be > + * large enough to store firmware version of the device. > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if operation is not supported. > + * - (-ENODEV) i

[dpdk-dev] [PATCH] net/qede: correct function declaration syntax

2017-01-15 Thread Emmanuel Roullit
clang reports this error message: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] Signed-off-by: Emmanuel Roullit --- drivers/net/qede/qede_eth_if.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_eth_if.h b/drivers/net/

[dpdk-dev] [PATCH] net/cxgbe: add parenthesis on bitwise operation

2017-01-15 Thread Emmanuel Roullit
clang reports the following error: error: logical not is only applied to the left hand side of this bitwise operator. [-Werror,-Wlogical-not-parentheses] Signed-off-by: Emmanuel Roullit --- drivers/net/cxgbe/cxgbe_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[dpdk-dev] [PATCH] mk: suppress reference of packed members

2017-01-15 Thread Emmanuel Roullit
error: taking address of packed member 'mlock' of class or structure 'rte_mem_config' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member] Signed-off-by: Emmanuel Roullit --- mk/toolchain/clang/rte.vars.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [dpdk-dev] [PATCH v5] mbuf: add a function to linearize a packet

2017-01-15 Thread Thomas Monjalon
2017-01-13 16:32, Olivier Matz: > On Thu, 12 Jan 2017 10:40:44 +0100, Tomasz Kulasek > wrote: > > This patch adds function rte_pktmbuf_linearize to let crypto PMD > > coalesce chained mbuf before crypto operation and extend their > > capabilities to support segmented mbufs when device cannot handl

Re: [dpdk-dev] [PATCH v7 0/6] Add MACsec offload support for ixgbe

2017-01-15 Thread Thomas Monjalon
2017-01-13 19:21, Tiwei Bie: > This patch set adds the MACsec offload support for ixgbe. > The testpmd is also updated to support MACsec cmds. Applied, thanks Minor updates when applying: - no need of release notes section for mbuf flag (covered by ixgbe entry) - squashed release notes patch with

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2017-01-15 Thread JOSHI, KAUSTUBH (KAUSTUBH)
John, Thanks for comments. To answer a specific question you raised: > Open question for me on this though is the PF in these SRIOV cases > ever being used by DPDK datapath or is it just being leveraged for > configuration with primarily control traffic? In our case, the answer is yes. We intend

Re: [dpdk-dev] 17.05 Roadmap

2017-01-15 Thread Hanoch Haim (hhaim)
Hi Tim, It's great that you are going to expose the i40E Qos capability, would it be possible to expose the low-latency configuration too? Thanks, Hanoh -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of O'Driscoll, Tim Sent: Friday, January 13, 2017 12:24 PM To: de

[dpdk-dev] [PATCH v4 3/5] examples/flow_distributor: sample app to demonstrate EFD usage

2017-01-15 Thread Pablo de Lara
This new sample app, based on the client/server sample app, shows the user an scenario using the EFD library. It consists of: - A front-end server which has an EFD table that stores the node id for each flow key, which will distribute the incoming packets to the different nodes - A back-end n

[dpdk-dev] [PATCH v4 5/5] doc: add flow distributor guide

2017-01-15 Thread Pablo de Lara
Signed-off-by: Sameh Gobriel Signed-off-by: Pablo de Lara Acked-by: Christian Maciocco --- MAINTAINERS |1 + doc/guides/sample_app_ug/flow_distributor.rst | 494 doc/guides/sample_app_ug/img/flow_distributor.svg | 1254

[dpdk-dev] [PATCH v4 2/5] app/test: add EFD functional and perf tests

2017-01-15 Thread Pablo de Lara
Signed-off-by: Byron Marohn Signed-off-by: Karla Saur Signed-off-by: Saikrishna Edupuganti Signed-off-by: Pablo de Lara Acked-by: Christian Maciocco --- MAINTAINERS | 1 + app/test/Makefile| 5 +- app/test/test_efd.c | 494

[dpdk-dev] [PATCH v4 1/5] efd: new Elastic Flow Distributor library

2017-01-15 Thread Pablo de Lara
Elastic Flow Distributor (EFD) is a distributor library that uses perfect hashing to determine a target/value for a given incoming flow key. It has the following advantages: - First, because it uses perfect hashing, it does not store the key itself and hence lookup performance is not dependent

[dpdk-dev] [PATCH v4 0/5] Elastic Flow Distributor

2017-01-15 Thread Pablo de Lara
EFD is a distributor library that uses perfect hashing to determine a target/value for a given incoming flow key. It has the following advantages: first, because it uses perfect hashing it does not store the key itself and hence lookup performance is not dependent on the key size. Second, the targe

Re: [dpdk-dev] net/i40e: TX descriptor is not done

2017-01-15 Thread Gregory Etelson
Update The fault is relevant to VF only DPDK over i40e PF functions correctly Regards, Gregory On Thu, Jan 12, 2017 at 11:14 AM, Gregory Etelson wrote: > Hello, > > > > I have a standalone utility that implements > > ICMP ping over DPDK. > > When I run the utility with i40e PMD over VF it stac