Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes

> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, December 23, 2016 7:42 AM > > On 12/3/2016 9:11 AM, Rasesh Mody wrote: > > This patch consists of semantic/formatting changes. It also includes > > comment additions. > > As far as I can see majority of the changes are formattin

Re: [dpdk-dev] [PATCH 22/25] net/qede/base: add support for new firmware

Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, December 23, 2016 7:40 AM > > On 12/3/2016 9:11 AM, Rasesh Mody wrote: > > Add support for 8.14.x.x firmware. > > Is it possible to list what has been changed with new FW here? The new firmware adds support for exte

Re: [dpdk-dev] [PATCH 2/2] vhost: start vhost servers once

On 12/29/2016 10:15 PM, Yuanhan Liu wrote: On Thu, Dec 29, 2016 at 10:58:11AM -0500, Charles (Chas) Williams wrote: On 12/29/2016 03:52 AM, Yuanhan Liu wrote: On Wed, Dec 28, 2016 at 04:10:52PM -0500, Charles (Chas) Williams wrote: Start a vhost server once during devinit instead of during d

[dpdk-dev] [RFC 21/23] eal: do not panic on failed PCI probe

It may even be possible to simply log the error and continue on letting the user check the logs and restart the application when things are failed. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/lib

[dpdk-dev] [RFC 22/23] eal_common_dev: continue initializing vdevs

Even if one vdev should fail, there's no need to prevent further processing. Log the error, and reflect it to the higher levels to decide. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_e

[dpdk-dev] [RFC 23/23] eal: do not panic (or abort) if vdev init fails

Seems like it's possible to continue. At least, the error is reflected properly in the logs. A user could then go and correct or investigate the situation. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/

[dpdk-dev] [RFC 19/23] eal: do not error if plugins fail to init

Plugins are useful and important. However, it seems crazy to abort everything just because they don't initialize properly. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c

[dpdk-dev] [RFC 20/23] eal_pci: Continue probing even on failures

Some devices may be inaccessible for a variety of reasons, or the PCI-bus may be unavailable causing the whole thing to fail. Still, better to continue attempts at probes. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_pci.c | 15 ++- 1 file changed, 10 insertions(

[dpdk-dev] [RFC 18/23] eal: Do not panic on interrupt thread init

When initializing the interrupt thread, there are a number of possible reasons for failure - some of which are correctable by the application. Do not panic() needlessly, and give the application a change to reflect this information to the user. Signed-off-by: Aaron Conole --- lib/librte_eal/linu

[dpdk-dev] [RFC 14/23] eal: do not panic on tailq init

There are some theoretical racy conditions in the system that _could_ cause early tailq init to fail; however, no need to panic the application. While it can't continue using DPDK, it could make better alerts to the user. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_tailqs.

[dpdk-dev] [RFC 17/23] eal: change the private pipe call to reflect errno

There could be some confusion as to why the call failed - this change will always reflect the value of the error in rte_error. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linux

[dpdk-dev] [RFC 16/23] eal: convert timer_init not to call panic

After code inspection, there is no way for eal_timer_init() to fail. It simply returns 0 in all cases. As such, this test could either go-away or stay here as 'future-proofing'. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 de

[dpdk-dev] [RFC 15/23] eal: do not panic on alarm init

rte_eal_alarm_init() call uses the linux timerfd framework to create a poll()-able timer using standard posix file operations. This could fail for a few reasons given in the man-pages, but many could be corrected by the user application. No need to panic. Signed-off-by: Aaron Conole --- lib/li

[dpdk-dev] [RFC 13/23] eal: do not panic on memory init

This can only happen when access to hugepages (either as primary or secondary process) fails (and that is usually permissions). Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal

[dpdk-dev] [RFC 12/23] eal: do not panic on vfio failure

Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 018d359..878ba7a 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librt

[dpdk-dev] [RFC 11/23] eal: Do not panic on pci-probe

Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index a23ba17..018d359 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librt

[dpdk-dev] [RFC 10/23] eal: Do not panic on log failures

When log initialization fails, it's generally because the fopencookie failed. While this is rare in practice, it could happen. Return 'Operation Not Supported' in errno, and let the caller know this error occured. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1

[dpdk-dev] [RFC 09/23] eal: set errno when exiting for already called

Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 31d3bba..f996047 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_ea

[dpdk-dev] [RFC 08/23] eal: do not panic on memzone initialization fails

When memzone initialization fails, report the error to the calling application rather than panic(). Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/lin

[dpdk-dev] [RFC 07/23] eal: Signal error when CPU isn't supported

It's now possible to gracefully exit the application, or for applications which support non-dpdk datapaths working in concert with DPDK datapaths, there no longer is the possibility of exiting for unsupported CPUs. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 5 - 1 fi

[dpdk-dev] [RFC 06/23] eal-common: introduce a way to query cpu support

This adds a new API to check for the eal cpu versions. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_cpuflags.c | 13 +++-- lib/librte_eal/common/include/generic/rte_cpuflags.h | 9 + 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/lib

[dpdk-dev] [RFC 04/23] eal: do not panic on failed hugepage query

If we fail to acquire hugepage information, simply signal an error to the application. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal

[dpdk-dev] [RFC 05/23] eal: failure to parse args returns error

It's possible that the application could take a corrective action here, and either prompt the user for different arguments, or at least perform a better logging. Exiting this early prevents any useful information gathering from the application layer. Signed-off-by: Aaron Conole --- lib/librte_e

[dpdk-dev] [RFC 03/23] eal: No panic on hugepages info init

When attempting to scan hugepages, signal to the eal.c that an error has occured, rather than performing a panic. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/

[dpdk-dev] [RFC 02/23] eal: return error instead of panic for cpu init

There may be a way to gracefully recover; at least the application should be notified that a failure happened, rather than completely aborting. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte

[dpdk-dev] [RFC 00/23] Refactor eal_init to remove panic() calls

In many cases, it's enough to simply let the application know that the call to initialize DPDK has failed. A complete halt can then be decided by the application based on error returned (and the app could even attempt a possible re-attempt after some corrective action by the user or application).

[dpdk-dev] [RFC 01/23] eal: CPU init will no longer panic

After this change, the EAL CPU NUMA node resolution step can no longer emit an rte_panic. This aligns with the code in rte_eal_init, which expects failures to return an error code. Signed-off-by: Aaron Conole --- lib/librte_eal/common/eal_common_lcore.c | 7 --- 1 file changed, 4 insertions

[dpdk-dev] [PATCH v2 18/18] net/ixgbe: flush all the filter list

This patch adds a function to flush all the fliter list filter on a port. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- --- drivers/net/ixgbe/ixgbe_ethdev.c | 59 1 file changed, 59 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/

[dpdk-dev] [PATCH v2 16/18] net/ixgbe: create consistent filter

This patch adds a function to create the flow directory filter. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- v2: --add new error set function --- drivers/net/ixgbe/ixgbe_ethdev.c | 240 ++- drivers/net/ixgbe/ixgbe_ethdev.h | 5 + 2 files changed,

[dpdk-dev] [PATCH v2 17/18] net/ixgbe: destroy consistent filter

This patch adds a function to destroy the flow fliter. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- v2: --fix git log error --- drivers/net/ixgbe/ixgbe_ethdev.c | 117 ++- 1 file changed, 116 insertions(+), 1 deletion(-) diff --git a/drivers/net/i

[dpdk-dev] [PATCH v2 15/18] net/ixgbe: parse flow director filter

check if the rule is a flow director rule, and get the flow director info. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- v2:add new error set function --- drivers/net/ixgbe/ixgbe_ethdev.c | 1467 +- drivers/net/ixgbe/ixgbe_ethdev.h | 16 + drivers

[dpdk-dev] [PATCH v2 11/18] net/ixgbe: parse n-tuple filter

Add rule validate function and check if the rule is a n-tuple rule, and get the n-tuple info. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- v2:add new error set function --- drivers/net/ixgbe/ixgbe_ethdev.c | 414 ++- 1 file changed, 409 insertions(

[dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter

check if the rule is a TCP SYN rule, and get the SYN info. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- v2:add new error set function --- drivers/net/ixgbe/ixgbe_ethdev.c | 251 +++ 1 file changed, 251 insertions(+) diff --git a/drivers/net/ixgbe/

[dpdk-dev] [PATCH v2 10/18] net/ixgbe: flush all the filters

Add support for flush all the filters in SW. Signed-off-by: Wenzhuo Lu Signed-off-by: Wei Zhao --- v2: --change flush filter function call relationship --- drivers/net/ixgbe/ixgbe_ethdev.c | 118 ++- drivers/net/ixgbe/ixgbe_ethdev.h | 9 +++ drivers/net/i

[dpdk-dev] [PATCH v2 14/18] net/ixgbe: parse L2 tunnel filter

check if the rule is a L2 tunnel rule, and get the L2 tunnel info. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- v2: --add new error set function --change return value type of parser function --- drivers/net/ixgbe/ixgbe_ethdev.c | 269 +++ lib/librt

[dpdk-dev] [PATCH v2 12/18] net/ixgbe: parse ethertype filter

check if the rule is a ethertype rule, and get the ethertype info. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- v2:add new error set function --- drivers/net/ixgbe/ixgbe_ethdev.c | 251 +++ 1 file changed, 251 insertions(+) diff --git a/drivers/net

[dpdk-dev] [PATCH v2 09/18] net/ixgbe: store and restore L2 tunnel configuration

Add support for store and restore L2 tunnel filter in SW. Signed-off-by: Wenzhuo Lu Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 36 drivers/net/ixgbe/ixgbe_ethdev.h | 3 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/net/ixgb

[dpdk-dev] [PATCH v2 08/18] net/ixgbe: restore L2 tunnel filter

Add support for restoring L2 tunnel filter in SW. Signed-off-by: Wenzhuo Lu Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 69 ++-- 1 file changed, 46 insertions(+), 23 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/

[dpdk-dev] [PATCH v2 05/18] net/ixgbe: restore ether type filter

Add support for restoring ether type filter in SW. Signed-off-by: Wenzhuo Lu Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 84 ++-- drivers/net/ixgbe/ixgbe_ethdev.h | 57 ++- drivers/net/ixgbe/ixgbe_pf.c | 25 +

[dpdk-dev] [PATCH v2 07/18] net/ixgbe: restore flow director filter

Add support for storing flow director filter in SW. Signed-off-by: Wenzhuo Lu Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/ixgbe/ixgbe_ethdev.h | 1 + drivers/net/ixgbe/ixgbe_fdir.c | 35 +++ 3 files changed, 37 insertions(+