Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-16 Thread Vincent JARDIN
Le 16/12/2016 à 20:02, Ferruh Yigit a écrit : As we need to support the scenario kernel PF + DPDK VF, DPDK follows the interface between kernel PF + kernel VF. Please, it has to be proven that DPDK provides the same interface that the kernel. It seems insane to duplicate kernel's PF into the D

Re: [dpdk-dev] [PATCH v5 23/29] app/testpmd: handle i40e in VF VLAN filter command

2016-12-16 Thread Vincent JARDIN
Le 16/12/2016 à 20:02, Ferruh Yigit a écrit : +#ifdef RTE_LIBRTE_IXGBE_PMD + if (strstr(dev_info.driver_name, "ixgbe") != NULL) + ret = rte_pmd_ixgbe_set_vf_vlan_filter(res->port_id, + res->vlan_id, res->vf_mask, is_add); +#endif +#ifdef RTE_LIBRT

Re: [dpdk-dev] [PATCH v5 18/29] app/testpmd: use VFD APIs on i40e

2016-12-16 Thread Vincent JARDIN
Le 16/12/2016 à 20:02, Ferruh Yigit a écrit : +#ifdef RTE_LIBRTE_IXGBE_PMD "set all queues drop (port_id) (on|off)\n" "Set drop enable bit for all queues.\n\n" "set vf split drop (port_id) (vf_id) (on|off)\n"

Re: [dpdk-dev] [PATCH v5 19/29] app/testpmd: use unicast promiscuous mode on i40e

2016-12-16 Thread Vincent JARDIN
Le 16/12/2016 à 20:02, Ferruh Yigit a écrit : +#ifdef RTE_LIBRTE_I40E_PMD + ret = rte_pmd_i40e_set_vf_unicast_promisc(res->port_id, + res->vf_id, is_on); +#endif Why is an ifdef used here? It won't scale to all PMDs. I means that you are missing an abstraction layer

Re: [dpdk-dev] [PATCH 2/2] hyperv: VMBUS support infrastucture

2016-12-16 Thread Stephen Hemminger
On Fri, 16 Dec 2016 19:09:02 +0100 Thomas Monjalon wrote: > 2016-12-15 09:26, Stephen Hemminger: > > On Thu, 15 Dec 2016 12:19:44 +0530 > > Shreyansh Jain wrote: > > > It is not a scale-able model where we have to change eth_driver/eth_dev > > > for every new device type, other than PCI. Mayb

[dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats from PF

2016-12-16 Thread Ferruh Yigit
From: Qi Zhang This patch add support to get/clear VF statistics from PF side. Two APIs are added: rte_pmd_i40e_get_vf_stats. rte_pmd_i40e_reset_vf_stats. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c| 76 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v5 28/29] net/i40e: enhance in sanity check of MAC

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" When VF sends request to add a new MAC address, PF host will check if it's a non-zero or unicast address, or it will return with error. In fact, VF still can set multicast address. This change remove to check if it's a unicast address. Signed-off-by: Chen Jing D(Mark)

[dpdk-dev] [PATCH v5 27/29] net/i40e: support Linux VF to configure IRQ link list

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" i40e PF host only support to work with DPDK VF driver, Linux VF driver is not supported. This change will enhance in configuring IRQ link list. This Change will identify VF client by number of vector requested. DPDK VF will ask only single one while Linux VF will reques

[dpdk-dev] [PATCH v5 25/29] net/i40e: return correct VSI id

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" PF host didn't return correct VSI id to VF. This change fix it. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_pf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 0f582ed.

[dpdk-dev] [PATCH v5 26/29] net/i40e: parse more VF parameter and configure

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" When VF requested to configure TX queue, a few parameters are missed to be configured in PF host. This change have more fields parsed and configured for TX context. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_pf.c | 4 +++- 1 file changed, 3 insertions(

[dpdk-dev] [PATCH v5 24/29] net/i40e: change version number to support Linux VF

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" i40e PF host only support to work with DPDK VF driver, Linux VF driver is not supported. This change will enhance in version number returned. Current version info returned won't be able to be recognized by Linux VF driver, change to values that both DPDK VF and Linux dr

[dpdk-dev] [PATCH v5 23/29] app/testpmd: handle i40e in VF VLAN filter command

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger modify set_vf_rx_vlan function to handle the i40e PMD. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 40 +--- app/test-pmd/config.c | 13 - app/test-pmd/testpmd.h | 2 -- 3 files changed, 33 insertions(+)

[dpdk-dev] [PATCH v5 22/29] app/testpmd: add command to test VF VLAN tag on i40e

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger command is: set vf vlan tag port_id vf_id on|off Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 97 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++ 2 files changed, 104 insertions(+) diff --git a/a

[dpdk-dev] [PATCH v5 21/29] app/testpmd: add command to test VF broadcast mode on i40e

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Add command to call rte_pmd_i40e_set_vf_broadcast. Add set vf broadcast in testpmd_funcs.rst file. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 91 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++

[dpdk-dev] [PATCH v5 19/29] app/testpmd: use unicast promiscuous mode on i40e

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Add testpmd CLI to set VF unicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 92 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 101 insertions(+) diff --git a/app/

[dpdk-dev] [PATCH v5 20/29] app/testpmd: use multicast promiscuous mode on i40e

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Add testpmd CLI to set VF multicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 92 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 101 insertions(+) diff --git a/ap

[dpdk-dev] [PATCH v5 18/29] app/testpmd: use VFD APIs on i40e

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd code to use them, including VF MAC anti-spoofing, VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. Signed-off-by: Wenzhuo Lu Signed-off-by: Chen Jing D(Mark) Signed-off-by: Bernard Iremonger

[dpdk-dev] [PATCH v5 16/29] net/i40e: set VF VLAN tag from PF

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Add rte_pmd_i40e_set_vf_vlan_tag API. User can call the API on PF to enable/disable a specific VF's VLAN tag. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 59 +++ drivers/net/i40e/rte_pmd_i40e.h |

[dpdk-dev] [PATCH v5 17/29] net/i40e: set VF VLAN filter from PF

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger add rte_pmd_i40e_set_vf_vlan_filter API. User can call the API on PF to enable/disable a set of VF's VLAN filters. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 52 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v5 15/29] net/i40e: set VF broadcast mode from PF

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Support enabling/disabling VF broadcast mode from PF. User can call the API on PF to enable/disable a specific VF's broadcast mode. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 43 +++ drivers/net/i40e/rte_

[dpdk-dev] [PATCH v5 13/29] net/i40e: add VF VLAN strip func

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" Add a function to configure vlan strip enable/disable for specific SRIOV VF device. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_ethdev.c| 26 ++ drivers/net/i40e/rte_pmd_i40e.h | 19 +++ driv

[dpdk-dev] [PATCH v5 14/29] net/i40e: add set VF VLAN insert function

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Support inserting VF VLAN id from PF. User can call the API on PF to insert a VLAN id to a specific VF. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 53 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 ++

[dpdk-dev] [PATCH v5 12/29] net/i40e: fix VF MAC address assignment

2016-12-16 Thread Ferruh Yigit
If PF sets vf->mac_addr, in VF initialization hw->mac.addr will be set to that same value. It is possible to check if PF set a MAC address or not through the hw->mac.addr variable. hw->mac.addr set by i40e_vf_parse_hw_config(), call stack is: In PF side i40e_pf_host_process_cmd_get_vf_resources()

[dpdk-dev] [PATCH v5 11/29] net/i40e: set VF MAC from VF support

2016-12-16 Thread Ferruh Yigit
Support changing VF default MAC address. This function is not supported if PF set the MAC address for the PF. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.h| 4 +++- drivers/net/i40e/i40e_ethdev_vf.c | 49 +-- 2 files changed, 45 insertion

[dpdk-dev] [PATCH v5 08/29] net/i40e: enable VF MTU change

2016-12-16 Thread Ferruh Yigit
From: Qi Zhang This patch implement mtu_set ops for i40e VF. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 12da0ec

[dpdk-dev] [PATCH v5 10/29] net/i40e: set VF MAC from PF support

2016-12-16 Thread Ferruh Yigit
Support setting VF MAC address from PF. User can call the API on PF to set a specific VF's MAC address. This will remove all existing MAC filters. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.c| 40 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v5 09/29] net/i40e: fix VF reset flow

2016-12-16 Thread Ferruh Yigit
From: Qi Zhang Add missing step during VF reset: PF should set I40E_VFGEN_RSTAT to ACTIVE at end of the VF reset operation or VF driver may not able to detect that reset is already completed. This patch also remove the unnecessary enum for vfr state. Fixes: 4861cde46116 ("i40e: new poll mode dri

[dpdk-dev] [PATCH v5 07/29] net/i40e: set VF multicast promisc mode from PF

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Support enabling/disabling VF multicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's multicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 36 +++ drivers/net

[dpdk-dev] [PATCH v5 06/29] net/i40e: set VF unicast promisc mode from PF

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Support enabling/disabling VF unicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's unicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 36 +++ drivers/net/i40

[dpdk-dev] [PATCH v5 05/29] net/i40e: set Tx loopback from PF

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Support enabling/disabling TX loopback from PF. User can call the API on PF to enable/disable TX loopback for all the PF and VFs. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 219 ++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v5 03/29] net/i40e: set VF MAC anti-spoofing from PF

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Support enabling/disabling VF MAC anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's MAC anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 63 +++ drivers/net/i40e/rte_pmd_i40e

[dpdk-dev] [PATCH v5 04/29] net/i40e: set VF VLAN anti-spoofing from PF

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Support enabling/disabling VF VLAN anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's VLAN anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 116 +- drivers/net/i40e/i40e_ethde

[dpdk-dev] [PATCH v5 01/29] net/i40e: support link status notification

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Add an API to expose the ability, that PF can notify VF when link status changes, to APP. So if PF APP doesn't want to enable interruption but check link status by itself, PF APP can let VF know link status changed. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/Makefile

[dpdk-dev] [PATCH v5 02/29] net/i40e: add callback to user on VF to PF mbox msg

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu The callback asks the user application if it is allowed to perform the mailbox messages. If the return value from user is RTE_PMD_I40E_MB_EVENT_PROCEED then continue. If ACK or NACK, do nothing and send not_supported to VF. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_

[dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-16 Thread Ferruh Yigit
1, VF Daemon (VFD) VFD is an idea to control all the VFs from PF. As we need to support the scenario kernel PF + DPDK VF, DPDK follows the interface between kernel PF + kernel VF. We don't want to introduce too many new messages between PF and VF. So this patch set adds some new APIs to control

Re: [dpdk-dev] [PATCH 2/2] hyperv: VMBUS support infrastucture

2016-12-16 Thread Thomas Monjalon
2016-12-15 09:26, Stephen Hemminger: > On Thu, 15 Dec 2016 12:19:44 +0530 > Shreyansh Jain wrote: > > It is not a scale-able model where we have to change eth_driver/eth_dev > > for every new device type, other than PCI. Maybe VMBus is _very_ close > > to PCI so no changes are required in PCI la

[dpdk-dev] [PATCH v2] doc: add details of sub-trees and maintainers

2016-12-16 Thread John McNamara
Add a new section to the Code Contributors Guide to outline the roles of tree and component maintainers and how they can be added and removed. Signed-off-by: John McNamara --- * V2: Added comments from mailing list. doc/guides/contributing/patches.rst | 72

Re: [dpdk-dev] [PATCH v3] vmxnet3: fix Rx deadlock

2016-12-16 Thread Yong Wang
> -Original Message- > From: Stefan Puiu [mailto:stefan.p...@gmail.com] > Sent: Friday, December 16, 2016 7:37 AM > To: dev@dpdk.org > Cc: Yong Wang ; mac_le...@yahoo.com.hk; > Stefan Puiu > Subject: [PATCH v3] vmxnet3: fix Rx deadlock > > Our use case is that we have an app that needs to

Re: [dpdk-dev] [PATCH] nfp: add doc about supported features

2016-12-16 Thread Alejandro Lucero
Hi, One question about this patch. I will send another patch soon which will require to modify the file created by this patch. So, should I use the dpdk-next for sending the new patch or the dpdk stable branch? I understand that using the latter will imply some integration later, but I really do n

[dpdk-dev] [PATCH v4] nfp: report link speed using hardware info

2016-12-16 Thread Alejandro Lucero
Previous reported speed was hardcoded because there was not firmware support for getting this information. This change needs to support old firmware versions, keeping with the hardcoded report, and the new versions, where the firmware makes that information available. v4: Make conditional simple a

Re: [dpdk-dev] [PATCH 00/28] introduce I/O device memory read/write operations

2016-12-16 Thread Thomas Monjalon
2016-12-14 18:48, Jerin Jacob: > On Wed, Dec 14, 2016 at 10:53:57AM +0800, Yuanhan Liu wrote: > > On Wed, Dec 14, 2016 at 07:25:30AM +0530, Jerin Jacob wrote: > > > patchset 14-28: Replace the raw readl/writel in the drivers with > > > new rte_read[b/w/l/q], rte_write[b/w/l/q] eal abstraction > >

[dpdk-dev] [PATCH v2 09/25] app/testpmd: add flow list command

2016-12-16 Thread Adrien Mazarguil
Syntax: flow list {port_id} [group {group_id}] [...] List configured flow rules on a port. Output can optionally be limited to a given set of group identifiers. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline.c | 4 ++ app/test-pmd/cmdline_flow.c | 141

Re: [dpdk-dev] [PATCH 1/3] ethdev: New API to free consumed buffers in TX ring

2016-12-16 Thread Stephen Hemminger
On Fri, 16 Dec 2016 07:48:49 -0500 Billy McFall wrote: > /** > + * Request the driver to free mbufs currently cached by the driver. The > + * driver will only free the mbuf if it is no longer in use. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param queue

[dpdk-dev] [PATCH v2 24/25] app/testpmd: add queue actions to flow command

2016-12-16 Thread Adrien Mazarguil
- QUEUE: assign packets to a given queue index. - DUP: duplicate packets to a given queue index. - RSS: spread packets among several queues. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 152 +++ 1 file changed, 152 insertions(+) diff --gi

[dpdk-dev] [PATCH v2 25/25] doc: describe testpmd flow command

2016-12-16 Thread Adrien Mazarguil
Document syntax, interaction with rte_flow and provide usage examples. Signed-off-by: Adrien Mazarguil --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 612 +++ 1 file changed, 612 insertions(+) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_

[dpdk-dev] [PATCH v2 23/25] app/testpmd: add various actions to flow command

2016-12-16 Thread Adrien Mazarguil
- MARK: attach 32 bit value to packets. - FLAG: flag packets. - DROP: drop packets. - COUNT: enable counters for a rule. - PF: redirect packets to physical device function. - VF: redirect packets to virtual device function. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 121 ++

[dpdk-dev] [PATCH v2 22/25] app/testpmd: add L4 items to flow command

2016-12-16 Thread Adrien Mazarguil
Add the ability to match a few properties of common L4[.5] protocol headers: - ICMP: type and code. - UDP: source and destination ports. - TCP: source and destination ports. - SCTP: source and destination ports. - VXLAN: network identifier. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdli

[dpdk-dev] [PATCH v2 20/25] app/testpmd: add items eth/vlan to flow command

2016-12-16 Thread Adrien Mazarguil
These pattern items match basic Ethernet headers (source, destination and type) and related 802.1Q/ad VLAN headers. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 126 +++ 1 file changed, 126 insertions(+) diff --git a/app/test-pmd/cmdline_

[dpdk-dev] [PATCH v2 21/25] app/testpmd: add items ipv4/ipv6 to flow command

2016-12-16 Thread Adrien Mazarguil
Add the ability to match basic fields from IPv4 and IPv6 headers (source and destination addresses only). Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 177 +++ 1 file changed, 177 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/a

[dpdk-dev] [PATCH v2 19/25] app/testpmd: add item raw to flow command

2016-12-16 Thread Adrien Mazarguil
Matches arbitrary byte strings with properties: - relative: look for pattern after the previous item. - search: search pattern from offset (see also limit). - offset: absolute or relative offset for pattern. - limit: search area limit for start of pattern. - length: pattern length. - pattern: byte

[dpdk-dev] [PATCH v2 18/25] app/testpmd: add various items to flow command

2016-12-16 Thread Adrien Mazarguil
- PF: match packets addressed to the physical function. - VF: match packets addressed to a virtual function ID. - PORT: device-specific physical port index to use. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 53 1 file changed, 53 in

[dpdk-dev] [PATCH v2 17/25] app/testpmd: add item any to flow command

2016-12-16 Thread Adrien Mazarguil
This pattern item matches any protocol in place of the current layer and has two properties: - min: minimum number of layers covered (0 or more). - max: maximum number of layers covered (0 means infinity). Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 23

[dpdk-dev] [PATCH v2 15/25] app/testpmd: add rte_flow item spec prefix length

2016-12-16 Thread Adrien Mazarguil
Generating bit-masks from prefix lengths is often more convenient than providing them entirely (e.g. to define IPv4 and IPv6 subnets). This commit adds the "prefix" operator that assigns generated bit-masks to any pattern item specification field. Signed-off-by: Adrien Mazarguil --- app/test-pm

[dpdk-dev] [PATCH v2 16/25] app/testpmd: add rte_flow bit-field support

2016-12-16 Thread Adrien Mazarguil
Several rte_flow structures expose bit-fields that cannot be set in a generic fashion at byte level. Add bit-mask support to handle them. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 59 1 file changed, 59 insertions(+) diff --git a/

[dpdk-dev] [PATCH v2 14/25] app/testpmd: add rte_flow item spec handler

2016-12-16 Thread Adrien Mazarguil
Add parser code to fully set individual fields of pattern item specification structures, using the following operators: - fix: sets field and applies full bit-mask for perfect matching. - spec: sets field without modifying its bit-mask. - last: sets upper value of the spec => last range. - mask: s

[dpdk-dev] [PATCH v2 13/25] app/testpmd: add flow query command

2016-12-16 Thread Adrien Mazarguil
Syntax: flow query {port_id} {rule_id} {action} Query a specific action of an existing flow rule. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline.c | 3 + app/test-pmd/cmdline_flow.c | 121 ++- 2 files changed, 123 insertions(+), 1 deletion(

[dpdk-dev] [PATCH v2 12/25] app/testpmd: add flow validate/create commands

2016-12-16 Thread Adrien Mazarguil
Syntax: flow (validate|create) {port_id} [group {group_id}] [priority {level}] [ingress] [egress] pattern {item} [/ {item} [...]] / end actions {action} [/ {action} [...]] / end Either check the validity of a flow rule or create it. Any number of pattern items and actions can be prov

[dpdk-dev] [PATCH v2 10/25] app/testpmd: add flow flush command

2016-12-16 Thread Adrien Mazarguil
Syntax: flow flush {port_id} Destroy all flow rules on a port. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline.c | 3 +++ app/test-pmd/cmdline_flow.c | 43 +++- 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdli

[dpdk-dev] [PATCH v2 11/25] app/testpmd: add flow destroy command

2016-12-16 Thread Adrien Mazarguil
Syntax: flow destroy {port_id} rule {rule_id} [...] Destroy a given set of flow rules associated with a port. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline.c | 3 ++ app/test-pmd/cmdline_flow.c | 106 ++- 2 files changed, 108 insertions(+)

[dpdk-dev] [PATCH v2 08/25] app/testpmd: add rte_flow integer support

2016-12-16 Thread Adrien Mazarguil
Parse all integer types and handle conversion to network byte order in a single function. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 148 +++ 1 file changed, 148 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdl

[dpdk-dev] [PATCH v2 07/25] app/testpmd: add flow command

2016-12-16 Thread Adrien Mazarguil
Managing generic flow API functions from command line requires the use of dynamic tokens for convenience as flow rules are not fixed and cannot be defined statically. This commit adds specific flexible parser code and object for a new "flow" command in separate file. Signed-off-by: Adrien Mazargu

[dpdk-dev] [PATCH v2 06/25] app/testpmd: implement basic support for rte_flow

2016-12-16 Thread Adrien Mazarguil
Add basic management functions for the generic flow API (validate, create, destroy, flush, query and list). Flow rule objects and properties are arranged in lists associated with each port. Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline.c | 1 + app/test-pmd/config.c | 485 +

[dpdk-dev] [PATCH v2 05/25] cmdline: add alignment constraint

2016-12-16 Thread Adrien Mazarguil
This prevents sigbus errors on architectures that cannot handle unexpected unaligned accesses to the output buffer. Signed-off-by: Adrien Mazarguil --- lib/librte_cmdline/cmdline_parse.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/librte_cmdline/cmdline_parse

[dpdk-dev] [PATCH v2 04/25] cmdline: add support for dynamic tokens

2016-12-16 Thread Adrien Mazarguil
Considering tokens must be hard-coded in a list part of the instruction structure, context-dependent tokens cannot be expressed. This commit adds support for building dynamic token lists through a user-provided function, which is called when the static token list is empty (a single NULL entry). B

[dpdk-dev] [PATCH v2 02/25] doc: add rte_flow prog guide

2016-12-16 Thread Adrien Mazarguil
This documentation is based on the latest RFC submission, subsequently updated according to feedback from the community. Signed-off-by: Adrien Mazarguil --- doc/guides/prog_guide/index.rst|1 + doc/guides/prog_guide/rte_flow.rst | 1853 +++ 2 files changed, 18

[dpdk-dev] [PATCH v2 03/25] doc: announce depreciation of legacy filter types

2016-12-16 Thread Adrien Mazarguil
They are superseded by the generic flow API (rte_flow). Target release is not defined yet. Suggested-by: Kevin Traynor Signed-off-by: Adrien Mazarguil --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/

[dpdk-dev] [PATCH v2 00/25] Generic flow API (rte_flow)

2016-12-16 Thread Adrien Mazarguil
As previously discussed in RFC v1 [1], RFC v2 [2], with changes described in [3] (also pasted below), here is the first non-draft series for this new API. Its capabilities are so generic that its name had to be vague, it may be called "Generic flow API", "Generic flow interface" (possibly shortene

[dpdk-dev] [PATCH v2 01/25] ethdev: introduce generic flow API

2016-12-16 Thread Adrien Mazarguil
This new API supersedes all the legacy filter types described in rte_eth_ctrl.h. It is slightly higher level and as a result relies more on PMDs to process and validate flow rules. Benefits: - A unified API is easier to program for, applications do not have to be written for a specific filter t

Re: [dpdk-dev] [PATCH 3/3] driver: vHost support to free consumed buffers

2016-12-16 Thread Stephen Hemminger
On Fri, 16 Dec 2016 07:48:51 -0500 Billy McFall wrote: > Add support to the vHostdriver for the new API to force free consumed > buffers on TX ring. vHost does not cache the mbufs so there is no work > to do. > > Signed-off-by: Billy McFall > --- > drivers/net/vhost/rte_eth_vhost.c | 11 ++

Re: [dpdk-dev] [PATCH v1] doc: add details of sub-trees and maintainers

2016-12-16 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 06:32:37PM +0100, Thomas Monjalon wrote: > Thanks for documenting the process, John. > > 2016-12-02 16:44, John McNamara: > > +The role of the component maintainers is to: > > + > > I would add: > * Coordinate how improvements and fixes are done. > > > +* Review patches f

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-16 Thread Jan Mędala
> > ​>At this point we need to have only pseudo-header checksum for TSO. Maybe > there will be new requirements, but that's something I cannot predict at > this point. > > Ok great, then we'll add a patch for ENA for v14, unless you guys would > like to do it yourself. > ​ ​That'd be great!​ >We

[dpdk-dev] [PATCH v3] vmxnet3: fix Rx deadlock

2016-12-16 Thread Stefan Puiu
Our use case is that we have an app that needs to keep mbufs around for a while. We've seen cases when calling vmxnet3_post_rx_bufs() from vmxet3_recv_pkts(), it might not succeed to add any mbufs to any RX descriptors (where it returns -err). Since there are no mbufs that the virtual hardware can

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-16 Thread Ananyev, Konstantin
Hi Jan, ​>Hello, ​ >>Is there any update on that subject? ​>At this point we need to have only pseudo-header checksum for TSO. Maybe there will be new requirements, but that's something I cannot predict at this point. Ok great, then we'll add a patch for ENA for v14, unless you guys would li

Re: [dpdk-dev] [PATCH 12/22] app/testpmd: add rte_flow item spec handler

2016-12-16 Thread Adrien Mazarguil
Hi Beilei, On Fri, Dec 16, 2016 at 12:22:52PM +, Xing, Beilei wrote: > Thanks Adrien. > > I have two questions: > 1. when I set " / vlan tci fix 10" with testpmd, I find the mask of tci is > 0x. > Actually tci includes PRI, CFI, and Vlan_id which holds 12 bits, so is > it possible

[dpdk-dev] [PATCH] performance-thread: add software packet type parsing

2016-12-16 Thread Tomasz Kulasek
Last changes in Niantic and Fortville NIC drivers causes that vector Rx path is chosen by default in l3fwd-thread application. This path doesn't support propagation of hw packet type recognition to the packet_type field in mbuf, and packets cannot be classified properly. The approach to solve this

Re: [dpdk-dev] [PATCH] crypto/openssl: fix extra bytes being written at end of data

2016-12-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Friday, December 16, 2016 10:30 AM > To: Azarewicz, PiotrX T > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: fix extra bytes being > written at

Re: [dpdk-dev] [PATCH v2] crypto/qat: fix to avoid buffer overwrite in OOP case

2016-12-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Griffin, John > Sent: Friday, December 16, 2016 11:21 AM > To: Trahe, Fiona; dev@dpdk.org > Cc: De Lara Guarch, Pablo; Trahe, Fiona; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] crypto/qat: fix to avoid buffer overwrite > in OOP case > > > > > -

[dpdk-dev] [RFC] cryptodev: enable BPI+ for Cablelabs DOCSIS security spec

2016-12-16 Thread Trahe, Fiona
Proposal to extend the DPDK cryptodev API to enable processing of packets according to the Baseline Privacy Interface Plus (BPI+) Specification described in the security specification of the Cablelabs Data-over-Cable Service Interface Specification (DOCSIS). Brief summary of BPI+ symmetric cryp

[dpdk-dev] [PATCH v4 16/29] net/i40e: set VF VLAN tag from PF

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Add rte_pmd_i40e_set_vf_vlan_tag API. User can call the API on PF to enable/disable a specific VF's VLAN tag. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 59 +++ drivers/net/i40e/rte_pmd_i40e.h |

Re: [dpdk-dev] ConnectX4 100GbE - Compilation problem

2016-12-16 Thread george . dit
Hi all, I am coming back to you regarding the Mellanox Connectx4 100Gbps DPDK driver. We exchanged some e-mails last summer and I managed to compile the DPDK-based Mellanox driver using DPDK 16.07 on top of Ubuntu server 16.04.01. A few days ago, I installed a fresh Ubuntu server 16.04.1 on my ma

Re: [dpdk-dev] [PATCH v4 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-16 Thread Vincent Jardin
I do not see test to validate that the PF userland will look like a Linux PF. I am getting concerned that it is a bad solution since we have two/three PF mailboxes which may not be consistent: Linux, DPDK, VMware. Le 16 décembre 2016 3:39:36 PM Ferruh Yigit a écrit : 1, VF Daemon (VFD) VFD i

[dpdk-dev] [PATCH v4 28/29] net/i40e: enhance in sanity check of MAC

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" When VF sends request to add a new MAC address, PF host will check if it's a non-zero or unicast address, or it will return with error. In fact, VF still can set multicast address. This change remove to check if it's a unicast address. Signed-off-by: Chen Jing D(Mark)

[dpdk-dev] [PATCH v4 29/29] net/i40e: set/clear VF stats from PF

2016-12-16 Thread Ferruh Yigit
From: Qi Zhang This patch add support to get/clear VF statistics from PF side. Two APIs are added: rte_pmd_i40e_get_vf_stats. rte_pmd_i40e_reset_vf_stats. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c| 76 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v4 27/29] net/i40e: support Linux VF to configure IRQ link list

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" i40e PF host only support to work with DPDK VF driver, Linux VF driver is not supported. This change will enhance in configuring IRQ link list. This Change will identify VF client by number of vector requested. DPDK VF will ask only single one while Linux VF will reques

[dpdk-dev] [PATCH v4 24/29] net/i40e: change version number to support Linux VF

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" i40e PF host only support to work with DPDK VF driver, Linux VF driver is not supported. This change will enhance in version number returned. Current version info returned won't be able to be recognized by Linux VF driver, change to values that both DPDK VF and Linux dr

[dpdk-dev] [PATCH v4 25/29] net/i40e: return correct VSI id

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" PF host didn't return correct VSI id to VF. This change fix it. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_pf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 0f582ed.

[dpdk-dev] [PATCH v4 26/29] net/i40e: parse more VF parameter and configure

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" When VF requested to configure TX queue, a few parameters are missed to be configured in PF host. This change have more fields parsed and configured for TX context. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_pf.c | 4 +++- 1 file changed, 3 insertions(

[dpdk-dev] [PATCH v4 23/29] app/testpmd: handle i40e in VF VLAN filter command

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger modify set_vf_rx_vlan function to handle the i40e PMD. Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index fc0424a..c5da9b1

[dpdk-dev] [PATCH v4 22/29] app/testpmd: add command to test VF VLAN tag on i40e

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger command is: set vf vlan tag port_id vf_id on|off Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 91 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++ 2 files changed, 98 insertions(+) diff --git a/ap

[dpdk-dev] [PATCH v4 21/29] app/testpmd: add command to test VF broadcast mode on i40e

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Add command to call rte_pmd_i40e_set_vf_broadcast. Add set vf broadcast in testpmd_funcs.rst file. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 85 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++

[dpdk-dev] [PATCH v4 20/29] app/testpmd: use multicast promiscuous mode on i40e

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Add testpmd CLI to set VF multicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 86 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 95 insertions(+) diff --git a/app

[dpdk-dev] [PATCH v4 19/29] app/testpmd: use unicast promiscuous mode on i40e

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Add testpmd CLI to set VF unicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 86 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 95 insertions(+) diff --git a/app/t

[dpdk-dev] [PATCH v4 18/29] app/testpmd: use VFD APIs on i40e

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd code to use them, including VF MAC anti-spoofing, VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. Signed-off-by: Wenzhuo Lu Signed-off-by: Chen Jing D(Mark) Signed-off-by: Bernard Iremonger

[dpdk-dev] [PATCH v4 17/29] net/i40e: set VF VLAN filter from PF

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger add rte_pmd_i40e_set_vf_vlan_filter API. User can call the API on PF to enable/disable a set of VF's VLAN filters. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 52 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v4 14/29] net/i40e: add set VF VLAN insert function

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Support inserting VF VLAN id from PF. User can call the API on PF to insert a VLAN id to a specific VF. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 53 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 ++

[dpdk-dev] [PATCH v4 15/29] net/i40e: set VF broadcast mode from PF

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Support enabling/disabling VF broadcast mode from PF. User can call the API on PF to enable/disable a specific VF's broadcast mode. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 43 +++ drivers/net/i40e/rte_

[dpdk-dev] [PATCH v4 13/29] net/i40e: add VF VLAN strip func

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" Add a function to configure vlan strip enable/disable for specific SRIOV VF device. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_ethdev.c| 26 ++ drivers/net/i40e/rte_pmd_i40e.h | 19 +++ driv

[dpdk-dev] [PATCH v4 12/29] net/i40e: fix VF MAC address assignment

2016-12-16 Thread Ferruh Yigit
If PF sets vf->mac_addr, in VF initialization hw->mac.addr will be set to that same value. It is possible to check if PF set a MAC address or not through the hw->mac.addr variable. hw->mac.addr set by i40e_vf_parse_hw_config(), call stack is: In PF side i40e_pf_host_process_cmd_get_vf_resources()

[dpdk-dev] [PATCH v4 10/29] net/i40e: set VF MAC from PF support

2016-12-16 Thread Ferruh Yigit
Support setting VF MAC address from PF. User can call the API on PF to set a specific VF's MAC address. This will remove all existing MAC filters. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.c| 40 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v4 11/29] net/i40e: set VF MAC from VF support

2016-12-16 Thread Ferruh Yigit
Support changing VF default MAC address. This function is not supported if PF set the MAC address for the PF. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.h| 4 +++- drivers/net/i40e/i40e_ethdev_vf.c | 49 +-- 2 files changed, 45 insertion

  1   2   >