[dpdk-dev] [PATCH] mk: toolchain: gcc: query the compiler macros to obtain the gcc version

2016-03-22 Thread Thomas Monjalon
2016-03-22 17:13, Markos Chandras: > This is similar to what's being used in the Linux kernel. Querying the > GCC macros directly gives more accurate results compared to -dumpversion > which could vary across distributions. > > Signed-off-by: Markos Chandras > --- > In openSUSE Tumbleweed (and in

[dpdk-dev] DPDK and HW offloads

2016-03-22 Thread Jerin Jacob
On Tue, Mar 22, 2016 at 10:17:21AM -0700, Stephen Hemminger wrote: > On Tue, 22 Mar 2016 07:19:01 -0500 > Jay Rolette wrote: > > > On Tue, Mar 22, 2016 at 5:19 AM, Bruce Richardson < > > bruce.richardson at intel.com> wrote: > > > > > On Tue, Mar 22, 2016 at 05:50:28AM +, Qiu, Michael wrote:

[dpdk-dev] [PATCH v5 1/9] ethdev: extend flow director for input selection

2016-03-22 Thread Thomas Monjalon
2016-03-21 14:18, Jingjing Wu: > This patch added RTE_ETH_INPUT_SET_L3_IP4_TTL, > RTE_ETH_INPUT_SET_L3_IP6_HOP_LIMITS input field type and extended > struct rte_eth_ipv4_flow and rte_eth_ipv6_flow to support filtering > by tos, protocol and ttl. [...] > --- a/doc/guides/rel_notes/deprecation.rst >

[dpdk-dev] [PATCH v5 0/9] extend flow director fields in i40e driver

2016-03-22 Thread Thomas Monjalon
2016-03-22 21:51, Bruce Richardson: > On Mon, Mar 21, 2016 at 02:18:43PM +0800, Jingjing Wu wrote: > > v5 changes: > > - remove the reorganizing of struct rte_eth_fdir_flow > > - remove fdir supporting on Tunnel Id > > - rebase to latest dpdk/master > > > Thomas, given the above removal, are you

[dpdk-dev] [PATCH] mk: toolchain: gcc: query the compiler macros to obtain the gcc version

2016-03-22 Thread Markos Chandras
Hi, On 22/03/16 22:34, Thomas Monjalon wrote: > 2016-03-22 17:13, Markos Chandras: >> This is similar to what's being used in the Linux kernel. Querying the >> GCC macros directly gives more accurate results compared to -dumpversion >> which could vary across distributions. >> >> Signed-off-by: Ma

[dpdk-dev] Error when starting testpmd in dpdk 2.2.0 ("Creation of mbuf pool for socket 0 failed")

2016-03-22 Thread Kevin Wilson
Hi, I am getting the following error while running testpmd: RING: Cannot reserve memory EAL: Error - exiting with code: 1 Cause: Creation of mbuf pool for socket 0 failed I am running it thus: build/app/testpmd --log-level 8 -c7 -n3 -- \ -i --nb-cores=2 --nb-ports=2 --pkt-filter-mode=

[dpdk-dev] [PATCH v5 0/9] extend flow director fields in i40e driver

2016-03-22 Thread Bruce Richardson
On Mon, Mar 21, 2016 at 02:18:43PM +0800, Jingjing Wu wrote: > v5 changes: > - remove the reorganizing of struct rte_eth_fdir_flow > - remove fdir supporting on Tunnel Id > - rebase to latest dpdk/master > Thomas, given the above removal, are you ok with the ethdev changes now present in this pa

[dpdk-dev] Question on examples/multi_process app

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 08:03:42PM +, Harish Patil wrote: > Hi, > I have a question regarding symmetric_mp and mp_server applications under > examples/multi_process. In those apps, rte_eth_promiscuous_enable() is > called before rte_eth_dev_start(). Is this the correct way to initialize > the p

[dpdk-dev] [PATCH v2 3/3] l2fwd-crypto: add NULL in cipher/auth algo list

2016-03-22 Thread Pablo de Lara
NULL crypto operation is now supported, but l2fwd-crypto was missing an update on the list of supported algorithms that can be passed from command line. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/l2fwd-crypto/m

[dpdk-dev] [PATCH v2 2/3] l2fwd-crypto: add AES GCM in auth algo list

2016-03-22 Thread Pablo de Lara
AES GCM is an algorithm for both ciphering and authentication, but the authentication algorithm was missing in the list of supported algorithms that can be passed from command line. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 5 - 1 file changed, 4 insertions(+), 1 deleti

[dpdk-dev] [PATCH v2 1/3] l2fwd-crypto: add SNOW3G algorithms

2016-03-22 Thread Pablo de Lara
Since SNOW3G UEA2/UIA2 are supported now by both HW and SW, l2fwd-crypto may use them, extending the list of algorithms parsed from command line. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 48 +++- 1 file changed, 39 insertions(+), 9 d

[dpdk-dev] [PATCH v2 0/3] Extend list of supported algorithms in L2fwd-crypto

2016-03-22 Thread Pablo de Lara
New cipher/authentication algorithms are supported in cryptodev, so L2fwd-crypto needs to have the list of supported algorithms updated. Changes in v2: - Added other two algorithms - Modified offset and length in bits for SNOW3G algorithms Pablo de Lara (3): l2fwd-crypto: add SNOW3G algorithms

[dpdk-dev] [PATCH] i40e: fix ipv6 TSO issue for tx function

2016-03-22 Thread Zhe Tao
Issue: when using the following CLI in testpmd to enable ipv6 TSO feature = set verbose 1 csum set ip hw 0 csum set udp hw 0 csum set tcp hw 0 csum set sctp hw 0 csum set outer-ip hw 0 csum parse_tunnel on 0 tso set 800 0 set fwd csum start = We will not get we want, the i

[dpdk-dev] [PATCH 3/8] drivers/net/e1000: Fix missing brackets

2016-03-22 Thread Thomas Monjalon
2016-03-01 13:02, Panu Matilainen: > On 02/26/2016 03:13 PM, Aaron Conole wrote: > > "Lu, Wenzhuo" writes: > >> Normally we will not maintain the base code. It's just taken from kernel > >> driver. > >> Agree with you that the whitespace is misleading. But as it's no real > >> impact. I'd like to

[dpdk-dev] [PATCH 1/8] lpm: Fix pointer aliasing issues

2016-03-22 Thread Thomas Monjalon
2016-02-25 21:30, Bruce Richardson: > On Thu, Feb 25, 2016 at 01:48:34PM -0500, Aaron Conole wrote: > > /** > > + * Convert from tbl_entry types to integer types > > + */ > > +static inline uint16_t > > +rte_lpm_tbl24_entry_to_uint16(const struct rte_lpm_tbl24_entry *entry) > > +{ > > + union {

[dpdk-dev] [PATCH v11 0/8] ethdev: 100G and link speed API refactoring

2016-03-22 Thread Thomas Monjalon
2016-03-17 19:08, Thomas Monjalon: > There are still too few tests and reviews, especially for > autonegotiation with Intel devices (patch #6). > I would not be surprised to see some bugs in this rework. Any feedback about autoneg in e1000/ixgbe/i40e? Has it been tested before its integration in R

[dpdk-dev] [PATCH v3] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Thomas Monjalon
2016-03-22 13:51, Daniel Mrzyglod: > For GLIBC < 2.17 it is necessery to add -lrt for linker > from glibc > 2.17 The `clock_*' suite of functions (declared in ) is > now > available directly in the main C library. This affect Ubuntu 12.04 in i686 > and other older Linux Distros). > > v3: change L

[dpdk-dev] Issues with openvswitch2.5+dpdk2.2+kvm/virtio-pci

2016-03-22 Thread Daniele Di Proietto
Hi Christian, thanks for the report. I've managed to reproduce the problem and I observed two separate issues: 1) short version: it appears to be a problem in DPDK 2.2 and it should be fixed by 9a0615af7746("virtio: fix restart"), now on master. long version: for every DPDK device added to OVS

[dpdk-dev] [PATCH 2/2] mk: fix two more missing libm dependencies

2016-03-22 Thread Thomas Monjalon
2016-03-21 11:48, Ferruh Yigit: > On 3/21/2016 11:33 AM, Panu Matilainen wrote: > > Commit e86a699cf6b1 missed two further libm dependencies: ceil() used by > > librte_meter is typically inlined so the missing dependency does not > > actually cause failures, and librte_pmd_nfp is not built by defau

[dpdk-dev] [PATCH] mk: restrict CPU flags list

2016-03-22 Thread Thomas Monjalon
2016-03-21 21:27, Thomas Monjalon: > When compiling each file, the CPU flags are given as RTE_MACHINE_CPUFLAG_* > and in the list RTE_COMPILE_TIME_CPUFLAGS. > > RTE_MACHINE_CPUFLAG_* are used to check the CPU features when compiling. > > The list RTE_COMPILE_TIME_CPUFLAGS is used only to check th

[dpdk-dev] [PATCH] examples/l3fwd: remove old SSE4 comments

2016-03-22 Thread Thomas Monjalon
The flag ENABLE_MULTI_BUFFER_OPTIMIZE has been removed so the related comments are now useless. Fixes: 26b5b020 ("examples/l3fwd: modularize") Signed-off-by: Thomas Monjalon --- examples/l3fwd/l3fwd_em.c | 9 - examples/l3fwd/l3fwd_lpm.c | 8 2 files changed, 17 deletions(

[dpdk-dev] Question on examples/multi_process app

2016-03-22 Thread Harish Patil
Hi, I have a question regarding symmetric_mp and mp_server applications under examples/multi_process. In those apps, rte_eth_promiscuous_enable() is called before rte_eth_dev_start(). Is this the correct way to initialize the port/device? As per the description in http://dpdk.org/doc/api/rte__ethde

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process environment

2016-03-22 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, March 22, 2016 11:42 AM > To: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio > Cc: dev at dpdk.org; Dhana Eadala; Richardson, Bruce; Qiu, Michael > Subject: Re: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH] examples/performance-thread: fix build without SSE4.1

2016-03-22 Thread Thomas Monjalon
> clang reports these errors: > > error: too many arguments to function call, expected 2, have 3 > examples/performance-thread/l3fwd-thread/main.c:1220:1: note: > 'l3fwd_simple_forward' declared here > > examples/l3fwd/main.c:550:1: error: unused function 'send_packetsx4' > > The fun

[dpdk-dev] [PATCH] examples/ip_pipeline: fix configuration parser

2016-03-22 Thread Thomas Monjalon
2016-03-14 12:22, Fan Zhang: > Fixes: 377cd98e ("example/ip_pipeline: add link identification") > > Signed-off-by: Fan Zhang > Acked-by: Cristian Dumitrescu Applied, thanks

[dpdk-dev] [PATCH] igb_uio: fix vmware e1000 input/output error

2016-03-22 Thread Stephen Hemminger
On Mon, 21 Mar 2016 11:07:56 +0100 Thomas Monjalon wrote: > 2016-03-21 17:01, Qian Xu: > > INTX is badly emulated in Vmware, INTX toggle check didn't work > > with Vmware e1000 device. The patch is to fix the issue. > > Is it possible to detect a VMware e1000 device? > > > --- a/lib/librte_eal/

[dpdk-dev] [PATCH] testpmd: fix enumerated type mixed with another type

2016-03-22 Thread Thomas Monjalon
2016-03-22 15:52, Tomasz Kulasek: > This patch fixes error #188: enumerated type mixed with another type, > when uint32_t is casted on enum type in icc. > > Fixes: 05f1b9c82ec2 ("app/testpmd: add commands for L2 tunnel config") > > Signed-off-by: Tomasz Kulasek Applied, thanks

[dpdk-dev] [PATCH] doc: notify Rx errors not counting missed packets anymore

2016-03-22 Thread Thomas Monjalon
2016-03-22 16:57, Thomas Monjalon: > Fixes: 86057c9992f5 ("ethdev: remove missed packets from error counter") > > Suggested-by: Maryam Tahhan > Signed-off-by: Thomas Monjalon [...] > +* The ethdev statistics counter imissed is considered exclusive with ierrors. > + Every drivers are now countin

[dpdk-dev] [PATCH v2] ring: check for zero objects mc dequeue / mp enqueue

2016-03-22 Thread Thomas Monjalon
> > Issuing a zero objects dequeue with a single consumer has no effect. > > Doing so with multiple consumers, can get more than one thread to succeed > > the compare-and-set operation and observe starvation or even deadlock in > > the while loop that checks for preceding dequeues. The problematic

[dpdk-dev] [PATCH] l2fwd-crypto: add SNOW3G algorithms

2016-03-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, March 22, 2016 1:17 PM > To: dev at dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo > Subject: [PATCH] l2fwd-crypto: add SNOW3G algorithms > > Since SNOW3G UEA2/UIA2 are supported now by both HW and SW, > l2fwd-cry

[dpdk-dev] [PATCH v2 7/7] drivers/net/ixgbe: Fix uninitialized warning

2016-03-22 Thread Aaron Conole
Silence a compiler warning that this variable may be used uninitialized. Signed-off-by: Aaron Conole Acked-by: Helin Zhang --- v2: * No change (apart from adding ACK) drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_

[dpdk-dev] [PATCH v2 6/7] drivers/net/ixgbe: Signed left shift operator

2016-03-22 Thread Aaron Conole
Tell the compiler to use an unsigned constant for the config shifts. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen Acked-by: Helin Zhang --- v2: * No change (apart from adding ACKs) drivers/net/ixgbe/ixgbe_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH v2 5/7] drivers/net/e1000/igb: Signed left shift operator

2016-03-22 Thread Aaron Conole
Tell the compiler to use an unsigned constant for the config shifts. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen Acked-by: Helin Zhang --- v2: * No change (apart from adding ACKs) drivers/net/e1000/igb_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH v2 4/7] drivers/net/ixgbe: Fix vlan filter missing brackets

2016-03-22 Thread Aaron Conole
The ixgbe vlan filter code has an if check with an incorrect whitespace. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen Acked-by: Helin Zhang --- v2: * No change (apart from adding ACKs) drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[dpdk-dev] [PATCH v2 3/7] drivers/net/e1000: Fix missing lsc interrupt check brackets

2016-03-22 Thread Aaron Conole
The device lsc interrupt check has a misleading whitespace around it which can be improved by adding appropriate braces to the check. Since the ret variable was checked after previous assignment, this introduces no functional change. Fixes commit 921a72008f76 ("e1000: add Rx interrupt handler") S

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-22 Thread Aaron Conole
The register read/write mphy functions have misleading whitespace around the locked check. This cleanup merely preserves the existing functionality while improving the ready check. Fixes commit 38db3f7f50bd ("e1000: update base driver") Signed-off-by: Aaron Conole --- v2: * Changed from "whitesp

[dpdk-dev] [PATCH v2 1/7] app/test/test: Fix missing brackets

2016-03-22 Thread Aaron Conole
The test application calls printf(...) with the suite->suite_name argument. The intent (based on whitespace) in the printf is to check suite->suite_name first and then apply the printf. This doesn't happen due to missing brackets. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen --- v2: * N

[dpdk-dev] [PATCH v2 0/7] Various fixes to compile with gcc6

2016-03-22 Thread Aaron Conole
This series brings a number of code cleanups to allow building using gcc6, with various legitimate warnings being fixed. Some of these fixes are to the drivers area, making this series a bit atypical. However, the fixes identified in patches 2 and 3 are actual bugs and should be fixed. The first

[dpdk-dev] [PATCH v2] enic: fix incorrect setting of rx descriptor limit

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 05:32:41PM +, Bruce Richardson wrote: > On Fri, Mar 18, 2016 at 11:33:34AM -0700, John Daley wrote: > > From: Nelson Escobar > > > > On initialization, the rq descriptor count was set to the limit > > of the vic. When the requested number of rx descriptors was > > les

[dpdk-dev] [PATCH v2] enic: fix incorrect setting of rx descriptor limit

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 11:33:34AM -0700, John Daley wrote: > From: Nelson Escobar > > On initialization, the rq descriptor count was set to the limit > of the vic. When the requested number of rx descriptors was > less than this count, enic_alloc_rq() was incorrectly setting > the count to the

[dpdk-dev] [PATCH v3] enic: update enic PMD maintainer and pointer to the guide.

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 11:27:07AM -0700, John Daley wrote: > Change maintainers for ENIC PMD and fix pointer to enic > documentation in MAINTAINERS. > > Signed-off-by: John Daley > --- Applied to dpdk-next-net/rel_16_04 /Bruce

[dpdk-dev] [PATCH 1/2] mlx5: fix overwritten RSS configuration

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 05:27:47PM +0100, Adrien Mazarguil wrote: > On Fri, Mar 18, 2016 at 01:54:42PM +0100, Nelio Laranjeiro wrote: > > RSS configuration provided by the application should not be used as storage > > by the PMD. > > > > Fixes: 2f97422e7759 ("mlx5: support RSS hash update and get"

[dpdk-dev] [PATCH] ixgbe: fix reta query and update on x550

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 03:19:35AM +, Lu, Wenzhuo wrote: > Hi, > > > > -Original Message- > > From: Wang, Xiao W > > Sent: Friday, March 18, 2016 10:28 AM > > To: Zhang, Helin > > Cc: dev at dpdk.org; Lu, Wenzhuo; Wang, Xiao W > > Subject: [PATCH] ixgbe: fix reta query and update on x

[dpdk-dev] [PATCH] vhost PMD: Fix wrong handling of maximum value of rx/tx queues

2016-03-22 Thread Loftus, Ciara
> > Currently, the maximum value of rx/tx queueus are kept by EAL. But, > the value are used like below different meanings in vhost PMD. > - The maximum value of current enabled queues. > - The maximum value of current supported queues. > > This wrong double meaning will cause an issue like bel

[dpdk-dev] [PATCH v4 0/5] lpm allocation fixes

2016-03-22 Thread Thomas Monjalon
2016-03-21 15:06, Christian Ehrhardt: > Poking a bit on autotest revealed a few shortcomings in the lpm allocation > path. > Thanks to the feedback to the first revision of the patches here v2. > Also Oliver Matz spotted similar issues and made me aware - thanks! > Integrating them revealed even m

[dpdk-dev] [PATCH] mk: toolchain: gcc: query the compiler macros to obtain the gcc version

2016-03-22 Thread Markos Chandras
This is similar to what's being used in the Linux kernel. Querying the GCC macros directly gives more accurate results compared to -dumpversion which could vary across distributions. Signed-off-by: Markos Chandras --- In openSUSE Tumbleweed (and in any other SUSE distribution which uses (or will

[dpdk-dev] [PATCH] eal/ppc: fix secondary process to map hugepages in correct order

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 04:35:32PM +, Sergio Gonzalez Monroy wrote: > First of all, forgive my ignorance regarding ppc64 and if the questions are > naive but after having a > look to the already existing code for ppc64 and this patch now, why are we > doing this reverse mapping at all? > > I g

[dpdk-dev] [PATCH] vhost PMD: Fix wrong handling of maximum value of rx/tx queues

2016-03-22 Thread Tetsuya Mukawa
Currently, the maximum value of rx/tx queueus are kept by EAL. But, the value are used like below different meanings in vhost PMD. - The maximum value of current enabled queues. - The maximum value of current supported queues. This wrong double meaning will cause an issue like below steps. * In

[dpdk-dev] [PATCH] doc: notify Rx errors not counting missed packets anymore

2016-03-22 Thread Thomas Monjalon
Fixes: 86057c9992f5 ("ethdev: remove missed packets from error counter") Suggested-by: Maryam Tahhan Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/release_16_04.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_16_04.rst b/doc/guides/rel_notes/r

[dpdk-dev] [PATCH 0/3] enic PMD receive path fixes

2016-03-22 Thread Bruce Richardson
On Thu, Mar 17, 2016 at 03:57:04PM -0700, John Daley wrote: > These patches fix up some bugs in the enic receive path. > > John Daley (3): > enic: mbuf->ol_flags could be set incorrectly > enic: handle error packets properly > enic: small cleanup- remove a packet_error conditional > > driv

[dpdk-dev] [PATCH] enic: prevent segfaults when allocating too many TX or RX queues

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 04:46:30PM +, Bruce Richardson wrote: > On Thu, Mar 17, 2016 at 03:49:58PM -0700, John Daley wrote: > > From: Nelson Escobar > > > > Add checks to make sure we don't try to allocate more tx or rx queues > > than we support. > > > > Signed-off-by: Nelson Escobar > > R

[dpdk-dev] [PATCH 1/8] lpm: Fix pointer aliasing issues

2016-03-22 Thread Aaron Conole
Thomas Monjalon writes: > 2016-02-25 21:30, Bruce Richardson: >> On Thu, Feb 25, 2016 at 01:48:34PM -0500, Aaron Conole wrote: >> > /** >> > + * Convert from tbl_entry types to integer types >> > + */ >> > +static inline uint16_t >> > +rte_lpm_tbl24_entry_to_uint16(const struct rte_lpm_tbl24_ent

[dpdk-dev] [PATCH] enic: prevent segfaults when allocating too many TX or RX queues

2016-03-22 Thread Bruce Richardson
On Thu, Mar 17, 2016 at 03:49:58PM -0700, John Daley wrote: > From: Nelson Escobar > > Add checks to make sure we don't try to allocate more tx or rx queues > than we support. > > Signed-off-by: Nelson Escobar > Reviewed-by: John Daley Better to use the word fix in the title to indicate this

[dpdk-dev] [PATCH] enic: add missing \n to a few print statements

2016-03-22 Thread Bruce Richardson
On Thu, Mar 17, 2016 at 03:48:13PM -0700, John Daley wrote: > From: Nelson Escobar > > Signed-off-by: Nelson Escobar > Acked-by: John Daley Applied to dpdk-next-net/rel_16_04 /Bruce

[dpdk-dev] [PATCH] eal/ppc: fix secondary process to map hugepages in correct order

2016-03-22 Thread Sergio Gonzalez Monroy
First of all, forgive my ignorance regarding ppc64 and if the questions are naive but after having a look to the already existing code for ppc64 and this patch now, why are we doing this reverse mapping at all? I guess the question revolves around the comment in eal_memory.c: 1316

[dpdk-dev] [PATCH v3 0/5] Implement missing features in mlx5

2016-03-22 Thread Bruce Richardson
On Thu, Mar 17, 2016 at 04:38:53PM +0100, Adrien Mazarguil wrote: > This patchset adds to mlx5 a few features available in mlx4 (TX from > secondary processes) or provided by Verbs (support for HW packet padding, > TX VLAN insertion). > > Release notes and documentation are updated accordingly. >

[dpdk-dev] [PATCH] ixgbe: add TX queue number check

2016-03-22 Thread Wenzhuo Lu
Ixgbe supports at most 128 TX queues. But in none VT nor DCB mode the queues 64 ~ 127 should not be used. Ixgbe doesn't do any check about that. If a queue larger than 64 is used, the TX packets will be dropped silently. It's hard to debug. This check is added to forbid using queue number larger th

[dpdk-dev] multi-segment mbuf

2016-03-22 Thread Clarylin L
Ok...I think you meant there's a bug in the driver code when formatting multi-segment mbuf. On Tue, Mar 22, 2016 at 3:13 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > Read the source. > > A multi-segment mbuf has the first mbuf with nb_segs > 1 and chained by > next pointer. > I

[dpdk-dev] [PATCH] testpmd: fix enumerated type mixed with another type

2016-03-22 Thread Tomasz Kulasek
This patch fixes error #188: enumerated type mixed with another type, when uint32_t is casted on enum type in icc. Fixes: 05f1b9c82ec2 ("app/testpmd: add commands for L2 tunnel config") Signed-off-by: Tomasz Kulasek --- app/test-pmd/cmdline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[dpdk-dev] multi-segment mbuf

2016-03-22 Thread Clarylin L
On my setup, the sending host is a regular one without running dpdk. It sends out 2500-byte packet without fragmentation to the dpdk node. Isn't it the enic pmd driver that is responsible for fetch the packet and format the mbuf (or mbuf chain if required)? Or do you mean I need to write my own co

[dpdk-dev] [PATCH v3 1/3] xen: Add UIO kernel driver

2016-03-22 Thread Jan Blunck
On Tue, Mar 22, 2016 at 12:27 PM, Thomas Monjalon wrote: > 2016-03-22 12:04, Jan Blunck: >> On Tue, Mar 22, 2016 at 11:42 AM, Thomas Monjalon >> wrote: >> > 2016-03-22 10:55, Jan Blunck: >> >> New UIO helper kernel driver for Xen netfront UIO poll mode driver. >> >> >> >> Signed-off-by: Stephen H

[dpdk-dev] [PATCH] i40e: fix using memory after free issue

2016-03-22 Thread Bruce Richardson
On Mon, Mar 14, 2016 at 09:02:04AM +, Jiangu Zhao wrote: > The old code still uses entry in the next loop of LIST_FOREACH after free() > in i40e_res_pool_destroy(). > Change to a safe way to free entry, which is similar with LIST_FOREACH_SAFE > in FreeBSD. > > Signed-off-by: Jiangu Zhao Th

[dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter

2016-03-22 Thread Tahhan, Maryam
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, March 17, 2016 4:41 PM > To: Igor Ryzhov > Cc: dev at dpdk.org; Tahhan, Maryam ; > olivier.matz at 6wind.com > Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in > erroneous packets counter > > CC M

[dpdk-dev] [PATCH v6 0/2] i40evf: pf reset event report

2016-03-22 Thread Bruce Richardson
On Tue, Mar 15, 2016 at 09:59:38AM +0800, Jingjing Wu wrote: > v6 changes: > - rebase on latest dpdk-next-net/rel_16_04 branch (commit 94d8f4bf963a) > - fix complie issue > > v5 changes: > - doc rewording and format fixing. > > v4 changes: > - rebase on latest dpdk-next-net/rel_16_04 branch (

[dpdk-dev] multi-segment mbuf

2016-03-22 Thread Stephen Hemminger
Read the source. A multi-segment mbuf has the first mbuf with nb_segs > 1 and chained by next pointer. It is a bug in the creator of the mbuf, if number of segments and next chain don't match. There is a rte_pktmbuf_dump(), you can use to look at how your mbuf is formatted. On Tue, Mar 22, 2016

[dpdk-dev] [PATCH] l2fwd-crypto: add SNOW3G algorithms

2016-03-22 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, March 22, 2016 1:17 PM > To: dev at dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] l2fwd-crypto: add SNOW3G algorithms > > Since SNOW3G UEA2/

[dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_xstats_get with NULL

2016-03-22 Thread Stephen Hemminger
Normal usage of rte_eth_dev_xstats_get is to call twice. The first time the function is called with portid, xstats = NULL and n = 0; this returns the number of entries in the statistics table that need to be allocated. The problem is that the routine adds a count value to NULL (0) and assumes that

[dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help

2016-03-22 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, March 22, 2016 1:21 PM > To: dev at dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help > > Previous

[dpdk-dev] [PATCH v2] testpmd: fix build on FreeBSD

2016-03-22 Thread Marvin Liu
Build log: /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named 's6_addr32' in 'struct in6_addr' rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]); This is caused by macro "s6_addr32" not defined on FreeBSD and testpmd swap big endian parameter to host endian. Move the swap a

[dpdk-dev] [PATCH v2] ring: check for zero objects mc dequeue / mp enqueue

2016-03-22 Thread Xie, Huawei
On 3/22/2016 6:13 PM, Richardson, Bruce wrote: > On Mon, Mar 21, 2016 at 05:47:44PM +, Xie, Huawei wrote: >> On 3/18/2016 10:17 PM, Bruce Richardson wrote: >>> On Fri, Mar 18, 2016 at 01:47:29PM +0100, Mauricio V?squez wrote: Hi, On Fri, Mar 18, 2016 at 11:35 AM, Thomas Monj

[dpdk-dev] Regarding DPDK installation

2016-03-22 Thread Thomas Monjalon
2016-03-22 13:13, Vivek Gupta: > I am trying to install DPDK 2.2 on Ubuntu 14. Do you just want to compile DPDK or really install it? Where do you want to install DPDK? > After configuring all necessary variables in common_linuxapp > file, I run following two commands > > make config T=x86_64-iv

[dpdk-dev] [PATCH] ixgbe: fix vector RX can't always set packet_type properly

2016-03-22 Thread Konstantin Ananyev
Fixes: 39625417585 ("mbuf: redefine packet type") Current vector RX can't always set packet_type properly. To be more specific: a) it never sets RTE_PTYPE_L2_ETHER b) it doesn't handle tunnel ipv4/ipv6 case correctly. c) it doesn't check is IXGBE_RXDADV_PKTTYPE_ETQF set or not. While a) is pretty

[dpdk-dev] [PATCH 2/3] bnx2x: Tx performance improvement fixes

2016-03-22 Thread Bruce Richardson
On Thu, Mar 10, 2016 at 05:47:56PM -0800, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > --- > drivers/net/bnx2x/bnx2x.c| 207 > +- > drivers/net/bnx2x/bnx2x.h|4 +- > drivers/net/bnx2x/bnx2x_ethdev.c |

[dpdk-dev] [PATCH] ixgbe: avoid unnessary break when checking at the tail of rx hwring

2016-03-22 Thread Ananyev, Konstantin
> -Original Message- > From: Jianbo Liu [mailto:jianbo.liu at linaro.org] > Sent: Monday, March 21, 2016 2:27 AM > To: Richardson, Bruce > Cc: Lu, Wenzhuo; Zhang, Helin; Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: avoid unnessary break when checking at >

[dpdk-dev] [PATCH] mlx4: use dummy rxqs when a non-pow2 number is requested

2016-03-22 Thread Wiles, Keith
Hi Olivier, >Hi Keith, > >On 03/21/2016 06:38 PM, Wiles, Keith wrote: >>> On Mar 21, 2016, at 11:10 AM, Olivier Matz >>> wrote: >>> >>> When using RSS, the number of rxqs has to be a power of two. >>> This is a problem because there is no API is dpdk that makes >>> the application aware of that.

[dpdk-dev] [PATCH v2] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Panu Matilainen
On 03/22/2016 11:58 AM, Daniel Mrzyglod wrote: > For GLIBC < 2.17 it is necessery to add -lrt for linker > from glibc > 2.17 The `clock_*' suite of functions (declared in ) is > now > available directly in the main C library. This affect Ubuntu 12.04 in i686 > and other older Linux Distros). > > F

[dpdk-dev] Regarding DPDK installation

2016-03-22 Thread Vivek Gupta
Hi >Do you just want to compile DPDK or really install it?Where do you want to >install DPDK? I want to install DPDK into {$HOME}/dpdk downloaded tar ball. > The install directory is not specified in this command. After your suggestion i used as make config T=x86_64-ivshmem-linuxapp-gcc DEST

[dpdk-dev] [PATCH v3] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Daniel Mrzyglod
For GLIBC < 2.17 it is necessery to add -lrt for linker from glibc > 2.17 The `clock_*' suite of functions (declared in ) is now available directly in the main C library. This affect Ubuntu 12.04 in i686 and other older Linux Distros). v3: change LDFLAGS to LDLIBS v2: Add missed example v1: Initia

[dpdk-dev] [PATCH v2] mk: fix eal shared library dependencies -lrt

2016-03-22 Thread Daniel Mrzyglod
For GLIBC < 2.17 it is necessery to add -lrt for linker from glibc > 2.17 The `clock_*' suite of functions (declared in ) is now available directly in the main C library. This affect Ubuntu 12.04 in i686 and other older Linux Distros). v3: change LDFLAGS to LDLIBS v2: Add missed example v1: Initia

[dpdk-dev] [PATCH 00/10] cxgbe: Add flow director support

2016-03-22 Thread Bruce Richardson
On Wed, Feb 03, 2016 at 02:02:21PM +0530, Rahul Lakkireddy wrote: > This series of patches extend the flow director filter and add support > for Chelsio T5 hardware filtering capabilities. > > Chelsio T5 supports carrying out filtering in hardware which supports 3 > actions to carry out on a packe

[dpdk-dev] [PATCH] i40e: fix ipv6 TSO issue for tx function

2016-03-22 Thread Ananyev, Konstantin
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhe Tao > Sent: Tuesday, March 22, 2016 1:14 PM > To: dev at dpdk.org > Cc: Tao, Zhe > Subject: [dpdk-dev] [PATCH] i40e: fix ipv6 TSO issue for tx function > > Issue: > when using the following CLI in test

[dpdk-dev] multi-segment mbuf

2016-03-22 Thread Clarylin L
Sorry my bad. The mbuf size has been accidentally changed to 3000. After fixing this by setting mbuf size to 2048, multi-segment mbuf still doesn't work. I was trying to send 2500-byte packets to the target system and was expecting to see two-segment mbuf chain), but got errors on it. Tue Mar 22

[dpdk-dev] [dpdk-users] how to Read(Write) from(to) via lcores in dpdk regardless of NIC

2016-03-22 Thread Mahdi Moradmand Badie
Dear Andriy, I did my task with the help of rte_ring, but now I wanna replace rte_ring with real share cache(L3), May I ask you if there is any possibility in DPDK in order to do it. Thanks in advance, On 9 March 2016 at 05:26, Andriy Berestovskyy wrote: > Mahdi, > 1. Sure, the rte_ring is anoth

[dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help

2016-03-22 Thread Pablo de Lara
Previous cdev parameter was changed to cdev_type, to select a crypto device type preference (HW/SW/ANY), instead of the device itself (QAT/AESNI...). Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities") Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 2 +- 1 file

[dpdk-dev] [PATCH] l2fwd-crypto: add SNOW3G algorithms

2016-03-22 Thread Pablo de Lara
Since SNOW3G UEA2/UIA2 are supported now by both HW and SW, l2fwd-crypto may use them, extending the list of algorithms parsed from command line. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/l2fwd-crypto/main.c b

[dpdk-dev] Reg: promiscuous mode on VF

2016-03-22 Thread bharath paulraj
Thanks a lot Michael. Finally i am able to see some light. I will try the same in our setup and will post you the results. Thanks, Bharath On Tue, Mar 22, 2016 at 12:09 PM, Qiu, Michael wrote: > Yes, we could let ovs using 82599 VF to do rx/tx. I don't know what's > your l2 bridge, but since o

[dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization

2016-03-22 Thread Michael Frasca
If the provided configuration does not call for RSS, then RSS is explicitly disabled. Without this change, the device continues to operate under the previous RSS configuration. Fixes: 57033cdf8fdc ("fm10k: add PF RSS") Signed-off-by: Michael Frasca --- drivers/net/fm10k/fm10k_ethdev.c | 4 +++-

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process environment

2016-03-22 Thread Thomas Monjalon
Hi, Pablo, Sergio, please could you help with this issue? 2016-03-13 22:16, Dhana Eadala: > We found a problem in dpdk-2.2 using under multi-process environment. > Here is the brief description how we are using the dpdk: > > We have two processes proc1, proc2 using dpdk. These proc1 and proc2 ar

[dpdk-dev] [PATCH] eal/ppc: fix secondary process to map hugepages in correct order

2016-03-22 Thread Thomas Monjalon
Sergio, your help is required here. Thanks 2016-03-17 10:35, gowrishankar: > Could this patch be reviewed please. > > Thanks, > Gowrishankar > > On Monday 07 March 2016 07:43 PM, Gowrishankar wrote: > > From: Gowri Shankar > > > > For a secondary process address space to map hugepages from ever

[dpdk-dev] [PATCH v3 1/3] xen: Add UIO kernel driver

2016-03-22 Thread Thomas Monjalon
2016-03-22 12:04, Jan Blunck: > On Tue, Mar 22, 2016 at 11:42 AM, Thomas Monjalon > wrote: > > 2016-03-22 10:55, Jan Blunck: > >> New UIO helper kernel driver for Xen netfront UIO poll mode driver. > >> > >> Signed-off-by: Stephen Hemminger > >> Signed-off-by: Jan Blunck > > > > Is it contribute

[dpdk-dev] [PATCH] eal/ppc: fix secondary process to map hugepages in correct order

2016-03-22 Thread Sergio Gonzalez Monroy
On 22/03/2016 11:36, Thomas Monjalon wrote: > Sergio, your help is required here. I missed it with the /ppc tag. I'll get to it. Sergio > Thanks > > 2016-03-17 10:35, gowrishankar: >> Could this patch be reviewed please. >> >> Thanks, >> Gowrishankar >> >> On Monday 07 March 2016 07:43 PM, Gowri

[dpdk-dev] [PATCH v3 1/3] xen: Add UIO kernel driver

2016-03-22 Thread Jan Blunck
On Tue, Mar 22, 2016 at 11:42 AM, Thomas Monjalon wrote: > 2016-03-22 10:55, Jan Blunck: >> New UIO helper kernel driver for Xen netfront UIO poll mode driver. >> >> Signed-off-by: Stephen Hemminger >> Signed-off-by: Jan Blunck > > Is it contributed upstream? No. Haven't planed that yet. > Is

[dpdk-dev] [PATCH v13 2/2] vhost: Add VHOST PMD

2016-03-22 Thread Tetsuya Mukawa
On 2016/03/22 10:55, Tetsuya Mukawa wrote: > On 2016/03/22 0:40, Loftus, Ciara wrote: >>> + >>> +static void >>> +eth_dev_info(struct rte_eth_dev *dev, >>> +struct rte_eth_dev_info *dev_info) >>> +{ >>> + dev_info->driver_name = drivername; >>> + dev_info->max_mac_addrs = 1; >>> + dev

[dpdk-dev] [PATCH v3 2/3] xen: Add netfront poll mode driver

2016-03-22 Thread Jan Blunck
On Tue, Mar 22, 2016 at 11:07 AM, David Marchand wrote: > Hello, > > On Tue, Mar 22, 2016 at 10:55 AM, Jan Blunck wrote: >> +static struct eth_dev_ops xen_eth_dev_ops = { >> + /*dev*/ >> + .dev_configure= xen_dev_configure, >> + .dev_close= xen_dev_close, >>

[dpdk-dev] [PATCH v3 1/3] xen: Add UIO kernel driver

2016-03-22 Thread Thomas Monjalon
2016-03-22 10:55, Jan Blunck: > New UIO helper kernel driver for Xen netfront UIO poll mode driver. > > Signed-off-by: Stephen Hemminger > Signed-off-by: Jan Blunck Is it contributed upstream? Is there something common with igb_uio?

[dpdk-dev] [PATCH] mlx4: check if port is configured for Ethernet

2016-03-22 Thread Adrien Mazarguil
Notify user otherwise. A similar check has already been added to mlx5 in commit "mlx5: check port is configured as ethernet device". Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/m

[dpdk-dev] [PATCH v3 00/10] qede: Add qede PMD

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 11:21:25AM +, Richardson, Bruce wrote: > I've had a quick scan over this patchset, and as you've probably seen I've > made some public comments on it. General comments on the whole patchset are: > * Please run checkpatch on the patchset and clear up as many issues as yo

[dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter

2016-03-22 Thread Stephen Hemminger
On Tue, 22 Mar 2016 15:23:22 + "Tahhan, Maryam" wrote: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Thursday, March 17, 2016 4:41 PM > > To: Igor Ryzhov > > Cc: dev at dpdk.org; Tahhan, Maryam ; > > olivier.matz at 6wind.com > > Subject: Re: [dpdk-dev] [PATCH] et

[dpdk-dev] [PATCH v2 0/9] pci cleanup and blacklist rework

2016-03-22 Thread David Marchand
Hello Jan, On Wed, Mar 16, 2016 at 5:07 PM, Jan Viktorin wrote: > On Fri, 29 Jan 2016 15:49:04 +0100 > David Marchand wrote: > >> Before 2.2.0 release, while preparing for more changes in eal (and fixing >> a problem reported by Roger M. [1]), I came up with this (part of) patchset >> that trie

[dpdk-dev] [PATCH v3 10/10] qede: Enable PMD build

2016-03-22 Thread Bruce Richardson
On Fri, Mar 18, 2016 at 05:53:25PM -0700, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > Signed-off-by: Sony Chacko > --- > config/common_base| 14 ++ > drivers/net/Makefile |1 + > mk/rte.app.mk |2 ++ > scripts/test-build.sh

  1   2   >