[dpdk-dev] [PATCH v4 29/29] i40evf: use base driver defined interface

2016-03-06 Thread Helin Zhang
It removes the i40evf_set_mac_type() defined in PMD, and reuses i40e_set_mac_type() defined in base driver. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev_vf.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/n

[dpdk-dev] [PATCH v4 28/29] i40e: add base driver release info

2016-03-06 Thread Helin Zhang
It adds base driver release information such as release date, for better tracking in the future. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile index 033ee4a

[dpdk-dev] [PATCH v4 27/29] i40e: update structure and macro definitions

2016-03-06 Thread Helin Zhang
Several structures and macros are added or updated, such as 'struct i40e_aqc_get_link_status', 'struct i40e_aqc_run_phy_activity' and 'struct i40e_aqc_lldp_set_local_mib_resp'. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- doc/guides/rel_notes/release_16_04.rst | 9 +++ drivers/net

[dpdk-dev] [PATCH v4 26/29] i40e/base: add AQ thermal sensor control struct

2016-03-06 Thread Helin Zhang
It adds the new AQ command and struct for managing a thermal sensor. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/ba

[dpdk-dev] [PATCH v4 25/29] i40e/base: add a new Virtchnl offload

2016-03-06 Thread Helin Zhang
X722 supports Expanded version of TCP, UDP PCTYPES for RSS. Add a Virtchnl offload to support this. Without this patch VF drivers will not be able to support the correct PCTYPES for X722 and UDP flows will not fan out. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i

[dpdk-dev] [PATCH v4 24/29] i40e: expose some registers

2016-03-06 Thread Helin Zhang
This patch adds 7 new register definitions for programming the parser, flow director and RSS blocks in the HW. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_register.h | 48 +++ drivers/net/i40e/i40e_ethdev.c| 11 ++--

[dpdk-dev] [PATCH v4 23/29] i40e: use AQ rx control register read/write

2016-03-06 Thread Helin Zhang
RX control register read/write functions are added, as directly read/write may fail when under stress small traffic. After the adminq is ready, all rx control registers should be read/written by dedicated functions. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- doc/guides/rel_notes/relea

[dpdk-dev] [PATCH v4 22/29] i40e/base: coding style fixes

2016-03-06 Thread Helin Zhang
It adds coding style fixes. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) v4: - Reworded the commit logs. diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e

[dpdk-dev] [PATCH v4 21/29] i40e/base: save off VSI resource count

2016-03-06 Thread Helin Zhang
When updating a VSI, save off the number of allocated and unallocated VSIs as we do when adding a VSI. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 6 ++ 1 file changed, 6 insertions(+) v4: - Reworded the commit logs. diff --git a/drivers/net

[dpdk-dev] [PATCH v4 20/29] i40e/base: fix driver load failure

2016-03-06 Thread Helin Zhang
It fixes the driver load failure with linking with particular PHY types, as the amount of time it takes for the GLGEN_RSTAT_DEVSTATE to be set increases greatly on those PHY types, which can lead to a timeout. Fixes: 9aeefed05538 ("i40e/base: support ESS") Signed-off-by: Helin Zhang Acked-by: Ji

[dpdk-dev] [PATCH v4 19/29] i40e/base: apply promisc mode to Tx Traffic

2016-03-06 Thread Helin Zhang
In Multi-Function Mode (MFP) mode particularly when it sets the PF VSI in limited promiscuous, the HW switch was still mirroring the outgoing packets from other VSIs (VF/VMdq) onto the PF VSI. It sets a new bit to avoid above mirroring, and it is in limited promiscuous on the PF VSI in MFP which is

[dpdk-dev] [PATCH v4 18/29] i40e/base: add functions to blink led

2016-03-06 Thread Helin Zhang
This patch adds functions to blink led on devices using a new PHY since MAC registers used in other designs do not work in this device configuration. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c| 329 + drivers/net/

[dpdk-dev] [PATCH v4 17/29] i40e/base: implement new API function

2016-03-06 Thread Helin Zhang
Add the support code for calling the AdminQ API call aq_set_switch_config. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 12 drivers/net/i40e/base/i40e_common.c | 28 drivers/net/i40e/base/i40e_protot

[dpdk-dev] [PATCH v4 16/29] i40e: add VEB stat control

2016-03-06 Thread Helin Zhang
With the latest firmware, statistics gathering can now be enabled and disabled in the HW switch, so we need to add a parameter to allow the driver to set it as desired. At the same time, the L2 cloud filtering parameter has been removed as it was never used. Older drivers working with the newer fir

[dpdk-dev] [PATCH v4 15/29] i40e/base: support operating port mirroring rules

2016-03-06 Thread Helin Zhang
This patch implements necessary functions related to port mirroring features such as add/delete mirror rule, function to set promiscuous VLAN mode for VSI if mirror rule_type is "VLAN Mirroring". Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c| 162 +

[dpdk-dev] [PATCH v4 14/29] i40e/base: set shared bit for multicast filters

2016-03-06 Thread Helin Zhang
It adds the use of the new shared MAC filter bit for multicast and broadcast filters in order to make better use of the filters available from the device. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + drivers/net/i40e/base/i40e_common.c

[dpdk-dev] [PATCH v4 13/29] i40e/base: fix for PHY NVM interaction problem

2016-03-06 Thread Helin Zhang
This patch fixes a problem where the NVMUpdate Tool, when using the PHY NVM feature, gets bad data from the PHY because of contention on the MDIO interface from get phy capability calls from the driver during regular operations. The problem is fixed by adding a check if media is available before ca

[dpdk-dev] [PATCH v4 12/29] i40e/base: unify the capability function

2016-03-06 Thread Helin Zhang
The device capabilities were defined in two places, and neither had all the definitions. It really belongs with the AQ API definition, so this patch removes the other set of definitions and fills out the missing item. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i4

[dpdk-dev] [PATCH v4 11/29] i40e/base: fix up recent proxy bits for X722_SUPPORT

2016-03-06 Thread Helin Zhang
The recently added proxy opcodes should be available only with X722_SUPPORT, so move them into the #ifdef, and reorder these to be in numerical order with the rest of the opcodes. Several structs that were added are unnecessary, so they are removed here. Fixes: 788fc17b2dec ("i40e/base: support pr

[dpdk-dev] [PATCH v4 10/29] i40e/base: fix up recent wol bits for X722_SUPPORT

2016-03-06 Thread Helin Zhang
The recently added Wakeup On Line (WOL) opcodes should be available only with X722_SUPPORT, so move them into the #ifdef, and reorder these to be in numerical order with the rest of the opcodes. Several structs that were added are unnecessary, so they are removed here. Fixes: 3c89193a36fd ("i40e/b

[dpdk-dev] [PATCH v4 09/29] i40e: update device id

2016-03-06 Thread Helin Zhang
Add new Device ID's for backplane and QSFP+ adapters, and delete deprecated one for backplane. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 12 ++-- drivers/net/i40e/base/i40e_devids.h | 10 +- drivers/net/i40

[dpdk-dev] [PATCH v4 08/29] i40e/base: fix uncertain event descriptor issue

2016-03-06 Thread Helin Zhang
In one obscure corner case, it was possible to clear the NVM update wait flag when no update_done message was actually received. This patch cleans the event descriptor before use, and moves the opcode check to where it won't get done if there was no event to clean. Fixes: 8db9e2a1b232 ("i40e: base

[dpdk-dev] [PATCH v4 07/29] i40e/base: set aq count after memory allocation

2016-03-06 Thread Helin Zhang
The standard way to check if the AQ is enabled is to look at the count field. So it should only set this field after it has successfully allocated memory. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[dpdk-dev] [PATCH v4 06/29] i40e/base: fix missing check for stopped admin queue

2016-03-06 Thread Helin Zhang
It's possible that while waiting for the spinlock, another entity (that owns the spinlock) has shut down the admin queue. If it then attempts to use the queue, it will panic. It adds a check for this condition on the receive side. This matches an existing check on the send queue side. Fixes: 8db9e

[dpdk-dev] [PATCH v4 05/29] i40e/base: limit version check of DCB

2016-03-06 Thread Helin Zhang
XL710/X710 devices requires FW version checks to properly handle DCB configurations from the FW while other devices (e.g. X722) do not, so limit these checks to XL710/X710 only. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_dcb.c | 34 +-

[dpdk-dev] [PATCH v4 04/29] i40e/base: add X722 support on nvm read

2016-03-06 Thread Helin Zhang
In X722, NVM reads can't be done through SRCTL registers. And require AQ calls, which require grabbing the NVM lock. Unfortunately some paths need the lock to be acquired once and do a whole bunch of stuff and then release it. This patch creates an unsafe version of the read calls, so that it can b

[dpdk-dev] [PATCH v4 03/29] i40e/base: add hw flag for X722 register access

2016-03-06 Thread Helin Zhang
Instead of doing the MAC check, use a flag that gets set per MAC. This way there are less chances of user error and it can enable multiple MACs with the capability in a single place rather than cluttering the code with MAC checks. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net

[dpdk-dev] [PATCH v4 02/29] i40e/base: acquire NVM ownership before reading it

2016-03-06 Thread Helin Zhang
It needs to acquire the NVM ownership before issuing an AQ read to the X722 NVM otherwise it will get EBUSY from the firmware. Also it should be released when done. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_nvm.c | 35 +-- 1

[dpdk-dev] [PATCH v4 01/29] i40e/base: fix compilation warnings

2016-03-06 Thread Helin Zhang
It fixes compilation warnings. Fixes: bd6651c2d2d7 ("i40e/base: use bit shift macros") Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/base/i40e_lan_hmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) v4: - Reworded the commit logs. diff --git a/drivers/net

[dpdk-dev] [PATCH v4 00/29] i40e base driver update

2016-03-06 Thread Helin Zhang
i40e base driver is updated, to support new X722 device IDs, and use rx control AQ commands to read/write rx control registers. Of cause, fixes and enhancements are added as listed as below. v4: - Reworded the commit logs. - Reorganized patches, in order to put together the code changes of th

[dpdk-dev] [PATCH v2] doc: add doc for i40e pmd driver introduction

2016-03-06 Thread Thomas Monjalon
2016-02-23 09:23, Jingjing Wu: > A new doc "i40e.rst" is added to introduce i40e pmd driver. > > Signed-off-by: Jingjing Wu > --- > doc/guides/nics/i40e.rst | 368 > ++ > doc/guides/nics/index.rst | 1 + > 2 files changed, 369 insertions(+) > crea

[dpdk-dev] [PATCH v2] docs: add statistics read frequency to fm10k guide

2016-03-06 Thread Thomas Monjalon
2016-02-09 15:19, Harry van Haaren: > +suggested to read stats every 20 seconds, which will gaurantee the statistics typo: gaurantee > --- a/doc/guides/rel_notes/release_2_3.rst > +++ b/doc/guides/rel_notes/release_2_3.rst > @@ -31,6 +31,10 @@ Other > Known Issues > > > +* **FM10

[dpdk-dev] [PATCH v2] doc/nic: add ixgbe statistics on read frequency

2016-03-06 Thread Thomas Monjalon
2016-02-29 12:17, Harry van Haaren: > +cause registers on hardware to count to thier maxiumum value, and "stick" at typos: thier maxiumum There are other occurences below. I suggest a spell checker :)

[dpdk-dev] [PATCH v2] doc: Malicious Driver Detection not supported by ixgbe

2016-03-06 Thread Thomas Monjalon
2016-02-26 12:48, Wenzhuo Lu: > --- a/doc/guides/nics/ixgbe.rst > +++ b/doc/guides/nics/ixgbe.rst > @@ -147,6 +147,26 @@ The following MACROs are used for these three features: > > * ETH_TXQ_FLAGS_NOXSUMTCP > > +Malicious Driver Detection not Supported by ixgbe > +^^^

[dpdk-dev] [PATCH v2 4/7] vhost: do not use rte_memcpy for virtio_hdr copy

2016-03-06 Thread Stephen Hemminger
On Thu, 18 Feb 2016 21:49:09 +0800 Yuanhan Liu wrote: > +static inline void > +copy_virtio_net_hdr(struct vhost_virtqueue *vq, uint64_t desc_addr, > + struct virtio_net_hdr_mrg_rxbuf hdr) > +{ > + if (vq->vhost_hlen == sizeof(struct virtio_net_hdr_mrg_rxbuf)) { > +

[dpdk-dev] [PATCH v3] config: remove duplicate configuration information

2016-03-06 Thread Thomas Monjalon
2016-03-06 01:11, Ferruh Yigit: > On 3/4/2016 10:43 PM, Thomas Monjalon wrote: > > 2016-03-04 12:11, Keith Wiles: > >> In order to cleanup the configuration files some and reduce > >> the number of duplicate configuration information. Add a new > >> file called common_base which contains just about

[dpdk-dev] [PATCH] config: move Linux only config options from base to Linux config

2016-03-06 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- config/common_base | 38 -- config/common_linuxapp | 33 - 2 files changed, 32 insertions(+), 39 deletions(-) diff --git a/config/common_base b/config/common_base index 1af28c8..104a53d 100644

[dpdk-dev] [PATCH v3] config: remove duplicate configuration information

2016-03-06 Thread Ferruh Yigit
On 3/4/2016 10:43 PM, Thomas Monjalon wrote: > 2016-03-04 12:11, Keith Wiles: >> In order to cleanup the configuration files some and reduce >> the number of duplicate configuration information. Add a new >> file called common_base which contains just about all of the >> configuration lines in one

[dpdk-dev] [PATCH] doc/linux gsg: add gcc-multilib as package hint

2016-03-06 Thread Thomas Monjalon
> > When compiling for i686 targets compilation could fail if the 32bit libc6- > > dev package is not installed. The gcc-multilib packages is a meta-package > > that will pull in the necessary dependencies, making setup easier for > > beginners. > > > > Reported-by: Weichun Chen > > Signed-off-by