[dpdk-dev] [PATCH] i40evf: fix the issue of configuring rss key enable flags

2015-11-27 Thread Helin Zhang
It fixes the issue of not configuring rss key enable flags when there is no rss key available. Fixes: 647d1eaf758b ("i40evf: support AQ based RSS config") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) dif

[dpdk-dev] [PATCH 1/2 v2] examples/distributor: Fix compile issue

2015-11-27 Thread Thomas Monjalon
> > examples/distributor/main.c(338): error #167: > > argument of type "struct rte_mbuf *" > > is incompatible with parameter of type "const char *" > > _mm_prefetch(bufs[0], 0); > > > > The first param pass to _mm_prefetch is wrong, > > need convert "struct rte_mbuf *" to "voi

[dpdk-dev] [PATCH 7/7] mk: Add hierarchy-file support (linux mod)

2015-11-27 Thread Arevalo, Mario Alfredo C
Hi ferruh, thank you for your comments in this serie of patches :) , I have been working on different new patches version in order to improve them according to feedback from different developers, at this moment I have sent the version 6 I would like to know your point of view and the point of view

[dpdk-dev] [PATCH v2] fm10k: add debug info for actual Rx/Tx func

2015-11-27 Thread Thomas Monjalon
2015-11-27 09:54, Chen Jing D: > From: "Chen Jing D(Mark)" > > After introducing vPMD feature, fm10k driver will select best > Rx/Tx in running time. Original implementation selects Rx/Tx > silently without notifications. > > This patch adds debug info to notify user what actual Rx/Tx > func are

[dpdk-dev] [PATCH] fm10k: fix wrong Rx func is used

2015-11-27 Thread Thomas Monjalon
2015-11-27 09:55, Chen Jing D: > From: "Chen Jing D(Mark)" > > Steps to reproduce the bug: > 1. All Rx offloading is disabled and start the device, then >Vector Rx is used. > 2. Stop the device. Re-configure to enable hw_ip_checksum = 1, >start the device again. > 3. In this case, assume

[dpdk-dev] [PATCH] e1000: fix VF mac address issue

2015-11-27 Thread Thomas Monjalon
2015-11-27 14:07, Wenzhuo Lu: > If use DPDK PF + DPDK VF on igb NICs, we find the MAC address of VF > port is always 0. Because we forget to give it a value if this MAC > address is not assigned by PF. This patch'll assign a random MAC > address to igb VF port as ixgbe does. > > Signed-off-by: Wen

[dpdk-dev] [PATCH] i40evf: fix the issue of configuring rss key enable flags

2015-11-27 Thread Thomas Monjalon
2015-11-27 23:34, Helin Zhang: > It fixes the issue of not configuring rss key enable flags > when there is no rss key available. > > Fixes: 647d1eaf758b ("i40evf: support AQ based RSS config") > > Signed-off-by: Helin Zhang Applied, thanks

[dpdk-dev] [PATCH v3 1/2] app/test: fix failures in the ring_pmd_autotest program

2015-11-27 Thread Thomas Monjalon
2015-11-27 16:40, Iremonger, Bernard: > Will correct in v4. Bernard, please use --in-reply-to '<1448640460-25249-1-git-send-email-bernard.iremonger at intel.com>'. It will thread the v4 below the v3. Thanks

[dpdk-dev] [PATCH] cryptodev: fixes for gcc 4.4.7 build issues

2015-11-27 Thread Thomas Monjalon
2015-11-27 17:44, Declan Doherty: > - Fix for build error caused by flexible array member in struct > rte_ccryptodev_session. error: flexible array member in otherwise empty struct > - Change void** casting of sess parameter in rte_cryptodev_session_create > which > causes a strict-aliasing err

[dpdk-dev] [PATCH v3 2/2] config: disable CONFIG_RTE_SCHED_VECTOR for arm

2015-11-27 Thread Jerin Jacob
Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR does support only SSE intrinsic, so disable it till we have neon support. Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config") Signed-off-by: Jerin Jacob --- config/common_arm64 | 1 + confi

[dpdk-dev] [PATCH v3 1/2] config: arm64: create common arm64 configs under common_arm64 file

2015-11-27 Thread Jerin Jacob
let each armv8 machine targets capture only the differences between the common arm64 config. Suggested-by: Thomas Monjalon Signed-off-by: Jerin Jacob --- config/common_arm64 | 48 config/defconfig_arm64-armv8a-linuxapp-gcc | 18 +

[dpdk-dev] [PATCH v3 0/2] disable CONFIG_RTE_SCHED_VECTOR for arm

2015-11-27 Thread Jerin Jacob
v1..v2 created common arm64 configs under common_arm64 file. let each armv8 machine targets capture only the differences between the common arm64 config. v2..v3 Fix whitespace issue with git am Jerin Jacob (2): config: arm64: create common arm64 configs under common_arm64 file config: disab

[dpdk-dev] [PATCH] reserve 'make install' for future use

2015-11-27 Thread Thomas Monjalon
2015-11-25 10:48, Panu Matilainen: > On 11/24/2015 06:54 PM, Bruce Richardson wrote: > > On Fri, Nov 06, 2015 at 02:04:54PM +0100, Thomas Monjalon wrote: > >> 2015-11-06 12:57, Bruce Richardson: > >>> So, any thoughts or comments on this? There has been lots of discussion > >>> in this > >>> gener

[dpdk-dev] [PATCH v2 2/2] config: disable CONFIG_RTE_SCHED_VECTOR for arm

2015-11-27 Thread Jerin Jacob
Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR does support only SSE intrinsic, so disable it till we have neon support. Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config") Signed-off-by: Jerin Jacob --- config/common_arm64 | 1 + confi

[dpdk-dev] [PATCH v2 1/2] config: arm64: create common arm64 configs under common_arm64 file

2015-11-27 Thread Jerin Jacob
let each armv8 machine targets capture only the differences between the common arm64 config. Suggested-by: Thomas Monjalon Signed-off-by: Jerin Jacob --- config/common_arm64 | 49 config/defconfig_arm64-armv8a-linuxapp-gcc | 17 +---

[dpdk-dev] [PATCH v2 0/2] disable CONFIG_RTE_SCHED_VECTOR for arm

2015-11-27 Thread Jerin Jacob
v1..v2 created common arm64 configs under common_arm64 file. let each armv8 machine targets capture only the differences between the common arm64 config. Jerin Jacob (2): config: arm64: create common arm64 configs under common_arm64 file config: disable CONFIG_RTE_SCHED_VECTOR for arm conf

[dpdk-dev] [PATCH] cryptodev: fixes for gcc 4.4.7 build issues

2015-11-27 Thread Declan Doherty
- Fix for build error caused by flexible array member in struct rte_ccryptodev_session. - Change void** casting of sess parameter in rte_cryptodev_session_create which causes a strict-aliasing error Signed-off-by: Declan Doherty --- lib/librte_cryptodev/rte_cryptodev.c | 7 +-- lib/libr

[dpdk-dev] [PATCH 7/7] mk: Add hierarchy-file support (linux mod)

2015-11-27 Thread David Marchand
On Fri, Nov 27, 2015 at 5:01 PM, Ferruh Yigit wrote: > As far as I know only "?=" assignment overridden by command line. > > Basic experiment: > > # cat Makefile > A ?= a > B := b > C = c > > all: > @echo $(A) $(B) $(C) > > - > > # make > a b c > > # A=x B=x C=x make > x b c > Those

[dpdk-dev] [PATCH v3 6/8] mk: Add rule for installing nic bind files

2015-11-27 Thread Thomas Monjalon
2015-10-02 10:54, Richardson, Bruce: > I think there are better utilities available for determining the core layout > that cpu_layout.py. "lstopo", for one, is much more powerful. Do we want/need > to keep our own script around for that? Good question. Anyone against dropping cpu_layout.py?

[dpdk-dev] [PATCH 7/7] mk: Add hierarchy-file support (linux mod)

2015-11-27 Thread Ferruh Yigit
On Fri, Nov 27, 2015 at 04:23:07PM +, Bruce Richardson wrote: > On Fri, Nov 27, 2015 at 05:20:43PM +0100, David Marchand wrote: > > On Fri, Nov 27, 2015 at 5:01 PM, Ferruh Yigit > > wrote: > > > > > As far as I know only "?=" assignment overridden by command line. > > > > > > Basic experiment

[dpdk-dev] [PATCH 7/7] mk: Add hierarchy-file support (linux mod)

2015-11-27 Thread Thomas Monjalon
2015-09-22 09:56, Panu Matilainen: > On 09/18/2015 11:33 PM, Mario Carrillo wrote: > > +MOD_DIR := $(DESTDIR)/lib/modules > > +KERNEL_DIR := $(shell uname -r)/extra > > Please don't assume one is always building for the running kernel. > Defaulting around uname -r is perfectly reasonable, but the

[dpdk-dev] [PATCH v3 1/2] app/test: fix failures in the ring_pmd_autotest program

2015-11-27 Thread Iremonger, Bernard
Hi Bruce, > Subject: Re: [dpdk-dev] [PATCH v3 1/2] app/test: fix failures in the > ring_pmd_autotest program > > On Fri, Nov 27, 2015 at 04:07:39PM +, Bernard Iremonger wrote: > > If eth_ring vdevs are created from the command line with the --vdev > > option, they create there own rings whic

[dpdk-dev] [PATCH 7/7] mk: Add hierarchy-file support (linux mod)

2015-11-27 Thread Bruce Richardson
On Fri, Nov 27, 2015 at 05:20:43PM +0100, David Marchand wrote: > On Fri, Nov 27, 2015 at 5:01 PM, Ferruh Yigit > wrote: > > > As far as I know only "?=" assignment overridden by command line. > > > > Basic experiment: > > > > # cat Makefile > > A ?= a > > B := b > > C = c > > > > all: > >

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Ananyev, Konstantin
> -Original Message- > From: Qiu, Michael > Sent: Friday, November 27, 2015 3:22 PM > To: Ananyev, Konstantin > Cc: Thomas Monjalon; dev at dpdk.org > Subject: Re: [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4 > > Sorry for not explaining clearly. > > For gcc version start from v

[dpdk-dev] [PATCH] config: disable CONFIG_RTE_SCHED_VECTOR for arm

2015-11-27 Thread Jerin Jacob
On Fri, Nov 27, 2015 at 11:23:01AM +0100, Thomas Monjalon wrote: > Hi Jerin, > > 2015-11-27 15:23, Jerin Jacob: > > Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR > > does support only SSE intrinsic, so disable it till we have neon support. > > > > Fixes: 42ec27a0178a ("sc

[dpdk-dev] [PATCH v3 2/2] doc: correct Rings-based PMD section in the NIC Drivers guides

2015-11-27 Thread Bruce Richardson
On Fri, Nov 27, 2015 at 04:07:40PM +, Bernard Iremonger wrote: > Correct the sample code in the pcap_ring.rst file to match the latest > rte_eth_ring.c code. > > The parameters to the rte_eth_from_rings() function have changed since > the documentation was written. > The API change occurred be

[dpdk-dev] [PATCH v3 1/2] app/test: fix failures in the ring_pmd_autotest program

2015-11-27 Thread Bruce Richardson
On Fri, Nov 27, 2015 at 04:07:39PM +, Bernard Iremonger wrote: > If eth_ring vdevs are created from the command line with the --vdev option, > they create there own rings which are not shared by other vdevs. Typo: s/their/there/ > Some of tests in this suite require that the vdevs share rings

[dpdk-dev] [PATCH v3 6/8] mk: Add rule for installing nic bind files

2015-11-27 Thread Bruce Richardson
On Fri, Nov 27, 2015 at 04:52:11PM +0100, Thomas Monjalon wrote: > 2015-10-02 10:54, Richardson, Bruce: > > I think there are better utilities available for determining the core layout > > that cpu_layout.py. "lstopo", for one, is much more powerful. Do we > > want/need > > to keep our own script

[dpdk-dev] [PATCH v3 2/2] doc: correct Rings-based PMD section in the NIC Drivers guides

2015-11-27 Thread Bernard Iremonger
Correct the sample code in the pcap_ring.rst file to match the latest rte_eth_ring.c code. The parameters to the rte_eth_from_rings() function have changed since the documentation was written. The API change occurred before DPDK 1.8 when the rst files were added. The original documentation on whic

[dpdk-dev] [PATCH v3 1/2] app/test: fix failures in the ring_pmd_autotest program

2015-11-27 Thread Bernard Iremonger
If eth_ring vdevs are created from the command line with the --vdev option, they create there own rings which are not shared by other vdevs. Some of tests in this suite require that the vdevs share rings, so some of the tests fail. For vdevs to share rings they must be created in the test code wit

[dpdk-dev] [PATCH v3 0/2] ring pmd autotest

2015-11-27 Thread Bernard Iremonger
Fix failures in the ring_pmd_autotest program. Correct errors in the ring PMD documentation. Changes in v3: rebase to latest code. revicse commit messages. Changes in v2: move doc changes to a seperate patch. Bernard Iremonger (2): app/test: fix failures in the ring_pmd_autotest program doc:

[dpdk-dev] [PATCH 7/7] mk: Add hierarchy-file support (linux mod)

2015-11-27 Thread Ferruh Yigit
On Fri, Nov 27, 2015 at 04:40:51PM +0100, Thomas Monjalon wrote: > 2015-09-22 09:56, Panu Matilainen: > > On 09/18/2015 11:33 PM, Mario Carrillo wrote: > > > +MOD_DIR := $(DESTDIR)/lib/modules > > > +KERNEL_DIR := $(shell uname -r)/extra > > > > Please don't assume one is always building for the r

[dpdk-dev] [PATCH] example/ip_pipeline: fix resource leak problem.

2015-11-27 Thread Fan Zhang
This patch fix the following Coverity issue: Coverity issue: 120147 Fixes: 7122d30131ad ("examples/ip_pipeline: rework flow classification pipeline") Signed-off-by: Fan Zhang --- .../pipeline/pipeline_flow_classification_be.c | 31 +- 1 file changed, 19 insertions(+), 12

[dpdk-dev] [PATCH v3 0/2] disable CONFIG_RTE_SCHED_VECTOR for arm

2015-11-27 Thread Thomas Monjalon
2015-11-27 15:40, Jan Viktorin: > Hello, > > this what I was talking about at the Userspace Summit in Dublin... > Somebody adds a feature or change a default setting and it breaks > builds of other configurations and platforms. The current build system > in DPDK is really imperfect. The issue is

[dpdk-dev] [PATCH v3 0/2] disable CONFIG_RTE_SCHED_VECTOR for arm

2015-11-27 Thread Jan Viktorin
Hello, this what I was talking about at the Userspace Summit in Dublin... Somebody adds a feature or change a default setting and it breaks builds of other configurations and platforms. The current build system in DPDK is really imperfect. Thanks for catching this! Regards Jan V. On Fri, 27 Nov

[dpdk-dev] [PATCH v3 2/2] config: disable CONFIG_RTE_SCHED_VECTOR for arm

2015-11-27 Thread Jan Viktorin
Acked-By: Jan Viktorin On Fri, 27 Nov 2015 19:04:28 +0530 Jerin Jacob wrote: > Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR > does support only SSE intrinsic, so disable it till we have neon support. > > Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config"

[dpdk-dev] [PATCH] maintainers: claim responsability for various sample apps

2015-11-27 Thread Thomas Monjalon
2015-11-27 14:14, Pablo de Lara: > Co-maintain helloworld, l2fwd and dpdk-qat sample apps. Naive question: what is the benefit of dpdk-qat compared to l2fwd-crypto? Is it something we can drop?

[dpdk-dev] [PATCH] config: disable CONFIG_RTE_SCHED_VECTOR for arm

2015-11-27 Thread Jerin Jacob
Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR does support only SSE intrinsic, so disable it till we have neon support. Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config") Signed-off-by: Jerin Jacob --- config/defconfig_arm-armv7a-linuxapp-gcc | 1 + c

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Qiu, Michael
Sorry for not explaining clearly. For gcc version start from version 4.4, x86intrin.h will be include, and inside x86intrin.h, immintrin.h will be directly include without check AVX (as I know, AVX is not exist when gcc >= 4.4),so no AVX macro does not mean vector disable. Only gcc < 4.4 and n

[dpdk-dev] [PATCH] cryptodev: mark experimental state

2015-11-27 Thread Panu Matilainen
On 11/26/2015 03:51 PM, Doherty, Declan wrote: >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: Thursday, November 26, 2015 10:09 AM >> To: Panu Matilainen; Doherty, Declan >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] cryptodev: mark

[dpdk-dev] [PATCH] maintainers: claim responsability for various sample apps

2015-11-27 Thread Declan Doherty
On 27/11/15 14:31, Thomas Monjalon wrote: > 2015-11-27 14:14, Pablo de Lara: >> Co-maintain helloworld, l2fwd and dpdk-qat sample apps. > > Naive question: what is the benefit of dpdk-qat compared to l2fwd-crypto? > Is it something we can drop? > So the dpdk-qat sample application is a sample of h

[dpdk-dev] [PATCH v2] scripts: add git hook scripts for checkpatch and auto doc generation

2015-11-27 Thread Ferruh Yigit
These scripts are to automate some common tasks, scripts needs to be deployed to specific folder to become active. Scripts: post-commit: Triggers after commit complete, re-generates api and guides html documents. "RTE_DOC_OUT" environment variable configures document output folder. Same script can

[dpdk-dev] [PATCH] maintainers: claim responsability for various sample apps

2015-11-27 Thread Bruce Richardson
On Fri, Nov 27, 2015 at 02:14:04PM +, Pablo de Lara wrote: > Co-maintain helloworld, l2fwd and dpdk-qat sample apps. > > Signed-off-by: Pablo de Lara > --- > MAINTAINERS | 3 +++ > 1 file changed, 3 insertions(+) > Thanks Pablo. While these aren't a huge deal of work to maintain, it's good t

[dpdk-dev] [PATCH] cryptodev: mark experimental state

2015-11-27 Thread Thomas Monjalon
2015-11-27 15:09, Panu Matilainen: > On 11/26/2015 03:51 PM, Doherty, Declan wrote: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > >> 2015-11-26 10:00, Panu Matilainen: > >>> On 11/26/2015 09:39 AM, Panu Matilainen wrote: > I think an experimental library which declares itse

[dpdk-dev] FW: OVS with DPDK Meetup notes

2015-11-27 Thread Mcnamara, John
Cross posting this from users at dpdk.org to get great visibility. > -Original Message- > From: dev [mailto:dev-bounces at openvswitch.org] On Behalf Of Traynor, Kevin > Sent: Thursday, November 26, 2015 5:56 PM > To: dev at openvswitch.org > Cc: users at dpdk.org > Subject: [ovs-dev] OVS

[dpdk-dev] dpdk proposal installation process

2015-11-27 Thread Marc
On 22 October 2015 at 16:57, Bruce Richardson wrote: > On Thu, Oct 22, 2015 at 08:55:41AM +0300, Panu Matilainen wrote: > > On 10/21/2015 10:15 PM, Olivier MATZ wrote: > > >Hi Mario, > > > > > >On 10/20/2015 11:17 AM, Bruce Richardson wrote: > > >>On Tue, Oct 20, 2015 at 12:21:00AM +, Arevalo

[dpdk-dev] [PATCH] maintainers: claim responsability for various sample apps

2015-11-27 Thread Pablo de Lara
Co-maintain helloworld, l2fwd and dpdk-qat sample apps. Signed-off-by: Pablo de Lara --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4478862..6e0bb53 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -509,6 +509,7 @@ Other Example Applications

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Ananyev, Konstantin
> -Original Message- > From: Qiu, Michael > Sent: Friday, November 27, 2015 2:02 PM > To: Ananyev, Konstantin > Cc: Thomas Monjalon; dev at dpdk.org > Subject: Re: [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4 > > I just replied that Marco AVX only exist in gcc version < 4.4 , oth

[dpdk-dev] [PATCH] e1000: fix VF mac address issue

2015-11-27 Thread Wenzhuo Lu
If use DPDK PF + DPDK VF on igb NICs, we find the MAC address of VF port is always 0. Because we forget to give it a value if this MAC address is not assigned by PF. This patch'll assign a random MAC address to igb VF port as ixgbe does. Signed-off-by: Wenzhuo Lu --- drivers/net/e1000/igb_ethdev

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Qiu, Michael
I just replied that Marco AVX only exist in gcc version < 4.4 , otherwise it will not exist. What's your suggest will not work if gcc version greater than 4.3. So still need to check gcc version. Any other solution? Thanks, Michael > ? 2015?11?278:34?Ananyev, Konstantin ??? > > >> -

[dpdk-dev] [PATCH 2/2] virtio: remove unnecessary rx_mbuf_alloc_failed counter clearing

2015-11-27 Thread Igor Ryzhov
This counter is cleared in rte_eth_stats_reset. Signed-off-by: Igor Ryzhov --- drivers/net/virtio/virtio_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 74c00ee..f5b72a3 100644 --- a/drivers/net/virtio/v

[dpdk-dev] [PATCH 1/2] ethdev: clear rx_mbuf_alloc_failed counter on rte_eth_stats_reset

2015-11-27 Thread Igor Ryzhov
--- lib/librte_ether/rte_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 3840775..41f5f0b 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -1456,6 +1456,7 @@ rte_eth_stats_reset(uint8_

[dpdk-dev] [PATCH 0/2] Clear rx_mbuf_alloc_failed counter on rte_eth_stats_reset

2015-11-27 Thread Igor Ryzhov
The rx_mbuf_alloc_failed counter was only cleared by virtio driver. Now it is cleared by common rte_eth_stats_clear function for all drivers at once. Igor Ryzhov (2): ethdev: clear rx_mbuf_alloc_failed counter on rte_eth_stats_reset virtio: remove unnecessary rx_mbuf_alloc_failed counter clea

[dpdk-dev] dpdk proposal installation process

2015-11-27 Thread Thomas Monjalon
2015-10-26 16:18, Arevalo, Mario Alfredo C: > Hi Guys, > > Thank you so much for your feedback, about your last comments, > I understood the next: > > 1) > -"make install" using "T" variable: > This command will use a rule for the current behaviour called "mbuild" I think the ability of building

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael > Sent: Friday, November 27, 2015 11:53 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4 > > really?I don't think so. >

[dpdk-dev] [PATCH] app/test: fix kni test always failed

2015-11-27 Thread Yong Liu
After all test functions called, return value should be reset to sucessful. Signed-off-by: Marvin Liu diff --git a/app/test/test_kni.c b/app/test/test_kni.c index 9dad988..329acb2 100644 --- a/app/test/test_kni.c +++ b/app/test/test_kni.c @@ -626,6 +626,7 @@ test_kni(void) goto f

[dpdk-dev] [PATCH 1/2 v2] examples/distributor: Fix compile issue

2015-11-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Qiu, Michael > Sent: Friday, November 27, 2015 3:36 AM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo; thomas.monjalon at 6wind.com; Qiu, Michael > Subject: [PATCH 1/2 v2] examples/distributor: Fix compile issue > > examples/distributor/main.c(338): error

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Qiu, Michael
really?I don't think so. AVX Marco only exist in the gcc version below 4.4, I still need to check if below or beyond 4.4 am I right? Thanks, Michael > ? 2015?11?275:01?Thomas Monjalon ??? > > 2015-11-27 02:26, Qiu, Michael: >>> On 2015/11/27 5:29, Thomas Monjalon wrote: >>> 2015-11-26 1

[dpdk-dev] [PATCH 2/2 v2] Fix compile issue in i686 platform

2015-11-27 Thread Michael Qiu
In i686 platform, long is 32bit, so XXX_CYCLECOUNTER_MASK need define as 'ULL' Fixes: 9c857bf6be87 ("igb: support ieee1588 functions for device time") Fixes: 1c4445e1f28e ("ixgbe: support ieee1588 functions for device time") Fixes: f3a4e40eca0c ("i40e: support ieee1588 functions for device time")

[dpdk-dev] [PATCH 1/2 v2] examples/distributor: Fix compile issue

2015-11-27 Thread Michael Qiu
examples/distributor/main.c(338): error #167: argument of type "struct rte_mbuf *" is incompatible with parameter of type "const char *" _mm_prefetch(bufs[0], 0); The first param pass to _mm_prefetch is wrong, need convert "struct rte_mbuf *" to "void *". Fixes: 07db4a9750

[dpdk-dev] [PATCH] config: disable CONFIG_RTE_SCHED_VECTOR for arm

2015-11-27 Thread Thomas Monjalon
Hi Jerin, 2015-11-27 15:23, Jerin Jacob: > Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR > does support only SSE intrinsic, so disable it till we have neon support. > > Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config") > > Signed-off-by: Jerin Jacob > --

[dpdk-dev] [PATCH] distributor: fix compilation on icc 2015

2015-11-27 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, November 27, 2015 10:10 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org; Qiu, Michael > Subject: Re: [dpdk-dev] [PATCH] distributor: fix compilation on icc 2015 > > 2015-11-2

[dpdk-dev] [PATCH v9 1/9] nfp: basic initialization

2015-11-27 Thread Thomas Monjalon
2015-11-27 07:51, Alejandro Lucero: > I converted (almost) all the Linux typedefs. This one went under the radar. > > We do not have such thing like ixgbe/base but maybe it makes sense. > > Should I send a new patchset version for fixing this "minor nit"? If you send a new version, please fix th

[dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function.

2015-11-27 Thread Yu Nemo Wenbin
Give user a chance to customize the hash key compare function. The default rte_hash_cmp_eq function is set in the rte_hash_create function, but these builtin ones may not be good enough, so the user may call this to override the default one. Signed-off-by: Yu Nemo Wenbin --- lib/librte_hash/rte_

[dpdk-dev] [PATCH 2/2 v2] Fix compile issue in i686 platform

2015-11-27 Thread Thomas Monjalon
2015-11-27 11:36, Michael Qiu: > In i686 platform, long is 32bit, so XXX_CYCLECOUNTER_MASK > need define as 'ULL' Michael, it is the same comment as the first patch. How your compiler is different of mine which compiles fine without this patch? I'm using GCC 5.2.0.

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Thomas Monjalon
2015-11-27 02:26, Qiu, Michael: > On 2015/11/27 5:29, Thomas Monjalon wrote: > > 2015-11-26 18:49, Michael Qiu: > >> gcc 4.3.4 does not include "immintrin.h", and will post below error: > >> lib/librte_sched/rte_sched.c:56:23: error: > >> immintrin.h: No such file or directory > >> > >> To

[dpdk-dev] [PATCH] fm10k: fix wrong Rx func is used

2015-11-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Steps to reproduce the bug: 1. All Rx offloading is disabled and start the device, then Vector Rx is used. 2. Stop the device. Re-configure to enable hw_ip_checksum = 1, start the device again. 3. In this case, assume regular Rx should be used since Vector Rx do

[dpdk-dev] [PATCH v2] fm10k: add debug info for actual Rx/Tx func

2015-11-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" After introducing vPMD feature, fm10k driver will select best Rx/Tx in running time. Original implementation selects Rx/Tx silently without notifications. This patch adds debug info to notify user what actual Rx/Tx func are used. Signed-off-by: Chen Jing D(Mark) ---

[dpdk-dev] [PATCH] distributor: fix compilation on icc 2015

2015-11-27 Thread Pablo de Lara
Fix following error on icc 2015: CC main.o /tmp/dpdk-tmp3/examples/distributor/main.c(338): error #167: argument of type "struct rte_mbuf *" is incompatible with parameter of type "const char *" _mm_prefetch(bufs[0], 0); Fixes: 07db4a97 ("examples/distributor: new sample app") Repo

[dpdk-dev] [PATCH v9 1/9] nfp: basic initialization

2015-11-27 Thread Alejandro Lucero
I converted (almost) all the Linux typedefs. This one went under the radar. We do not have such thing like ixgbe/base but maybe it makes sense. Should I send a new patchset version for fixing this "minor nit"? Thanks On Thu, Nov 26, 2015 at 6:14 PM, Stephen Hemminger < stephen at networkplumber

[dpdk-dev] [PATCH v6 0/8] virtio ring layout optimization and simple rx/tx processing

2015-11-27 Thread Xu, Qian Q
Some virtio-pmd optimization performance data sharing: 1. Use simplified vhost-sample, only doing the dequeuer and free, so virtio only tx, then test the virtio tx performance improvement. Then in the VM, using one virtio to do the txonly, and let the virtio tx working. Also modified the txonly

[dpdk-dev] [PATCH] fm10k: fix wrong Rx func is used

2015-11-27 Thread Wang, Xiao W
Hi, > -Original Message- > From: Chen, Jing D > Sent: Friday, November 27, 2015 9:56 AM > To: dev at dpdk.org > Cc: Wang, Xiao W ; Chen, Jing D > > Subject: [PATCH] fm10k: fix wrong Rx func is used > > From: "Chen Jing D(Mark)" > > Steps to reproduce the bug: > 1. All Rx offloading is

[dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4

2015-11-27 Thread Qiu, Michael
On 2015/11/27 5:29, Thomas Monjalon wrote: > 2015-11-26 18:49, Michael Qiu: >> gcc 4.3.4 does not include "immintrin.h", and will post below error: >> lib/librte_sched/rte_sched.c:56:23: error: >> immintrin.h: No such file or directory >> >> To avoid this issue, a gcc version check is need

[dpdk-dev] [PATCH] distributor: fix compilation on icc 2015

2015-11-27 Thread Thomas Monjalon
2015-11-27 09:49, Pablo de Lara: > Fix following error on icc 2015: > > CC main.o > /tmp/dpdk-tmp3/examples/distributor/main.c(338): error #167: > argument of type "struct rte_mbuf *" is incompatible with > parameter of type "const char *" > _mm_prefetch(bufs[0], 0); > > Fixes: 07db

[dpdk-dev] [PATCH 2/2] Fix compile issue in i686 platform

2015-11-27 Thread Qiu, Michael
On 2015/11/27 5:15, Thomas Monjalon wrote: > 2015-11-26 09:35, Michael Qiu: >> In i686 platform, long is 32bit, so XXX_CYCLECOUNTER_MASK >> need define as 'ULL' >> >> Signed-off-by: Michael Qiu > This patch is correct but the description is not exact: > I have no issue with my i686 compiler. > For

[dpdk-dev] [PATCH 1/2] examples/distributor: Fix compile issue

2015-11-27 Thread Wan, Qun
Acked and verified. -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michael Qiu Sent: Thursday, November 26, 2015 9:35 AM To: dev at dpdk.org Subject: [dpdk-dev] [PATCH 1/2] examples/distributor: Fix compile issue examples/distributor/main.c(338): error #167: argum