[dpdk-dev] difficulty w/ RTE_NEXT_ABI

2015-11-22 Thread Matthew Hall
On Mon, Nov 23, 2015 at 01:13:32AM +0100, Thomas Monjalon wrote: > If your change is sent upstream, you must rely on the new ABI because the old > one > will be removed when your change will be integrated. > If it is a local change, it depends on which ABI you want to use. I submitted separately

[dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

2015-11-22 Thread Stephen Hemminger
On Mon, 23 Nov 2015 05:05:21 + "Xie, Huawei" wrote: > On 11/23/2015 12:07 PM, Stephen Hemminger wrote: > > On Mon, 23 Nov 2015 03:46:31 + > > "Xie, Huawei" wrote: > > > >>> Why cannot we rely on the kernel zeroing the memory ? > >>> If that behavior were to change, then we can zero out t

[dpdk-dev] difficulty w/ RTE_NEXT_ABI

2015-11-22 Thread Thomas Monjalon
2015-11-21 19:25, Matthew Hall: > On Sat, Nov 21, 2015 at 11:44:20AM +0100, Thomas Monjalon wrote: > > The new mbuf provides packet type instead of flags. > > So the processing in this function is changed and the variable name is > > different to reflect this. > > But the data type of the variable

[dpdk-dev] [PATCH] pktgen-stats.c: remove stats deprecated upstream

2015-11-22 Thread Matthew Hall
Signed-off-by: Matthew Hall --- app/pktgen-stats.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/app/pktgen-stats.c b/app/pktgen-stats.c index f1de4d7..f552ac2 100644 --- a/app/pktgen-stats.c +++ b/app/pktgen-stats.c @@ -305,8 +305,6 @@ pktgen_page_stats(void) pktgen.cu

[dpdk-dev] [PATCH v3] i40e: fix BW info update if no dcb enabled

2015-11-22 Thread Jingjing Wu
If DCB is not enabled, the BW info is not stored for VSI. This patch fixes this issue by merging functions i40e_vsi_dump_bw_config and i40e_vsi_get_bw_info together. Fixes: c8b9a3e3fe1b (i40e: support DCB mode) Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 116 +---

[dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

2015-11-22 Thread Stephen Hemminger
On Mon, 23 Nov 2015 03:46:31 + "Xie, Huawei" wrote: > > > > Why cannot we rely on the kernel zeroing the memory ? > > If that behavior were to change, then we can zero out the memory > > ourselves. > It is undocumented kernel behavior. My opinion is if not a big burden, > zero out the neede

[dpdk-dev] [PATCH v2] i40e: fix BW info update if no dcb enabled

2015-11-22 Thread Jingjing Wu
If DCB is not enabled, the BW info is not stored for VSI. This patch fixes this issue by merging functions i40e_vsi_dump_bw_config and i40e_vsi_get_bw_info together. Fixes: c8b9a3e3fe1b (i40e: support DCB mode) Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 112 +---

[dpdk-dev] missing __rte_deprecated on rte_eth_stats.imcasts ?

2015-11-22 Thread Matthew Hall
I was reading through the deprecations in rte_eth_stats to see if I could fix the pktgen. Of course many fields were marked with __rte_deprecated . However I found this one field which said deprecated in its comment, but it lacked __rte_deprecated . Is the comment wrong, or is the field definit

[dpdk-dev] [PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

2015-11-22 Thread Stephen Hemminger
On Sun, 22 Nov 2015 14:13:35 -0500 Zhihong Wang wrote: > The kernel fills new allocated (huge) pages with zeros. > DPDK just has to populate page tables to trigger the allocation. > > Signed-off-by: Zhihong Wang > --- > lib/librte_eal/linuxapp/eal/eal_memory.c | 20 ++-- > 1 fi

[dpdk-dev] difficulty w/ RTE_NEXT_ABI

2015-11-22 Thread Matthew Hall
On Sun, Nov 22, 2015 at 09:59:30PM +0100, Thomas Monjalon wrote: > > So again I am confused what advantage we got from RTE_NEXT_ABI here, and > > how > > you have multiple copies of RTE_NEXT_ABI on a single symbol when it is a > > binary variable. > > I don't understand what is not clear here.

[dpdk-dev] [PATCH] i40e: fix BW info update if no dcb enabled

2015-11-22 Thread Jingjing Wu
If DCB is not enabled, the BW info is not stored for VSI. This patch fixes this issue by merging functions i40e_vsi_dump_bw_config and i40e_vsi_get_bw_info together. Fixes: c8b9a3e3fe1b (i40e: support DCB mode) Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 112 +---

[dpdk-dev] [PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

2015-11-22 Thread Zhihong Wang
The kernel fills new allocated (huge) pages with zeros. DPDK just has to populate page tables to trigger the allocation. Signed-off-by: Zhihong Wang --- lib/librte_eal/linuxapp/eal/eal_memory.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/lib/librte_e

[dpdk-dev] [PATCH 1/2] lib/librte_eal: Reduce timer initialization time

2015-11-22 Thread Zhihong Wang
Changing from 1/2 second to 1/10 doesn't compromise the precision, and a 4/10 second is worth saving. Signed-off-by: Zhihong Wang --- lib/librte_eal/linuxapp/eal/eal_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_timer.c b/lib/librte

[dpdk-dev] [PATCH 0/2] Reduce DPDK initialization time

2015-11-22 Thread Zhihong Wang
This patch aims to reduce DPDK initialization time, which is important in cases such as micro service. Changes are: 1. Reduce timer initialization time 2. Remove unnecessary hugepage zero-filling operations With this patch: 1. Timer initialization time can be reduced by 4/10 second 2. Memory

[dpdk-dev] [PATCH v3] i40e: fix BW info update if no dcb enabled

2015-11-22 Thread Zhang, Helin
> -Original Message- > From: Wu, Jingjing > Sent: Sunday, November 22, 2015 8:35 PM > To: dev at dpdk.org > Cc: Wu, Jingjing; Zhang, Helin > Subject: [PATCH v3] i40e: fix BW info update if no dcb enabled > > If DCB is not enabled, the BW info is not stored for VSI. This patch fixes > th

[dpdk-dev] Mellanox dpdk issues

2015-11-22 Thread Olga Shern
Hi Sotiris, You can disable compilation of igb_uio, this module is not needed for Mellanox PMD. Let me know if you have any question Best Regards, Olga -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gilad Berman Sent: Sunday, November 22, 2015 1:30 PM To:

[dpdk-dev] Mellanox dpdk issues

2015-11-22 Thread Gilad Berman
Let us check and get back to you. Gilad Berman | Staff System Engineer | Business Development | Mellanox Technologies Ltd. Work: +972 52 2554262| 6 Ha'Barzel St. Tel Aviv 6971010, Israel -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Sotiris Salloumis Sent: F

[dpdk-dev] compiling pktgen w/ DPDK 2.1.0 and master seems broken

2015-11-22 Thread Matthew Hall
Hello, There are some really weird errors if you try to compile pktgen using DPDK 2.1.0. No matter what I try, the logic in the DPDK external app *.mk files seems to mess up the value of RTE_OUTPUT. I tried tracing through the *.mk and I found various places where it was set right and various

[dpdk-dev] [PATCH] i40e: merge two duplicate functions together

2015-11-22 Thread Jingjing Wu
The functions i40e_vsi_dump_bw_config and i40e_vsi_get_bw_info do the similar actions on BW configuration of vsi. It is necessary to merge them together to avoid functions duplication. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 99 +-