[dpdk-dev] [PATCH v10 4/4] examples: new example: l2fwd-ethtool

The example includes an ethtool library and two applications: one application is a non- DPDK process (nic-control) and the other is a DPDK l2fwd applicaiton (l2fwd-app). The nic-control process sends ethtool alike device management requests to l2fwd-app through a named pipe IPC. This example is des

[dpdk-dev] [PATCH v10 3/4] igb: add ops to support ethtool ops

add function to support ethtool ops: - set_mac_addr - get_reg_length - get_regs - get_eeprom_length - get_eeprom - set_eeprom Signed-off-by: Liang-Min Larry Wang --- drivers/net/e1000/igb_ethdev.c | 175 +++ drivers/net/e1000/igb_regs.h | 227 +++

[dpdk-dev] [PATCH v10 2/4] ixgbe: add ops to support ethtool ops

add function to support ethtool ops: - set_mac_addr - get_reg_length - get_regs - get_eeprom_length - get_eeprom - set_eeprom Signed-off-by: Liang-Min Larry Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 179 +- drivers/net/ixgbe/ixgbe_regs.h | 380

[dpdk-dev] [PATCH v10 1/4] ethdev: add apis to support access device info

add new apis: - rte_eth_dev_default_mac_addr_set - rte_eth_dev_reg_length - rte_eth_dev_reg_info - rte_eth_dev_eeprom_length - rte_eth_dev_get_eeprom - rte_eth_dev_set_eeprom to enable reading device parameters (mac-addr, register, eeprom) based upon ethtool alike data parameter specification. Si

[dpdk-dev] [PATCH v10 0/4] User-space Ethtool

This implementation is designed to provide a familar interface for applications that rely on kernel-space driver to support ethtool_op and net_device_op for device management. The initial implementation focuses on ops that can be implemented through existing netdev APIs. More ops will be support

[dpdk-dev] [PATCH v9 5/5] ixgbe/igb: changed register tables to const

Changed registers tables in ixgbe and igb to const type. Signed-off-by: Andrew G. Harvey Signed-off-by: Liang-Min Larry Wang --- drivers/net/e1000/igb_ethdev.c | 8 drivers/net/e1000/igb_regs.h | 28 - drivers/net/ixgbe/ixgbe_ethdev.c | 12 +-- dr

[dpdk-dev] [PATCH v9 4/5] examples: new example: l2fwd-ethtool

The example includes an ethtool library and two applications: one application is a non- DPDK process (nic-control) and the other is a DPDK l2fwd applicaiton (l2fwd-app). The nic-control process sends ethtool alike device management requests to l2fwd-app through a named pipe IPC. This example is des

[dpdk-dev] [PATCH v9 3/5] igb: add ops to support ethtool ops

add function to support ethtool ops: - set_mac_addr - get_reg_length - get_regs - get_eeprom_length - get_eeprom - set_eeprom Signed-off-by: Liang-Min Larry Wang --- drivers/net/e1000/igb_ethdev.c | 187 ++ drivers/net/e1000/igb_regs.h | 226

[dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops

add function to support ethtool ops: - set_mac_addr - get_reg_length - get_regs - get_eeprom_length - get_eeprom - set_eeprom Signed-off-by: Liang-Min Larry Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 190 +++- drivers/net/ixgbe/ixgbe_regs.h | 379 ++

[dpdk-dev] [PATCH v9 1/5] ethdev: add apis to support access device info

add new apis: - rte_eth_dev_default_mac_addr_set - rte_eth_dev_reg_length - rte_eth_dev_reg_info - rte_eth_dev_eeprom_length - rte_eth_dev_get_eeprom - rte_eth_dev_set_eeprom to enable reading device parameters (mac-addr, register, eeprom) based upon ethtool alike data parameter specification. Si

[dpdk-dev] [PATCH v9 0/5] User-space Ethtool

This implementation is designed to provide a familar interface for applications that rely on kernel-space driver to support ethtool_op and net_device_op for device management. The initial implementation focuses on ops that can be implemented through existing netdev APIs. More ops will be support

[dpdk-dev] [PATCH v8 0/5] User-space Ethtool

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Liang-Min Larry Wang > Sent: Friday, June 26, 2015 3:27 PM > To: dev at dpdk.org > Cc: Wang, Liang-min > Subject: [dpdk-dev] [PATCH v8 0/5] User-space Ethtool > > This implementation is designed to provide a f

[dpdk-dev] [PATCH v9 5/5] ixgbe/igb: changed register tables to const

On Fri, 26 Jun 2015 21:19:08 -0400 Liang-Min Larry Wang wrote: > Changed registers tables in ixgbe and igb to const type. > > Signed-off-by: Andrew G. Harvey > Signed-off-by: Liang-Min Larry Wang Since code is not yet accepted, all these changes should be rolled back into next (v10) of the or

[dpdk-dev] [PATCH v9 3/5] igb: add ops to support ethtool ops

On Fri, 26 Jun 2015 21:19:06 -0400 Liang-Min Larry Wang wrote: > +static struct reg_info igb_regs_general[] = { > + {E1000_CTRL, 1, 1, "E1000_CTRL"}, > + {E1000_STATUS, 1, 1, "E1000_STATUS"}, > + {E1000_CTRL_EXT, 1, 1, "E1000_CTRL_EXT"}, > + {E1000_MDIC, 1, 1, "E1000_MDIC"}, > +

[dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops

On Fri, 26 Jun 2015 21:19:05 -0400 Liang-Min Larry Wang wrote: > +static struct reg_info ixgbe_regs_general[] = { > + {IXGBE_CTRL, 1, 1, "IXGBE_CTRL"}, > + {IXGBE_STATUS, 1, 1, "IXGBE_STATUS"}, > + {IXGBE_CTRL_EXT, 1, 1, "IXGBE_CTRL_EXT"}, > + {IXGBE_ESDP, 1, 1, "IXGBE_ESDP"}, > +

[dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops

On Fri, 26 Jun 2015 21:19:05 -0400 Liang-Min Larry Wang wrote: > + reg_group = reg_set[g_ind++]; > + while (reg_group) { > + count += ixgbe_regs_group_count(reg_group); > + reg_group = reg_set[g_ind++]; > + } I don't care what checkpatch says, this an example

[dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops

On Fri, 26 Jun 2015 21:19:05 -0400 Liang-Min Larry Wang wrote: > +static int > +ixgbe_get_reg_length(struct rte_eth_dev *dev __rte_unused) > +{ > + struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private) The dev arg is used, and therefore should not be marked __rte_unused.

[dpdk-dev] [PATCH v2 8/8] eal: Enable Port Hotplug as default in Linux and BSD

From: "Tetsuya.Mukawa" This patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option, and enables it as default in both Linux and BSD. Also, to support port hotplug, rte_eal_pci_scan() and below missing symbols should be exported to ethdev library. - rte_eal_parse_devargs_str() - rte_eal_pci_close_on

[dpdk-dev] [PATCH v2 7/8] eal: Consolidate pci uio functions of linuxapp and bsdapp

From: "Tetsuya.Mukawa" The patch consolidates below functions, and implement these in eal_common_pci_uio.c. - pci_uio_map_secondary() - pci_uio_map_resource() - pci_uio_unmap() - pci_uio_find_resource() - pci_uio_unmap_resource() Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal

[dpdk-dev] [PATCH v2 6/8] eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp

From: "Tetsuya.Mukawa" The patch consolidates below functions, and implemented in common eal code. - pci_map_resource() - pci_unmap_resource() Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c| 22 lib/librte_eal/common/eal_common_pci.c | 40 +

[dpdk-dev] [PATCH v2 5/8] eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp

From: "Tetsuya.Mukawa" The patch consolidates below functions, and implemented in common eal code. - pci_map_device() - pci_unmap_device() Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 12 +++ lib/librte_eal/common/eal_common_pci.c | 57

[dpdk-dev] [PATCH v2 4/8] eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and bsdapp

From: "Tetsuya.Mukawa" This patch consolidates below functions, and implements these in common eal code. - rte_eal_pci_probe_one_driver() - rte_eal_pci_close_one_driver() Because pci_map_device() is only implemented in linuxapp, the patch implements it in bsdapp too. This implemented function

[dpdk-dev] [PATCH v2 3/8] eal: Consolidate pci_map and mapped_pci_resource of linuxapp and bsdapp

From: "Tetsuya.Mukawa" This patch consolidates below structures, and defines them in common code. - struct pci_map - strucy mapped_pci_resouces Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c| 24 lib/librte_eal/common/include/rte_pci.h

[dpdk-dev] [PATCH v2 2/8] eal: Add pci_uio_map_uio_resource_by_index()

From: "Tetsuya.Mukawa" This patch adds a new function called pci_uio_map_resource_by_index(). The function hides how to map uio resource in linuxapp and bsdapp. With the function, pci_uio_map_resource() will be more abstracted. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pc

[dpdk-dev] [PATCH v2 1/8] eal: Add pci_uio_alloc_uio_resource()

From: "Tetsuya.Mukawa" This patch adds a new function called pci_uio_alloc_uio_resource(). The function hides how to prepare uio resource in linuxapp and bsdapp. With the function, pci_uio_map_resource() will be more abstracted. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_p

[dpdk-dev] [PATCH v2 0/8] Add Port Hotplug support to BSD

This patch series adds port hotplug support to BSD. Before applying, following patches should be applied. - [PATCH v6 1/5] eal: Fix coding style of eal_pci.c and eal_pci_uio.c - [PATCH v6 2/5] eal: Close file descriptor of uio configuration - [PATCH v6 3/5] eal: Fix memory leaks and needless inc

[dpdk-dev] [PATCH v6 5/5] eal: Fix uio mapping differences between linuxapp and bsdapp

From: "Tetsuya.Mukawa" This patch fixes below. - bsdapp - Use map_id in pci_uio_map_resource(). - Fix interface of pci_map_resource(). - Move path variable of mapped_pci_resource structure to pci_map. - linuxapp - Remove redundant error message of linuxapp. 'pci_uio_map_resource()' is implem

[dpdk-dev] [PATCH v6 4/5] eal/bsdapp: Change names of pci related data structure

From: "Tetsuya.Mukawa" To merge pci code of linuxapp and bsdapp, this patch changes names like below. - uio_map to pci_map - uio_resource to mapped_pci_resource - uio_res_list to mapped_pci_res_list Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 24 -

[dpdk-dev] [PATCH v6 3/5] eal: Fix memory leaks and needless increment of pci_map_addr

From: "Tetsuya.Mukawa" This patch fixes following memory leaks. - When open() is failed, uio_res and fds won't be freed in pci_uio_map_resource(). - When pci_map_resource() is failed but path is allocated correctly, path and fds won't be freed in pci_uio_map_recource(). Also, some mapped re

[dpdk-dev] [PATCH v6 2/5] eal: Close file descriptor of uio configuration

From: "Tetsuya.Mukawa" When pci_uio_unmap_resource() is called, a file descriptor that is used for uio configuration should be closed. Signed-off-by: Tetsuya Mukawa Acked-by: Stephen Hemminger --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletio

[dpdk-dev] [PATCH v6 1/5] eal: Fix coding style of eal_pci.c and eal_pci_uio.c

From: "Tetsuya.Mukawa" This patch fixes coding style of below files in linuxapp and bsdapp. - eal_pci.c - eal_pci_uio.c Signed-off-by: Tetsuya Mukawa Acked-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/eal_pci.c | 12 +++- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 12 +

[dpdk-dev] [PATCH v6 0/5] Clean up pci uio implementations

This patch set cleans up pci uio implementation. These clean up are for consolidating pci uio implementation of linuxapp and bsdapp, and moving consolidated functions in eal common. Because of above, this patch set tries to implement linuxapp and bsdapp almost same. Actual consolidations will be do

[dpdk-dev] [PATCH v2 4/4] kni: fix missing validation when vhost HDR is enabled

A missing port from memcpy_toiovecend to copy_to_iter is showed when vHost HDR is enabled. DPDK would not build. This patch add this validation to build with kernel > 3.19. Fixes: 45e63ba8db31 ("kni: fix vhost build with kernels 3.19 and 4.0") Fixes: ba7438aed924 ("vhost: don't bother copying iov

[dpdk-dev] [PATCH v2 3/4] kni: fix function parameter from proto_ops pointers

Parameters from sendmsg and recvmsg has been changed in 4.1 kernel. The function pointers belong to proto_ops structure were updated removing the struct kiocb parameter. Fixes: 1b784140474e ("net: Remove iocb argument from sendmsg and recvmsg") Signed-off-by: Miguel Bernal Marin --- lib/librte

[dpdk-dev] [PATCH v2 2/4] kni: fix header_ops to build with 4.1

rebuild member was removed from headers_ops in kernel release 4.1. Therefore kni module compilation breaks. This patch add the properly checks to fix it. Fixes: d476059e77d1 ("net: Kill dev_rebuild_header") Signed-off-by: Miguel Bernal Marin --- lib/librte_eal/linuxapp/kni/kni_net.c | 4

[dpdk-dev] [PATCH v2 1/4] kni: fix igb_ndo_bridge_getlink to build with 4.1

ndo_bridge_getlink has changed in kernel release 4.1. It adds new parameter which brakes compilation. This patch add the properly checks to fix it. Fixes: 46c264d5 ("bridge/nl: remove wrong use of NLM_F_MULTI") Signed-off-by: Miguel Bernal Marin --- lib/librte_eal/linuxapp/kni/ethtool/igb/

[dpdk-dev] [PATCH v2 0/4] kni: fix build with kernel 4.1

Due to API changes in netdevice.h in 4.1 kernel release, KNI modules would not build. This patch set adds the properly checks to fix compilation. Changes in v2: - Fixed vHost module build errors. Miguel Bernal Marin (4): kni: fix igb_ndo_bridge_getlink to buid with 4.1 kni: fix header_ops

[dpdk-dev] [PATCH v8 1/5] ethdev: add apis to support access device info

> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, June 26, 2015 12:52 PM > To: Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 1/5] ethdev: add apis to support access > device info > > On Fri, 26 Jun 2015 10:26

[dpdk-dev] [PATCH 4/4] rte_ethdev: introduce valid port helper

From: Stephen Hemminger The code pattern is repeated so many times, it is a good idea to introduce template like other code here uses. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 490 +- 1 file changed, 101 insertions(+), 389 del

[dpdk-dev] [PATCH 3/4] rte_ethdev: fix code style

From: Stephen Hemminger This fixes lots of complaints from checkpatch about whitespace and other non-material things. Important to fix the old code now befor more code does copy/paste of same junk. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 172 +--

[dpdk-dev] [PATCH 2/4] rte_ethdev: fix comment spelling

From: Stephen Hemminger Fix trivial spelling errors. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index dec3da7..14a14a5 100644 -

[dpdk-dev] [PATCH 1/4] rte_ethdev: remove impossible condition

From: Stephen Hemminger Since rte_eth_devices is in BSS, the address of rte_eth_devices plus port_id can not ever be NULL for a valid port_id number. Remove this unnecessary check and fix the code style. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 45 +-

[dpdk-dev] [PATCH 0/4] ethdev: patches

From: Stephen Hemminger The recent work on ethtool like API exposed some of the stylistic ugliness and waste in the current rte_ethdev code. Stephen Hemminger (4): rte_ethdev: remove impossible condition rte_ethdev: fix comment spelling rte_ethdev: fix code style rte_ethdev: introduce va

[dpdk-dev] 10G Interface used as PCI Pass-Through reports 64bytes / packet

Hello, Is it normal that a 10G NIC interface, supporting the 82599 Ethernet Controller, configured as PCI Pass-through for a virtual machine using DPDK, reports 64 bytes per packet; no matter what the packet size? If so; I'm assuming this is to improve the performance of passing the network t

[dpdk-dev] [PATCH 2/2 v4] fm10k: Add hotplug support for fm10k

Add hotplug support for fm10k. Signed-off-by: Michael Qiu Acked-by: Jing Chen --- drivers/net/fm10k/fm10k_ethdev.c | 97 +++- 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c ind

[dpdk-dev] [PATCH 1/2 v4] fm10k: Free queues when close port

When close a port, lots of memory should be released, such as software rings, queues, etc. Signed-off-by: Michael Qiu --- drivers/net/fm10k/fm10k_ethdev.c | 37 + 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b

[dpdk-dev] [PATCH 0/2 v4] Enable hotplug support for fm10k

Hotplug feature is supported in EAL, this patch set is to enable this feature in driver side. change log: v4 --> v3: rebase code. v3 --> v2: reset queue numbers to zero. v2 --> v1: remove __rte_unused flag Michael Qiu (2): fm10k: Free queues when

[dpdk-dev] [PATCH v6 9/9] doc: update malloc documentation

Update malloc documentation to reflect new implementation details. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/prog_guide/env_abstraction_layer.rst | 220 +- doc/guides/prog_guide/img/malloc_heap.png | Bin 81329 -> 80952 bytes doc/guides/prog_guide/index.rst

[dpdk-dev] [PATCH v6 8/9] doc: announce ABI change of librte_malloc

Announce the creation of dummy malloc library for 2.1 and removal of such library, now integrated in librte_eal, for 2.2 release. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/rel_notes/abi.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/r

[dpdk-dev] [PATCH v6 7/9] app/test: rte_memzone_free unit test

Add new unit test for rte_memzone_free API. Signed-off-by: Sergio Gonzalez Monroy --- app/test/test_memzone.c | 82 +++-- 1 file changed, 80 insertions(+), 2 deletions(-) diff --git a/app/test/test_memzone.c b/app/test/test_memzone.c index 6934eee..c3

[dpdk-dev] [PATCH v6 6/9] eal: new rte_memzone_free

Implement rte_memzone_free which, as its name implies, would free a memzone. Currently memzone are tracked in an array and cannot be free. To be able to reuse the same array to track memzones, we have to change how we keep track of reserved memzones. With this patch, any memzone with addr NULL is

[dpdk-dev] [PATCH v6 5/9] eal: remove free_memseg and references to it

Remove free_memseg field from internal mem config structure as it is not used anymore. Also remove code in ivshmem that was setting up free_memseg on init. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/include/rte_eal_memconfig.h | 3 --- lib/librte_eal/linuxapp/eal/eal_ivshmem

[dpdk-dev] [PATCH v6 4/9] config: remove CONFIG_RTE_MALLOC_MEMZONE_SIZE

During initializaio malloc sets all available memory as part of the heaps. CONFIG_RTE_MALLOC_MEMZONE_SIZE was used to specify the default memory block size to expand the heap. The option is not used/relevant anymore, so we remove it. Signed-off-by: Sergio Gonzalez Monroy --- config/common_bsdap

[dpdk-dev] [PATCH v6 3/9] app/test: update malloc/memzone unit tests

Some unit test are not relevant anymore. It is the case of those malloc UTs that checked corner cases when allocating MALLOC_MEMZONE_SIZE chunks, and the case of those memzone UTs relaying of specific free memsegs of rhte reserved memzone. Other UTs just need to be update, for example, to calculat

[dpdk-dev] [PATCH v6 2/9] eal: memzone allocated by malloc

In the current memory hierarchy, memsegs are groups of physically contiguous hugepages, memzones are slices of memsegs and malloc further slices memzones into smaller memory chunks. This patch modifies malloc so it partitions memsegs instead of memzones. Thus memzones would call malloc internally

[dpdk-dev] [PATCH v6 1/9] eal: move librte_malloc to eal/common

Move malloc inside eal. Create a dummy malloc library to avoid breaking applications that have librte_malloc in their DT_NEEDED entries. This is the first step towards using malloc to allocate memory directly from memsegs. Thus, memzones would allocate memory through malloc, allowing to free memz

[dpdk-dev] [PATCH v6 0/9] Dynamic memzones

Current implemetation allows reserving/creating memzones but not the opposite (unreserve/free). This affects mempools and other memzone based objects. >From my point of view, implementing free functionality for memzones would look like malloc over memsegs. Thus, this approach moves malloc inside e

[dpdk-dev] [PATCH v6 0/9] Dynamic memzones

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez Monroy > Sent: Friday, June 26, 2015 4:29 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v6 0/9] Dynamic memzones > > Current implemetation allows reserving/creating memzones but not the

[dpdk-dev] [PATCH] support jumbo frames for pcap vdev

2015-06-09 15:50, Maxim Uvarov: > On 06/09/15 15:15, Mcnamara, John wrote: > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maxim Uvarov > >> PCAP PMD vdev is used mostly for testing. Increase snapshot len parameter > >> provided to pcap_open_live() to accept packet more then 4096 (suppo

[dpdk-dev] Distributor example app not working for 1G ports (I354)

Hi DPDKers, I have a strange case where the Distributor example application is not working when I use Intel's I35x (I354 specifically) 1Gig ports. The app initializes fine but the port always comes with link down: [root at localhost dpdk]# ./tools/dpdk_nic_bind.py -b igb_uio eth1 eth2 [root at

[dpdk-dev] [PATCH] cfgfile: fix unitialised buffer and improve reading from nfs filesystem.

On Fri, Jun 26, 2015 at 10:37:13AM +0200, Daniel Mrzyglod wrote: > Nature of the problem was not initialised buffer[256] on special condition > there were probability that program will work on unitialised data that > could provide unexpected program behaviour. > > Adding additional transparent I/O

[dpdk-dev] [PATCHv3 3/3] ABI: Add some documentation

2015-06-25 10:35, Neil Horman: > v3) > * Fixed in tact -> intact > * Added docs to address static linking > * Removed duplicate documentation from release notes It seems you missed some of my previous comments. [...] > +* ``VERSION_SYMBOL(b, e, n)``: Creates a symbol version table

[dpdk-dev] [PATCHv3 2/3] rte_compat: Add MAP_STATIC_SYMBOL macro

2015-06-25 10:35, Neil Horman: > +/* > + * MAP_STATIC_SYMBOL > + * If a function has been bifurcated into multiple versions, none of which > + * are defined as the exported symbol name in the map file, this macro can be > + * used to alias a specific version of the symbol to its exported name. For

[dpdk-dev] [PATCH v3 4/7] ethdev: remove HW specific stats in stats structs

> Hi Maryam, > I was not aware of the proc_info app. Is there any documentation on dpdk.org > about it, or should I browse the code? > Thanks, > Kyle Hi Kyle, It's the last patch in the patchset I posted. I haven't written up the documentation yet, but will do so, for now feel free to peruse the

[dpdk-dev] [PATCHv3 1/3] rte_compat.h : Clean up some typos

2015-06-25 10:35, Neil Horman: > #define VERSION_SYMBOL(b, e, v) > #define __vsym > #define BASE_SYMBOL(b, n) You forgot to fix the parameter names to (b, e, n) and (b, e).

[dpdk-dev] [PATCH v6 5/5] eal: Fix uio mapping differences between linuxapp and bsdapp

> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, June 26, 2015 9:18 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Tetsuya.Mukawa > Subject: [PATCH v6 5/5] eal: Fix uio mapping differences between linuxapp > and bsdap

[dpdk-dev] [PATCH v6 4/5] eal/bsdapp: Change names of pci related data structure

> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, June 26, 2015 9:18 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Tetsuya.Mukawa > Subject: [PATCH v6 4/5] eal/bsdapp: Change names of pci related data > structure > >

[dpdk-dev] [PATCH v6 3/5] eal: Fix memory leaks and needless increment of pci_map_addr

> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, June 26, 2015 9:18 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Tetsuya.Mukawa > Subject: [PATCH v6 3/5] eal: Fix memory leaks and needless increment of > pci_map_add

[dpdk-dev] [PATCH v6 2/5] eal: Close file descriptor of uio configuration

> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, June 26, 2015 9:18 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Tetsuya.Mukawa > Subject: [PATCH v6 2/5] eal: Close file descriptor of uio configuration > > From: "T

[dpdk-dev] [PATCH v6 1/5] eal: Fix coding style of eal_pci.c and eal_pci_uio.c

> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, June 26, 2015 9:18 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Tetsuya.Mukawa > Subject: [PATCH v6 1/5] eal: Fix coding style of eal_pci.c and eal_pci_uio.c > > Fr

[dpdk-dev] [PATCH v3 4/7] ethdev: remove HW specific stats in stats structs

On Fri, Jun 26, 2015 at 8:59 AM, Maryam Tahhan mailto:maryam.tahhan at intel.com>> wrote: Remove non generic stats in rte_stats_strings and mark the relevant fields in struct rte_eth_stats as deprecated. Signed-off-by: Maryam Tahhan mailto:maryam.tahhan at intel.com>> --- doc/guides/rel_notes/a

[dpdk-dev] [PATCH] support jumbo frames for pcap vdev

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, June 26, 2015 3:04 PM > To: Maxim Uvarov; Mcnamara, John; tero.aho at coriant.com > Cc: dev at dpdk.org; Bill Fischofer > Subject: Re: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev >

[dpdk-dev] [PATCH v3 7/7] app: add a new app proc_info

proc_info displays statistics information including extened stats for given DPDK ports and dumps the memory information for DPDK. Signed-off-by: Maryam Tahhan --- MAINTAINERS| 4 + app/Makefile | 1 + app/proc_info/Makefile | 45 + app/proc_info/main.c | 512

[dpdk-dev] [PATCH v3 6/7] app: remove dump_cfg

Remove the dump_cfg application, this will be replaced by a new app called proc_info that will implement the same functionality as dump_cfg and extend it to retrieve statistics for DPDK ports. Signed-off-by: Maryam Tahhan --- app/Makefile | 1 - app/dump_cfg/Makefile | 45 -

[dpdk-dev] [PATCH v3 5/7] ixgbe: add NIC specific stats removed from ethdev

Add the NIC/HW specific stats that were removed from rte_ethdev.c to the extended stats in ixgbe. Signed-off-by: Maryam Tahhan --- drivers/net/ixgbe/ixgbe_ethdev.c | 43 ++-- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/drivers/net/ixgbe/ixg

[dpdk-dev] [PATCH v3 4/7] ethdev: remove HW specific stats in stats structs

Remove non generic stats in rte_stats_strings and mark the relevant fields in struct rte_eth_stats as deprecated. Signed-off-by: Maryam Tahhan --- doc/guides/rel_notes/abi.rst | 11 +++ lib/librte_ether/rte_ethdev.c | 9 - lib/librte_ether/rte_ethdev.h | 30

[dpdk-dev] [PATCH v3 3/7] ethdev: expose extended error stats

Extend rte_eth_xstats_get to retrieve additional stats from the device driver as well the ethdev generic stats. Signed-off-by: Maryam Tahhan --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- lib/librte_ether/rte_ethdev.c| 20 ++-- 2 files changed, 15 insertions(+), 7 deletions(-)

[dpdk-dev] [PATCH v3 2/7] ixgbe: add functions to get and reset xstats

Implement ixgbe_dev_xstats_reset and ixgbe_dev_xstats_get. Signed-off-by: Maryam Tahhan --- drivers/net/ixgbe/ixgbe_ethdev.c | 85 1 file changed, 85 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 927

[dpdk-dev] [PATCH v3 1/7] ixgbe: move stats register reads to a new function

Move stats register reads to ixgbe_read_stats_registers() as it will be used by the functions to retrieve stats and extended stats. Signed-off-by: Maryam Tahhan --- drivers/net/ixgbe/ixgbe_ethdev.c | 64 +++- 1 file changed, 44 insertions(+), 20 deletions(-)

[dpdk-dev] [PATCH v3 0/7] Expose IXGBE extended stats to DPDK apps

This patch set implements xstats_get() and xstats_reset() in dev_ops for ixgbe to expose detailed error statistics to DPDK applications. The dump_cfg application was extended to demonstrate the usage of retrieving statistics for DPDK interfaces and renamed to proc_info in order reflect this new fun

[dpdk-dev] [PATCH 00/37] update ixgbe base driver

2015-06-25 01:24, Zhang, Helin: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu > > Wenzhuo Lu (37): > > ixgbe/base: update readme > > ixgbe/base: update Low Power Link Up to use MAC ops link > > ixgbe/base: fix 1G and 10G link stability for x550em SFP+ > > ixgbe/base:

[dpdk-dev] [PATCH v5 9/9] doc: update malloc documentation

Update malloc documentation to reflect new implementation details. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/prog_guide/env_abstraction_layer.rst | 220 +- doc/guides/prog_guide/img/malloc_heap.png | Bin 81329 -> 80952 bytes doc/guides/prog_guide/index.rst

[dpdk-dev] [PATCH v5 8/9] doc: announce ABI change of librte_malloc

Announce the creation of dummy malloc library for 2.1 and removal of such library, now integrated in librte_eal, for 2.2 release. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/rel_notes/abi.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/r

[dpdk-dev] [PATCH v5 7/9] app/test: update unit test with rte_memzone_free

Update memzone unit test for the new rte_memzone_free API. Signed-off-by: Sergio Gonzalez Monroy --- app/test/test_memzone.c | 80 + 1 file changed, 80 insertions(+) diff --git a/app/test/test_memzone.c b/app/test/test_memzone.c index 6934eee..30e

[dpdk-dev] [PATCH v5 6/9] eal: new rte_memzone_free

Implement rte_memzone_free which, as its name implies, would free a memzone. Currently memzone are tracked in an array and cannot be free. To be able to reuse the same array to track memzones, we have to change how we keep track of reserved memzones. With this patch, any memzone with addr NULL is

[dpdk-dev] [PATCH v5 5/9] eal: remove free_memseg and references to it

Remove free_memseg field from internal mem config structure as it is not used anymore. Also remove code in ivshmem that was setting up free_memseg on init. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/include/rte_eal_memconfig.h | 3 --- lib/librte_eal/linuxapp/eal/eal_ivshmem

[dpdk-dev] [PATCH v5 4/9] config: remove CONFIG_RTE_MALLOC_MEMZONE_SIZE

During initializaio malloc sets all available memory as part of the heaps. CONFIG_RTE_MALLOC_MEMZONE_SIZE was used to specify the default memory block size to expand the heap. The option is not used/relevant anymore, so we remove it. Signed-off-by: Sergio Gonzalez Monroy --- config/common_bsdap

[dpdk-dev] [PATCH v5 3/9] app/test: update malloc/memzone unit tests

Some unit test are not relevant anymore. It is the case of those malloc UTs that checked corner cases when allocating MALLOC_MEMZONE_SIZE chunks, and the case of those memzone UTs relaying of specific free memsegs of rhte reserved memzone. Other UTs just need to be update, for example, to calculat

[dpdk-dev] [PATCH v5 2/9] eal: memzone allocated by malloc

In the current memory hierarchy, memsegs are groups of physically contiguous hugepages, memzones are slices of memsegs and malloc further slices memzones into smaller memory chunks. This patch modifies malloc so it partitions memsegs instead of memzones. Thus memzones would call malloc internally

[dpdk-dev] [PATCH v5 1/9] eal: move librte_malloc to eal/common

Move malloc inside eal. Create a dummy malloc library to avoid breaking applications that have librte_malloc in their DT_NEEDED entries. This is the first step towards using malloc to allocate memory directly from memsegs. Thus, memzones would allocate memory through malloc, allowing to free memz

[dpdk-dev] [PATCH v5 0/9] Dynamic memzones

Current implemetation allows reserving/creating memzones but not the opposite (unreserve/free). This affects mempools and other memzone based objects. >From my point of view, implementing free functionality for memzones would look like malloc over memsegs. Thus, this approach moves malloc inside e

[dpdk-dev] Receiving packets on only one port

Hello, I'm writing a packet capture program from the l3fwd. When I send DNS packets, the wireshark simultaneously gets all the packets on two ports. However, using my program with promiscuous mode, one port receives all the packets, but the other port gets nothing. Do you know why it happens? Coul

[dpdk-dev] [PATCH 1/2 v4] fm10k: Free queues when close port

> -Original Message- > From: Qiu, Michael > Sent: Friday, June 26, 2015 9:30 AM > To: dev at dpdk.org > Cc: Chen, Jing D; He, Shaopeng; Iremonger, Bernard; Qiu, Michael > Subject: [PATCH 1/2 v4] fm10k: Free queues when close port > > When close a port, lots of memory should be released, su

[dpdk-dev] [PATCHv3 3/3] ABI: Add some documentation

On Fri, Jun 26, 2015 at 03:00:17PM +0200, Thomas Monjalon wrote: > 2015-06-25 10:35, Neil Horman: > > v3) > > * Fixed in tact -> intact > > * Added docs to address static linking > > * Removed duplicate documentation from release notes > > It seems you missed some of my previous com

[dpdk-dev] [PATCH v3 4/7] ethdev: remove HW specific stats in stats structs

Hi Maryam, I was not aware of the proc_info app. Is there any documentation on dpdk.org about it, or should I browse the code? Thanks, Kyle On Fri, Jun 26, 2015 at 10:30 AM, Tahhan, Maryam wrote: > > > On Fri, Jun 26, 2015 at 8:59 AM, Maryam Tahhan > wrote: > > Remove non generic stats in rt

[dpdk-dev] [PATCH] fm10k: fix an error message when adding default VLAN

The default MAC address is directly copied to Device Ethernet Link address array in the device initialize phase, which bypasses fm10k MAC address number check mechanism, and will cause an error message when adding default VLAN. Fix it by moving default MAC address registration to device initialize

[dpdk-dev] [PATCH] cfgfile: fix unitialised buffer and improve reading from nfs filesystem.

Nature of the problem was not initialised buffer[256] on special condition there were probability that program will work on unitialised data that could provide unexpected program behaviour. Adding additional transparent I/O buffer for I/O operations improve reading on heavyloaded enviroments with

[dpdk-dev] [PATCH v5 3/5] eal: Fix memory leaks and needless increment of pci_map_addr

On 2015/06/25 18:18, David Marchand wrote: > On Thu, Jun 25, 2015 at 5:19 AM, Tetsuya Mukawa > wrote: > > From: "Tetsuya.Mukawa" mailto:mukawa at > igel.co.jp>> > > This patch fixes following memory leaks. > - When open() is failed, uio_res and fds won't b

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

Changes in v2: do not free mac_addrs and hash_mac_addrs here. Signed-off-by: Bernard Iremonger --- lib/librte_ether/rte_ethdev.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index e13fde5..7ae101a 1006

[dpdk-dev] [PATCH v5 3/5] eal: Fix memory leaks and needless increment of pci_map_addr

On 2015/06/25 18:16, David Marchand wrote: > Hello Tetsuya, > > > On Thu, Jun 25, 2015 at 5:19 AM, Tetsuya Mukawa > wrote: > > From: "Tetsuya.Mukawa" mailto:mukawa at > igel.co.jp>> > > This patch fixes following memory leaks. > - When open() is failed, u

  1   2   >