>NOTE Please avoid, as much as possible, including headers from other headers
>file. Doing so should be properly explained and justified.
Actually, I think a *failure* to #include other header files that this header
file depends on should be what needs explained and justified. It drives me
craz
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, April 8, 2015 5:16 PM
> To: Wiles, Keith; Butler, Siobhan A
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] tools brainstorming
>
> 2015-04-08 15:53, Wiles, Keith:
> > One of the biggest
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Igor Ryzhov
> Sent: Wednesday, April 8, 2015 5:31 PM
> To: dev at dpdk.org
> Cc: Igor Ryzhov
> Subject: [dpdk-dev] [PATCH] doc: fix vhost guide
>
> Guide says that a configure parameter to choose between vhost
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Wednesday, April 8, 2015 7:16 PM
> To: Butler, Siobhan A
> Cc: Thomas Monjalon; dev at dpdk.org
> Subject: Re: [dpdk-dev] tools brainstorming
>
> Thanks for doing this, it is a great start.
> I
Guide says that a configure parameter to choose between vhost cuse and vhost
user will be introduced in the future, but it?s already added by commit
28a1ccca41bf.
Signed-off-by: Igor Ryzhov
---
doc/guides/sample_app_ug/vhost.rst | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
dif
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Aaron Campbell
> Sent: Wednesday, April 08, 2015 5:36 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] Polling too often at lower packet rates?
>
> Hi,
>
> I have a machine with 6 DPDK ports (4 igb, 2 ixgbe), w
I found the source of the problem.
The issues happens also in dpdk 1.8.0, and related to patch
http://dpdk.org/dev/patchwork/patch/239/
Adding Thomas and David to the thread and I will appreciate your input.
The patch comes to solve a file descriptor leak in the bsdapp version of
rte_eal_iopl_
2015-04-08 15:53, Wiles, Keith:
> One of the biggest problems with any style is helping the developer
> maintain the style. Using some tool does help and I have used astyle
> before, not bad code formatter. Here is a few that seem to be reasonable.
>
> http://astyle.sourceforge.net/
>
> http://un
"C comments" includes //, right? It's been part of the C standard for a long
time now...
Sent from my iPhone
> On Apr 8, 2015, at 8:40 AM, Butler, Siobhan A
> wrote:
>
>
>
>> -Original Message-
>> From: Neil Horman [mailto:nhorman at tuxdriver.com]
>> Sent: Wednesday, April 8, 2015
On 4/8/15, 11:16 AM, "Thomas Monjalon" wrote:
>2015-04-08 15:53, Wiles, Keith:
>> One of the biggest problems with any style is helping the developer
>> maintain the style. Using some tool does help and I have used astyle
>> before, not bad code formatter. Here is a few that seem to be
>>reason
Given the circular dependencies between eal, malloc, mempool and ring
libraries and that eal does not have proper DT_NEEDED entries, we work
around it by forcing linking against mentioned libraries by preceding
them with --no-as-needed flag when building shared libraries.
This patch also does:
-
This patch mainly makes use of the LDLIBS variable when linking shared
libraries, setting proper DT_NEEDED entries.
This patch also fixes a few nits like syntax highlighting, the command
string (O_TO_S_CMD) used for linking shared libraries and the displayed
of dependencies when debugging is enabl
When creating shared libraries, each library will be linked against
their dependant libraries, specified by the new LDLIBS variable.
Given the circular dependencies between eal, malloc, mempool and ring,
we work around it by not linking eal against its dependent libraries.
Therefore, eal will not
After the patch, building DPDK will always generate a linker script
(name use is based on CONFIG_RTE_LIBNAME config option) that behaves
as a combined library when linking against it.
Signed-off-by: Sergio Gonzalez Monroy
---
mk/rte.combinedlib.mk | 89 +++
Currently, the target/rules to build combined libraries is different
than the one to build individual libraries.
By removing the combined library option as a build configuration option
we simplify the build pocess by having a single point for linking/archiving
libraries in DPDK.
This patch remove
This patch series has the following goals:
- Remove config option to build a combined library to simplify maintenance.
- Add makefile to always generate linker script that behaves like a
combined library.
- For shared libraries, explicitly link against dependant libraries (adding
entries t
rte_ethdev.c (main points):
- Collect up the globals and static variables in the file into a new
rte_eth_globals structure.
- Update the global references to use the new global structure
- Move parts of the callback routines into eal_common_device.c to all other
device a common routine
-
Signed-off-by: Keith Wiles
---
lib/librte_eal/bsdapp/eal/Makefile | 1 +
lib/librte_eal/common/Makefile | 1 +
lib/librte_eal/common/include/rte_log.h | 1 +
lib/librte_eal/linuxapp/eal/Makefile| 1 +
4 files changed, 4 insertions(+)
diff --git a/lib/librte_eal/bsdapp/eal/Makef
Move a number of device specific define, structures and functions
into a generic device base set of files for all device not just Ethernet.
Signed-off-by: Keith Wiles
---
lib/librte_eal/common/eal_common_device.c | 185 +++
lib/librte_eal/common/include/rte_common_device.h | 617
Rename the RTE_ETH_PCI, VIRTUAL, ... to be RTE_DEV_PCI, ... names.
Signed-off-by: Keith Wiles
---
app/test/test_link_bonding.c | 10 +-
app/test/virtual_pmd.c | 4 ++--
examples/link_status_interrupt/main.c| 6 +++---
lib/librte_pmd_af_pack
Hi All,
Here is a set of RFC patches to update DPDK to support a generic set of
devices. The patches that follow create two files eal_common_device.h
and rte_common_device.c and then a few items in rte_ethdev.[ch] were moved
to cleanup those files by moving the device generic values and functions
On 4/8/15, 5:43 AM, "Butler, Siobhan A" wrote:
>Hi all,
>To add to the tools brainstorming - I propose we use the following Coding
>Standards as the basis of guidelines on coding style going forward.
>The style outlined below is in alignment with the current convention used
>for the majority of
On Wed, 8 Apr 2015 16:29:54 -0600
Jay Rolette wrote:
> "C comments" includes //, right? It's been part of the C standard for a long
> time now...
Yes but.
I like to use checkpatch and checkpatch enforces kernel style which does not
allow // for
comments.
On Wed, 8 Apr 2015 15:06:13 -0400
Vladimir Medvedkin wrote:
> Software implementation of the Toeplitz hash function used by RSS.
> Can be used either for packet distribution on single queue NIC
> or for simulating of RSS computation on specific NIC (for example
> after GRE header decapsulating).
This RFC describes a proposed change in the ethdev API for updating
the set of multicast MAC addresses that are filtered by a port.
The change consists in adding a new function "update_mc_addr_list" that
takes the whole set of multicast MAC addresses to be filtered by a port,
if any.
In case the
On 4/8/15, 5:43 AM, "Butler, Siobhan A" wrote:
>Hi all,
>To add to the tools brainstorming - I propose we use the following Coding
>Standards as the basis of guidelines on coding style going forward.
>The style outlined below is in alignment with the current convention used
>for the majority of
On 4/7/2015 10:23 PM, Luke Gorrie wrote:
> Hi Michael,
>
> I'm writing to follow up the previous discussion about memory barriers in
> virtio-net device implementations, and Cc'ing the DPDK list because I
> believe this is relevant to them too.
>
> First, thanks again for getting in touch and revie
The userspace code has to be BSD ( no GPL ).
The Linux kernel code must be GPLv2 or BSD/GPL license.
The other kernel code should be BSD/GPL.
On Wed, Apr 8, 2015 at 11:58 AM, Matthew Hall wrote:
> On Wed, Apr 08, 2015 at 11:16:03AM -0700, Stephen Hemminger wrote:
> > I prefer the file just say
This patch depends on the Port Hotplug Framework.
It implements the eth_dev_uninit functions for rte_em_pmd,
rte_igb_pmd and rte_igbvf_pmd.
Signed-off-by: Bernard Iremonger
---
lib/librte_pmd_e1000/e1000_ethdev.h |4 +-
lib/librte_pmd_e1000/em_ethdev.c| 36 -
lib/librte
Software implementation of the Toeplitz hash function used by RSS.
Can be used either for packet distribution on single queue NIC
or for simulating of RSS computation on specific NIC (for example
after GRE header decapsulating).
Signed-off-by: Vladimir Medvedkin
---
lib/librte_hash/Makefile|
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Wednesday, April 8, 2015 2:11 PM
> To: Butler, Siobhan A
> Cc: Thomas Monjalon; dev at dpdk.org
> Subject: Re: [dpdk-dev] tools brainstorming
>
> On Wed, Apr 08, 2015 at 12:16:10PM +, Butler, Siobhan A
On 4/6/2015 6:42 PM, Srinivasreddy R wrote:
> Hi,
> I have observed packet loss with usvhost dpdk interfaces even at a very
> small rate .
> This is because virtqueue [dev->virtqueue] is found to be full,
> and my application should drop the packets .
Maybe your virtio guest is slow in processin
On 4/8/15, 5:43 AM, "Butler, Siobhan A" wrote:
>Hi all,
>To add to the tools brainstorming - I propose we use the following Coding
>Standards as the basis of guidelines on coding style going forward.
>The style outlined below is in alignment with the current convention used
>for the majority of
Hi Neil,
Thanks for the quick response.
The issue got fixed by setting CONFIG_RTE_MACHINE to "default".
Though, this fixed the CRASH issue, I am observing inconsistent behavior
with ACL tables.
With the same traffic and same ACL rule, on ONE machine the ACL rule is
being HIT, where as on the OT
Hi Olivier,
> -Original Message-
> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
> Sent: Wednesday, April 08, 2015 10:44 AM
> To: Ananyev, Konstantin; dev at dpdk.org
> Cc: zoltan.kiss at linaro.org; Richardson, Bruce
> Subject: Re: [PATCH v3 1/5] mbuf: fix clone support when appli
Hi,
I have a machine with 6 DPDK ports (4 igb, 2 ixgbe), with 1.23Mpps traffic
offered to only one of the 10G ports (the other 5 are unused). I also have a
program with a pretty standard looking DPDK receive loop, where it calls
rte_eth_rx_burst() for each configured port. If I configure the
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Butler, Siobhan A
> Sent: Wednesday, April 8, 2015 1:16 PM
> To: Neil Horman
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] tools brainstorming
>
>
>
> > -Original Message-
> > From: Neil Horman [ma
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Wednesday, April 8, 2015 12:44 PM
> To: Butler, Siobhan A
> Cc: Thomas Monjalon; dev at dpdk.org
> Subject: Re: [dpdk-dev] tools brainstorming
>
> On Wed, Apr 08, 2015 at 10:43:53AM +, Butler, Siobhan
On Wed, Apr 08, 2015 at 11:16:03AM -0700, Stephen Hemminger wrote:
> I prefer the file just say that it is BSD or GPL and refer to license files
> in the package. That way if something has to change it doesn't need a
> massive license sweep
Hi guys,
I hope we're also enforcing some requirement
Hi Konstantin,
On 04/07/2015 07:17 PM, Ananyev, Konstantin wrote:
>> Just to be sure we're on the same line:
>>
>> - before the patch series
>>
>> - private area was working before that patch series if clones were not
>> used. To use a private are, the user had to provide another
>>
On Wed, Apr 08, 2015 at 02:40:59PM +, Butler, Siobhan A wrote:
>
>
> > -Original Message-
> > From: Neil Horman [mailto:nhorman at tuxdriver.com]
> > Sent: Wednesday, April 8, 2015 2:11 PM
> > To: Butler, Siobhan A
> > Cc: Thomas Monjalon; dev at dpdk.org
> > Subject: Re: [dpdk-dev] t
On Wed, 8 Apr 2015 16:07:21 +0100
Sergio Gonzalez Monroy wrote:
> Currently, the target/rules to build combined libraries is different
> than the one to build individual libraries.
>
> By removing the combined library option as a build configuration option
> we simplify the build pocess by havi
Thanks for doing this, it is a great start.
I admit strong bias towards Linux kernel style.
Could you use one of the standard markup styles so that it could get put in
documentation?
> License Header
> --
I prefer the file just say that it is BSD or GPL and refer to license files i
This patch depends on the Port Hotplug Framework.
It implements the eth_dev_uninit functions for rte_ixgbe_pmd and
rte_ixgbevf_pmd.pmd.
Signed-off-by: Bernard Iremonger
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 87 +-
lib/librte_pmd_ixgbe/ixgbe_ethdev.h |4 +
We use adaptive polling loop similar to l3fwd-power example.
See:
http://video.fosdem.org/2015/devroom-network_management_and_sdn/
On Wed, Apr 8, 2015 at 9:35 AM, Aaron Campbell wrote:
> Hi,
>
> I have a machine with 6 DPDK ports (4 igb, 2 ixgbe), with 1.23Mpps traffic
> offered to only one of
Hi all,
To add to the tools brainstorming - I propose we use the following Coding
Standards as the basis of guidelines on coding style going forward.
The style outlined below is in alignment with the current convention used for
the majority of the project.
Any thoughts/suggestions or feedback wel
From: Stephen Hemminger
The function documentation was obviously copied and not updated.
Signed-off-by: Stephen Hemminger
---
tools/dpdk_nic_bind.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
index 8523f82..b7bd877 100755
From: Stephen Hemminger
Silence is normal. drivers should speak only when spoken to and not
be chatty.
Signed-off-by: Stephen Hemminger
---
lib/librte_pmd_enic/enic_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c
ind
These are trivial patches found by review
Stephen Hemminger (2):
enic: silence log message
tools: fix comment in bind script
lib/librte_pmd_enic/enic_main.c | 2 --
tools/dpdk_nic_bind.py | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
--
2.1.4
On Wed, Apr 08, 2015 at 12:16:10PM +, Butler, Siobhan A wrote:
>
>
> > -Original Message-
> > From: Neil Horman [mailto:nhorman at tuxdriver.com]
> > Sent: Wednesday, April 8, 2015 12:44 PM
> > To: Butler, Siobhan A
> > Cc: Thomas Monjalon; dev at dpdk.org
> > Subject: Re: [dpdk-dev]
On Tue, Apr 07, 2015 at 02:20:58PM -0700, Stephen Hemminger wrote:
> Remove useless memset, since dev_private is created by rte_zmalloc
> it must already be zero.
>
> Signed-off-by: Stephen Hemminger
> ---
> app/test/virtual_pmd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/app/te
On Wed, Apr 08, 2015 at 02:03:05PM +0530, Venkat Thummala wrote:
> Hi Neil,
>
> Thanks for the quick response.
>
> The issue got fixed by setting CONFIG_RTE_MACHINE to "default".
>
Default is the lowest common demoninator system that dpdk supports (core2 duo).
So if you're system is superior to
On Wed, Apr 08, 2015 at 10:43:53AM +, Butler, Siobhan A wrote:
> Hi all,
> To add to the tools brainstorming - I propose we use the following Coding
> Standards as the basis of guidelines on coding style going forward.
> The style outlined below is in alignment with the current convention used
Hi,
Is there any limit to work with dpdk within different pthreads in parallel to
multi-process system
For example, I will have a system with one primary processes with 4 pthreads
and in addition I will have another 4 secondary processes
All of the above will call to dpdk APIs. Is it possible
On 7 April 2015 at 17:30, Michael S. Tsirkin wrote:
> Just guessing from the available info:
>
> I think you refer to this:
> The driver MUST handle spurious interrupts from the device.
>
> The intent is to be able to handle some spurious interrupts once in a
> while. AFAIK linux trigger
On 07/04/15 11:10 pm, "Thomas Monjalon" wrote:
>The function name is printed in each enic_ethdev function.
>Disable it by default with a new build option.
>
>Signed-off-by: Thomas Monjalon
>---
> config/common_bsdapp | 1 +
> config/common_linuxapp| 1 +
> lib/librte_pmd
Fixes: 8a312224bcde ("eal/bsd: fix fd leak")
Signed-off-by: Raz Amir
---
lib/librte_eal/bsdapp/eal/eal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 871d5f4..e20f915 100644
--- a/lib/librte_eal/bsdapp
Signed-off-by: Raz Amir
---
lib/librte_eal/bsdapp/eal/eal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 871d5f4..e20f915 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal
58 matches
Mail list logo
