The mbuf leak happens when the assigned number of rx descriptor is not power of
2.
As it's presumed on vpmd rx(for rx_tail wrap), adding condition check to
prevent it.
The root cause reference code in *_recv_raw_pkts_vec* as below.
"rxq->rx_tail = (uint16_t)(rxq->rx_tail & (rxq->nb_rx_desc - 1));
X550 should use the correct macro to set the VFTDT and VFRDT register address.
This patch fixes the VF TX issue for Sageville.
Signed-off-by: Changchun Ouyang
---
Change in v2
-- Fix one more mac type: ixgbe_mac_X550EM_x_vf.
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 8 ++--
1 file changed, 6 i
> > Theres no need to export this variable. Its set and queried from an API
> > call
> > that doesn't exist in the hot path. Instead just export the rte_socket_id
> > symbol and make the variable private to protect it from type changes. We
> > should
> > do this with the other exported variabl
2015-03-02 13:23, David Marchand:
> On Mon, Mar 2, 2015 at 12:09 PM, Pawel Wodkowski intel.com
> > wrote:
>
> > On failure devargs->args should not be accesed if devargs is NULL.
>
> accessed.
>
> Fixes: c07691ae1089 ("devargs: remove limit on parameters length")
> Acked-by: David Marchand
Ap
> > This patch set enables i40e TSO feature for both non-tunneling packet and
> > tunneling packet.
> >
> > Change logs:
> > v2 change: rework based on Olivier's patch set [PATCH v2 00/20] enhance
> > Tx checksum offload API
> > http://dpdk.org/ml/archives/dev/2015-February/012375.
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa
> Sent: Wednesday, February 25, 2015 7:32 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v15 13/13] doc: Add port hotplug framework
> section to programmers guide
>
> This patch adds a ne
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John McNamara
> Sent: Wednesday, February 25, 2015 7:46 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 3/3] doc: add docs for the rxtx_callbacks sample
> app
>
> Added a sample application guide for the
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John McNamara
> Sent: Wednesday, February 25, 2015 7:46 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 1/3] examples/skeleton: minor refactoring to
> help documentation
>
> Minor refactoring and comment
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun
> Sent: Monday, March 2, 2015 8:41 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v2] doc: Update prog guide for virtio
>
> This patch add contents for major change in single virtio imp
On 2015-03-02 17:47, Wiles, Keith wrote:
>
>
> On 3/2/15, 8:55 AM, "Wodkowski, PawelX" wrote:
>
>> On 2015-03-02 15:40, Wiles, Keith wrote:
>>>
>>>
>>> On 3/2/15, 6:23 AM, "David Marchand" wrote:
>>>
Hello Pawel,
On Mon, Mar 2, 2015 at 12:09 PM, Pawel Wodkowski
wrote:
>>>
On 22/02/15 12:51, Marc Sune wrote:
> I don't like the proposed patch, but I am recovering this old thread
> because I agree on the problem statement.
>
> On 04/04/14 11:57, Ananyev, Konstantin wrote:
>> Hi Cyril,
>> We already do have 'EXTRA_CFLAGS' and 'EXTRA_LDFLAGS' that you can
>> use to en
Thank you Adrien this is great.
Siobhan
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Adrien Mazarguil
> Sent: Wednesday, February 25, 2015 1:52 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v3 3/3] doc: add librte_pmd_mlx4
> documentation
>
> This
Fixed strict-aliasing rules breaking errors for some GCC version.
Signed-off-by: Zhihong Wang
---
.../common/include/arch/x86/rte_memcpy.h | 44 --
1 file changed, 24 insertions(+), 20 deletions(-)
diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
b
Hi,
lspci command shows the following:
*04:00.0 Ethernet controller: Intel Corporation 82599EB 10-Gigabit SFI/SFP+
Network Connection (rev 01)Subsystem: Hewlett-Packard Company Ethernet 10Gb
2-port 560SFP+ Adapter*
Thanks,
Alexandra
On 2 March 2015 at 11:15, Gonzalez Monroy, Sergio <
sergio.go
Add some contents for vhost sample.
Signed-off-by: Changchun Ouyang
---
doc/guides/sample_app_ug/vhost.rst | 29 +
1 file changed, 29 insertions(+)
diff --git a/doc/guides/sample_app_ug/vhost.rst
b/doc/guides/sample_app_ug/vhost.rst
index fa53db6..756838c 100644
---
On 3/2/15, 8:55 AM, "Wodkowski, PawelX" wrote:
>On 2015-03-02 15:40, Wiles, Keith wrote:
>>
>>
>> On 3/2/15, 6:23 AM, "David Marchand" wrote:
>>
>>> Hello Pawel,
>>>
>>> On Mon, Mar 2, 2015 at 12:09 PM, Pawel Wodkowski
>>> >>> wrote:
>>>
On failure devargs->args should not be accesed if d
This patch add contents for major change in single virtio implementation,
also add back something for merge-able feature and promiscuous mode in virtio.
Signed-off-by: Changchun Ouyang
---
Changes in v2
-- A few words adjusted.
.../prog_guide/poll_mode_drv_emulated_virtio_nic.rst| 17 +++
The contigmem module was using an "int" type for specifying the
size of blocks of memory to be reserved. A 2GB block was therefore
overflowing the signed 32-bit value, making 1GB the largest block
size that could be reserved as a single unit.
The fix is to change the type used for the buffer/block
As hotplug has been enabled, start the testpmd with no nic binded
will show one error log "Please stop the ports first":
Interactive-mode selected
Please stop the ports first
Done
testpmd>
This issue is cause by the logic of check link status.
Signed-off-by: Michael Qiu
---
app/test-pmd/testpm
This patch add contents for major change in single virtio implementation,
also add back something for merge-able feature and promiscuous mode in virtio.
Signed-off-by: Changchun Ouyang
---
.../prog_guide/poll_mode_drv_emulated_virtio_nic.rst| 17 +
1 file changed, 13 insertio
On 2015-03-02 15:40, Wiles, Keith wrote:
>
>
> On 3/2/15, 6:23 AM, "David Marchand" wrote:
>
>> Hello Pawel,
>>
>> On Mon, Mar 2, 2015 at 12:09 PM, Pawel Wodkowski
>> >> wrote:
>>
>>> On failure devargs->args should not be accesed if devargs is NULL.
>>>
>>
>> accessed.
>>
>>
>>>
>>> Signed-off-by
/i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
cast from pointer to integer of different size
[-Werror=pointer-to-int-cast]
dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
Type 'long long' is 64-bit in i686 platform while 'void *'
is 32-bit.
Signed-off-by: Michael Qiu
Ping.
On Thu, Feb 19, 2015 at 04:50:10PM +0200, Gleb Natapov wrote:
> CCing i40e driver author in a hope to get an answer.
>
> On Mon, Feb 16, 2015 at 03:36:54PM +0200, Gleb Natapov wrote:
> > I have an application that works reasonably well with ixgbe driver, but
> > when I try to use it with i4
The following changes since commit ffc468ff3cfe768b0132f851cef6382cd16a3c68:
app/testpmd: fix crash when portmask is specified (2015-02-28 00:24:32 +0100)
are available in the git repository at:
helin at dpdk.org:dpdk-i40e-next.git master
for you to fetch changes up to f8d745171cbddbf3b18ed
On 3/2/15, 6:23 AM, "David Marchand" wrote:
>Hello Pawel,
>
>On Mon, Mar 2, 2015 at 12:09 PM, Pawel Wodkowski
>> wrote:
>
>> On failure devargs->args should not be accesed if devargs is NULL.
>>
>
>accessed.
>
>
>>
>> Signed-off-by: Pawel Wodkowski
>> ---
>> lib/librte_eal/common/eal_common_d
X550 should use the correct macro to set the VFTDT and VFRDT register address.
This patch fixes the VF TX issue for Sageville.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgb
2015-03-02 13:58, Raz Amir:
> BTW, I don't see it in incoming patches page at
> http://dpdk.org/dev/patchwork/project/dpdk/list/?page=1
> Is it because I missed something in the code contribution instruction?
It's here: http://dpdk.org/dev/patchwork/patch/3800/
Thanks.
How should I continue with this patch?
BTW, I don't see it in incoming patches page at
http://dpdk.org/dev/patchwork/project/dpdk/list/?page=1
Is it because I missed something in the code contribution instruction?
-Original Message-
From: Neil Horman [mailto:nhor...@tuxdriver.com]
On 2015-03-02 11:32, Bruce Richardson wrote:
> On Mon, Mar 02, 2015 at 05:03:50PM +0800, zhihong.wang at intel.com wrote:
>> Fixed strict-aliasing rules breaking errors for some GCC version.
>>
>
> This looks messy. Also, I believe the definition of memcpy should include
> the "restrict" keyword to
Hello Pawel,
On Mon, Mar 2, 2015 at 12:09 PM, Pawel Wodkowski wrote:
> On failure devargs->args should not be accesed if devargs is NULL.
>
accessed.
>
> Signed-off-by: Pawel Wodkowski
> ---
> lib/librte_eal/common/eal_common_devargs.c | 7 ---
> 1 file changed, 4 insertions(+), 3 delet
Hi,
I got a error while building master branch on FreeBSD.
Here is a log.
$ gmake T=x86_64-native-bsdapp-clang config
cc: error: unknown argument: '-fdirectives-only'
cp: /usr/home/mukawa/work/dpdk/build/.config_tmp: No such file or directory
cp: /usr/home/mukawa/work/dpdk/build/.config_tmp: No s
On failure devargs->args should not be accesed if devargs is NULL.
Signed-off-by: Pawel Wodkowski
---
lib/librte_eal/common/eal_common_devargs.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_devargs.c
b/lib/librte_eal/common/eal_comm
Hi Helin,
I see that you have removed "uint16_t reserved" member from rte_mbuf:
> + uint16_t data_len;/**< Amount of data in segment buffer. */
> uint16_t vlan_tci;/**< VLAN Tag Control Identifier (CPU order)
> */
> - uint16_t reserved;
> union {
>
On 02/03/2015 07:27, Michael Qiu wrote:
> /i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
> cast from pointer to integer of different size
> [-Werror=pointer-to-int-cast]
>
>dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
>
> Type 'long long' is 64-bit in i686 platform w
Hi guys,
Did you have a chance to look over my question?
Thanks,
Alexandra
On 24 February 2015 at 13:14, Alexandra Sava
wrote:
> Hi guys,
>
> I'm trying to get statistics per queue (on rx side), therefore I'm
> using rte_eth_dev_set_rx_queue_stats_mapping
> function in order to map a partic
On Mon, Mar 02, 2015 at 05:03:50PM +0800, zhihong.wang at intel.com wrote:
> Fixed strict-aliasing rules breaking errors for some GCC version.
>
This looks messy. Also, I believe the definition of memcpy should include
the "restrict" keyword to indicate that source and dest can't overlap. Might
t
On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wrote:
> Hi,
>
> I got a error while building master branch on FreeBSD.
> Here is a log.
>
> $ gmake T=x86_64-native-bsdapp-clang config
> cc: error: unknown argument: '-fdirectives-only'
> cp: /usr/home/mukawa/work/dpdk/build/.config_tmp:
The patch I suggest is in the nic_uio freebsd kernel driver. I don't think
that rte_log can be used there.
I checked the contigmem freebsd driver and it uses printf.
I can either remove those printfs, or keep them.
I suggest keeping them as they were very helpful for understanding the flow,
and the
On Sat, Feb 28, 2015 at 06:08:16PM +, Wiles, Keith wrote:
> Looking that the code below does the rte_mbuf_refcnt_set(m,0) need to be
> present?
>
> static inline struct rte_mbuf* __attribute__((always_inline))
> __rte_pktmbuf_prefree_seg(struct rte_mbuf *m)
> {
> __rte_mbuf_sanity_check(m, 0)
Hi Alexandra,
On 02/03/2015 08:50, Alexandra Sava wrote:
> Hi guys,
>
> Did you have a chance to look over my question?
>
>
>
> Thanks,
> Alexandra
>
>
> On 24 February 2015 at 13:14, Alexandra Sava
> wrote:
>> Hi guys,
>>
>> I'm trying to get statistics per queue (on rx side), therefore I'm
>>
On 2015-02-27 17:24, Ananyev, Konstantin wrote:
> Actually, I wonder wouldn't something like the one below be sufficient?
>
> diff --git a/lib/librte_eal/common/include/rte_common.h
> b/lib/librte_eal/common/
> index 8ac940c..1867692 100644
> --- a/lib/librte_eal/common/include/rte_common.h
> +++
Thank you Changchun some small wording changes noted below
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun
> Sent: Monday, March 2, 2015 8:08 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: Update prog guide for virtio
>
> This p
On Mon, Mar 02, 2015 at 10:18:42AM +0200, Raz Amir wrote:
> The patch I suggest is in the nic_uio freebsd kernel driver. I don't think
> that rte_log can be used there.
> I checked the contigmem freebsd driver and it uses printf.
> I can either remove those printfs, or keep them.
> I suggest keepin
Tested-by: min.cao
Patch name: [dpdk-dev] [PATCH v3 0/3] support TSO on i40e
Test Flag: Tested-by
Tester name:min.cao at intel.com
Result summary: total 3 cases, 3 passed, 0 failed
Test Case 1:
Name: ipv4
E
44 matches
Mail list logo
