[dpdk-dev] Explanation of the QoS offset values used in the QoS scheduler example app.

2015-02-14 Thread Aws Ismail
Hi everyone, I am looking at this portion of the code in the app_thread.c file of the QoS scheduler example application: /* * QoS parameters are encoded as follows: * Outer VLAN ID defines subport * Inner VLAN ID defines pipe * Destination IP 0.0.XXX.0 defines traffic class * Destination IP host

[dpdk-dev] [PATCH 4/4] xen: net-front poll mode driver

2015-02-14 Thread Neil Horman
On Sat, Feb 14, 2015 at 01:06:48PM -0500, Stephen Hemminger wrote: > This driver implements DPDK driver that has the same functionality > as net-front driver in Linux kernel. > > Signed-off-by: Stephen Hemminger > --- > config/common_linuxapp| 6 + > lib/Makefile

[dpdk-dev] [PATCH 1/4] xen: allow choosing dom0 support at runtime

2015-02-14 Thread Neil Horman
On Sat, Feb 14, 2015 at 01:06:45PM -0500, Stephen Hemminger wrote: > The previous code would only allow building library and application > so that it ran on Xen DOM0 or not on DOM0. This changes that to > a runtime flag. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/common/include/

[dpdk-dev] [PATCH 4/4] xen: net-front poll mode driver

2015-02-14 Thread Stephen Hemminger
This driver implements DPDK driver that has the same functionality as net-front driver in Linux kernel. Signed-off-by: Stephen Hemminger --- config/common_linuxapp| 6 + lib/Makefile | 1 + lib/librte_eal/common/eal_private.h | 7 + lib/librte_eal

[dpdk-dev] [PATCH 3/4] xen: add uio driver

2015-02-14 Thread Stephen Hemminger
New uio helper kernel driver for use by Xen netfront UIO poll mode driver. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/Makefile | 3 + lib/librte_eal/linuxapp/xen_uio/Makefile | 55 ++ lib/librte_eal/linuxapp/xen_uio/xen_uio.c | 837 ++ 3

[dpdk-dev] [PATCH 2/4] xen: add phys-addr command line argument

2015-02-14 Thread Stephen Hemminger
Allow overriding default Xen DOM0 behavior to use physical addresses insted of mfn. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_options.c | 5 + lib/librte_eal/common/eal_internal_cfg.h | 1 + lib/librte_eal/common/eal_options.h| 2 ++ lib/librte_eal/co

[dpdk-dev] [PATCH 1/4] xen: allow choosing dom0 support at runtime

2015-02-14 Thread Stephen Hemminger
The previous code would only allow building library and application so that it ran on Xen DOM0 or not on DOM0. This changes that to a runtime flag. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/include/rte_memory.h | 4 +++ lib/librte_eal/linuxapp/eal/eal_memory.c | 7 lib/

[dpdk-dev] [PATCH] Add support to read target/generic/rte.vars.mk file for external builds

2015-02-14 Thread Keith Wiles
The external build of applications does not import the target/generic/rte.vars.mk file, which is needed for locating DPDK headers and libraries. Signed-off-by: Keith Wiles --- mk/rte.extvars.mk | 7 +++ 1 file changed, 7 insertions(+) diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk inde

[dpdk-dev] [PATCH] Add Q variable to external builds to be quite

2015-02-14 Thread Keith Wiles
Signed-off-by: Keith Wiles --- mk/rte.extvars.mk | 4 1 file changed, 4 insertions(+) diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk index 3e5a990..83a5721 100644 --- a/mk/rte.extvars.mk +++ b/mk/rte.extvars.mk @@ -66,6 +66,10 @@ endif RTE_OUTPUT ?= $(RTE_SRCDIR)/build export RTE_OUTP

[dpdk-dev] [PATCH 1/2] enic: replace use of printf with log

2015-02-14 Thread Neil Horman
On Sat, Feb 14, 2015 at 10:32:58AM -0500, Stephen Hemminger wrote: > Device driver should log via DPDK log, not to printf which is > sends to /dev/null in a daemon application. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_pmd_enic/enic_compat.h | 11 +++ > 1 file changed, 7 in

[dpdk-dev] [PATCH 2/2] enic: change probe log message level

2015-02-14 Thread Stephen Hemminger
Drivers should be silent on boot. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_enic/enic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c index 48fdca2..c66f139 100644 --- a/lib/librte_pmd_enic/eni

[dpdk-dev] [PATCH 1/2] enic: replace use of printf with log

2015-02-14 Thread Stephen Hemminger
Device driver should log via DPDK log, not to printf which is sends to /dev/null in a daemon application. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_enic/enic_compat.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/librte_pmd_enic/enic_compat.h b/li

[dpdk-dev] [PATCH 6/6] examples: remove unneeded casts

2015-02-14 Thread Stephen Hemminger
*alloc() routines return void * and therefore cast is not needed. Signed-off-by: Stephen Hemminger --- examples/kni/main.c | 4 ++-- examples/l3fwd-acl/main.c | 4 ++-- examples/vhost/main.c | 7 --- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/kni/main.c

[dpdk-dev] [PATCH 5/6] eal: remove useless memset

2015-02-14 Thread Stephen Hemminger
The path variable is set via snprintf, and does not need to memset before that. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH 4/6] enic: eliminate useless cast

2015-02-14 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/librte_pmd_enic/enic_clsf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_enic/enic_clsf.c b/lib/librte_pmd_enic/enic_clsf.c index 577a382..b61d625 100644 --- a/lib/librte_pmd_enic/enic_clsf.c +++ b/lib/librte_pmd_

[dpdk-dev] [PATCH 3/6] bsd: remove useless assignments

2015-02-14 Thread Stephen Hemminger
If variable is set in the next line, it doesn't need to be initialized. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/eal.c | 3 ++- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/l

[dpdk-dev] [PATCH 2/6] vhost_xen: remove unnecessary cast

2015-02-14 Thread Stephen Hemminger
Don't need to cast malloc family of functions since they return void *. Signed-off-by: Stephen Hemminger --- examples/vhost_xen/vhost_monitor.c | 2 +- examples/vhost_xen/xenstore_parse.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/vhost_xen/vhost_monitor.c

[dpdk-dev] [PATCH 1/6] test: remove unneeded casts

2015-02-14 Thread Stephen Hemminger
The malloc family returns void * and therefore cast is unnecessary. Use calloc rather than zmalloc with multiply for array. Signed-off-by: Stephen Hemminger --- app/test/test_hash_perf.c | 8 app/test/test_mempool.c | 2 +- app/test/test_ring.c | 2 +- 3 files changed, 6 insertio