[dpdk-dev] mk: fix LDFLAGS for shared lib

2014-12-08 Thread Hiroshi Shimamoto
> Subject: Re: [dpdk-dev] mk: fix LDFLAGS for shared lib > > On Wed, Dec 03, 2014 at 11:33:54PM +, Hiroshi Shimamoto wrote: > > From: Hiroshi Shimamoto > > > > Only CPU_LDFLAGS is used in mk/rte.sharelib.mk. > > It should be LDFLAGS to build the library with correct linkage options. > > > > S

[dpdk-dev] [RFC PATCH 00/17] Single virtio implementation

2014-12-08 Thread Stephen Hemminger
I sent the patches to Ouyang with my Signed-off. He did the testing with current DPDK. On Mon, Dec 8, 2014 at 7:23 PM, Qiu, Michael wrote: > On 12/9/2014 9:11 AM, Ouyang, Changchun wrote: > > Hi Thomas, > > > >> -Original Message- > >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wi

[dpdk-dev] DDPK use of MAP_FIXED in mmap

2014-12-08 Thread Karmarkar Suyash
Hello, In DPDK when we use mmap why are we passing the MAP_FIXED flag when Linux man page itself says that the option is discouraged? Any specific reason for passing the MAP_FIXED flag? http://linux.die.net/man/2/mmap MAP_FIXED Don't interpret addr as a hint: place the mapping at exactly that

[dpdk-dev] [PATCH v2] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Burakov, Anatoly
Hi Michael > I don't think so, if we check module "vfio", but if given module name is > "vfio_xx", it will also correct if use strncmp. Sorry I missed this the last time. I don't think that is the case. If you do strncmp on sizeof(buffer), strncmp will always check 30 bytes. That way if you ch

[dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Michael Qiu
When vfio module is not loaded when kernel support vfio feature, the routine still try to open the container to get file description. This action is not safe, and of cause got error messages: EAL: Detected 40 lcore(s) EAL: unsupported IOMMU type! EAL: VFIO support could not be initialized EAL:

[dpdk-dev] (no subject)

2014-12-08 Thread
>From stephen at networkplumber.org Mon Dec 8 09:46:51 2014 Message-Id: <20141208174651.333788346 at networkplumber.org> User-Agent: quilt/0.63-1 Date: Mon, 08 Dec 2014 09:46:00 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev at dpdk.org, Stephen Hemminger Subject: [PATCH 6/6] rte_sc

[dpdk-dev] (no subject)

2014-12-08 Thread
>From stephen at networkplumber.org Mon Dec 8 09:46:51 2014 Message-Id: <20141208174651.282719331 at networkplumber.org> User-Agent: quilt/0.63-1 Date: Mon, 08 Dec 2014 09:45:59 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev at dpdk.org, Stephen Hemminger Subject: [PATCH 5/6] rte_sc

[dpdk-dev] (no subject)

2014-12-08 Thread
>From stephen at networkplumber.org Mon Dec 8 09:46:51 2014 Message-Id: <20141208174651.232055974 at networkplumber.org> User-Agent: quilt/0.63-1 Date: Mon, 08 Dec 2014 09:45:58 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev at dpdk.org, Stephen Hemminger Subject: [PATCH 4/6] rte_sc

[dpdk-dev] (no subject)

2014-12-08 Thread
>From stephen at networkplumber.org Mon Dec 8 09:46:51 2014 Message-Id: <20141208174651.181685914 at networkplumber.org> User-Agent: quilt/0.63-1 Date: Mon, 08 Dec 2014 09:45:57 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev at dpdk.org, Stephen Hemminger Subject: [PATCH 3/6] qos: m

[dpdk-dev] (no subject)

2014-12-08 Thread
>From stephen at networkplumber.org Mon Dec 8 09:46:51 2014 Message-Id: <20141208174651.130426937 at networkplumber.org> User-Agent: quilt/0.63-1 Date: Mon, 08 Dec 2014 09:45:56 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev at dpdk.org, Stephen Hemminger Subject: [PATCH 2/6] ixgbe:

[dpdk-dev] (no subject)

2014-12-08 Thread
>From stephen at networkplumber.org Mon Dec 8 09:46:51 2014 Message-Id: <20141208174651.064719116 at networkplumber.org> User-Agent: quilt/0.63-1 Date: Mon, 08 Dec 2014 09:45:55 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev at dpdk.org, Stephen Hemminger Subject: [PATCH 1/6] rte_lo

[dpdk-dev] (no subject)

2014-12-08 Thread
>From stephen at networkplumber.org Mon Dec 8 09:46:51 2014 Message-Id: <20141208174554.889069531 at networkplumber.org> User-Agent: quilt/0.63-1 Date: Mon, 08 Dec 2014 09:45:54 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev at dpdk.org Subject: [PATCH 0/6] Misc patches for DPDK 1.8

[dpdk-dev] [PATCH] doc: add bsd license to svg file

2014-12-08 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- .../sample_app_ug/img/exception_path_example.svg | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/doc/guides/sample_app_ug/img/exception_path_example.svg b/doc/guides/sample_app_ug/img/exception_path_example.svg

[dpdk-dev] [PATCH 15/15] eal: allow empty set of compile time cpuflags

2014-12-08 Thread Zhigang Lu
On architectures that do not rely on RTE_COMPILE_TIME_CPUFLAGS, the compile_time_flags[] array can end up being zero sized. This results in a compiler complaint in the subsequent loop. Pulling out the array size computation silences this complaint. Signed-off-by: Zhigang Lu Signed-off-by: Cyril

[dpdk-dev] [PATCH 14/15] app/test: turn off cpu flag checks for tile architecture

2014-12-08 Thread Zhigang Lu
Tile processor doesn't have CPU flag hardware registers, so this patch turns off cpu flag checks for tile. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- app/test/test_cpuflags.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_cpuflags.c b/app/t

[dpdk-dev] [PATCH 13/15] pmd/tile: add mPIPE poll mode driver for TileGx

2014-12-08 Thread Zhigang Lu
Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- lib/Makefile |1 + lib/librte_pmd_mpipe/Makefile| 24 + lib/librte_pmd_mpipe/pmd_mpipe.c | 1343 ++ mk/rte.app.mk|4 + 4 files changed, 1372 in

[dpdk-dev] [PATCH 12/15] eal/tile: add mPIPE buffer stack mempool provider

2014-12-08 Thread Zhigang Lu
TileGX: Modified mempool to allow for variable metadata. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- app/test-pmd/mempool_anon.c | 2 +- app/test/Makefile | 6 +- app/test/test_mempool_tile.c | 217 lib/Makefile

[dpdk-dev] [PATCH 11/15] eal/tile: add EAL support for global mPIPE initialization

2014-12-08 Thread Zhigang Lu
The TileGx mPIPE hardware provides Ethernet connectivity, packet classification, and packet load balancing services. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_mpipe.h | 67 ++ lib/librte_eal/linuxapp/eal/Makefile

[dpdk-dev] [PATCH 10/15] eal/tile: add vector operations for TileGx

2014-12-08 Thread Zhigang Lu
Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_common_vect.h | 49 ++ 1 file changed, 49 insertions(+) create mode 100644 lib/librte_eal/common/include/arch/tile/rte_common_vect.h diff --git a/lib/librte_eal/common/includ

[dpdk-dev] [PATCH 09/15] eal: split vector operations to architecture specific

2014-12-08 Thread Zhigang Lu
This patch splits vector operations from DPDK and push them to architecture specific arch directories, so that other processor architecture can implement its own vector functions to support DPDK. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- lib/librte_eal/common/Makefile

[dpdk-dev] [PATCH 08/15] eal/tile: add cycle operations for TileGx

2014-12-08 Thread Zhigang Lu
This patch adds CPU TSC read operations for TileGx. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_cycles.h | 64 ++ 1 file changed, 64 insertions(+) create mode 100644 lib/librte_eal/common/include/arch/tile/rte_cyc

[dpdk-dev] [PATCH 07/15] eal/tile: add CPU flags operations for TileGx

2014-12-08 Thread Zhigang Lu
This patch adds empty functions for CPU flags operations to support DPDK, since tile processor doesn't have CPU flag hardware registers. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_cpuflags.h| 69 ++ 1 file changed,

[dpdk-dev] [PATCH 06/15] eal/tile: add memcpy operations for TileGx

2014-12-08 Thread Zhigang Lu
Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_memcpy.h | 97 ++ 1 file changed, 97 insertions(+) create mode 100644 lib/librte_eal/common/include/arch/tile/rte_memcpy.h diff --git a/lib/librte_eal/common/include/arc

[dpdk-dev] [PATCH 05/15] eal/tile: add prefetch operations for TileGx

2014-12-08 Thread Zhigang Lu
Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_prefetch.h| 62 ++ 1 file changed, 62 insertions(+) create mode 100644 lib/librte_eal/common/include/arch/tile/rte_prefetch.h diff --git a/lib/librte_eal/common/include/a

[dpdk-dev] [PATCH 04/15] eal/tile: add spinlock operations for TileGx

2014-12-08 Thread Zhigang Lu
TileGx uses generic spinlock operations. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_spinlock.h| 47 ++ 1 file changed, 47 insertions(+) create mode 100644 lib/librte_eal/common/include/arch/tile/rte_spinlock.h di

[dpdk-dev] [PATCH 03/15] eal/tile: add byte order operations for TileGx

2014-12-08 Thread Zhigang Lu
This patch adds architecture specific byte swap and endianness operations for TileGx. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_byteorder.h | 70 ++ 1 file changed, 70 insertions(+) create mode 100644 lib/librte_ea

[dpdk-dev] [PATCH 02/15] eal/tile: add atomic operations for TileGx

2014-12-08 Thread Zhigang Lu
This patch adds architecture specific memory barrier operations for TileGx. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- .../common/include/arch/tile/rte_atomic.h | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 lib/librte_eal/common/i

[dpdk-dev] [PATCH 01/15] mk: introduce Tilera Tile architecture

2014-12-08 Thread Zhigang Lu
Add defconfig and rte.vars.mk files for Tile architecture. Signed-off-by: Zhigang Lu Signed-off-by: Cyril Chemparathy --- config/defconfig_tile-tilegx-linuxapp-gcc | 78 +++ mk/arch/tile/rte.vars.mk | 59 +++ mk/machine/tilegx/rte

[dpdk-dev] [PATCH 00/15] Patches for DPDK to support tile architecture

2014-12-08 Thread Zhigang Lu
This patch set adds default configuration, compiling related rte.vars.mk files for tile, and architecture-specific operations for EAL. TileGx processor, as a SOC, contains a on-chip networking engine named mPIPE( multicore Programmable Intelligent Packet Engine). This patch set also adds poll mode

[dpdk-dev] [PATCH v3] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Michael Qiu
When vfio module is not loaded when kernel support vfio feature, the routine still try to open the container to get file description. This action is not safe, and of cause got error messages: EAL: Detected 40 lcore(s) EAL: unsupported IOMMU type! EAL: VFIO support could not be initialized EAL:

[dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Qiu, Michael
On 2014/12/8 20:19, Burakov, Anatoly wrote: >> When vfio module is not loaded when kernel support vfio feature, the >> routine still try to open the container to get file description. >> >> This action is not safe, and of cause got error messages: >> >> EAL: Detected 40 lcore(s) >> EAL: unsupport

[dpdk-dev] error: value computed is not used

2014-12-08 Thread Wodkowski, PawelX
> -Original Message- > From: Qiu, Michael > Sent: Monday, December 08, 2014 4:24 PM > To: Wodkowski, PawelX; dev at dpdk.org > Subject: Re: error: value computed is not used > > On 2014/12/8 19:00, Wodkowski, PawelX wrote: > >> lib/librte_pmd_enic/enic_main.c: In function 'enic_set_rsske

[dpdk-dev] error: value computed is not used

2014-12-08 Thread Qiu, Michael
On 2014/12/8 19:00, Wodkowski, PawelX wrote: >> lib/librte_pmd_enic/enic_main.c: In function ?enic_set_rsskey?: >> lib/librte_pmd_enic/enic_main.c:862:2: error: value computed is not used >> >> I dig out that, it was ome issue of the macros rte_memcpy() >> #define rte_memcpy(dst, src, n)

[dpdk-dev] [PATCH 11/15] eal/tile: add EAL support for global mPIPE initialization

2014-12-08 Thread Neil Horman
On Mon, Dec 08, 2014 at 04:59:34PM +0800, Zhigang Lu wrote: > The TileGx mPIPE hardware provides Ethernet connectivity, > packet classification, and packet load balancing services. > > Signed-off-by: Zhigang Lu > Signed-off-by: Cyril Chemparathy > --- > .../common/include/arch/tile/rte_mpipe.h

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-08 Thread Qiu, Michael
On 2014/12/8 19:38, Neil Horman wrote: > On Mon, Dec 08, 2014 at 03:37:19AM +, Qiu, Michael wrote: >> On 12/8/2014 11:00 AM, Neil Horman wrote: >>> On Mon, Dec 08, 2014 at 02:46:51AM +, Qiu, Michael wrote: On 12/5/2014 11:25 PM, Neil Horman wrote: > On Fri, Dec 05, 2014 at 03:02:33

[dpdk-dev] [PATCH v2] bond: fix for mac assignment to slaves device

2014-12-08 Thread Wodkowski, PawelX
> -Original Message- > From: Doherty, Declan > Sent: Monday, December 08, 2014 12:20 PM > To: dev at dpdk.org > Cc: Wodkowski, PawelX; Jiajia, SunX; Doherty, Declan > Subject: [PATCH v2] bond: fix for mac assignment to slaves device > > -V2: > Tidies up the slave_remove function as per P

[dpdk-dev] [RFC PATCH 17/17] virtio: Use port IO to get PCI resource.

2014-12-08 Thread Ouyang Changchun
Make virtio not require UIO for some security reasons, this is to match 6Wind's virtio-net-pmd. Signed-off-by: Changchun Ouyang --- lib/librte_eal/common/include/rte_pci.h | 2 + lib/librte_eal/linuxapp/eal/eal_pci.c | 3 +- lib/librte_pmd_virtio/virtio_ethdev.c | 75 +

[dpdk-dev] [RFC PATCH 16/17] virtio: Free mbuf's with threshold

2014-12-08 Thread Ouyang Changchun
This makes virtio driver work like ixgbe. Transmit buffers are held until a transmit threshold is reached. The previous behavior was to hold mbuf's until the ring entry was reused which caused more memory usage than needed. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- li

[dpdk-dev] [RFC PATCH 15/17] virtio: Add ability to set MAC address

2014-12-08 Thread Ouyang Changchun
Need to have do special things to set default mac address. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.h | 5 + lib/librte_pmd_virtio/virtio_ethdev.c | 24 2 files changed, 29 insertions(+) diff --git a/

[dpdk-dev] [RFC PATCH 14/17] virtio: Add suport for multiple mac addresses

2014-12-08 Thread Ouyang Changchun
Virtio support multiple MAC addresses. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 94 ++- lib/librte_pmd_virtio/virtio_ethdev.h | 3 +- lib/librte_pmd_virtio/virtqueue.h | 34 - 3

[dpdk-dev] [RFC PATCH 13/17] virtio: Add support for vlan filtering

2014-12-08 Thread Ouyang Changchun
Virtio supports vlan filtering. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd

[dpdk-dev] [RFC PATCH 12/17] virtio: Move allocation before initialization

2014-12-08 Thread Ouyang Changchun
If allocation fails, don't want to leave virtio device stuck in middle of initialization sequence. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/li

[dpdk-dev] [RFC PATCH 11/17] virtio: Check for packet headroom at compile time

2014-12-08 Thread Ouyang Changchun
Better to check at compile time than fail at runtime. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virti

[dpdk-dev] [RFC PATCH 10/17] virtio: Make vtpci_get_status local

2014-12-08 Thread Ouyang Changchun
Make vtpci_get_status a local function as it is used in one file. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_pci.c | 4 +++- lib/librte_pmd_virtio/virtio_pci.h | 2 -- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librt

[dpdk-dev] [RFC PATCH 09/17] virtio: Fix how states are handled during initialization

2014-12-08 Thread Ouyang Changchun
Change order of initialiazation to match Linux kernel. Don't blow away control queue by doing reset when stopped. Calling dev_stop then dev_start would not work. Dev_stop was calling virtio reset and that would clear all queues and clear all feature negotiation. Resolved by only doing reset on dev

[dpdk-dev] [RFC PATCH 08/17] virtio: Remove redundant vq_alignment

2014-12-08 Thread Ouyang Changchun
Since vq_alignment is constant (always 4K), it does not need to be part of the vring struct. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 1 - lib/librte_pmd_virtio/virtio_rxtx.c | 2 +- lib/librte_pmd_virtio/virtqueue.h | 3

[dpdk-dev] [RFC PATCH 07/17] virtio: Remove unnecessary adapter structure

2014-12-08 Thread Ouyang Changchun
Cleanup virtio code by eliminating unnecessary nesting of virtio hardware structure inside adapter structure. Also allows removing unneeded macro, making code clearer. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 43 ---

[dpdk-dev] [RFC PATCH 06/17] virtio: Use software vlan stripping

2014-12-08 Thread Ouyang Changchun
Implement VLAN stripping in software. This allows application to be device independent. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.h | 3 +++ lib/librte_pmd_virtio/virtio_ethdev.c | 2 ++ lib/librte_pmd_virtio/virtio_pci.h| 1

[dpdk-dev] [RFC PATCH 05/17] ether: Add soft vlan encap/decap functions

2014-12-08 Thread Ouyang Changchun
It is helpful to allow device drivers that don't support hardware VLAN stripping to emulate this in software. This allows application to be device independent. Avoid discarding shared mbufs. Make a copy in rte_vlan_insert() of any packet to be tagged that has a reference count > 1. Signed-off-by:

[dpdk-dev] [RFC PATCH 04/17] virtio: Add support for Link State interrupt

2014-12-08 Thread Ouyang Changchun
Virtio has link state interrupt which can be used. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 78 +++ lib/librte_pmd_virtio/virtio_pci.c| 22 ++ lib/librte_pmd_virtio/virtio_pci.h|

[dpdk-dev] [RFC PATCH 03/17] virtio: Allow starting with link down

2014-12-08 Thread Ouyang Changchun
Starting driver with link down should be ok, it is with every other driver. So just allow it. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/librte_pmd_virti

[dpdk-dev] [RFC PATCH 02/17] virtio: Use weaker barriers

2014-12-08 Thread Ouyang Changchun
The DPDK driver only has to deal with the case of running on PCI and with SMP. In this case, the code can use the weaker barriers instead of using hard (fence) barriers. This will help performance. The rationale is explained in Linux kernel virtio_ring.h. To make it clearer that this is a virtio t

[dpdk-dev] [RFC PATCH 01/17] virtio: Rearrange resource initialization

2014-12-08 Thread Ouyang Changchun
For clarity make the setup of PCI resources for Linux into a function rather than block of code #ifdef'd in middle of dev_init. Signed-off-by: Changchun Ouyang Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 76 --- 1 file changed, 43

[dpdk-dev] [RFC PATCH 00/17] Single virtio implementation

2014-12-08 Thread Ouyang Changchun
This is RFC patch for single virtio implementation. Why we need single virtio? As we know currently there are at least 3 virtio PMD driver implementations: A) lib/librte_pmd_virtio(refer as virtio A); B) virtio_net_pmd by 6wind(refer as virtio B); C) virtio by Brocade/

[dpdk-dev] [PATCH 01/15] mk: introduce Tilera Tile architecture

2014-12-08 Thread Cyril Chemparathy
On 12/8/2014 6:25 AM, Neil Horman wrote: > On Mon, Dec 08, 2014 at 11:09:13AM +, Bruce Richardson wrote: >> On Mon, Dec 08, 2014 at 04:59:24PM +0800, Zhigang Lu wrote: >>> Add defconfig and rte.vars.mk files for Tile architecture. >>> >>> Signed-off-by: Zhigang Lu >>> Signed-off-by: Cyril Chem

[dpdk-dev] [PATCH 11/15] eal/tile: add EAL support for global mPIPE initialization

2014-12-08 Thread Cyril Chemparathy
Hi Neil, On 12/8/2014 12:03 PM, Neil Horman wrote: > On Mon, Dec 08, 2014 at 04:59:34PM +0800, Zhigang Lu wrote: >> The TileGx mPIPE hardware provides Ethernet connectivity, >> packet classification, and packet load balancing services. >> >> Signed-off-by: Zhigang Lu >> Signed-off-by: Cyril Chem

[dpdk-dev] [PATCH 02/15] eal/tile: add atomic operations for TileGx

2014-12-08 Thread Cyril Chemparathy
On 12/8/2014 6:28 AM, Neil Horman wrote: > On Mon, Dec 08, 2014 at 04:59:25PM +0800, Zhigang Lu wrote: >> This patch adds architecture specific memory barrier operations for >> TileGx. >> >> Signed-off-by: Zhigang Lu >> Signed-off-by: Cyril Chemparathy >> --- [...] >> +__sync_synchronize(); >

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-08 Thread Thomas Monjalon
2014-12-08 06:37, Neil Horman: > On Mon, Dec 08, 2014 at 03:37:19AM +, Qiu, Michael wrote: > > On 12/8/2014 11:00 AM, Neil Horman wrote: > > > On Mon, Dec 08, 2014 at 02:46:51AM +, Qiu, Michael wrote: > > >> On 12/5/2014 11:25 PM, Neil Horman wrote: > > >>> On Fri, Dec 05, 2014 at 03:02:33P

[dpdk-dev] reviews needed to help closing the release

2014-12-08 Thread Thomas Monjalon
Hello, The goal is to release the version 1.8.0 at the end of this week. It would very helpful to have more reviews on pending patches. To make things clear, the patches which must not be applied in this release, have been moved in "Deferred" state in patchwork: http://dpdk.org/dev/patchwo

[dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Burakov, Anatoly
> When vfio module is not loaded when kernel support vfio feature, the > routine still try to open the container to get file description. > > This action is not safe, and of cause got error messages: > > EAL: Detected 40 lcore(s) > EAL: unsupported IOMMU type! > EAL: VFIO support could not be i

[dpdk-dev] [PATCH v3] mbuf: fix of enabling all newly added RX error flags

2014-12-08 Thread Thomas Monjalon
Hi Helin, 2014-12-06 09:33, Helin Zhang: > Before redefining mbuf structure, there was lack of free bits in 'ol_flags' > (32 bits in total) for new RX or TX flags. So it tried to reuse existant > bits as most as possible, or even assigning 0 to some of bit flags. After > new mbuf structure defined

[dpdk-dev] [PATCH 3/3] test-pmd:change tx_checksum command and csum forwarding engine

2014-12-08 Thread Ananyev, Konstantin
Hi Jijiang, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jijiang Liu > Sent: Sunday, December 07, 2014 11:36 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 3/3] test-pmd:change tx_checksum command and csum > forwarding engine > > The patch enhance

[dpdk-dev] [PATCH] doc: typos corrected in distributor application

2014-12-08 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Friday, December 5, 2014 4:08 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: typos corrected in distributor application > > corrected couple of typos in distributor application

[dpdk-dev] [PATCH] doc: add license header to link bonding diagrams

2014-12-08 Thread Declan Doherty
Signed-off-by: Declan Doherty --- doc/guides/prog_guide/img/bond-mode-0.svg | 34 + doc/guides/prog_guide/img/bond-mode-1.svg | 34 + doc/guides/prog_guide/img/bond-mode-2.svg | 34 + doc/guides/prog_guide/

[dpdk-dev] [PATCH v2] bond: fix for mac assignment to slaves device

2014-12-08 Thread Declan Doherty
-V2: Tidies up the slave_remove function as per Pawel's comments. Adding call to mac_address_slaves_update from the lsc handler when the first slave become active to propagate any mac changes made while devices are inactive Changed removing slave logic to use memmove instead of memcpy to move dat

[dpdk-dev] [PATCH 01/15] mk: introduce Tilera Tile architecture

2014-12-08 Thread Bruce Richardson
On Mon, Dec 08, 2014 at 04:59:24PM +0800, Zhigang Lu wrote: > Add defconfig and rte.vars.mk files for Tile architecture. > > Signed-off-by: Zhigang Lu > Signed-off-by: Cyril Chemparathy > --- > config/defconfig_tile-tilegx-linuxapp-gcc | 78 > +++ > mk/arch/tile/rte

[dpdk-dev] error: value computed is not used

2014-12-08 Thread Wodkowski, PawelX
> lib/librte_pmd_enic/enic_main.c: In function 'enic_set_rsskey': > lib/librte_pmd_enic/enic_main.c:862:2: error: value computed is not used > > I dig out that, it was ome issue of the macros rte_memcpy() > #define rte_memcpy(dst, src, n) \ > ((__builtin_constant_p(n)) ?

[dpdk-dev] [PATCH v2 2/2] mbuf: assign valid bit values for some RX and TX flags

2014-12-08 Thread Ananyev, Konstantin
> -Original Message- > From: Zhang, Helin > Sent: Saturday, December 06, 2014 1:08 AM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: Cao, Waterman; Cao, Min; Wu, Jingjing; Liu, Jijiang; olivier.matz at > 6wind.com > Subject: RE: [PATCH v2 2/2] mbuf: assign valid bit values for some RX

[dpdk-dev] [PATCH v3] mbuf: fix of enabling all newly added RX error flags

2014-12-08 Thread Ananyev, Konstantin
Hi Helin, > -Original Message- > From: Zhang, Helin > Sent: Saturday, December 06, 2014 1:34 AM > To: dev at dpdk.org > Cc: Cao, Waterman; Cao, Min; olivier.matz at 6wind.com; Ananyev, Konstantin; > Zhang, Helin > Subject: [PATCH v3] mbuf: fix of enabling all newly added RX error flags >

[dpdk-dev] [RFC PATCH 00/17] Single virtio implementation

2014-12-08 Thread Thomas Monjalon
Hi Changchun, 2014-12-08 14:21, Ouyang Changchun: > This patch set bases on two original RFC patch sets from Stephen > Hemminger[stephen at networkplumber.org] > Refer to [http://dpdk.org/ml/archives/dev/2014-August/004845.html ] for the > original one. > This patch set also resolves some confli

[dpdk-dev] [PATCH v3] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Qiu, Michael
On 12/8/2014 5:54 PM, Burakov, Anatoly wrote: >> When vfio module is not loaded when kernel support vfio feature, the >> routine still try to open the container to get file description. >> >> This action is not safe, and of cause got error messages: >> >> EAL: Detected 40 lcore(s) >> EAL: unsuppo

[dpdk-dev] lib: include rte_memory.h for __rte_cache_aligned

2014-12-08 Thread Neil Horman
On Fri, Nov 07, 2014 at 09:28:09AM -0800, Jia Yu wrote: > Include rte_memory.h for lib files that use __rte_cache_aligned > attribute. > > Signed-off-by: Jia Yu > Why? I presume there was a build break or something. Please repost with a changelog that details what this patch is for. Neil > --

[dpdk-dev] mk: fix LDFLAGS for shared lib

2014-12-08 Thread Neil Horman
On Wed, Dec 03, 2014 at 11:33:54PM +, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > Only CPU_LDFLAGS is used in mk/rte.sharelib.mk. > It should be LDFLAGS to build the library with correct linkage options. > > Signed-off-by: Hiroshi Shimamoto > Reviewed-by: Hayato Momma > > --- >

[dpdk-dev] [PATCH v3] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Burakov, Anatoly
> When vfio module is not loaded when kernel support vfio feature, the > routine still try to open the container to get file description. > > This action is not safe, and of cause got error messages: > > EAL: Detected 40 lcore(s) > EAL: unsupported IOMMU type! > EAL: VFIO support could not be i

[dpdk-dev] mk: fix app linking for combined libs

2014-12-08 Thread Neil Horman
On Thu, Oct 23, 2014 at 04:36:44PM +0100, Sergio Gonzalez Monroy wrote: > Building combined shared libraries results in applications being linked > against separeted/individual and combined libs altogether. > > Link only against combined lib when the config option is enabled. > > Signed-off-by: S

[dpdk-dev] mk: fix build 32bits shared libs on 64bits system

2014-12-08 Thread Neil Horman
On Wed, Oct 22, 2014 at 05:36:22PM +0100, Sergio Gonzalez Monroy wrote: > Incompatible libraries error when building shared libraries for 32bits on > a 64bits system. > Fix issue by passing CPU_CFLAGS to CC when LINK_USING_CC is enabled. > > Signed-off-by: Sergio Gonzalez Monroy > Acked-by: Pablo

[dpdk-dev] [dpdk-dev, pcap] pcap: fix build of all-in-one shared library

2014-12-08 Thread Neil Horman
On Tue, Oct 07, 2014 at 12:14:04AM +0100, stepan wrote: > Build of some of the test binaries fails when the following flags are enabled: > > CONFIG_RTE_LIBRTE_PMD_PCAP=y > CONFIG_RTE_BUILD_SHARED_LIB=y > CONFIG_RTE_BUILD_COMBINE_LIBS=y > > The binarieas are missing symbols from libpcap. This > pa

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-08 Thread Neil Horman
On Tue, Jul 08, 2014 at 12:16:24PM +0100, Daniel Mrzyglod wrote: > Signed-off-by: Daniel Mrzyglod > > --- > examples/l3fwd-vf/main.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/examples/l3fwd-vf/main.c b/examples/l3fwd-vf/main.c > index 2ca5c21..57852d0 10064

[dpdk-dev] [PATCH] bond: fix for mac assignment to slaves device

2014-12-08 Thread Wodkowski, PawelX
Some formatting issues during posting. I was talking about parenthesis in count calculation (sizeof(internals->slaves[0]) * internals->slave_count - i - 1));

[dpdk-dev] [PATCH 02/15] eal/tile: add atomic operations for TileGx

2014-12-08 Thread Neil Horman
On Mon, Dec 08, 2014 at 04:59:25PM +0800, Zhigang Lu wrote: > This patch adds architecture specific memory barrier operations for > TileGx. > > Signed-off-by: Zhigang Lu > Signed-off-by: Cyril Chemparathy > --- > .../common/include/arch/tile/rte_atomic.h | 62 > ++

[dpdk-dev] [PATCH 01/15] mk: introduce Tilera Tile architecture

2014-12-08 Thread Neil Horman
On Mon, Dec 08, 2014 at 11:09:13AM +, Bruce Richardson wrote: > On Mon, Dec 08, 2014 at 04:59:24PM +0800, Zhigang Lu wrote: > > Add defconfig and rte.vars.mk files for Tile architecture. > > > > Signed-off-by: Zhigang Lu > > Signed-off-by: Cyril Chemparathy > > --- > > config/defconfig_tile

[dpdk-dev] [PATCH] bond: fix for mac assignment to slaves device

2014-12-08 Thread Wodkowski, PawelX
> + memmove(&internals->slaves[i], &internals- > >slaves[i+1], > + (sizeof(internals->slaves[0]) * ^^^ > + internals->slave_count - i

[dpdk-dev] error: value computed is not used

2014-12-08 Thread Qiu, Michael
Hi all, My platform is: uname -a Linux suse-11-sp3 3.0.77-0.11-xen #1 SMP Tue Mar 11 16:48:56 CST 2014 x86_64 x86_64 x86_64 GNU/Linux gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib64/gcc/x86_64-suse-linux/4.5/lto-wrapper Target: x86_64-suse-linux Configured with: ../con

[dpdk-dev] [PATCH v2] VFIO: Avoid to enable vfio while the module not loaded

2014-12-08 Thread Qiu, Michael
On 12/5/2014 6:00 PM, Burakov, Anatoly wrote: > Hi Michael, > > Few nitpicks :-) (wording of the log message I guess is up to Thomas, I won't > comment on that) > >> lib/librte_eal/common/eal_private.h| 36 >> ++ >> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c |

[dpdk-dev] [PATCH] bond: fix for mac assignment to slaves device

2014-12-08 Thread Jiajia, SunX
Tested-by: Jiajia, SunX - Tested Commit: 29d03f7aa33edc3292bf75730ec684dd4cbe5054 - OS: Fedora20 3.11.10-301.fc20.x86_64 - GCC: gcc version 4.8.3 - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection [8086:10fb] - Default x86_64-

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-08 Thread Neil Horman
On Mon, Dec 08, 2014 at 03:37:19AM +, Qiu, Michael wrote: > On 12/8/2014 11:00 AM, Neil Horman wrote: > > On Mon, Dec 08, 2014 at 02:46:51AM +, Qiu, Michael wrote: > >> On 12/5/2014 11:25 PM, Neil Horman wrote: > >>> On Fri, Dec 05, 2014 at 03:02:33PM +, Bruce Richardson wrote: > O

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-08 Thread Qiu, Michael
On 12/8/2014 11:39 AM, Qiu, Michael wrote: > On 12/8/2014 11:00 AM, Neil Horman wrote: >> On Mon, Dec 08, 2014 at 02:46:51AM +, Qiu, Michael wrote: >>> On 12/5/2014 11:25 PM, Neil Horman wrote: On Fri, Dec 05, 2014 at 03:02:33PM +, Bruce Richardson wrote: > On Fri, Dec 05, 2014 at

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-08 Thread Qiu, Michael
On 12/8/2014 11:00 AM, Neil Horman wrote: > On Mon, Dec 08, 2014 at 02:46:51AM +, Qiu, Michael wrote: >> On 12/5/2014 11:25 PM, Neil Horman wrote: >>> On Fri, Dec 05, 2014 at 03:02:33PM +, Bruce Richardson wrote: On Fri, Dec 05, 2014 at 09:22:05AM -0500, Neil Horman wrote: > On Fri

[dpdk-dev] [PATCH v3] Fix two compile issues with i686 platform

2014-12-08 Thread Qiu, Michael
On 12/5/2014 11:25 PM, Neil Horman wrote: > On Fri, Dec 05, 2014 at 03:02:33PM +, Bruce Richardson wrote: >> On Fri, Dec 05, 2014 at 09:22:05AM -0500, Neil Horman wrote: >>> On Fri, Dec 05, 2014 at 04:31:47PM +0800, Chao Zhu wrote: On 2014/12/4 17:12, Michael Qiu wrote: > lib/librte_ea

[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

2014-12-08 Thread Qiu, Michael
On 12/4/2014 9:35 PM, Michael Qiu wrote: > app/test-pmd/csumonly.c: In function ?get_psd_sum?: > build/include/rte_ip.h:161: error: dereferencing pointer ?u16? > does break strict-aliasing rules > build/include/rte_ip.h:157: note: initialized from here > ... > > The root cause is th

[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

2014-12-08 Thread Qiu, Michael
On 12/5/2014 5:26 PM, Thomas Monjalon wrote: > 2014-12-05 05:34, Qiu, Michael: >> Any comments about this version? a new workaround solution :) > Yes, one comment: I think it's ugly :) > These aliasing errors are not reliable so I think we can disable it (like > Linux does). > But in case you don't