[dpdk-dev] [PATCH v3 13/13] testpmd: add a verbose mode csum forward engine

2014-11-20 Thread Olivier Matz
If the user specifies 'set verbose 1' in testpmd command line, the csum forward engine will dump some informations about received and transmitted packets, especially which flags are set and what values are assigned to l2_len, l3_len, l4_len and tso_segsz. This can help someone implementing TSO or

[dpdk-dev] [PATCH v3 12/13] testpmd: support TSO in csum forward engine

2014-11-20 Thread Olivier Matz
Add two new commands in testpmd: - tso set - tso show These commands can be used enable TSO when transmitting TCP packets in the csum forward engine. Ex: set fwd csum tx_checksum set ip hw 0 tso set 800 0 start Signed-off-by: Olivier Matz --- app/test-pmd/cmdline.c | 92 ++

[dpdk-dev] [PATCH v3 11/13] ixgbe: support TCP segmentation offload

2014-11-20 Thread Olivier Matz
Implement TSO (TCP segmentation offload) in ixgbe driver. The driver is now able to use PKT_TX_TCP_SEG mbuf flag and mbuf hardware offload infos (l2_len, l3_len, l4_len, tso_segsz) to configure the hardware support of TCP segmentation. In ixgbe, when doing TSO, the IP length must not be included i

[dpdk-dev] [PATCH v3 10/13] mbuf: generic support for TCP segmentation offload

2014-11-20 Thread Olivier Matz
Some of the NICs supported by DPDK have a possibility to accelerate TCP traffic by using segmentation offload. The application prepares a packet with valid TCP header with size up to 64K and deleguates the segmentation to the NIC. Implement the generic part of TCP segmentation offload in rte_mbuf.

[dpdk-dev] [PATCH v3 09/13] mbuf: introduce new checksum API

2014-11-20 Thread Olivier Matz
Introduce new functions to calculate checksums. These new functions are derivated from the ones provided csumonly.c but slightly reworked. There is still some room for future optimization of these functions (maybe SSE/AVX, ...). This API will be modified in tbe next commits by the introduction of

[dpdk-dev] [PATCH v3 08/13] testpmd: rework csum forward engine

2014-11-20 Thread Olivier Matz
The csum forward engine was becoming too complex to be used and extended (the next commits want to add the support of TSO): - no explaination about what the code does - code is not factorized, lots of code duplicated, especially between ipv4/ipv6 - user command line api: use of bitmasks that nee

[dpdk-dev] [PATCH v3 07/13] testpmd: fix use of offload flags in testpmd

2014-11-20 Thread Olivier Matz
In testpmd the rte_port->tx_ol_flags flag was used in 2 incompatible manners: - sometimes used with testpmd specific flags (0xff for checksums, and bit 11 for vlan) - sometimes assigned to m->ol_flags directly, which is wrong in case of checksum flags This commit replaces the hardcoded values

[dpdk-dev] [PATCH v3 06/13] mbuf: add functions to get the name of an ol_flag

2014-11-20 Thread Olivier Matz
In test-pmd (rxonly.c), the code is able to dump the list of ol_flags. The issue is that the list of flags in the application has to be synchronized with the flags defined in rte_mbuf.h. This patch introduces 2 new functions rte_get_rx_ol_flag_name() and rte_get_tx_ol_flag_name() that returns the

[dpdk-dev] [PATCH v3 05/13] mbuf: remove too specific PKT_TX_OFFLOAD_MASK definition

2014-11-20 Thread Olivier Matz
This definition is specific to Intel PMD drivers and its definition "indicate what bits required for building TX context" shows that it should not be in the generic rte_mbuf.h but in the PMD driver. Signed-off-by: Olivier Matz Acked-by: Bruce Richardson --- lib/librte_mbuf/rte_mbuf.h| 5

[dpdk-dev] [PATCH v3 04/13] mbuf: add help about TX checksum flags

2014-11-20 Thread Olivier Matz
Describe how to use hardware checksum API. Signed-off-by: Olivier Matz Acked-by: Bruce Richardson --- lib/librte_mbuf/rte_mbuf.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index d3eba44..0c96b00

[dpdk-dev] [PATCH v3 03/13] mbuf: reorder tx ol_flags

2014-11-20 Thread Olivier Matz
The tx mbuf flags are now ordered from the lowest value to the the highest. Add comments to explain where to add new flags. By the way, move the PKT_TX_VXLAN_CKSUM at the right place. Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 17 + 1 file changed, 9 insertions

[dpdk-dev] [PATCH v3 02/13] ixgbe: fix remaining pkt_flags variable size to 64 bits

2014-11-20 Thread Olivier Matz
Since commit 4332beee9 "mbuf: expand ol_flags field to 64-bits", the packet flags are now 64 bits wide. Some occurences were forgotten in the ixgbe driver. Signed-off-by: Olivier Matz Acked-by: Bruce Richardson --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 12 ++-- 1 file changed, 6 insertion

[dpdk-dev] [PATCH v3 01/13] igb/ixgbe: fix IP checksum calculation

2014-11-20 Thread Olivier Matz
According to Intel? 82599 10 GbE Controller Datasheet (Table 7-38), both L2 and L3 lengths are needed to offload the IP checksum. Note that the e1000 driver does not need to be patched as it already contains the fix. Signed-off-by: Olivier Matz Acked-by: Konstantin Ananyev --- lib/librte_pmd_e

[dpdk-dev] [PATCH v3 00/13] add TSO support

2014-11-20 Thread Olivier Matz
This series add TSO support in ixgbe DPDK driver. This is a rework of the series sent earlier this week [1]. This work is based on another version [2] that was posted several months ago and which included a mbuf rework that is now in mainline. Changes in v3: - indicate that rte_get_rx_ol_flag_nam

[dpdk-dev] DPDK Community Conference Call - Friday 31st October

2014-11-20 Thread O'driscoll, Tim
The video is now accessible at: http://youtu.be/AbHQ4YaWY90. Thomas may want to add a link to this from somewhere on the dpdk.org page. Tim > From: Kevin Wilson [mailto:wkevils at gmail.com] > > Hi, > >I'll post a recording of it soon. > Great idea! most welcomed! > > Kevin > > > On Thu, No

[dpdk-dev] versioning and maintenance

2014-11-20 Thread Thomas Monjalon
2014-11-20 13:25, Neil Horman: > On Thu, Nov 20, 2014 at 06:09:10PM +0100, Thomas Monjalon wrote: > > 2014-11-19 10:13, Neil Horman: > > > On Wed, Nov 19, 2014 at 11:35:08AM +, Bruce Richardson wrote: > > > > On Wed, Nov 19, 2014 at 12:22:14PM +0100, Thomas Monjalon wrote: > > > > > Following t

[dpdk-dev] versioning and maintenance

2014-11-20 Thread Neil Horman
On Thu, Nov 20, 2014 at 10:08:25PM +0100, Thomas Monjalon wrote: > 2014-11-20 13:25, Neil Horman: > > On Thu, Nov 20, 2014 at 06:09:10PM +0100, Thomas Monjalon wrote: > > > 2014-11-19 10:13, Neil Horman: > > > > On Wed, Nov 19, 2014 at 11:35:08AM +, Bruce Richardson wrote: > > > > > On Wed, Nov

[dpdk-dev] DPDK Community Conference Call - Friday 31st October

2014-11-20 Thread Kevin Wilson
Hi, >I'll post a recording of it soon. Great idea! most welcomed! Kevin On Thu, Nov 20, 2014 at 3:13 PM, O'driscoll, Tim wrote: > Hi Kevin, > >> From: Kevin Wilson [mailto:wkevils at gmail.com] >> > We'll schedule a follow-up call for 2 weeks' time >> Just a short question - is this still inten

[dpdk-dev] [PATCH] testpmd: Add port hotplug support

2014-11-20 Thread Tetsuya Mukawa
The patch introduces following commands. - port [attach|detach] [p|v] [ident] - attach: attaching a port - detach: detaching a port - p: physical port - v: virtual port - ident: pci address of physical device. Or device name and paramerters of virtual device. (ex. :02:00

[dpdk-dev] [PATCH] librte_pmd_pcap: Add port hotplug support

2014-11-20 Thread Tetsuya Mukawa
This patch adds finalization code to free resources allocated by the PMD. Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_pcap/rte_eth_pcap.c | 33 + 1 file changed, 33 insertions(+) diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte_eth_

[dpdk-dev] versioning and maintenance

2014-11-20 Thread Thomas Monjalon
Hi, 2014-11-19 10:13, Neil Horman: > On Wed, Nov 19, 2014 at 11:35:08AM +, Bruce Richardson wrote: > > On Wed, Nov 19, 2014 at 12:22:14PM +0100, Thomas Monjalon wrote: > > > Following the discussion we had with Neil during the conference call, > > > I suggest this plan, starting with the next

[dpdk-dev] [PATCH 25/25] eal: Enable port hotplug framework in Linux

2014-11-20 Thread Tetsuya Mukawa
The patch enables CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux configuration. Signed-off-by: Tetsuya Mukawa --- config/common_linuxapp | 5 + 1 file changed, 5 insertions(+) diff --git a/config/common_linuxapp b/config/common_linuxapp index 57b61c9..a2b1e36 100644 --- a/config/common_linuxapp +++

[dpdk-dev] [PATCH 24/25] eal/pci: Add port hotplug functions for physical devices.

2014-11-20 Thread Tetsuya Mukawa
The patch adds rte_eal_dev_attach_pdev() and rte_eal_dev_detach_pdev(). rte_eal_dev_attach_pdev() receives a PCI address of the device and returns an attached port number. rte_eal_dev_detach_pdev() receives a port number, and returns a PCI address actually detached. Signed-off-by: Tetsuya Mukawa

[dpdk-dev] [PATCH 23/25] eal/pci: Add rte_eal_pci_probe_one and rte_eal_pci_close_one

2014-11-20 Thread Tetsuya Mukawa
The functions are used for probe and close a device. First the function tries to find a device that has the specfied PCI address. Then, probe or close the device. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_pci.c | 58 + lib/librte_eal/comm

[dpdk-dev] [PATCH 22/25] eal/pci: Add pci_close_all_drivers

2014-11-20 Thread Tetsuya Mukawa
The function tries to find a driver for the specified device, and then close the driver. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_pci.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/comm

[dpdk-dev] [PATCH 21/25] eal/pci: Fix pci_probe_all_drivers to share code with closing function

2014-11-20 Thread Tetsuya Mukawa
pci_close_all_drivers() will be implemented after the patch. To share a part of code between thses 2 functions, The patch fixes pci_probe_all_drivers() first. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_pci.c | 28 1 file changed, 20 insertions

[dpdk-dev] [PATCH 20/25] eal/pci: Add rte_eal_pci_close_one_driver

2014-11-20 Thread Tetsuya Mukawa
The function is used for closing the specified driver and device. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/include/eal_private.h | 11 ++ lib/librte_eal/linuxapp/eal/eal_pci.c | 58 + 2 files changed, 69 insertions(+) diff --git a/lib/librte_

[dpdk-dev] [PATCH 19/25] eal/pci: Change scope of rte_eal_pci_scan to global

2014-11-20 Thread Tetsuya Mukawa
The function is called by port hotplug framework, so change scope of the function to global. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/include/eal_private.h | 11 +++ lib/librte_eal/linuxapp/eal/eal_pci.c | 6 +++--- 2 files changed, 14 insertions(+), 3 deletions(-)

[dpdk-dev] [PATCH 18/25] eal/pci: Prevent double registrations for pci_device_list

2014-11-20 Thread Tetsuya Mukawa
The patch fixes pci_scan_one() not to register same pci devices twice. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci

[dpdk-dev] [PATCH 17/25] eal/linux/pci: Add functions for unmapping igb_uio resources

2014-11-20 Thread Tetsuya Mukawa
The patch adds functions for unmapping igb_uio resources. The patch is only for Linux and igb_uio environment. VFIO and BSD are not supported. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci.c | 32 + lib/librte_eal/linuxapp/eal/eal_pci_uio.c

[dpdk-dev] [PATCH 16/25] eal/pci: Add port hotplug functions for virtual devices.

2014-11-20 Thread Tetsuya Mukawa
The patch adds rte_eal_dev_attach_vdev() and rte_eal_dev_detach_vdev(). rte_eal_dev_attach_vdev() receives virtual device name and parameters, and returns an attached port number. rte_eal_dev_detach_vdev() receives a port number, and returns device name actually detached. Signed-off-by: Tetsuya M

[dpdk-dev] [PATCH 15/25] eal/pci: Add probe and close function for virtual drivers

2014-11-20 Thread Tetsuya Mukawa
The patch adds rte_eal_dev_init_one() and rte_eal_dev_close_one(). These are used for attaching and detaching virtual devices. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_dev.c | 74 + lib/librte_eal/common/include/rte_dev.h | 6 +++ lib/l

[dpdk-dev] [PATCH 14/25] eal/pci: Add rte_eal_devargs_remove

2014-11-20 Thread Tetsuya Mukawa
The function removes a specified devargs from devargs_list. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_devargs.c | 13 + lib/librte_eal/common/include/rte_devargs.h | 18 ++ 2 files changed, 31 insertions(+) diff --git a/lib/librte_eal/common

[dpdk-dev] [PATCH 13/25] eal/pci: Prevent double registration for devargs_list

2014-11-20 Thread Tetsuya Mukawa
The patch fixes rte_eal_devargs_add() not to register same device twice. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_devargs.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/c

[dpdk-dev] [PATCH 12/25] ethdev: Change scope of rte_eth_dev_allocated to global

2014-11-20 Thread Tetsuya Mukawa
This function is used by virtual PMDs to support port hotplug framework. So change scope of the function to global. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 2 +- lib/librte_ether/rte_ethdev.h | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 11/25] ethdev: Add rte_eth_dev_check_detachable

2014-11-20 Thread Tetsuya Mukawa
The function returns whether a PMD supports detach function, or not. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 9 + lib/librte_ether/rte_ethdev.h | 11 +++ 2 files changed, 20 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rt

[dpdk-dev] [PATCH 10/25] ethdev: Add rte_eth_dev_get_name_by_port

2014-11-20 Thread Tetsuya Mukawa
The function returns a unique identifier name of a ethdev specified by port identifier. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 17 + lib/librte_ether/rte_ethdev.h | 12 2 files changed, 29 insertions(+) diff --git a/lib/librte_ether/rte_et

[dpdk-dev] [PATCH 09/25] ethdev: Add rte_eth_dev_get_port_by_addr

2014-11-20 Thread Tetsuya Mukawa
The function returns a port identifier of a ethdev specified by pci address. v3: - Fix if-condition bug while comparing pci addresses. - Add error checking codes. Reported-by: Mark Enright Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 17 + lib/librte_ether/

[dpdk-dev] [PATCH 08/25] ethdev: Add rte_eth_dev_get_addr_by_port

2014-11-20 Thread Tetsuya Mukawa
The function returns a pci address of a ethdev specified by port identifier. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 12 lib/librte_ether/rte_ethdev.h | 13 + 2 files changed, 25 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/li

[dpdk-dev] [PATCH 07/25] ethdev: Add functions to know which port is attached or detached

2014-11-20 Thread Tetsuya Mukawa
The patch adds rte_eth_dev_save() and rte_eth_dev_get_changed_port(). rte_eth_dev_save() is used for saving current rte_eth_dev structures. rte_eth_dev_get_changed_port() receives the rte_eth_dev structures, then compare these with current values to know which port is actually attached or detached.

[dpdk-dev] [PATCH 06/25] ethdev: Add rte_eth_dev_shutdown for closing PCI devices.

2014-11-20 Thread Tetsuya Mukawa
rte_eth_dev_shutdown() is called when PCI device is closed. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 37 + 1 file changed, 37 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index f217e14..c9f8

[dpdk-dev] [PATCH 05/25] eal, ethdev: Add function pointer for closing a device

2014-11-20 Thread Tetsuya Mukawa
The patch adds function pointer to rte_pci_driver and eth_driver structure. These function pointers are used when ports are detached. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/include/rte_pci.h | 7 +++ lib/librte_ether/rte_ethdev.h | 4 2 files changed, 11 inser

[dpdk-dev] [PATCH 04/25] ethdev: Add rte_eth_dev_free to free specified device

2014-11-20 Thread Tetsuya Mukawa
This patch adds rte_eth_dev_free(). The function is used for changing a attached status of the device that has specified name. Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 17 + lib/librte_ether/rte_ethdev.h | 11 +++ 2 files changed, 28 insertions(+)

[dpdk-dev] [PATCH 03/25] eal/pci: Replace pci address comparison code by eal_compare_pci_addr

2014-11-20 Thread Tetsuya Mukawa
This patch replaces pci_addr_comparison() and memcmp() of pci addresses by eal_compare_pci_addr(). Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 16 +--- lib/librte_eal/common/eal_common_pci.c| 2 +- lib/librte_eal/common/include/rte_pci.h | 29

[dpdk-dev] [PATCH 02/25] ethdev: Remove assumption that port will not be detached

2014-11-20 Thread Tetsuya Mukawa
To remove assumption, do like followings. - Add 'attached' member to rte_eth_dev structure. This member is used for indicating the port is attached, or not. - Add rte_eth_dev_allocate_new_port(). This function is used for allocating new port. Signed-off-by: Tetsuya Mukawa --- lib/librte_eth

[dpdk-dev] [PATCH 01/25] eal/pci: Add a new flag indicating a driver can detach devices at runtime.

2014-11-20 Thread Tetsuya Mukawa
This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver structure. The flags indicates the driver can detach devices at runtime. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/include/rte_pci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/i

[dpdk-dev] [PATCH 00/25] Port Hotplug Framework

2014-11-20 Thread Tetsuya Mukawa
This patch series adds a dynamic port hotplug framework to DPDK. With the patches, DPDK apps can attach or detach ports at runtime. The basic concept of the port hotplug is like followings. - DPDK apps must have resposibility to manage ports. DPDK apps only know which ports are attached or detac

[dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum offload

2014-11-20 Thread Olivier MATZ
Hi Jijiang, On 11/20/2014 08:28 AM, Liu, Jijiang wrote: >> The original behavior (without your vxlan patches), which still works today, >> is to >> select inner or outer using the m->l2_len field: >> >>- checksum outer IP + UDP >> m->l2_len=14 m->l3_len=20 >> flags=PKT_TX_IP_CKSUM P

[dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD

2014-11-20 Thread Bruce Richardson
On Thu, Nov 20, 2014 at 12:03:40PM -0500, Neil Horman wrote: > On Thu, Nov 20, 2014 at 04:42:23PM +, Gonzalez Monroy, Sergio wrote: > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > Sent: Thursday, November 20, 2014 2:21 PM > > > On Thu, Nov 20, 2014 at 02:17:13PM +, Sergio Go

[dpdk-dev] one worker reading multiple ports

2014-11-20 Thread Newman Poborsky
Thank you for your answer. I just realized that the reason the rte_eth_rx_burst() returns 0 is because inside ixgbe_recv_pkts() this fails: nmb = rte_rxmbuf_alloc(rxq->mb_pool); => nmb is NULL Does this mean that every RX queue should have its own rte_mempool? If so, are there any optimal value

[dpdk-dev] [PATCH v2] i40e: link flow control support

2014-11-20 Thread zhida zang
From: zzang Add link flow control support for i40e Signed-off-by: zhida zang --- lib/librte_pmd_i40e/i40e_ethdev.c | 155 +- lib/librte_pmd_i40e/i40e_ethdev.h | 10 +++ 2 files changed, 162 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_i40e/i40

[dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD

2014-11-20 Thread Gonzalez Monroy, Sergio
> From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Thursday, November 20, 2014 2:21 PM > On Thu, Nov 20, 2014 at 02:17:13PM +, Sergio Gonzalez Monroy wrote: > > Some features of the cmdline were broken in FreeBSD as a result of > > termios not being compiled. > > > > Signed-off-by: S

[dpdk-dev] [PATCH v2] i40e: fixed tx packets stats bug

2014-11-20 Thread zhida zang
From: zzang i40e only count tx packets that sent by pf. But in some condition packet can be sent by NIC without being counted by pf. So count vsi tx packets instead. Signed-off-by: zhida zang --- lib/librte_pmd_i40e/i40e_ethdev.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-

[dpdk-dev] [PULL REQUEST] doc: Various document fixes in testpmd UG

2014-11-20 Thread Bernard Iremonger
These changes are DPDK 1.8 modifications and some corrections to the TestPMD Application User Guide. The following changes since commit fc1f2750a3ec6da919e3c86e59d56f34ec97154b: doc: programmers guide (2014-11-18 14:49:54 +0100) are available in the git repository at: git://dpdk.org/next/dp

[dpdk-dev] Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

2014-11-20 Thread Tapio Tallgren
On Thu, Nov 20, 2014 at 1:33 PM, Thomas Monjalon wrote: > 2014-11-20 06:17, Neil Horman: > > On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote: > > > Looks like a version conflict? Dpdk 1.7 should support virtio-pmd so > what > > > am I doing wrong? > > > > Nothing, its a bug. DPDK

[dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD

2014-11-20 Thread Sergio Gonzalez Monroy
Some features of the cmdline were broken in FreeBSD as a result of termios not being compiled. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_cmdline/cmdline.h| 2 -- lib/librte_cmdline/cmdline_socket.c | 10 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git

[dpdk-dev] [PATCH 2/2] eal: Remove unused HPET support from FreeBSD

2014-11-20 Thread Sergio Gonzalez Monroy
The HPET support in the BSD EAL was copied directly from the Linux version, but did not actually work on FreeBSD. We replace this old code with a simple compiler message that informs the user that we don't support HPET on BSD if they enable such support in the build-time configuration file. Signed

[dpdk-dev] [PATCH 1/2] eal: use sysctl in BSD to set TSC freq

2014-11-20 Thread Sergio Gonzalez Monroy
BSD provides the TSC frequency value through sysctl. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/bsdapp/eal/eal_timer.c | 46 --- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_timer.c b/lib/librte_eal/b

[dpdk-dev] [PATCH 0/2] BSD timer cleanup/update

2014-11-20 Thread Sergio Gonzalez Monroy
This patch set is a quick cleanup/update of the timer in BSD. Since BSD exposes TSC freq in sysctl, we avoid other less accurate methods. We still provide a fallback in case we fail to obtain the value, as it is x86 specific. The HPET device is not expose in BSD, therefore current code does not wo

[dpdk-dev] one worker reading multiple ports

2014-11-20 Thread Matthew Hall
On Thu, Nov 20, 2014 at 05:10:51PM +0100, Newman Poborsky wrote: > Thank you for your answer. > > I just realized that the reason the rte_eth_rx_burst() returns 0 is because > inside ixgbe_recv_pkts() this fails: > nmb = rte_rxmbuf_alloc(rxq->mb_pool); => nmb is NULL > > Does this mean that ever

[dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD

2014-11-20 Thread Neil Horman
On Thu, Nov 20, 2014 at 05:19:19PM +, Bruce Richardson wrote: > On Thu, Nov 20, 2014 at 12:03:40PM -0500, Neil Horman wrote: > > On Thu, Nov 20, 2014 at 04:42:23PM +, Gonzalez Monroy, Sergio wrote: > > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > > Sent: Thursday, November

[dpdk-dev] versioning and maintenance

2014-11-20 Thread Neil Horman
On Thu, Nov 20, 2014 at 06:09:10PM +0100, Thomas Monjalon wrote: > Hi, > > 2014-11-19 10:13, Neil Horman: > > On Wed, Nov 19, 2014 at 11:35:08AM +, Bruce Richardson wrote: > > > On Wed, Nov 19, 2014 at 12:22:14PM +0100, Thomas Monjalon wrote: > > > > Following the discussion we had with Neil d

[dpdk-dev] Community conference call - Tuesday 18th November

2014-11-20 Thread O'driscoll, Tim
Hi Mirek, > From: Walukiewicz, Miroslaw > Is it a possibility to create some place on dpdk.org available to everyone > where the slides and recording will be available? Yes, I've been talking with Thomas about this. I have a recording of the meeting, and I'll work with Thomas to find the best wa

[dpdk-dev] DPDK Community Conference Call - Friday 31st October

2014-11-20 Thread O'driscoll, Tim
Hi Kevin, > From: Kevin Wilson [mailto:wkevils at gmail.com] > > We'll schedule a follow-up call for 2 weeks' time > Just a short question - is this still intended to be held ? We had our second call earlier this week, on Tuesday. I'll post a recording of it soon. The next call will be in 2 wee

[dpdk-dev] Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

2014-11-20 Thread Thomas Monjalon
2014-11-20 06:17, Neil Horman: > On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote: > > Looks like a version conflict? Dpdk 1.7 should support virtio-pmd so what > > am I doing wrong? > > Nothing, its a bug. DPDK changed the API here with commit > 9aaccf1abdb2894ec23870e1d2199a657f85

[dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD

2014-11-20 Thread Neil Horman
On Thu, Nov 20, 2014 at 04:42:23PM +, Gonzalez Monroy, Sergio wrote: > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Thursday, November 20, 2014 2:21 PM > > On Thu, Nov 20, 2014 at 02:17:13PM +, Sergio Gonzalez Monroy wrote: > > > Some features of the cmdline were broken i

[dpdk-dev] [PATCH v5 5/7] hash: add fallback to software CRC32 implementation

2014-11-20 Thread Yerden Zhumabekov
Initially, SSE4.2 support is detected via CPUID instruction via the constructor function. Added rte_hash_crc_set_alg() function to detect and set CRC32 implementation if necessary. SSE4.2 is allowed by default. rte_hash_crc_*byte() functions reworked so they choose available CRC32 implementation

[dpdk-dev] [PATCH v5 7/7] test: remove redundant compile checks

2014-11-20 Thread Yerden Zhumabekov
Since rte_hash_crc() can now be run regardless of SSE4.2 support, we can safely remove compile checks for RTE_MACHINE_CPUFLAG_SSE4_2 in test utilities. Signed-off-by: Yerden Zhumabekov --- app/test/test_hash.c |7 --- app/test/test_hash_perf.c | 11 --- 2 files changed, 18

[dpdk-dev] [PATCH v5 6/7] hash: rte_hash_crc() slices data into 8-byte pieces

2014-11-20 Thread Yerden Zhumabekov
Calculating hash for data of variable length is more efficient when that data is sliced into 8-byte pieces. The rest part of data is hashed using CRC32 functions with either 8 and 4 byte operands. Signed-off-by: Yerden Zhumabekov --- lib/librte_hash/rte_hash_crc.h | 33

[dpdk-dev] [PATCH v5 4/7] hash: add rte_hash_crc_8byte function

2014-11-20 Thread Yerden Zhumabekov
SSE4.2 provides CRC32 intrinsic with 8-byte operand. Signed-off-by: Yerden Zhumabekov --- lib/librte_hash/rte_hash_crc.h | 16 1 file changed, 16 insertions(+) diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/rte_hash_crc.h index cd28833..2c8ec99 100644 --- a/lib

[dpdk-dev] [PATCH v5 3/7] hash: replace built-in functions implementing SSE4.2

2014-11-20 Thread Yerden Zhumabekov
Give up using built-in intrinsics and use our own assembly implementation. Remove #include entry as well. Signed-off-by: Yerden Zhumabekov --- lib/librte_hash/rte_hash_crc.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/

[dpdk-dev] [PATCH v5 2/7] hash: add assembly implementation of CRC32 intrinsics

2014-11-20 Thread Yerden Zhumabekov
Added: - crc32c_sse42_u32() emits 'crc32l' asm instruction; - crc32c_sse42_u64() emits 'crc32q' asm instruction; - crc32c_sse42_u64_mimic(), wrapper in case of run on 32-bit platform. Signed-off-by: Yerden Zhumabekov --- lib/librte_hash/rte_hash_crc.h | 34 ++ 1

[dpdk-dev] [PATCH v5 1/7] hash: add software CRC32 implementation

2014-11-20 Thread Yerden Zhumabekov
Add lookup tables for CRC32 algorithm, crc32c_1word() and crc32c_2words() functions returning hash of 32-bit and 64-bit operand. Signed-off-by: Yerden Zhumabekov --- lib/librte_hash/rte_hash_crc.h | 316 1 file changed, 316 insertions(+) diff --git a/li

[dpdk-dev] [PATCH v5 0/7] rte_hash_crc reworked to be platform-independent

2014-11-20 Thread Yerden Zhumabekov
These patches bring a fallback mechanism to ensure that CRC32 hash is calculated regardless of hardware support from CPU (i.e. SSE4.2 intrinsics). Performance is also improved by slicing data in 8 bytes. Patches were tested on machines either with and without SSE4.2 support. Software implementat

[dpdk-dev] [PATCH] examples/dpdk_qat: Fix reference to old mbuf field "data"

2014-11-20 Thread Pablo de Lara
DPDK QAT app was using the old "data" field in mbuf, so it has been subtituted with rte_pktmbuf_mtod function. Signed-off-by: Pablo de Lara --- examples/dpdk_qat/crypto.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/dpdk_qat/crypto.c b/examples/dpdk_qat/

[dpdk-dev] one worker reading multiple ports

2014-11-20 Thread Newman Poborsky
Hi, is it possible to use one worker thread (one lcore) to read packets from multiple ports? When I start 2 workers and assign each one to read from different ports (with rte_eth_rx_burst()) everything works fine, but if I assign one worker to read packets from 2 ports, rte_eth_rx_burst() retur

[dpdk-dev] Community conference call - Tuesday 18th November

2014-11-20 Thread Walukiewicz, Miroslaw
Tim, Is it a possibility to create some place on dpdk.org available to everyone where the slides and recording will be available? Regards, Mirek > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of O'driscoll, Tim > Sent: Wednesday, November 19, 2014 1:34 PM

[dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD

2014-11-20 Thread Neil Horman
On Thu, Nov 20, 2014 at 02:17:13PM +, Sergio Gonzalez Monroy wrote: > Some features of the cmdline were broken in FreeBSD as a result of > termios not being compiled. > > Signed-off-by: Sergio Gonzalez Monroy Not sure I understand the changelog above. You're removing ifdefs below which make

[dpdk-dev] DPDK Community Conference Call - Friday 31st October

2014-11-20 Thread Kevin Wilson
Hi, Tim, > We'll schedule a follow-up call for 2 weeks' time Just a short question - is this still intended to be held ? Kevin On Fri, Oct 31, 2014 at 7:36 PM, O'driscoll, Tim wrote: > Thanks again to those who attended the call earlier. Hopefully people found > it useful. > > We'll schedule a

[dpdk-dev] Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

2014-11-20 Thread Neil Horman
On Thu, Nov 20, 2014 at 02:37:27PM +0200, Tapio Tallgren wrote: > On Thu, Nov 20, 2014 at 1:33 PM, Thomas Monjalon 6wind.com> > wrote: > > > 2014-11-20 06:17, Neil Horman: > > > On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote: > > > > Looks like a version conflict? Dpdk 1.7 should

[dpdk-dev] Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

2014-11-20 Thread Tapio Tallgren
Hi, I am probably doing something obviously wrong but I cannot figure it out right now.. I have dpdk version 1.7.1 installed and compiled (from the git repository) and virtio-net-pmd driver version v1.2 from git.dpdk.org. When I try to compile virtio-net-pmd with make RTE_INCLUDE=../dpdk/build/in

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-20 Thread Yerden Zhumabekov
19.11.2014 21:07, Neil Horman ?: > On Wed, Nov 19, 2014 at 05:35:51PM +0600, Yerden Zhumabekov wrote: >> static inline uint32_t >> crc32_sse42_u32(uint32_t data, uint32_t init_val) >> { >> /*??__asm__ volatile( >> "crc32l %[data], %[init_val];" >> : [init_val] "+r" (ini

[dpdk-dev] one worker reading multiple ports

2014-11-20 Thread De Lara Guarch, Pablo
Hi Newman, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Newman Poborsky > Sent: Thursday, November 20, 2014 8:34 AM > To: dev at dpdk.org > Subject: [dpdk-dev] one worker reading multiple ports > > Hi, > > is it possible to use one worker thread (one lco

[dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum offload

2014-11-20 Thread Liu, Jijiang
Hi, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, November 17, 2014 7:22 PM > To: Liu, Jijiang; Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum > offload > > Hi Jijiang, > >

[dpdk-dev] Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

2014-11-20 Thread Neil Horman
On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote: > Hi, > > I am probably doing something obviously wrong but I cannot figure it out > right now.. > I have dpdk version 1.7.1 installed and compiled (from the git repository) > and virtio-net-pmd driver version v1.2 from git.dpdk.org.

[dpdk-dev] Enhance KNI DPDK-app-side to be Multi-Producer/Consumer

2014-11-20 Thread Zhou, Danny
Robert, I roughly review the code below about lockless KNI fifo with MP/MC support , which looks good to me. Comparing to SP/SC implementation, I think It should introduce a little performance degradation but it will be making your multiple-threaded DPDK application easier to program. Do you ha

[dpdk-dev] [PATCH] i40e: fixed tx stats bug

2014-11-20 Thread Zang, Zhida
Is that OK that I send another patch with details directly? -Original Message- From: Qiu, Michael Sent: Wednesday, November 19, 2014 17:27 To: Zang, Zhida; dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: fixed tx stats bug On 11/19/2014 4:43 PM, zhida zang wrote: > From: zzang > >