[dpdk-dev] [PATCH v6 3/3] app/testpmd: add commands to support hash functions

2014-11-19 Thread Helin Zhang
To demonstrate the hash filter control, commands are added. They are, - get_sym_hash_ena_per_port - set_sym_hash_ena_per_port - get_sym_hash_ena_per_pctype - set_sym_hash_ena_per_pctype - get_filter_swap - set_filter_swap - get_hash_function - set_hash_function Signed-off-by: Helin Zhang --- app

[dpdk-dev] [PATCH v6 2/3] i40e: support of controlling hash functions

2014-11-19 Thread Helin Zhang
Hash filter control has been implemented for i40e. It includes getting/setting, - hash function type - symmetric hash enable per pctype (packet classification type) - symmetric hash enable per port - filter swap configuration Signed-off-by: Helin Zhang --- lib/librte_ether/rte_eth_ctrl.h | 98

[dpdk-dev] [PATCH v6 1/3] i40e: Use constant as the default hash keys

2014-11-19 Thread Helin Zhang
Calculating the default RSS hash keys at run time is not needed at all, and may have race conditions. The alternative is to use array of random values which were generated manually as the default hash keys. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_ethdev.c | 14 +++--- 1 f

[dpdk-dev] [PATCH v6 0/3] Support configuring hash functions

2014-11-19 Thread Helin Zhang
These patches mainly support configuring hash functions. In detail, - It can get or set hash functions. - It can configure symmetric hash functions. * Get/set symmetric hash enable per port. * Get/set symmetric hash enable per flow type. * Get/set filter swap configurations. - Six comma

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Yerden Zhumabekov
19.11.2014 17:50, Ananyev, Konstantin ?: > > As I remember with gcc & icc it is possible to specify tht you'd like to > compile that particular function > for different target. > From https://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html: > "target > The target attribute is used to spec

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Yerden Zhumabekov
19.11.2014 16:16, Bruce Richardson ?: > On Tue, Nov 18, 2014 at 04:36:24PM -0500, Neil Horman wrote: >> an alternate option would be to not use the intrinsic, and craft some >> explicit >> __asm__ statement that executes the right sse42 instructions. That way the >> asm >> is directly emitt

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Ananyev, Konstantin
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Wednesday, November 19, 2014 3:06 PM > To: Ananyev, Konstantin > Cc: Richardson, Bruce; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 > implementation > > O

[dpdk-dev] [PATCH] i40e: fixed tx stats bug

2014-11-19 Thread zhida zang
From: zzang Fixed tx stats bug in i40e Signed-off-by: zzang --- lib/librte_pmd_i40e/i40e_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c index 4b7a827..e01590c 100644 --- a/lib/librte_pmd_i

[dpdk-dev] Enhance KNI DPDK-app-side to be Multi-Producer/Consumer

2014-11-19 Thread Robert Sanford
Hi Danny, On Fri, Nov 14, 2014 at 7:04 PM, Zhou, Danny wrote: > It will be always good if you can submit the RFC patch in terms of KNI > optimization. > > On the other hand, do you have any perf. data to prove that your patchset > could improve > KNI performance which is the concern that most cu

[dpdk-dev] [PATCH v4 2/2] testpmd: add mode 4 support

2014-11-19 Thread De Lara Guarch, Pablo
Sorry I missed extra comments here: > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski > Sent: Tuesday, November 18, 2014 4:31 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v4 2/2] testpmd: add mode 4 support > > From: Pawel Wodkowski

[dpdk-dev] [PATCH v2 4/4] doc: Various document fixes in testpmd UG

2014-11-19 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, November 18, 2014 5:05 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 4/4] doc: Various document fixes in testpmd UG > > Signed-off-by: Pablo de Lara Acked-by: Bernard

[dpdk-dev] [PATCH v2 3/4] doc: Moved commands in testpmd UG to match testpmd command help order

2014-11-19 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, November 18, 2014 5:05 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/4] doc: Moved commands in testpmd UG to match > testpmd > command help order > > Moved commands i

[dpdk-dev] [PATCH v2 2/4] doc: Corrected info for tx_checksum set mask function, in testpmd UG

2014-11-19 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, November 18, 2014 5:05 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/4] doc: Corrected info for tx_checksum set > mask function, in > testpmd UG > > tx_checksum set m

[dpdk-dev] [PATCH v2 1/4] doc: Added new commands in testpmd UG

2014-11-19 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, November 18, 2014 5:05 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/4] doc: Added new commands in testpmd UG > > Added info in testpmd functions section for the follo

[dpdk-dev] Community conference call - Tuesday 18th November

2014-11-19 Thread O'driscoll, Tim
Thanks again to those who attended the call yesterday. There was a good discussion, and it was more interactive than the previous call, which is what we were aiming for. We'll schedule a follow-up call for 2 weeks' time. Thanks again to those who presented on the following features: - ABI Versi

[dpdk-dev] [PATCH] xenvirt: fix reference to old mbuf field

2014-11-19 Thread Sergio Gonzalez Monroy
data is not an mbuf field anymore. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_pmd_xenvirt/virtqueue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_xenvirt/virtqueue.h b/lib/librte_pmd_xenvirt/virtqueue.h index d8717fe..34a24fc 100644 --- a/lib/lib

[dpdk-dev] [PATCH 3/3] Add RTE_ prefix to CACHE_LINE_ROUNDUP macro

2014-11-19 Thread Sergio Gonzalez Monroy
Adding RTE_ for consistency with other renamed macros and to avoid potential conflicts. Signed-off-by: Sergio Gonzalez Monroy --- app/test-pmd/testpmd.c | 2 +- lib/librte_eal/common/include/rte_memory.h | 2 +- lib/librte_malloc/malloc_heap.c| 4 ++-- lib/libr

[dpdk-dev] [PATCH 2/3] Add RTE_ prefix to CACHE_LINE_MASK macro

2014-11-19 Thread Sergio Gonzalez Monroy
Adding RTE_ for consistency with other renamed macros and to avoid potential conflicts. Signed-off-by: Sergio Gonzalez Monroy --- app/test/test_memzone.c| 32 +++--- lib/librte_acl/rte_acl_osdep_alone.h | 2 +- lib/librte_distributor/rte_distrib

[dpdk-dev] [PATCH 1/3] Add RTE_ prefix to CACHE_LINE_SIZE macro

2014-11-19 Thread Sergio Gonzalez Monroy
CACHE_LINE_SIZE is a macro defined in machine/param.h in FreeBSD and conflicts with DPDK macro version. Adding RTE_ prefix to avoid conflicts. Signed-off-by: Sergio Gonzalez Monroy --- app/test-acl/main.c | 2 +- app/test-pipeline/runtime.c |

[dpdk-dev] [PATCH 0/3] Add RTE_ prefix to CACHE_LINE related macros

2014-11-19 Thread Sergio Gonzalez Monroy
Currently DPDK sets CACHE_LINE_SIZE value to 64 by default if the macro is not already defined. FreeBSD defines a CACHE_LINE_SIZE macro in the header file: /usr/include/machine/param.h These macros set different values, 64 in DPDK vs 128 in FreeBSD, causing broken application behaviour if the sys

[dpdk-dev] versioning and maintenance

2014-11-19 Thread Thomas Monjalon
Following the discussion we had with Neil during the conference call, I suggest this plan, starting with the next release (2.0): - add version numbers to libraries - add version numbers to functions inside .map files - create a git tree dedicated to maintenance and API compa

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, November 19, 2014 11:38 AM > To: Neil Horman > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 > implementation > > On Wed

[dpdk-dev] [PATCH 1/4] rte_mbuf:add packet types

2014-11-19 Thread Olivier MATZ
Hi Jijiang, On 11/18/2014 08:37 AM, Jijiang Liu wrote: > This patch abstracts packet types of L2 packet, Non Tunneled IPv4/6, IP in > IP, IP in GRE, MAC in GRE and MAC in UDP, and add 4 MACROS to check packet IP > header. > > Signed-off-by: Jijiang Liu > --- > lib/librte_mbuf/rte_mbuf.h | 22

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Bruce Richardson
On Wed, Nov 19, 2014 at 06:34:08AM -0500, Neil Horman wrote: > On Wed, Nov 19, 2014 at 10:16:14AM +, Bruce Richardson wrote: > > On Tue, Nov 18, 2014 at 04:36:24PM -0500, Neil Horman wrote: > > > On Tue, Nov 18, 2014 at 05:52:27PM +, Bruce Richardson wrote: > > > > On Tue, Nov 18, 2014 at 1

[dpdk-dev] versioning and maintenance

2014-11-19 Thread Bruce Richardson
On Wed, Nov 19, 2014 at 12:22:14PM +0100, Thomas Monjalon wrote: > Following the discussion we had with Neil during the conference call, > I suggest this plan, starting with the next release (2.0): > - add version numbers to libraries > - add version numbers to functions inside .map fil

[dpdk-dev] [PATCH] test: fix misplaced braces in strncmp call

2014-11-19 Thread Olivier MATZ
Hi Bruce, On 11/19/2014 10:06 AM, Bruce Richardson wrote: > This patch fixes two occurances where a call to strncmp had the closing > brace in the wrong place. Changing this form: > if (strncmp(X,Y,sizeof(X) != 0)) > which does a comparison of length 1, to > if (strncmp(X,Y,sizeof(X))

[dpdk-dev] [PATCH v2 06/13] mbuf: add functions to get the name of an ol_flag

2014-11-19 Thread Ananyev, Konstantin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, November 18, 2014 9:30 AM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: jigsaw at gmail.com; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v2 06/13] mbuf: add functions to get the name > of a

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Bruce Richardson
On Tue, Nov 18, 2014 at 04:36:24PM -0500, Neil Horman wrote: > On Tue, Nov 18, 2014 at 05:52:27PM +, Bruce Richardson wrote: > > On Tue, Nov 18, 2014 at 12:46:19PM -0500, Neil Horman wrote: > > > On Tue, Nov 18, 2014 at 11:13:17PM +0600, Yerden Zhumabekov wrote: > > > > > > > > 18.11.2014 22:0

[dpdk-dev] versioning and maintenance

2014-11-19 Thread Neil Horman
On Wed, Nov 19, 2014 at 11:35:08AM +, Bruce Richardson wrote: > On Wed, Nov 19, 2014 at 12:22:14PM +0100, Thomas Monjalon wrote: > > Following the discussion we had with Neil during the conference call, > > I suggest this plan, starting with the next release (2.0): > > - add version numbers

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Neil Horman
On Wed, Nov 19, 2014 at 05:35:51PM +0600, Yerden Zhumabekov wrote: > > 19.11.2014 16:16, Bruce Richardson ?: > > On Tue, Nov 18, 2014 at 04:36:24PM -0500, Neil Horman wrote: > >> an alternate option would be to not use the intrinsic, and craft some > >> explicit > >> __asm__ statement that ex

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Yerden Zhumabekov
18.11.2014 23:29, Wang, Shawn ?: > I have a general question about using CPUID to detect supported instruction > set. > What if we are compiling the software with some old hardware which does not > support SSE4.2, but run it on new hardware which does support SSE4.2. Is > there still a stat

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Neil Horman
On Wed, Nov 19, 2014 at 11:50:40AM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Wednesday, November 19, 2014 11:38 AM > > To: Neil Horman > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-d

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Yerden Zhumabekov
19.11.2014 3:36, Neil Horman ?: > On Tue, Nov 18, 2014 at 05:52:27PM +, Bruce Richardson wrote: >> On Tue, Nov 18, 2014 at 12:46:19PM -0500, Neil Horman wrote: >>> On Tue, Nov 18, 2014 at 11:13:17PM +0600, Yerden Zhumabekov wrote: Everybody's up for the second option? :) >>> Crud

[dpdk-dev] [PATCH 0/4] Translate packet types for i40e

2014-11-19 Thread Ananyev, Konstantin
> -Original Message- > From: Liu, Jijiang > Sent: Wednesday, November 19, 2014 3:53 AM > To: Ananyev, Konstantin > Cc: dev at dpdk.org; Richardson, Bruce > Subject: RE: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e > > > > > -Original Message- > > From: Ananyev, Konsta

[dpdk-dev] [PATCH v6 0/8] support of multiple sizes of redirection table

2014-11-19 Thread Chen, Erlu
Tested-by: Erlu Chen - Tested Commit: 951ac486a6bb9499cbaa605bd4bde2b5e52e - OS: Linux fc20 3.11.10-301.fc20.x86_64 - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - GCC: gcc version 4.8.3 20140624 - NIC: Intel Corporation Ethernet Controller X710 for 10GbE SFP+ [8086:1572] Intel Corporat

[dpdk-dev] [PATCH] i40e: fixed tx stats bug

2014-11-19 Thread Qiu, Michael
On 11/19/2014 4:43 PM, zhida zang wrote: > From: zzang > > Fixed tx stats bug in i40e Would you mind to give more details about this bug in the commit log? This can really help reviewer to get the initial idea about your patch without go through the code it self. Thanks, Michael > > Signed-of

[dpdk-dev] [PATCH] test: fix misplaced braces in strncmp call

2014-11-19 Thread Bruce Richardson
This patch fixes two occurances where a call to strncmp had the closing brace in the wrong place. Changing this form: if (strncmp(X,Y,sizeof(X) != 0)) which does a comparison of length 1, to if (strncmp(X,Y,sizeof(X)) != 0) which does the correct length comparison and then compares

[dpdk-dev] [PATCH v5 02/21] i40e: tear down flow director

2014-11-19 Thread Cao, Min
Tested-by: Min Cao Patch name: [PATCH v5 00/21] Support flow director programming on Fortville Test Flag: Tested-by Tester name:min.cao at intel.com Result summary: total 3 cases, 3 passed, 0 failed Test Case 1: Name:

[dpdk-dev] [PATCH v4 00/21] Support flow director programming on Fortville

2014-11-19 Thread Cao, Min
Tested-by: Min Cao Patch name: [PATCH v4 00/21] Support flow director programming on Fortville Test Flag: Tested-by Tester name:min.cao at intel.com Result summary: total 3 cases, 3 passed, 0 failed Test Case 1: Name:

[dpdk-dev] [PATCH v4 3/5] hash: add fallback to software CRC32 implementation

2014-11-19 Thread Neil Horman
On Wed, Nov 19, 2014 at 10:16:14AM +, Bruce Richardson wrote: > On Tue, Nov 18, 2014 at 04:36:24PM -0500, Neil Horman wrote: > > On Tue, Nov 18, 2014 at 05:52:27PM +, Bruce Richardson wrote: > > > On Tue, Nov 18, 2014 at 12:46:19PM -0500, Neil Horman wrote: > > > > On Tue, Nov 18, 2014 at 1

[dpdk-dev] [PATCH 0/4] Translate packet types for i40e

2014-11-19 Thread Liu, Jijiang
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, November 18, 2014 11:29 PM > To: Richardson, Bruce > Cc: Liu, Jijiang; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e > > > > > -Original Message- > > From: Richardson, Bruc

[dpdk-dev] [PATCH 0/4] Translate packet types for i40e

2014-11-19 Thread Zhang, Helin
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, November 18, 2014 11:26 PM > To: Zhang, Helin; Liu, Jijiang; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e > > > > > -Original Message- > > From: Zhang, Helin > > Sent: Tue