[dpdk-dev] [PATCH v10 0/5] link bonding

2014-06-27 11:18, Declan Doherty: > Fixed copyright in link bonding library Makefile A small fix is needed in Makefile for renaming of file rte_eth_bond_args.c. And more important, it cannot be built as an optional shared library as test applications call functions from the specific API. The bes

[dpdk-dev] [PATCH] string: fix potential seg fault on snprintf

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier MATZ > Sent: Friday, June 27, 2014 5:34 AM > To: De Lara Guarch, Pablo; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] string: fix potential seg fault on snprintf > > Hi Pablo, > > On 06/27/2014 02:1

[dpdk-dev] [PATCH] test: Ring PMD unit test rollback

Hi Neil, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Friday, June 27, 2014 4:03 PM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test: Ring PMD unit test rollback > > On Fri, Jun 27, 2014 at 03:46

[dpdk-dev] [PATCH] test: Ring PMD unit test rollback

From: Pablo de Lara New ring PMD unit test requires extra EAL option (vdev), in order to pass, which I believe is incorrect, as this test should be focused on testing the API, without needing to pass any argument. Added again all functions that create all the ring devices necessary for the test,

[dpdk-dev] [PATCH] string: fix potential seg fault on snprintf

Hi Pablo, On 06/27/2014 02:13 PM, De Lara Guarch, Pablo wrote: > With last Thomas' patch, cmdline unit test does not pass due to this problem > (basically it tests this situation). > After test passed, by fixing this issue in several functions, I looked for > other places where this happened. I

[dpdk-dev] [PATCH] string: fix potential seg fault on snprintf

Hello Pablo, On 06/27/2014 01:04 PM, Pablo de Lara wrote: > From: Pablo de Lara > > Several functions did not check if destination buffer, used > in snprintf was a non-NULL pointer. Did you noticed any issue without this patch? It seems that all the get_help() cmdline functions are never called

[dpdk-dev] [PATCH] test: Ring PMD unit test rollback

On Fri, Jun 27, 2014 at 03:47:07PM +, De Lara Guarch, Pablo wrote: > Hi Neil, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > > Sent: Friday, June 27, 2014 4:03 PM > > To: De Lara Guarch, Pablo > > Cc: dev at dpdk.org > > Subject: Re:

[dpdk-dev] [PATCH] string: fix potential seg fault on snprintf

Hi Olivier > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier MATZ > Sent: Friday, June 27, 2014 12:30 PM > To: De Lara Guarch, Pablo; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] string: fix potential seg fault on snprintf > > Hello Pablo, > > On

[dpdk-dev] [PATCH] string: fix potential seg fault on snprintf

From: Pablo de Lara Several functions did not check if destination buffer, used in snprintf was a non-NULL pointer. Signed-off-by: Pablo de Lara --- examples/cmdline/parse_obj_list.c|3 +++ lib/librte_cmdline/cmdline_parse_etheraddr.c |3 +++ lib/librte_cmdline/cmdline_pars

[dpdk-dev] [PATCH] app/test: fix build switches to enable cmdline tests

There were 2 typos since these commits (in 1.6.0 releases): 21a7f4e264 fix build without librte_cmdline cac6d08c8b replace --use-device option by --pci-whitelist and --vdev In makefiles, the build options are prefixed with CONFIG_RTE_ but in .c file, it is only RTE_. These typos we

[dpdk-dev] [PATCH v10 5/5] bond: testpmd support

- Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- app/test-pmd/cmdline.c| 579

[dpdk-dev] [PATCH v10 4/5] bond: unit tests

Including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- app/test/Makefile |4 +- app/test/commands.c

[dpdk-dev] [PATCH v10 3/5] eal: support link bonding device initialization

Updating functionality in EAL to support adding link bonding devices via ?vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- lib/librte_eal/bsdapp/eal/eal.c |

[dpdk-dev] [PATCH v10 2/5] ethdev: add unique name to devices

Adding support to rte_eth_dev_data structure to support unique name identifier for ethdevs to support adding slave ethdevs (specifically virtual devices which have no public unique identifier) to a link bonding device. This changes the API rte_eth_dev_allocate() to require a const char *name when a

[dpdk-dev] [PATCH v10 1/5] bond: new link bonding library

Initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- config/common_bsdapp |5 + conf

[dpdk-dev] [PATCH v10 0/5] link bonding

Fixed copyright in link bonding library Makefile Declan Doherty (5): bond: new link bonding library ethdev: add unique name to devices eal: support link bonding device initialization bond: unit tests bond: testpmd support app/test-pmd/cmdline.c | 579 app/te

[dpdk-dev] [PATCH] test: Ring PMD unit test rollback

On Fri, Jun 27, 2014 at 03:46:39PM +0100, Pablo de Lara wrote: > From: Pablo de Lara > > New ring PMD unit test requires extra EAL option (vdev), > in order to pass, which I believe is incorrect, as this > test should be focused on testing the API, without needing > to pass any argument. > > Add

[dpdk-dev] [PATCH] app/test: fix build switches to enable cmdline tests

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, June 27, 2014 10:47 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] app/test: fix build switches to enable cmdline > tests > > There were 2 typos since these commits (in 1.

[dpdk-dev] Intel I350 | Jumbo Frame support | Segmentation fault

Hai all, When I try to send packets of sizes > 512 bytes (in a burst of 64), the program exits with a segmentation fault. I'm using Intel I350 1GbE card. Moreover if I try to enable jumbo frame support , it exits with an error saying 'Could not configure port1 (-22)' . Any help would be appreciat

[dpdk-dev] [dpdk-announce] release candidate 1.7.0-rc2

The second release candidate of version 1.7.0 can be downloaded here: http://dpdk.org/browse/dpdk/tag/?id=v1.7.0-rc2 Please test it. The release 1.7.0 should be ready in few days if things go well. You can check the log here: http://dpdk.org/browse/dpdk/log A short changelog will b

[dpdk-dev] [PATCH] dpdk_nic_bind: unbind ports that were erroneously bound

> When binding devices to a generic driver (i.e. one that doesn't have a > PCI ID table, some devices that are not bound to any other driver could > be bound even if no one has asked them to. hence, we check the list of > drivers again, and see if some of the previously-unbound devices were > erron

[dpdk-dev] [PATCH] dpdk_nic_bind: allow status query without igb_uio

> Allow the nic bind/unbind script to print out its status messages even > if the igb_uio driver is not loaded. For binding and unbinding NICs, the > behaviour is the same, and the igb_uio driver still needs to be loaded. > > Signed-off-by: Bruce richardson Acked-by: Thomas Monjalon Applied fo

[dpdk-dev] [PATCH 0/3] fix flow control in testpmd

2014-06-24 15:06, David Marchand: > Here is a patchset that addresses the problem reported by Jijiang Liu and > introduces "partial" commands for setting flow control parameters in > testpmd. > > By the way, I tried to factorise the code in testpmd when handling flow > control "commands" so that w

[dpdk-dev] [PATCH] eal: fix invalid memory read as reported by valgrind

2014-06-26 10:54, Aaron Campbell: > ==29880== Invalid read of size 1 > ==29880==at 0x56FF9A5: cpu_socket_id (eal_lcore.c:101) > ==29880==by 0x56FFAE9: rte_eal_cpu_init (eal_lcore.c:168) > ==29880==by 0x56F944A: rte_eal_init (eal.c:975) > > The problem is that endptr points to memory al

[dpdk-dev] [PATCH 1/2 v2] fix incorrect snprintf args

2014-06-24 11:14, Stephen Hemminger: > Now that snprintf is used, Gcc finds more uses of unsafe arguments. > Fix where found. Some of these may have already been fixed by > other patches on the mailing list. > > Signed-off-by: Stephen Hemminger It was already fixed by Bruce's patch: http

[dpdk-dev] [PATCH 1/2 v2] string: deprecate rte_snprintf

> The function rte_snprintf serves no useful purpose. It is the > same as snprintf() for all valid inputs. Deprecate it and > replace all uses in current code. > > Leave the tests for the deprecated function in place. > > Signed-off-by: Stephen Hemminger Acked-by: Thomas Monjalon Applied for

[dpdk-dev] [PATCH v3] EAL: fix usage of printf-like functions

> Mark the rte_log, cmdline_printf and rte_snprintf functions as > being printf-style functions. This causes compilation errors > due to mis-matched parameter types, so the parameter types are > fixed where appropriate. > > Changes in V2: > * Additional fixes for ivshmem-target compilation > > Ch

[dpdk-dev] [PATCH 0/2] minor compile fixes for FreeBSD 10

2014-06-24 01:23, Bruce Richardson: > These two small patches fix minor compilation issues found when testing > compilation on a FreeBSD 10 system. > > > Bruce Richardson (2): > mk: overriding CC also overrides HOSTCC > bsdapp: disable ACL library compilation Acked and applied for version 1.

[dpdk-dev] [PATCH v9 1/5] bond: new link bonding library

2014-06-27 01:57, Thomas Monjalon: > +SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += rte_eth_bond_vargs.c I forgot to rename the file here to rte_eth_bond_args.c. -- Thomas

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-26 13:20, Aaron Campbell: > On Jun 26, 2014, at 12:09 PM, Richardson, Bruce intel.com> wrote: > >> I agree we should try to use the "deprecated" attribute when possible. > >> So application porting effort will be smoother. > >> > >> But in this case, there is something different: as Step

[dpdk-dev] [PATCH v2] rte_ethdev: add link support flag

2014-06-20 15:06, Thomas Monjalon: > 2014-06-19 15:12, Stephen Hemminger: > > Only some devices support the link state interrupt configuration option. > > Link state control does not work in virtual drivers > > (virtio, vmxnet3, igbvf, and ixgbevf). Instead of having the application > > try and gue

[dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE

> The below commit requires stdio FILE structure. > > commit 591a9d7985c1230652d9f7ea1f9221e8c66ec188 > Author: Stephen Hemminger > Date: Fri May 2 16:42:56 2014 -0700 > > add FILE argument to debug functions > > Application which includes rte_memory.h without stdio.h will be hit > compil

[dpdk-dev] [PATCH] ethdev: read link state interrupt without link_update service

> > It is now possible to read link status updated by interrupt without > > having manual link_update() service provided by the PMD. > > Indeed link_update() is useless in interrupt case. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Olivier Matz Applied for version 1.7.0. -- Thomas

[dpdk-dev] [PATCH v9 5/5] bond: testpmd support

From: Declan Doherty - Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- app/test-pmd/c

[dpdk-dev] [PATCH v9 4/5] bond: unit tests

From: Declan Doherty Including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- app/test/Makefile |4 +- app

[dpdk-dev] [PATCH v9 3/5] eal: support link bonding device initialization

From: Declan Doherty Updating functionality in EAL to support adding link bonding devices via ?vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- lib/librte_eal/bsdapp/eal

[dpdk-dev] [PATCH v9 2/5] ethdev: add unique name to devices

From: Declan Doherty Adding support to rte_eth_dev_data structure to support unique name identifier for ethdevs to support adding slave ethdevs (specifically virtual devices which have no public unique identifier) to a link bonding device. This changes the API rte_eth_dev_allocate() to require a

[dpdk-dev] [PATCH v9 1/5] bond: new link bonding library

From: Declan Doherty Initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty Acked-by: Pablo de Lara --- config/common_bsdapp

[dpdk-dev] [PATCH v9 0/5] link bonding

Hi Declan, I've made some adjustments in your patches. * Some renaming: - RTE_PMD_BOND / PMD_BOND_KVARG -> PMD_BOND_NAME - rte_pmd_bond_init -> bond_init - rte_pmd_bond_drv -> bond_drv - rte_eth_bond_vargs.c -> rte_eth_bond_args.c * Some moves in doxygen configuration * Remov