Thanks a lot Jeff for your detailed explanation. I still have open question
left. I would be grateful if someone would share their insight on it.
I have performed experiments to vary both the MAX_BURST_SIZE (originally
set as 32) and BURST_TX_DRAIN_US (originally set as 100 usec) in l3fwd
main.c.
This v3 patch continues fixing some errors and warnings reported by
checkpatch.pl.
This patch supports multiple queues feature in DPDK based virtio-net frontend.
It firstly gets max queue number of virtio-net from virtio PCI configuration and
then send command to negotiate the queue number with b
On Mon, May 26, 2014 at 03:45:28PM +0800, Ouyang Changchun wrote:
> This patch v2 fixes some errors and warnings reported by checkpatch.pl.
>
> This patch series also contain the 3 items:
> 1. Add API to support setting TX rate for a queue or a VF.
> 2. Implement the functionality of setting TX r
On Sun, May 25, 2014 at 09:39:22PM +, Gilmore, Walter E wrote:
> Olivier you're making an assumption that customer application code running on
> the Intel DPDK isn't using the rte_ctrlmbuf structure.
> Remember there are more than 300 customers using the Intel DPDK and there is
> no way you
2014-05-23 12:08, Konstantin Ananyev:
> 1)If igb_alloc_rx_queue_mbufs() would fail to allocate an mbuf for RX queue,
> it calls igb_rx_queue_release(rxq).
> That causes rxq to be silently freed, without updating
> dev->data->rx_queues[]. So any firther reference to it will trigger the
> SIGSEGV.
>
> > Bug: When a timer is running
> >
> > - if rte_timer_stop is called, the pending decrement is
> > skipped (decremented only if the timer is pending) and due
> > to the update flag the future processing is skipped so the
> > timer is counted as pending while it is stopped. - the same
> >
2014-05-23 16:52, Olivier MATZ:
> > Bug: when a periodic timer's callback is running, if another
> > timer is manipulated, the periodic timer is not reloaded.
> > Solution: set the update flag only is the modified timer is
> > in RUNNING state
>
> Acked-by: Olivier Matz
Applied in version 1.7.
> > Bug fix in cmdline library to allow return on EOF as opposed to infinite
> > loop.
> >
> > Signed-off-by: Cristian Dumitrescu
>
> Acked-by: Olivier Matz
Applied for version 1.7.0 with title:
cmdline: fix infinite loop after EOF
Thanks
--
Thomas
On Fri, 9 May 2014 16:50:30 +0200
Olivier Matz wrote:
> The initial role of rte_ctrlmbuf is to carry generic messages (data
> pointer + data length) but it's not used by the DPDK or it applications.
> Keeping it implies:
> - loosing 1 byte in the rte_mbuf structure
> - having some dead code
I am also using the rte_ctrlmbuf to send messages between cores in one of the
Packet Framework sample apps that I am going to send as a patch tomorrow or
later this week.
Removing rte_ctrlmbuf would require additional rework to this (complex) sample
app. It can be done, but it is additional wor
Hi Cristian,
On 05/23/2014 05:32 PM, Olivier MATZ wrote:
> On 05/23/2014 05:21 PM, Cristian Dumitrescu wrote:
>> Bug fix in cmdline library to allow return on EOF as opposed to
>> infinite loop.
>>
>> Signed-off-by: Cristian Dumitrescu
>> ---
>> lib/librte_cmdline/cmdline.c |2 +-
>> 1 fil
Hi Konstantin,
On 05/26/2014 03:57 PM, Ananyev, Konstantin wrote:
> In most cases just a compiler barrier is enough, but there are few exceptions.
> Always using fence instructions - means introduce unnecessary slowdown for
> cases, when order is guaranteed.
> No using fences in cases, when they
This patch adds commands in testpmd to test the functionality of setting TX
rate for queue or VF.
Signed-off-by: Ouyang Changchun
---
app/test-pmd/cmdline.c | 159 -
app/test-pmd/config.c | 47 +++
app/test-pmd/testpmd.h | 3 +
3 f
This patch implements the functionality of setting TX rate for queue or VF in
IXGBE PMD.
Signed-off-by: Ouyang Changchun
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 122
lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 13 +++-
2 files changed, 132 insertions(+), 3 dele
This patch adds API to support setting TX rate for a queue and a VF.
Signed-off-by: Ouyang Changchun
---
lib/librte_ether/rte_ethdev.c | 71 +++
lib/librte_ether/rte_ethdev.h | 51 +++
2 files changed, 122 insertions(+)
diff --
This patch v2 fixes some errors and warnings reported by checkpatch.pl.
This patch series also contain the 3 items:
1. Add API to support setting TX rate for a queue or a VF.
2. Implement the functionality of setting TX rate for queue or VF in IXGBE PMD.
3. Add commands in testpmd to test the func
Hi Oliver,
>> I don't see any big changes in the v2 of that patch.
>>
>> At least both things that I have concerns about, stay unchanged in
>> the v2:
>>
>> 1) merge physaddr and buf_len in a bitfield - I still think we better
>> keep physaddr as 64bit field (PATCH 5).
>As nobody reacted
2014-05-26 20:53, Ouyang Changchun:
> This v3 patch continues fixing some errors and warnings reported by
> checkpatch.pl.
Thank you for cleaning code.
> This patch supports multiple queues feature in DPDK based virtio-net
Please do not mix cleaning and feature in the same patch.
It makes diffic
Hi Walt,
> The purpose of this structure is to send commands, events or any other type
> of information between user application tasks (normally from a manager
> task). It has been there since the beginning in the original design and
> it's up to the user to define what is in the data field and h
Hi Venky,
>> my testpmd iofwd test with the txqflags option disabling many mbuf
>> features is not representative of a real world application.
> [Venky] I did see your test reports. I also made the point that the
> tests we have are insufficient for testing the impact. If you look at
> data_ofs,
Hi Oliver,
>> So with the following fragment of code:
>> extern int *x;
>> extern __128i a, *p;
>> L0:
>> _mm_stream_si128( p, a);
>> rte_compiler_barrier();
>> L1:
>> *x = 0;
>>
>> There is no guarantee that store at L0 will always be finished
>> before store at L1.
>This code fragment looks v
From: Ivan Boule
Take avantage of the .set_mtu ethdev function and make it possible to configure
MTU on devices using testpmd.
Signed-off-by: Ivan Boule
Signed-off-by: David Marchand
---
app/test-pmd/cmdline.c | 54
app/test-pmd/config.c |
From: Ivan Boule
The support of jumbo frames in the ixgbevf Poll Mode Driver of 10GbE
82599 VF functions consists in the following enhancements:
- Implement the mtu_set function in the ixgbevf PMD, using the IXGBE_VF_SET_LPE
request of the version 1.0 of the VF/PF mailbox API for this purpose.
From: Samuel Gauthier
This patch adds two new functions in ethdev api to retrieve current MTU and
change MTU of a port.
These operations have been implemented for rte_em_pmd, rte_igb_pmd and
rte_ixgbe_pmd.
Signed-off-by: Samuel Gauthier
Signed-off-by: Ivan Boule
Signed-off-by: David Marchand
Add autoneg field in flow control parameters.
This makes it easier to understand why changing some parameters does not always
have the expected result.
Changing autoneg is not supported at the moment.
Signed-off-by: David Marchand
---
lib/librte_ether/rte_ethdev.h |1 +
lib/librte_pmd
From: Zijie Pan
This patch adds a new function in ethdev api to retrieve current flow control
configuration.
This operation has been implemented for rte_em_pmd, rte_igb_pmd and
rte_ixgbe_pmd.
Signed-off-by: Zijie Pan
Signed-off-by: David Marchand
---
lib/librte_ether/rte_ethdev.c | 16
This patchset introduces 3 new ethdev operations: flow control parameters
retrieval and mtu get/set operations.
--
David Marchand
David Marchand (1):
ethdev: add autoneg parameter in flow ctrl accessors
Ivan Boule (2):
ixgbe: add get/set_mtu to ixgbevf
app/testpmd: allow to configure mtu
27 matches
Mail list logo
