[dpdk-dev] [PATCH] eal: parse args before any kinds of init

2014-04-17 Thread Thomas Monjalon
Hi, 2014-04-15 11:03, Wang Sheng-Hui: > Parse args first, to resolve any invalid args and give out the usage string. > E.g './helloworld --invalid', the '--invalid' will be checked before any > init. After the options are checked, take any init actions. > > Signed-off-by: Wang Sheng-Hui [...] >

[dpdk-dev] [PATCH] kni: fix build with kernel 3.15

2014-04-17 Thread Thomas Monjalon
2014-04-14 16:50, Aaro Koskinen: > rxhash has been renamed to hash. In 3.14 and newer, we can use > skb_set_hash(). > > Signed-off-by: Aaro Koskinen Acked-by: Thomas Monjalon It's applied for version 1.6.0r2. Thanks -- Thomas

[dpdk-dev] rte_pktmbuf_alloc fails

2014-04-17 Thread Thomas Monjalon
Hi Konstantin, 2014-04-07 08:53, Ananyev, Konstantin: > Yep indeed, there is a bug in eth_pcap_tx() that can cause mbuf corruption. > I think it should be something like that instead: > > --- a/lib/librte_pmd_pcap/rte_eth_pcap.c > +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c > @@ -205,8 +205,9 @@ eth

[dpdk-dev] when create DMA space to NIC

2014-04-17 Thread 吕恩泳
HI ! When create NIC tx_desc in eth_igb_tx_queue_setup(), tx_desc was allocated by ring_dma_zone_reserve(). But when DMA speace was allocated by EAL(memzone)? eth_igb_tx_queue_setup()-->ring_dma_zone_reserve()-->memzone_lookup_thread_u nsafe()-->mcfg->memzone[] THANKS

[dpdk-dev] RES: RES: hw.nic_uio.bdfs

2014-04-17 Thread Thomas Monjalon
Hi Fred, 2014-03-26 04:22, Fred Pedrisa: > Here is my fix for probe code : > > static int > nic_uio_probe (device_t dev) > { > int i, len; > char *remaining; > long bus = 0, device = 0, function = 0; > remaining = bdf_str; > len = strlen(remaining); > >

[dpdk-dev] [PATCH 6/6] ivshmem: fix errors identified by hardening

2014-04-17 Thread Thomas Monjalon
2014-03-07 10:13, Stephen Hemminger: > Need to pass mode argument to open with O_CREAT. > Must check return value from ftruncate(). > > Signed-off-by: Stephen Hemminger Acked-by: Thomas Monjalon It's applied for version 1.6.0r2. Thanks -- Thomas

[dpdk-dev] [PATCH 1.6.1] don't inline rte_string_fns

2014-04-17 Thread Thomas Monjalon
Hi Stephen, This patch is still pending. Please send a v2. 2014-03-20 17:30, Thomas Monjalon: > Hi, > > I have some minor comments below. > > 27/02/2014 09:18, Stephen Hemminger : > > The function rte_snprintf() can never be inlined by Gcc. > > > > If compiled with -Winline it generates an erro

[dpdk-dev] [PATCH] mk: pass CROSS_COMPILE when compiling kernel modules

2014-04-17 Thread Thomas Monjalon
Hi, 2014-03-07 15:32, Aaro Koskinen: > On Tue, Feb 25, 2014 at 10:55:36PM +0100, Thomas Monjalon wrote: > > 07/02/2014 18:44, Aaro Koskinen : > > > Pass CROSS_COMPILE to the kernel build system when compiling kernel > > > modules. Although we export CC etc. the top level kernel Makefile will > > >

[dpdk-dev] Calling rte_eal_init multiple times in the same process

2014-04-17 Thread Thomas Monjalon
Hello, 2014-04-17 09:09, Tomas Vestelind: > The problem I'm facing is that I need to do rte_eal_init serveral times in > the same process. The reason for this is mostly architectural as we want to > divide certain functionality in to different, implementation independent, > modules in which DPDK w

[dpdk-dev] [PATCH 05/15 v3] ring: Convert to use of PMD_REGISTER_DRIVER and fix linking

2014-04-17 Thread Neil Horman
convert the ring driver to use the PMD_REGISTER_DRIVER macro and fix up the Makefile so that its linkage is only done if we are building static libraries. This means that the test applications now have no reference to the ring library when building DSO's and must specify its use on the command line

[dpdk-dev] build break on BSD

2014-04-17 Thread Olivier MATZ
Hi Neil, On 04/16/2014 09:52 PM, Neil Horman wrote: > I was just trying to do a build on bsd for dpdk and hit this: > > == Build lib/librte_eal/bsdapp/eal >CC eal.o > /root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c: In function ?eal_parse_args?: > /root/git/dpdk/lib/librte_eal/bsdapp/eal/e

[dpdk-dev] Build break on Ubuntu12.04

2014-04-17 Thread Olivier MATZ
Hi, On 04/17/2014 09:47 AM, ??? wrote: > cd $(OVS_DIR)/openvswitch > ./boot.sh > ./configure RTE_SDK=$(DPDK_DIR) > make > > I got following ERROR message. > > gcc -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith > -Wdeclaration-after-statement -Wformat-security -Wswitch-enum >

[dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro

2014-04-17 Thread Olivier MATZ
Hi Neil, On 04/16/2014 07:29 PM, Neil Horman wrote: > Ok, so look it up. DPDK is open source and cscope is easy to use. A > module initilization macro is a common method for doing init time binding in > modular programming (the best examples are the module_init() and module_exit() > macros in th

[dpdk-dev] [PATCH 05/15] ring: Convert to use of PMD_REGISTER_DRIVER and fix linking

2014-04-17 Thread Ananyev, Konstantin
Hi Neil, Few comments from me there. Thanks Konstantin - parse_kvlist(): 1) node = strchr(name, ':'); ... action = strchr(node, ':'); We can't expect that input parameter will always be valid. So need to check that strchr() doesn't return NULL. 2) if (strcmp(action, "ATTACH")) if (strc

[dpdk-dev] Calling rte_eal_init multiple times in the same process

2014-04-17 Thread Tomas Vestelind
Dear all, I'm not sure who to address with this email so I'll just present my problem and my suggested solution. The problem I'm facing is that I need to do rte_eal_init serveral times in the same process. The reason for this is mostly architectural as we want to divide certain functionality i

[dpdk-dev] Build break on Ubuntu12.04

2014-04-17 Thread 최강일
Hello, For DPDK 1.6.0, cd $(DPDK_DIR) make install T=x86_64-ivshmem-linuxapp-gcc => No Errors. However, for Openvswitch, cd $(OVS_DIR)/openvswitch ./boot.sh ./configure RTE_SDK=$(DPDK_DIR) make I got following ERROR message. gcc -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-a

[dpdk-dev] [PATCH 05/15] ring: Convert to use of PMD_REGISTER_DRIVER and fix linking

2014-04-17 Thread Neil Horman
On Thu, Apr 17, 2014 at 09:50:02AM +, Ananyev, Konstantin wrote: > Hi Neil, > Few comments from me there. > Thanks > Konstantin > > - parse_kvlist(): > > 1) > node = strchr(name, ':'); > ... > action = strchr(node, ':'); > > We can't expect that input parameter will always be valid. > So ne

[dpdk-dev] Calling rte_eal_init multiple times in the same process

2014-04-17 Thread Neil Horman
On Thu, Apr 17, 2014 at 09:09:44AM +, Tomas Vestelind wrote: > Dear all, > > I'm not sure who to address with this email so I'll just present my problem > and my suggested solution. > > The problem I'm facing is that I need to do rte_eal_init serveral times in > the same process. The reason

[dpdk-dev] [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro

2014-04-17 Thread Neil Horman
On Thu, Apr 17, 2014 at 10:08:29AM +0200, Olivier MATZ wrote: > Hi Neil, > > On 04/16/2014 07:29 PM, Neil Horman wrote: > >Ok, so look it up. DPDK is open source and cscope is easy to use. A > >module initilization macro is a common method for doing init time binding in > >modular programming (t