+1.
I checked:
[x] The download link is legal and the PGP signature are valid.
[x] The source code matches the current release version.
[x] The LICENSE and NOTICE files are correct.
On Tue, Mar 21, 2023 at 7:21 PM wudi <676366...@qq.com.invalid> wrote:
> Hi all,
>
> This is a call for the vote t
Hi,
+1(nonbinding)
I checked :
- LICENSE and NOTICE are fine
- All files have license headers if necessary.
- All links are valid
- Checksums and GPG signatures are valid.
- Build success on JDK11
--
Best wishes!
Calvin Kirs
On 2023/03/21 11:20:56 wudi wrote:
> Hi all,
>
> This is a call for
+1
On Tue, Mar 21, 2023 at 7:21 PM wudi <676366...@qq.com.invalid> wrote:
> Hi all,
>
> This is a call for the vote to release Apache Doris-Shade 1.0.0
>
> The git tag for the release:
> https://github.com/apache/doris-shade/releases/tag/doris-shade-1.0.0 <
> https://github.com/apache/doris-shade
Here is my +1(binding).
I checked:
[x] The download link is legal and the PGP signature are valid.
[x] The source code matches the current release version.
[x] The LICENSE and NOTICE files are correct.
Jiafeng.Zhang / 张家锋
Email: jiafengzh...@apache.org
Mingyu Chen 于2023年3月21日周二 20:47写道:
> +1 (
+1 (binding)
I would like to explain why we need this shade package for thrift.
Recently, the thrift version used by Doris has been upgraded from 0.13 to 0.16.
And there are some new interface of thrift being introduced since thrift 0.14,
such as `TBinaryProtocol.checkStringReadLength`.
But wh