Re: Checkstyle for Doris FE

2022-04-19 Thread ling miao
> We can use `checkstyle` directly instead of using IDE configuration The IDE should be installed plugin 'checkstyle' before import 'checkstyle.xml' vin jake 于2022年4月20日周三 12:09写道: > We can use `checkstyle` directly instead of using IDE configuration > > On Wed, Apr 20, 2022 at 11:05 AM ling mi

Re: Checkstyle for Doris FE

2022-04-19 Thread ling miao
> We can use `checkstyle` directly instead of using IDE configuration The IDE should be installed plugin 'checkstyle' before impo vin jake 于2022年4月20日周三 12:09写道: > We can use `checkstyle` directly instead of using IDE configuration > > On Wed, Apr 20, 2022 at 11:05 AM ling miao wrote: > > > >

Re: Checkstyle for Doris FE

2022-04-19 Thread vin jake
We can use `checkstyle` directly instead of using IDE configuration On Wed, Apr 20, 2022 at 11:05 AM ling miao wrote: > > Using the IDEA checkstyle plugin, this checkstyle will influence `5080 > items in 890 files`. > > I suggest you submit the checkstyle and **formatted fe code** together in >

Re: Checkstyle for Doris FE

2022-04-19 Thread ling miao
> Using the IDEA checkstyle plugin, this checkstyle will influence `5080 items in 890 files`. I suggest you submit the checkstyle and **formatted fe code** together in one PR. So as it can avoid the compilation problem caused by checkstyle. Secondly, is it possible to export the code format of ID

Checkstyle for Doris FE

2022-04-19 Thread vin jake
Hi everyone: For the situation of Doris Fe of lacking `format style`, I'm trying to fix this thing. I made a draft `checkstyle` in the PR link . I format the stable directory of FE with this style for reviewing. PR link

[GitHub] [incubator-doris] imay merged pull request #1353: Add Checkstyle for doris-fe

2019-06-21 Thread GitBox
imay merged pull request #1353: Add Checkstyle for doris-fe URL: https://github.com/apache/incubator-doris/pull/1353 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] DDDDDDouble opened a new pull request #1353: Add Checkstyle for doris-fe

2019-06-20 Thread GitBox
DDouble opened a new pull request #1353: Add Checkstyle for doris-fe URL: https://github.com/apache/incubator-doris/pull/1353 For https://github.com/apache/incubator-doris/issues/1345 This is an automated message from

[GitHub] [incubator-doris] imay commented on issue #1345: Add Checkstyle for doris-fe

2019-06-20 Thread GitBox
imay commented on issue #1345: Add Checkstyle for doris-fe URL: https://github.com/apache/incubator-doris/issues/1345#issuecomment-503986323 @DDouble Thanks for your proposal. For License header, I prefer second type. Because most of our code is forked from Apache Impala, who

[GitHub] [incubator-doris] DDDDDDouble opened a new issue #1345: Add Checkstyle for doris-fe

2019-06-20 Thread GitBox
DDouble opened a new issue #1345: Add Checkstyle for doris-fe URL: https://github.com/apache/incubator-doris/issues/1345 @imay HI, I want to add Checkstyle plugin to FE code to check the code style. I'm going to start with a simple check. First we need to discuss which par